codeclimate-services 1.6.1 → 1.7.0

data/lib/cc/services/flowdock.rb

@@ -7,14 +7,14 @@ class CC::Service::Flowdock < CC::Service
     validates :api_token, presence: true
   end
 
-  BASE_URL = "https://api.flowdock.com/v1"
+  BASE_URL = "https://api.flowdock.com/v1".freeze
   INVALID_PROJECT_CHARACTERS = /[^0-9a-z\-_ ]+/i
 
   self.description = "Send messages to a Flowdock inbox"
 
   def receive_test
     notify("Test", repo_name, formatter.format_test).merge(
-      message: "Test message sent"
+      message: "Test message sent",
     )
   end
 
@@ -37,7 +37,7 @@ class CC::Service::Flowdock < CC::Service
       self,
       prefix: "",
       prefix_with_repo: false,
-      link_style: :html
+      link_style: :html,
     )
   end
 
@@ -48,9 +48,9 @@ class CC::Service::Flowdock < CC::Service
       from_name:    "Code Climate",
       format:       "html",
       subject:      subject,
-      project:      project.gsub(INVALID_PROJECT_CHARACTERS, ''),
+      project:      project.gsub(INVALID_PROJECT_CHARACTERS, ""),
       content:      content,
-      link:         "https://codeclimate.com"
+      link:         "https://codeclimate.com",
     }
 
     url = "#{BASE_URL}/messages/team_inbox/#{config.api_token}"

data/lib/cc/services/github_issues.rb

@@ -24,7 +24,7 @@ class CC::Service::GitHubIssues < CC::Service
   def receive_test
     result = create_issue("Test ticket from Code Climate", "")
     result.merge(
-      message: "Issue <a href='#{result[:url]}'>##{result[:number]}</a> created."
+      message: "Issue <a href='#{result[:url]}'>##{result[:number]}</a> created.",
     )
   rescue CC::Service::HTTPError => e
     body = JSON.parse(e.response_body)
@@ -41,19 +41,19 @@ class CC::Service::GitHubIssues < CC::Service
 
     create_issue(
       formatter.format_vulnerability_title,
-      formatter.format_vulnerability_body
+      formatter.format_vulnerability_body,
     )
   end
 
   def receive_issue
-    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+    title = %(Fix "#{issue["check_name"]}" issue in #{constant_name})
 
     body = [issue["description"], details_url].join("\n\n")
 
     create_issue(title, body)
   end
 
-private
+  private
 
   def create_issue(title, issue_body)
     params = { title: title, body: issue_body }
@@ -67,14 +67,13 @@ private
     http.headers["User-Agent"] = "Code Climate"
 
     url = "#{config.base_url}/repos/#{config.project}/issues"
-    service_post(url, params.to_json) do |response|
+    service_post_with_redirects(url, params.to_json) do |response|
       body = JSON.parse(response.body)
       {
         id: body["id"],
         number: body["number"],
-        url: body["html_url"]
+        url: body["html_url"],
       }
     end
   end
-
 end

data/lib/cc/services/github_pull_requests.rb

@@ -13,6 +13,12 @@ class CC::Service::GitHubPullRequests < CC::PullRequests
       label: "Github Context",
       description: "The integration name next to the pull request status",
       default: "codeclimate"
+    attribute :rollout_usernames, Axiom::Types::String,
+      label: "Allowed Author's Usernames",
+      description: "The GitHub usernames of authors to report status for, comma separated"
+    attribute :rollout_percentage, Axiom::Types::Integer,
+      label: "Author Rollout Percentage",
+      description: "The percentage of users to report status for"
 
     validates :oauth_token, presence: true
   end
@@ -22,6 +28,37 @@ class CC::Service::GitHubPullRequests < CC::PullRequests
 
   private
 
+  def report_status?
+    if should_apply_rollout?
+      rollout_allowed_by_username? || rollout_allowed_by_percentage?
+    else
+      true
+    end
+  end
+
+  def should_apply_rollout?
+    (github_login.present? && config.rollout_usernames.present?) ||
+      (github_user_id.present? && config.rollout_percentage.present?)
+  end
+
+  def rollout_allowed_by_username?
+    github_login.present? && config.rollout_usernames.present? &&
+      config.rollout_usernames.split(",").map(&:strip).include?(github_login)
+  end
+
+  def rollout_allowed_by_percentage?
+    github_user_id.present? && config.rollout_percentage.present? &&
+      github_user_id % 100 < config.rollout_percentage
+  end
+
+  def github_login
+    @payload["github_login"]
+  end
+
+  def github_user_id
+    @payload["github_user_id"]
+  end
+
   def update_status_skipped
     update_status("success", presenter.skipped_message)
   end
@@ -41,21 +78,21 @@ class CC::Service::GitHubPullRequests < CC::PullRequests
   def update_status_error
     update_status(
       "error",
-      @payload["message"] || presenter.error_message
+      @payload["message"] || presenter.error_message,
     )
   end
 
   def update_status_pending
     update_status(
       "pending",
-      @payload["message"] || presenter.pending_message
+      @payload["message"] || presenter.pending_message,
     )
   end
 
   def setup_http
-    http.headers["Content-Type"]  = "application/json"
+    http.headers["Content-Type"] = "application/json"
     http.headers["Authorization"] = "token #{config.oauth_token}"
-    http.headers["User-Agent"]    = "Code Climate"
+    http.headers["User-Agent"] = "Code Climate"
   end
 
   def base_status_url(commit_sha)
@@ -67,7 +104,7 @@ class CC::Service::GitHubPullRequests < CC::PullRequests
   end
 
   def response_includes_repo_scope?(response)
-    response.headers['x-oauth-scopes'] && response.headers['x-oauth-scopes'].split(/\s*,\s*/).include?("repo")
+    response.headers["x-oauth-scopes"] && response.headers["x-oauth-scopes"].split(/\s*,\s*/).include?("repo")
   end
 
   def test_status_code

data/lib/cc/services/gitlab_merge_requests.rb

@@ -22,6 +22,10 @@ class CC::Service::GitlabMergeRequests < CC::PullRequests
 
   private
 
+  def report_status?
+    true
+  end
+
   def update_status_skipped
     update_status("success", presenter.skipped_message)
   end
@@ -41,14 +45,14 @@ class CC::Service::GitlabMergeRequests < CC::PullRequests
   def update_status_error
     update_status(
       "failed",
-      @payload["message"] || presenter.error_message
+      @payload["message"] || presenter.error_message,
     )
   end
 
   def update_status_pending
     update_status(
       "running",
-      @payload["message"] || presenter.pending_message
+      @payload["message"] || presenter.pending_message,
     )
   end
 

data/lib/cc/services/hipchat.rb

@@ -13,13 +13,13 @@ class CC::Service::HipChat < CC::Service
     validates :room_id, presence: true
   end
 
-  BASE_URL = "https://api.hipchat.com/v1"
+  BASE_URL = "https://api.hipchat.com/v1".freeze
 
   self.description = "Send messages to a HipChat chat room"
 
   def receive_test
     speak(formatter.format_test, "green").merge(
-      message: "Test message sent"
+      message: "Test message sent",
     )
   end
 
@@ -49,9 +49,8 @@ class CC::Service::HipChat < CC::Service
       auth_token: config.auth_token,
       room_id:    config.room_id,
       notify:     !!config.notify,
-      color:      color
+      color:      color,
     }
     service_post(url, params)
   end
-
 end

data/lib/cc/services/jira.rb

@@ -1,4 +1,4 @@
-require 'base64'
+require "base64"
 
 class CC::Service::Jira < CC::Service
   class Config < CC::Service::Config
@@ -35,7 +35,7 @@ class CC::Service::Jira < CC::Service
   def receive_test
     result = create_ticket("Test ticket from Code Climate", "Test ticket from Code Climate")
     result.merge(
-      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created."
+      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created.",
     )
   end
 
@@ -44,7 +44,7 @@ class CC::Service::Jira < CC::Service
   end
 
   def receive_issue
-    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+    title = %(Fix "#{issue["check_name"]}" issue in #{constant_name})
 
     body = [issue["description"], details_url].join("\n\n")
 
@@ -56,11 +56,11 @@ class CC::Service::Jira < CC::Service
 
     create_ticket(
       formatter.format_vulnerability_title,
-      formatter.format_vulnerability_body
+      formatter.format_vulnerability_body,
     )
   end
 
-private
+  private
 
   def create_ticket(title, ticket_body)
     params = {
@@ -69,8 +69,8 @@ private
           project: { id: config.project_id },
           summary: title,
           description: ticket_body,
-          issuetype: { name: config.issue_type }
-        }
+          issuetype: { name: config.issue_type },
+        },
     }
 
     if config.labels.present?
@@ -87,9 +87,8 @@ private
       {
         id: body["id"],
         key: body["key"],
-        url: "https://#{config.domain}/browse/#{body["key"]}"
+        url: "https://#{config.domain}/browse/#{body["key"]}",
       }
     end
   end
-
 end

data/lib/cc/services/lighthouse.rb

@@ -25,7 +25,7 @@ class CC::Service::Lighthouse < CC::Service
   def receive_test
     result = create_ticket("Test ticket from Code Climate", "")
     result.merge(
-      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created."
+      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created.",
     )
   end
 
@@ -34,7 +34,7 @@ class CC::Service::Lighthouse < CC::Service
   end
 
   def receive_issue
-    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+    title = %(Fix "#{issue["check_name"]}" issue in #{constant_name})
 
     body = [issue["description"], details_url].join("\n\n")
 
@@ -46,11 +46,11 @@ class CC::Service::Lighthouse < CC::Service
 
     create_ticket(
       formatter.format_vulnerability_title,
-      formatter.format_vulnerability_body
+      formatter.format_vulnerability_body,
     )
   end
 
-private
+  private
 
   def create_ticket(title, ticket_body)
     params = { ticket: { title: title, body: ticket_body } }
@@ -73,5 +73,4 @@ private
       }
     end
   end
-
 end

data/lib/cc/services/pivotal_tracker.rb

@@ -18,12 +18,12 @@ class CC::Service::PivotalTracker < CC::Service
   self.description = "Create stories on Pivotal Tracker"
   self.issue_tracker = true
 
-  BASE_URL = "https://www.pivotaltracker.com/services/v3"
+  BASE_URL = "https://www.pivotaltracker.com/services/v3".freeze
 
   def receive_test
     result = create_story("Test ticket from Code Climate", "")
     result.merge(
-      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created."
+      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created.",
     )
   end
 
@@ -32,7 +32,7 @@ class CC::Service::PivotalTracker < CC::Service
   end
 
   def receive_issue
-    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+    title = %(Fix "#{issue["check_name"]}" issue in #{constant_name})
 
     body = [issue["description"], details_url].join("\n\n")
 
@@ -44,11 +44,11 @@ class CC::Service::PivotalTracker < CC::Service
 
     create_story(
       formatter.format_vulnerability_title,
-      formatter.format_vulnerability_body
+      formatter.format_vulnerability_body,
     )
   end
 
-private
+  private
 
   def create_story(name, description)
     params = {
@@ -68,9 +68,8 @@ private
       body = Nokogiri::XML(response.body)
       {
         id: (body / "story/id").text,
-        url: (body / "story/url").text
+        url: (body / "story/url").text,
       }
     end
   end
-
 end

data/lib/cc/services/slack.rb

@@ -1,4 +1,4 @@
- # encoding: UTF-8
+# encoding: UTF-8
 
 class CC::Service::Slack < CC::Service
   include CC::Service::QualityHelper
@@ -18,7 +18,7 @@ class CC::Service::Slack < CC::Service
     # payloads for test receivers include the weekly quality report.
     send_snapshot_to_slack(CC::Formatters::SnapshotFormatter::Sample.new(payload))
     speak(formatter.format_test).merge(
-      message: "Test message sent"
+      message: "Test message sent",
     )
   end
 
@@ -45,20 +45,20 @@ class CC::Service::Slack < CC::Service
       color: color,
       fallback: message,
       fields: [{ value: message }],
-      mrkdwn_in: ["fields", "fallback"]
-    }]}
+      mrkdwn_in: %w[fields fallback],
+    }] }
 
     if config.channel
       params[:channel] = config.channel
     end
 
-    http.headers['Content-Type']  = 'application/json'
+    http.headers["Content-Type"] = "application/json"
     url = config.webhook_url
 
     service_post(url, params.to_json) do |response|
       {
         ok: response.body == "ok",
-        message: response.body
+        message: response.body,
       }
     end
   end
@@ -88,7 +88,7 @@ class CC::Service::Slack < CC::Service
 
       if constant["from"]
         from_rating = constant["from"]["rating"]
-        to_rating   = constant["to"]["rating"]
+        to_rating = constant["to"]["rating"]
 
         message << "• _#{object_identifier}_ just declined from #{with_article(from_rating, :bold)} to #{with_article(to_rating, :bold)}"
       else
@@ -113,7 +113,7 @@ class CC::Service::Slack < CC::Service
     constants[0..2].each do |constant|
       object_identifier = constant_basename(constant["name"])
       from_rating = constant["from"]["rating"]
-      to_rating   = constant["to"]["rating"]
+      to_rating = constant["to"]["rating"]
 
       message << "• _#{object_identifier}_ just improved from #{with_article(from_rating, :bold)} to #{with_article(to_rating, :bold)}"
     end

data/lib/cc/services/stash_pull_requests.rb

@@ -81,9 +81,9 @@ class CC::Service::StashPullRequests < CC::Service
   end
 
   def setup_http
-    http.headers["Content-Type"]  = "application/json"
+    http.headers["Content-Type"] = "application/json"
     http.headers["Authorization"] = "Basic #{auth_token}"
-    http.headers["User-Agent"]    = "Code Climate"
+    http.headers["User-Agent"] = "Code Climate"
   end
 
   # Following Basic Auth headers here:

data/lib/cc/services/version.rb

@@ -1,5 +1,5 @@
 module CC
   module Services
-    VERSION = "1.6.1"
+    VERSION = "1.7.0".freeze
   end
 end