codeclimate-services 1.6.1 → 1.7.0

data/{test/jira_test.rb → spec/cc/service/jira_spec.rb}

@@ -1,70 +1,68 @@
-require File.expand_path('../helper', __FILE__)
-
-class TestJira < CC::Service::TestCase
-  def test_successful_receive
+describe CC::Service::Jira, type: :service do
+  it "successful receive" do
     response = assert_jira_receives(
       event(:quality, to: "D", from: "C"),
       "Refactor User from a D on Code Climate",
-      "https://codeclimate.com/repos/1/feed"
+      "https://codeclimate.com/repos/1/feed",
     )
-    assert_equal "10000", response[:id]
+    expect(response[:id]).to eq("10000")
   end
 
-  def test_quality
+  it "quality" do
     assert_jira_receives(
       event(:quality, to: "D", from: "C"),
       "Refactor User from a D on Code Climate",
-      "https://codeclimate.com/repos/1/feed"
+      "https://codeclimate.com/repos/1/feed",
     )
   end
 
-  def test_vulnerability
+  it "vulnerability" do
     assert_jira_receives(
       event(:vulnerability, vulnerabilities: [{
-        "warning_type" => "critical",
-        "location" => "app/user.rb line 120"
-      }]),
+              "warning_type" => "critical",
+              "location" => "app/user.rb line 120",
+            }]),
       "New critical issue found in app/user.rb line 120",
-      "A critical vulnerability was found by Code Climate in app/user.rb line 120.\n\nhttps://codeclimate.com/repos/1/feed"
+      "A critical vulnerability was found by Code Climate in app/user.rb line 120.\n\nhttps://codeclimate.com/repos/1/feed",
     )
   end
 
-  def test_issue
+  it "issue" do
     payload = {
       issue: {
         "check_name" => "Style/LongLine",
-        "description" => "Line is too long [1000/80]"
+        "description" => "Line is too long [1000/80]",
       },
       constant_name: "foo.rb",
-      details_url: "http://example.com/repos/id/foo.rb#issue_123"
+      details_url: "http://example.com/repos/id/foo.rb#issue_123",
     }
 
     assert_jira_receives(
       event(:issue, payload),
       "Fix \"Style/LongLine\" issue in foo.rb",
-      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123"
+      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123",
     )
   end
 
-  def test_receive_test
-    @stubs.post '/rest/api/2/issue' do |env|
+  it "receive test" do
+    http_stubs.post "/rest/api/2/issue" do |_env|
       [200, {}, '{"id": 12345, "key": "CC-123", "self": "http://foo.bar"}']
     end
 
     response = receive_event(name: "test")
 
-    assert_equal "Ticket <a href='https://foo.com/browse/CC-123'>12345</a> created.", response[:message]
+    expect(response[:message]).to eq("Ticket <a href='https://foo.com/browse/CC-123'>12345</a> created.")
   end
 
   private
 
   def assert_jira_receives(event_data, title, ticket_body)
-    @stubs.post '/rest/api/2/issue' do |env|
+    http_stubs.post "/rest/api/2/issue" do |env|
       body = JSON.parse(env[:body])
-      assert_equal "Basic Zm9vOmJhcg==", env[:request_headers]["Authorization"]
-      assert_equal title, body["fields"]["summary"]
-      assert_equal ticket_body, body["fields"]["description"]
-      assert_equal "Task", body["fields"]["issuetype"]["name"]
+      expect(env[:request_headers]["Authorization"]).to eq("Basic Zm9vOmJhcg==")
+      expect(body["fields"]["summary"]).to eq(title)
+      expect(body["fields"]["description"]).to eq(ticket_body)
+      expect(body["fields"]["issuetype"]["name"]).to eq("Task")
       [200, {}, '{"id":"10000"}']
     end
 
@@ -72,10 +70,10 @@ class TestJira < CC::Service::TestCase
   end
 
   def receive_event(event_data = nil)
-    receive(
+    service_receive(
       CC::Service::Jira,
       { domain: "foo.com", username: "foo", password: "bar", project_id: "100" },
-      event_data || event(:quality, from: "C", to: "D")
+      event_data || event(:quality, from: "C", to: "D"),
     )
   end
 end

data/{test/lighthouse_test.rb → spec/cc/service/lighthouse_spec.rb}

@@ -1,63 +1,60 @@
-require File.expand_path('../helper', __FILE__)
-
-class TestLighthouse < CC::Service::TestCase
-  def test_quality
+describe CC::Service::Lighthouse, type: :service do
+  it "quality" do
     response = assert_lighthouse_receives(
       event(:quality, to: "D", from: "C"),
       "Refactor User from a D on Code Climate",
-      "https://codeclimate.com/repos/1/feed"
+      "https://codeclimate.com/repos/1/feed",
     )
-    assert_equal "123", response[:id]
-    assert_equal "http://lighthouse.com/projects/123/tickets/123.json",
-      response[:url]
+    expect(response[:id]).to eq("123")
+    expect("http://lighthouse.com/projects/123/tickets/123.json").to eq(response[:url])
   end
 
-  def test_vulnerability
+  it "vulnerability" do
     assert_lighthouse_receives(
       event(:vulnerability, vulnerabilities: [{
-        "warning_type" => "critical",
-        "location" => "app/user.rb line 120"
-      }]),
+              "warning_type" => "critical",
+              "location" => "app/user.rb line 120",
+            }]),
       "New critical issue found in app/user.rb line 120",
-      "A critical vulnerability was found by Code Climate in app/user.rb line 120.\n\nhttps://codeclimate.com/repos/1/feed"
+      "A critical vulnerability was found by Code Climate in app/user.rb line 120.\n\nhttps://codeclimate.com/repos/1/feed",
     )
   end
 
-  def test_issue
+  it "issue" do
     payload = {
       issue: {
         "check_name" => "Style/LongLine",
-        "description" => "Line is too long [1000/80]"
+        "description" => "Line is too long [1000/80]",
       },
       constant_name: "foo.rb",
-      details_url: "http://example.com/repos/id/foo.rb#issue_123"
+      details_url: "http://example.com/repos/id/foo.rb#issue_123",
     }
 
     assert_lighthouse_receives(
       event(:issue, payload),
       "Fix \"Style/LongLine\" issue in foo.rb",
-      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123"
+      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123",
     )
   end
 
-  def test_receive_test
-    @stubs.post 'projects/123/tickets.json' do |env|
+  it "receive test" do
+    http_stubs.post "projects/123/tickets.json" do |_env|
       [200, {}, '{"ticket":{"number": "123", "url":"http://foo.bar"}}']
     end
 
     response = receive_event(name: "test")
 
-    assert_equal "Ticket <a href='http://foo.bar'>123</a> created.", response[:message]
+    expect(response[:message]).to eq("Ticket <a href='http://foo.bar'>123</a> created.")
   end
 
   private
 
   def assert_lighthouse_receives(event_data, title, ticket_body)
-    @stubs.post 'projects/123/tickets.json' do |env|
+    http_stubs.post "projects/123/tickets.json" do |env|
       body = JSON.parse(env[:body])
-      assert_equal "token", env[:request_headers]["X-LighthouseToken"]
-      assert_equal title, body["ticket"]["title"]
-      assert_equal ticket_body, body["ticket"]["body"]
+      expect(env[:request_headers]["X-LighthouseToken"]).to eq("token")
+      expect(body["ticket"]["title"]).to eq(title)
+      expect(body["ticket"]["body"]).to eq(ticket_body)
       [200, {}, '{"ticket":{"number": "123", "url":"http://lighthouse.com/projects/123/tickets/123.json"}}']
     end
 
@@ -65,10 +62,10 @@ class TestLighthouse < CC::Service::TestCase
   end
 
   def receive_event(event_data = nil)
-    receive(
+    service_receive(
       CC::Service::Lighthouse,
       { subdomain: "foo", api_token: "token", project_id: "123" },
-      event_data || event(:quality, from: "C", to: "D")
+      event_data || event(:quality, from: "C", to: "D"),
     )
   end
 end

data/spec/cc/service/pivotal_tracker_spec.rb

@@ -0,0 +1,70 @@
+describe CC::Service::PivotalTracker, type: :service do
+  it "quality" do
+    response = assert_pivotal_receives(
+      event(:quality, to: "D", from: "C"),
+      "Refactor User from a D on Code Climate",
+      "https://codeclimate.com/repos/1/feed",
+    )
+    expect(response[:id]).to eq("123")
+    expect("http://pivotaltracker.com/n/projects/123/stories/123").to eq(response[:url])
+  end
+
+  it "vulnerability" do
+    assert_pivotal_receives(
+      event(:vulnerability, vulnerabilities: [{
+              "warning_type" => "critical",
+              "location" => "app/user.rb line 120",
+            }]),
+      "New critical issue found in app/user.rb line 120",
+      "A critical vulnerability was found by Code Climate in app/user.rb line 120.\n\nhttps://codeclimate.com/repos/1/feed",
+    )
+  end
+
+  it "issue" do
+    payload = {
+      issue: {
+        "check_name" => "Style/LongLine",
+        "description" => "Line is too long [1000/80]",
+      },
+      constant_name: "foo.rb",
+      details_url: "http://example.com/repos/id/foo.rb#issue_123",
+    }
+
+    assert_pivotal_receives(
+      event(:issue, payload),
+      "Fix \"Style/LongLine\" issue in foo.rb",
+      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123",
+    )
+  end
+
+  it "receive test" do
+    http_stubs.post "services/v3/projects/123/stories" do |_env|
+      [200, {}, "<story><id>123</id><url>http://foo.bar</url></story>"]
+    end
+
+    response = receive_event(name: "test")
+
+    expect(response[:message]).to eq("Ticket <a href='http://foo.bar'>123</a> created.")
+  end
+
+  private
+
+  def assert_pivotal_receives(event_data, name, description)
+    http_stubs.post "services/v3/projects/123/stories" do |env|
+      body = Hash[URI.decode_www_form(env[:body])]
+      expect(env[:request_headers]["X-TrackerToken"]).to eq("token")
+      expect(body["story[name]"]).to eq(name)
+      expect(body["story[description]"]).to eq(description)
+      [200, {}, "<doc><story><id>123</id><url>http://pivotaltracker.com/n/projects/123/stories/123</url></story></doc>"]
+    end
+    receive_event(event_data)
+  end
+
+  def receive_event(event_data = nil)
+    service_receive(
+      CC::Service::PivotalTracker,
+      { api_token: "token", project_id: "123" },
+      event_data || event(:quality, from: "C", to: "D"),
+    )
+  end
+end

data/{test/slack_test.rb → spec/cc/service/slack_spec.rb}

@@ -1,42 +1,38 @@
-# encoding: UTF-8
-
-require File.expand_path('../helper', __FILE__)
-
-class TestSlack < CC::Service::TestCase
-  def test_test_hook
+describe CC::Service::Slack, type: :service do
+  it "test hook" do
     assert_slack_receives(
       nil,
       { name: "test", repo_name: "rails" },
-      "[rails] This is a test of the Slack service hook"
+      "[rails] This is a test of the Slack service hook",
     )
   end
 
-  def test_coverage_improved
+  it "coverage improved" do
     e = event(:coverage, to: 90.2, from: 80)
 
     assert_slack_receives("#38ae6f", e, [
       "[Example]",
       "<https://codeclimate.com/repos/1/feed|Test coverage>",
       "has improved to 90.2% (+10.2%)",
-      "(<https://codeclimate.com/repos/1/compare|Compare>)"
+      "(<https://codeclimate.com/repos/1/compare|Compare>)",
     ].join(" "))
   end
 
-  def test_coverage_declined
+  it "coverage declined" do
     e = event(:coverage, to: 88.6, from: 94.6)
 
     assert_slack_receives("#ed2f00", e, [
       "[Example]",
       "<https://codeclimate.com/repos/1/feed|Test coverage>",
       "has declined to 88.6% (-6.0%)",
-      "(<https://codeclimate.com/repos/1/compare|Compare>)"
+      "(<https://codeclimate.com/repos/1/compare|Compare>)",
     ].join(" "))
   end
 
-  def test_single_vulnerability
+  it "single vulnerability" do
     e = event(:vulnerability, vulnerabilities: [
-      { "warning_type" => "critical" }
-    ])
+                { "warning_type" => "critical" },
+              ])
 
     assert_slack_receives(nil, e, [
       "[Example]",
@@ -45,11 +41,11 @@ class TestSlack < CC::Service::TestCase
     ].join(" "))
   end
 
-  def test_single_vulnerability_with_location
+  it "single vulnerability with location" do
     e = event(:vulnerability, vulnerabilities: [{
-      "warning_type" => "critical",
-      "location" => "app/user.rb line 120"
-    }])
+                "warning_type" => "critical",
+                "location" => "app/user.rb line 120",
+              }])
 
     assert_slack_receives(nil, e, [
       "[Example]",
@@ -58,14 +54,14 @@ class TestSlack < CC::Service::TestCase
     ].join(" "))
   end
 
-  def test_multiple_vulnerabilities
+  it "multiple vulnerabilities" do
     e = event(:vulnerability, warning_type: "critical", vulnerabilities: [{
-      "warning_type" => "unused",
-      "location" => "unused"
-    }, {
-      "warning_type" => "unused",
-      "location" => "unused"
-    }])
+                "warning_type" => "unused",
+                "location" => "unused",
+              }, {
+                "warning_type" => "unused",
+                "location" => "unused",
+              }])
 
     assert_slack_receives(nil, e, [
       "[Example]",
@@ -74,49 +70,47 @@ class TestSlack < CC::Service::TestCase
     ].join(" "))
   end
 
-  def test_quality_alert_with_new_constants
+  it "quality alert with new constants" do
     data = { "name" => "snapshot", "repo_name" => "Rails",
-             "new_constants" => [{"name" => "Foo", "to" => {"rating" => "D"}}, {"name" => "bar.js", "to" => {"rating" => "F"}}],
+             "new_constants" => [{ "name" => "Foo", "to" => { "rating" => "D" } }, { "name" => "bar.js", "to" => { "rating" => "F" } }],
              "changed_constants" => [],
              "compare_url" => "https://codeclimate.com/repos/1/compare/a...z" }
 
     response = assert_slack_receives(CC::Service::Slack::RED_HEX, data,
-"""Quality alert triggered for *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
+      """Quality alert triggered for *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
 
 • _Foo_ was just created and is a *D*
 • _bar.js_ was just created and is an *F*""")
 
-    assert response[:ok]
+    expect(response[:ok]).to eq(true)
   end
 
-  def test_quality_alert_with_new_constants_and_declined_constants
+  it "quality alert with new constants and declined constants" do
     data = { "name" => "snapshot", "repo_name" => "Rails",
-             "new_constants" => [{"name" => "Foo", "to" => {"rating" => "D"}}],
-             "changed_constants" => [{"name" => "bar.js", "from" => {"rating" => "A"}, "to" => {"rating" => "F"}}],
+             "new_constants" => [{ "name" => "Foo", "to" => { "rating" => "D" } }],
+             "changed_constants" => [{ "name" => "bar.js", "from" => { "rating" => "A" }, "to" => { "rating" => "F" } }],
              "compare_url" => "https://codeclimate.com/repos/1/compare/a...z" }
 
     assert_slack_receives(CC::Service::Slack::RED_HEX, data,
-"""Quality alert triggered for *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
+      """Quality alert triggered for *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
 
 • _Foo_ was just created and is a *D*
 • _bar.js_ just declined from an *A* to an *F*""")
   end
 
-  def test_quality_alert_with_new_constants_and_declined_constants_overflown
+  it "quality alert with new constants and declined constants overflown" do
     data = { "name" => "snapshot", "repo_name" => "Rails",
-             "new_constants" => [{"name" => "Foo", "to" => {"rating" => "D"}}],
+             "new_constants" => [{ "name" => "Foo", "to" => { "rating" => "D" } }],
              "changed_constants" => [
-               {"name" => "bar.js", "from" => {"rating" => "A"}, "to" => {"rating" => "F"}},
-               {"name" => "baz.js", "from" => {"rating" => "B"}, "to" => {"rating" => "D"}},
-               {"name" => "Qux",    "from" => {"rating" => "A"}, "to" => {"rating" => "D"}}
+               { "name" => "bar.js", "from" => { "rating" => "A" }, "to" => { "rating" => "F" } },
+               { "name" => "baz.js", "from" => { "rating" => "B" }, "to" => { "rating" => "D" } },
+               { "name" => "Qux", "from" => { "rating" => "A" }, "to" => { "rating" => "D" } },
              ],
              "compare_url" => "https://codeclimate.com/repos/1/compare/a...z",
-             "details_url" => "https://codeclimate.com/repos/1/feed"
-    }
-
+             "details_url" => "https://codeclimate.com/repos/1/feed" }
 
     assert_slack_receives(CC::Service::Slack::RED_HEX, data,
-"""Quality alert triggered for *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
+      """Quality alert triggered for *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
 
 • _Foo_ was just created and is a *D*
 • _bar.js_ just declined from an *A* to an *F*
@@ -125,39 +119,35 @@ class TestSlack < CC::Service::TestCase
 And <https://codeclimate.com/repos/1/feed|1 other change>""")
   end
 
-  def test_quality_improvements
+  it "quality improvements" do
     data = { "name" => "snapshot", "repo_name" => "Rails",
              "new_constants" => [],
              "changed_constants" => [
-               {"name" => "bar.js", "from" => {"rating" => "F"}, "to" => {"rating" => "A"}},
+               { "name" => "bar.js", "from" => { "rating" => "F" }, "to" => { "rating" => "A" } },
              ],
              "compare_url" => "https://codeclimate.com/repos/1/compare/a...z",
-             "details_url" => "https://codeclimate.com/repos/1/feed"
-    }
-
+             "details_url" => "https://codeclimate.com/repos/1/feed" }
 
     assert_slack_receives(CC::Service::Slack::GREEN_HEX, data,
-"""Quality improvements in *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
+      """Quality improvements in *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
 
 • _bar.js_ just improved from an *F* to an *A*""")
   end
 
-  def test_quality_improvements_overflown
+  it "quality improvements overflown" do
     data = { "name" => "snapshot", "repo_name" => "Rails",
              "new_constants" => [],
              "changed_constants" => [
-               {"name" => "Foo",    "from" => {"rating" => "F"}, "to" => {"rating" => "A"}},
-               {"name" => "bar.js", "from" => {"rating" => "D"}, "to" => {"rating" => "B"}},
-               {"name" => "baz.js", "from" => {"rating" => "D"}, "to" => {"rating" => "A"}},
-               {"name" => "Qux",    "from" => {"rating" => "F"}, "to" => {"rating" => "A"}},
+               { "name" => "Foo", "from" => { "rating" => "F" }, "to" => { "rating" => "A" } },
+               { "name" => "bar.js", "from" => { "rating" => "D" }, "to" => { "rating" => "B" } },
+               { "name" => "baz.js", "from" => { "rating" => "D" }, "to" => { "rating" => "A" } },
+               { "name" => "Qux", "from" => { "rating" => "F" }, "to" => { "rating" => "A" } },
              ],
              "compare_url" => "https://codeclimate.com/repos/1/compare/a...z",
-             "details_url" => "https://codeclimate.com/repos/1/feed"
-    }
-
+             "details_url" => "https://codeclimate.com/repos/1/feed" }
 
     assert_slack_receives(CC::Service::Slack::GREEN_HEX, data,
-"""Quality improvements in *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
+      """Quality improvements in *Rails* (<https://codeclimate.com/repos/1/compare/a...z|Compare>)
 
 • _Foo_ just improved from an *F* to an *A*
 • _bar.js_ just improved from a *D* to a *B*
@@ -166,57 +156,56 @@ And <https://codeclimate.com/repos/1/feed|1 other change>""")
 And <https://codeclimate.com/repos/1/feed|1 other improvement>""")
   end
 
-  def test_received_success
+  it "received success" do
     response = assert_slack_receives(
       nil,
       { name: "test", repo_name: "rails" },
-      "[rails] This is a test of the Slack service hook"
+      "[rails] This is a test of the Slack service hook",
     )
-    assert_true response[:ok]
-    assert_equal "Test message sent", response[:message]
+    expect(response[:ok]).to eq(true)
+    expect(response[:message]).to eq("Test message sent")
   end
 
-  def test_receive_test
-    @stubs.post '/token' do |env|
-      [200, {}, 'ok']
+  it "receive test" do
+    http_stubs.post "/token" do |_env|
+      [200, {}, "ok"]
     end
 
     response = receive_event(name: "test")
 
-    assert_equal "Test message sent", response[:message]
+    expect(response[:message]).to eq("Test message sent")
   end
 
-  def test_no_changes_in_snapshot
+  it "no changes in snapshot" do
     data = { "name" => "snapshot", "repo_name" => "Rails",
              "new_constants" => [],
-             "changed_constants" => [],
-    }
+             "changed_constants" => [] }
     response = receive_event(data)
 
-    assert_equal false, response[:ok]
-    assert response[:ignored]
+    expect(response[:ok]).to eq(false)
+    expect(response[:ignored]).to eq(true)
   end
 
   private
 
   def assert_slack_receives(color, event_data, expected_body)
-    @stubs.post '/token' do |env|
+    http_stubs.post "/token" do |env|
       body = JSON.parse(env[:body])
       attachment = body["attachments"].first
       field = attachment["fields"].first
-      assert_equal color, attachment["color"] # may be nil
-      assert_equal expected_body, attachment["fallback"]
-      assert_equal expected_body, field["value"]
-      [200, {}, 'ok']
+      attachment["color"] # may be expect(nil).to eq(color)
+      expect(attachment["fallback"]).to eq(expected_body)
+      expect(field["value"]).to eq(expected_body)
+      [200, {}, "ok"]
     end
     receive_event(event_data)
   end
 
   def receive_event(event_data = nil)
-    receive(
+    service_receive(
       CC::Service::Slack,
       { webhook_url: "http://api.slack.com/token", channel: "#general" },
-      event_data || event(:quality, from: "C", to: "D")
+      event_data || event(:quality, from: "C", to: "D"),
     )
   end
 end