codeclimate-services 1.6.1 → 1.7.0

data/lib/cc/helpers/vulnerability_helper.rb

@@ -1,5 +1,4 @@
 module CC::Service::VulnerabilityHelper
-
   def vulnerability
     vulnerabilities.first || {}
   end
@@ -27,5 +26,4 @@ module CC::Service::VulnerabilityHelper
       vulnerability["warning_type"]
     end
   end
-
 end

data/lib/cc/presenters/pull_requests_presenter.rb

@@ -47,7 +47,7 @@ module CC
         end
       end
 
-    private
+      private
 
       def both_issue_counts_zero?
         issue_counts.all?(&:zero?)
@@ -56,16 +56,12 @@ module CC
       def formatted_fixed_issues
         if @fixed_count > 0
           "#{number_to_delimited(@fixed_count)} fixed #{"issue".pluralize(@fixed_count)}"
-        else
-          nil
         end
       end
 
       def formatted_new_issues
         if @new_count > 0
           "#{number_to_delimited(@new_count)} new #{"issue".pluralize(@new_count)}"
-        else
-          nil
         end
       end
 

data/lib/cc/pull_requests.rb

@@ -9,7 +9,7 @@ class CC::PullRequests < CC::Service
     setup_http
     state = @payload["state"]
 
-    if %w[pending success failure skipped error].include?(state)
+    if %w[pending success failure skipped error].include?(state) && report_status?
       send("update_status_#{state}")
     else
       @response = simple_failure("Unknown state")
@@ -22,7 +22,7 @@ class CC::PullRequests < CC::Service
     setup_http
     state = @payload["state"]
 
-    if state == "success"
+    if state == "success" && report_status?
       update_coverage_status_success
     else
       @response = simple_failure("Unknown state")
@@ -33,6 +33,10 @@ class CC::PullRequests < CC::Service
 
   private
 
+  def report_status?
+    raise NotImplementedError
+  end
+
   def simple_failure(message)
     { ok: false, message: message }
   end
@@ -80,7 +84,7 @@ class CC::PullRequests < CC::Service
         params: params.as_json,
         status: e.status,
         endpoint_url: url,
-        message: "Access token is valid"
+        message: "Access token is valid",
       }
     else
       raise

data/lib/cc/service.rb

@@ -7,12 +7,12 @@ module CC
     require "cc/service/invocation"
     require "axiom/types/password"
 
-    dir = File.expand_path '../helpers', __FILE__
+    dir = File.expand_path "../helpers", __FILE__
     Dir["#{dir}/*_helper.rb"].sort.each do |helper|
       require helper
     end
 
-    dir = File.expand_path '../formatters', __FILE__
+    dir = File.expand_path "../formatters", __FILE__
     Dir["#{dir}/*_formatter.rb"].sort.each do |formatter|
       require formatter
     end
@@ -71,7 +71,7 @@ module CC
     def self.title
       @title ||= begin
         hook = name.dup
-        hook.sub!(/.*:/, '')
+        hook.sub!(/.*:/, "")
         hook
       end
     end
@@ -80,15 +80,15 @@ module CC
       @slug ||= begin
         hook = name.dup
         hook.downcase!
-        hook.sub!(/.*:/, '')
+        hook.sub!(/.*:/, "")
         hook
       end
     end
 
     def initialize(config, payload)
-      @payload     = payload.stringify_keys
-      @config      = create_config(config)
-      @event       = @payload["name"].to_s
+      @payload = payload.stringify_keys
+      @config = create_config(config)
+      @event = @payload["name"].to_s
 
       load_helper
       validate_event
@@ -103,7 +103,7 @@ module CC
         end
       end
 
-      { ok: false, ignored: true,  message: "No service handler found" }
+      { ok: false, ignored: true, message: "No service handler found" }
     end
 
     private
@@ -119,7 +119,7 @@ module CC
 
     def validate_event
       unless ALL_EVENTS.include?(event)
-        raise ArgumentError.new("Invalid event: #{event}")
+        raise ArgumentError, "Invalid event: #{event}"
       end
     end
 
@@ -138,6 +138,5 @@ module CC
         Config
       end
     end
-
   end
 end

data/lib/cc/service/formatter.rb

@@ -1,4 +1,4 @@
-require 'delegate'
+require "delegate"
 
 class CC::Service::Formatter < SimpleDelegator
   attr_reader :options
@@ -8,7 +8,7 @@ class CC::Service::Formatter < SimpleDelegator
 
     @options = {
       prefix: "[Code Climate]",
-      prefix_with_repo: true
+      prefix_with_repo: true,
     }.merge(options)
   end
 
@@ -25,7 +25,7 @@ class CC::Service::Formatter < SimpleDelegator
       prefix << "[#{repo_name}]"
     end
 
-    if !prefix.empty?
+    unless prefix.empty?
       prefix << " "
     end
 

data/lib/cc/service/helper.rb

@@ -1,6 +1,6 @@
 module CC::Service::Helper
-  GREEN_HEX = "#38ae6f"
-  RED_HEX   = "#ed2f00"
+  GREEN_HEX = "#38ae6f".freeze
+  RED_HEX = "#ed2f00".freeze
 
   def repo_name
     payload["repo_name"]
@@ -50,5 +50,4 @@ module CC::Service::Helper
     raise NotImplementedError,
       "Event-specific helpers must define #{__method__}"
   end
-
 end

data/lib/cc/service/http.rb

@@ -4,7 +4,7 @@ require "cc/service/response_check"
 module CC::Service::HTTP
   extend ActiveSupport::Concern
 
-  REDIRECT_CODES = [302, 307]
+  REDIRECT_CODES = [302, 307].freeze
 
   module ClassMethods
     def default_http_options
@@ -12,7 +12,7 @@ module CC::Service::HTTP
         adapter: :net_http,
         request: { timeout: 10, open_timeout: 5 },
         ssl:     { verify_depth: 5 },
-        headers: {}
+        headers: {},
       }
     end
   end
@@ -22,13 +22,13 @@ module CC::Service::HTTP
   end
 
   def service_post(url, body = nil, headers = nil, &block)
-    block ||= lambda{|*_args| Hash.new }
+    block ||= ->(*_args) { Hash.new }
     response = raw_post(url, body, headers)
     formatted_post_response(response, url, body).merge(block.call(response))
   end
 
   def service_post_with_redirects(url, body = nil, headers = nil, &block)
-    block ||= lambda{|*_args| Hash.new }
+    block ||= ->(*_args) { Hash.new }
     response = raw_post(url, body, headers)
     if REDIRECT_CODES.include?(response.status)
       response = raw_post(response.headers["location"], body, headers)
@@ -39,8 +39,8 @@ module CC::Service::HTTP
 
   def raw_get(url = nil, params = nil, headers = nil)
     http.get do |req|
-      req.url(url)                if url
-      req.params.update(params)   if params
+      req.url(url) if url
+      req.params.update(params) if params
       req.headers.update(headers) if headers
       yield req if block_given?
     end
@@ -55,9 +55,9 @@ module CC::Service::HTTP
     block = Proc.new if block_given?
 
     http.send(method) do |req|
-      req.url(url)                if url
+      req.url(url) if url
       req.headers.update(headers) if headers
-      req.body = body             if body
+      req.body = body if body
       block.call req if block
     end
   end
@@ -87,7 +87,7 @@ module CC::Service::HTTP
   #
   # Returns a String path.
   def ca_file
-    @ca_file ||= ENV.fetch("CODECLIMATE_CA_FILE", File.expand_path('../../../../config/cacert.pem', __FILE__))
+    @ca_file ||= ENV.fetch("CODECLIMATE_CA_FILE", File.expand_path("../../../../config/cacert.pem", __FILE__))
   end
 
   def formatted_post_response(response, url, body)

data/lib/cc/service/invocation.rb

@@ -1,8 +1,8 @@
-require 'cc/service/invocation/invocation_chain'
-require 'cc/service/invocation/with_retries'
-require 'cc/service/invocation/with_metrics'
-require 'cc/service/invocation/with_error_handling'
-require 'cc/service/invocation/with_return_values'
+require "cc/service/invocation/invocation_chain"
+require "cc/service/invocation/with_retries"
+require "cc/service/invocation/with_metrics"
+require "cc/service/invocation/with_error_handling"
+require "cc/service/invocation/with_return_values"
 
 class CC::Service::Invocation
   MIDDLEWARE = {
@@ -10,7 +10,7 @@ class CC::Service::Invocation
     metrics: WithMetrics,
     error_handling: WithErrorHandling,
     return_values: WithReturnValues,
-  }
+  }.freeze
 
   attr_reader :result
 

data/lib/cc/service/invocation/with_error_handling.rb

@@ -16,27 +16,28 @@ class CC::Service::Invocation
         status: e.status,
         endpoint_url: e.endpoint_url,
         message: e.user_message || e.message,
-        log_message: error_message(e)
+        log_message: error_message(e),
       }
     rescue => e
       @logger.error(error_message(e))
       {
         ok: false,
         message: e.message,
-        log_message: error_message(e)
+        log_message: error_message(e),
       }
     end
 
     private
 
     def error_message(e)
-      if e.respond_to?(:response_body)
-        response_body = ". Response: <#{e.response_body.inspect}>"
-      else
-        response_body = ""
-      end
+      response_body =
+        if e.respond_to?(:response_body)
+          ". Response: <#{e.response_body.inspect}>"
+        else
+          ""
+        end
 
-      message  = "Exception invoking service:"
+      message = "Exception invoking service:"
       message << " [#{@prefix}]" if @prefix
       message << " (#{e.class}) #{e.message}"
       message << response_body

data/lib/cc/service/invocation/with_metrics.rb

@@ -22,16 +22,16 @@ class CC::Service::Invocation
     end
 
     def success_key
-      ["services.invocations", @prefix].compact.join('.')
+      ["services.invocations", @prefix].compact.join(".")
     end
 
     def timing_key
-      ["services.timing", @prefix].compact.join('.')
+      ["services.timing", @prefix].compact.join(".")
     end
 
     def error_key(ex)
-      error_string = ex.class.name.underscore.gsub("/", "-")
-      ["services.errors", @prefix, error_string].compact.join('.')
+      error_string = ex.class.name.underscore.tr("/", "-")
+      ["services.errors", @prefix, error_string].compact.join(".")
     end
   end
 end

data/lib/cc/service/invocation/with_return_values.rb

@@ -15,4 +15,3 @@ class CC::Service::Invocation
     end
   end
 end
-

data/lib/cc/service/response_check.rb

@@ -5,9 +5,9 @@ class CC::Service
 
     def initialize(message, env)
       @response_body = env[:body]
-      @status        = env[:status]
-      @params        = env[:params]
-      @endpoint_url  = env[:url].to_s
+      @status = env[:status]
+      @params = env[:params]
+      @endpoint_url = env[:url].to_s
 
       super(message)
     end
@@ -25,7 +25,7 @@ class CC::Service
       end
     end
 
-  private
+    private
 
     def error_message(env)
       # We only handle Jira (or responses which look like Jira's). We will add
@@ -37,6 +37,5 @@ class CC::Service
       end
     rescue JSON::ParserError
     end
-
   end
 end

data/lib/cc/services.rb

@@ -6,5 +6,5 @@ require "virtus"
 require "active_model"
 require "active_support/core_ext"
 
-require File.expand_path('../service', __FILE__)
-require File.expand_path('../pull_requests', __FILE__)
+require File.expand_path("../service", __FILE__)
+require File.expand_path("../pull_requests", __FILE__)

data/lib/cc/services/asana.rb

@@ -14,7 +14,7 @@ class CC::Service::Asana < CC::Service
     validates :workspace_id, presence: true
   end
 
-  ENDPOINT = "https://app.asana.com/api/1.0/tasks"
+  ENDPOINT = "https://app.asana.com/api/1.0/tasks".freeze
 
   self.title = "Asana"
   self.description = "Create tasks in Asana"
@@ -23,16 +23,16 @@ class CC::Service::Asana < CC::Service
   def receive_test
     result = create_task("Test task from Code Climate")
     result.merge(
-      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created."
+      message: "Ticket <a href='#{result[:url]}'>#{result[:id]}</a> created.",
     )
   rescue CC::Service::HTTPError => ex
     body = JSON.parse(ex.response_body)
-    ex.user_message = body["errors"].map{|e| e["message"] }.join(" ")
+    ex.user_message = body["errors"].map { |e| e["message"] }.join(" ")
     raise ex
   end
 
   def receive_issue
-    title = %{Fix "#{issue["check_name"]}" issue in #{constant_name}}
+    title = %(Fix "#{issue["check_name"]}" issue in #{constant_name})
 
     body = [issue["description"], details_url].join("\n\n")
 
@@ -45,12 +45,12 @@ class CC::Service::Asana < CC::Service
 
   def receive_vulnerability
     formatter = CC::Formatters::TicketFormatter.new(self)
-    title     = formatter.format_vulnerability_title
+    title = formatter.format_vulnerability_title
 
     create_task("#{title} - #{details_url}")
   end
 
-private
+  private
 
   def create_task(name, notes = "")
     params = generate_params(name, notes)
@@ -58,7 +58,7 @@ private
     http.headers["Content-Type"] = "application/json"
     service_post(ENDPOINT, params.to_json) do |response|
       body = JSON.parse(response.body)
-      id = body['data']['id']
+      id = body["data"]["id"]
       url = "https://app.asana.com/0/#{config.workspace_id}/#{id}"
       { id: id, url: url }
     end
@@ -66,7 +66,7 @@ private
 
   def generate_params(name, notes = nil)
     params = {
-      data: { workspace: config.workspace_id, name: name, notes: notes }
+      data: { workspace: config.workspace_id, name: name, notes: notes },
     }
 
     if config.project_id.present?
@@ -84,5 +84,4 @@ private
   def authenticate_http
     http.basic_auth(config.api_key, "")
   end
-
 end

data/lib/cc/services/campfire.rb

@@ -16,7 +16,7 @@ class CC::Service::Campfire < CC::Service
 
   def receive_test
     speak(formatter.format_test).merge(
-      message: "Test message sent"
+      message: "Test message sent",
     )
   end
 
@@ -39,7 +39,7 @@ class CC::Service::Campfire < CC::Service
   end
 
   def speak(line)
-    http.headers['Content-Type']  = 'application/json'
+    http.headers["Content-Type"] = "application/json"
     params = { message: { body: line } }
 
     http.basic_auth(config.token, "X")
@@ -51,5 +51,4 @@ class CC::Service::Campfire < CC::Service
     room_id = config.room_id
     "https://#{subdomain}.campfirenow.com/room/#{room_id}/speak.json"
   end
-
 end