chef 14.14.29-universal-mingw32 → 14.15.6-universal-mingw32

Sign up to get free protection for your applications and to get access to all the features.
Files changed (366) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -1
  3. data/README.md +18 -7
  4. data/Rakefile +7 -4
  5. data/chef.gemspec +1 -1
  6. data/lib/chef/knife/ssh.rb +6 -0
  7. data/lib/chef/provider/ifconfig.rb +14 -5
  8. data/lib/chef/provider/windows_task.rb +9 -5
  9. data/lib/chef/resource/kernel_module.rb +61 -0
  10. data/lib/chef/resource/windows_task.rb +4 -0
  11. data/lib/chef/version.rb +1 -1
  12. data/spec/data/cookbooks/openldap/metadata.rb +2 -2
  13. data/spec/data/metadata/quick_start/metadata.rb +2 -7
  14. data/spec/functional/audit/runner_spec.rb +1 -1
  15. data/spec/functional/dsl/reboot_pending_spec.rb +7 -25
  16. data/spec/functional/event_loggers/windows_eventlog_spec.rb +6 -4
  17. data/spec/functional/file_content_management/deploy_strategies_spec.rb +21 -21
  18. data/spec/functional/knife/exec_spec.rb +1 -1
  19. data/spec/functional/knife/ssh_spec.rb +3 -3
  20. data/spec/functional/mixin/user_context_spec.rb +3 -1
  21. data/spec/functional/rebooter_spec.rb +1 -1
  22. data/spec/functional/resource/aix_service_spec.rb +1 -1
  23. data/spec/functional/resource/aixinit_service_spec.rb +1 -1
  24. data/spec/functional/resource/apt_package_spec.rb +1 -1
  25. data/spec/functional/resource/chocolatey_package_spec.rb +2 -2
  26. data/spec/functional/resource/cookbook_file_spec.rb +1 -3
  27. data/spec/functional/resource/cron_spec.rb +4 -3
  28. data/spec/functional/resource/dpkg_package_spec.rb +4 -4
  29. data/spec/functional/resource/dsc_resource_spec.rb +2 -1
  30. data/spec/functional/resource/dsc_script_spec.rb +16 -20
  31. data/spec/functional/resource/execute_spec.rb +2 -2
  32. data/spec/functional/resource/git_spec.rb +6 -6
  33. data/spec/functional/resource/group_spec.rb +8 -6
  34. data/spec/functional/resource/ifconfig_spec.rb +3 -5
  35. data/spec/functional/resource/link_spec.rb +2 -2
  36. data/spec/functional/resource/mount_spec.rb +3 -7
  37. data/spec/functional/resource/powershell_script_spec.rb +9 -8
  38. data/spec/functional/resource/reboot_spec.rb +1 -1
  39. data/spec/functional/resource/remote_file_spec.rb +2 -2
  40. data/spec/functional/resource/template_spec.rb +1 -1
  41. data/spec/functional/resource/user/windows_spec.rb +2 -2
  42. data/spec/functional/resource/windows_certificate_spec.rb +3 -3
  43. data/spec/functional/resource/windows_service_spec.rb +3 -3
  44. data/spec/functional/resource/windows_task_spec.rb +51 -0
  45. data/spec/functional/run_lock_spec.rb +10 -3
  46. data/spec/functional/shell_spec.rb +1 -1
  47. data/spec/functional/util/powershell/cmdlet_spec.rb +1 -1
  48. data/spec/functional/version_spec.rb +1 -1
  49. data/spec/functional/win32/security_spec.rb +12 -7
  50. data/spec/functional/win32/service_manager_spec.rb +1 -1
  51. data/spec/functional/win32/version_info_spec.rb +4 -4
  52. data/spec/integration/client/client_spec.rb +114 -132
  53. data/spec/integration/client/exit_code_spec.rb +8 -8
  54. data/spec/integration/client/ipv6_spec.rb +5 -5
  55. data/spec/integration/knife/chef_fs_data_store_spec.rb +38 -38
  56. data/spec/integration/knife/chef_repo_path_spec.rb +42 -42
  57. data/spec/integration/knife/chef_repository_file_system_spec.rb +9 -9
  58. data/spec/integration/knife/chefignore_spec.rb +13 -13
  59. data/spec/integration/knife/client_bulk_delete_spec.rb +8 -8
  60. data/spec/integration/knife/client_create_spec.rb +1 -1
  61. data/spec/integration/knife/client_delete_spec.rb +4 -4
  62. data/spec/integration/knife/client_key_delete_spec.rb +1 -1
  63. data/spec/integration/knife/client_key_list_spec.rb +1 -1
  64. data/spec/integration/knife/client_list_spec.rb +1 -1
  65. data/spec/integration/knife/common_options_spec.rb +1 -1
  66. data/spec/integration/knife/config_get_spec.rb +1 -1
  67. data/spec/integration/knife/config_list_profiles_spec.rb +2 -1
  68. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +3 -3
  69. data/spec/integration/knife/cookbook_bulk_delete_spec.rb +3 -3
  70. data/spec/integration/knife/cookbook_download_spec.rb +4 -4
  71. data/spec/integration/knife/cookbook_list_spec.rb +2 -2
  72. data/spec/integration/knife/cookbook_show_spec.rb +3 -3
  73. data/spec/integration/knife/cookbook_upload_spec.rb +6 -6
  74. data/spec/integration/knife/data_bag_delete_spec.rb +4 -4
  75. data/spec/integration/knife/data_bag_from_file_spec.rb +7 -7
  76. data/spec/integration/knife/data_bag_list_spec.rb +1 -1
  77. data/spec/integration/knife/delete_spec.rb +37 -37
  78. data/spec/integration/knife/deps_spec.rb +23 -23
  79. data/spec/integration/knife/diff_spec.rb +23 -23
  80. data/spec/integration/knife/download_spec.rb +79 -79
  81. data/spec/integration/knife/environment_compare_spec.rb +3 -3
  82. data/spec/integration/knife/environment_from_file_spec.rb +6 -6
  83. data/spec/integration/knife/environment_list_spec.rb +1 -1
  84. data/spec/integration/knife/environment_show_spec.rb +4 -4
  85. data/spec/integration/knife/list_spec.rb +25 -25
  86. data/spec/integration/knife/node_bulk_delete_spec.rb +2 -2
  87. data/spec/integration/knife/node_delete_spec.rb +2 -2
  88. data/spec/integration/knife/node_environment_set_spec.rb +1 -1
  89. data/spec/integration/knife/node_from_file_spec.rb +2 -2
  90. data/spec/integration/knife/node_list_spec.rb +1 -1
  91. data/spec/integration/knife/raw_spec.rb +12 -12
  92. data/spec/integration/knife/redirection_spec.rb +1 -1
  93. data/spec/integration/knife/role_bulk_delete_spec.rb +2 -2
  94. data/spec/integration/knife/role_delete_spec.rb +2 -2
  95. data/spec/integration/knife/role_from_file_spec.rb +5 -5
  96. data/spec/integration/knife/role_list_spec.rb +1 -1
  97. data/spec/integration/knife/role_show_spec.rb +1 -1
  98. data/spec/integration/knife/show_spec.rb +10 -10
  99. data/spec/integration/knife/upload_spec.rb +85 -85
  100. data/spec/integration/recipes/accumulator_spec.rb +4 -4
  101. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +6 -6
  102. data/spec/integration/recipes/lwrp_spec.rb +6 -6
  103. data/spec/integration/recipes/notifies_spec.rb +45 -45
  104. data/spec/integration/recipes/notifying_block_spec.rb +4 -4
  105. data/spec/integration/recipes/provider_choice.rb +1 -2
  106. data/spec/integration/recipes/recipe_dsl_spec.rb +9 -9
  107. data/spec/integration/recipes/remote_directory.rb +2 -2
  108. data/spec/integration/recipes/resource_action_spec.rb +1 -1
  109. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +19 -19
  110. data/spec/integration/solo/solo_spec.rb +29 -29
  111. data/spec/scripts/ssl-serve.rb +1 -1
  112. data/spec/spec_helper.rb +11 -14
  113. data/spec/stress/win32/security_spec.rb +1 -1
  114. data/spec/support/lib/chef/resource/zen_follower.rb +1 -1
  115. data/spec/support/lib/chef/resource/zen_master.rb +1 -1
  116. data/spec/support/mock/platform.rb +2 -2
  117. data/spec/support/platform_helpers.rb +12 -3
  118. data/spec/support/platforms/win32/spec_service.rb +6 -10
  119. data/spec/support/shared/context/client.rb +2 -1
  120. data/spec/support/shared/functional/execute_resource.rb +4 -4
  121. data/spec/support/shared/functional/file_resource.rb +1 -3
  122. data/spec/support/shared/functional/http.rb +20 -44
  123. data/spec/support/shared/functional/securable_resource.rb +4 -8
  124. data/spec/support/shared/functional/win32_service.rb +1 -1
  125. data/spec/support/shared/functional/windows_script.rb +2 -1
  126. data/spec/support/shared/integration/app_server_support.rb +3 -4
  127. data/spec/support/shared/integration/integration_helper.rb +1 -0
  128. data/spec/support/shared/integration/knife_support.rb +5 -5
  129. data/spec/support/shared/unit/application_dot_d.rb +10 -4
  130. data/spec/support/shared/unit/file_system_support.rb +3 -2
  131. data/spec/support/shared/unit/platform_introspector.rb +12 -12
  132. data/spec/support/shared/unit/provider/file.rb +1 -1
  133. data/spec/support/shared/unit/script_resource.rb +1 -1
  134. data/spec/support/shared/unit/windows_script_resource.rb +1 -1
  135. data/spec/tiny_server.rb +1 -1
  136. data/spec/unit/api_client/registration_spec.rb +1 -1
  137. data/spec/unit/api_client_spec.rb +5 -5
  138. data/spec/unit/api_client_v1_spec.rb +6 -6
  139. data/spec/unit/application/client_spec.rb +8 -8
  140. data/spec/unit/application/exit_code_spec.rb +3 -2
  141. data/spec/unit/application/knife_spec.rb +1 -2
  142. data/spec/unit/audit/audit_event_proxy_spec.rb +14 -7
  143. data/spec/unit/audit/audit_reporter_spec.rb +20 -11
  144. data/spec/unit/audit/control_group_data_spec.rb +17 -12
  145. data/spec/unit/chef_fs/config_spec.rb +3 -3
  146. data/spec/unit/chef_fs/file_system/repository/directory_spec.rb +1 -1
  147. data/spec/unit/chef_fs/parallelizer.rb +1 -1
  148. data/spec/unit/client_spec.rb +3 -3
  149. data/spec/unit/config_fetcher_spec.rb +1 -1
  150. data/spec/unit/cookbook/metadata_spec.rb +13 -13
  151. data/spec/unit/cookbook/synchronizer_spec.rb +6 -6
  152. data/spec/unit/cookbook_loader_spec.rb +17 -17
  153. data/spec/unit/cookbook_manifest_spec.rb +9 -9
  154. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +1 -2
  155. data/spec/unit/cookbook_uploader_spec.rb +2 -2
  156. data/spec/unit/cookbook_version_file_specificity_spec.rb +9 -9
  157. data/spec/unit/cookbook_version_spec.rb +2 -2
  158. data/spec/unit/data_bag_item_spec.rb +7 -7
  159. data/spec/unit/data_bag_spec.rb +1 -1
  160. data/spec/unit/data_collector_spec.rb +23 -23
  161. data/spec/unit/decorator_spec.rb +2 -2
  162. data/spec/unit/deprecated_spec.rb +2 -2
  163. data/spec/unit/dsl/data_query_spec.rb +3 -2
  164. data/spec/unit/dsl/declare_resource_spec.rb +1 -1
  165. data/spec/unit/dsl/platform_introspection_spec.rb +2 -2
  166. data/spec/unit/encrypted_data_bag_item/check_encrypted_spec.rb +2 -1
  167. data/spec/unit/encrypted_data_bag_item_spec.rb +2 -1
  168. data/spec/unit/environment_spec.rb +13 -13
  169. data/spec/unit/event_dispatch/dsl_spec.rb +1 -1
  170. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +3 -3
  171. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +2 -2
  172. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +3 -3
  173. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +1 -1
  174. data/spec/unit/http/authenticator_spec.rb +4 -3
  175. data/spec/unit/http/json_input_spec.rb +1 -1
  176. data/spec/unit/http/socketless_chef_zero_client_spec.rb +15 -15
  177. data/spec/unit/key_spec.rb +8 -8
  178. data/spec/unit/knife/bootstrap_spec.rb +14 -10
  179. data/spec/unit/knife/client_bulk_delete_spec.rb +4 -4
  180. data/spec/unit/knife/configure_client_spec.rb +1 -1
  181. data/spec/unit/knife/configure_spec.rb +1 -1
  182. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +1 -1
  183. data/spec/unit/knife/cookbook_delete_spec.rb +2 -2
  184. data/spec/unit/knife/cookbook_download_spec.rb +2 -2
  185. data/spec/unit/knife/cookbook_metadata_spec.rb +4 -4
  186. data/spec/unit/knife/cookbook_upload_spec.rb +7 -5
  187. data/spec/unit/knife/core/bootstrap_context_spec.rb +1 -1
  188. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +2 -2
  189. data/spec/unit/knife/core/gem_glob_loader_spec.rb +4 -4
  190. data/spec/unit/knife/core/hashed_command_loader_spec.rb +4 -2
  191. data/spec/unit/knife/core/node_editor_spec.rb +12 -12
  192. data/spec/unit/knife/core/ui_spec.rb +11 -11
  193. data/spec/unit/knife/data_bag_from_file_spec.rb +2 -1
  194. data/spec/unit/knife/data_bag_show_spec.rb +2 -1
  195. data/spec/unit/knife/key_create_spec.rb +1 -1
  196. data/spec/unit/knife/key_delete_spec.rb +3 -3
  197. data/spec/unit/knife/key_edit_spec.rb +4 -4
  198. data/spec/unit/knife/key_list_spec.rb +1 -1
  199. data/spec/unit/knife/key_show_spec.rb +3 -3
  200. data/spec/unit/knife/node_bulk_delete_spec.rb +3 -3
  201. data/spec/unit/knife/node_delete_spec.rb +2 -2
  202. data/spec/unit/knife/node_edit_spec.rb +1 -1
  203. data/spec/unit/knife/node_environment_set_spec.rb +1 -1
  204. data/spec/unit/knife/node_from_file_spec.rb +1 -1
  205. data/spec/unit/knife/node_policy_set_spec.rb +1 -1
  206. data/spec/unit/knife/node_run_list_add_spec.rb +1 -1
  207. data/spec/unit/knife/node_run_list_remove_spec.rb +1 -1
  208. data/spec/unit/knife/node_run_list_set_spec.rb +1 -1
  209. data/spec/unit/knife/node_show_spec.rb +1 -1
  210. data/spec/unit/knife/raw_spec.rb +2 -2
  211. data/spec/unit/knife/role_bulk_delete_spec.rb +2 -2
  212. data/spec/unit/knife/role_create_spec.rb +1 -1
  213. data/spec/unit/knife/role_delete_spec.rb +1 -1
  214. data/spec/unit/knife/role_edit_spec.rb +1 -1
  215. data/spec/unit/knife/role_env_run_list_add_spec.rb +1 -1
  216. data/spec/unit/knife/role_env_run_list_clear_spec.rb +1 -1
  217. data/spec/unit/knife/role_env_run_list_remove_spec.rb +1 -1
  218. data/spec/unit/knife/role_env_run_list_replace_spec.rb +1 -1
  219. data/spec/unit/knife/role_env_run_list_set_spec.rb +1 -1
  220. data/spec/unit/knife/role_from_file_spec.rb +1 -1
  221. data/spec/unit/knife/role_run_list_add_spec.rb +1 -1
  222. data/spec/unit/knife/role_run_list_clear_spec.rb +1 -1
  223. data/spec/unit/knife/role_run_list_remove_spec.rb +1 -1
  224. data/spec/unit/knife/role_run_list_replace_spec.rb +1 -1
  225. data/spec/unit/knife/role_run_list_set_spec.rb +1 -1
  226. data/spec/unit/knife/ssh_spec.rb +27 -17
  227. data/spec/unit/knife/ssl_check_spec.rb +4 -4
  228. data/spec/unit/knife/ssl_fetch_spec.rb +5 -5
  229. data/spec/unit/knife/status_spec.rb +3 -2
  230. data/spec/unit/knife/supermarket_download_spec.rb +4 -4
  231. data/spec/unit/knife/supermarket_install_spec.rb +5 -4
  232. data/spec/unit/knife/supermarket_share_spec.rb +1 -1
  233. data/spec/unit/knife_spec.rb +34 -33
  234. data/spec/unit/lwrp_spec.rb +19 -19
  235. data/spec/unit/mixin/homebrew_user_spec.rb +1 -1
  236. data/spec/unit/mixin/params_validate_spec.rb +10 -10
  237. data/spec/unit/mixin/properties_spec.rb +4 -4
  238. data/spec/unit/mixin/shell_out_spec.rb +27 -27
  239. data/spec/unit/mixin/template_spec.rb +4 -8
  240. data/spec/unit/mixin/unformatter_spec.rb +1 -2
  241. data/spec/unit/mixin/user_context_spec.rb +1 -2
  242. data/spec/unit/mixin/which.rb +2 -0
  243. data/spec/unit/mixin/windows_architecture_helper_spec.rb +3 -3
  244. data/spec/unit/node/attribute_spec.rb +79 -79
  245. data/spec/unit/node/immutable_collections_spec.rb +50 -50
  246. data/spec/unit/node_spec.rb +16 -16
  247. data/spec/unit/org_spec.rb +3 -3
  248. data/spec/unit/policy_builder/policyfile_spec.rb +2 -2
  249. data/spec/unit/property/state_spec.rb +26 -25
  250. data/spec/unit/property/validation_spec.rb +14 -13
  251. data/spec/unit/property_spec.rb +10 -9
  252. data/spec/unit/provider/apt_update_spec.rb +6 -6
  253. data/spec/unit/provider/cron_spec.rb +15 -15
  254. data/spec/unit/provider/dsc_resource_spec.rb +6 -3
  255. data/spec/unit/provider/dsc_script_spec.rb +1 -1
  256. data/spec/unit/provider/execute_spec.rb +5 -5
  257. data/spec/unit/provider/git_spec.rb +39 -39
  258. data/spec/unit/provider/group/dscl_spec.rb +3 -3
  259. data/spec/unit/provider/group/groupadd_spec.rb +1 -1
  260. data/spec/unit/provider/group_spec.rb +2 -3
  261. data/spec/unit/provider/ifconfig/aix_spec.rb +1 -1
  262. data/spec/unit/provider/ifconfig/debian_spec.rb +2 -2
  263. data/spec/unit/provider/ifconfig_spec.rb +45 -16
  264. data/spec/unit/provider/launchd_spec.rb +23 -15
  265. data/spec/unit/provider/link_spec.rb +22 -11
  266. data/spec/unit/provider/mount/aix_spec.rb +6 -6
  267. data/spec/unit/provider/mount/mount_spec.rb +31 -31
  268. data/spec/unit/provider/mount/solaris_spec.rb +11 -11
  269. data/spec/unit/provider/ohai_spec.rb +1 -1
  270. data/spec/unit/provider/osx_profile_spec.rb +5 -7
  271. data/spec/unit/provider/package/apt_spec.rb +5 -5
  272. data/spec/unit/provider/package/bff_spec.rb +1 -1
  273. data/spec/unit/provider/package/cab_spec.rb +1 -1
  274. data/spec/unit/provider/package/chocolatey_spec.rb +8 -8
  275. data/spec/unit/provider/package/freebsd/pkg_spec.rb +1 -1
  276. data/spec/unit/provider/package/ips_spec.rb +6 -6
  277. data/spec/unit/provider/package/macports_spec.rb +1 -1
  278. data/spec/unit/provider/package/msu_spec.rb +1 -1
  279. data/spec/unit/provider/package/openbsd_spec.rb +15 -11
  280. data/spec/unit/provider/package/pacman_spec.rb +3 -3
  281. data/spec/unit/provider/package/paludis_spec.rb +4 -4
  282. data/spec/unit/provider/package/portage_spec.rb +1 -1
  283. data/spec/unit/provider/package/powershell_spec.rb +1 -1
  284. data/spec/unit/provider/package/smartos_spec.rb +3 -3
  285. data/spec/unit/provider/package/solaris_spec.rb +1 -1
  286. data/spec/unit/provider/package/windows/exe_spec.rb +9 -9
  287. data/spec/unit/provider/package/windows/msi_spec.rb +7 -7
  288. data/spec/unit/provider/package/windows_spec.rb +2 -1
  289. data/spec/unit/provider/package/yum/yum_cache_spec.rb +1 -1
  290. data/spec/unit/provider/package/zypper_spec.rb +4 -4
  291. data/spec/unit/provider/package_spec.rb +1 -1
  292. data/spec/unit/provider/powershell_script_spec.rb +7 -7
  293. data/spec/unit/provider/registry_key_spec.rb +1 -1
  294. data/spec/unit/provider/remote_directory_spec.rb +6 -6
  295. data/spec/unit/provider/route_spec.rb +11 -11
  296. data/spec/unit/provider/service/arch_service_spec.rb +13 -13
  297. data/spec/unit/provider/service/debian_service_spec.rb +2 -1
  298. data/spec/unit/provider/service/freebsd_service_spec.rb +28 -24
  299. data/spec/unit/provider/service/gentoo_service_spec.rb +2 -2
  300. data/spec/unit/provider/service/init_service_spec.rb +11 -11
  301. data/spec/unit/provider/service/invokercd_service_spec.rb +11 -11
  302. data/spec/unit/provider/service/macosx_spec.rb +5 -5
  303. data/spec/unit/provider/service/openbsd_service_spec.rb +15 -11
  304. data/spec/unit/provider/service/simple_service_spec.rb +7 -7
  305. data/spec/unit/provider/service/upstart_service_spec.rb +14 -14
  306. data/spec/unit/provider/service/windows_spec.rb +53 -35
  307. data/spec/unit/provider/subversion_spec.rb +8 -4
  308. data/spec/unit/provider/systemd_unit_spec.rb +142 -142
  309. data/spec/unit/provider/template/content_spec.rb +29 -29
  310. data/spec/unit/provider/windows_task_spec.rb +1 -1
  311. data/spec/unit/provider_resolver_spec.rb +75 -75
  312. data/spec/unit/provider_spec.rb +2 -4
  313. data/spec/unit/recipe_spec.rb +4 -4
  314. data/spec/unit/resource/batch_spec.rb +1 -1
  315. data/spec/unit/resource/chef_gem_spec.rb +1 -1
  316. data/spec/unit/resource/chocolatey_config_spec.rb +1 -1
  317. data/spec/unit/resource/chocolatey_source_spec.rb +1 -1
  318. data/spec/unit/resource/directory_spec.rb +1 -1
  319. data/spec/unit/resource/dnf_package_spec.rb +1 -1
  320. data/spec/unit/resource/dsc_resource_spec.rb +1 -1
  321. data/spec/unit/resource/file/verification_spec.rb +1 -2
  322. data/spec/unit/resource/file_spec.rb +1 -1
  323. data/spec/unit/resource/group_spec.rb +1 -1
  324. data/spec/unit/resource/link_spec.rb +1 -1
  325. data/spec/unit/resource/osx_profile_spec.rb +2 -1
  326. data/spec/unit/resource/powershell_script_spec.rb +12 -7
  327. data/spec/unit/resource/registry_key_spec.rb +3 -3
  328. data/spec/unit/resource/rhsm_subscription_spec.rb +1 -1
  329. data/spec/unit/resource/service_spec.rb +1 -1
  330. data/spec/unit/resource/template_spec.rb +2 -2
  331. data/spec/unit/resource/windows_env_spec.rb +1 -1
  332. data/spec/unit/resource/windows_service_spec.rb +5 -5
  333. data/spec/unit/resource/windows_task_spec.rb +6 -2
  334. data/spec/unit/resource/yum_package_spec.rb +1 -1
  335. data/spec/unit/resource_collection/resource_list_spec.rb +1 -1
  336. data/spec/unit/resource_collection/resource_set_spec.rb +7 -7
  337. data/spec/unit/resource_collection/stepable_iterator_spec.rb +2 -2
  338. data/spec/unit/resource_collection_spec.rb +4 -4
  339. data/spec/unit/resource_definition_spec.rb +2 -2
  340. data/spec/unit/resource_inspector_spec.rb +1 -1
  341. data/spec/unit/resource_reporter_spec.rb +4 -4
  342. data/spec/unit/resource_spec.rb +22 -22
  343. data/spec/unit/role_spec.rb +3 -3
  344. data/spec/unit/run_context/cookbook_compiler_spec.rb +23 -23
  345. data/spec/unit/run_list/run_list_expansion_spec.rb +9 -6
  346. data/spec/unit/run_list_spec.rb +1 -1
  347. data/spec/unit/runner_spec.rb +3 -3
  348. data/spec/unit/search/query_spec.rb +3 -2
  349. data/spec/unit/shell/model_wrapper_spec.rb +1 -1
  350. data/spec/unit/shell/shell_session_spec.rb +8 -11
  351. data/spec/unit/shell_spec.rb +1 -2
  352. data/spec/unit/user_spec.rb +4 -4
  353. data/spec/unit/user_v1_spec.rb +3 -3
  354. data/spec/unit/util/backup_spec.rb +1 -1
  355. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +13 -13
  356. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +3 -3
  357. data/spec/unit/util/editor_spec.rb +1 -1
  358. data/spec/unit/util/powershell/ps_credential_spec.rb +3 -2
  359. data/spec/unit/util/threaded_job_queue_spec.rb +2 -2
  360. data/spec/unit/version_class_spec.rb +4 -4
  361. data/spec/unit/win32/registry_spec.rb +5 -5
  362. data/spec/unit/win32/security_spec.rb +2 -1
  363. data/tasks/announce.rb +4 -11
  364. metadata +10 -6
  365. data/tasks/maintainers.rb +0 -211
  366. data/tasks/templates/prerelease.md.erb +0 -35
@@ -113,7 +113,7 @@ describe Chef::Role do
113
113
  end
114
114
 
115
115
  it "should throw an ArgumentError if we aren't a kind of hash" do
116
- expect { @role.default_attributes(Array.new) }.to raise_error(ArgumentError)
116
+ expect { @role.default_attributes([]) }.to raise_error(ArgumentError)
117
117
  end
118
118
  end
119
119
 
@@ -128,7 +128,7 @@ describe Chef::Role do
128
128
  end
129
129
 
130
130
  it "should throw an ArgumentError if we aren't a kind of hash" do
131
- expect { @role.override_attributes(Array.new) }.to raise_error(ArgumentError)
131
+ expect { @role.override_attributes([]) }.to raise_error(ArgumentError)
132
132
  end
133
133
  end
134
134
 
@@ -248,7 +248,7 @@ describe Chef::Role do
248
248
  ROLE_DSL = <<~EOR.freeze
249
249
  name "ceiling_cat"
250
250
  description "like Aliens, but furry"
251
- EOR
251
+ EOR
252
252
 
253
253
  describe "when loading from disk" do
254
254
  before do
@@ -107,7 +107,7 @@ describe Chef::RunContext::CookbookCompiler do
107
107
  node.run_list("test-with-deps::default", "test-with-circular-deps::default")
108
108
 
109
109
  compiler.compile_libraries
110
- expect(LibraryLoadOrder.load_order).to eq(["dependency1", "dependency2", "test-with-deps", "circular-dep2", "circular-dep1", "test-with-circular-deps"])
110
+ expect(LibraryLoadOrder.load_order).to eq(%w{dependency1 dependency2 test-with-deps circular-dep2 circular-dep1 test-with-circular-deps})
111
111
  end
112
112
  end
113
113
 
@@ -121,18 +121,18 @@ describe Chef::RunContext::CookbookCompiler do
121
121
  node.run_list("test-with-deps::default", "test-with-circular-deps::default")
122
122
 
123
123
  compiler.compile_lwrps
124
- expect(LibraryLoadOrder.load_order).to eq(["dependency1-provider",
125
- "dependency1-resource",
126
- "dependency2-provider",
127
- "dependency2-resource",
128
- "test-with-deps-provider",
129
- "test-with-deps-resource",
130
- "circular-dep2-provider",
131
- "circular-dep2-resource",
132
- "circular-dep1-provider",
133
- "circular-dep1-resource",
134
- "test-with-circular-deps-provider",
135
- "test-with-circular-deps-resource"])
124
+ expect(LibraryLoadOrder.load_order).to eq(%w{dependency1-provider
125
+ dependency1-resource
126
+ dependency2-provider
127
+ dependency2-resource
128
+ test-with-deps-provider
129
+ test-with-deps-resource
130
+ circular-dep2-provider
131
+ circular-dep2-resource
132
+ circular-dep1-provider
133
+ circular-dep1-resource
134
+ test-with-circular-deps-provider
135
+ test-with-circular-deps-resource})
136
136
  end
137
137
  end
138
138
 
@@ -147,12 +147,12 @@ describe Chef::RunContext::CookbookCompiler do
147
147
  node.run_list("test-with-deps::default", "test-with-circular-deps::default")
148
148
 
149
149
  compiler.compile_resource_definitions
150
- expect(LibraryLoadOrder.load_order).to eq(["dependency1-definition",
151
- "dependency2-definition",
152
- "test-with-deps-definition",
153
- "circular-dep2-definition",
154
- "circular-dep1-definition",
155
- "test-with-circular-deps-definition"])
150
+ expect(LibraryLoadOrder.load_order).to eq(%w{dependency1-definition
151
+ dependency2-definition
152
+ test-with-deps-definition
153
+ circular-dep2-definition
154
+ circular-dep1-definition
155
+ test-with-circular-deps-definition})
156
156
  end
157
157
 
158
158
  end
@@ -205,14 +205,14 @@ describe Chef::RunContext::CookbookCompiler do
205
205
  it "should return an array of cookbook names as symbols without duplicates" do
206
206
  node.run_list("test-with-circular-deps::default", "circular-dep1::default", "circular-dep2::default")
207
207
 
208
- expect(compiler.cookbook_order).to eq([:"circular-dep2",
209
- :"circular-dep1",
210
- :"test-with-circular-deps"])
208
+ expect(compiler.cookbook_order).to eq(%i{circular-dep2
209
+ circular-dep1
210
+ test-with-circular-deps})
211
211
  end
212
212
 
213
213
  it "determines if a cookbook is in the list of cookbooks reachable by dependency" do
214
214
  node.run_list("test-with-deps::default", "test-with-deps::server")
215
- expect(compiler.cookbook_order).to eq([:dependency1, :dependency2, :"test-with-deps"])
215
+ expect(compiler.cookbook_order).to eq(%i{dependency1 dependency2 test-with-deps})
216
216
  expect(compiler.unreachable_cookbook?(:dependency1)).to be_falsey
217
217
  expect(compiler.unreachable_cookbook?(:dependency2)).to be_falsey
218
218
  expect(compiler.unreachable_cookbook?(:'test-with-deps')).to be_falsey
@@ -94,12 +94,15 @@ describe Chef::RunList::RunListExpansion do
94
94
  allow(@expansion).to receive(:fetch_role).and_return(@first_role, @second_role)
95
95
  @expansion.expand
96
96
  @json = '{"id":"_default","run_list":[{"type":"recipe","name":"lobster::mastercookbook","version":"0.1.0",'
97
- .concat(
98
- '"skipped":false},{"type":"role","name":"rage","children":[{"type":"role","name":"mollusk","children":[],"missing":null,'
99
- .concat(
100
- '"error":null,"skipped":null},{"type":"recipe","name":"crabrevenge","version":null,"skipped":false}],"missing":null,'
101
- .concat(
102
- '"error":null,"skipped":null},{"type":"recipe","name":"fist","version":"0.1","skipped":false}]}')))
97
+ .concat(
98
+ '"skipped":false},{"type":"role","name":"rage","children":[{"type":"role","name":"mollusk","children":[],"missing":null,'
99
+ .concat(
100
+ '"error":null,"skipped":null},{"type":"recipe","name":"crabrevenge","version":null,"skipped":false}],"missing":null,'
101
+ .concat(
102
+ '"error":null,"skipped":null},{"type":"recipe","name":"fist","version":"0.1","skipped":false}]}'
103
+ )
104
+ )
105
+ )
103
106
 
104
107
  end
105
108
 
@@ -133,7 +133,7 @@ describe Chef::RunList do
133
133
  it "should yield each member to your block" do
134
134
  @run_list << "foo"
135
135
  @run_list << "bar"
136
- seen = Array.new
136
+ seen = []
137
137
  @run_list.each { |r| seen << r }
138
138
  expect(seen).to be_include("recipe[foo]")
139
139
  expect(seen).to be_include("recipe[bar]")
@@ -295,7 +295,7 @@ describe Chef::Runner do
295
295
  # execution, and schedule delayed actions :second and :third on the first
296
296
  # resource. The duplicate actions should "collapse" to a single notification
297
297
  # and order should be preserved.
298
- expect(SnitchyProvider.all_actions_called).to eq([:first, :first, :second, :third])
298
+ expect(SnitchyProvider.all_actions_called).to eq(%i{first first second third})
299
299
  end
300
300
 
301
301
  it "executes delayed notifications in the order they were declared" do
@@ -321,7 +321,7 @@ describe Chef::Runner do
321
321
  third_resource.notifies(:third_action, first_resource, :delayed)
322
322
 
323
323
  runner.converge
324
- expect(SnitchyProvider.all_actions_called).to eq([:first, :first, :second, :third])
324
+ expect(SnitchyProvider.all_actions_called).to eq(%i{first first second third})
325
325
  end
326
326
 
327
327
  it "does not fire notifications if the resource was not updated by the last action executed" do
@@ -347,7 +347,7 @@ describe Chef::Runner do
347
347
  runner.converge
348
348
 
349
349
  # All of the resources should only fire once:
350
- expect(SnitchyProvider.all_actions_called).to eq([:first, :second, :third])
350
+ expect(SnitchyProvider.all_actions_called).to eq(%i{first second third})
351
351
 
352
352
  # all of the resources should be marked as updated for reporting purposes
353
353
  expect(first_resource).to be_updated
@@ -149,7 +149,8 @@ describe Chef::Search::Query do
149
149
  ],
150
150
  "start" => 0,
151
151
  "total" => 4,
152
- } end
152
+ }
153
+ end
153
154
 
154
155
  let(:big_response_empty) do
155
156
  {
@@ -169,7 +170,7 @@ describe Chef::Search::Query do
169
170
  it "accepts a type as the first argument" do
170
171
  expect { query.search("node") }.not_to raise_error
171
172
  expect { query.search(:node) }.not_to raise_error
172
- expect { query.search(Hash.new) }.to raise_error(Chef::Exceptions::InvalidSearchQuery, /(Hash)/)
173
+ expect { query.search({}) }.to raise_error(Chef::Exceptions::InvalidSearchQuery, /(Hash)/)
173
174
  end
174
175
 
175
176
  it "queries for every object of a type by default" do
@@ -57,7 +57,7 @@ describe Shell::ModelWrapper do
57
57
  end
58
58
 
59
59
  it "maps the listed nodes when given a block" do
60
- expect(@wrapper.all { |n| n.name }.sort.reverse).to eq(%w{yummy sammich})
60
+ expect(@wrapper.all(&:name).sort.reverse).to eq(%w{yummy sammich})
61
61
  end
62
62
  end
63
63
 
@@ -57,8 +57,7 @@ describe Shell::ClientSession do
57
57
  load_node: true,
58
58
  build_node: true,
59
59
  register: true,
60
- sync_cookbooks: {}
61
- )
60
+ sync_cookbooks: {})
62
61
  end
63
62
 
64
63
  before do
@@ -94,8 +93,7 @@ describe Shell::SoloSession do
94
93
  load_node: true,
95
94
  build_node: true,
96
95
  register: true,
97
- sync_cookbooks: {}
98
- )
96
+ sync_cookbooks: {})
99
97
  end
100
98
 
101
99
  before do
@@ -132,8 +130,7 @@ describe Shell::StandAloneSession do
132
130
  load_node: true,
133
131
  build_node: true,
134
132
  register: true,
135
- sync_cookbooks: {}
136
- )
133
+ sync_cookbooks: {})
137
134
  end
138
135
  let(:recipe) { Chef::Recipe.new(nil, nil, run_context) }
139
136
  let(:run_context) { Chef::RunContext.new(node, {}, events) }
@@ -238,11 +235,11 @@ describe Shell::SoloLegacySession do
238
235
 
239
236
  it "passes the shell CLI args to the client" do
240
237
  @client = double("Chef::Client.new",
241
- run_ohai: true,
242
- load_node: true,
243
- build_node: true,
244
- register: true,
245
- sync_cookbooks: {})
238
+ run_ohai: true,
239
+ load_node: true,
240
+ build_node: true,
241
+ register: true,
242
+ sync_cookbooks: {})
246
243
  expect(Chef::Client).to receive(:new).with(json_attribs, Chef::Config[:shell_config]).and_return(@client)
247
244
  @session.json_configuration = json_attribs
248
245
  @session.send(:rebuild_node)
@@ -30,8 +30,7 @@ ObjectTestHarness = Proc.new do
30
30
  end
31
31
 
32
32
  desc "rspecin'"
33
- def rspec_method
34
- end
33
+ def rspec_method; end
35
34
  end
36
35
 
37
36
  class TestJobManager
@@ -65,7 +65,7 @@ describe Chef::User do
65
65
  end
66
66
 
67
67
  it "should throw an ArgumentError if you feed it anything but a string" do
68
- expect { @user.name Hash.new }.to raise_error(ArgumentError)
68
+ expect { @user.name({}) }.to raise_error(ArgumentError)
69
69
  end
70
70
  end
71
71
 
@@ -84,7 +84,7 @@ describe Chef::User do
84
84
  end
85
85
 
86
86
  it "should throw an ArgumentError if you feed it anything but true or false" do
87
- expect { @user.name Hash.new }.to raise_error(ArgumentError)
87
+ expect { @user.name({}) }.to raise_error(ArgumentError)
88
88
  end
89
89
  end
90
90
 
@@ -99,7 +99,7 @@ describe Chef::User do
99
99
  end
100
100
 
101
101
  it "should throw an ArgumentError if you feed it something lame" do
102
- expect { @user.public_key Hash.new }.to raise_error(ArgumentError)
102
+ expect { @user.public_key({}) }.to raise_error(ArgumentError)
103
103
  end
104
104
  end
105
105
 
@@ -114,7 +114,7 @@ describe Chef::User do
114
114
  end
115
115
 
116
116
  it "should throw an ArgumentError if you feed it something lame" do
117
- expect { @user.private_key Hash.new }.to raise_error(ArgumentError)
117
+ expect { @user.private_key({}) }.to raise_error(ArgumentError)
118
118
  end
119
119
  end
120
120
 
@@ -37,7 +37,7 @@ describe Chef::UserV1 do
37
37
  end
38
38
 
39
39
  it "should throw an ArgumentError if you feed it something lame" do
40
- expect { @user.send(method, Hash.new) }.to raise_error(ArgumentError)
40
+ expect { @user.send(method, {}) }.to raise_error(ArgumentError)
41
41
  end
42
42
  end
43
43
 
@@ -57,7 +57,7 @@ describe Chef::UserV1 do
57
57
  end
58
58
 
59
59
  it "should throw an ArgumentError if you feed it anything but true or false" do
60
- expect { @user.send(method, Hash.new) }.to raise_error(ArgumentError)
60
+ expect { @user.send(method, {}) }.to raise_error(ArgumentError)
61
61
  end
62
62
  end
63
63
 
@@ -95,7 +95,7 @@ describe Chef::UserV1 do
95
95
  end
96
96
 
97
97
  it "should throw an ArgumentError if you feed it anything but a string" do
98
- expect { @user.username Hash.new }.to raise_error(ArgumentError)
98
+ expect { @user.username({}) }.to raise_error(ArgumentError)
99
99
  end
100
100
  end
101
101
 
@@ -110,7 +110,7 @@ describe Chef::Util::Backup do
110
110
  end
111
111
  it "should strip the drive letter off for windows" do
112
112
  expect(@backup).to receive(:path).and_return('c:\a\b\c.txt')
113
- expect(@backup.send(:backup_filename)).to match(%r|^\\a\\b\\c.txt.chef-\d{14}.\d{6}$|)
113
+ expect(@backup.send(:backup_filename)).to match(/^\\a\\b\\c.txt.chef-\d{14}.\d{6}$/)
114
114
  end
115
115
  it "should strip the drive letter off for windows (with forwardslashes)" do
116
116
  expect(@backup).to receive(:path).and_return("c:/a/b/c.txt")
@@ -52,7 +52,7 @@ describe Chef::Util::DSC::LocalConfigurationManager::Parser do
52
52
  logtype: [machinename]: LCM: [ Start Resource ] [name]
53
53
  logtype: [machinename]: LCM: [ End Resource ] [name]
54
54
  logtype: [machinename]: LCM: [ End Set ]
55
- EOF
55
+ EOF
56
56
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
57
57
  expect(resources.length).to eq(1)
58
58
  expect(resources[0].name).to eq("[name]")
@@ -66,7 +66,7 @@ EOF
66
66
  logtype: [machinename]: LCM: [ End Set ] [name]
67
67
  logtype: [machinename]: LCM: [ End Resource ] [name]
68
68
  logtype: [machinename]: LCM: [ End Set ]
69
- EOF
69
+ EOF
70
70
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
71
71
  expect(resources[0].changes_state?).to be_truthy
72
72
  end
@@ -80,7 +80,7 @@ EOF
80
80
  logtype: [machinename]: LCM: [ End Set ] [name]
81
81
  logtype: [machinename]: LCM: [ End Resource ] [name]
82
82
  logtype: [machinename]: LCM: [ End Set ]
83
- EOF
83
+ EOF
84
84
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
85
85
  expect(resources[0].change_log).to match_array(["[name]", "[message]", "[name]"])
86
86
  end
@@ -92,7 +92,7 @@ EOF
92
92
  logtype: [machinename]: LCM: [ Skip Set ] [name]
93
93
  logtype: [machinename]: LCM: [ End Resource ] [name]
94
94
  logtype: [machinename]: LCM: [ End Set ]
95
- EOF
95
+ EOF
96
96
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
97
97
  expect(resources[0].changes_state?).to be_falsey
98
98
  end
@@ -104,7 +104,7 @@ EOF
104
104
  logtype: [machinename]: LCM: [ Skip Set ] [name]
105
105
  logtype: [machinename]: LCM: [ End Resource ] [name]
106
106
  logtype: [machinename]: LCM: [ End Set ]
107
- EOF
107
+ EOF
108
108
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
109
109
  expect(resources[0].change_log).to be_empty
110
110
  end
@@ -118,7 +118,7 @@ EOF
118
118
  ResourcesNotInDesiredState: [name]
119
119
  ReturnValue : 0
120
120
  PSComputerName : .
121
- EOF
121
+ EOF
122
122
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, true)
123
123
  expect(resources.length).to eq(1)
124
124
  expect(resources[0].name).to eq("[name]")
@@ -131,7 +131,7 @@ EOF
131
131
  ResourcesNotInDesiredState: [name]
132
132
  ReturnValue : 0
133
133
  PSComputerName : .
134
- EOF
134
+ EOF
135
135
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, true)
136
136
  expect(resources[0].changes_state?).to be_truthy
137
137
  end
@@ -143,7 +143,7 @@ EOF
143
143
  ResourcesNotInDesiredState:
144
144
  ReturnValue : 0
145
145
  PSComputerName : .
146
- EOF
146
+ EOF
147
147
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, true)
148
148
  expect(resources[0].changes_state?).to be_falsey
149
149
  end
@@ -155,7 +155,7 @@ EOF
155
155
  ResourcesNotInDesiredState:
156
156
  ReturnValue : 0
157
157
  PSComputerName : .
158
- EOF
158
+ EOF
159
159
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, true)
160
160
  expect(resources[0].change_log).to be_empty
161
161
  end
@@ -176,7 +176,7 @@ EOF
176
176
  logtype: [machinename]: LCM: [ Start Set ]
177
177
  logtype: [machinename]: LCM: [ End Set ]
178
178
  logtype: [machinename]: LCM: [ End Set ]
179
- EOF
179
+ EOF
180
180
 
181
181
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
182
182
  expect(resources[0].changes_state?).to be_falsey
@@ -197,7 +197,7 @@ EOF
197
197
  logtype: [machinename]: LCM: [ End Set ]
198
198
  logtype: [machinename]: LCM: [ End Resource ]
199
199
  logtype: [machinename]: LCM: [ End Set ]
200
- EOF
200
+ EOF
201
201
 
202
202
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
203
203
  expect(resources[0].changes_state?).to be_falsey
@@ -217,7 +217,7 @@ EOF
217
217
  logtype: [machinename]: LCM: [ End Set ]
218
218
  logtype: [machinename]: LCM: [ End Resource ]
219
219
  logtype: [machinename]: LCM: [ End Set ]
220
- EOF
220
+ EOF
221
221
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, false)
222
222
  expect(resources[0].changes_state?).to be_truthy
223
223
  expect(resources[0].name).to eql("[name]")
@@ -239,7 +239,7 @@ EOF
239
239
  ResourcesNotInDesiredState: [name2]
240
240
  ReturnValue : 0
241
241
  PSComputerName : .
242
- EOF
242
+ EOF
243
243
 
244
244
  resources = Chef::Util::DSC::LocalConfigurationManager::Parser.parse(str, true)
245
245
  expect(resources[0].changes_state?).to be_falsey
@@ -29,7 +29,7 @@ describe Chef::Util::DSC::LocalConfigurationManager do
29
29
  logtype: [machinename]: LCM: [ Start Resource ] [name]
30
30
  logtype: [machinename]: LCM: [ End Resource ] [name]
31
31
  logtype: [machinename]: LCM: [ End Set ]
32
- EOH
32
+ EOH
33
33
  end
34
34
 
35
35
  let(:no_whatif_lcm_output) do
@@ -40,13 +40,13 @@ EOH
40
40
  + ~~~~~~~~
41
41
  + CategoryInfo : InvalidArgument: (:) [Start-DscConfiguration], ParameterBindingException
42
42
  + FullyQualifiedErrorId : NamedParameterNotFound,SomeCompany.SomeAssembly.Commands.RunSomeCommand
43
- EOH
43
+ EOH
44
44
  end
45
45
 
46
46
  let(:dsc_resource_import_failure_output) do
47
47
  <<~EOH
48
48
  PowerShell provider MSFT_xWebsite failed to execute Test-TargetResource functionality with error message: Please ensure that WebAdministration module is installed. + CategoryInfo : InvalidOperation: (:) [], CimException + FullyQualifiedErrorId : ProviderOperationExecutionFailure + PSComputerName : . PowerShell provider MSFT_xWebsite failed to execute Test-TargetResource functionality with error message: Please ensure that WebAdministration module is installed. + CategoryInfo : InvalidOperation: (:) [], CimException + FullyQualifiedErrorId : ProviderOperationExecutionFailure + PSComputerName : . The SendConfigurationApply function did not succeed. + CategoryInfo : NotSpecified: (root/Microsoft/...gurationManager:String) [], CimException + FullyQualifiedErrorId : MI RESULT 1 + PSComputerName : .
49
- EOH
49
+ EOH
50
50
  end
51
51
 
52
52
  let(:lcm_status) do