chef 14.14.29-universal-mingw32 → 14.15.6-universal-mingw32

Sign up to get free protection for your applications and to get access to all the features.
Files changed (366) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -1
  3. data/README.md +18 -7
  4. data/Rakefile +7 -4
  5. data/chef.gemspec +1 -1
  6. data/lib/chef/knife/ssh.rb +6 -0
  7. data/lib/chef/provider/ifconfig.rb +14 -5
  8. data/lib/chef/provider/windows_task.rb +9 -5
  9. data/lib/chef/resource/kernel_module.rb +61 -0
  10. data/lib/chef/resource/windows_task.rb +4 -0
  11. data/lib/chef/version.rb +1 -1
  12. data/spec/data/cookbooks/openldap/metadata.rb +2 -2
  13. data/spec/data/metadata/quick_start/metadata.rb +2 -7
  14. data/spec/functional/audit/runner_spec.rb +1 -1
  15. data/spec/functional/dsl/reboot_pending_spec.rb +7 -25
  16. data/spec/functional/event_loggers/windows_eventlog_spec.rb +6 -4
  17. data/spec/functional/file_content_management/deploy_strategies_spec.rb +21 -21
  18. data/spec/functional/knife/exec_spec.rb +1 -1
  19. data/spec/functional/knife/ssh_spec.rb +3 -3
  20. data/spec/functional/mixin/user_context_spec.rb +3 -1
  21. data/spec/functional/rebooter_spec.rb +1 -1
  22. data/spec/functional/resource/aix_service_spec.rb +1 -1
  23. data/spec/functional/resource/aixinit_service_spec.rb +1 -1
  24. data/spec/functional/resource/apt_package_spec.rb +1 -1
  25. data/spec/functional/resource/chocolatey_package_spec.rb +2 -2
  26. data/spec/functional/resource/cookbook_file_spec.rb +1 -3
  27. data/spec/functional/resource/cron_spec.rb +4 -3
  28. data/spec/functional/resource/dpkg_package_spec.rb +4 -4
  29. data/spec/functional/resource/dsc_resource_spec.rb +2 -1
  30. data/spec/functional/resource/dsc_script_spec.rb +16 -20
  31. data/spec/functional/resource/execute_spec.rb +2 -2
  32. data/spec/functional/resource/git_spec.rb +6 -6
  33. data/spec/functional/resource/group_spec.rb +8 -6
  34. data/spec/functional/resource/ifconfig_spec.rb +3 -5
  35. data/spec/functional/resource/link_spec.rb +2 -2
  36. data/spec/functional/resource/mount_spec.rb +3 -7
  37. data/spec/functional/resource/powershell_script_spec.rb +9 -8
  38. data/spec/functional/resource/reboot_spec.rb +1 -1
  39. data/spec/functional/resource/remote_file_spec.rb +2 -2
  40. data/spec/functional/resource/template_spec.rb +1 -1
  41. data/spec/functional/resource/user/windows_spec.rb +2 -2
  42. data/spec/functional/resource/windows_certificate_spec.rb +3 -3
  43. data/spec/functional/resource/windows_service_spec.rb +3 -3
  44. data/spec/functional/resource/windows_task_spec.rb +51 -0
  45. data/spec/functional/run_lock_spec.rb +10 -3
  46. data/spec/functional/shell_spec.rb +1 -1
  47. data/spec/functional/util/powershell/cmdlet_spec.rb +1 -1
  48. data/spec/functional/version_spec.rb +1 -1
  49. data/spec/functional/win32/security_spec.rb +12 -7
  50. data/spec/functional/win32/service_manager_spec.rb +1 -1
  51. data/spec/functional/win32/version_info_spec.rb +4 -4
  52. data/spec/integration/client/client_spec.rb +114 -132
  53. data/spec/integration/client/exit_code_spec.rb +8 -8
  54. data/spec/integration/client/ipv6_spec.rb +5 -5
  55. data/spec/integration/knife/chef_fs_data_store_spec.rb +38 -38
  56. data/spec/integration/knife/chef_repo_path_spec.rb +42 -42
  57. data/spec/integration/knife/chef_repository_file_system_spec.rb +9 -9
  58. data/spec/integration/knife/chefignore_spec.rb +13 -13
  59. data/spec/integration/knife/client_bulk_delete_spec.rb +8 -8
  60. data/spec/integration/knife/client_create_spec.rb +1 -1
  61. data/spec/integration/knife/client_delete_spec.rb +4 -4
  62. data/spec/integration/knife/client_key_delete_spec.rb +1 -1
  63. data/spec/integration/knife/client_key_list_spec.rb +1 -1
  64. data/spec/integration/knife/client_list_spec.rb +1 -1
  65. data/spec/integration/knife/common_options_spec.rb +1 -1
  66. data/spec/integration/knife/config_get_spec.rb +1 -1
  67. data/spec/integration/knife/config_list_profiles_spec.rb +2 -1
  68. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +3 -3
  69. data/spec/integration/knife/cookbook_bulk_delete_spec.rb +3 -3
  70. data/spec/integration/knife/cookbook_download_spec.rb +4 -4
  71. data/spec/integration/knife/cookbook_list_spec.rb +2 -2
  72. data/spec/integration/knife/cookbook_show_spec.rb +3 -3
  73. data/spec/integration/knife/cookbook_upload_spec.rb +6 -6
  74. data/spec/integration/knife/data_bag_delete_spec.rb +4 -4
  75. data/spec/integration/knife/data_bag_from_file_spec.rb +7 -7
  76. data/spec/integration/knife/data_bag_list_spec.rb +1 -1
  77. data/spec/integration/knife/delete_spec.rb +37 -37
  78. data/spec/integration/knife/deps_spec.rb +23 -23
  79. data/spec/integration/knife/diff_spec.rb +23 -23
  80. data/spec/integration/knife/download_spec.rb +79 -79
  81. data/spec/integration/knife/environment_compare_spec.rb +3 -3
  82. data/spec/integration/knife/environment_from_file_spec.rb +6 -6
  83. data/spec/integration/knife/environment_list_spec.rb +1 -1
  84. data/spec/integration/knife/environment_show_spec.rb +4 -4
  85. data/spec/integration/knife/list_spec.rb +25 -25
  86. data/spec/integration/knife/node_bulk_delete_spec.rb +2 -2
  87. data/spec/integration/knife/node_delete_spec.rb +2 -2
  88. data/spec/integration/knife/node_environment_set_spec.rb +1 -1
  89. data/spec/integration/knife/node_from_file_spec.rb +2 -2
  90. data/spec/integration/knife/node_list_spec.rb +1 -1
  91. data/spec/integration/knife/raw_spec.rb +12 -12
  92. data/spec/integration/knife/redirection_spec.rb +1 -1
  93. data/spec/integration/knife/role_bulk_delete_spec.rb +2 -2
  94. data/spec/integration/knife/role_delete_spec.rb +2 -2
  95. data/spec/integration/knife/role_from_file_spec.rb +5 -5
  96. data/spec/integration/knife/role_list_spec.rb +1 -1
  97. data/spec/integration/knife/role_show_spec.rb +1 -1
  98. data/spec/integration/knife/show_spec.rb +10 -10
  99. data/spec/integration/knife/upload_spec.rb +85 -85
  100. data/spec/integration/recipes/accumulator_spec.rb +4 -4
  101. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +6 -6
  102. data/spec/integration/recipes/lwrp_spec.rb +6 -6
  103. data/spec/integration/recipes/notifies_spec.rb +45 -45
  104. data/spec/integration/recipes/notifying_block_spec.rb +4 -4
  105. data/spec/integration/recipes/provider_choice.rb +1 -2
  106. data/spec/integration/recipes/recipe_dsl_spec.rb +9 -9
  107. data/spec/integration/recipes/remote_directory.rb +2 -2
  108. data/spec/integration/recipes/resource_action_spec.rb +1 -1
  109. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +19 -19
  110. data/spec/integration/solo/solo_spec.rb +29 -29
  111. data/spec/scripts/ssl-serve.rb +1 -1
  112. data/spec/spec_helper.rb +11 -14
  113. data/spec/stress/win32/security_spec.rb +1 -1
  114. data/spec/support/lib/chef/resource/zen_follower.rb +1 -1
  115. data/spec/support/lib/chef/resource/zen_master.rb +1 -1
  116. data/spec/support/mock/platform.rb +2 -2
  117. data/spec/support/platform_helpers.rb +12 -3
  118. data/spec/support/platforms/win32/spec_service.rb +6 -10
  119. data/spec/support/shared/context/client.rb +2 -1
  120. data/spec/support/shared/functional/execute_resource.rb +4 -4
  121. data/spec/support/shared/functional/file_resource.rb +1 -3
  122. data/spec/support/shared/functional/http.rb +20 -44
  123. data/spec/support/shared/functional/securable_resource.rb +4 -8
  124. data/spec/support/shared/functional/win32_service.rb +1 -1
  125. data/spec/support/shared/functional/windows_script.rb +2 -1
  126. data/spec/support/shared/integration/app_server_support.rb +3 -4
  127. data/spec/support/shared/integration/integration_helper.rb +1 -0
  128. data/spec/support/shared/integration/knife_support.rb +5 -5
  129. data/spec/support/shared/unit/application_dot_d.rb +10 -4
  130. data/spec/support/shared/unit/file_system_support.rb +3 -2
  131. data/spec/support/shared/unit/platform_introspector.rb +12 -12
  132. data/spec/support/shared/unit/provider/file.rb +1 -1
  133. data/spec/support/shared/unit/script_resource.rb +1 -1
  134. data/spec/support/shared/unit/windows_script_resource.rb +1 -1
  135. data/spec/tiny_server.rb +1 -1
  136. data/spec/unit/api_client/registration_spec.rb +1 -1
  137. data/spec/unit/api_client_spec.rb +5 -5
  138. data/spec/unit/api_client_v1_spec.rb +6 -6
  139. data/spec/unit/application/client_spec.rb +8 -8
  140. data/spec/unit/application/exit_code_spec.rb +3 -2
  141. data/spec/unit/application/knife_spec.rb +1 -2
  142. data/spec/unit/audit/audit_event_proxy_spec.rb +14 -7
  143. data/spec/unit/audit/audit_reporter_spec.rb +20 -11
  144. data/spec/unit/audit/control_group_data_spec.rb +17 -12
  145. data/spec/unit/chef_fs/config_spec.rb +3 -3
  146. data/spec/unit/chef_fs/file_system/repository/directory_spec.rb +1 -1
  147. data/spec/unit/chef_fs/parallelizer.rb +1 -1
  148. data/spec/unit/client_spec.rb +3 -3
  149. data/spec/unit/config_fetcher_spec.rb +1 -1
  150. data/spec/unit/cookbook/metadata_spec.rb +13 -13
  151. data/spec/unit/cookbook/synchronizer_spec.rb +6 -6
  152. data/spec/unit/cookbook_loader_spec.rb +17 -17
  153. data/spec/unit/cookbook_manifest_spec.rb +9 -9
  154. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +1 -2
  155. data/spec/unit/cookbook_uploader_spec.rb +2 -2
  156. data/spec/unit/cookbook_version_file_specificity_spec.rb +9 -9
  157. data/spec/unit/cookbook_version_spec.rb +2 -2
  158. data/spec/unit/data_bag_item_spec.rb +7 -7
  159. data/spec/unit/data_bag_spec.rb +1 -1
  160. data/spec/unit/data_collector_spec.rb +23 -23
  161. data/spec/unit/decorator_spec.rb +2 -2
  162. data/spec/unit/deprecated_spec.rb +2 -2
  163. data/spec/unit/dsl/data_query_spec.rb +3 -2
  164. data/spec/unit/dsl/declare_resource_spec.rb +1 -1
  165. data/spec/unit/dsl/platform_introspection_spec.rb +2 -2
  166. data/spec/unit/encrypted_data_bag_item/check_encrypted_spec.rb +2 -1
  167. data/spec/unit/encrypted_data_bag_item_spec.rb +2 -1
  168. data/spec/unit/environment_spec.rb +13 -13
  169. data/spec/unit/event_dispatch/dsl_spec.rb +1 -1
  170. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +3 -3
  171. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +2 -2
  172. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +3 -3
  173. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +1 -1
  174. data/spec/unit/http/authenticator_spec.rb +4 -3
  175. data/spec/unit/http/json_input_spec.rb +1 -1
  176. data/spec/unit/http/socketless_chef_zero_client_spec.rb +15 -15
  177. data/spec/unit/key_spec.rb +8 -8
  178. data/spec/unit/knife/bootstrap_spec.rb +14 -10
  179. data/spec/unit/knife/client_bulk_delete_spec.rb +4 -4
  180. data/spec/unit/knife/configure_client_spec.rb +1 -1
  181. data/spec/unit/knife/configure_spec.rb +1 -1
  182. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +1 -1
  183. data/spec/unit/knife/cookbook_delete_spec.rb +2 -2
  184. data/spec/unit/knife/cookbook_download_spec.rb +2 -2
  185. data/spec/unit/knife/cookbook_metadata_spec.rb +4 -4
  186. data/spec/unit/knife/cookbook_upload_spec.rb +7 -5
  187. data/spec/unit/knife/core/bootstrap_context_spec.rb +1 -1
  188. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +2 -2
  189. data/spec/unit/knife/core/gem_glob_loader_spec.rb +4 -4
  190. data/spec/unit/knife/core/hashed_command_loader_spec.rb +4 -2
  191. data/spec/unit/knife/core/node_editor_spec.rb +12 -12
  192. data/spec/unit/knife/core/ui_spec.rb +11 -11
  193. data/spec/unit/knife/data_bag_from_file_spec.rb +2 -1
  194. data/spec/unit/knife/data_bag_show_spec.rb +2 -1
  195. data/spec/unit/knife/key_create_spec.rb +1 -1
  196. data/spec/unit/knife/key_delete_spec.rb +3 -3
  197. data/spec/unit/knife/key_edit_spec.rb +4 -4
  198. data/spec/unit/knife/key_list_spec.rb +1 -1
  199. data/spec/unit/knife/key_show_spec.rb +3 -3
  200. data/spec/unit/knife/node_bulk_delete_spec.rb +3 -3
  201. data/spec/unit/knife/node_delete_spec.rb +2 -2
  202. data/spec/unit/knife/node_edit_spec.rb +1 -1
  203. data/spec/unit/knife/node_environment_set_spec.rb +1 -1
  204. data/spec/unit/knife/node_from_file_spec.rb +1 -1
  205. data/spec/unit/knife/node_policy_set_spec.rb +1 -1
  206. data/spec/unit/knife/node_run_list_add_spec.rb +1 -1
  207. data/spec/unit/knife/node_run_list_remove_spec.rb +1 -1
  208. data/spec/unit/knife/node_run_list_set_spec.rb +1 -1
  209. data/spec/unit/knife/node_show_spec.rb +1 -1
  210. data/spec/unit/knife/raw_spec.rb +2 -2
  211. data/spec/unit/knife/role_bulk_delete_spec.rb +2 -2
  212. data/spec/unit/knife/role_create_spec.rb +1 -1
  213. data/spec/unit/knife/role_delete_spec.rb +1 -1
  214. data/spec/unit/knife/role_edit_spec.rb +1 -1
  215. data/spec/unit/knife/role_env_run_list_add_spec.rb +1 -1
  216. data/spec/unit/knife/role_env_run_list_clear_spec.rb +1 -1
  217. data/spec/unit/knife/role_env_run_list_remove_spec.rb +1 -1
  218. data/spec/unit/knife/role_env_run_list_replace_spec.rb +1 -1
  219. data/spec/unit/knife/role_env_run_list_set_spec.rb +1 -1
  220. data/spec/unit/knife/role_from_file_spec.rb +1 -1
  221. data/spec/unit/knife/role_run_list_add_spec.rb +1 -1
  222. data/spec/unit/knife/role_run_list_clear_spec.rb +1 -1
  223. data/spec/unit/knife/role_run_list_remove_spec.rb +1 -1
  224. data/spec/unit/knife/role_run_list_replace_spec.rb +1 -1
  225. data/spec/unit/knife/role_run_list_set_spec.rb +1 -1
  226. data/spec/unit/knife/ssh_spec.rb +27 -17
  227. data/spec/unit/knife/ssl_check_spec.rb +4 -4
  228. data/spec/unit/knife/ssl_fetch_spec.rb +5 -5
  229. data/spec/unit/knife/status_spec.rb +3 -2
  230. data/spec/unit/knife/supermarket_download_spec.rb +4 -4
  231. data/spec/unit/knife/supermarket_install_spec.rb +5 -4
  232. data/spec/unit/knife/supermarket_share_spec.rb +1 -1
  233. data/spec/unit/knife_spec.rb +34 -33
  234. data/spec/unit/lwrp_spec.rb +19 -19
  235. data/spec/unit/mixin/homebrew_user_spec.rb +1 -1
  236. data/spec/unit/mixin/params_validate_spec.rb +10 -10
  237. data/spec/unit/mixin/properties_spec.rb +4 -4
  238. data/spec/unit/mixin/shell_out_spec.rb +27 -27
  239. data/spec/unit/mixin/template_spec.rb +4 -8
  240. data/spec/unit/mixin/unformatter_spec.rb +1 -2
  241. data/spec/unit/mixin/user_context_spec.rb +1 -2
  242. data/spec/unit/mixin/which.rb +2 -0
  243. data/spec/unit/mixin/windows_architecture_helper_spec.rb +3 -3
  244. data/spec/unit/node/attribute_spec.rb +79 -79
  245. data/spec/unit/node/immutable_collections_spec.rb +50 -50
  246. data/spec/unit/node_spec.rb +16 -16
  247. data/spec/unit/org_spec.rb +3 -3
  248. data/spec/unit/policy_builder/policyfile_spec.rb +2 -2
  249. data/spec/unit/property/state_spec.rb +26 -25
  250. data/spec/unit/property/validation_spec.rb +14 -13
  251. data/spec/unit/property_spec.rb +10 -9
  252. data/spec/unit/provider/apt_update_spec.rb +6 -6
  253. data/spec/unit/provider/cron_spec.rb +15 -15
  254. data/spec/unit/provider/dsc_resource_spec.rb +6 -3
  255. data/spec/unit/provider/dsc_script_spec.rb +1 -1
  256. data/spec/unit/provider/execute_spec.rb +5 -5
  257. data/spec/unit/provider/git_spec.rb +39 -39
  258. data/spec/unit/provider/group/dscl_spec.rb +3 -3
  259. data/spec/unit/provider/group/groupadd_spec.rb +1 -1
  260. data/spec/unit/provider/group_spec.rb +2 -3
  261. data/spec/unit/provider/ifconfig/aix_spec.rb +1 -1
  262. data/spec/unit/provider/ifconfig/debian_spec.rb +2 -2
  263. data/spec/unit/provider/ifconfig_spec.rb +45 -16
  264. data/spec/unit/provider/launchd_spec.rb +23 -15
  265. data/spec/unit/provider/link_spec.rb +22 -11
  266. data/spec/unit/provider/mount/aix_spec.rb +6 -6
  267. data/spec/unit/provider/mount/mount_spec.rb +31 -31
  268. data/spec/unit/provider/mount/solaris_spec.rb +11 -11
  269. data/spec/unit/provider/ohai_spec.rb +1 -1
  270. data/spec/unit/provider/osx_profile_spec.rb +5 -7
  271. data/spec/unit/provider/package/apt_spec.rb +5 -5
  272. data/spec/unit/provider/package/bff_spec.rb +1 -1
  273. data/spec/unit/provider/package/cab_spec.rb +1 -1
  274. data/spec/unit/provider/package/chocolatey_spec.rb +8 -8
  275. data/spec/unit/provider/package/freebsd/pkg_spec.rb +1 -1
  276. data/spec/unit/provider/package/ips_spec.rb +6 -6
  277. data/spec/unit/provider/package/macports_spec.rb +1 -1
  278. data/spec/unit/provider/package/msu_spec.rb +1 -1
  279. data/spec/unit/provider/package/openbsd_spec.rb +15 -11
  280. data/spec/unit/provider/package/pacman_spec.rb +3 -3
  281. data/spec/unit/provider/package/paludis_spec.rb +4 -4
  282. data/spec/unit/provider/package/portage_spec.rb +1 -1
  283. data/spec/unit/provider/package/powershell_spec.rb +1 -1
  284. data/spec/unit/provider/package/smartos_spec.rb +3 -3
  285. data/spec/unit/provider/package/solaris_spec.rb +1 -1
  286. data/spec/unit/provider/package/windows/exe_spec.rb +9 -9
  287. data/spec/unit/provider/package/windows/msi_spec.rb +7 -7
  288. data/spec/unit/provider/package/windows_spec.rb +2 -1
  289. data/spec/unit/provider/package/yum/yum_cache_spec.rb +1 -1
  290. data/spec/unit/provider/package/zypper_spec.rb +4 -4
  291. data/spec/unit/provider/package_spec.rb +1 -1
  292. data/spec/unit/provider/powershell_script_spec.rb +7 -7
  293. data/spec/unit/provider/registry_key_spec.rb +1 -1
  294. data/spec/unit/provider/remote_directory_spec.rb +6 -6
  295. data/spec/unit/provider/route_spec.rb +11 -11
  296. data/spec/unit/provider/service/arch_service_spec.rb +13 -13
  297. data/spec/unit/provider/service/debian_service_spec.rb +2 -1
  298. data/spec/unit/provider/service/freebsd_service_spec.rb +28 -24
  299. data/spec/unit/provider/service/gentoo_service_spec.rb +2 -2
  300. data/spec/unit/provider/service/init_service_spec.rb +11 -11
  301. data/spec/unit/provider/service/invokercd_service_spec.rb +11 -11
  302. data/spec/unit/provider/service/macosx_spec.rb +5 -5
  303. data/spec/unit/provider/service/openbsd_service_spec.rb +15 -11
  304. data/spec/unit/provider/service/simple_service_spec.rb +7 -7
  305. data/spec/unit/provider/service/upstart_service_spec.rb +14 -14
  306. data/spec/unit/provider/service/windows_spec.rb +53 -35
  307. data/spec/unit/provider/subversion_spec.rb +8 -4
  308. data/spec/unit/provider/systemd_unit_spec.rb +142 -142
  309. data/spec/unit/provider/template/content_spec.rb +29 -29
  310. data/spec/unit/provider/windows_task_spec.rb +1 -1
  311. data/spec/unit/provider_resolver_spec.rb +75 -75
  312. data/spec/unit/provider_spec.rb +2 -4
  313. data/spec/unit/recipe_spec.rb +4 -4
  314. data/spec/unit/resource/batch_spec.rb +1 -1
  315. data/spec/unit/resource/chef_gem_spec.rb +1 -1
  316. data/spec/unit/resource/chocolatey_config_spec.rb +1 -1
  317. data/spec/unit/resource/chocolatey_source_spec.rb +1 -1
  318. data/spec/unit/resource/directory_spec.rb +1 -1
  319. data/spec/unit/resource/dnf_package_spec.rb +1 -1
  320. data/spec/unit/resource/dsc_resource_spec.rb +1 -1
  321. data/spec/unit/resource/file/verification_spec.rb +1 -2
  322. data/spec/unit/resource/file_spec.rb +1 -1
  323. data/spec/unit/resource/group_spec.rb +1 -1
  324. data/spec/unit/resource/link_spec.rb +1 -1
  325. data/spec/unit/resource/osx_profile_spec.rb +2 -1
  326. data/spec/unit/resource/powershell_script_spec.rb +12 -7
  327. data/spec/unit/resource/registry_key_spec.rb +3 -3
  328. data/spec/unit/resource/rhsm_subscription_spec.rb +1 -1
  329. data/spec/unit/resource/service_spec.rb +1 -1
  330. data/spec/unit/resource/template_spec.rb +2 -2
  331. data/spec/unit/resource/windows_env_spec.rb +1 -1
  332. data/spec/unit/resource/windows_service_spec.rb +5 -5
  333. data/spec/unit/resource/windows_task_spec.rb +6 -2
  334. data/spec/unit/resource/yum_package_spec.rb +1 -1
  335. data/spec/unit/resource_collection/resource_list_spec.rb +1 -1
  336. data/spec/unit/resource_collection/resource_set_spec.rb +7 -7
  337. data/spec/unit/resource_collection/stepable_iterator_spec.rb +2 -2
  338. data/spec/unit/resource_collection_spec.rb +4 -4
  339. data/spec/unit/resource_definition_spec.rb +2 -2
  340. data/spec/unit/resource_inspector_spec.rb +1 -1
  341. data/spec/unit/resource_reporter_spec.rb +4 -4
  342. data/spec/unit/resource_spec.rb +22 -22
  343. data/spec/unit/role_spec.rb +3 -3
  344. data/spec/unit/run_context/cookbook_compiler_spec.rb +23 -23
  345. data/spec/unit/run_list/run_list_expansion_spec.rb +9 -6
  346. data/spec/unit/run_list_spec.rb +1 -1
  347. data/spec/unit/runner_spec.rb +3 -3
  348. data/spec/unit/search/query_spec.rb +3 -2
  349. data/spec/unit/shell/model_wrapper_spec.rb +1 -1
  350. data/spec/unit/shell/shell_session_spec.rb +8 -11
  351. data/spec/unit/shell_spec.rb +1 -2
  352. data/spec/unit/user_spec.rb +4 -4
  353. data/spec/unit/user_v1_spec.rb +3 -3
  354. data/spec/unit/util/backup_spec.rb +1 -1
  355. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +13 -13
  356. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +3 -3
  357. data/spec/unit/util/editor_spec.rb +1 -1
  358. data/spec/unit/util/powershell/ps_credential_spec.rb +3 -2
  359. data/spec/unit/util/threaded_job_queue_spec.rb +2 -2
  360. data/spec/unit/version_class_spec.rb +4 -4
  361. data/spec/unit/win32/registry_spec.rb +5 -5
  362. data/spec/unit/win32/security_spec.rb +2 -1
  363. data/tasks/announce.rb +4 -11
  364. metadata +10 -6
  365. data/tasks/maintainers.rb +0 -211
  366. data/tasks/templates/prerelease.md.erb +0 -35
@@ -43,8 +43,10 @@ describe Chef::Knife::SubcommandLoader::HashedCommandLoader do
43
43
 
44
44
  let(:loader) do
45
45
  Chef::Knife::SubcommandLoader::HashedCommandLoader.new(
46
- File.join(CHEF_SPEC_DATA, "knife-site-subcommands"),
47
- plugin_manifest) end
46
+ File.join(CHEF_SPEC_DATA, "knife-site-subcommands"),
47
+ plugin_manifest
48
+ )
49
+ end
48
50
 
49
51
  describe "#list_commands" do
50
52
  before do
@@ -24,10 +24,10 @@ describe Chef::Knife::NodeEditor do
24
24
  { "name" => "test_node",
25
25
  "chef_environment" => "production",
26
26
  "automatic" => { "foo" => "bar" },
27
- "default" => { "alpha" => { "bravo" => "charlie", "delta" => "echo" } },
28
- "normal" => { "alpha" => { "bravo" => "hotel" }, "tags" => [] },
29
- "override" => { "alpha" => { "bravo" => "foxtrot", "delta" => "golf" } },
30
- "policy_name" => nil,
27
+ "default" => { "alpha" => { "bravo" => "charlie", "delta" => "echo" } },
28
+ "normal" => { "alpha" => { "bravo" => "hotel" }, "tags" => [] },
29
+ "override" => { "alpha" => { "bravo" => "foxtrot", "delta" => "golf" } },
30
+ "policy_name" => nil,
31
31
  "policy_group" => nil,
32
32
  "run_list" => %w{role[comedy] role[drama] recipe[mystery]},
33
33
  }
@@ -44,13 +44,13 @@ describe Chef::Knife::NodeEditor do
44
44
  describe "#view" do
45
45
  it "returns a Hash with only the name, chef_environment, normal, " +
46
46
  "policy_name, policy_group, and run_list properties" do
47
- expected = node_data.select do |key,|
48
- %w{ name chef_environment normal
49
- policy_name policy_group run_list }.include?(key)
50
- end
47
+ expected = node_data.select do |key,|
48
+ %w{ name chef_environment normal
49
+ policy_name policy_group run_list }.include?(key)
50
+ end
51
51
 
52
- expect(subject.view).to eq(expected)
53
- end
52
+ expect(subject.view).to eq(expected)
53
+ end
54
54
 
55
55
  context "when config[:all_attributes] == true" do
56
56
  let(:config) { base_config.merge(all_attributes: true) }
@@ -190,8 +190,8 @@ describe Chef::Knife::NodeEditor do
190
190
 
191
191
  it "returns an array of property names that doesn't include " +
192
192
  "the non-editable properties" do
193
- expect(subject.updated?).to eql %w{ chef_environment normal policy_name policy_group run_list }
194
- end
193
+ expect(subject.updated?).to eql %w{ chef_environment normal policy_name policy_group run_list }
194
+ end
195
195
  end
196
196
  end
197
197
 
@@ -214,7 +214,7 @@ describe Chef::Knife::UI do
214
214
  expect(@out.string).to eq <<~EOM
215
215
  hi: a
216
216
  lo: b
217
- EOM
217
+ EOM
218
218
  end
219
219
 
220
220
  it "formats empty hashes appropriately" do
@@ -227,7 +227,7 @@ EOM
227
227
  expect(@out.string).to eq <<~EOM
228
228
  a
229
229
  b
230
- EOM
230
+ EOM
231
231
  end
232
232
 
233
233
  it "formats empty arrays appropriately" do
@@ -253,7 +253,7 @@ EOM
253
253
 
254
254
  c
255
255
  d
256
- EOM
256
+ EOM
257
257
  end
258
258
 
259
259
  it "formats nested arrays with single- and empty subarrays appropriately" do
@@ -267,7 +267,7 @@ EOM
267
267
 
268
268
  d
269
269
  e
270
- EOM
270
+ EOM
271
271
  end
272
272
 
273
273
  it "formats arrays of hashes with extra lines in between for readability" do
@@ -280,7 +280,7 @@ EOM
280
280
 
281
281
  m: n
282
282
  o: p
283
- EOM
283
+ EOM
284
284
  end
285
285
 
286
286
  it "formats hashes with empty array members appropriately" do
@@ -288,7 +288,7 @@ EOM
288
288
  expect(@out.string).to eq <<~EOM
289
289
  a:
290
290
  b: c
291
- EOM
291
+ EOM
292
292
  end
293
293
 
294
294
  it "formats hashes with single-member array values appropriately" do
@@ -296,7 +296,7 @@ EOM
296
296
  expect(@out.string).to eq <<~EOM
297
297
  a: foo
298
298
  b: c
299
- EOM
299
+ EOM
300
300
  end
301
301
 
302
302
  it "formats hashes with array members appropriately" do
@@ -306,7 +306,7 @@ EOM
306
306
  foo
307
307
  bar
308
308
  b: c
309
- EOM
309
+ EOM
310
310
  end
311
311
 
312
312
  it "formats hashes with single-member nested array values appropriately" do
@@ -315,7 +315,7 @@ EOM
315
315
  a:
316
316
  foo
317
317
  b: c
318
- EOM
318
+ EOM
319
319
  end
320
320
 
321
321
  it "formats hashes with nested array values appropriately" do
@@ -332,7 +332,7 @@ EOM
332
332
  aa: bb
333
333
  cc: dd
334
334
  b: c
335
- EOM
335
+ EOM
336
336
  end
337
337
 
338
338
  it "formats hashes with empty hash values appropriately" do
@@ -340,7 +340,7 @@ EOM
340
340
  expect(@out.string).to eq <<~EOM
341
341
  a:
342
342
  b: c
343
- EOM
343
+ EOM
344
344
  end
345
345
  end
346
346
 
@@ -77,7 +77,8 @@ describe Chef::Knife::DataBagFromFile do
77
77
  "id" => "item_name",
78
78
  "greeting" => "hello",
79
79
  "nested" => { "a1" => [1, 2, 3], "a2" => { "b1" => true } },
80
- } end
80
+ }
81
+ end
81
82
  let(:enc_data) { Chef::EncryptedDataBagItem.encrypt_data_bag_item(plain_data, secret) }
82
83
 
83
84
  let(:rest) { double("Chef::ServerAPI") }
@@ -47,7 +47,8 @@ describe Chef::Knife::DataBagShow do
47
47
 
48
48
  let(:data_bag_contents) do
49
49
  { "id" => "id", "baz" => "http://localhost:4000/data/bag_o_data/baz",
50
- "qux" => "http://localhost:4000/data/bag_o_data/qux" } end
50
+ "qux" => "http://localhost:4000/data/bag_o_data/qux" }
51
+ end
51
52
  let(:enc_hash) { Chef::EncryptedDataBagItem.encrypt_data_bag_item(data_bag_contents, secret) }
52
53
  let(:data_bag) { Chef::DataBagItem.from_hash(data_bag_contents) }
53
54
  let(:data_bag_with_encoded_hash) { Chef::DataBagItem.from_hash(enc_hash) }
@@ -84,7 +84,7 @@ Tfuc9dUYsFjptWYrV6pfEQ+bgo1OGBXORBFcFL+2D7u9JYquKrMgosznHoEkQNLo
84
84
  0wIDAQAB
85
85
  -----END PUBLIC KEY-----"
86
86
  end
87
- let(:config) { Hash.new }
87
+ let(:config) { {} }
88
88
  let(:actor) { "charmander" }
89
89
  let(:ui) { instance_double("Chef::Knife::UI") }
90
90
 
@@ -37,7 +37,7 @@ describe "key delete commands that inherit knife" do
37
37
  end
38
38
 
39
39
  context "after apply_params! is called with valid args" do
40
- let(:params) { ["charmander", "charmander-key"] }
40
+ let(:params) { %w{charmander charmander-key} }
41
41
  before do
42
42
  command.apply_params!(params)
43
43
  end
@@ -59,7 +59,7 @@ describe "key delete commands that inherit knife" do
59
59
  it_should_behave_like "a knife key command with a keyname as the second arg"
60
60
  it_should_behave_like "a knife key command" do
61
61
  let(:service_object) { instance_double(Chef::Knife::KeyDelete) }
62
- let(:params) { ["charmander", "charmander-key"] }
62
+ let(:params) { %w{charmander charmander-key} }
63
63
  end
64
64
  end
65
65
 
@@ -69,7 +69,7 @@ describe "key delete commands that inherit knife" do
69
69
  it_should_behave_like "a knife key command with a keyname as the second arg"
70
70
  it_should_behave_like "a knife key command" do
71
71
  let(:service_object) { instance_double(Chef::Knife::KeyDelete) }
72
- let(:params) { ["charmander", "charmander-key"] }
72
+ let(:params) { %w{charmander charmander-key} }
73
73
  end
74
74
  end
75
75
  end
@@ -37,7 +37,7 @@ describe "key edit commands that inherit knife" do
37
37
  end
38
38
 
39
39
  context "after apply_params! is called with valid args" do
40
- let(:params) { ["charmander", "charmander-key"] }
40
+ let(:params) { %w{charmander charmander-key} }
41
41
  before do
42
42
  command.apply_params!(params)
43
43
  end
@@ -59,7 +59,7 @@ describe "key edit commands that inherit knife" do
59
59
  it_should_behave_like "a knife key command with a keyname as the second arg"
60
60
  it_should_behave_like "a knife key command" do
61
61
  let(:service_object) { instance_double(Chef::Knife::KeyEdit) }
62
- let(:params) { ["charmander", "charmander-key"] }
62
+ let(:params) { %w{charmander charmander-key} }
63
63
  end
64
64
  end
65
65
 
@@ -69,7 +69,7 @@ describe "key edit commands that inherit knife" do
69
69
  it_should_behave_like "a knife key command with a keyname as the second arg"
70
70
  it_should_behave_like "a knife key command" do
71
71
  let(:service_object) { instance_double(Chef::Knife::KeyEdit) }
72
- let(:params) { ["charmander", "charmander-key"] }
72
+ let(:params) { %w{charmander charmander-key} }
73
73
  end
74
74
  end
75
75
  end
@@ -86,7 +86,7 @@ Tfuc9dUYsFjptWYrV6pfEQ+bgo1OGBXORBFcFL+2D7u9JYquKrMgosznHoEkQNLo
86
86
  0wIDAQAB
87
87
  -----END PUBLIC KEY-----"
88
88
  end
89
- let(:config) { Hash.new }
89
+ let(:config) { {} }
90
90
  let(:actor) { "charmander" }
91
91
  let(:keyname) { "charmander-key" }
92
92
  let(:ui) { instance_double("Chef::Knife::UI") }
@@ -73,7 +73,7 @@ describe "key list commands that inherit knife" do
73
73
  end
74
74
 
75
75
  describe Chef::Knife::KeyList do
76
- let(:config) { Hash.new }
76
+ let(:config) { {} }
77
77
  let(:actor) { "charmander" }
78
78
  let(:ui) { instance_double("Chef::Knife::UI") }
79
79
 
@@ -37,7 +37,7 @@ describe "key show commands that inherit knife" do
37
37
  end
38
38
 
39
39
  context "after apply_params! is called with valid args" do
40
- let(:params) { ["charmander", "charmander-key"] }
40
+ let(:params) { %w{charmander charmander-key} }
41
41
  before do
42
42
  command.apply_params!(params)
43
43
  end
@@ -59,7 +59,7 @@ describe "key show commands that inherit knife" do
59
59
  it_should_behave_like "a knife key command with a keyname as the second arg"
60
60
  it_should_behave_like "a knife key command" do
61
61
  let(:service_object) { instance_double(Chef::Knife::KeyShow) }
62
- let(:params) { ["charmander", "charmander-key"] }
62
+ let(:params) { %w{charmander charmander-key} }
63
63
  end
64
64
  end
65
65
 
@@ -69,7 +69,7 @@ describe "key show commands that inherit knife" do
69
69
  it_should_behave_like "a knife key command with a keyname as the second arg"
70
70
  it_should_behave_like "a knife key command" do
71
71
  let(:service_object) { instance_double(Chef::Knife::KeyShow) }
72
- let(:params) { ["charmander", "charmander-key"] }
72
+ let(:params) { %w{charmander charmander-key} }
73
73
  end
74
74
  end
75
75
  end
@@ -28,7 +28,7 @@ describe Chef::Knife::NodeBulkDelete do
28
28
  @stdout = StringIO.new
29
29
  allow(@knife.ui).to receive(:stdout).and_return(@stdout)
30
30
  allow(@knife.ui).to receive(:confirm).and_return(true)
31
- @nodes = Hash.new
31
+ @nodes = {}
32
32
  %w{adam brent jacob}.each do |node_name|
33
33
  @nodes[node_name] = "http://localhost:4000/nodes/#{node_name}"
34
34
  end
@@ -44,14 +44,14 @@ describe Chef::Knife::NodeBulkDelete do
44
44
  # I hate not having == defined for anything :(
45
45
  actual = @knife.all_nodes
46
46
  expect(actual.keys).to match_array(expected.keys)
47
- expect(actual.values.map { |n| n.name }).to match_array(%w{adam brent jacob})
47
+ expect(actual.values.map(&:name)).to match_array(%w{adam brent jacob})
48
48
  end
49
49
  end
50
50
 
51
51
  describe "run" do
52
52
  before do
53
53
  @inflatedish_list = @nodes.keys.inject({}) do |nodes_by_name, name|
54
- node = Chef::Node.new()
54
+ node = Chef::Node.new
55
55
  node.name(name)
56
56
  allow(node).to receive(:destroy).and_return(true)
57
57
  nodes_by_name[name] = node
@@ -29,8 +29,8 @@ describe Chef::Knife::NodeDelete do
29
29
  allow(@knife).to receive(:output).and_return(true)
30
30
  allow(@knife).to receive(:confirm).and_return(true)
31
31
 
32
- @adam_node = Chef::Node.new()
33
- @ben_node = Chef::Node.new()
32
+ @adam_node = Chef::Node.new
33
+ @ben_node = Chef::Node.new
34
34
  allow(@ben_node).to receive(:destroy).and_return(true)
35
35
  allow(@adam_node).to receive(:destroy).and_return(true)
36
36
  allow(Chef::Node).to receive(:load).with("adam").and_return(@adam_node)
@@ -35,7 +35,7 @@ describe Chef::Knife::NodeEdit do
35
35
  print_after: nil,
36
36
  }
37
37
  @knife.name_args = [ "adam" ]
38
- @node = Chef::Node.new()
38
+ @node = Chef::Node.new
39
39
  end
40
40
 
41
41
  it "should load the node" do
@@ -24,7 +24,7 @@ describe Chef::Knife::NodeEnvironmentSet do
24
24
  @knife = Chef::Knife::NodeEnvironmentSet.new
25
25
  @knife.name_args = %w{adam bar}
26
26
  allow(@knife).to receive(:output).and_return(true)
27
- @node = Chef::Node.new()
27
+ @node = Chef::Node.new
28
28
  @node.name("knifetest-node")
29
29
  @node.chef_environment << "foo"
30
30
  allow(@node).to receive(:save).and_return(true)
@@ -30,7 +30,7 @@ describe Chef::Knife::NodeFromFile do
30
30
  @knife.name_args = [ "adam.rb" ]
31
31
  allow(@knife).to receive(:output).and_return(true)
32
32
  allow(@knife).to receive(:confirm).and_return(true)
33
- @node = Chef::Node.new()
33
+ @node = Chef::Node.new
34
34
  allow(@node).to receive(:save)
35
35
  allow(@knife.loader).to receive(:load_from).and_return(@node)
36
36
  @stdout = StringIO.new
@@ -20,7 +20,7 @@ require "spec_helper"
20
20
 
21
21
  describe Chef::Knife::NodePolicySet do
22
22
  let(:node) do
23
- node = Chef::Node.new()
23
+ node = Chef::Node.new
24
24
  node.name("adam")
25
25
  node.run_list = ["role[base]"]
26
26
  node
@@ -27,7 +27,7 @@ describe Chef::Knife::NodeRunListAdd do
27
27
  }
28
28
  @knife.name_args = [ "adam", "role[monkey]" ]
29
29
  allow(@knife).to receive(:output).and_return(true)
30
- @node = Chef::Node.new()
30
+ @node = Chef::Node.new
31
31
  allow(@node).to receive(:save).and_return(true)
32
32
  allow(Chef::Node).to receive(:load).and_return(@node)
33
33
  end
@@ -24,7 +24,7 @@ describe Chef::Knife::NodeRunListRemove do
24
24
  @knife = Chef::Knife::NodeRunListRemove.new
25
25
  @knife.config[:print_after] = nil
26
26
  @knife.name_args = [ "adam", "role[monkey]" ]
27
- @node = Chef::Node.new()
27
+ @node = Chef::Node.new
28
28
  @node.name("knifetest-node")
29
29
  @node.run_list << "role[monkey]"
30
30
  allow(@node).to receive(:save).and_return(true)
@@ -25,7 +25,7 @@ describe Chef::Knife::NodeRunListSet do
25
25
  @knife.config = {}
26
26
  @knife.name_args = [ "adam", "role[monkey]" ]
27
27
  allow(@knife).to receive(:output).and_return(true)
28
- @node = Chef::Node.new()
28
+ @node = Chef::Node.new
29
29
  allow(@node).to receive(:save).and_return(true)
30
30
  allow(Chef::Node).to receive(:load).and_return(@node)
31
31
  end
@@ -21,7 +21,7 @@ require "spec_helper"
21
21
  describe Chef::Knife::NodeShow do
22
22
 
23
23
  let(:node) do
24
- node = Chef::Node.new()
24
+ node = Chef::Node.new
25
25
  node.name("adam")
26
26
  node.run_list = ["role[base]"]
27
27
  node
@@ -35,8 +35,8 @@ describe Chef::Knife::Raw do
35
35
  it "should set the x-ops-request-source header when --proxy-auth is set" do
36
36
  knife.config[:proxy_auth] = true
37
37
  expect(rest).to receive(:request).with(:GET, "/nodes",
38
- { "Content-Type" => "application/json",
39
- "x-ops-request-source" => "web" }, false)
38
+ { "Content-Type" => "application/json",
39
+ "x-ops-request-source" => "web" }, false)
40
40
  knife.run
41
41
  end
42
42
  end
@@ -29,9 +29,9 @@ describe Chef::Knife::RoleBulkDelete do
29
29
  @stdout = StringIO.new
30
30
  allow(@knife.ui).to receive(:stdout).and_return(@stdout)
31
31
  allow(@knife.ui).to receive(:confirm).and_return(true)
32
- @roles = Hash.new
32
+ @roles = {}
33
33
  %w{dev staging production}.each do |role_name|
34
- role = Chef::Role.new()
34
+ role = Chef::Role.new
35
35
  role.name(role_name)
36
36
  allow(role).to receive(:destroy).and_return(true)
37
37
  @roles[role_name] = role
@@ -27,7 +27,7 @@ describe Chef::Knife::RoleCreate do
27
27
  }
28
28
  @knife.name_args = [ "adam" ]
29
29
  allow(@knife).to receive(:output).and_return(true)
30
- @role = Chef::Role.new()
30
+ @role = Chef::Role.new
31
31
  allow(@role).to receive(:save)
32
32
  allow(Chef::Role).to receive(:new).and_return(@role)
33
33
  allow(@knife).to receive(:edit_data).and_return(@role)
@@ -28,7 +28,7 @@ describe Chef::Knife::RoleDelete do
28
28
  @knife.name_args = [ "adam" ]
29
29
  allow(@knife).to receive(:output).and_return(true)
30
30
  allow(@knife).to receive(:confirm).and_return(true)
31
- @role = Chef::Role.new()
31
+ @role = Chef::Role.new
32
32
  allow(@role).to receive(:destroy).and_return(true)
33
33
  allow(Chef::Role).to receive(:load).and_return(@role)
34
34
  @stdout = StringIO.new