chef 14.14.29-universal-mingw32 → 14.15.6-universal-mingw32

Sign up to get free protection for your applications and to get access to all the features.
Files changed (366) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -1
  3. data/README.md +18 -7
  4. data/Rakefile +7 -4
  5. data/chef.gemspec +1 -1
  6. data/lib/chef/knife/ssh.rb +6 -0
  7. data/lib/chef/provider/ifconfig.rb +14 -5
  8. data/lib/chef/provider/windows_task.rb +9 -5
  9. data/lib/chef/resource/kernel_module.rb +61 -0
  10. data/lib/chef/resource/windows_task.rb +4 -0
  11. data/lib/chef/version.rb +1 -1
  12. data/spec/data/cookbooks/openldap/metadata.rb +2 -2
  13. data/spec/data/metadata/quick_start/metadata.rb +2 -7
  14. data/spec/functional/audit/runner_spec.rb +1 -1
  15. data/spec/functional/dsl/reboot_pending_spec.rb +7 -25
  16. data/spec/functional/event_loggers/windows_eventlog_spec.rb +6 -4
  17. data/spec/functional/file_content_management/deploy_strategies_spec.rb +21 -21
  18. data/spec/functional/knife/exec_spec.rb +1 -1
  19. data/spec/functional/knife/ssh_spec.rb +3 -3
  20. data/spec/functional/mixin/user_context_spec.rb +3 -1
  21. data/spec/functional/rebooter_spec.rb +1 -1
  22. data/spec/functional/resource/aix_service_spec.rb +1 -1
  23. data/spec/functional/resource/aixinit_service_spec.rb +1 -1
  24. data/spec/functional/resource/apt_package_spec.rb +1 -1
  25. data/spec/functional/resource/chocolatey_package_spec.rb +2 -2
  26. data/spec/functional/resource/cookbook_file_spec.rb +1 -3
  27. data/spec/functional/resource/cron_spec.rb +4 -3
  28. data/spec/functional/resource/dpkg_package_spec.rb +4 -4
  29. data/spec/functional/resource/dsc_resource_spec.rb +2 -1
  30. data/spec/functional/resource/dsc_script_spec.rb +16 -20
  31. data/spec/functional/resource/execute_spec.rb +2 -2
  32. data/spec/functional/resource/git_spec.rb +6 -6
  33. data/spec/functional/resource/group_spec.rb +8 -6
  34. data/spec/functional/resource/ifconfig_spec.rb +3 -5
  35. data/spec/functional/resource/link_spec.rb +2 -2
  36. data/spec/functional/resource/mount_spec.rb +3 -7
  37. data/spec/functional/resource/powershell_script_spec.rb +9 -8
  38. data/spec/functional/resource/reboot_spec.rb +1 -1
  39. data/spec/functional/resource/remote_file_spec.rb +2 -2
  40. data/spec/functional/resource/template_spec.rb +1 -1
  41. data/spec/functional/resource/user/windows_spec.rb +2 -2
  42. data/spec/functional/resource/windows_certificate_spec.rb +3 -3
  43. data/spec/functional/resource/windows_service_spec.rb +3 -3
  44. data/spec/functional/resource/windows_task_spec.rb +51 -0
  45. data/spec/functional/run_lock_spec.rb +10 -3
  46. data/spec/functional/shell_spec.rb +1 -1
  47. data/spec/functional/util/powershell/cmdlet_spec.rb +1 -1
  48. data/spec/functional/version_spec.rb +1 -1
  49. data/spec/functional/win32/security_spec.rb +12 -7
  50. data/spec/functional/win32/service_manager_spec.rb +1 -1
  51. data/spec/functional/win32/version_info_spec.rb +4 -4
  52. data/spec/integration/client/client_spec.rb +114 -132
  53. data/spec/integration/client/exit_code_spec.rb +8 -8
  54. data/spec/integration/client/ipv6_spec.rb +5 -5
  55. data/spec/integration/knife/chef_fs_data_store_spec.rb +38 -38
  56. data/spec/integration/knife/chef_repo_path_spec.rb +42 -42
  57. data/spec/integration/knife/chef_repository_file_system_spec.rb +9 -9
  58. data/spec/integration/knife/chefignore_spec.rb +13 -13
  59. data/spec/integration/knife/client_bulk_delete_spec.rb +8 -8
  60. data/spec/integration/knife/client_create_spec.rb +1 -1
  61. data/spec/integration/knife/client_delete_spec.rb +4 -4
  62. data/spec/integration/knife/client_key_delete_spec.rb +1 -1
  63. data/spec/integration/knife/client_key_list_spec.rb +1 -1
  64. data/spec/integration/knife/client_list_spec.rb +1 -1
  65. data/spec/integration/knife/common_options_spec.rb +1 -1
  66. data/spec/integration/knife/config_get_spec.rb +1 -1
  67. data/spec/integration/knife/config_list_profiles_spec.rb +2 -1
  68. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +3 -3
  69. data/spec/integration/knife/cookbook_bulk_delete_spec.rb +3 -3
  70. data/spec/integration/knife/cookbook_download_spec.rb +4 -4
  71. data/spec/integration/knife/cookbook_list_spec.rb +2 -2
  72. data/spec/integration/knife/cookbook_show_spec.rb +3 -3
  73. data/spec/integration/knife/cookbook_upload_spec.rb +6 -6
  74. data/spec/integration/knife/data_bag_delete_spec.rb +4 -4
  75. data/spec/integration/knife/data_bag_from_file_spec.rb +7 -7
  76. data/spec/integration/knife/data_bag_list_spec.rb +1 -1
  77. data/spec/integration/knife/delete_spec.rb +37 -37
  78. data/spec/integration/knife/deps_spec.rb +23 -23
  79. data/spec/integration/knife/diff_spec.rb +23 -23
  80. data/spec/integration/knife/download_spec.rb +79 -79
  81. data/spec/integration/knife/environment_compare_spec.rb +3 -3
  82. data/spec/integration/knife/environment_from_file_spec.rb +6 -6
  83. data/spec/integration/knife/environment_list_spec.rb +1 -1
  84. data/spec/integration/knife/environment_show_spec.rb +4 -4
  85. data/spec/integration/knife/list_spec.rb +25 -25
  86. data/spec/integration/knife/node_bulk_delete_spec.rb +2 -2
  87. data/spec/integration/knife/node_delete_spec.rb +2 -2
  88. data/spec/integration/knife/node_environment_set_spec.rb +1 -1
  89. data/spec/integration/knife/node_from_file_spec.rb +2 -2
  90. data/spec/integration/knife/node_list_spec.rb +1 -1
  91. data/spec/integration/knife/raw_spec.rb +12 -12
  92. data/spec/integration/knife/redirection_spec.rb +1 -1
  93. data/spec/integration/knife/role_bulk_delete_spec.rb +2 -2
  94. data/spec/integration/knife/role_delete_spec.rb +2 -2
  95. data/spec/integration/knife/role_from_file_spec.rb +5 -5
  96. data/spec/integration/knife/role_list_spec.rb +1 -1
  97. data/spec/integration/knife/role_show_spec.rb +1 -1
  98. data/spec/integration/knife/show_spec.rb +10 -10
  99. data/spec/integration/knife/upload_spec.rb +85 -85
  100. data/spec/integration/recipes/accumulator_spec.rb +4 -4
  101. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +6 -6
  102. data/spec/integration/recipes/lwrp_spec.rb +6 -6
  103. data/spec/integration/recipes/notifies_spec.rb +45 -45
  104. data/spec/integration/recipes/notifying_block_spec.rb +4 -4
  105. data/spec/integration/recipes/provider_choice.rb +1 -2
  106. data/spec/integration/recipes/recipe_dsl_spec.rb +9 -9
  107. data/spec/integration/recipes/remote_directory.rb +2 -2
  108. data/spec/integration/recipes/resource_action_spec.rb +1 -1
  109. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +19 -19
  110. data/spec/integration/solo/solo_spec.rb +29 -29
  111. data/spec/scripts/ssl-serve.rb +1 -1
  112. data/spec/spec_helper.rb +11 -14
  113. data/spec/stress/win32/security_spec.rb +1 -1
  114. data/spec/support/lib/chef/resource/zen_follower.rb +1 -1
  115. data/spec/support/lib/chef/resource/zen_master.rb +1 -1
  116. data/spec/support/mock/platform.rb +2 -2
  117. data/spec/support/platform_helpers.rb +12 -3
  118. data/spec/support/platforms/win32/spec_service.rb +6 -10
  119. data/spec/support/shared/context/client.rb +2 -1
  120. data/spec/support/shared/functional/execute_resource.rb +4 -4
  121. data/spec/support/shared/functional/file_resource.rb +1 -3
  122. data/spec/support/shared/functional/http.rb +20 -44
  123. data/spec/support/shared/functional/securable_resource.rb +4 -8
  124. data/spec/support/shared/functional/win32_service.rb +1 -1
  125. data/spec/support/shared/functional/windows_script.rb +2 -1
  126. data/spec/support/shared/integration/app_server_support.rb +3 -4
  127. data/spec/support/shared/integration/integration_helper.rb +1 -0
  128. data/spec/support/shared/integration/knife_support.rb +5 -5
  129. data/spec/support/shared/unit/application_dot_d.rb +10 -4
  130. data/spec/support/shared/unit/file_system_support.rb +3 -2
  131. data/spec/support/shared/unit/platform_introspector.rb +12 -12
  132. data/spec/support/shared/unit/provider/file.rb +1 -1
  133. data/spec/support/shared/unit/script_resource.rb +1 -1
  134. data/spec/support/shared/unit/windows_script_resource.rb +1 -1
  135. data/spec/tiny_server.rb +1 -1
  136. data/spec/unit/api_client/registration_spec.rb +1 -1
  137. data/spec/unit/api_client_spec.rb +5 -5
  138. data/spec/unit/api_client_v1_spec.rb +6 -6
  139. data/spec/unit/application/client_spec.rb +8 -8
  140. data/spec/unit/application/exit_code_spec.rb +3 -2
  141. data/spec/unit/application/knife_spec.rb +1 -2
  142. data/spec/unit/audit/audit_event_proxy_spec.rb +14 -7
  143. data/spec/unit/audit/audit_reporter_spec.rb +20 -11
  144. data/spec/unit/audit/control_group_data_spec.rb +17 -12
  145. data/spec/unit/chef_fs/config_spec.rb +3 -3
  146. data/spec/unit/chef_fs/file_system/repository/directory_spec.rb +1 -1
  147. data/spec/unit/chef_fs/parallelizer.rb +1 -1
  148. data/spec/unit/client_spec.rb +3 -3
  149. data/spec/unit/config_fetcher_spec.rb +1 -1
  150. data/spec/unit/cookbook/metadata_spec.rb +13 -13
  151. data/spec/unit/cookbook/synchronizer_spec.rb +6 -6
  152. data/spec/unit/cookbook_loader_spec.rb +17 -17
  153. data/spec/unit/cookbook_manifest_spec.rb +9 -9
  154. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +1 -2
  155. data/spec/unit/cookbook_uploader_spec.rb +2 -2
  156. data/spec/unit/cookbook_version_file_specificity_spec.rb +9 -9
  157. data/spec/unit/cookbook_version_spec.rb +2 -2
  158. data/spec/unit/data_bag_item_spec.rb +7 -7
  159. data/spec/unit/data_bag_spec.rb +1 -1
  160. data/spec/unit/data_collector_spec.rb +23 -23
  161. data/spec/unit/decorator_spec.rb +2 -2
  162. data/spec/unit/deprecated_spec.rb +2 -2
  163. data/spec/unit/dsl/data_query_spec.rb +3 -2
  164. data/spec/unit/dsl/declare_resource_spec.rb +1 -1
  165. data/spec/unit/dsl/platform_introspection_spec.rb +2 -2
  166. data/spec/unit/encrypted_data_bag_item/check_encrypted_spec.rb +2 -1
  167. data/spec/unit/encrypted_data_bag_item_spec.rb +2 -1
  168. data/spec/unit/environment_spec.rb +13 -13
  169. data/spec/unit/event_dispatch/dsl_spec.rb +1 -1
  170. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +3 -3
  171. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +2 -2
  172. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +3 -3
  173. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +1 -1
  174. data/spec/unit/http/authenticator_spec.rb +4 -3
  175. data/spec/unit/http/json_input_spec.rb +1 -1
  176. data/spec/unit/http/socketless_chef_zero_client_spec.rb +15 -15
  177. data/spec/unit/key_spec.rb +8 -8
  178. data/spec/unit/knife/bootstrap_spec.rb +14 -10
  179. data/spec/unit/knife/client_bulk_delete_spec.rb +4 -4
  180. data/spec/unit/knife/configure_client_spec.rb +1 -1
  181. data/spec/unit/knife/configure_spec.rb +1 -1
  182. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +1 -1
  183. data/spec/unit/knife/cookbook_delete_spec.rb +2 -2
  184. data/spec/unit/knife/cookbook_download_spec.rb +2 -2
  185. data/spec/unit/knife/cookbook_metadata_spec.rb +4 -4
  186. data/spec/unit/knife/cookbook_upload_spec.rb +7 -5
  187. data/spec/unit/knife/core/bootstrap_context_spec.rb +1 -1
  188. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +2 -2
  189. data/spec/unit/knife/core/gem_glob_loader_spec.rb +4 -4
  190. data/spec/unit/knife/core/hashed_command_loader_spec.rb +4 -2
  191. data/spec/unit/knife/core/node_editor_spec.rb +12 -12
  192. data/spec/unit/knife/core/ui_spec.rb +11 -11
  193. data/spec/unit/knife/data_bag_from_file_spec.rb +2 -1
  194. data/spec/unit/knife/data_bag_show_spec.rb +2 -1
  195. data/spec/unit/knife/key_create_spec.rb +1 -1
  196. data/spec/unit/knife/key_delete_spec.rb +3 -3
  197. data/spec/unit/knife/key_edit_spec.rb +4 -4
  198. data/spec/unit/knife/key_list_spec.rb +1 -1
  199. data/spec/unit/knife/key_show_spec.rb +3 -3
  200. data/spec/unit/knife/node_bulk_delete_spec.rb +3 -3
  201. data/spec/unit/knife/node_delete_spec.rb +2 -2
  202. data/spec/unit/knife/node_edit_spec.rb +1 -1
  203. data/spec/unit/knife/node_environment_set_spec.rb +1 -1
  204. data/spec/unit/knife/node_from_file_spec.rb +1 -1
  205. data/spec/unit/knife/node_policy_set_spec.rb +1 -1
  206. data/spec/unit/knife/node_run_list_add_spec.rb +1 -1
  207. data/spec/unit/knife/node_run_list_remove_spec.rb +1 -1
  208. data/spec/unit/knife/node_run_list_set_spec.rb +1 -1
  209. data/spec/unit/knife/node_show_spec.rb +1 -1
  210. data/spec/unit/knife/raw_spec.rb +2 -2
  211. data/spec/unit/knife/role_bulk_delete_spec.rb +2 -2
  212. data/spec/unit/knife/role_create_spec.rb +1 -1
  213. data/spec/unit/knife/role_delete_spec.rb +1 -1
  214. data/spec/unit/knife/role_edit_spec.rb +1 -1
  215. data/spec/unit/knife/role_env_run_list_add_spec.rb +1 -1
  216. data/spec/unit/knife/role_env_run_list_clear_spec.rb +1 -1
  217. data/spec/unit/knife/role_env_run_list_remove_spec.rb +1 -1
  218. data/spec/unit/knife/role_env_run_list_replace_spec.rb +1 -1
  219. data/spec/unit/knife/role_env_run_list_set_spec.rb +1 -1
  220. data/spec/unit/knife/role_from_file_spec.rb +1 -1
  221. data/spec/unit/knife/role_run_list_add_spec.rb +1 -1
  222. data/spec/unit/knife/role_run_list_clear_spec.rb +1 -1
  223. data/spec/unit/knife/role_run_list_remove_spec.rb +1 -1
  224. data/spec/unit/knife/role_run_list_replace_spec.rb +1 -1
  225. data/spec/unit/knife/role_run_list_set_spec.rb +1 -1
  226. data/spec/unit/knife/ssh_spec.rb +27 -17
  227. data/spec/unit/knife/ssl_check_spec.rb +4 -4
  228. data/spec/unit/knife/ssl_fetch_spec.rb +5 -5
  229. data/spec/unit/knife/status_spec.rb +3 -2
  230. data/spec/unit/knife/supermarket_download_spec.rb +4 -4
  231. data/spec/unit/knife/supermarket_install_spec.rb +5 -4
  232. data/spec/unit/knife/supermarket_share_spec.rb +1 -1
  233. data/spec/unit/knife_spec.rb +34 -33
  234. data/spec/unit/lwrp_spec.rb +19 -19
  235. data/spec/unit/mixin/homebrew_user_spec.rb +1 -1
  236. data/spec/unit/mixin/params_validate_spec.rb +10 -10
  237. data/spec/unit/mixin/properties_spec.rb +4 -4
  238. data/spec/unit/mixin/shell_out_spec.rb +27 -27
  239. data/spec/unit/mixin/template_spec.rb +4 -8
  240. data/spec/unit/mixin/unformatter_spec.rb +1 -2
  241. data/spec/unit/mixin/user_context_spec.rb +1 -2
  242. data/spec/unit/mixin/which.rb +2 -0
  243. data/spec/unit/mixin/windows_architecture_helper_spec.rb +3 -3
  244. data/spec/unit/node/attribute_spec.rb +79 -79
  245. data/spec/unit/node/immutable_collections_spec.rb +50 -50
  246. data/spec/unit/node_spec.rb +16 -16
  247. data/spec/unit/org_spec.rb +3 -3
  248. data/spec/unit/policy_builder/policyfile_spec.rb +2 -2
  249. data/spec/unit/property/state_spec.rb +26 -25
  250. data/spec/unit/property/validation_spec.rb +14 -13
  251. data/spec/unit/property_spec.rb +10 -9
  252. data/spec/unit/provider/apt_update_spec.rb +6 -6
  253. data/spec/unit/provider/cron_spec.rb +15 -15
  254. data/spec/unit/provider/dsc_resource_spec.rb +6 -3
  255. data/spec/unit/provider/dsc_script_spec.rb +1 -1
  256. data/spec/unit/provider/execute_spec.rb +5 -5
  257. data/spec/unit/provider/git_spec.rb +39 -39
  258. data/spec/unit/provider/group/dscl_spec.rb +3 -3
  259. data/spec/unit/provider/group/groupadd_spec.rb +1 -1
  260. data/spec/unit/provider/group_spec.rb +2 -3
  261. data/spec/unit/provider/ifconfig/aix_spec.rb +1 -1
  262. data/spec/unit/provider/ifconfig/debian_spec.rb +2 -2
  263. data/spec/unit/provider/ifconfig_spec.rb +45 -16
  264. data/spec/unit/provider/launchd_spec.rb +23 -15
  265. data/spec/unit/provider/link_spec.rb +22 -11
  266. data/spec/unit/provider/mount/aix_spec.rb +6 -6
  267. data/spec/unit/provider/mount/mount_spec.rb +31 -31
  268. data/spec/unit/provider/mount/solaris_spec.rb +11 -11
  269. data/spec/unit/provider/ohai_spec.rb +1 -1
  270. data/spec/unit/provider/osx_profile_spec.rb +5 -7
  271. data/spec/unit/provider/package/apt_spec.rb +5 -5
  272. data/spec/unit/provider/package/bff_spec.rb +1 -1
  273. data/spec/unit/provider/package/cab_spec.rb +1 -1
  274. data/spec/unit/provider/package/chocolatey_spec.rb +8 -8
  275. data/spec/unit/provider/package/freebsd/pkg_spec.rb +1 -1
  276. data/spec/unit/provider/package/ips_spec.rb +6 -6
  277. data/spec/unit/provider/package/macports_spec.rb +1 -1
  278. data/spec/unit/provider/package/msu_spec.rb +1 -1
  279. data/spec/unit/provider/package/openbsd_spec.rb +15 -11
  280. data/spec/unit/provider/package/pacman_spec.rb +3 -3
  281. data/spec/unit/provider/package/paludis_spec.rb +4 -4
  282. data/spec/unit/provider/package/portage_spec.rb +1 -1
  283. data/spec/unit/provider/package/powershell_spec.rb +1 -1
  284. data/spec/unit/provider/package/smartos_spec.rb +3 -3
  285. data/spec/unit/provider/package/solaris_spec.rb +1 -1
  286. data/spec/unit/provider/package/windows/exe_spec.rb +9 -9
  287. data/spec/unit/provider/package/windows/msi_spec.rb +7 -7
  288. data/spec/unit/provider/package/windows_spec.rb +2 -1
  289. data/spec/unit/provider/package/yum/yum_cache_spec.rb +1 -1
  290. data/spec/unit/provider/package/zypper_spec.rb +4 -4
  291. data/spec/unit/provider/package_spec.rb +1 -1
  292. data/spec/unit/provider/powershell_script_spec.rb +7 -7
  293. data/spec/unit/provider/registry_key_spec.rb +1 -1
  294. data/spec/unit/provider/remote_directory_spec.rb +6 -6
  295. data/spec/unit/provider/route_spec.rb +11 -11
  296. data/spec/unit/provider/service/arch_service_spec.rb +13 -13
  297. data/spec/unit/provider/service/debian_service_spec.rb +2 -1
  298. data/spec/unit/provider/service/freebsd_service_spec.rb +28 -24
  299. data/spec/unit/provider/service/gentoo_service_spec.rb +2 -2
  300. data/spec/unit/provider/service/init_service_spec.rb +11 -11
  301. data/spec/unit/provider/service/invokercd_service_spec.rb +11 -11
  302. data/spec/unit/provider/service/macosx_spec.rb +5 -5
  303. data/spec/unit/provider/service/openbsd_service_spec.rb +15 -11
  304. data/spec/unit/provider/service/simple_service_spec.rb +7 -7
  305. data/spec/unit/provider/service/upstart_service_spec.rb +14 -14
  306. data/spec/unit/provider/service/windows_spec.rb +53 -35
  307. data/spec/unit/provider/subversion_spec.rb +8 -4
  308. data/spec/unit/provider/systemd_unit_spec.rb +142 -142
  309. data/spec/unit/provider/template/content_spec.rb +29 -29
  310. data/spec/unit/provider/windows_task_spec.rb +1 -1
  311. data/spec/unit/provider_resolver_spec.rb +75 -75
  312. data/spec/unit/provider_spec.rb +2 -4
  313. data/spec/unit/recipe_spec.rb +4 -4
  314. data/spec/unit/resource/batch_spec.rb +1 -1
  315. data/spec/unit/resource/chef_gem_spec.rb +1 -1
  316. data/spec/unit/resource/chocolatey_config_spec.rb +1 -1
  317. data/spec/unit/resource/chocolatey_source_spec.rb +1 -1
  318. data/spec/unit/resource/directory_spec.rb +1 -1
  319. data/spec/unit/resource/dnf_package_spec.rb +1 -1
  320. data/spec/unit/resource/dsc_resource_spec.rb +1 -1
  321. data/spec/unit/resource/file/verification_spec.rb +1 -2
  322. data/spec/unit/resource/file_spec.rb +1 -1
  323. data/spec/unit/resource/group_spec.rb +1 -1
  324. data/spec/unit/resource/link_spec.rb +1 -1
  325. data/spec/unit/resource/osx_profile_spec.rb +2 -1
  326. data/spec/unit/resource/powershell_script_spec.rb +12 -7
  327. data/spec/unit/resource/registry_key_spec.rb +3 -3
  328. data/spec/unit/resource/rhsm_subscription_spec.rb +1 -1
  329. data/spec/unit/resource/service_spec.rb +1 -1
  330. data/spec/unit/resource/template_spec.rb +2 -2
  331. data/spec/unit/resource/windows_env_spec.rb +1 -1
  332. data/spec/unit/resource/windows_service_spec.rb +5 -5
  333. data/spec/unit/resource/windows_task_spec.rb +6 -2
  334. data/spec/unit/resource/yum_package_spec.rb +1 -1
  335. data/spec/unit/resource_collection/resource_list_spec.rb +1 -1
  336. data/spec/unit/resource_collection/resource_set_spec.rb +7 -7
  337. data/spec/unit/resource_collection/stepable_iterator_spec.rb +2 -2
  338. data/spec/unit/resource_collection_spec.rb +4 -4
  339. data/spec/unit/resource_definition_spec.rb +2 -2
  340. data/spec/unit/resource_inspector_spec.rb +1 -1
  341. data/spec/unit/resource_reporter_spec.rb +4 -4
  342. data/spec/unit/resource_spec.rb +22 -22
  343. data/spec/unit/role_spec.rb +3 -3
  344. data/spec/unit/run_context/cookbook_compiler_spec.rb +23 -23
  345. data/spec/unit/run_list/run_list_expansion_spec.rb +9 -6
  346. data/spec/unit/run_list_spec.rb +1 -1
  347. data/spec/unit/runner_spec.rb +3 -3
  348. data/spec/unit/search/query_spec.rb +3 -2
  349. data/spec/unit/shell/model_wrapper_spec.rb +1 -1
  350. data/spec/unit/shell/shell_session_spec.rb +8 -11
  351. data/spec/unit/shell_spec.rb +1 -2
  352. data/spec/unit/user_spec.rb +4 -4
  353. data/spec/unit/user_v1_spec.rb +3 -3
  354. data/spec/unit/util/backup_spec.rb +1 -1
  355. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +13 -13
  356. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +3 -3
  357. data/spec/unit/util/editor_spec.rb +1 -1
  358. data/spec/unit/util/powershell/ps_credential_spec.rb +3 -2
  359. data/spec/unit/util/threaded_job_queue_spec.rb +2 -2
  360. data/spec/unit/version_class_spec.rb +4 -4
  361. data/spec/unit/win32/registry_spec.rb +5 -5
  362. data/spec/unit/win32/security_spec.rb +2 -1
  363. data/tasks/announce.rb +4 -11
  364. metadata +10 -6
  365. data/tasks/maintainers.rb +0 -211
  366. data/tasks/templates/prerelease.md.erb +0 -35
@@ -128,8 +128,7 @@ describe Chef::Resource::File::Verification do
128
128
  before(:each) do
129
129
  class Chef::Resource::File::Verification::Turtle < Chef::Resource::File::Verification
130
130
  provides :cats
131
- def verify(path, opts)
132
- end
131
+ def verify(path, opts); end
133
132
  end
134
133
  allow(Chef::Resource::File::Verification::Turtle).to receive(:new).and_return(registered_verification)
135
134
  end
@@ -85,7 +85,7 @@ describe Chef::Resource::File do
85
85
  it "accepts a string as the path" do
86
86
  expect { resource.path "/tmp" }.not_to raise_error
87
87
  expect(resource.path).to eql("/tmp")
88
- expect { resource.path Hash.new }.to raise_error(ArgumentError)
88
+ expect { resource.path({}) }.to raise_error(ArgumentError)
89
89
  end
90
90
 
91
91
  describe "when it has a path, owner, group, mode, and checksum" do
@@ -96,7 +96,7 @@ end
96
96
  describe Chef::Resource::Group, "members" do
97
97
  let(:resource) { Chef::Resource::Group.new("fakey_fakerton") }
98
98
 
99
- [ :users, :members].each do |method|
99
+ %i{users members}.each do |method|
100
100
  it "(#{method}) allows a String and coerces it to an Array" do
101
101
  resource.send(method, "some_user")
102
102
  expect(resource.send(method)).to eql(["some_user"])
@@ -63,7 +63,7 @@ describe Chef::Resource::Link do
63
63
  end
64
64
 
65
65
  it "does not accept a Hash for the link source via 'to'" do
66
- expect { resource.to Hash.new }.to raise_error(ArgumentError)
66
+ expect { resource.to({}) }.to raise_error(ArgumentError)
67
67
  end
68
68
 
69
69
  it "allows you to set a link source via 'to'" do
@@ -21,7 +21,8 @@ require "spec_helper"
21
21
  describe Chef::Resource::OsxProfile do
22
22
  let(:resource) do
23
23
  Chef::Resource::OsxProfile.new(
24
- "fakey_fakerton")
24
+ "fakey_fakerton"
25
+ )
25
26
  end
26
27
 
27
28
  it "has a resource name of profile" do
@@ -23,7 +23,7 @@ describe Chef::Resource::PowershellScript do
23
23
  before(:each) do
24
24
  node = Chef::Node.new
25
25
 
26
- node.default["kernel"] = Hash.new
26
+ node.default["kernel"] = {}
27
27
  node.default["kernel"][:machine] = :x86_64.to_s
28
28
  node.automatic[:os] = "windows"
29
29
 
@@ -61,7 +61,7 @@ describe Chef::Resource::PowershellScript do
61
61
 
62
62
  it "inherits exactly the :cwd, :environment, :group, :path, :user, :umask, :architecture, :elevated properties from a parent resource class" do
63
63
  inherited_difference = Chef::Resource::PowershellScript.guard_inherited_attributes -
64
- [:cwd, :environment, :group, :path, :user, :umask, :architecture, :elevated ]
64
+ %i{cwd environment group path user umask architecture elevated}
65
65
 
66
66
  expect(inherited_difference).to eq([])
67
67
  end
@@ -87,7 +87,8 @@ describe Chef::Resource::PowershellScript do
87
87
  it "enables convert_boolean_return by default for guards in the context of powershell_script when no guard params are specified" do
88
88
  allow_any_instance_of(Chef::GuardInterpreter::ResourceGuardInterpreter).to receive(:evaluate_action).and_return(true)
89
89
  allow_any_instance_of(Chef::GuardInterpreter::ResourceGuardInterpreter).to receive(:block_from_attributes).with(
90
- { convert_boolean_return: true, code: "$true" }).and_return(Proc.new {})
90
+ { convert_boolean_return: true, code: "$true" }
91
+ ).and_return(Proc.new {})
91
92
  resource.only_if("$true")
92
93
  end
93
94
 
@@ -98,21 +99,24 @@ describe Chef::Resource::PowershellScript do
98
99
  file_resource.guard_interpreter :powershell_script
99
100
 
100
101
  allow_any_instance_of(Chef::GuardInterpreter::ResourceGuardInterpreter).to receive(:block_from_attributes).with(
101
- { convert_boolean_return: true, code: "$true" }).and_return(Proc.new {})
102
+ { convert_boolean_return: true, code: "$true" }
103
+ ).and_return(Proc.new {})
102
104
  resource.only_if("$true")
103
105
  end
104
106
 
105
107
  it "enables convert_boolean_return by default for guards in the context of powershell_script when guard params are specified" do
106
108
  guard_parameters = { cwd: "/etc/chef", architecture: :x86_64 }
107
109
  allow_any_instance_of(Chef::GuardInterpreter::ResourceGuardInterpreter).to receive(:block_from_attributes).with(
108
- { convert_boolean_return: true, code: "$true" }.merge(guard_parameters)).and_return(Proc.new {})
110
+ { convert_boolean_return: true, code: "$true" }.merge(guard_parameters)
111
+ ).and_return(Proc.new {})
109
112
  resource.only_if("$true", guard_parameters)
110
113
  end
111
114
 
112
115
  it "passes convert_boolean_return as true if it was specified as true in a guard parameter" do
113
116
  guard_parameters = { cwd: "/etc/chef", convert_boolean_return: true, architecture: :x86_64 }
114
117
  allow_any_instance_of(Chef::GuardInterpreter::ResourceGuardInterpreter).to receive(:block_from_attributes).with(
115
- { convert_boolean_return: true, code: "$true" }.merge(guard_parameters)).and_return(Proc.new {})
118
+ { convert_boolean_return: true, code: "$true" }.merge(guard_parameters)
119
+ ).and_return(Proc.new {})
116
120
  resource.only_if("$true", guard_parameters)
117
121
  end
118
122
 
@@ -120,7 +124,8 @@ describe Chef::Resource::PowershellScript do
120
124
  other_guard_parameters = { cwd: "/etc/chef", architecture: :x86_64 }
121
125
  parameters_with_boolean_disabled = other_guard_parameters.merge({ convert_boolean_return: false, code: "$true" })
122
126
  allow_any_instance_of(Chef::GuardInterpreter::ResourceGuardInterpreter).to receive(:block_from_attributes).with(
123
- parameters_with_boolean_disabled).and_return(Proc.new {})
127
+ parameters_with_boolean_disabled
128
+ ).and_return(Proc.new {})
124
129
  resource.only_if("$true", parameters_with_boolean_disabled)
125
130
  end
126
131
  end
@@ -152,7 +152,7 @@ describe Chef::Resource::RegistryKey, "recursive" do
152
152
  end
153
153
 
154
154
  it "does not allow an array" do
155
- expect { resource.recursive([:nose, :chin]) }.to raise_error(ArgumentError)
155
+ expect { resource.recursive(%i{nose chin}) }.to raise_error(ArgumentError)
156
156
  end
157
157
 
158
158
  it "does not allow a string" do
@@ -167,7 +167,7 @@ end
167
167
  describe Chef::Resource::RegistryKey, "architecture" do
168
168
  let(:resource) { Chef::Resource::RegistryKey.new('HKCU\Software\Raxicoricofallapatorius') }
169
169
 
170
- [ :i386, :x86_64, :machine ].each do |arch|
170
+ %i{i386 x86_64 machine}.each do |arch|
171
171
  it "allows #{arch} as a symbol" do
172
172
  resource.architecture(arch)
173
173
  expect(resource.architecture).to eql(arch)
@@ -183,7 +183,7 @@ describe Chef::Resource::RegistryKey, "architecture" do
183
183
  end
184
184
 
185
185
  it "does not allow an array" do
186
- expect { resource.architecture([:nose, :chin]) }.to raise_error(ArgumentError)
186
+ expect { resource.architecture(%i{nose chin}) }.to raise_error(ArgumentError)
187
187
  end
188
188
 
189
189
  it "does not allow a string" do
@@ -74,7 +74,7 @@ describe Chef::Resource::RhsmSubscription do
74
74
  Pool ID: pool2
75
75
  Serial: serial2
76
76
  Key2: value2
77
- EOL
77
+ EOL
78
78
  end
79
79
 
80
80
  it "parses the output correctly" do
@@ -173,7 +173,7 @@ describe Chef::Resource::Service do
173
173
  end
174
174
 
175
175
  it "allows you to set what features this resource supports as a array" do
176
- support_array = [ :status, :restart ]
176
+ support_array = %i{status restart}
177
177
  support_hash = { status: true, restart: true }
178
178
  resource.supports(support_array)
179
179
  expect(resource.supports).to eq(support_hash)
@@ -147,7 +147,7 @@ describe Chef::Resource::Template do
147
147
  end
148
148
 
149
149
  it "compiles helper methods with arguments into a module" do
150
- resource.helper(:shout) { |quiet| quiet.upcase }
150
+ resource.helper(:shout, &:upcase)
151
151
  modules = resource.helper_modules
152
152
  o = Object.new
153
153
  modules.each { |m| o.extend(m) }
@@ -186,7 +186,7 @@ describe Chef::Resource::Template do
186
186
  end
187
187
 
188
188
  it "raises an error when no block or module name is given for helpers definition" do
189
- expect { resource.helpers() }.to raise_error(Chef::Exceptions::ValidationFailed)
189
+ expect { resource.helpers }.to raise_error(Chef::Exceptions::ValidationFailed)
190
190
  end
191
191
 
192
192
  it "raises an error when a non-module is given for helpers definition" do
@@ -47,7 +47,7 @@ describe Chef::Resource::WindowsEnv do
47
47
  end
48
48
 
49
49
  it "does not accept a Hash for the env value via 'to'" do
50
- expect { resource.value Hash.new }.to raise_error(ArgumentError)
50
+ expect { resource.value({}) }.to raise_error(ArgumentError)
51
51
  end
52
52
 
53
53
  it "allows you to set an env value via 'to'" do
@@ -69,11 +69,11 @@ describe Chef::Resource::WindowsService, "initialize" do
69
69
  # Properties that are Strings
70
70
  %i{description service_name binary_path_name load_order_group dependencies
71
71
  run_as_user run_as_password display_name}.each do |prop|
72
- it "support setting #{prop}" do
73
- resource.send("#{prop}=", "some value")
74
- expect(resource.send(prop)).to eq("some value")
75
- end
76
- end
72
+ it "support setting #{prop}" do
73
+ resource.send("#{prop}=", "some value")
74
+ expect(resource.send(prop)).to eq("some value")
75
+ end
76
+ end
77
77
 
78
78
  # Properties that are Integers
79
79
  %i{desired_access error_control service_type}.each do |prop|
@@ -61,6 +61,10 @@ describe Chef::Resource::WindowsTask, :windows_only do
61
61
  expect(resource.stop_if_going_on_batteries).to eql(false)
62
62
  end
63
63
 
64
+ it "sets the default value for start_when_available as false" do
65
+ expect(resource.start_when_available).to eql(false)
66
+ end
67
+
64
68
  context "when frequency is not provided" do
65
69
  it "raises ArgumentError to provide frequency" do
66
70
  expect { resource.after_created }.to raise_error(ArgumentError, "Frequency needs to be provided. Valid frequencies are :minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none." )
@@ -352,7 +356,7 @@ describe Chef::Resource::WindowsTask, :windows_only do
352
356
 
353
357
  context "#validate_idle_time" do
354
358
  it "raises error if frequency is not :on_idle" do
355
- [:minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :none].each do |frequency|
359
+ %i{minute hourly daily weekly monthly once on_logon onstart none}.each do |frequency|
356
360
  expect { resource.send(:validate_idle_time, 5, frequency) }.to raise_error(ArgumentError, "idle_time property is only valid for tasks that run on_idle")
357
361
  end
358
362
  end
@@ -370,7 +374,7 @@ describe Chef::Resource::WindowsTask, :windows_only do
370
374
  end
371
375
 
372
376
  it "does not raises error if idle_time is not set for other frequencies" do
373
- [:minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :none].each do |frequency|
377
+ %i{minute hourly daily weekly monthly once on_logon onstart none}.each do |frequency|
374
378
  expect { resource.send(:validate_idle_time, nil, frequency) }.not_to raise_error
375
379
  end
376
380
  end
@@ -95,7 +95,7 @@ describe Chef::Resource::YumPackage, "flush_cache" do
95
95
  end
96
96
 
97
97
  it "should allow you to set the flush timing with an array" do
98
- flush_array = [ :before, :after ]
98
+ flush_array = %i{before after}
99
99
  flush_hash = { before: true, after: true }
100
100
  @resource.flush_cache(flush_array)
101
101
  expect(@resource.flush_cache).to eq(flush_hash)
@@ -19,7 +19,7 @@
19
19
  require "spec_helper"
20
20
 
21
21
  describe Chef::ResourceCollection::ResourceList do
22
- let(:resource_list) { Chef::ResourceCollection::ResourceList.new() }
22
+ let(:resource_list) { Chef::ResourceCollection::ResourceList.new }
23
23
  let(:resource) { Chef::Resource::ZenMaster.new("makoto") }
24
24
  let(:second_resource) { Chef::Resource::ZenMaster.new("hattori") }
25
25
 
@@ -92,7 +92,7 @@ describe Chef::ResourceCollection::ResourceSet do
92
92
  collection.insert_as(zen_master)
93
93
  collection.insert_as(zen_follower)
94
94
  check_by_names(collection.find(zen_master: [zen_master_name], zen_follower: [zen_follower_name]),
95
- zen_master_name, zen_follower_name)
95
+ zen_master_name, zen_follower_name)
96
96
  end
97
97
 
98
98
  it "should find resources of multiple kinds (:zen_master => a, :zen_follower => b with custom names)" do
@@ -100,7 +100,7 @@ describe Chef::ResourceCollection::ResourceSet do
100
100
  collection.insert_as(zen_master2, :zzz, "name2")
101
101
  collection.insert_as(zen_follower, :yyy, "name3")
102
102
  check_by_names(collection.find(zzz: %w{name1 name2}, yyy: ["name3"]),
103
- zen_master_name, zen_follower_name, zen_master2_name)
103
+ zen_master_name, zen_follower_name, zen_master2_name)
104
104
  end
105
105
 
106
106
  it "should find a resource by string zen_master[a]" do
@@ -118,7 +118,7 @@ describe Chef::ResourceCollection::ResourceSet do
118
118
  collection.insert_as(zen_master)
119
119
  collection.insert_as(zen_master2)
120
120
  check_by_names(collection.find("zen_master[#{zen_master_name},#{zen_master2_name}]"),
121
- zen_master_name, zen_master2_name)
121
+ zen_master_name, zen_master2_name)
122
122
  end
123
123
 
124
124
  it "should find array names" do
@@ -138,14 +138,14 @@ describe Chef::ResourceCollection::ResourceSet do
138
138
  collection.insert_as(zen_master, :zzz, "name1")
139
139
  collection.insert_as(zen_master2, :zzz, "name2")
140
140
  check_by_names(collection.find("zzz[name1,name2]"),
141
- zen_master_name, zen_master2_name)
141
+ zen_master_name, zen_master2_name)
142
142
  end
143
143
 
144
144
  it "should find resources of multiple types by strings of zen_master[a]" do
145
145
  collection.insert_as(zen_master)
146
146
  collection.insert_as(zen_follower)
147
147
  check_by_names(collection.find("zen_master[#{zen_master_name}]", "zen_follower[#{zen_follower_name}]"),
148
- zen_master_name, zen_follower_name)
148
+ zen_master_name, zen_follower_name)
149
149
  end
150
150
 
151
151
  it "should find resources of multiple types by strings of zen_master[a] with custom names" do
@@ -154,7 +154,7 @@ describe Chef::ResourceCollection::ResourceSet do
154
154
  collection.insert_as(zen_master2, :zzz, "name2")
155
155
  collection.insert_as(zen_follower, :yyy, "name3")
156
156
  check_by_names(collection.find("zzz[name1,name2]", "yyy[name3]"),
157
- zen_master_name, zen_follower_name, zen_master2_name)
157
+ zen_master_name, zen_follower_name, zen_master2_name)
158
158
  end
159
159
 
160
160
  it "should only keep the last copy when multiple instances of a Resource are inserted" do
@@ -172,7 +172,7 @@ describe Chef::ResourceCollection::ResourceSet do
172
172
  end
173
173
 
174
174
  it "should raise an exception if you pass something other than a string or hash to resource" do
175
- expect { collection.find([Array.new]) }.to raise_error(ArgumentError)
175
+ expect { collection.find([[]]) }.to raise_error(ArgumentError)
176
176
  end
177
177
 
178
178
  it "raises an error when attempting to find a resource that does not exist" do
@@ -72,7 +72,7 @@ describe Chef::ResourceCollection::StepableIterator do
72
72
  @collection << lambda { @snitch_var = 42 }
73
73
 
74
74
  @iterator = CRSI.for_collection(@collection)
75
- @iterator.each { |proc| proc.call }
75
+ @iterator.each(&:call)
76
76
  end
77
77
 
78
78
  it "allows the iteration to be paused" do
@@ -124,7 +124,7 @@ describe Chef::ResourceCollection::StepableIterator do
124
124
  it "allows the iteration to start by being stepped" do
125
125
  @snitch_var = nil
126
126
  @iterator = CRSI.for_collection(@collection)
127
- @iterator.iterate_on(:element) { |proc| proc.call }
127
+ @iterator.iterate_on(:element, &:call)
128
128
  @iterator.step
129
129
  expect(@iterator.position).to eq(1)
130
130
  expect(@snitch_var).to eq(23)
@@ -20,7 +20,7 @@
20
20
  require "spec_helper"
21
21
 
22
22
  describe Chef::ResourceCollection do
23
- let(:rc) { Chef::ResourceCollection.new() }
23
+ let(:rc) { Chef::ResourceCollection.new }
24
24
  let(:resource) { Chef::Resource::ZenMaster.new("makoto") }
25
25
 
26
26
  it "should throw an error when calling a non-delegated method" do
@@ -97,7 +97,7 @@ describe Chef::ResourceCollection do
97
97
  describe "each" do
98
98
  it "should allow you to iterate over every resource in the collection" do
99
99
  load_up_resources
100
- results = Array.new
100
+ results = []
101
101
  expect do
102
102
  rc.each do |r|
103
103
  results << r.name
@@ -119,7 +119,7 @@ describe Chef::ResourceCollection do
119
119
  describe "each_index" do
120
120
  it "should allow you to iterate over every resource by index" do
121
121
  load_up_resources
122
- results = Array.new
122
+ results = []
123
123
  expect do
124
124
  rc.each_index do |i|
125
125
  results << rc[i].name
@@ -246,7 +246,7 @@ describe Chef::ResourceCollection do
246
246
  end
247
247
 
248
248
  it "should raise an exception if you pass something other than a string or hash to resource" do
249
- expect { rc.resources([Array.new]) }.to raise_error(ArgumentError)
249
+ expect { rc.resources([[]]) }.to raise_error(ArgumentError)
250
250
  end
251
251
 
252
252
  it "raises an error when attempting to find a resource that does not exist" do
@@ -19,7 +19,7 @@
19
19
  require "spec_helper"
20
20
 
21
21
  describe Chef::ResourceDefinition do
22
- let(:defn) { Chef::ResourceDefinition.new() }
22
+ let(:defn) { Chef::ResourceDefinition.new }
23
23
 
24
24
  describe "initialize" do
25
25
  it "should be a Chef::ResourceDefinition" do
@@ -92,7 +92,7 @@ describe Chef::ResourceDefinition do
92
92
 
93
93
  it "should raise an exception if prototype_params is not a hash" do
94
94
  expect do
95
- defn.define :monkey, Array.new do
95
+ defn.define :monkey, [] do
96
96
  end
97
97
  end.to raise_error(ArgumentError)
98
98
  end
@@ -39,7 +39,7 @@ describe ResourceInspector do
39
39
 
40
40
  it "returns a hash with required data" do
41
41
  expect(subject[:description]).to eq "A dummy resource"
42
- expect(subject[:actions]).to match_array [:nothing, :dummy]
42
+ expect(subject[:actions]).to match_array %i{nothing dummy}
43
43
  end
44
44
 
45
45
  context "excluding built in properties" do
@@ -619,7 +619,7 @@ describe Chef::ResourceReporter do
619
619
  expect(@rest_client).to receive(:post)
620
620
  .with("reports/nodes/spitfire/runs", { action: :start, run_id: @run_id,
621
621
  start_time: @start_time.to_s },
622
- { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
622
+ { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
623
623
  .and_raise(@error)
624
624
  end
625
625
 
@@ -648,7 +648,7 @@ describe Chef::ResourceReporter do
648
648
  @error = Net::HTTPClientException.new("500 message", @response)
649
649
  expect(@rest_client).to receive(:post)
650
650
  .with("reports/nodes/spitfire/runs", { action: :start, run_id: @run_id, start_time: @start_time.to_s },
651
- { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
651
+ { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
652
652
  .and_raise(@error)
653
653
  end
654
654
 
@@ -678,7 +678,7 @@ describe Chef::ResourceReporter do
678
678
  @error = Net::HTTPClientException.new("500 message", @response)
679
679
  expect(@rest_client).to receive(:post)
680
680
  .with("reports/nodes/spitfire/runs", { action: :start, run_id: @run_id, start_time: @start_time.to_s },
681
- { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
681
+ { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
682
682
  .and_raise(@error)
683
683
  end
684
684
 
@@ -699,7 +699,7 @@ describe Chef::ResourceReporter do
699
699
  response = { "uri" => "https://example.com/reports/nodes/spitfire/runs/@run_id" }
700
700
  expect(@rest_client).to receive(:post)
701
701
  .with("reports/nodes/spitfire/runs", { action: :start, run_id: @run_id, start_time: @start_time.to_s },
702
- { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
702
+ { "X-Ops-Reporting-Protocol-Version" => Chef::ResourceReporter::PROTOCOL_VERSION })
703
703
  .and_return(response)
704
704
  @resource_reporter.run_started(@run_status)
705
705
  end
@@ -115,14 +115,14 @@ describe Chef::Resource do
115
115
  it "sets a list of state attributes" do
116
116
  resource_class = Class.new(Chef::Resource)
117
117
  resource_class.state_attrs(:checksum, :owner, :group, :mode)
118
- expect(resource_class.state_attrs).to match_array([:checksum, :owner, :group, :mode])
118
+ expect(resource_class.state_attrs).to match_array(%i{checksum owner group mode})
119
119
  end
120
120
 
121
121
  it "inherits state attributes from the superclass" do
122
122
  resource_class = Class.new(Chef::Resource)
123
123
  resource_subclass = Class.new(resource_class)
124
124
  resource_class.state_attrs(:checksum, :owner, :group, :mode)
125
- expect(resource_subclass.state_attrs).to match_array([:checksum, :owner, :group, :mode])
125
+ expect(resource_subclass.state_attrs).to match_array(%i{checksum owner group mode})
126
126
  end
127
127
 
128
128
  it "combines inherited state attributes with non-inherited state attributes" do
@@ -130,7 +130,7 @@ describe Chef::Resource do
130
130
  resource_subclass = Class.new(resource_class)
131
131
  resource_class.state_attrs(:checksum, :owner)
132
132
  resource_subclass.state_attrs(:group, :mode)
133
- expect(resource_subclass.state_attrs).to match_array([:checksum, :owner, :group, :mode])
133
+ expect(resource_subclass.state_attrs).to match_array(%i{checksum owner group mode})
134
134
  end
135
135
 
136
136
  end
@@ -157,7 +157,7 @@ describe Chef::Resource do
157
157
 
158
158
  it "describes its state" do
159
159
  resource_state = file_resource.state_for_resource_reporter
160
- expect(resource_state.keys).to match_array([:checksum, :owner, :group, :mode])
160
+ expect(resource_state.keys).to match_array(%i{checksum owner group mode})
161
161
  expect(resource_state[:checksum]).to eq("abc123")
162
162
  expect(resource_state[:owner]).to eq("root")
163
163
  expect(resource_state[:group]).to eq("wheel")
@@ -410,7 +410,7 @@ describe Chef::Resource do
410
410
  resource "foo" do
411
411
  foo foo
412
412
  end
413
- EOH
413
+ EOH
414
414
  end
415
415
  end
416
416
 
@@ -510,11 +510,11 @@ describe Chef::Resource do
510
510
  context "when the resource has a property with a default" do
511
511
  let(:resource_class) { Class.new(Chef::Resource) { property :a, default: 1 } }
512
512
  it "should include the default in the hash" do
513
- expect(resource.to_hash.keys.sort).to eq([:a, :allowed_actions, :params, :provider, :updated,
514
- :updated_by_last_action, :before,
515
- :name, :source_line,
516
- :action, :elapsed_time,
517
- :default_guard_interpreter, :guard_interpreter].sort)
513
+ expect(resource.to_hash.keys.sort).to eq(%i{a allowed_actions params provider updated
514
+ updated_by_last_action before
515
+ name source_line
516
+ action elapsed_time
517
+ default_guard_interpreter guard_interpreter}.sort)
518
518
  expect(resource.to_hash[:name]).to eq "funk"
519
519
  expect(resource.to_hash[:a]).to eq 1
520
520
  end
@@ -522,11 +522,11 @@ describe Chef::Resource do
522
522
 
523
523
  it "should convert to a hash" do
524
524
  hash = resource.to_hash
525
- expected_keys = [ :allowed_actions, :params, :provider, :updated,
526
- :updated_by_last_action, :before,
527
- :name, :source_line,
528
- :action, :elapsed_time,
529
- :default_guard_interpreter, :guard_interpreter ]
525
+ expected_keys = %i{allowed_actions params provider updated
526
+ updated_by_last_action before
527
+ name source_line
528
+ action elapsed_time
529
+ default_guard_interpreter guard_interpreter}
530
530
  expect(hash.keys - expected_keys).to eq([])
531
531
  expect(expected_keys - hash.keys).to eq([])
532
532
  expect(hash[:name]).to eql("funk")
@@ -838,7 +838,7 @@ describe Chef::Resource do
838
838
  it "should print \"skipped due to action :nothing\" message for doc formatter when action is :nothing" do
839
839
  fdoc = Chef::Formatters.new(:doc, STDOUT, STDERR)
840
840
  allow(run_context).to receive(:events).and_return(fdoc)
841
- expect(fdoc).to receive(:puts).with(" (skipped due to action :nothing)", anything())
841
+ expect(fdoc).to receive(:puts).with(" (skipped due to action :nothing)", anything)
842
842
  resource.should_skip?(:nothing)
843
843
  end
844
844
 
@@ -1118,8 +1118,8 @@ describe Chef::Resource do
1118
1118
  end
1119
1119
 
1120
1120
  context "with an array action" do
1121
- before { resource.action([:two, :one]) }
1122
- it { is_expected.to eq [:two, :one] }
1121
+ before { resource.action(%i{two one}) }
1122
+ it { is_expected.to eq %i{two one} }
1123
1123
  end
1124
1124
 
1125
1125
  context "with an assignment" do
@@ -1128,8 +1128,8 @@ describe Chef::Resource do
1128
1128
  end
1129
1129
 
1130
1130
  context "with an array assignment" do
1131
- before { resource.action = [:two, :one] }
1132
- it { is_expected.to eq [:two, :one] }
1131
+ before { resource.action = %i{two one} }
1132
+ it { is_expected.to eq %i{two one} }
1133
1133
  end
1134
1134
 
1135
1135
  context "with an invalid action" do
@@ -1166,8 +1166,8 @@ describe Chef::Resource do
1166
1166
  end
1167
1167
 
1168
1168
  context "with an array default action" do
1169
- let(:default_action) { [:two, :one] }
1170
- it { is_expected.to eq [:two, :one] }
1169
+ let(:default_action) { %i{two one} }
1170
+ it { is_expected.to eq %i{two one} }
1171
1171
  end
1172
1172
  end
1173
1173