chef 14.14.29-universal-mingw32 → 14.15.6-universal-mingw32

Sign up to get free protection for your applications and to get access to all the features.
Files changed (366) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -1
  3. data/README.md +18 -7
  4. data/Rakefile +7 -4
  5. data/chef.gemspec +1 -1
  6. data/lib/chef/knife/ssh.rb +6 -0
  7. data/lib/chef/provider/ifconfig.rb +14 -5
  8. data/lib/chef/provider/windows_task.rb +9 -5
  9. data/lib/chef/resource/kernel_module.rb +61 -0
  10. data/lib/chef/resource/windows_task.rb +4 -0
  11. data/lib/chef/version.rb +1 -1
  12. data/spec/data/cookbooks/openldap/metadata.rb +2 -2
  13. data/spec/data/metadata/quick_start/metadata.rb +2 -7
  14. data/spec/functional/audit/runner_spec.rb +1 -1
  15. data/spec/functional/dsl/reboot_pending_spec.rb +7 -25
  16. data/spec/functional/event_loggers/windows_eventlog_spec.rb +6 -4
  17. data/spec/functional/file_content_management/deploy_strategies_spec.rb +21 -21
  18. data/spec/functional/knife/exec_spec.rb +1 -1
  19. data/spec/functional/knife/ssh_spec.rb +3 -3
  20. data/spec/functional/mixin/user_context_spec.rb +3 -1
  21. data/spec/functional/rebooter_spec.rb +1 -1
  22. data/spec/functional/resource/aix_service_spec.rb +1 -1
  23. data/spec/functional/resource/aixinit_service_spec.rb +1 -1
  24. data/spec/functional/resource/apt_package_spec.rb +1 -1
  25. data/spec/functional/resource/chocolatey_package_spec.rb +2 -2
  26. data/spec/functional/resource/cookbook_file_spec.rb +1 -3
  27. data/spec/functional/resource/cron_spec.rb +4 -3
  28. data/spec/functional/resource/dpkg_package_spec.rb +4 -4
  29. data/spec/functional/resource/dsc_resource_spec.rb +2 -1
  30. data/spec/functional/resource/dsc_script_spec.rb +16 -20
  31. data/spec/functional/resource/execute_spec.rb +2 -2
  32. data/spec/functional/resource/git_spec.rb +6 -6
  33. data/spec/functional/resource/group_spec.rb +8 -6
  34. data/spec/functional/resource/ifconfig_spec.rb +3 -5
  35. data/spec/functional/resource/link_spec.rb +2 -2
  36. data/spec/functional/resource/mount_spec.rb +3 -7
  37. data/spec/functional/resource/powershell_script_spec.rb +9 -8
  38. data/spec/functional/resource/reboot_spec.rb +1 -1
  39. data/spec/functional/resource/remote_file_spec.rb +2 -2
  40. data/spec/functional/resource/template_spec.rb +1 -1
  41. data/spec/functional/resource/user/windows_spec.rb +2 -2
  42. data/spec/functional/resource/windows_certificate_spec.rb +3 -3
  43. data/spec/functional/resource/windows_service_spec.rb +3 -3
  44. data/spec/functional/resource/windows_task_spec.rb +51 -0
  45. data/spec/functional/run_lock_spec.rb +10 -3
  46. data/spec/functional/shell_spec.rb +1 -1
  47. data/spec/functional/util/powershell/cmdlet_spec.rb +1 -1
  48. data/spec/functional/version_spec.rb +1 -1
  49. data/spec/functional/win32/security_spec.rb +12 -7
  50. data/spec/functional/win32/service_manager_spec.rb +1 -1
  51. data/spec/functional/win32/version_info_spec.rb +4 -4
  52. data/spec/integration/client/client_spec.rb +114 -132
  53. data/spec/integration/client/exit_code_spec.rb +8 -8
  54. data/spec/integration/client/ipv6_spec.rb +5 -5
  55. data/spec/integration/knife/chef_fs_data_store_spec.rb +38 -38
  56. data/spec/integration/knife/chef_repo_path_spec.rb +42 -42
  57. data/spec/integration/knife/chef_repository_file_system_spec.rb +9 -9
  58. data/spec/integration/knife/chefignore_spec.rb +13 -13
  59. data/spec/integration/knife/client_bulk_delete_spec.rb +8 -8
  60. data/spec/integration/knife/client_create_spec.rb +1 -1
  61. data/spec/integration/knife/client_delete_spec.rb +4 -4
  62. data/spec/integration/knife/client_key_delete_spec.rb +1 -1
  63. data/spec/integration/knife/client_key_list_spec.rb +1 -1
  64. data/spec/integration/knife/client_list_spec.rb +1 -1
  65. data/spec/integration/knife/common_options_spec.rb +1 -1
  66. data/spec/integration/knife/config_get_spec.rb +1 -1
  67. data/spec/integration/knife/config_list_profiles_spec.rb +2 -1
  68. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +3 -3
  69. data/spec/integration/knife/cookbook_bulk_delete_spec.rb +3 -3
  70. data/spec/integration/knife/cookbook_download_spec.rb +4 -4
  71. data/spec/integration/knife/cookbook_list_spec.rb +2 -2
  72. data/spec/integration/knife/cookbook_show_spec.rb +3 -3
  73. data/spec/integration/knife/cookbook_upload_spec.rb +6 -6
  74. data/spec/integration/knife/data_bag_delete_spec.rb +4 -4
  75. data/spec/integration/knife/data_bag_from_file_spec.rb +7 -7
  76. data/spec/integration/knife/data_bag_list_spec.rb +1 -1
  77. data/spec/integration/knife/delete_spec.rb +37 -37
  78. data/spec/integration/knife/deps_spec.rb +23 -23
  79. data/spec/integration/knife/diff_spec.rb +23 -23
  80. data/spec/integration/knife/download_spec.rb +79 -79
  81. data/spec/integration/knife/environment_compare_spec.rb +3 -3
  82. data/spec/integration/knife/environment_from_file_spec.rb +6 -6
  83. data/spec/integration/knife/environment_list_spec.rb +1 -1
  84. data/spec/integration/knife/environment_show_spec.rb +4 -4
  85. data/spec/integration/knife/list_spec.rb +25 -25
  86. data/spec/integration/knife/node_bulk_delete_spec.rb +2 -2
  87. data/spec/integration/knife/node_delete_spec.rb +2 -2
  88. data/spec/integration/knife/node_environment_set_spec.rb +1 -1
  89. data/spec/integration/knife/node_from_file_spec.rb +2 -2
  90. data/spec/integration/knife/node_list_spec.rb +1 -1
  91. data/spec/integration/knife/raw_spec.rb +12 -12
  92. data/spec/integration/knife/redirection_spec.rb +1 -1
  93. data/spec/integration/knife/role_bulk_delete_spec.rb +2 -2
  94. data/spec/integration/knife/role_delete_spec.rb +2 -2
  95. data/spec/integration/knife/role_from_file_spec.rb +5 -5
  96. data/spec/integration/knife/role_list_spec.rb +1 -1
  97. data/spec/integration/knife/role_show_spec.rb +1 -1
  98. data/spec/integration/knife/show_spec.rb +10 -10
  99. data/spec/integration/knife/upload_spec.rb +85 -85
  100. data/spec/integration/recipes/accumulator_spec.rb +4 -4
  101. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +6 -6
  102. data/spec/integration/recipes/lwrp_spec.rb +6 -6
  103. data/spec/integration/recipes/notifies_spec.rb +45 -45
  104. data/spec/integration/recipes/notifying_block_spec.rb +4 -4
  105. data/spec/integration/recipes/provider_choice.rb +1 -2
  106. data/spec/integration/recipes/recipe_dsl_spec.rb +9 -9
  107. data/spec/integration/recipes/remote_directory.rb +2 -2
  108. data/spec/integration/recipes/resource_action_spec.rb +1 -1
  109. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +19 -19
  110. data/spec/integration/solo/solo_spec.rb +29 -29
  111. data/spec/scripts/ssl-serve.rb +1 -1
  112. data/spec/spec_helper.rb +11 -14
  113. data/spec/stress/win32/security_spec.rb +1 -1
  114. data/spec/support/lib/chef/resource/zen_follower.rb +1 -1
  115. data/spec/support/lib/chef/resource/zen_master.rb +1 -1
  116. data/spec/support/mock/platform.rb +2 -2
  117. data/spec/support/platform_helpers.rb +12 -3
  118. data/spec/support/platforms/win32/spec_service.rb +6 -10
  119. data/spec/support/shared/context/client.rb +2 -1
  120. data/spec/support/shared/functional/execute_resource.rb +4 -4
  121. data/spec/support/shared/functional/file_resource.rb +1 -3
  122. data/spec/support/shared/functional/http.rb +20 -44
  123. data/spec/support/shared/functional/securable_resource.rb +4 -8
  124. data/spec/support/shared/functional/win32_service.rb +1 -1
  125. data/spec/support/shared/functional/windows_script.rb +2 -1
  126. data/spec/support/shared/integration/app_server_support.rb +3 -4
  127. data/spec/support/shared/integration/integration_helper.rb +1 -0
  128. data/spec/support/shared/integration/knife_support.rb +5 -5
  129. data/spec/support/shared/unit/application_dot_d.rb +10 -4
  130. data/spec/support/shared/unit/file_system_support.rb +3 -2
  131. data/spec/support/shared/unit/platform_introspector.rb +12 -12
  132. data/spec/support/shared/unit/provider/file.rb +1 -1
  133. data/spec/support/shared/unit/script_resource.rb +1 -1
  134. data/spec/support/shared/unit/windows_script_resource.rb +1 -1
  135. data/spec/tiny_server.rb +1 -1
  136. data/spec/unit/api_client/registration_spec.rb +1 -1
  137. data/spec/unit/api_client_spec.rb +5 -5
  138. data/spec/unit/api_client_v1_spec.rb +6 -6
  139. data/spec/unit/application/client_spec.rb +8 -8
  140. data/spec/unit/application/exit_code_spec.rb +3 -2
  141. data/spec/unit/application/knife_spec.rb +1 -2
  142. data/spec/unit/audit/audit_event_proxy_spec.rb +14 -7
  143. data/spec/unit/audit/audit_reporter_spec.rb +20 -11
  144. data/spec/unit/audit/control_group_data_spec.rb +17 -12
  145. data/spec/unit/chef_fs/config_spec.rb +3 -3
  146. data/spec/unit/chef_fs/file_system/repository/directory_spec.rb +1 -1
  147. data/spec/unit/chef_fs/parallelizer.rb +1 -1
  148. data/spec/unit/client_spec.rb +3 -3
  149. data/spec/unit/config_fetcher_spec.rb +1 -1
  150. data/spec/unit/cookbook/metadata_spec.rb +13 -13
  151. data/spec/unit/cookbook/synchronizer_spec.rb +6 -6
  152. data/spec/unit/cookbook_loader_spec.rb +17 -17
  153. data/spec/unit/cookbook_manifest_spec.rb +9 -9
  154. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +1 -2
  155. data/spec/unit/cookbook_uploader_spec.rb +2 -2
  156. data/spec/unit/cookbook_version_file_specificity_spec.rb +9 -9
  157. data/spec/unit/cookbook_version_spec.rb +2 -2
  158. data/spec/unit/data_bag_item_spec.rb +7 -7
  159. data/spec/unit/data_bag_spec.rb +1 -1
  160. data/spec/unit/data_collector_spec.rb +23 -23
  161. data/spec/unit/decorator_spec.rb +2 -2
  162. data/spec/unit/deprecated_spec.rb +2 -2
  163. data/spec/unit/dsl/data_query_spec.rb +3 -2
  164. data/spec/unit/dsl/declare_resource_spec.rb +1 -1
  165. data/spec/unit/dsl/platform_introspection_spec.rb +2 -2
  166. data/spec/unit/encrypted_data_bag_item/check_encrypted_spec.rb +2 -1
  167. data/spec/unit/encrypted_data_bag_item_spec.rb +2 -1
  168. data/spec/unit/environment_spec.rb +13 -13
  169. data/spec/unit/event_dispatch/dsl_spec.rb +1 -1
  170. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +3 -3
  171. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +2 -2
  172. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +3 -3
  173. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +1 -1
  174. data/spec/unit/http/authenticator_spec.rb +4 -3
  175. data/spec/unit/http/json_input_spec.rb +1 -1
  176. data/spec/unit/http/socketless_chef_zero_client_spec.rb +15 -15
  177. data/spec/unit/key_spec.rb +8 -8
  178. data/spec/unit/knife/bootstrap_spec.rb +14 -10
  179. data/spec/unit/knife/client_bulk_delete_spec.rb +4 -4
  180. data/spec/unit/knife/configure_client_spec.rb +1 -1
  181. data/spec/unit/knife/configure_spec.rb +1 -1
  182. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +1 -1
  183. data/spec/unit/knife/cookbook_delete_spec.rb +2 -2
  184. data/spec/unit/knife/cookbook_download_spec.rb +2 -2
  185. data/spec/unit/knife/cookbook_metadata_spec.rb +4 -4
  186. data/spec/unit/knife/cookbook_upload_spec.rb +7 -5
  187. data/spec/unit/knife/core/bootstrap_context_spec.rb +1 -1
  188. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +2 -2
  189. data/spec/unit/knife/core/gem_glob_loader_spec.rb +4 -4
  190. data/spec/unit/knife/core/hashed_command_loader_spec.rb +4 -2
  191. data/spec/unit/knife/core/node_editor_spec.rb +12 -12
  192. data/spec/unit/knife/core/ui_spec.rb +11 -11
  193. data/spec/unit/knife/data_bag_from_file_spec.rb +2 -1
  194. data/spec/unit/knife/data_bag_show_spec.rb +2 -1
  195. data/spec/unit/knife/key_create_spec.rb +1 -1
  196. data/spec/unit/knife/key_delete_spec.rb +3 -3
  197. data/spec/unit/knife/key_edit_spec.rb +4 -4
  198. data/spec/unit/knife/key_list_spec.rb +1 -1
  199. data/spec/unit/knife/key_show_spec.rb +3 -3
  200. data/spec/unit/knife/node_bulk_delete_spec.rb +3 -3
  201. data/spec/unit/knife/node_delete_spec.rb +2 -2
  202. data/spec/unit/knife/node_edit_spec.rb +1 -1
  203. data/spec/unit/knife/node_environment_set_spec.rb +1 -1
  204. data/spec/unit/knife/node_from_file_spec.rb +1 -1
  205. data/spec/unit/knife/node_policy_set_spec.rb +1 -1
  206. data/spec/unit/knife/node_run_list_add_spec.rb +1 -1
  207. data/spec/unit/knife/node_run_list_remove_spec.rb +1 -1
  208. data/spec/unit/knife/node_run_list_set_spec.rb +1 -1
  209. data/spec/unit/knife/node_show_spec.rb +1 -1
  210. data/spec/unit/knife/raw_spec.rb +2 -2
  211. data/spec/unit/knife/role_bulk_delete_spec.rb +2 -2
  212. data/spec/unit/knife/role_create_spec.rb +1 -1
  213. data/spec/unit/knife/role_delete_spec.rb +1 -1
  214. data/spec/unit/knife/role_edit_spec.rb +1 -1
  215. data/spec/unit/knife/role_env_run_list_add_spec.rb +1 -1
  216. data/spec/unit/knife/role_env_run_list_clear_spec.rb +1 -1
  217. data/spec/unit/knife/role_env_run_list_remove_spec.rb +1 -1
  218. data/spec/unit/knife/role_env_run_list_replace_spec.rb +1 -1
  219. data/spec/unit/knife/role_env_run_list_set_spec.rb +1 -1
  220. data/spec/unit/knife/role_from_file_spec.rb +1 -1
  221. data/spec/unit/knife/role_run_list_add_spec.rb +1 -1
  222. data/spec/unit/knife/role_run_list_clear_spec.rb +1 -1
  223. data/spec/unit/knife/role_run_list_remove_spec.rb +1 -1
  224. data/spec/unit/knife/role_run_list_replace_spec.rb +1 -1
  225. data/spec/unit/knife/role_run_list_set_spec.rb +1 -1
  226. data/spec/unit/knife/ssh_spec.rb +27 -17
  227. data/spec/unit/knife/ssl_check_spec.rb +4 -4
  228. data/spec/unit/knife/ssl_fetch_spec.rb +5 -5
  229. data/spec/unit/knife/status_spec.rb +3 -2
  230. data/spec/unit/knife/supermarket_download_spec.rb +4 -4
  231. data/spec/unit/knife/supermarket_install_spec.rb +5 -4
  232. data/spec/unit/knife/supermarket_share_spec.rb +1 -1
  233. data/spec/unit/knife_spec.rb +34 -33
  234. data/spec/unit/lwrp_spec.rb +19 -19
  235. data/spec/unit/mixin/homebrew_user_spec.rb +1 -1
  236. data/spec/unit/mixin/params_validate_spec.rb +10 -10
  237. data/spec/unit/mixin/properties_spec.rb +4 -4
  238. data/spec/unit/mixin/shell_out_spec.rb +27 -27
  239. data/spec/unit/mixin/template_spec.rb +4 -8
  240. data/spec/unit/mixin/unformatter_spec.rb +1 -2
  241. data/spec/unit/mixin/user_context_spec.rb +1 -2
  242. data/spec/unit/mixin/which.rb +2 -0
  243. data/spec/unit/mixin/windows_architecture_helper_spec.rb +3 -3
  244. data/spec/unit/node/attribute_spec.rb +79 -79
  245. data/spec/unit/node/immutable_collections_spec.rb +50 -50
  246. data/spec/unit/node_spec.rb +16 -16
  247. data/spec/unit/org_spec.rb +3 -3
  248. data/spec/unit/policy_builder/policyfile_spec.rb +2 -2
  249. data/spec/unit/property/state_spec.rb +26 -25
  250. data/spec/unit/property/validation_spec.rb +14 -13
  251. data/spec/unit/property_spec.rb +10 -9
  252. data/spec/unit/provider/apt_update_spec.rb +6 -6
  253. data/spec/unit/provider/cron_spec.rb +15 -15
  254. data/spec/unit/provider/dsc_resource_spec.rb +6 -3
  255. data/spec/unit/provider/dsc_script_spec.rb +1 -1
  256. data/spec/unit/provider/execute_spec.rb +5 -5
  257. data/spec/unit/provider/git_spec.rb +39 -39
  258. data/spec/unit/provider/group/dscl_spec.rb +3 -3
  259. data/spec/unit/provider/group/groupadd_spec.rb +1 -1
  260. data/spec/unit/provider/group_spec.rb +2 -3
  261. data/spec/unit/provider/ifconfig/aix_spec.rb +1 -1
  262. data/spec/unit/provider/ifconfig/debian_spec.rb +2 -2
  263. data/spec/unit/provider/ifconfig_spec.rb +45 -16
  264. data/spec/unit/provider/launchd_spec.rb +23 -15
  265. data/spec/unit/provider/link_spec.rb +22 -11
  266. data/spec/unit/provider/mount/aix_spec.rb +6 -6
  267. data/spec/unit/provider/mount/mount_spec.rb +31 -31
  268. data/spec/unit/provider/mount/solaris_spec.rb +11 -11
  269. data/spec/unit/provider/ohai_spec.rb +1 -1
  270. data/spec/unit/provider/osx_profile_spec.rb +5 -7
  271. data/spec/unit/provider/package/apt_spec.rb +5 -5
  272. data/spec/unit/provider/package/bff_spec.rb +1 -1
  273. data/spec/unit/provider/package/cab_spec.rb +1 -1
  274. data/spec/unit/provider/package/chocolatey_spec.rb +8 -8
  275. data/spec/unit/provider/package/freebsd/pkg_spec.rb +1 -1
  276. data/spec/unit/provider/package/ips_spec.rb +6 -6
  277. data/spec/unit/provider/package/macports_spec.rb +1 -1
  278. data/spec/unit/provider/package/msu_spec.rb +1 -1
  279. data/spec/unit/provider/package/openbsd_spec.rb +15 -11
  280. data/spec/unit/provider/package/pacman_spec.rb +3 -3
  281. data/spec/unit/provider/package/paludis_spec.rb +4 -4
  282. data/spec/unit/provider/package/portage_spec.rb +1 -1
  283. data/spec/unit/provider/package/powershell_spec.rb +1 -1
  284. data/spec/unit/provider/package/smartos_spec.rb +3 -3
  285. data/spec/unit/provider/package/solaris_spec.rb +1 -1
  286. data/spec/unit/provider/package/windows/exe_spec.rb +9 -9
  287. data/spec/unit/provider/package/windows/msi_spec.rb +7 -7
  288. data/spec/unit/provider/package/windows_spec.rb +2 -1
  289. data/spec/unit/provider/package/yum/yum_cache_spec.rb +1 -1
  290. data/spec/unit/provider/package/zypper_spec.rb +4 -4
  291. data/spec/unit/provider/package_spec.rb +1 -1
  292. data/spec/unit/provider/powershell_script_spec.rb +7 -7
  293. data/spec/unit/provider/registry_key_spec.rb +1 -1
  294. data/spec/unit/provider/remote_directory_spec.rb +6 -6
  295. data/spec/unit/provider/route_spec.rb +11 -11
  296. data/spec/unit/provider/service/arch_service_spec.rb +13 -13
  297. data/spec/unit/provider/service/debian_service_spec.rb +2 -1
  298. data/spec/unit/provider/service/freebsd_service_spec.rb +28 -24
  299. data/spec/unit/provider/service/gentoo_service_spec.rb +2 -2
  300. data/spec/unit/provider/service/init_service_spec.rb +11 -11
  301. data/spec/unit/provider/service/invokercd_service_spec.rb +11 -11
  302. data/spec/unit/provider/service/macosx_spec.rb +5 -5
  303. data/spec/unit/provider/service/openbsd_service_spec.rb +15 -11
  304. data/spec/unit/provider/service/simple_service_spec.rb +7 -7
  305. data/spec/unit/provider/service/upstart_service_spec.rb +14 -14
  306. data/spec/unit/provider/service/windows_spec.rb +53 -35
  307. data/spec/unit/provider/subversion_spec.rb +8 -4
  308. data/spec/unit/provider/systemd_unit_spec.rb +142 -142
  309. data/spec/unit/provider/template/content_spec.rb +29 -29
  310. data/spec/unit/provider/windows_task_spec.rb +1 -1
  311. data/spec/unit/provider_resolver_spec.rb +75 -75
  312. data/spec/unit/provider_spec.rb +2 -4
  313. data/spec/unit/recipe_spec.rb +4 -4
  314. data/spec/unit/resource/batch_spec.rb +1 -1
  315. data/spec/unit/resource/chef_gem_spec.rb +1 -1
  316. data/spec/unit/resource/chocolatey_config_spec.rb +1 -1
  317. data/spec/unit/resource/chocolatey_source_spec.rb +1 -1
  318. data/spec/unit/resource/directory_spec.rb +1 -1
  319. data/spec/unit/resource/dnf_package_spec.rb +1 -1
  320. data/spec/unit/resource/dsc_resource_spec.rb +1 -1
  321. data/spec/unit/resource/file/verification_spec.rb +1 -2
  322. data/spec/unit/resource/file_spec.rb +1 -1
  323. data/spec/unit/resource/group_spec.rb +1 -1
  324. data/spec/unit/resource/link_spec.rb +1 -1
  325. data/spec/unit/resource/osx_profile_spec.rb +2 -1
  326. data/spec/unit/resource/powershell_script_spec.rb +12 -7
  327. data/spec/unit/resource/registry_key_spec.rb +3 -3
  328. data/spec/unit/resource/rhsm_subscription_spec.rb +1 -1
  329. data/spec/unit/resource/service_spec.rb +1 -1
  330. data/spec/unit/resource/template_spec.rb +2 -2
  331. data/spec/unit/resource/windows_env_spec.rb +1 -1
  332. data/spec/unit/resource/windows_service_spec.rb +5 -5
  333. data/spec/unit/resource/windows_task_spec.rb +6 -2
  334. data/spec/unit/resource/yum_package_spec.rb +1 -1
  335. data/spec/unit/resource_collection/resource_list_spec.rb +1 -1
  336. data/spec/unit/resource_collection/resource_set_spec.rb +7 -7
  337. data/spec/unit/resource_collection/stepable_iterator_spec.rb +2 -2
  338. data/spec/unit/resource_collection_spec.rb +4 -4
  339. data/spec/unit/resource_definition_spec.rb +2 -2
  340. data/spec/unit/resource_inspector_spec.rb +1 -1
  341. data/spec/unit/resource_reporter_spec.rb +4 -4
  342. data/spec/unit/resource_spec.rb +22 -22
  343. data/spec/unit/role_spec.rb +3 -3
  344. data/spec/unit/run_context/cookbook_compiler_spec.rb +23 -23
  345. data/spec/unit/run_list/run_list_expansion_spec.rb +9 -6
  346. data/spec/unit/run_list_spec.rb +1 -1
  347. data/spec/unit/runner_spec.rb +3 -3
  348. data/spec/unit/search/query_spec.rb +3 -2
  349. data/spec/unit/shell/model_wrapper_spec.rb +1 -1
  350. data/spec/unit/shell/shell_session_spec.rb +8 -11
  351. data/spec/unit/shell_spec.rb +1 -2
  352. data/spec/unit/user_spec.rb +4 -4
  353. data/spec/unit/user_v1_spec.rb +3 -3
  354. data/spec/unit/util/backup_spec.rb +1 -1
  355. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +13 -13
  356. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +3 -3
  357. data/spec/unit/util/editor_spec.rb +1 -1
  358. data/spec/unit/util/powershell/ps_credential_spec.rb +3 -2
  359. data/spec/unit/util/threaded_job_queue_spec.rb +2 -2
  360. data/spec/unit/version_class_spec.rb +4 -4
  361. data/spec/unit/win32/registry_spec.rb +5 -5
  362. data/spec/unit/win32/security_spec.rb +2 -1
  363. data/tasks/announce.rb +4 -11
  364. metadata +10 -6
  365. data/tasks/maintainers.rb +0 -211
  366. data/tasks/templates/prerelease.md.erb +0 -35
@@ -259,7 +259,8 @@ describe Chef::Resource::Link do
259
259
  allow(stat).to receive(:gid).and_return(501)
260
260
  allow(stat).to receive(:mode).and_return(0755)
261
261
  allow(provider.file_class).to receive(:stat).with(
262
- "#{CHEF_SPEC_DATA}/fofile-link").and_return(stat)
262
+ "#{CHEF_SPEC_DATA}/fofile-link"
263
+ ).and_return(stat)
263
264
 
264
265
  provider.load_current_resource
265
266
  end
@@ -267,7 +268,8 @@ describe Chef::Resource::Link do
267
268
  shared_context "delete link to directories on Windows" do
268
269
  before do
269
270
  allow(::File).to receive(:directory?).with(
270
- "#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
271
+ "#{CHEF_SPEC_DATA}/fofile-link"
272
+ ).and_return(true)
271
273
  end
272
274
 
273
275
  it "invokes Dir.delete method to delete the link" do
@@ -280,7 +282,8 @@ describe Chef::Resource::Link do
280
282
  shared_context "delete link to directories on Linux" do
281
283
  before do
282
284
  allow(::File).to receive(:directory?).with(
283
- "#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
285
+ "#{CHEF_SPEC_DATA}/fofile-link"
286
+ ).and_return(true)
284
287
  end
285
288
 
286
289
  it "invokes File.delete method to delete the link" do
@@ -293,7 +296,8 @@ describe Chef::Resource::Link do
293
296
  shared_context "delete link to files" do
294
297
  before do
295
298
  allow(::File).to receive(:directory?).with(
296
- "#{CHEF_SPEC_DATA}/fofile-link").and_return(false)
299
+ "#{CHEF_SPEC_DATA}/fofile-link"
300
+ ).and_return(false)
297
301
  end
298
302
 
299
303
  it "invokes File.delete method to delete the link" do
@@ -306,9 +310,11 @@ describe Chef::Resource::Link do
306
310
  shared_context "soft links prerequisites" do
307
311
  before(:each) do
308
312
  allow(provider.file_class).to receive(:symlink?).with(
309
- "#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
313
+ "#{CHEF_SPEC_DATA}/fofile-link"
314
+ ).and_return(true)
310
315
  allow(provider.file_class).to receive(:readlink).with(
311
- "#{CHEF_SPEC_DATA}/fofile-link").and_return("#{CHEF_SPEC_DATA}/fofile")
316
+ "#{CHEF_SPEC_DATA}/fofile-link"
317
+ ).and_return("#{CHEF_SPEC_DATA}/fofile")
312
318
  end
313
319
  end
314
320
 
@@ -327,15 +333,19 @@ describe Chef::Resource::Link do
327
333
  allow(stat).to receive(:mode).and_return(0644)
328
334
 
329
335
  allow(provider.file_class).to receive(:symlink?).with(
330
- "#{CHEF_SPEC_DATA}/fofile-link").and_return(false)
336
+ "#{CHEF_SPEC_DATA}/fofile-link"
337
+ ).and_return(false)
331
338
 
332
339
  allow(File).to receive(:exists?).with(
333
- "#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
340
+ "#{CHEF_SPEC_DATA}/fofile-link"
341
+ ).and_return(true)
334
342
  allow(File).to receive(:exists?).with(
335
- "#{CHEF_SPEC_DATA}/fofile").and_return(true)
343
+ "#{CHEF_SPEC_DATA}/fofile"
344
+ ).and_return(true)
336
345
 
337
346
  allow(provider.file_class).to receive(:stat).with(
338
- "#{CHEF_SPEC_DATA}/fofile").and_return(stat)
347
+ "#{CHEF_SPEC_DATA}/fofile"
348
+ ).and_return(stat)
339
349
  end
340
350
  end
341
351
 
@@ -346,7 +356,8 @@ describe Chef::Resource::Link do
346
356
 
347
357
  before(:each) do
348
358
  allow(Chef::Resource::Link).to receive(:new).with(
349
- provider.new_resource.name).and_return(resource_link)
359
+ provider.new_resource.name
360
+ ).and_return(resource_link)
350
361
  allow(resource_link).to receive(:verify_links_supported!)
351
362
  allow(Chef::Platform).to receive(:windows?).and_return(true)
352
363
  end
@@ -26,29 +26,29 @@ describe Chef::Provider::Mount::Aix do
26
26
  node mounted mounted over vfs date options
27
27
  -------- --------------- --------------- ------ ------------ ---------------
28
28
  /dev/sdz1 /tmp/foo jfs2 Jul 17 13:22 rw,log=/dev/hd8
29
- MOUNT
29
+ MOUNT
30
30
 
31
31
  @unmounted_output = <<~UNMOUNTED
32
32
  node mounted mounted over vfs date options
33
33
  -------- --------------- --------------- ------ ------------ ---------------
34
34
  /dev/sdz2 / jfs2 Jul 17 13:22 rw,log=/dev/hd8
35
- UNMOUNTED
35
+ UNMOUNTED
36
36
 
37
37
  @conflict_mounted_output = <<~MOUNT
38
38
  node mounted mounted over vfs date options
39
39
  -------- --------------- --------------- ------ ------------ ---------------
40
40
  /dev/sdz3 /tmp/foo jfs2 Jul 17 13:22 rw,log=/dev/hd8
41
- MOUNT
41
+ MOUNT
42
42
 
43
43
  @enabled_output = <<~ENABLED
44
44
  #MountPoint:Device:Vfs:Nodename:Type:Size:Options:AutoMount:Acct
45
45
  /tmp/foo:/dev/sdz1:jfs2::bootfs:10485760:rw:yes:no
46
- ENABLED
46
+ ENABLED
47
47
 
48
48
  @test_wrong_output = <<~WRONG
49
49
  #MountPoint:Device:Vfs:Nodename:Type:Size:Options:AutoMount:Acct
50
50
  /tmp/foo::/dev/sdz1:jfs2:bootfs:10485760:rw:yes:no
51
- WRONG
51
+ WRONG
52
52
  end
53
53
 
54
54
  before(:each) do
@@ -256,7 +256,7 @@ WRONG
256
256
  vfs = jfs2
257
257
  mount = true
258
258
  options = rw
259
- ETCFILESYSTEMS
259
+ ETCFILESYSTEMS
260
260
 
261
261
  filesystems = StringIO.new
262
262
  allow(::File).to receive(:open).with("/etc/filesystems", "w").and_yield(filesystems)
@@ -67,23 +67,23 @@ describe Chef::Provider::Mount::Mount do
67
67
  describe "when dealing with network mounts" do
68
68
  { "nfs" => "nfsserver:/vol/path",
69
69
  "cifs" => "//cifsserver/share" }.each do |type, fs_spec|
70
- it "should detect network fs_spec (#{type})" do
71
- @new_resource.device fs_spec
72
- expect(@provider.network_device?).to be_truthy
70
+ it "should detect network fs_spec (#{type})" do
71
+ @new_resource.device fs_spec
72
+ expect(@provider.network_device?).to be_truthy
73
+ end
74
+
75
+ it "should ignore trailing slash and set mounted to true for network mount (#{type})" do
76
+ @new_resource.device fs_spec
77
+ allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: "#{fs_spec}/ on /tmp/foo type #{type} (rw)\n"))
78
+ @provider.load_current_resource
79
+ expect(@provider.current_resource.mounted).to be_truthy
80
+ end
73
81
  end
74
-
75
- it "should ignore trailing slash and set mounted to true for network mount (#{type})" do
76
- @new_resource.device fs_spec
77
- allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: "#{fs_spec}/ on /tmp/foo type #{type} (rw)\n"))
78
- @provider.load_current_resource
79
- expect(@provider.current_resource.mounted).to be_truthy
80
- end
81
- end
82
82
  end
83
83
 
84
84
  it "should raise an error if the mount device does not exist" do
85
85
  allow(::File).to receive(:exists?).with("/dev/sdz1").and_return false
86
- expect { @provider.load_current_resource(); @provider.mountable? }.to raise_error(Chef::Exceptions::Mount)
86
+ expect { @provider.load_current_resource; @provider.mountable? }.to raise_error(Chef::Exceptions::Mount)
87
87
  end
88
88
 
89
89
  it "should not call mountable? with load_current_resource - CHEF-1565" do
@@ -100,36 +100,36 @@ describe Chef::Provider::Mount::Mount do
100
100
  @new_resource.device "d21afe51-a0fe-4dc6-9152-ac733763ae0a"
101
101
  expect(@provider).to receive(:shell_out_compacted).with("/sbin/findfs", "UUID=d21afe51-a0fe-4dc6-9152-ac733763ae0a").and_return(status)
102
102
  expect(::File).to receive(:exists?).with("").and_return(false)
103
- expect { @provider.load_current_resource(); @provider.mountable? }.to raise_error(Chef::Exceptions::Mount)
103
+ expect { @provider.load_current_resource; @provider.mountable? }.to raise_error(Chef::Exceptions::Mount)
104
104
  end
105
105
 
106
106
  it "should raise an error if the mount point does not exist" do
107
107
  allow(::File).to receive(:exists?).with("/tmp/foo").and_return false
108
- expect { @provider.load_current_resource(); @provider.mountable? }.to raise_error(Chef::Exceptions::Mount)
108
+ expect { @provider.load_current_resource; @provider.mountable? }.to raise_error(Chef::Exceptions::Mount)
109
109
  end
110
110
 
111
111
  %w{tmpfs fuse cgroup vboxsf zfs}.each do |fstype|
112
112
  it "does not expect the device to exist for #{fstype}" do
113
113
  @new_resource.fstype(fstype)
114
114
  @new_resource.device("whatever")
115
- expect { @provider.load_current_resource(); @provider.mountable? }.not_to raise_error
115
+ expect { @provider.load_current_resource; @provider.mountable? }.not_to raise_error
116
116
  end
117
117
  end
118
118
 
119
119
  it "does not expect the device to exist if it's none" do
120
120
  @new_resource.device("none")
121
- expect { @provider.load_current_resource(); @provider.mountable? }.not_to raise_error
121
+ expect { @provider.load_current_resource; @provider.mountable? }.not_to raise_error
122
122
  end
123
123
 
124
124
  it "should set mounted true if the mount point is found in the mounts list" do
125
125
  allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: "/dev/sdz1 on /tmp/foo type ext3 (rw)\n"))
126
- @provider.load_current_resource()
126
+ @provider.load_current_resource
127
127
  expect(@provider.current_resource.mounted).to be_truthy
128
128
  end
129
129
 
130
130
  it "should set mounted false if another mount point beginning with the same path is found in the mounts list" do
131
131
  allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: "/dev/sdz1 on /tmp/foobar type ext3 (rw)\n"))
132
- @provider.load_current_resource()
132
+ @provider.load_current_resource
133
133
  expect(@provider.current_resource.mounted).to be_falsey
134
134
  end
135
135
 
@@ -141,7 +141,7 @@ describe Chef::Provider::Mount::Mount do
141
141
  allow(::File).to receive(:readlink).with((@new_resource.device).to_s).and_return(target)
142
142
 
143
143
  allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: "#{target} on /tmp/foo type ext3 (rw)\n"))
144
- @provider.load_current_resource()
144
+ @provider.load_current_resource
145
145
  expect(@provider.current_resource.mounted).to be_truthy
146
146
  end
147
147
 
@@ -155,7 +155,7 @@ describe Chef::Provider::Mount::Mount do
155
155
  allow(::File).to receive(:readlink).with((@new_resource.device).to_s).and_return(target)
156
156
 
157
157
  allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: "#{absolute_target} on /tmp/foo type ext3 (rw)\n"))
158
- @provider.load_current_resource()
158
+ @provider.load_current_resource
159
159
  expect(@provider.current_resource.mounted).to be_truthy
160
160
  end
161
161
 
@@ -164,7 +164,7 @@ describe Chef::Provider::Mount::Mount do
164
164
  mount << "#{@new_resource.device} on #{@new_resource.mount_point} type ext3 (rw)\n"
165
165
 
166
166
  allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: mount))
167
- @provider.load_current_resource()
167
+ @provider.load_current_resource
168
168
  expect(@provider.current_resource.mounted).to be_truthy
169
169
  end
170
170
 
@@ -173,13 +173,13 @@ describe Chef::Provider::Mount::Mount do
173
173
  mount << "/dev/sdy1 on #{@new_resource.mount_point} type ext3 (rw)\n"
174
174
 
175
175
  allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: mount))
176
- @provider.load_current_resource()
176
+ @provider.load_current_resource
177
177
  expect(@provider.current_resource.mounted).to be_falsey
178
178
  end
179
179
 
180
180
  it "mounted should be false if the mount point is not found in the mounts list" do
181
181
  allow(@provider).to receive(:shell_out!).and_return(OpenStruct.new(stdout: "/dev/sdy1 on /tmp/foo type ext3 (rw)\n"))
182
- @provider.load_current_resource()
182
+ @provider.load_current_resource
183
183
  expect(@provider.current_resource.mounted).to be_falsey
184
184
  end
185
185
 
@@ -297,14 +297,14 @@ describe Chef::Provider::Mount::Mount do
297
297
  describe "mount_fs" do
298
298
  it "should mount the filesystem if it is not mounted" do
299
299
  expect(@provider).to receive(:shell_out_compacted!).with("mount", "-t", "ext3", "-o", "defaults", "/dev/sdz1", "/tmp/foo")
300
- @provider.mount_fs()
300
+ @provider.mount_fs
301
301
  end
302
302
 
303
303
  it "should mount the filesystem with options if options were passed" do
304
304
  options = "rw,noexec,noauto"
305
305
  @new_resource.options(%w{rw noexec noauto})
306
306
  expect(@provider).to receive(:shell_out_compacted!).with("mount", "-t", "ext3", "-o", "rw,noexec,noauto", "/dev/sdz1", "/tmp/foo")
307
- @provider.mount_fs()
307
+ @provider.mount_fs
308
308
  end
309
309
 
310
310
  it "should mount the filesystem specified by uuid", :not_supported_on_solaris do
@@ -315,13 +315,13 @@ describe Chef::Provider::Mount::Mount do
315
315
  @stdout_mock = double("stdout mock")
316
316
  allow(@stdout_mock).to receive(:each).and_yield("#{@new_resource.device} on #{@new_resource.mount_point}")
317
317
  expect(@provider).to receive(:shell_out_compacted!).with("mount", "-t", @new_resource.fstype, "-o", "defaults", "-U", @new_resource.device, @new_resource.mount_point).and_return(@stdout_mock)
318
- @provider.mount_fs()
318
+ @provider.mount_fs
319
319
  end
320
320
 
321
321
  it "should not mount the filesystem if it is mounted" do
322
322
  allow(@current_resource).to receive(:mounted).and_return(true)
323
323
  expect(@provider).not_to receive(:shell_out!)
324
- @provider.mount_fs()
324
+ @provider.mount_fs
325
325
  end
326
326
 
327
327
  end
@@ -330,13 +330,13 @@ describe Chef::Provider::Mount::Mount do
330
330
  it "should umount the filesystem if it is mounted" do
331
331
  @current_resource.mounted(true)
332
332
  expect(@provider).to receive(:shell_out!).with("umount", "/tmp/foo")
333
- @provider.umount_fs()
333
+ @provider.umount_fs
334
334
  end
335
335
 
336
336
  it "should not umount the filesystem if it is not mounted" do
337
337
  @current_resource.mounted(false)
338
338
  expect(@provider).not_to receive(:shell_out!)
339
- @provider.umount_fs()
339
+ @provider.umount_fs
340
340
  end
341
341
  end
342
342
 
@@ -363,7 +363,7 @@ describe Chef::Provider::Mount::Mount do
363
363
  expect(@provider).to receive(:umount_fs)
364
364
  expect(@provider).to receive(:sleep).with(1)
365
365
  expect(@provider).to receive(:mount_fs)
366
- @provider.remount_fs()
366
+ @provider.remount_fs
367
367
  end
368
368
 
369
369
  it "should not try to remount at all if mounted is false" do
@@ -371,7 +371,7 @@ describe Chef::Provider::Mount::Mount do
371
371
  expect(@provider).not_to receive(:shell_out!)
372
372
  expect(@provider).not_to receive(:umount_fs)
373
373
  expect(@provider).not_to receive(:mount_fs)
374
- @provider.remount_fs()
374
+ @provider.remount_fs
375
375
  end
376
376
  end
377
377
 
@@ -103,7 +103,7 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
103
103
  describe "#define_resource_requirements" do
104
104
  before do
105
105
  # we're not testing the actual actions so stub them all out
106
- [:mount_fs, :umount_fs, :remount_fs, :enable_fs, :disable_fs].each { |m| allow(provider).to receive(m) }
106
+ %i{mount_fs umount_fs remount_fs enable_fs disable_fs}.each { |m| allow(provider).to receive(m) }
107
107
  end
108
108
 
109
109
  it "run_action(:mount) should raise an error if the device does not exist" do
@@ -350,7 +350,7 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
350
350
  expect(File).to receive(:symlink?).with(device).at_least(:once).and_return(true)
351
351
  expect(File).to receive(:readlink).with(device).at_least(:once).and_return(target)
352
352
 
353
- provider.load_current_resource()
353
+ provider.load_current_resource
354
354
  end
355
355
 
356
356
  it "should set mounted true if the symlink target of the device is found in the mounts list" do
@@ -387,7 +387,7 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
387
387
  expect(File).to receive(:symlink?).with(device).at_least(:once).and_return(true)
388
388
  expect(File).to receive(:readlink).with(device).at_least(:once).and_return(target)
389
389
 
390
- provider.load_current_resource()
390
+ provider.load_current_resource
391
391
  end
392
392
 
393
393
  it "should set mounted true if the symlink target of the device is found in the mounts list" do
@@ -411,7 +411,7 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
411
411
  EOF
412
412
  end
413
413
  it "should set mounted true" do
414
- provider.load_current_resource()
414
+ provider.load_current_resource
415
415
  expect(provider.current_resource.mounted).to be_truthy
416
416
  end
417
417
  end
@@ -424,7 +424,7 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
424
424
  EOF
425
425
  end
426
426
  it "should set mounted false" do
427
- provider.load_current_resource()
427
+ provider.load_current_resource
428
428
  expect(provider.current_resource.mounted).to be_falsey
429
429
  end
430
430
  end
@@ -436,7 +436,7 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
436
436
  EOF
437
437
  end
438
438
  it "should set mounted false" do
439
- provider.load_current_resource()
439
+ provider.load_current_resource
440
440
  expect(provider.current_resource.mounted).to be_falsey
441
441
  end
442
442
  end
@@ -448,7 +448,7 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
448
448
  EOF
449
449
  end
450
450
  it "should set mounted false" do
451
- provider.load_current_resource()
451
+ provider.load_current_resource
452
452
  expect(provider.current_resource.mounted).to be_falsey
453
453
  end
454
454
  end
@@ -539,28 +539,28 @@ describe Chef::Provider::Mount::Solaris, :unix_only do
539
539
  describe "mount_fs" do
540
540
  it "should mount the filesystem" do
541
541
  expect(provider).to receive(:shell_out_compacted!).with("mount", "-F", fstype, device, mountpoint)
542
- provider.mount_fs()
542
+ provider.mount_fs
543
543
  end
544
544
 
545
545
  it "should mount the filesystem with options if options were passed" do
546
546
  options = "logging,noatime,largefiles,nosuid,rw,quota"
547
547
  new_resource.options(options.split(/,/))
548
548
  expect(provider).to receive(:shell_out_compacted!).with("mount", "-F", fstype, "-o", options, device, mountpoint)
549
- provider.mount_fs()
549
+ provider.mount_fs
550
550
  end
551
551
 
552
552
  it "should delete the 'noauto' magic option" do
553
553
  options = "rw,noauto"
554
554
  new_resource.options(%w{rw noauto})
555
555
  expect(provider).to receive(:shell_out_compacted!).with("mount", "-F", fstype, "-o", "rw", device, mountpoint)
556
- provider.mount_fs()
556
+ provider.mount_fs
557
557
  end
558
558
  end
559
559
 
560
560
  describe "umount_fs" do
561
561
  it "should umount the filesystem if it is mounted" do
562
562
  expect(provider).to receive(:shell_out_compacted!).with("umount", mountpoint)
563
- provider.umount_fs()
563
+ provider.umount_fs
564
564
  end
565
565
  end
566
566
 
@@ -43,7 +43,7 @@ describe Chef::Provider::Ohai do
43
43
  }
44
44
  allow(mock_ohai).to receive(:all_plugins).and_return(true)
45
45
  allow(mock_ohai).to receive(:data).and_return(mock_ohai[:data],
46
- mock_ohai[:data2])
46
+ mock_ohai[:data2])
47
47
  allow(Ohai::System).to receive(:new).and_return(mock_ohai)
48
48
  allow(Chef::Platform).to receive(:find_platform_and_version).and_return({ "platform" => @platform,
49
49
  "platform_version" => @platform_version })
@@ -132,7 +132,7 @@ describe Chef::Provider::OsxProfile do
132
132
  provider.load_current_resource
133
133
  expect(
134
134
  provider.instance_variable_get(:@new_profile_identifier)
135
- ).to eql(test_profile["PayloadIdentifier"])
135
+ ).to eql(test_profile["PayloadIdentifier"])
136
136
  end
137
137
 
138
138
  it "should install when not installed" do
@@ -167,7 +167,7 @@ describe Chef::Provider::OsxProfile do
167
167
  provider.load_current_resource
168
168
  allow(provider).to receive(:write_profile_to_disk).and_return(profile_path)
169
169
  expect(provider).to receive(:shell_out_compacted).with("/usr/bin/profiles", "-I", "-F", profile_path).and_return(shell_out_success)
170
- provider.action_install()
170
+ provider.action_install
171
171
  end
172
172
 
173
173
  it "should fail if there is no identifier inside the profile" do
@@ -228,16 +228,14 @@ describe Chef::Provider::OsxProfile do
228
228
  new_resource.profile_name "com.testprofile.screensaver"
229
229
  new_resource.action(:remove)
230
230
  provider.load_current_resource
231
- expect(provider.instance_variable_get(:@new_profile_identifier)
232
- ).to eql(new_resource.profile_name)
231
+ expect(provider.instance_variable_get(:@new_profile_identifier)).to eql(new_resource.profile_name)
233
232
  end
234
233
 
235
234
  it "should use specified identifier" do
236
235
  new_resource.identifier "com.testprofile.screensaver"
237
236
  new_resource.action(:remove)
238
237
  provider.load_current_resource
239
- expect(provider.instance_variable_get(:@new_profile_identifier)
240
- ).to eql(new_resource.identifier)
238
+ expect(provider.instance_variable_get(:@new_profile_identifier)).to eql(new_resource.identifier)
241
239
  end
242
240
 
243
241
  it "should work with spaces in the identifier" do
@@ -251,7 +249,7 @@ describe Chef::Provider::OsxProfile do
251
249
  new_resource.action(:remove)
252
250
  provider.load_current_resource
253
251
  expect(provider).to receive(:shell_out_compacted).with("/usr/bin/profiles", "-R", "-p", new_resource.identifier).and_return(shell_out_success)
254
- provider.action_remove()
252
+ provider.action_remove
255
253
  end
256
254
  end
257
255
  end