chef 14.14.29-universal-mingw32 → 14.15.6-universal-mingw32

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (366) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -1
  3. data/README.md +18 -7
  4. data/Rakefile +7 -4
  5. data/chef.gemspec +1 -1
  6. data/lib/chef/knife/ssh.rb +6 -0
  7. data/lib/chef/provider/ifconfig.rb +14 -5
  8. data/lib/chef/provider/windows_task.rb +9 -5
  9. data/lib/chef/resource/kernel_module.rb +61 -0
  10. data/lib/chef/resource/windows_task.rb +4 -0
  11. data/lib/chef/version.rb +1 -1
  12. data/spec/data/cookbooks/openldap/metadata.rb +2 -2
  13. data/spec/data/metadata/quick_start/metadata.rb +2 -7
  14. data/spec/functional/audit/runner_spec.rb +1 -1
  15. data/spec/functional/dsl/reboot_pending_spec.rb +7 -25
  16. data/spec/functional/event_loggers/windows_eventlog_spec.rb +6 -4
  17. data/spec/functional/file_content_management/deploy_strategies_spec.rb +21 -21
  18. data/spec/functional/knife/exec_spec.rb +1 -1
  19. data/spec/functional/knife/ssh_spec.rb +3 -3
  20. data/spec/functional/mixin/user_context_spec.rb +3 -1
  21. data/spec/functional/rebooter_spec.rb +1 -1
  22. data/spec/functional/resource/aix_service_spec.rb +1 -1
  23. data/spec/functional/resource/aixinit_service_spec.rb +1 -1
  24. data/spec/functional/resource/apt_package_spec.rb +1 -1
  25. data/spec/functional/resource/chocolatey_package_spec.rb +2 -2
  26. data/spec/functional/resource/cookbook_file_spec.rb +1 -3
  27. data/spec/functional/resource/cron_spec.rb +4 -3
  28. data/spec/functional/resource/dpkg_package_spec.rb +4 -4
  29. data/spec/functional/resource/dsc_resource_spec.rb +2 -1
  30. data/spec/functional/resource/dsc_script_spec.rb +16 -20
  31. data/spec/functional/resource/execute_spec.rb +2 -2
  32. data/spec/functional/resource/git_spec.rb +6 -6
  33. data/spec/functional/resource/group_spec.rb +8 -6
  34. data/spec/functional/resource/ifconfig_spec.rb +3 -5
  35. data/spec/functional/resource/link_spec.rb +2 -2
  36. data/spec/functional/resource/mount_spec.rb +3 -7
  37. data/spec/functional/resource/powershell_script_spec.rb +9 -8
  38. data/spec/functional/resource/reboot_spec.rb +1 -1
  39. data/spec/functional/resource/remote_file_spec.rb +2 -2
  40. data/spec/functional/resource/template_spec.rb +1 -1
  41. data/spec/functional/resource/user/windows_spec.rb +2 -2
  42. data/spec/functional/resource/windows_certificate_spec.rb +3 -3
  43. data/spec/functional/resource/windows_service_spec.rb +3 -3
  44. data/spec/functional/resource/windows_task_spec.rb +51 -0
  45. data/spec/functional/run_lock_spec.rb +10 -3
  46. data/spec/functional/shell_spec.rb +1 -1
  47. data/spec/functional/util/powershell/cmdlet_spec.rb +1 -1
  48. data/spec/functional/version_spec.rb +1 -1
  49. data/spec/functional/win32/security_spec.rb +12 -7
  50. data/spec/functional/win32/service_manager_spec.rb +1 -1
  51. data/spec/functional/win32/version_info_spec.rb +4 -4
  52. data/spec/integration/client/client_spec.rb +114 -132
  53. data/spec/integration/client/exit_code_spec.rb +8 -8
  54. data/spec/integration/client/ipv6_spec.rb +5 -5
  55. data/spec/integration/knife/chef_fs_data_store_spec.rb +38 -38
  56. data/spec/integration/knife/chef_repo_path_spec.rb +42 -42
  57. data/spec/integration/knife/chef_repository_file_system_spec.rb +9 -9
  58. data/spec/integration/knife/chefignore_spec.rb +13 -13
  59. data/spec/integration/knife/client_bulk_delete_spec.rb +8 -8
  60. data/spec/integration/knife/client_create_spec.rb +1 -1
  61. data/spec/integration/knife/client_delete_spec.rb +4 -4
  62. data/spec/integration/knife/client_key_delete_spec.rb +1 -1
  63. data/spec/integration/knife/client_key_list_spec.rb +1 -1
  64. data/spec/integration/knife/client_list_spec.rb +1 -1
  65. data/spec/integration/knife/common_options_spec.rb +1 -1
  66. data/spec/integration/knife/config_get_spec.rb +1 -1
  67. data/spec/integration/knife/config_list_profiles_spec.rb +2 -1
  68. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +3 -3
  69. data/spec/integration/knife/cookbook_bulk_delete_spec.rb +3 -3
  70. data/spec/integration/knife/cookbook_download_spec.rb +4 -4
  71. data/spec/integration/knife/cookbook_list_spec.rb +2 -2
  72. data/spec/integration/knife/cookbook_show_spec.rb +3 -3
  73. data/spec/integration/knife/cookbook_upload_spec.rb +6 -6
  74. data/spec/integration/knife/data_bag_delete_spec.rb +4 -4
  75. data/spec/integration/knife/data_bag_from_file_spec.rb +7 -7
  76. data/spec/integration/knife/data_bag_list_spec.rb +1 -1
  77. data/spec/integration/knife/delete_spec.rb +37 -37
  78. data/spec/integration/knife/deps_spec.rb +23 -23
  79. data/spec/integration/knife/diff_spec.rb +23 -23
  80. data/spec/integration/knife/download_spec.rb +79 -79
  81. data/spec/integration/knife/environment_compare_spec.rb +3 -3
  82. data/spec/integration/knife/environment_from_file_spec.rb +6 -6
  83. data/spec/integration/knife/environment_list_spec.rb +1 -1
  84. data/spec/integration/knife/environment_show_spec.rb +4 -4
  85. data/spec/integration/knife/list_spec.rb +25 -25
  86. data/spec/integration/knife/node_bulk_delete_spec.rb +2 -2
  87. data/spec/integration/knife/node_delete_spec.rb +2 -2
  88. data/spec/integration/knife/node_environment_set_spec.rb +1 -1
  89. data/spec/integration/knife/node_from_file_spec.rb +2 -2
  90. data/spec/integration/knife/node_list_spec.rb +1 -1
  91. data/spec/integration/knife/raw_spec.rb +12 -12
  92. data/spec/integration/knife/redirection_spec.rb +1 -1
  93. data/spec/integration/knife/role_bulk_delete_spec.rb +2 -2
  94. data/spec/integration/knife/role_delete_spec.rb +2 -2
  95. data/spec/integration/knife/role_from_file_spec.rb +5 -5
  96. data/spec/integration/knife/role_list_spec.rb +1 -1
  97. data/spec/integration/knife/role_show_spec.rb +1 -1
  98. data/spec/integration/knife/show_spec.rb +10 -10
  99. data/spec/integration/knife/upload_spec.rb +85 -85
  100. data/spec/integration/recipes/accumulator_spec.rb +4 -4
  101. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +6 -6
  102. data/spec/integration/recipes/lwrp_spec.rb +6 -6
  103. data/spec/integration/recipes/notifies_spec.rb +45 -45
  104. data/spec/integration/recipes/notifying_block_spec.rb +4 -4
  105. data/spec/integration/recipes/provider_choice.rb +1 -2
  106. data/spec/integration/recipes/recipe_dsl_spec.rb +9 -9
  107. data/spec/integration/recipes/remote_directory.rb +2 -2
  108. data/spec/integration/recipes/resource_action_spec.rb +1 -1
  109. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +19 -19
  110. data/spec/integration/solo/solo_spec.rb +29 -29
  111. data/spec/scripts/ssl-serve.rb +1 -1
  112. data/spec/spec_helper.rb +11 -14
  113. data/spec/stress/win32/security_spec.rb +1 -1
  114. data/spec/support/lib/chef/resource/zen_follower.rb +1 -1
  115. data/spec/support/lib/chef/resource/zen_master.rb +1 -1
  116. data/spec/support/mock/platform.rb +2 -2
  117. data/spec/support/platform_helpers.rb +12 -3
  118. data/spec/support/platforms/win32/spec_service.rb +6 -10
  119. data/spec/support/shared/context/client.rb +2 -1
  120. data/spec/support/shared/functional/execute_resource.rb +4 -4
  121. data/spec/support/shared/functional/file_resource.rb +1 -3
  122. data/spec/support/shared/functional/http.rb +20 -44
  123. data/spec/support/shared/functional/securable_resource.rb +4 -8
  124. data/spec/support/shared/functional/win32_service.rb +1 -1
  125. data/spec/support/shared/functional/windows_script.rb +2 -1
  126. data/spec/support/shared/integration/app_server_support.rb +3 -4
  127. data/spec/support/shared/integration/integration_helper.rb +1 -0
  128. data/spec/support/shared/integration/knife_support.rb +5 -5
  129. data/spec/support/shared/unit/application_dot_d.rb +10 -4
  130. data/spec/support/shared/unit/file_system_support.rb +3 -2
  131. data/spec/support/shared/unit/platform_introspector.rb +12 -12
  132. data/spec/support/shared/unit/provider/file.rb +1 -1
  133. data/spec/support/shared/unit/script_resource.rb +1 -1
  134. data/spec/support/shared/unit/windows_script_resource.rb +1 -1
  135. data/spec/tiny_server.rb +1 -1
  136. data/spec/unit/api_client/registration_spec.rb +1 -1
  137. data/spec/unit/api_client_spec.rb +5 -5
  138. data/spec/unit/api_client_v1_spec.rb +6 -6
  139. data/spec/unit/application/client_spec.rb +8 -8
  140. data/spec/unit/application/exit_code_spec.rb +3 -2
  141. data/spec/unit/application/knife_spec.rb +1 -2
  142. data/spec/unit/audit/audit_event_proxy_spec.rb +14 -7
  143. data/spec/unit/audit/audit_reporter_spec.rb +20 -11
  144. data/spec/unit/audit/control_group_data_spec.rb +17 -12
  145. data/spec/unit/chef_fs/config_spec.rb +3 -3
  146. data/spec/unit/chef_fs/file_system/repository/directory_spec.rb +1 -1
  147. data/spec/unit/chef_fs/parallelizer.rb +1 -1
  148. data/spec/unit/client_spec.rb +3 -3
  149. data/spec/unit/config_fetcher_spec.rb +1 -1
  150. data/spec/unit/cookbook/metadata_spec.rb +13 -13
  151. data/spec/unit/cookbook/synchronizer_spec.rb +6 -6
  152. data/spec/unit/cookbook_loader_spec.rb +17 -17
  153. data/spec/unit/cookbook_manifest_spec.rb +9 -9
  154. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +1 -2
  155. data/spec/unit/cookbook_uploader_spec.rb +2 -2
  156. data/spec/unit/cookbook_version_file_specificity_spec.rb +9 -9
  157. data/spec/unit/cookbook_version_spec.rb +2 -2
  158. data/spec/unit/data_bag_item_spec.rb +7 -7
  159. data/spec/unit/data_bag_spec.rb +1 -1
  160. data/spec/unit/data_collector_spec.rb +23 -23
  161. data/spec/unit/decorator_spec.rb +2 -2
  162. data/spec/unit/deprecated_spec.rb +2 -2
  163. data/spec/unit/dsl/data_query_spec.rb +3 -2
  164. data/spec/unit/dsl/declare_resource_spec.rb +1 -1
  165. data/spec/unit/dsl/platform_introspection_spec.rb +2 -2
  166. data/spec/unit/encrypted_data_bag_item/check_encrypted_spec.rb +2 -1
  167. data/spec/unit/encrypted_data_bag_item_spec.rb +2 -1
  168. data/spec/unit/environment_spec.rb +13 -13
  169. data/spec/unit/event_dispatch/dsl_spec.rb +1 -1
  170. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +3 -3
  171. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +2 -2
  172. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +3 -3
  173. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +1 -1
  174. data/spec/unit/http/authenticator_spec.rb +4 -3
  175. data/spec/unit/http/json_input_spec.rb +1 -1
  176. data/spec/unit/http/socketless_chef_zero_client_spec.rb +15 -15
  177. data/spec/unit/key_spec.rb +8 -8
  178. data/spec/unit/knife/bootstrap_spec.rb +14 -10
  179. data/spec/unit/knife/client_bulk_delete_spec.rb +4 -4
  180. data/spec/unit/knife/configure_client_spec.rb +1 -1
  181. data/spec/unit/knife/configure_spec.rb +1 -1
  182. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +1 -1
  183. data/spec/unit/knife/cookbook_delete_spec.rb +2 -2
  184. data/spec/unit/knife/cookbook_download_spec.rb +2 -2
  185. data/spec/unit/knife/cookbook_metadata_spec.rb +4 -4
  186. data/spec/unit/knife/cookbook_upload_spec.rb +7 -5
  187. data/spec/unit/knife/core/bootstrap_context_spec.rb +1 -1
  188. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +2 -2
  189. data/spec/unit/knife/core/gem_glob_loader_spec.rb +4 -4
  190. data/spec/unit/knife/core/hashed_command_loader_spec.rb +4 -2
  191. data/spec/unit/knife/core/node_editor_spec.rb +12 -12
  192. data/spec/unit/knife/core/ui_spec.rb +11 -11
  193. data/spec/unit/knife/data_bag_from_file_spec.rb +2 -1
  194. data/spec/unit/knife/data_bag_show_spec.rb +2 -1
  195. data/spec/unit/knife/key_create_spec.rb +1 -1
  196. data/spec/unit/knife/key_delete_spec.rb +3 -3
  197. data/spec/unit/knife/key_edit_spec.rb +4 -4
  198. data/spec/unit/knife/key_list_spec.rb +1 -1
  199. data/spec/unit/knife/key_show_spec.rb +3 -3
  200. data/spec/unit/knife/node_bulk_delete_spec.rb +3 -3
  201. data/spec/unit/knife/node_delete_spec.rb +2 -2
  202. data/spec/unit/knife/node_edit_spec.rb +1 -1
  203. data/spec/unit/knife/node_environment_set_spec.rb +1 -1
  204. data/spec/unit/knife/node_from_file_spec.rb +1 -1
  205. data/spec/unit/knife/node_policy_set_spec.rb +1 -1
  206. data/spec/unit/knife/node_run_list_add_spec.rb +1 -1
  207. data/spec/unit/knife/node_run_list_remove_spec.rb +1 -1
  208. data/spec/unit/knife/node_run_list_set_spec.rb +1 -1
  209. data/spec/unit/knife/node_show_spec.rb +1 -1
  210. data/spec/unit/knife/raw_spec.rb +2 -2
  211. data/spec/unit/knife/role_bulk_delete_spec.rb +2 -2
  212. data/spec/unit/knife/role_create_spec.rb +1 -1
  213. data/spec/unit/knife/role_delete_spec.rb +1 -1
  214. data/spec/unit/knife/role_edit_spec.rb +1 -1
  215. data/spec/unit/knife/role_env_run_list_add_spec.rb +1 -1
  216. data/spec/unit/knife/role_env_run_list_clear_spec.rb +1 -1
  217. data/spec/unit/knife/role_env_run_list_remove_spec.rb +1 -1
  218. data/spec/unit/knife/role_env_run_list_replace_spec.rb +1 -1
  219. data/spec/unit/knife/role_env_run_list_set_spec.rb +1 -1
  220. data/spec/unit/knife/role_from_file_spec.rb +1 -1
  221. data/spec/unit/knife/role_run_list_add_spec.rb +1 -1
  222. data/spec/unit/knife/role_run_list_clear_spec.rb +1 -1
  223. data/spec/unit/knife/role_run_list_remove_spec.rb +1 -1
  224. data/spec/unit/knife/role_run_list_replace_spec.rb +1 -1
  225. data/spec/unit/knife/role_run_list_set_spec.rb +1 -1
  226. data/spec/unit/knife/ssh_spec.rb +27 -17
  227. data/spec/unit/knife/ssl_check_spec.rb +4 -4
  228. data/spec/unit/knife/ssl_fetch_spec.rb +5 -5
  229. data/spec/unit/knife/status_spec.rb +3 -2
  230. data/spec/unit/knife/supermarket_download_spec.rb +4 -4
  231. data/spec/unit/knife/supermarket_install_spec.rb +5 -4
  232. data/spec/unit/knife/supermarket_share_spec.rb +1 -1
  233. data/spec/unit/knife_spec.rb +34 -33
  234. data/spec/unit/lwrp_spec.rb +19 -19
  235. data/spec/unit/mixin/homebrew_user_spec.rb +1 -1
  236. data/spec/unit/mixin/params_validate_spec.rb +10 -10
  237. data/spec/unit/mixin/properties_spec.rb +4 -4
  238. data/spec/unit/mixin/shell_out_spec.rb +27 -27
  239. data/spec/unit/mixin/template_spec.rb +4 -8
  240. data/spec/unit/mixin/unformatter_spec.rb +1 -2
  241. data/spec/unit/mixin/user_context_spec.rb +1 -2
  242. data/spec/unit/mixin/which.rb +2 -0
  243. data/spec/unit/mixin/windows_architecture_helper_spec.rb +3 -3
  244. data/spec/unit/node/attribute_spec.rb +79 -79
  245. data/spec/unit/node/immutable_collections_spec.rb +50 -50
  246. data/spec/unit/node_spec.rb +16 -16
  247. data/spec/unit/org_spec.rb +3 -3
  248. data/spec/unit/policy_builder/policyfile_spec.rb +2 -2
  249. data/spec/unit/property/state_spec.rb +26 -25
  250. data/spec/unit/property/validation_spec.rb +14 -13
  251. data/spec/unit/property_spec.rb +10 -9
  252. data/spec/unit/provider/apt_update_spec.rb +6 -6
  253. data/spec/unit/provider/cron_spec.rb +15 -15
  254. data/spec/unit/provider/dsc_resource_spec.rb +6 -3
  255. data/spec/unit/provider/dsc_script_spec.rb +1 -1
  256. data/spec/unit/provider/execute_spec.rb +5 -5
  257. data/spec/unit/provider/git_spec.rb +39 -39
  258. data/spec/unit/provider/group/dscl_spec.rb +3 -3
  259. data/spec/unit/provider/group/groupadd_spec.rb +1 -1
  260. data/spec/unit/provider/group_spec.rb +2 -3
  261. data/spec/unit/provider/ifconfig/aix_spec.rb +1 -1
  262. data/spec/unit/provider/ifconfig/debian_spec.rb +2 -2
  263. data/spec/unit/provider/ifconfig_spec.rb +45 -16
  264. data/spec/unit/provider/launchd_spec.rb +23 -15
  265. data/spec/unit/provider/link_spec.rb +22 -11
  266. data/spec/unit/provider/mount/aix_spec.rb +6 -6
  267. data/spec/unit/provider/mount/mount_spec.rb +31 -31
  268. data/spec/unit/provider/mount/solaris_spec.rb +11 -11
  269. data/spec/unit/provider/ohai_spec.rb +1 -1
  270. data/spec/unit/provider/osx_profile_spec.rb +5 -7
  271. data/spec/unit/provider/package/apt_spec.rb +5 -5
  272. data/spec/unit/provider/package/bff_spec.rb +1 -1
  273. data/spec/unit/provider/package/cab_spec.rb +1 -1
  274. data/spec/unit/provider/package/chocolatey_spec.rb +8 -8
  275. data/spec/unit/provider/package/freebsd/pkg_spec.rb +1 -1
  276. data/spec/unit/provider/package/ips_spec.rb +6 -6
  277. data/spec/unit/provider/package/macports_spec.rb +1 -1
  278. data/spec/unit/provider/package/msu_spec.rb +1 -1
  279. data/spec/unit/provider/package/openbsd_spec.rb +15 -11
  280. data/spec/unit/provider/package/pacman_spec.rb +3 -3
  281. data/spec/unit/provider/package/paludis_spec.rb +4 -4
  282. data/spec/unit/provider/package/portage_spec.rb +1 -1
  283. data/spec/unit/provider/package/powershell_spec.rb +1 -1
  284. data/spec/unit/provider/package/smartos_spec.rb +3 -3
  285. data/spec/unit/provider/package/solaris_spec.rb +1 -1
  286. data/spec/unit/provider/package/windows/exe_spec.rb +9 -9
  287. data/spec/unit/provider/package/windows/msi_spec.rb +7 -7
  288. data/spec/unit/provider/package/windows_spec.rb +2 -1
  289. data/spec/unit/provider/package/yum/yum_cache_spec.rb +1 -1
  290. data/spec/unit/provider/package/zypper_spec.rb +4 -4
  291. data/spec/unit/provider/package_spec.rb +1 -1
  292. data/spec/unit/provider/powershell_script_spec.rb +7 -7
  293. data/spec/unit/provider/registry_key_spec.rb +1 -1
  294. data/spec/unit/provider/remote_directory_spec.rb +6 -6
  295. data/spec/unit/provider/route_spec.rb +11 -11
  296. data/spec/unit/provider/service/arch_service_spec.rb +13 -13
  297. data/spec/unit/provider/service/debian_service_spec.rb +2 -1
  298. data/spec/unit/provider/service/freebsd_service_spec.rb +28 -24
  299. data/spec/unit/provider/service/gentoo_service_spec.rb +2 -2
  300. data/spec/unit/provider/service/init_service_spec.rb +11 -11
  301. data/spec/unit/provider/service/invokercd_service_spec.rb +11 -11
  302. data/spec/unit/provider/service/macosx_spec.rb +5 -5
  303. data/spec/unit/provider/service/openbsd_service_spec.rb +15 -11
  304. data/spec/unit/provider/service/simple_service_spec.rb +7 -7
  305. data/spec/unit/provider/service/upstart_service_spec.rb +14 -14
  306. data/spec/unit/provider/service/windows_spec.rb +53 -35
  307. data/spec/unit/provider/subversion_spec.rb +8 -4
  308. data/spec/unit/provider/systemd_unit_spec.rb +142 -142
  309. data/spec/unit/provider/template/content_spec.rb +29 -29
  310. data/spec/unit/provider/windows_task_spec.rb +1 -1
  311. data/spec/unit/provider_resolver_spec.rb +75 -75
  312. data/spec/unit/provider_spec.rb +2 -4
  313. data/spec/unit/recipe_spec.rb +4 -4
  314. data/spec/unit/resource/batch_spec.rb +1 -1
  315. data/spec/unit/resource/chef_gem_spec.rb +1 -1
  316. data/spec/unit/resource/chocolatey_config_spec.rb +1 -1
  317. data/spec/unit/resource/chocolatey_source_spec.rb +1 -1
  318. data/spec/unit/resource/directory_spec.rb +1 -1
  319. data/spec/unit/resource/dnf_package_spec.rb +1 -1
  320. data/spec/unit/resource/dsc_resource_spec.rb +1 -1
  321. data/spec/unit/resource/file/verification_spec.rb +1 -2
  322. data/spec/unit/resource/file_spec.rb +1 -1
  323. data/spec/unit/resource/group_spec.rb +1 -1
  324. data/spec/unit/resource/link_spec.rb +1 -1
  325. data/spec/unit/resource/osx_profile_spec.rb +2 -1
  326. data/spec/unit/resource/powershell_script_spec.rb +12 -7
  327. data/spec/unit/resource/registry_key_spec.rb +3 -3
  328. data/spec/unit/resource/rhsm_subscription_spec.rb +1 -1
  329. data/spec/unit/resource/service_spec.rb +1 -1
  330. data/spec/unit/resource/template_spec.rb +2 -2
  331. data/spec/unit/resource/windows_env_spec.rb +1 -1
  332. data/spec/unit/resource/windows_service_spec.rb +5 -5
  333. data/spec/unit/resource/windows_task_spec.rb +6 -2
  334. data/spec/unit/resource/yum_package_spec.rb +1 -1
  335. data/spec/unit/resource_collection/resource_list_spec.rb +1 -1
  336. data/spec/unit/resource_collection/resource_set_spec.rb +7 -7
  337. data/spec/unit/resource_collection/stepable_iterator_spec.rb +2 -2
  338. data/spec/unit/resource_collection_spec.rb +4 -4
  339. data/spec/unit/resource_definition_spec.rb +2 -2
  340. data/spec/unit/resource_inspector_spec.rb +1 -1
  341. data/spec/unit/resource_reporter_spec.rb +4 -4
  342. data/spec/unit/resource_spec.rb +22 -22
  343. data/spec/unit/role_spec.rb +3 -3
  344. data/spec/unit/run_context/cookbook_compiler_spec.rb +23 -23
  345. data/spec/unit/run_list/run_list_expansion_spec.rb +9 -6
  346. data/spec/unit/run_list_spec.rb +1 -1
  347. data/spec/unit/runner_spec.rb +3 -3
  348. data/spec/unit/search/query_spec.rb +3 -2
  349. data/spec/unit/shell/model_wrapper_spec.rb +1 -1
  350. data/spec/unit/shell/shell_session_spec.rb +8 -11
  351. data/spec/unit/shell_spec.rb +1 -2
  352. data/spec/unit/user_spec.rb +4 -4
  353. data/spec/unit/user_v1_spec.rb +3 -3
  354. data/spec/unit/util/backup_spec.rb +1 -1
  355. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +13 -13
  356. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +3 -3
  357. data/spec/unit/util/editor_spec.rb +1 -1
  358. data/spec/unit/util/powershell/ps_credential_spec.rb +3 -2
  359. data/spec/unit/util/threaded_job_queue_spec.rb +2 -2
  360. data/spec/unit/version_class_spec.rb +4 -4
  361. data/spec/unit/win32/registry_spec.rb +5 -5
  362. data/spec/unit/win32/security_spec.rb +2 -1
  363. data/tasks/announce.rb +4 -11
  364. metadata +10 -6
  365. data/tasks/maintainers.rb +0 -211
  366. data/tasks/templates/prerelease.md.erb +0 -35
@@ -30,20 +30,20 @@ describe Chef::Provider::Template::Content do
30
30
 
31
31
  let(:new_resource) do
32
32
  double("Chef::Resource::Template (new)",
33
- cookbook_name: "openldap",
34
- recipe_name: "default",
35
- source_line: "/Users/lamont/solo/cookbooks/openldap/recipes/default.rb:2:in `from_file'",
36
- source_line_file: "/Users/lamont/solo/cookbooks/openldap/recipes/default.rb",
37
- source_line_number: "2",
38
- source: "openldap_stuff.conf.erb",
39
- name: "openldap_stuff.conf",
40
- path: resource_path,
41
- local: false,
42
- cookbook: nil,
43
- variables: {},
44
- inline_helper_blocks: {},
45
- inline_helper_modules: [],
46
- helper_modules: [])
33
+ cookbook_name: "openldap",
34
+ recipe_name: "default",
35
+ source_line: "/Users/lamont/solo/cookbooks/openldap/recipes/default.rb:2:in `from_file'",
36
+ source_line_file: "/Users/lamont/solo/cookbooks/openldap/recipes/default.rb",
37
+ source_line_number: "2",
38
+ source: "openldap_stuff.conf.erb",
39
+ name: "openldap_stuff.conf",
40
+ path: resource_path,
41
+ local: false,
42
+ cookbook: nil,
43
+ variables: {},
44
+ inline_helper_blocks: {},
45
+ inline_helper_modules: [],
46
+ helper_modules: [])
47
47
  end
48
48
 
49
49
  let(:rendered_file_locations) do
@@ -130,20 +130,20 @@ describe Chef::Provider::Template::Content do
130
130
  describe "when using location helpers" do
131
131
  let(:new_resource) do
132
132
  double("Chef::Resource::Template (new)",
133
- cookbook_name: "openldap",
134
- recipe_name: "default",
135
- source_line: CHEF_SPEC_DATA + "/cookbooks/openldap/recipes/default.rb:2:in `from_file'",
136
- source_line_file: CHEF_SPEC_DATA + "/cookbooks/openldap/recipes/default.rb",
137
- source_line_number: "2",
138
- source: "helpers.erb",
139
- name: "helpers.erb",
140
- path: CHEF_SPEC_DATA + "/cookbooks/openldap/templates/default/helpers.erb",
141
- local: false,
142
- cookbook: nil,
143
- variables: {},
144
- inline_helper_blocks: {},
145
- inline_helper_modules: [],
146
- helper_modules: [])
133
+ cookbook_name: "openldap",
134
+ recipe_name: "default",
135
+ source_line: CHEF_SPEC_DATA + "/cookbooks/openldap/recipes/default.rb:2:in `from_file'",
136
+ source_line_file: CHEF_SPEC_DATA + "/cookbooks/openldap/recipes/default.rb",
137
+ source_line_number: "2",
138
+ source: "helpers.erb",
139
+ name: "helpers.erb",
140
+ path: CHEF_SPEC_DATA + "/cookbooks/openldap/templates/default/helpers.erb",
141
+ local: false,
142
+ cookbook: nil,
143
+ variables: {},
144
+ inline_helper_blocks: {},
145
+ inline_helper_modules: [],
146
+ helper_modules: [])
147
147
  end
148
148
 
149
149
  it "creates the template with the rendered content" do
@@ -162,7 +162,7 @@ describe Chef::Provider::Template::Content do
162
162
  2
163
163
  helpers.erb
164
164
  #{CHEF_SPEC_DATA}/cookbooks/openldap/templates/default/helpers.erb
165
- EOF
165
+ EOF
166
166
  end
167
167
 
168
168
  end
@@ -20,7 +20,7 @@ require "spec_helper"
20
20
 
21
21
  describe Chef::Provider::WindowsTask, :windows_only do
22
22
  let(:new_resource) { Chef::Resource::WindowsTask.new("sample_task") }
23
- let(:current_resource) { Chef::Resource::WindowsTask.new() }
23
+ let(:current_resource) { Chef::Resource::WindowsTask.new }
24
24
 
25
25
  let(:provider) do
26
26
  node = Chef::Node.new
@@ -553,60 +553,60 @@ describe Chef::ProviderResolver do
553
553
 
554
554
  PROVIDERS =
555
555
  {
556
- aix_user: [ Chef::Resource::User::AixUser, Chef::Provider::User::Aix ],
557
- apt_package: [ Chef::Resource::AptPackage, Chef::Provider::Package::Apt ],
558
- bash: [ Chef::Resource::Bash, Chef::Provider::Script ],
559
- bff_package: [ Chef::Resource::BffPackage, Chef::Provider::Package::Bff ],
560
- breakpoint: [ Chef::Resource::Breakpoint, Chef::Resource::Breakpoint.action_class ],
561
- chef_gem: [ Chef::Resource::ChefGem, Chef::Provider::Package::Rubygems ],
562
- cookbook_file: [ Chef::Resource::CookbookFile, Chef::Provider::CookbookFile ],
563
- csh: [ Chef::Resource::Csh, Chef::Provider::Script ],
564
- directory: [ Chef::Resource::Directory, Chef::Provider::Directory ],
565
- dpkg_package: [ Chef::Resource::DpkgPackage, Chef::Provider::Package::Dpkg ],
566
- dsc_script: [ Chef::Resource::DscScript, Chef::Provider::DscScript ],
567
- dscl_user: [ Chef::Resource::User::DsclUser, Chef::Provider::User::Dscl ],
568
- execute: [ Chef::Resource::Execute, Chef::Provider::Execute ],
569
- file: [ Chef::Resource::File, Chef::Provider::File ],
570
- gem_package: [ Chef::Resource::GemPackage, Chef::Provider::Package::Rubygems ],
571
- git: [ Chef::Resource::Git, Chef::Provider::Git ],
572
- group: [ Chef::Resource::Group, Chef::Provider::Group::Gpasswd ],
573
- homebrew_package: [ Chef::Resource::HomebrewPackage, Chef::Provider::Package::Homebrew ],
574
- http_request: [ Chef::Resource::HttpRequest, Chef::Provider::HttpRequest ],
575
- ifconfig: [ Chef::Resource::Ifconfig, Chef::Provider::Ifconfig ],
576
- ips_package: [ Chef::Resource::IpsPackage, Chef::Provider::Package::Ips ],
577
- link: [ Chef::Resource::Link, Chef::Provider::Link ],
578
- linux_user: [ Chef::Resource::User::LinuxUser, Chef::Provider::User::Linux ],
579
- log: [ Chef::Resource::Log, Chef::Provider::Log::ChefLog ],
580
- macports_package: [ Chef::Resource::MacportsPackage, Chef::Provider::Package::Macports ],
581
- mdadm: [ Chef::Resource::Mdadm, Chef::Provider::Mdadm ],
582
- mount: [ Chef::Resource::Mount, Chef::Provider::Mount::Mount ],
583
- pacman_package: [ Chef::Resource::PacmanPackage, Chef::Provider::Package::Pacman ],
584
- paludis_package: [ Chef::Resource::PaludisPackage, Chef::Provider::Package::Paludis ],
585
- perl: [ Chef::Resource::Perl, Chef::Provider::Script ],
586
- portage_package: [ Chef::Resource::PortagePackage, Chef::Provider::Package::Portage ],
587
- pw_user: [ Chef::Resource::User::PwUser, Chef::Provider::User::Pw ],
588
- python: [ Chef::Resource::Python, Chef::Provider::Script ],
589
- remote_directory: [ Chef::Resource::RemoteDirectory, Chef::Provider::RemoteDirectory ],
590
- route: [ Chef::Resource::Route, Chef::Provider::Route ],
591
- rpm_package: [ Chef::Resource::Package::RpmPackage, Chef::Provider::Package::Rpm ],
592
- ruby_block: [ Chef::Resource::RubyBlock, Chef::Provider::RubyBlock ],
593
- ruby: [ Chef::Resource::Ruby, Chef::Provider::Script ],
594
- script: [ Chef::Resource::Script, Chef::Provider::Script ],
595
- smartos_package: [ Chef::Resource::SmartosPackage, Chef::Provider::Package::SmartOS ],
596
- solaris_package: [ Chef::Resource::SolarisPackage, Chef::Provider::Package::Solaris ],
597
- solaris_user: [ Chef::Resource::User::SolarisUser, Chef::Provider::User::Solaris ],
598
- subversion: [ Chef::Resource::Subversion, Chef::Provider::Subversion ],
599
- template: [ Chef::Resource::Template, Chef::Provider::Template ],
556
+ aix_user: [ Chef::Resource::User::AixUser, Chef::Provider::User::Aix ],
557
+ apt_package: [ Chef::Resource::AptPackage, Chef::Provider::Package::Apt ],
558
+ bash: [ Chef::Resource::Bash, Chef::Provider::Script ],
559
+ bff_package: [ Chef::Resource::BffPackage, Chef::Provider::Package::Bff ],
560
+ breakpoint: [ Chef::Resource::Breakpoint, Chef::Resource::Breakpoint.action_class ],
561
+ chef_gem: [ Chef::Resource::ChefGem, Chef::Provider::Package::Rubygems ],
562
+ cookbook_file: [ Chef::Resource::CookbookFile, Chef::Provider::CookbookFile ],
563
+ csh: [ Chef::Resource::Csh, Chef::Provider::Script ],
564
+ directory: [ Chef::Resource::Directory, Chef::Provider::Directory ],
565
+ dpkg_package: [ Chef::Resource::DpkgPackage, Chef::Provider::Package::Dpkg ],
566
+ dsc_script: [ Chef::Resource::DscScript, Chef::Provider::DscScript ],
567
+ dscl_user: [ Chef::Resource::User::DsclUser, Chef::Provider::User::Dscl ],
568
+ execute: [ Chef::Resource::Execute, Chef::Provider::Execute ],
569
+ file: [ Chef::Resource::File, Chef::Provider::File ],
570
+ gem_package: [ Chef::Resource::GemPackage, Chef::Provider::Package::Rubygems ],
571
+ git: [ Chef::Resource::Git, Chef::Provider::Git ],
572
+ group: [ Chef::Resource::Group, Chef::Provider::Group::Gpasswd ],
573
+ homebrew_package: [ Chef::Resource::HomebrewPackage, Chef::Provider::Package::Homebrew ],
574
+ http_request: [ Chef::Resource::HttpRequest, Chef::Provider::HttpRequest ],
575
+ ifconfig: [ Chef::Resource::Ifconfig, Chef::Provider::Ifconfig ],
576
+ ips_package: [ Chef::Resource::IpsPackage, Chef::Provider::Package::Ips ],
577
+ link: [ Chef::Resource::Link, Chef::Provider::Link ],
578
+ linux_user: [ Chef::Resource::User::LinuxUser, Chef::Provider::User::Linux ],
579
+ log: [ Chef::Resource::Log, Chef::Provider::Log::ChefLog ],
580
+ macports_package: [ Chef::Resource::MacportsPackage, Chef::Provider::Package::Macports ],
581
+ mdadm: [ Chef::Resource::Mdadm, Chef::Provider::Mdadm ],
582
+ mount: [ Chef::Resource::Mount, Chef::Provider::Mount::Mount ],
583
+ pacman_package: [ Chef::Resource::PacmanPackage, Chef::Provider::Package::Pacman ],
584
+ paludis_package: [ Chef::Resource::PaludisPackage, Chef::Provider::Package::Paludis ],
585
+ perl: [ Chef::Resource::Perl, Chef::Provider::Script ],
586
+ portage_package: [ Chef::Resource::PortagePackage, Chef::Provider::Package::Portage ],
587
+ pw_user: [ Chef::Resource::User::PwUser, Chef::Provider::User::Pw ],
588
+ python: [ Chef::Resource::Python, Chef::Provider::Script ],
589
+ remote_directory: [ Chef::Resource::RemoteDirectory, Chef::Provider::RemoteDirectory ],
590
+ route: [ Chef::Resource::Route, Chef::Provider::Route ],
591
+ rpm_package: [ Chef::Resource::Package::RpmPackage, Chef::Provider::Package::Rpm ],
592
+ ruby_block: [ Chef::Resource::RubyBlock, Chef::Provider::RubyBlock ],
593
+ ruby: [ Chef::Resource::Ruby, Chef::Provider::Script ],
594
+ script: [ Chef::Resource::Script, Chef::Provider::Script ],
595
+ smartos_package: [ Chef::Resource::SmartosPackage, Chef::Provider::Package::SmartOS ],
596
+ solaris_package: [ Chef::Resource::SolarisPackage, Chef::Provider::Package::Solaris ],
597
+ solaris_user: [ Chef::Resource::User::SolarisUser, Chef::Provider::User::Solaris ],
598
+ subversion: [ Chef::Resource::Subversion, Chef::Provider::Subversion ],
599
+ template: [ Chef::Resource::Template, Chef::Provider::Template ],
600
600
  whyrun_safe_ruby_block: [ Chef::Resource::WhyrunSafeRubyBlock, Chef::Provider::WhyrunSafeRubyBlock ],
601
- windows_package: [ Chef::Resource::WindowsPackage, Chef::Provider::Package::Windows ],
602
- windows_service: [ Chef::Resource::WindowsService, Chef::Provider::Service::Windows ],
603
- windows_user: [ Chef::Resource::User::WindowsUser, Chef::Provider::User::Windows ],
604
- yum_package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
601
+ windows_package: [ Chef::Resource::WindowsPackage, Chef::Provider::Package::Windows ],
602
+ windows_service: [ Chef::Resource::WindowsService, Chef::Provider::Service::Windows ],
603
+ windows_user: [ Chef::Resource::User::WindowsUser, Chef::Provider::User::Windows ],
604
+ yum_package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
605
605
 
606
606
  "linux" => {
607
607
  "debian" => {
608
608
  ifconfig: [ Chef::Resource::Ifconfig, Chef::Provider::Ifconfig::Debian ],
609
- package: [ Chef::Resource::AptPackage, Chef::Provider::Package::Apt ],
609
+ package: [ Chef::Resource::AptPackage, Chef::Provider::Package::Apt ],
610
610
  # service: [ Chef::Resource::DebianService, Chef::Provider::Service::Debian ],
611
611
 
612
612
  "debian" => {
@@ -672,7 +672,7 @@ describe Chef::ProviderResolver do
672
672
  "opensuse" => {
673
673
  # service: [ Chef::Resource::RedhatService, Chef::Provider::Service::Redhat ],
674
674
  package: [ Chef::Resource::ZypperPackage, Chef::Provider::Package::Zypper ],
675
- group: [ Chef::Resource::Group, Chef::Provider::Group::Usermod ],
675
+ group: [ Chef::Resource::Group, Chef::Provider::Group::Usermod ],
676
676
  "12.3" => {
677
677
  },
678
678
  "12.2" => {
@@ -683,7 +683,7 @@ describe Chef::ProviderResolver do
683
683
 
684
684
  "gentoo" => {
685
685
  # TODO should be Chef::Resource::PortagePackage
686
- package: [ Chef::Resource::Package, Chef::Provider::Package::Portage ],
686
+ package: [ Chef::Resource::Package, Chef::Provider::Package::Portage ],
687
687
  portage_package: [ Chef::Resource::PortagePackage, Chef::Provider::Package::Portage ],
688
688
  # service: [ Chef::Resource::GentooService, Chef::Provider::Service::Gentoo ],
689
689
 
@@ -695,21 +695,21 @@ describe Chef::ProviderResolver do
695
695
 
696
696
  "rhel" => {
697
697
  # service: [ Chef::Resource::SystemdService, Chef::Provider::Service::Systemd ],
698
- package: [ Chef::Resource::DnfPackage, Chef::Provider::Package::Dnf ],
698
+ package: [ Chef::Resource::DnfPackage, Chef::Provider::Package::Dnf ],
699
699
  ifconfig: [ Chef::Resource::Ifconfig, Chef::Provider::Ifconfig::Redhat ],
700
700
 
701
701
  %w{amazon xcp xenserver ibm_powerkvm cloudlinux parallels} => {
702
702
  "3.1.4" => {
703
- package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
703
+ package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
704
704
  # service: [ Chef::Resource::RedhatService, Chef::Provider::Service::Redhat ],
705
705
  },
706
706
  },
707
707
  %w{redhat centos scientific oracle} => {
708
708
  "7.0" => {
709
- package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
709
+ package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
710
710
  },
711
711
  "6.0" => {
712
- package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
712
+ package: [ Chef::Resource::YumPackage, Chef::Provider::Package::Yum ],
713
713
  # service: [ Chef::Resource::RedhatService, Chef::Provider::Service::Redhat ],
714
714
  },
715
715
  },
@@ -727,7 +727,7 @@ describe Chef::ProviderResolver do
727
727
  "freebsd" => {
728
728
  "freebsd" => {
729
729
  group: [ Chef::Resource::Group, Chef::Provider::Group::Pw ],
730
- user: [ Chef::Resource::User::PwUser, Chef::Provider::User::Pw ],
730
+ user: [ Chef::Resource::User::PwUser, Chef::Provider::User::Pw ],
731
731
 
732
732
  "freebsd" => {
733
733
  "10.3" => {
@@ -738,10 +738,10 @@ describe Chef::ProviderResolver do
738
738
 
739
739
  "darwin" => {
740
740
  %w{mac_os_x mac_os_x_server} => {
741
- group: [ Chef::Resource::Group, Chef::Provider::Group::Dscl ],
741
+ group: [ Chef::Resource::Group, Chef::Provider::Group::Dscl ],
742
742
  package: [ Chef::Resource::HomebrewPackage, Chef::Provider::Package::Homebrew ],
743
743
  osx_profile: [ Chef::Resource::OsxProfile, Chef::Provider::OsxProfile],
744
- user: [ Chef::Resource::User::DsclUser, Chef::Provider::User::Dscl ],
744
+ user: [ Chef::Resource::User::DsclUser, Chef::Provider::User::Dscl ],
745
745
 
746
746
  "mac_os_x" => {
747
747
  "10.9.2" => {
@@ -751,17 +751,17 @@ describe Chef::ProviderResolver do
751
751
  },
752
752
 
753
753
  "windows" => {
754
- batch: [ Chef::Resource::Batch, Chef::Provider::Batch ],
755
- dsc_script: [ Chef::Resource::DscScript, Chef::Provider::DscScript ],
756
- windows_env: [ Chef::Resource::WindowsEnv, Chef::Provider::WindowsEnv ],
757
- group: [ Chef::Resource::Group, Chef::Provider::Group::Windows ],
758
- mount: [ Chef::Resource::Mount, Chef::Provider::Mount::Windows ],
759
- package: [ Chef::Resource::WindowsPackage, Chef::Provider::Package::Windows ],
754
+ batch: [ Chef::Resource::Batch, Chef::Provider::Batch ],
755
+ dsc_script: [ Chef::Resource::DscScript, Chef::Provider::DscScript ],
756
+ windows_env: [ Chef::Resource::WindowsEnv, Chef::Provider::WindowsEnv ],
757
+ group: [ Chef::Resource::Group, Chef::Provider::Group::Windows ],
758
+ mount: [ Chef::Resource::Mount, Chef::Provider::Mount::Windows ],
759
+ package: [ Chef::Resource::WindowsPackage, Chef::Provider::Package::Windows ],
760
760
  powershell_script: [ Chef::Resource::PowershellScript, Chef::Provider::PowershellScript ],
761
- service: [ Chef::Resource::WindowsService, Chef::Provider::Service::Windows ],
762
- user: [ Chef::Resource::User::WindowsUser, Chef::Provider::User::Windows ],
763
- windows_package: [ Chef::Resource::WindowsPackage, Chef::Provider::Package::Windows ],
764
- windows_service: [ Chef::Resource::WindowsService, Chef::Provider::Service::Windows ],
761
+ service: [ Chef::Resource::WindowsService, Chef::Provider::Service::Windows ],
762
+ user: [ Chef::Resource::User::WindowsUser, Chef::Provider::User::Windows ],
763
+ windows_package: [ Chef::Resource::WindowsPackage, Chef::Provider::Package::Windows ],
764
+ windows_service: [ Chef::Resource::WindowsService, Chef::Provider::Service::Windows ],
765
765
 
766
766
  "windows" => {
767
767
  %w{mswin mingw32 windows} => {
@@ -822,15 +822,15 @@ describe Chef::ProviderResolver do
822
822
  },
823
823
 
824
824
  "solaris2" => {
825
- group: [ Chef::Resource::Group, Chef::Provider::Group::Usermod ],
826
- ips_package: [ Chef::Resource::IpsPackage, Chef::Provider::Package::Ips ],
827
- package: [ Chef::Resource::SolarisPackage, Chef::Provider::Package::Solaris ],
828
- mount: [ Chef::Resource::Mount, Chef::Provider::Mount::Solaris ],
825
+ group: [ Chef::Resource::Group, Chef::Provider::Group::Usermod ],
826
+ ips_package: [ Chef::Resource::IpsPackage, Chef::Provider::Package::Ips ],
827
+ package: [ Chef::Resource::SolarisPackage, Chef::Provider::Package::Solaris ],
828
+ mount: [ Chef::Resource::Mount, Chef::Provider::Mount::Solaris ],
829
829
  solaris_package: [ Chef::Resource::SolarisPackage, Chef::Provider::Package::Solaris ],
830
830
 
831
831
  "smartos" => {
832
832
  smartos_package: [ Chef::Resource::SmartosPackage, Chef::Provider::Package::SmartOS ],
833
- package: [ Chef::Resource::SmartosPackage, Chef::Provider::Package::SmartOS ],
833
+ package: [ Chef::Resource::SmartosPackage, Chef::Provider::Package::SmartOS ],
834
834
 
835
835
  "smartos" => {
836
836
  "3.1.4" => {
@@ -892,7 +892,7 @@ describe Chef::ProviderResolver do
892
892
  def self.create_provider_tests(providers, test, expected, filter)
893
893
  expected = expected.merge(providers.select { |key, value| key.is_a?(Symbol) })
894
894
  providers.each do |key, value|
895
- if !key.is_a?(Symbol)
895
+ unless key.is_a?(Symbol)
896
896
  next_test = test.merge({ filter => key })
897
897
  next_filter =
898
898
  case filter
@@ -911,7 +911,7 @@ describe Chef::ProviderResolver do
911
911
  end
912
912
  end
913
913
  # If there is no filter, we're as deep as we need to go
914
- if !filter
914
+ unless filter
915
915
  on_platform test.delete(:platform), test do
916
916
  expect_providers(expected)
917
917
  end
@@ -24,8 +24,7 @@ class NoWhyrunDemonstrator < Chef::Provider
24
24
  false
25
25
  end
26
26
 
27
- def load_current_resource
28
- end
27
+ def load_current_resource; end
29
28
 
30
29
  def action_foo
31
30
  @system_state_altered = true
@@ -39,8 +38,7 @@ class ConvergeActionDemonstrator < Chef::Provider
39
38
  true
40
39
  end
41
40
 
42
- def load_current_resource
43
- end
41
+ def load_current_resource; end
44
42
 
45
43
  def action_foo
46
44
  converge_by("running a state changing action") do
@@ -94,7 +94,7 @@ describe Chef::Recipe do
94
94
  end
95
95
  end
96
96
 
97
- expect(run_context.resource_collection.map { |r| r.name }).to eql(%w{monkey dog cat})
97
+ expect(run_context.resource_collection.map(&:name)).to eql(%w{monkey dog cat})
98
98
  end
99
99
 
100
100
  it "should return the new resource after creating it" do
@@ -115,7 +115,7 @@ describe Chef::Recipe do
115
115
  node.automatic[:platform_version] = "123"
116
116
  res = recipe.laughter "timmy"
117
117
  expect(res.name).to eql("timmy")
118
- res.kind_of?(ShaunTheSheep)
118
+ res.is_a?(ShaunTheSheep)
119
119
  end
120
120
 
121
121
  it "locate a resource for all platforms" do
@@ -124,7 +124,7 @@ describe Chef::Recipe do
124
124
  YourMom.provides :love_and_caring
125
125
  res = recipe.love_and_caring "mommy"
126
126
  expect(res.name).to eql("mommy")
127
- res.kind_of?(YourMom)
127
+ res.is_a?(YourMom)
128
128
  end
129
129
 
130
130
  describe "when there is more than one resource that resolves on a node" do
@@ -390,7 +390,7 @@ describe Chef::Recipe do
390
390
  zen_master "gnome" do
391
391
  peace = true
392
392
  end
393
- CODE
393
+ CODE
394
394
  expect { recipe.instance_eval(code) }.not_to raise_error
395
395
  expect(recipe.resources(zen_master: "gnome").name).to eql("gnome")
396
396
  end
@@ -22,7 +22,7 @@ describe Chef::Resource::Batch do
22
22
  let(:node) { Chef::Node.new }
23
23
 
24
24
  before(:each) do
25
- node.default["kernel"] = Hash.new
25
+ node.default["kernel"] = {}
26
26
  node.default["kernel"][:machine] = :x86_64.to_s
27
27
  node.automatic[:os] = "windows"
28
28
 
@@ -53,7 +53,7 @@ describe Chef::Resource::ChefGem, "gem_binary" do
53
53
  end
54
54
 
55
55
  it "sets the gem_binary based on computing it from RbConfig" do
56
- expect(resource.gem_binary).to eql("#{RbConfig::CONFIG['bindir']}/gem")
56
+ expect(resource.gem_binary).to eql("#{RbConfig::CONFIG["bindir"]}/gem")
57
57
  end
58
58
 
59
59
  it "sets compile_time to false by default" do
@@ -35,7 +35,7 @@ describe Chef::Resource::ChocolateyConfig do
35
35
  </features>
36
36
  <apiKeys />
37
37
  </chocolatey>
38
- CONFIG
38
+ CONFIG
39
39
  end
40
40
 
41
41
  # we save off the ENV and set ALLUSERSPROFILE so these specs will work on *nix and non-C drive Windows installs
@@ -35,7 +35,7 @@ describe Chef::Resource::ChocolateySource do
35
35
  </features>
36
36
  <apiKeys />
37
37
  </chocolatey>
38
- CONFIG
38
+ CONFIG
39
39
  end
40
40
 
41
41
  # we save off the ENV and set ALLUSERSPROFILE so these specs will work on *nix and non-C drive Windows installs
@@ -38,7 +38,7 @@ describe Chef::Resource::Directory do
38
38
  it "accepts a string as the path" do
39
39
  expect { resource.path "/tmp" }.not_to raise_error
40
40
  expect(resource.path).to eql("/tmp")
41
- expect { resource.path Hash.new }.to raise_error(ArgumentError)
41
+ expect { resource.path({}) }.to raise_error(ArgumentError)
42
42
  end
43
43
 
44
44
  it "allows you to have specify whether the action is recursive with true/false" do
@@ -64,7 +64,7 @@ describe Chef::Resource::DnfPackage, "flush_cache" do
64
64
  end
65
65
 
66
66
  it "allows you to set the flush timing with an array" do
67
- flush_array = [ :before, :after ]
67
+ flush_array = %i{before after}
68
68
  flush_hash = { before: true, after: true }
69
69
  resource.flush_cache(flush_array)
70
70
  expect(resource.flush_cache).to eq(flush_hash)
@@ -41,7 +41,7 @@ describe Chef::Resource::DscResource do
41
41
  end
42
42
 
43
43
  it "has an ed_actions property with only the `:run` and `:nothing` properties" do
44
- expect(dsc_test_resource.allowed_actions.to_set).to eq([:run, :nothing].to_set)
44
+ expect(dsc_test_resource.allowed_actions.to_set).to eq(%i{run nothing}.to_set)
45
45
  end
46
46
 
47
47
  it "allows the resource property to be set" do