chef 12.6.0 → 12.7.2

data/lib/chef/file_content_management/content_base.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/lib/chef/file_content_management/deploy.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,10 +16,10 @@
 # limitations under the License.
 #
 
-require 'chef/file_content_management/deploy/cp'
-require 'chef/file_content_management/deploy/mv_unix'
+require "chef/file_content_management/deploy/cp"
+require "chef/file_content_management/deploy/mv_unix"
 if Chef::Platform.windows?
-  require 'chef/file_content_management/deploy/mv_windows'
+  require "chef/file_content_management/deploy/mv_windows"
 end
 
 class Chef
@@ -35,4 +35,3 @@ class Chef
     end
   end
 end
-

data/lib/chef/file_content_management/deploy/cp.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/lib/chef/file_content_management/deploy/mv_unix.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -74,4 +74,3 @@ class Chef
     end
   end
 end
-

data/lib/chef/file_content_management/deploy/mv_windows.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -21,9 +21,9 @@
 # ACL information on the dst file.
 #
 
-require 'chef/platform/query_helpers'
+require "chef/platform/query_helpers"
 if Chef::Platform.windows?
-  require 'chef/win32/security'
+  require "chef/win32/security"
 end
 
 class Chef
@@ -96,10 +96,8 @@ class Chef
           dst_so.owner = dst_sd.owner
           dst_so.set_dacl(apply_dacl, dst_sd.dacl_inherits?) if dacl_present
           dst_so.set_sacl(apply_sacl, dst_sd.sacl_inherits?) if sacl_present
-
         end
       end
     end
   end
 end
-

data/lib/chef/file_content_management/tempfile.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -64,7 +64,7 @@ class Chef
       #
       def tempfile_basename
         basename = ::File.basename(@new_resource.name)
-        basename.insert 0, "." unless Chef::Platform.windows?  # dotfile if we're not on windows
+        basename.insert 0, "." unless Chef::Platform.windows? # dotfile if we're not on windows
         basename
       end
 

data/lib/chef/formatters/base.rb

@@ -1,7 +1,7 @@
 #
-# Author:: Tyler Cloke (<tyler@opscode.com>)
+# Author:: Tyler Cloke (<tyler@chef.io>)
 #
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Copyright:: Copyright 2012-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,11 +17,11 @@
 # limitations under the License.
 #
 
-require 'chef/event_dispatch/base'
-require 'chef/formatters/error_inspectors'
-require 'chef/formatters/error_descriptor'
-require 'chef/formatters/error_mapper'
-require 'chef/formatters/indentable_output_stream'
+require "chef/event_dispatch/base"
+require "chef/formatters/error_inspectors"
+require "chef/formatters/error_descriptor"
+require "chef/formatters/error_mapper"
+require "chef/formatters/indentable_output_stream"
 
 class Chef
 
@@ -212,7 +212,7 @@ class Chef
         file_load_failed(path, exception)
       end
 
-      def deprecation(message, location=caller(2..2)[0])
+      def deprecation(message, location = caller(2..2)[0])
         Chef::Log.deprecation("#{message} at #{location}")
       end
 
@@ -221,7 +221,6 @@ class Chef
       end
     end
 
-
     # == NullFormatter
     # Formatter that doesn't actually produce any output. You can use this to
     # disable the use of output formatters.

data/lib/chef/formatters/doc.rb

@@ -1,5 +1,5 @@
-require 'chef/formatters/base'
-require 'chef/config'
+require "chef/formatters/base"
+require "chef/config"
 
 class Chef
   module Formatters
@@ -43,6 +43,7 @@ class Chef
 
       def run_start(version)
         puts_line "Starting Chef Client, version #{version}"
+        puts_line "OpenSSL FIPS 140 mode enabled" if Chef::Config[:fips]
       end
 
       def total_resources
@@ -239,7 +240,7 @@ class Chef
       end
 
       # Called before action is executed on a resource.
-      def resource_action_start(resource, action, notification_type=nil, notifier=nil)
+      def resource_action_start(resource, action, notification_type = nil, notifier = nil)
         if resource.cookbook_name && resource.recipe_name
           resource_recipe = "#{resource.cookbook_name}::#{resource.recipe_name}"
         else
@@ -281,7 +282,7 @@ class Chef
 
       # Called when a resource has no converge actions, e.g., it was already correct.
       def resource_up_to_date(resource, action)
-        @up_to_date_resources+= 1
+        @up_to_date_resources += 1
         puts " (up to date)", :stream => resource
         unindent
       end
@@ -292,7 +293,6 @@ class Chef
       end
 
       def output_record(line)
-
       end
 
       # Called when a change has been made to a resource. May be called multiple
@@ -334,7 +334,7 @@ class Chef
 
       # Called before handlers run
       def handlers_start(handler_count)
-        puts ''
+        puts ""
         puts "Running handlers:"
         indent
       end
@@ -368,7 +368,7 @@ class Chef
         end
       end
 
-      def deprecation(message, location=caller(2..2)[0])
+      def deprecation(message, location = caller(2..2)[0])
         if Chef::Config[:treat_deprecation_warnings_as_errors]
           super
         end

data/lib/chef/formatters/error_descriptor.rb

@@ -1,7 +1,7 @@
 #
-# Author:: Tyler Cloke (<tyler@opscode.com>)
+# Author:: Tyler Cloke (<tyler@chef.io>)
 #
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Copyright:: Copyright 2012-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -31,7 +31,7 @@ class Chef
       end
 
       def section(heading, text)
-        @sections << {heading => (text or "")}
+        @sections << { heading => (text or "") }
       end
 
       def display(out)
@@ -48,8 +48,8 @@ class Chef
 
       def for_json()
         {
-          'title' => @title,
-          'sections' => @sections
+          "title" => @title,
+          "sections" => @sections,
         }
       end
 

data/lib/chef/formatters/error_inspectors.rb

@@ -1,9 +1,9 @@
-require 'chef/formatters/error_inspectors/node_load_error_inspector'
+require "chef/formatters/error_inspectors/node_load_error_inspector"
 require "chef/formatters/error_inspectors/registration_error_inspector"
-require 'chef/formatters/error_inspectors/compile_error_inspector'
-require 'chef/formatters/error_inspectors/resource_failure_inspector'
-require 'chef/formatters/error_inspectors/run_list_expansion_error_inspector'
-require 'chef/formatters/error_inspectors/cookbook_resolve_error_inspector'
+require "chef/formatters/error_inspectors/compile_error_inspector"
+require "chef/formatters/error_inspectors/resource_failure_inspector"
+require "chef/formatters/error_inspectors/run_list_expansion_error_inspector"
+require "chef/formatters/error_inspectors/cookbook_resolve_error_inspector"
 require "chef/formatters/error_inspectors/cookbook_sync_error_inspector"
 
 class Chef

data/lib/chef/formatters/error_inspectors/api_error_formatting.rb

@@ -1,6 +1,6 @@
 #--
-# Author:: Daniel DeLeo (<dan@opscode.com>)
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Author:: Daniel DeLeo (<dan@chef.io>)
+# Copyright:: Copyright 2012-2016, Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-require 'chef/http/authenticator'
+require "chef/http/authenticator"
 
 class Chef
   module Formatters
@@ -26,30 +26,66 @@ class Chef
       NETWORK_ERROR_CLASSES = [Errno::ECONNREFUSED, Timeout::Error, Errno::ETIMEDOUT, SocketError]
 
       def describe_network_errors(error_description)
-        error_description.section("Networking Error:",<<-E)
+        error_description.section("Networking Error:", <<-E)
 #{exception.message}
 
 Your chef_server_url may be misconfigured, or the network could be down.
 E
-        error_description.section("Relevant Config Settings:",<<-E)
+        error_description.section("Relevant Config Settings:", <<-E)
 chef_server_url  "#{server_url}"
 E
       end
 
+      def describe_eof_error(error_description)
+        error_description.section("Authentication Error:", <<-E)
+Received an EOF on transport socket.  This almost always indicates a network
+error external to chef-client.  Some causes include:
+
+  - Blocking ICMP Dest Unreachable (breaking Path MTU Discovery)
+  - IPsec or VPN tunnelling / TCP Encapsulation MTU issues
+  - Jumbo frames configured only on one side (breaking Path MTU)
+  - Jumbo frames configured on a LAN that does not support them
+  - Proxies or Load Balancers breaking large POSTs
+  - Broken TCP offload in network drivers/hardware
+
+Try sending large pings to the destination:
+
+   windows:  ping server.example.com -f -l 9999
+   unix:  ping server.example.com -s 9999
+
+Try sending large POSTs to the destination (any HTTP code returned is success):
+
+   e.g.:  curl http://server.example.com/`printf '%*s' 9999 '' | tr ' ' 'a'`
+
+Try disabling TCP Offload Engines (TOE) in your ethernet drivers.
+
+  windows:
+    Disable-NetAdapterChecksumOffload * -TcpIPv4 -UdpIPv4 -IpIPv4 -NoRestart
+    Disable-NetAdapterLso * -IPv4 -NoRestart
+    Set-NetAdapterAdvancedProperty * -DisplayName "Large Receive Offload (IPv4)" -DisplayValue Disabled –NoRestart
+    Restart-NetAdapter *
+  unix(bash):
+    for i in rx tx sg tso ufo gso gro lro rxvlan txvlan rxhash; do /sbin/ethtool -K eth0 $i off; done
+
+In some cases the underlying virtualization layer (Xen, VMware, KVM, Hyper-V, etc) may have
+broken virtual networking code.
+        E
+      end
+
       def describe_401_error(error_description)
         if clock_skew?
-          error_description.section("Authentication Error:",<<-E)
+          error_description.section("Authentication Error:", <<-E)
 Failed to authenticate to the chef server (http 401).
 The request failed because your clock has drifted by more than 15 minutes.
 Syncing your clock to an NTP Time source should resolve the issue.
 E
         else
-          error_description.section("Authentication Error:",<<-E)
+          error_description.section("Authentication Error:", <<-E)
 Failed to authenticate to the chef server (http 401).
 E
 
           error_description.section("Server Response:", format_rest_error)
-          error_description.section("Relevant Config Settings:",<<-E)
+          error_description.section("Relevant Config Settings:", <<-E)
 chef_server_url   "#{server_url}"
 node_name         "#{username}"
 client_key        "#{api_key}"
@@ -61,10 +97,10 @@ E
       end
 
       def describe_400_error(error_description)
-        error_description.section("Invalid Request Data:",<<-E)
+        error_description.section("Invalid Request Data:", <<-E)
 The data in your request was invalid (HTTP 400).
 E
-        error_description.section("Server Response:",format_rest_error)
+        error_description.section("Server Response:", format_rest_error)
       end
 
       def describe_406_error(error_description, response)
@@ -74,7 +110,7 @@ E
           min_server_version = version_header["min_version"]
           max_server_version = version_header["max_version"]
 
-          error_description.section("Incompatible server API version:",<<-E)
+          error_description.section("Incompatible server API version:", <<-E)
 This version of the API that this Chef request specified is not supported by the Chef server you sent this request to.
 The server supports a min API version of #{min_server_version} and a max API version of #{max_server_version}.
 Chef just made a request with an API version of #{client_api_version}.
@@ -86,18 +122,17 @@ E
       end
 
       def describe_500_error(error_description)
-        error_description.section("Unknown Server Error:",<<-E)
+        error_description.section("Unknown Server Error:", <<-E)
 The server had a fatal error attempting to load the node data.
 E
         error_description.section("Server Response:", format_rest_error)
       end
 
       def describe_503_error(error_description)
-        error_description.section("Server Unavailable","The Chef Server is temporarily unavailable")
+        error_description.section("Server Unavailable", "The Chef Server is temporarily unavailable")
         error_description.section("Server Response:", format_rest_error)
       end
 
-
       # Fallback for unexpected/uncommon http errors
       def describe_http_error(error_description)
         error_description.section("Unexpected API Request Failure:", format_rest_error)
@@ -106,7 +141,7 @@ E
       # Parses JSON from the error response sent by Chef Server and returns the
       # error message
       def format_rest_error
-        Array(Chef::JSONCompat.from_json(exception.response.body)["error"]).join('; ')
+        Array(Chef::JSONCompat.from_json(exception.response.body)["error"]).join("; ")
       rescue Exception
         safe_format_rest_error
       end

data/lib/chef/formatters/error_inspectors/compile_error_inspector.rb

@@ -1,6 +1,6 @@
 #--
-# Author:: Daniel DeLeo (<dan@opscode.com>)
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Author:: Daniel DeLeo (<dan@chef.io>)
+# Copyright:: Copyright 2012-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -40,7 +40,7 @@ class Chef
           error_description.section(exception.class.name, exception.message)
 
           if found_error_in_cookbooks?
-            traceback = filtered_bt.map {|line| "  #{line}"}.join("\n")
+            traceback = filtered_bt.map { |line| "  #{line}" }.join("\n")
             error_description.section("Cookbook Trace:", traceback)
             error_description.section("Relevant File Content:", context)
           end
@@ -74,7 +74,7 @@ class Chef
 
             MESSAGE
 
-            error_description.section("Additional information:", msg.gsub(/^ {6}/, ''))
+            error_description.section("Additional information:", msg.gsub(/^ {6}/, ""))
           end
         end
 
@@ -107,22 +107,22 @@ class Chef
 
         def culprit_backtrace_entry
           @culprit_backtrace_entry ||= begin
-             bt_entry = filtered_bt.first
-             Chef::Log.debug("Backtrace entry for compile error: '#{bt_entry}'")
-             bt_entry
+            bt_entry = filtered_bt.first
+            Chef::Log.debug("Backtrace entry for compile error: '#{bt_entry}'")
+            bt_entry
           end
         end
 
         def culprit_line
           @culprit_line ||= begin
-            line_number = culprit_backtrace_entry[/^(?:.\:)?[^:]+:([\d]+)/,1].to_i
+            line_number = culprit_backtrace_entry[/^(?:.\:)?[^:]+:([\d]+)/, 1].to_i
             Chef::Log.debug("Line number of compile error: '#{line_number}'")
             line_number
           end
         end
 
         def culprit_file
-          @culprit_file ||= culprit_backtrace_entry[/^((?:.\:)?[^:]+):([\d]+)/,1]
+          @culprit_file ||= culprit_backtrace_entry[/^((?:.\:)?[^:]+):([\d]+)/, 1]
         end
 
         def filtered_bt
@@ -136,8 +136,8 @@ class Chef
         def backtrace_lines_in_cookbooks
           @backtrace_lines_in_cookbooks ||=
             begin
-              filters = Array(Chef::Config.cookbook_path).map {|p| /^#{Regexp.escape(p)}/i }
-              r = exception.backtrace.select {|line| filters.any? {|filter| line =~ filter }}
+              filters = Array(Chef::Config.cookbook_path).map { |p| /^#{Regexp.escape(p)}/i }
+              r = exception.backtrace.select { |line| filters.any? { |filter| line =~ filter } }
               Chef::Log.debug("Filtered backtrace of compile error: #{r.join(",")}")
               r
             end