chef 12.6.0 → 12.7.2

Sign up to get free protection for your applications and to get access to all the features.
Files changed (1449) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +26 -19
  3. data/README.md +26 -23
  4. data/Rakefile +28 -17
  5. data/VERSION +1 -0
  6. data/acceptance/.gitignore +1 -0
  7. data/acceptance/.shared/kitchen_acceptance/.kitchen.digitalocean.yml +27 -0
  8. data/acceptance/.shared/kitchen_acceptance/.kitchen.ec2.yml +281 -0
  9. data/acceptance/.shared/kitchen_acceptance/.kitchen.vagrant.yml +49 -0
  10. data/acceptance/.shared/kitchen_acceptance/libraries/kitchen.rb +46 -0
  11. data/acceptance/.shared/kitchen_acceptance/metadata.rb +1 -0
  12. data/acceptance/Gemfile +11 -0
  13. data/acceptance/README.md +86 -0
  14. data/acceptance/basics/.acceptance/acceptance-cookbook/.gitignore +2 -0
  15. data/acceptance/basics/.acceptance/acceptance-cookbook/metadata.rb +3 -0
  16. data/acceptance/basics/.acceptance/acceptance-cookbook/recipes/destroy.rb +1 -0
  17. data/acceptance/basics/.acceptance/acceptance-cookbook/recipes/provision.rb +1 -0
  18. data/acceptance/basics/.acceptance/acceptance-cookbook/recipes/verify.rb +1 -0
  19. data/acceptance/basics/.kitchen.yml +4 -0
  20. data/acceptance/basics/test/integration/chef-current-install/serverspec/chef_client_spec.rb +19 -0
  21. data/acceptance/basics/test/integration/chef-current-install/serverspec/spec_helper.rb +6 -0
  22. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/.gitignore +2 -0
  23. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/libraries/cookbook_kitchen.rb +43 -0
  24. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/libraries/top_cookbooks.rb +21 -0
  25. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/metadata.rb +3 -0
  26. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/recipes/destroy.rb +1 -0
  27. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/recipes/provision.rb +1 -0
  28. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/recipes/verify.rb +1 -0
  29. data/acceptance/top-cookbooks/.gitignore +1 -0
  30. data/acceptance/top-cookbooks/.kitchen.git.yml +10 -0
  31. data/acceptance/top-cookbooks/.kitchen.learn-the-basics-rhel.yml +4 -0
  32. data/acceptance/top-cookbooks/.kitchen.learn-the-basics-ubuntu.yml +4 -0
  33. data/acceptance/top-cookbooks/.kitchen.learn-the-basics-windows.yml +4 -0
  34. data/acceptance/trivial/.acceptance/acceptance-cookbook/.gitignore +2 -0
  35. data/acceptance/trivial/.acceptance/acceptance-cookbook/metadata.rb +2 -0
  36. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/destroy.rb +1 -0
  37. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/provision.rb +1 -0
  38. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/verify.rb +1 -0
  39. data/acceptance/trivial/.kitchen.yml +7 -0
  40. data/acceptance/trivial/test/integration/chef-current-install/inspec/chef_client_spec.rb +5 -0
  41. data/acceptance/windows-service/.acceptance/acceptance-cookbook/.gitignore +2 -0
  42. data/acceptance/windows-service/.acceptance/acceptance-cookbook/metadata.rb +2 -0
  43. data/acceptance/windows-service/.acceptance/acceptance-cookbook/recipes/destroy.rb +1 -0
  44. data/acceptance/windows-service/.acceptance/acceptance-cookbook/recipes/provision.rb +1 -0
  45. data/acceptance/windows-service/.acceptance/acceptance-cookbook/recipes/verify.rb +1 -0
  46. data/acceptance/windows-service/.kitchen.yml +7 -0
  47. data/acceptance/windows-service/test/integration/chef-windows-service/inspec/chef_windows_service_spec.rb +58 -0
  48. data/bin/chef-apply +3 -3
  49. data/bin/chef-client +5 -5
  50. data/bin/chef-shell +1 -1
  51. data/bin/chef-solo +4 -4
  52. data/bin/knife +4 -5
  53. data/chef-windows.gemspec +5 -2
  54. data/chef.gemspec +13 -13
  55. data/distro/common/html/_static/basic.css +1 -1
  56. data/distro/common/html/_static/doctools.js +1 -1
  57. data/distro/common/html/_static/searchtools.js +1 -1
  58. data/distro/common/html/_static/websupport.js +1 -1
  59. data/lib-backcompat/chef/chef_fs/file_system/acl_entry.rb +5 -0
  60. data/lib-backcompat/chef/chef_fs/file_system/chef_repository_file_system_root_dir.rb +5 -0
  61. data/lib-backcompat/chef/chef_fs/file_system/chef_server_root_dir.rb +5 -0
  62. data/lib/chef.rb +17 -17
  63. data/lib/chef/api_client.rb +31 -30
  64. data/lib/chef/api_client/registration.rb +34 -10
  65. data/lib/chef/api_client_v1.rb +36 -36
  66. data/lib/chef/application.rb +32 -23
  67. data/lib/chef/application/apply.rb +20 -20
  68. data/lib/chef/application/client.rb +63 -43
  69. data/lib/chef/application/knife.rb +21 -15
  70. data/lib/chef/application/solo.rb +52 -41
  71. data/lib/chef/application/windows_service.rb +25 -25
  72. data/lib/chef/application/windows_service_manager.rb +22 -22
  73. data/lib/chef/applications.rb +4 -4
  74. data/lib/chef/audit/audit_event_proxy.rb +3 -3
  75. data/lib/chef/audit/audit_reporter.rb +8 -10
  76. data/lib/chef/audit/control_group_data.rb +9 -10
  77. data/lib/chef/audit/logger.rb +3 -3
  78. data/lib/chef/audit/rspec_formatter.rb +2 -2
  79. data/lib/chef/audit/runner.rb +15 -14
  80. data/lib/chef/chef_class.rb +10 -7
  81. data/lib/chef/chef_fs.rb +51 -1
  82. data/lib/chef/chef_fs/chef_fs_data_store.rb +320 -125
  83. data/lib/chef/chef_fs/command_line.rb +8 -8
  84. data/lib/chef/chef_fs/config.rb +52 -23
  85. data/lib/chef/chef_fs/data_handler/acl_data_handler.rb +10 -10
  86. data/lib/chef/chef_fs/data_handler/client_data_handler.rb +12 -12
  87. data/lib/chef/chef_fs/data_handler/container_data_handler.rb +6 -6
  88. data/lib/chef/chef_fs/data_handler/cookbook_data_handler.rb +15 -15
  89. data/lib/chef/chef_fs/data_handler/data_bag_item_data_handler.rb +11 -11
  90. data/lib/chef/chef_fs/data_handler/data_handler_base.rb +8 -8
  91. data/lib/chef/chef_fs/data_handler/environment_data_handler.rb +14 -14
  92. data/lib/chef/chef_fs/data_handler/group_data_handler.rb +18 -18
  93. data/lib/chef/chef_fs/data_handler/node_data_handler.rb +14 -14
  94. data/lib/chef/chef_fs/data_handler/organization_data_handler.rb +9 -9
  95. data/lib/chef/chef_fs/data_handler/organization_invites_data_handler.rb +2 -2
  96. data/lib/chef/chef_fs/data_handler/organization_members_data_handler.rb +2 -2
  97. data/lib/chef/chef_fs/data_handler/policy_data_handler.rb +30 -3
  98. data/lib/chef/chef_fs/data_handler/policy_group_data_handler.rb +27 -0
  99. data/lib/chef/chef_fs/data_handler/role_data_handler.rb +16 -16
  100. data/lib/chef/chef_fs/data_handler/user_data_handler.rb +12 -12
  101. data/lib/chef/chef_fs/file_pattern.rb +25 -25
  102. data/lib/chef/chef_fs/file_system.rb +10 -10
  103. data/lib/chef/chef_fs/file_system/already_exists_error.rb +3 -6
  104. data/lib/chef/chef_fs/file_system/base_fs_dir.rb +4 -4
  105. data/lib/chef/chef_fs/file_system/base_fs_object.rb +8 -8
  106. data/lib/chef/chef_fs/file_system/chef_server/acl_dir.rb +65 -0
  107. data/lib/chef/chef_fs/file_system/chef_server/acl_entry.rb +60 -0
  108. data/lib/chef/chef_fs/file_system/chef_server/acls_dir.rb +75 -0
  109. data/lib/chef/chef_fs/file_system/chef_server/chef_server_root_dir.rb +196 -0
  110. data/lib/chef/chef_fs/file_system/{chef_repository_file_system_acls_dir.rb → chef_server/cookbook_artifact_dir.rb} +13 -12
  111. data/lib/chef/chef_fs/file_system/chef_server/cookbook_artifacts_dir.rb +102 -0
  112. data/lib/chef/chef_fs/file_system/chef_server/cookbook_dir.rb +222 -0
  113. data/lib/chef/chef_fs/file_system/chef_server/cookbook_file.rb +84 -0
  114. data/lib/chef/chef_fs/file_system/chef_server/cookbook_subdir.rb +61 -0
  115. data/lib/chef/chef_fs/file_system/chef_server/cookbooks_acl_dir.rb +42 -0
  116. data/lib/chef/chef_fs/file_system/chef_server/cookbooks_dir.rb +102 -0
  117. data/lib/chef/chef_fs/file_system/chef_server/data_bag_dir.rb +71 -0
  118. data/lib/chef/chef_fs/file_system/chef_server/data_bags_dir.rb +69 -0
  119. data/lib/chef/chef_fs/file_system/chef_server/environments_dir.rb +57 -0
  120. data/lib/chef/chef_fs/file_system/chef_server/nodes_dir.rb +53 -0
  121. data/lib/chef/chef_fs/file_system/chef_server/org_entry.rb +31 -0
  122. data/lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb +61 -0
  123. data/lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb +60 -0
  124. data/lib/chef/chef_fs/file_system/chef_server/policies_acl_dir.rb +41 -0
  125. data/lib/chef/chef_fs/file_system/chef_server/policies_dir.rb +160 -0
  126. data/lib/chef/chef_fs/file_system/chef_server/policy_group_entry.rb +137 -0
  127. data/lib/chef/chef_fs/file_system/chef_server/policy_groups_dir.rb +43 -0
  128. data/lib/chef/chef_fs/file_system/chef_server/policy_revision_entry.rb +34 -0
  129. data/lib/chef/chef_fs/file_system/chef_server/rest_list_dir.rb +178 -0
  130. data/lib/chef/chef_fs/file_system/chef_server/rest_list_entry.rb +187 -0
  131. data/lib/chef/chef_fs/file_system/chef_server/versioned_cookbook_dir.rb +45 -0
  132. data/lib/chef/chef_fs/file_system/chef_server/versioned_cookbooks_dir.rb +107 -0
  133. data/lib/chef/chef_fs/file_system/cookbook_frozen_error.rb +3 -6
  134. data/lib/chef/chef_fs/file_system/default_environment_cannot_be_modified_error.rb +3 -7
  135. data/lib/chef/chef_fs/file_system/file_system_error.rb +14 -3
  136. data/lib/chef/chef_fs/file_system/memory/memory_dir.rb +53 -0
  137. data/lib/chef/chef_fs/file_system/memory/memory_file.rb +20 -0
  138. data/lib/chef/chef_fs/file_system/memory/memory_root.rb +23 -0
  139. data/lib/chef/chef_fs/file_system/multiplexed_dir.rb +2 -2
  140. data/lib/chef/chef_fs/file_system/must_delete_recursively_error.rb +3 -6
  141. data/lib/chef/chef_fs/file_system/nonexistent_fs_object.rb +4 -4
  142. data/lib/chef/chef_fs/file_system/not_found_error.rb +3 -6
  143. data/lib/chef/chef_fs/file_system/operation_failed_error.rb +5 -5
  144. data/lib/chef/chef_fs/file_system/operation_not_allowed_error.rb +16 -18
  145. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_acls_dir.rb +39 -0
  146. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbook_artifact_dir.rb +41 -0
  147. data/lib/chef/chef_fs/file_system/{chef_repository_file_system_policies_dir.rb → repository/chef_repository_file_system_cookbook_artifacts_dir.rb} +9 -13
  148. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbook_dir.rb +95 -0
  149. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbook_entry.rb +82 -0
  150. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbooks_dir.rb +84 -0
  151. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_data_bags_dir.rb +38 -0
  152. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_entry.rb +83 -0
  153. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_policies_dir.rb +38 -0
  154. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb +210 -0
  155. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_versioned_cookbook_dir.rb +42 -0
  156. data/lib/chef/chef_fs/file_system/{chef_repository_file_system_data_bags_dir.rb → repository/chef_repository_file_system_versioned_cookbooks_dir.rb} +9 -11
  157. data/lib/chef/chef_fs/file_system/repository/file_system_entry.rb +117 -0
  158. data/lib/chef/chef_fs/file_system/{file_system_root_dir.rb → repository/file_system_root_dir.rb} +8 -6
  159. data/lib/chef/chef_fs/knife.rb +16 -16
  160. data/lib/chef/chef_fs/parallelizer.rb +3 -3
  161. data/lib/chef/chef_fs/parallelizer/flatten_enumerable.rb +1 -1
  162. data/lib/chef/chef_fs/parallelizer/parallel_enumerable.rb +3 -3
  163. data/lib/chef/chef_fs/path_utils.rb +11 -10
  164. data/lib/chef/client.rb +80 -71
  165. data/lib/chef/config.rb +10 -10
  166. data/lib/chef/config_fetcher.rb +12 -4
  167. data/lib/chef/constants.rb +2 -1
  168. data/lib/chef/cookbook/chefignore.rb +4 -5
  169. data/lib/chef/cookbook/cookbook_collection.rb +6 -6
  170. data/lib/chef/cookbook/cookbook_version_loader.rb +15 -15
  171. data/lib/chef/cookbook/file_system_file_vendor.rb +4 -4
  172. data/lib/chef/cookbook/file_vendor.rb +3 -4
  173. data/lib/chef/cookbook/metadata.rb +108 -107
  174. data/lib/chef/cookbook/remote_file_vendor.rb +7 -7
  175. data/lib/chef/cookbook/synchronizer.rb +11 -10
  176. data/lib/chef/cookbook/syntax_check.rb +14 -14
  177. data/lib/chef/cookbook_loader.rb +14 -14
  178. data/lib/chef/cookbook_manifest.rb +16 -15
  179. data/lib/chef/cookbook_site_streaming_uploader.rb +22 -22
  180. data/lib/chef/cookbook_uploader.rb +22 -21
  181. data/lib/chef/cookbook_version.rb +87 -87
  182. data/lib/chef/daemon.rb +6 -6
  183. data/lib/chef/data_bag.rb +32 -26
  184. data/lib/chef/data_bag_item.rb +43 -40
  185. data/lib/chef/delayed_evaluator.rb +1 -1
  186. data/lib/chef/deprecation/mixin/template.rb +4 -4
  187. data/lib/chef/deprecation/provider/cookbook_file.rb +2 -3
  188. data/lib/chef/deprecation/provider/file.rb +10 -10
  189. data/lib/chef/deprecation/provider/remote_directory.rb +5 -5
  190. data/lib/chef/deprecation/provider/remote_file.rb +3 -3
  191. data/lib/chef/deprecation/provider/template.rb +3 -3
  192. data/lib/chef/deprecation/warnings.rb +2 -2
  193. data/lib/chef/digester.rb +6 -6
  194. data/lib/chef/dsl.rb +6 -6
  195. data/lib/chef/dsl/audit.rb +4 -4
  196. data/lib/chef/dsl/chef_provisioning.rb +5 -5
  197. data/lib/chef/dsl/cheffish.rb +5 -5
  198. data/lib/chef/dsl/data_query.rb +10 -10
  199. data/lib/chef/dsl/declare_resource.rb +8 -8
  200. data/lib/chef/dsl/definitions.rb +1 -2
  201. data/lib/chef/dsl/include_attribute.rb +4 -6
  202. data/lib/chef/dsl/include_recipe.rb +4 -4
  203. data/lib/chef/dsl/platform_introspection.rb +8 -14
  204. data/lib/chef/dsl/powershell.rb +3 -3
  205. data/lib/chef/dsl/reboot_pending.rb +12 -13
  206. data/lib/chef/dsl/recipe.rb +20 -20
  207. data/lib/chef/dsl/registry_helper.rb +7 -3
  208. data/lib/chef/dsl/resources.rb +6 -5
  209. data/lib/chef/encrypted_data_bag_item.rb +10 -10
  210. data/lib/chef/encrypted_data_bag_item/assertions.rb +4 -4
  211. data/lib/chef/encrypted_data_bag_item/check_encrypted.rb +3 -3
  212. data/lib/chef/encrypted_data_bag_item/decryption_failure.rb +2 -2
  213. data/lib/chef/encrypted_data_bag_item/decryptor.rb +16 -14
  214. data/lib/chef/encrypted_data_bag_item/encrypted_data_bag_item_assertions.rb +1 -1
  215. data/lib/chef/encrypted_data_bag_item/encryption_failure.rb +1 -1
  216. data/lib/chef/encrypted_data_bag_item/encryptor.rb +20 -20
  217. data/lib/chef/encrypted_data_bag_item/unacceptable_encrypted_data_bag_item_format.rb +2 -2
  218. data/lib/chef/encrypted_data_bag_item/unsupported_cipher.rb +2 -2
  219. data/lib/chef/encrypted_data_bag_item/unsupported_encrypted_data_bag_item_format.rb +2 -2
  220. data/lib/chef/environment.rb +41 -34
  221. data/lib/chef/event_dispatch/base.rb +2 -2
  222. data/lib/chef/event_dispatch/dispatcher.rb +2 -2
  223. data/lib/chef/event_dispatch/dsl.rb +6 -5
  224. data/lib/chef/event_loggers/base.rb +3 -3
  225. data/lib/chef/event_loggers/windows_eventlog.rb +11 -11
  226. data/lib/chef/exceptions.rb +23 -34
  227. data/lib/chef/file_access_control.rb +6 -6
  228. data/lib/chef/file_access_control/unix.rb +5 -5
  229. data/lib/chef/file_access_control/windows.rb +5 -5
  230. data/lib/chef/file_cache.rb +21 -21
  231. data/lib/chef/file_content_management/content_base.rb +2 -2
  232. data/lib/chef/file_content_management/deploy.rb +5 -6
  233. data/lib/chef/file_content_management/deploy/cp.rb +2 -2
  234. data/lib/chef/file_content_management/deploy/mv_unix.rb +2 -3
  235. data/lib/chef/file_content_management/deploy/mv_windows.rb +4 -6
  236. data/lib/chef/file_content_management/tempfile.rb +3 -3
  237. data/lib/chef/formatters/base.rb +8 -9
  238. data/lib/chef/formatters/doc.rb +7 -7
  239. data/lib/chef/formatters/error_descriptor.rb +5 -5
  240. data/lib/chef/formatters/error_inspectors.rb +5 -5
  241. data/lib/chef/formatters/error_inspectors/api_error_formatting.rb +50 -15
  242. data/lib/chef/formatters/error_inspectors/compile_error_inspector.rb +11 -11
  243. data/lib/chef/formatters/error_inspectors/cookbook_resolve_error_inspector.rb +8 -8
  244. data/lib/chef/formatters/error_inspectors/cookbook_sync_error_inspector.rb +8 -6
  245. data/lib/chef/formatters/error_inspectors/node_load_error_inspector.rb +14 -13
  246. data/lib/chef/formatters/error_inspectors/registration_error_inspector.rb +19 -17
  247. data/lib/chef/formatters/error_inspectors/resource_failure_inspector.rb +8 -11
  248. data/lib/chef/formatters/error_inspectors/run_list_expansion_error_inspector.rb +15 -14
  249. data/lib/chef/formatters/error_mapper.rb +2 -2
  250. data/lib/chef/formatters/indentable_output_stream.rb +5 -5
  251. data/lib/chef/formatters/minimal.rb +7 -9
  252. data/lib/chef/guard_interpreter.rb +3 -3
  253. data/lib/chef/guard_interpreter/default_guard_interpreter.rb +3 -4
  254. data/lib/chef/guard_interpreter/resource_guard_interpreter.rb +9 -9
  255. data/lib/chef/handler.rb +4 -4
  256. data/lib/chef/handler/error_report.rb +4 -4
  257. data/lib/chef/handler/json_file.rb +5 -5
  258. data/lib/chef/http.rb +32 -35
  259. data/lib/chef/http/auth_credentials.rb +12 -12
  260. data/lib/chef/http/authenticator.rb +17 -12
  261. data/lib/chef/http/basic_client.rb +20 -20
  262. data/lib/chef/http/cookie_jar.rb +7 -7
  263. data/lib/chef/http/cookie_manager.rb +8 -8
  264. data/lib/chef/http/decompressor.rb +7 -9
  265. data/lib/chef/http/http_request.rb +31 -32
  266. data/lib/chef/http/json_input.rb +9 -9
  267. data/lib/chef/http/json_output.rb +9 -9
  268. data/lib/chef/http/json_to_model_output.rb +4 -4
  269. data/lib/chef/http/remote_request_id.rb +6 -6
  270. data/lib/chef/http/simple.rb +23 -5
  271. data/lib/chef/http/simple_json.rb +43 -0
  272. data/lib/chef/http/socketless_chef_zero_client.rb +56 -57
  273. data/lib/chef/http/ssl_policies.rb +9 -9
  274. data/lib/chef/http/validate_content_length.rb +12 -12
  275. data/lib/chef/json_compat.rb +6 -6
  276. data/lib/chef/key.rb +44 -42
  277. data/lib/chef/knife.rb +47 -44
  278. data/lib/chef/knife/bootstrap.rb +32 -32
  279. data/lib/chef/knife/bootstrap/chef_vault_handler.rb +16 -23
  280. data/lib/chef/knife/bootstrap/client_builder.rb +15 -13
  281. data/lib/chef/knife/bootstrap/templates/chef-full.erb +1 -1
  282. data/lib/chef/knife/client_bulk_delete.rb +5 -5
  283. data/lib/chef/knife/client_create.rb +5 -5
  284. data/lib/chef/knife/client_delete.rb +6 -6
  285. data/lib/chef/knife/client_edit.rb +5 -5
  286. data/lib/chef/knife/client_key_create.rb +6 -6
  287. data/lib/chef/knife/client_key_delete.rb +6 -6
  288. data/lib/chef/knife/client_key_edit.rb +8 -9
  289. data/lib/chef/knife/client_key_list.rb +5 -5
  290. data/lib/chef/knife/client_key_show.rb +5 -5
  291. data/lib/chef/knife/client_list.rb +5 -5
  292. data/lib/chef/knife/client_reregister.rb +5 -5
  293. data/lib/chef/knife/client_show.rb +5 -5
  294. data/lib/chef/knife/configure.rb +14 -14
  295. data/lib/chef/knife/configure_client.rb +6 -6
  296. data/lib/chef/knife/cookbook_bulk_delete.rb +9 -10
  297. data/lib/chef/knife/cookbook_create.rb +12 -12
  298. data/lib/chef/knife/cookbook_delete.rb +10 -10
  299. data/lib/chef/knife/cookbook_download.rb +8 -10
  300. data/lib/chef/knife/cookbook_list.rb +5 -5
  301. data/lib/chef/knife/cookbook_metadata.rb +8 -8
  302. data/lib/chef/knife/cookbook_metadata_from_file.rb +5 -5
  303. data/lib/chef/knife/cookbook_show.rb +14 -18
  304. data/lib/chef/knife/cookbook_site_download.rb +22 -22
  305. data/lib/chef/knife/cookbook_site_install.rb +10 -10
  306. data/lib/chef/knife/cookbook_site_list.rb +6 -10
  307. data/lib/chef/knife/cookbook_site_search.rb +5 -10
  308. data/lib/chef/knife/cookbook_site_share.rb +17 -18
  309. data/lib/chef/knife/cookbook_site_show.rb +7 -12
  310. data/lib/chef/knife/cookbook_site_unshare.rb +6 -6
  311. data/lib/chef/knife/cookbook_site_vendor.rb +5 -5
  312. data/lib/chef/knife/cookbook_test.rb +6 -7
  313. data/lib/chef/knife/cookbook_upload.rb +19 -20
  314. data/lib/chef/knife/core/bootstrap_context.rb +25 -21
  315. data/lib/chef/knife/core/cookbook_scm_repo.rb +11 -12
  316. data/lib/chef/knife/core/custom_manifest_loader.rb +2 -2
  317. data/lib/chef/knife/core/gem_glob_loader.rb +11 -11
  318. data/lib/chef/knife/core/generic_presenter.rb +33 -34
  319. data/lib/chef/knife/core/hashed_command_loader.rb +6 -6
  320. data/lib/chef/knife/core/node_editor.rb +59 -38
  321. data/lib/chef/knife/core/node_presenter.rb +13 -14
  322. data/lib/chef/knife/core/object_loader.rb +9 -9
  323. data/lib/chef/knife/core/status_presenter.rb +17 -17
  324. data/lib/chef/knife/core/subcommand_loader.rb +19 -20
  325. data/lib/chef/knife/core/text_formatter.rb +13 -14
  326. data/lib/chef/knife/core/ui.rb +17 -18
  327. data/lib/chef/knife/data_bag_create.rb +11 -10
  328. data/lib/chef/knife/data_bag_delete.rb +6 -8
  329. data/lib/chef/knife/data_bag_edit.rb +8 -11
  330. data/lib/chef/knife/data_bag_from_file.rb +12 -11
  331. data/lib/chef/knife/data_bag_list.rb +4 -8
  332. data/lib/chef/knife/data_bag_secret_options.rb +6 -6
  333. data/lib/chef/knife/data_bag_show.rb +31 -31
  334. data/lib/chef/knife/delete.rb +6 -7
  335. data/lib/chef/knife/deps.rb +18 -18
  336. data/lib/chef/knife/diff.rb +8 -9
  337. data/lib/chef/knife/download.rb +11 -12
  338. data/lib/chef/knife/edit.rb +5 -6
  339. data/lib/chef/knife/environment_compare.rb +23 -23
  340. data/lib/chef/knife/environment_create.rb +5 -5
  341. data/lib/chef/knife/environment_delete.rb +5 -5
  342. data/lib/chef/knife/environment_edit.rb +5 -5
  343. data/lib/chef/knife/environment_from_file.rb +4 -5
  344. data/lib/chef/knife/environment_list.rb +5 -5
  345. data/lib/chef/knife/environment_show.rb +5 -5
  346. data/lib/chef/knife/exec.rb +7 -7
  347. data/lib/chef/knife/help.rb +7 -9
  348. data/lib/chef/knife/index_rebuild.rb +4 -5
  349. data/lib/chef/knife/key_create.rb +5 -5
  350. data/lib/chef/knife/key_create_base.rb +1 -1
  351. data/lib/chef/knife/key_delete.rb +2 -2
  352. data/lib/chef/knife/key_edit.rb +5 -5
  353. data/lib/chef/knife/key_edit_base.rb +1 -1
  354. data/lib/chef/knife/key_list.rb +12 -12
  355. data/lib/chef/knife/key_list_base.rb +1 -1
  356. data/lib/chef/knife/key_show.rb +4 -4
  357. data/lib/chef/knife/list.rb +14 -13
  358. data/lib/chef/knife/node_bulk_delete.rb +6 -12
  359. data/lib/chef/knife/node_create.rb +5 -8
  360. data/lib/chef/knife/node_delete.rb +5 -6
  361. data/lib/chef/knife/node_edit.rb +6 -8
  362. data/lib/chef/knife/node_environment_set.rb +4 -4
  363. data/lib/chef/knife/node_from_file.rb +10 -10
  364. data/lib/chef/knife/node_list.rb +5 -7
  365. data/lib/chef/knife/node_run_list_add.rb +8 -8
  366. data/lib/chef/knife/node_run_list_remove.rb +8 -8
  367. data/lib/chef/knife/node_run_list_set.rb +6 -6
  368. data/lib/chef/knife/node_show.rb +6 -7
  369. data/lib/chef/knife/osc_user_create.rb +5 -5
  370. data/lib/chef/knife/osc_user_delete.rb +5 -5
  371. data/lib/chef/knife/osc_user_edit.rb +5 -5
  372. data/lib/chef/knife/osc_user_list.rb +5 -5
  373. data/lib/chef/knife/osc_user_reregister.rb +5 -5
  374. data/lib/chef/knife/osc_user_show.rb +5 -5
  375. data/lib/chef/knife/raw.rb +18 -17
  376. data/lib/chef/knife/recipe_list.rb +4 -4
  377. data/lib/chef/knife/rehash.rb +9 -9
  378. data/lib/chef/knife/role_bulk_delete.rb +5 -10
  379. data/lib/chef/knife/role_create.rb +5 -7
  380. data/lib/chef/knife/role_delete.rb +5 -6
  381. data/lib/chef/knife/role_edit.rb +5 -8
  382. data/lib/chef/knife/role_env_run_list_add.rb +9 -9
  383. data/lib/chef/knife/role_env_run_list_clear.rb +4 -4
  384. data/lib/chef/knife/role_env_run_list_remove.rb +13 -13
  385. data/lib/chef/knife/role_env_run_list_replace.rb +6 -6
  386. data/lib/chef/knife/role_env_run_list_set.rb +6 -6
  387. data/lib/chef/knife/role_from_file.rb +6 -11
  388. data/lib/chef/knife/role_list.rb +5 -6
  389. data/lib/chef/knife/role_run_list_add.rb +9 -9
  390. data/lib/chef/knife/role_run_list_clear.rb +4 -4
  391. data/lib/chef/knife/role_run_list_remove.rb +13 -13
  392. data/lib/chef/knife/role_run_list_replace.rb +6 -6
  393. data/lib/chef/knife/role_run_list_set.rb +6 -6
  394. data/lib/chef/knife/role_show.rb +5 -8
  395. data/lib/chef/knife/search.rb +11 -11
  396. data/lib/chef/knife/serve.rb +10 -10
  397. data/lib/chef/knife/show.rb +4 -4
  398. data/lib/chef/knife/ssh.rb +34 -34
  399. data/lib/chef/knife/ssl_check.rb +12 -11
  400. data/lib/chef/knife/ssl_fetch.rb +13 -15
  401. data/lib/chef/knife/status.rb +10 -10
  402. data/lib/chef/knife/tag_create.rb +5 -5
  403. data/lib/chef/knife/tag_delete.rb +5 -5
  404. data/lib/chef/knife/tag_list.rb +5 -5
  405. data/lib/chef/knife/upload.rb +10 -11
  406. data/lib/chef/knife/user_create.rb +6 -8
  407. data/lib/chef/knife/user_delete.rb +6 -7
  408. data/lib/chef/knife/user_edit.rb +6 -7
  409. data/lib/chef/knife/user_key_create.rb +7 -7
  410. data/lib/chef/knife/user_key_delete.rb +6 -6
  411. data/lib/chef/knife/user_key_edit.rb +8 -9
  412. data/lib/chef/knife/user_key_list.rb +5 -5
  413. data/lib/chef/knife/user_key_show.rb +5 -5
  414. data/lib/chef/knife/user_list.rb +5 -5
  415. data/lib/chef/knife/user_reregister.rb +6 -7
  416. data/lib/chef/knife/user_show.rb +6 -6
  417. data/lib/chef/knife/xargs.rb +22 -23
  418. data/lib/chef/local_mode.rb +13 -11
  419. data/lib/chef/log.rb +10 -10
  420. data/lib/chef/log/syslog.rb +5 -6
  421. data/lib/chef/log/winevt.rb +12 -12
  422. data/lib/chef/mash.rb +6 -5
  423. data/lib/chef/mixin/api_version_request_handling.rb +1 -1
  424. data/lib/chef/mixin/checksum.rb +4 -4
  425. data/lib/chef/mixin/command.rb +13 -13
  426. data/lib/chef/mixin/command/unix.rb +7 -7
  427. data/lib/chef/mixin/command/windows.rb +6 -7
  428. data/lib/chef/mixin/convert_to_class_name.rb +11 -11
  429. data/lib/chef/mixin/create_path.rb +3 -3
  430. data/lib/chef/mixin/deep_merge.rb +3 -3
  431. data/lib/chef/mixin/deprecation.rb +24 -25
  432. data/lib/chef/mixin/descendants_tracker.rb +2 -3
  433. data/lib/chef/mixin/enforce_ownership_and_permissions.rb +3 -3
  434. data/lib/chef/mixin/file_class.rb +9 -11
  435. data/lib/chef/mixin/from_file.rb +3 -3
  436. data/lib/chef/mixin/get_source_from_package.rb +2 -3
  437. data/lib/chef/mixin/homebrew_user.rb +6 -6
  438. data/lib/chef/mixin/language.rb +5 -5
  439. data/lib/chef/mixin/language_include_attribute.rb +4 -5
  440. data/lib/chef/mixin/language_include_recipe.rb +4 -5
  441. data/lib/chef/mixin/params_validate.rb +38 -18
  442. data/lib/chef/mixin/path_sanity.rb +7 -7
  443. data/lib/chef/mixin/powershell_out.rb +5 -5
  444. data/lib/chef/mixin/powershell_type_coercions.rb +12 -10
  445. data/lib/chef/mixin/properties.rb +8 -8
  446. data/lib/chef/mixin/provides.rb +2 -2
  447. data/lib/chef/mixin/proxified_socket.rb +4 -4
  448. data/lib/chef/mixin/recipe_definition_dsl_core.rb +4 -4
  449. data/lib/chef/mixin/securable.rb +24 -27
  450. data/lib/chef/mixin/shell_out.rb +10 -10
  451. data/lib/chef/mixin/subclass_directive.rb +2 -2
  452. data/lib/chef/mixin/template.rb +8 -9
  453. data/lib/chef/mixin/unformatter.rb +1 -1
  454. data/lib/chef/mixin/uris.rb +2 -3
  455. data/lib/chef/mixin/which.rb +3 -3
  456. data/lib/chef/mixin/why_run.rb +6 -7
  457. data/lib/chef/mixin/wide_string.rb +7 -7
  458. data/lib/chef/mixin/windows_architecture_helper.rb +9 -10
  459. data/lib/chef/mixin/windows_env_helper.rb +10 -11
  460. data/lib/chef/mixin/xml_escape.rb +13 -13
  461. data/lib/chef/mixins.rb +13 -14
  462. data/lib/chef/monkey_patches/net-ssh-multi.rb +6 -6
  463. data/lib/chef/monkey_patches/net_http.rb +2 -2
  464. data/lib/chef/monkey_patches/webrick-utils.rb +6 -6
  465. data/lib/chef/monkey_patches/win32/registry.rb +6 -6
  466. data/lib/chef/monologger.rb +2 -4
  467. data/lib/chef/node.rb +66 -60
  468. data/lib/chef/node/attribute.rb +289 -289
  469. data/lib/chef/node/attribute_collections.rb +8 -8
  470. data/lib/chef/node/immutable_collections.rb +3 -3
  471. data/lib/chef/node_map.rb +11 -11
  472. data/lib/chef/null_logger.rb +3 -3
  473. data/lib/chef/org.rb +31 -30
  474. data/lib/chef/platform.rb +4 -4
  475. data/lib/chef/platform/handler_map.rb +2 -2
  476. data/lib/chef/platform/priority_map.rb +2 -2
  477. data/lib/chef/platform/provider_handler_map.rb +3 -3
  478. data/lib/chef/platform/provider_mapping.rb +33 -33
  479. data/lib/chef/platform/provider_priority_map.rb +2 -2
  480. data/lib/chef/platform/query_helpers.rb +10 -11
  481. data/lib/chef/platform/rebooter.rb +11 -11
  482. data/lib/chef/platform/resource_handler_map.rb +3 -3
  483. data/lib/chef/platform/resource_priority_map.rb +2 -2
  484. data/lib/chef/platform/service_helpers.rb +5 -5
  485. data/lib/chef/policy_builder.rb +5 -5
  486. data/lib/chef/policy_builder/dynamic.rb +10 -11
  487. data/lib/chef/policy_builder/expand_node_object.rb +24 -19
  488. data/lib/chef/policy_builder/policyfile.rb +13 -14
  489. data/lib/chef/property.rb +115 -49
  490. data/lib/chef/provider.rb +43 -43
  491. data/lib/chef/provider/apt_update.rb +79 -0
  492. data/lib/chef/provider/batch.rb +6 -6
  493. data/lib/chef/provider/breakpoint.rb +1 -1
  494. data/lib/chef/provider/cookbook_file.rb +5 -5
  495. data/lib/chef/provider/cookbook_file/content.rb +4 -4
  496. data/lib/chef/provider/cron.rb +8 -8
  497. data/lib/chef/provider/cron/aix.rb +1 -1
  498. data/lib/chef/provider/cron/solaris.rb +1 -1
  499. data/lib/chef/provider/cron/unix.rb +7 -7
  500. data/lib/chef/provider/deploy.rb +7 -8
  501. data/lib/chef/provider/deploy/revision.rb +9 -9
  502. data/lib/chef/provider/deploy/timestamped.rb +1 -1
  503. data/lib/chef/provider/directory.rb +8 -8
  504. data/lib/chef/provider/dsc_resource.rb +33 -27
  505. data/lib/chef/provider/dsc_script.rb +17 -17
  506. data/lib/chef/provider/env.rb +8 -8
  507. data/lib/chef/provider/env/windows.rb +3 -3
  508. data/lib/chef/provider/erl_call.rb +5 -5
  509. data/lib/chef/provider/execute.rb +8 -8
  510. data/lib/chef/provider/file.rb +24 -24
  511. data/lib/chef/provider/file/content.rb +4 -4
  512. data/lib/chef/provider/git.rb +33 -35
  513. data/lib/chef/provider/group.rb +7 -7
  514. data/lib/chef/provider/group/aix.rb +6 -6
  515. data/lib/chef/provider/group/dscl.rb +11 -11
  516. data/lib/chef/provider/group/gpasswd.rb +3 -3
  517. data/lib/chef/provider/group/groupadd.rb +8 -8
  518. data/lib/chef/provider/group/groupmod.rb +3 -3
  519. data/lib/chef/provider/group/pw.rb +2 -2
  520. data/lib/chef/provider/group/suse.rb +5 -5
  521. data/lib/chef/provider/group/usermod.rb +8 -8
  522. data/lib/chef/provider/group/windows.rb +5 -5
  523. data/lib/chef/provider/http_request.rb +15 -15
  524. data/lib/chef/provider/ifconfig.rb +15 -14
  525. data/lib/chef/provider/ifconfig/aix.rb +5 -4
  526. data/lib/chef/provider/ifconfig/debian.rb +6 -6
  527. data/lib/chef/provider/ifconfig/redhat.rb +3 -3
  528. data/lib/chef/provider/link.rb +13 -13
  529. data/lib/chef/provider/log.rb +1 -1
  530. data/lib/chef/provider/lwrp_base.rb +8 -8
  531. data/lib/chef/provider/mdadm.rb +4 -4
  532. data/lib/chef/provider/mount.rb +13 -13
  533. data/lib/chef/provider/mount/aix.rb +14 -14
  534. data/lib/chef/provider/mount/mount.rb +18 -18
  535. data/lib/chef/provider/mount/solaris.rb +30 -30
  536. data/lib/chef/provider/mount/windows.rb +4 -4
  537. data/lib/chef/provider/ohai.rb +2 -2
  538. data/lib/chef/provider/osx_profile.rb +256 -0
  539. data/lib/chef/provider/package.rb +19 -19
  540. data/lib/chef/provider/package/aix.rb +8 -9
  541. data/lib/chef/provider/package/apt.rb +12 -12
  542. data/lib/chef/provider/package/chocolatey.rb +277 -0
  543. data/lib/chef/provider/package/dpkg.rb +7 -7
  544. data/lib/chef/provider/package/easy_install.rb +14 -15
  545. data/lib/chef/provider/package/freebsd/base.rb +7 -7
  546. data/lib/chef/provider/package/freebsd/pkg.rb +8 -8
  547. data/lib/chef/provider/package/freebsd/pkgng.rb +6 -6
  548. data/lib/chef/provider/package/freebsd/port.rb +4 -4
  549. data/lib/chef/provider/package/homebrew.rb +16 -16
  550. data/lib/chef/provider/package/ips.rb +8 -8
  551. data/lib/chef/provider/package/macports.rb +1 -0
  552. data/lib/chef/provider/package/openbsd.rb +13 -13
  553. data/lib/chef/provider/package/pacman.rb +6 -9
  554. data/lib/chef/provider/package/paludis.rb +7 -10
  555. data/lib/chef/provider/package/portage.rb +10 -13
  556. data/lib/chef/provider/package/rpm.rb +7 -8
  557. data/lib/chef/provider/package/rubygems.rb +64 -64
  558. data/lib/chef/provider/package/smartos.rb +7 -10
  559. data/lib/chef/provider/package/solaris.rb +6 -11
  560. data/lib/chef/provider/package/windows.rb +38 -29
  561. data/lib/chef/provider/package/windows/exe.rb +9 -21
  562. data/lib/chef/provider/package/windows/msi.rb +12 -12
  563. data/lib/chef/provider/package/windows/registry_uninstall_entry.rb +7 -7
  564. data/lib/chef/provider/package/yum-dump.py +1 -1
  565. data/lib/chef/provider/package/yum.rb +43 -44
  566. data/lib/chef/provider/package/zypper.rb +57 -47
  567. data/lib/chef/provider/powershell_script.rb +14 -14
  568. data/lib/chef/provider/reboot.rb +5 -5
  569. data/lib/chef/provider/registry_key.rb +16 -16
  570. data/lib/chef/provider/remote_directory.rb +15 -15
  571. data/lib/chef/provider/remote_file.rb +5 -5
  572. data/lib/chef/provider/remote_file/cache_control_data.rb +11 -12
  573. data/lib/chef/provider/remote_file/content.rb +11 -11
  574. data/lib/chef/provider/remote_file/fetcher.rb +2 -2
  575. data/lib/chef/provider/remote_file/ftp.rb +11 -11
  576. data/lib/chef/provider/remote_file/http.rb +9 -9
  577. data/lib/chef/provider/remote_file/local_file.rb +5 -5
  578. data/lib/chef/provider/remote_file/network_file.rb +4 -4
  579. data/lib/chef/provider/route.rb +188 -188
  580. data/lib/chef/provider/ruby_block.rb +3 -3
  581. data/lib/chef/provider/script.rb +5 -5
  582. data/lib/chef/provider/service.rb +30 -30
  583. data/lib/chef/provider/service/aix.rb +4 -4
  584. data/lib/chef/provider/service/aixinit.rb +12 -12
  585. data/lib/chef/provider/service/arch.rb +5 -5
  586. data/lib/chef/provider/service/debian.rb +12 -13
  587. data/lib/chef/provider/service/freebsd.rb +7 -7
  588. data/lib/chef/provider/service/gentoo.rb +5 -5
  589. data/lib/chef/provider/service/init.rb +4 -4
  590. data/lib/chef/provider/service/insserv.rb +4 -4
  591. data/lib/chef/provider/service/invokercd.rb +3 -3
  592. data/lib/chef/provider/service/macosx.rb +19 -19
  593. data/lib/chef/provider/service/openbsd.rb +14 -14
  594. data/lib/chef/provider/service/redhat.rb +6 -6
  595. data/lib/chef/provider/service/simple.rb +10 -9
  596. data/lib/chef/provider/service/solaris.rb +8 -8
  597. data/lib/chef/provider/service/systemd.rb +4 -4
  598. data/lib/chef/provider/service/upstart.rb +8 -8
  599. data/lib/chef/provider/service/windows.rb +32 -78
  600. data/lib/chef/provider/subversion.rb +13 -13
  601. data/lib/chef/provider/template.rb +7 -7
  602. data/lib/chef/provider/template/content.rb +4 -4
  603. data/lib/chef/provider/template_finder.rb +2 -1
  604. data/lib/chef/provider/user.rb +9 -10
  605. data/lib/chef/provider/user/aix.rb +4 -3
  606. data/lib/chef/provider/user/dscl.rb +39 -40
  607. data/lib/chef/provider/user/pw.rb +9 -9
  608. data/lib/chef/provider/user/solaris.rb +9 -9
  609. data/lib/chef/provider/user/useradd.rb +9 -9
  610. data/lib/chef/provider/user/windows.rb +13 -13
  611. data/lib/chef/provider/whyrun_safe_ruby_block.rb +1 -1
  612. data/lib/chef/provider/windows_script.rb +5 -5
  613. data/lib/chef/provider_resolver.rb +3 -3
  614. data/lib/chef/providers.rb +113 -110
  615. data/lib/chef/recipe.rb +13 -14
  616. data/lib/chef/request_id.rb +4 -4
  617. data/lib/chef/resource.rb +103 -93
  618. data/lib/chef/resource/action_class.rb +3 -3
  619. data/lib/chef/resource/apt_package.rb +6 -17
  620. data/lib/chef/{shell/shell_rest.rb → resource/apt_update.rb} +14 -9
  621. data/lib/chef/resource/bash.rb +5 -5
  622. data/lib/chef/resource/batch.rb +4 -4
  623. data/lib/chef/resource/bff_package.rb +3 -3
  624. data/lib/chef/resource/breakpoint.rb +3 -4
  625. data/lib/chef/resource/chef_gem.rb +9 -25
  626. data/lib/chef/resource/chocolatey_package.rb +39 -0
  627. data/lib/chef/resource/conditional.rb +8 -8
  628. data/lib/chef/resource/conditional_action_not_nothing.rb +1 -1
  629. data/lib/chef/resource/cookbook_file.rb +10 -10
  630. data/lib/chef/resource/cron.rb +33 -33
  631. data/lib/chef/resource/csh.rb +5 -5
  632. data/lib/chef/resource/deploy.rb +76 -76
  633. data/lib/chef/resource/deploy_revision.rb +1 -1
  634. data/lib/chef/resource/directory.rb +12 -12
  635. data/lib/chef/resource/dpkg_package.rb +5 -6
  636. data/lib/chef/resource/dsc_resource.rb +121 -120
  637. data/lib/chef/resource/dsc_script.rb +25 -25
  638. data/lib/chef/resource/easy_install_package.rb +6 -25
  639. data/lib/chef/resource/env.rb +9 -9
  640. data/lib/chef/resource/erl_call.rb +15 -15
  641. data/lib/chef/resource/execute.rb +28 -28
  642. data/lib/chef/resource/file.rb +20 -87
  643. data/lib/chef/resource/file/verification.rb +11 -11
  644. data/lib/chef/resource/freebsd_package.rb +10 -9
  645. data/lib/chef/resource/gem_package.rb +8 -23
  646. data/lib/chef/resource/git.rb +4 -4
  647. data/lib/chef/resource/group.rb +18 -19
  648. data/lib/chef/resource/homebrew_package.rb +7 -18
  649. data/lib/chef/resource/http_request.rb +12 -12
  650. data/lib/chef/resource/ifconfig.rb +28 -28
  651. data/lib/chef/resource/ips_package.rb +5 -16
  652. data/lib/chef/resource/ksh.rb +3 -3
  653. data/lib/chef/resource/link.rb +18 -17
  654. data/lib/chef/resource/log.rb +9 -9
  655. data/lib/chef/resource/lwrp_base.rb +10 -10
  656. data/lib/chef/resource/macosx_service.rb +7 -7
  657. data/lib/chef/resource/macports_package.rb +3 -2
  658. data/lib/chef/resource/mdadm.rb +18 -19
  659. data/lib/chef/resource/mount.rb +34 -34
  660. data/lib/chef/resource/ohai.rb +7 -7
  661. data/lib/chef/resource/openbsd_package.rb +7 -6
  662. data/lib/chef/resource/osx_profile.rb +74 -0
  663. data/lib/chef/resource/package.rb +15 -69
  664. data/lib/chef/resource/pacman_package.rb +3 -2
  665. data/lib/chef/resource/paludis_package.rb +5 -7
  666. data/lib/chef/resource/perl.rb +5 -5
  667. data/lib/chef/resource/portage_package.rb +5 -4
  668. data/lib/chef/resource/powershell_script.rb +7 -7
  669. data/lib/chef/resource/python.rb +5 -5
  670. data/lib/chef/resource/reboot.rb +6 -6
  671. data/lib/chef/resource/registry_key.rb +15 -15
  672. data/lib/chef/resource/remote_directory.rb +23 -24
  673. data/lib/chef/resource/remote_file.rb +21 -21
  674. data/lib/chef/resource/resource_notification.rb +2 -2
  675. data/lib/chef/resource/route.rb +26 -26
  676. data/lib/chef/resource/rpm_package.rb +5 -15
  677. data/lib/chef/resource/ruby.rb +5 -5
  678. data/lib/chef/resource/ruby_block.rb +8 -8
  679. data/lib/chef/resource/scm.rb +36 -37
  680. data/lib/chef/resource/script.rb +13 -13
  681. data/lib/chef/resource/service.rb +32 -32
  682. data/lib/chef/resource/smartos_package.rb +4 -3
  683. data/lib/chef/resource/solaris_package.rb +4 -3
  684. data/lib/chef/resource/subversion.rb +6 -6
  685. data/lib/chef/resource/template.rb +19 -19
  686. data/lib/chef/resource/timestamped_deploy.rb +1 -1
  687. data/lib/chef/resource/user.rb +31 -31
  688. data/lib/chef/resource/whyrun_safe_ruby_block.rb +1 -1
  689. data/lib/chef/resource/windows_package.rb +21 -66
  690. data/lib/chef/resource/windows_script.rb +8 -8
  691. data/lib/chef/resource/windows_service.rb +9 -9
  692. data/lib/chef/resource/yum_package.rb +18 -42
  693. data/lib/chef/resource/zypper_package.rb +3 -2
  694. data/lib/chef/resource_builder.rb +4 -4
  695. data/lib/chef/resource_collection.rb +11 -11
  696. data/lib/chef/resource_collection/resource_collection_serialization.rb +5 -5
  697. data/lib/chef/resource_collection/resource_list.rb +6 -6
  698. data/lib/chef/resource_collection/resource_set.rb +6 -6
  699. data/lib/chef/resource_collection/stepable_iterator.rb +4 -4
  700. data/lib/chef/resource_definition.rb +7 -7
  701. data/lib/chef/resource_definition_list.rb +5 -5
  702. data/lib/chef/resource_reporter.rb +14 -15
  703. data/lib/chef/resource_resolver.rb +4 -5
  704. data/lib/chef/resources.rb +71 -68
  705. data/lib/chef/rest.rb +23 -23
  706. data/lib/chef/role.rb +49 -43
  707. data/lib/chef/run_context.rb +21 -23
  708. data/lib/chef/run_context/cookbook_compiler.rb +10 -13
  709. data/lib/chef/run_list.rb +17 -17
  710. data/lib/chef/run_list/run_list_expansion.rb +22 -26
  711. data/lib/chef/run_list/run_list_item.rb +8 -9
  712. data/lib/chef/run_list/versioned_recipe_list.rb +13 -13
  713. data/lib/chef/run_lock.rb +12 -12
  714. data/lib/chef/run_status.rb +3 -3
  715. data/lib/chef/runner.rb +11 -12
  716. data/lib/chef/scan_access_control.rb +7 -7
  717. data/lib/chef/search/query.rb +30 -16
  718. data/lib/chef/server_api.rb +42 -10
  719. data/lib/chef/shell.rb +24 -25
  720. data/lib/chef/shell/ext.rb +31 -31
  721. data/lib/chef/shell/model_wrapper.rb +7 -8
  722. data/lib/chef/shell/shell_session.rb +20 -19
  723. data/lib/chef/shell_out.rb +2 -2
  724. data/lib/chef/tasks/chef_repo.rake +62 -63
  725. data/lib/chef/user.rb +38 -37
  726. data/lib/chef/user_v1.rb +53 -58
  727. data/lib/chef/util/backup.rb +6 -6
  728. data/lib/chef/util/diff.rb +8 -8
  729. data/lib/chef/util/dsc/configuration_generator.rb +11 -11
  730. data/lib/chef/util/dsc/lcm_output_parser.rb +8 -8
  731. data/lib/chef/util/dsc/local_configuration_manager.rb +9 -9
  732. data/lib/chef/util/dsc/resource_info.rb +15 -15
  733. data/lib/chef/util/dsc/resource_store.rb +73 -74
  734. data/lib/chef/util/editor.rb +1 -2
  735. data/lib/chef/util/file_edit.rb +5 -5
  736. data/lib/chef/util/path_helper.rb +2 -2
  737. data/lib/chef/util/powershell/cmdlet.rb +119 -119
  738. data/lib/chef/util/powershell/cmdlet_result.rb +36 -36
  739. data/lib/chef/util/powershell/ps_credential.rb +2 -2
  740. data/lib/chef/util/selinux.rb +6 -6
  741. data/lib/chef/util/threaded_job_queue.rb +2 -2
  742. data/lib/chef/util/windows.rb +1 -1
  743. data/lib/chef/util/windows/net_group.rb +84 -85
  744. data/lib/chef/util/windows/net_use.rb +6 -6
  745. data/lib/chef/util/windows/net_user.rb +9 -8
  746. data/lib/chef/util/windows/volume.rb +3 -3
  747. data/lib/chef/version.rb +2 -2
  748. data/lib/chef/version/platform.rb +5 -5
  749. data/lib/chef/version_class.rb +6 -6
  750. data/lib/chef/version_constraint.rb +13 -13
  751. data/lib/chef/version_constraint/platform.rb +3 -3
  752. data/lib/chef/whitelist.rb +2 -2
  753. data/lib/chef/win32/api.rb +13 -8
  754. data/lib/chef/win32/api/crypto.rb +63 -63
  755. data/lib/chef/win32/api/error.rb +11 -10
  756. data/lib/chef/win32/api/file.rb +17 -16
  757. data/lib/chef/win32/api/installer.rb +15 -16
  758. data/lib/chef/win32/api/memory.rb +4 -4
  759. data/lib/chef/win32/api/net.rb +111 -123
  760. data/lib/chef/win32/api/process.rb +4 -4
  761. data/lib/chef/win32/api/psapi.rb +4 -4
  762. data/lib/chef/win32/api/registry.rb +4 -4
  763. data/lib/chef/win32/api/security.rb +51 -26
  764. data/lib/chef/win32/api/synchronization.rb +4 -4
  765. data/lib/chef/win32/api/system.rb +4 -4
  766. data/lib/chef/win32/api/unicode.rb +4 -4
  767. data/lib/chef/win32/crypto.rb +50 -50
  768. data/lib/chef/win32/error.rb +18 -15
  769. data/lib/chef/win32/eventlog.rb +2 -2
  770. data/lib/chef/win32/file.rb +14 -14
  771. data/lib/chef/win32/file/info.rb +3 -4
  772. data/lib/chef/win32/file/version_info.rb +4 -4
  773. data/lib/chef/win32/handle.rb +6 -6
  774. data/lib/chef/win32/memory.rb +4 -4
  775. data/lib/chef/win32/mutex.rb +4 -4
  776. data/lib/chef/win32/net.rb +26 -59
  777. data/lib/chef/win32/process.rb +7 -7
  778. data/lib/chef/win32/registry.rb +19 -33
  779. data/lib/chef/win32/security.rb +82 -20
  780. data/lib/chef/win32/security/ace.rb +6 -6
  781. data/lib/chef/win32/security/acl.rb +8 -8
  782. data/lib/chef/win32/security/securable_object.rb +5 -5
  783. data/lib/chef/win32/security/security_descriptor.rb +5 -5
  784. data/lib/chef/win32/security/sid.rb +81 -43
  785. data/lib/chef/win32/security/token.rb +6 -6
  786. data/lib/chef/win32/system.rb +4 -4
  787. data/lib/chef/win32/unicode.rb +7 -7
  788. data/lib/chef/win32/version.rb +26 -26
  789. data/lib/chef/workstation_config_loader.rb +2 -2
  790. data/spec/data/apt/chef-integration-test-1.0/debian/copyright +2 -2
  791. data/spec/data/apt/chef-integration-test-1.1/debian/copyright +2 -2
  792. data/spec/data/apt/chef-integration-test2-1.0/debian/copyright +2 -2
  793. data/spec/data/cookbooks/name-mismatch-versionnumber/recipes/default.rb +1 -1
  794. data/spec/data/cookbooks/supports-platform-constraints/metadata.rb +5 -0
  795. data/spec/data/incomplete-metadata-chef-repo/incomplete-metadata/recipes/default.rb +1 -1
  796. data/spec/data/invalid-metadata-chef-repo/invalid-metadata/metadata.rb +1 -2
  797. data/spec/data/invalid-metadata-chef-repo/invalid-metadata/recipes/default.rb +1 -1
  798. data/spec/functional/application_spec.rb +7 -7
  799. data/spec/functional/assets/chocolatey_feed/test-A.1.0.nupkg +0 -0
  800. data/spec/functional/assets/chocolatey_feed/test-A.1.5.nupkg +0 -0
  801. data/spec/functional/assets/chocolatey_feed/test-A.2.0.nupkg +0 -0
  802. data/spec/functional/assets/chocolatey_feed/test-B.1.0.nupkg +0 -0
  803. data/spec/functional/audit/rspec_formatter_spec.rb +8 -8
  804. data/spec/functional/audit/runner_spec.rb +9 -9
  805. data/spec/functional/dsl/reboot_pending_spec.rb +10 -15
  806. data/spec/functional/dsl/registry_helper_spec.rb +8 -10
  807. data/spec/functional/event_loggers/windows_eventlog_spec.rb +27 -22
  808. data/spec/functional/file_content_management/deploy_strategies_spec.rb +9 -10
  809. data/spec/functional/http/simple_spec.rb +11 -11
  810. data/spec/functional/knife/configure_spec.rb +5 -10
  811. data/spec/functional/knife/cookbook_delete_spec.rb +11 -11
  812. data/spec/functional/knife/exec_spec.rb +6 -6
  813. data/spec/functional/knife/smoke_test.rb +11 -3
  814. data/spec/functional/knife/ssh_spec.rb +22 -22
  815. data/spec/functional/mixin/powershell_out_spec.rb +3 -3
  816. data/spec/functional/mixin/shell_out_spec.rb +12 -12
  817. data/spec/functional/notifications_spec.rb +6 -7
  818. data/spec/functional/provider/remote_file/cache_control_data_spec.rb +11 -12
  819. data/spec/functional/provider/whyrun_safe_ruby_block_spec.rb +4 -4
  820. data/spec/functional/rebooter_spec.rb +12 -12
  821. data/spec/functional/resource/aix_service_spec.rb +7 -8
  822. data/spec/functional/resource/aixinit_service_spec.rb +20 -20
  823. data/spec/functional/resource/base.rb +1 -3
  824. data/spec/functional/resource/bash_spec.rb +6 -6
  825. data/spec/functional/resource/batch_spec.rb +5 -5
  826. data/spec/functional/resource/bff_spec.rb +10 -12
  827. data/spec/functional/resource/chocolatey_package_spec.rb +124 -0
  828. data/spec/functional/resource/cookbook_file_spec.rb +9 -9
  829. data/spec/functional/resource/cron_spec.rb +13 -13
  830. data/spec/functional/resource/deploy_revision_spec.rb +18 -18
  831. data/spec/functional/resource/directory_spec.rb +4 -4
  832. data/spec/functional/resource/dpkg_package_spec.rb +38 -38
  833. data/spec/functional/resource/dsc_resource_spec.rb +17 -22
  834. data/spec/functional/resource/dsc_script_spec.rb +104 -106
  835. data/spec/functional/resource/env_spec.rb +30 -30
  836. data/spec/functional/resource/execute_spec.rb +10 -10
  837. data/spec/functional/resource/file_spec.rb +12 -13
  838. data/spec/functional/resource/git_spec.rb +20 -20
  839. data/spec/functional/resource/group_spec.rb +21 -21
  840. data/spec/functional/resource/ifconfig_spec.rb +11 -11
  841. data/spec/functional/resource/link_spec.rb +140 -135
  842. data/spec/functional/resource/mount_spec.rb +17 -29
  843. data/spec/functional/resource/ohai_spec.rb +5 -8
  844. data/spec/functional/resource/package_spec.rb +11 -13
  845. data/spec/functional/resource/powershell_script_spec.rb +60 -60
  846. data/spec/functional/resource/reboot_spec.rb +12 -12
  847. data/spec/functional/resource/registry_spec.rb +71 -72
  848. data/spec/functional/resource/remote_directory_spec.rb +23 -23
  849. data/spec/functional/resource/remote_file_spec.rb +17 -17
  850. data/spec/functional/resource/rpm_spec.rb +14 -14
  851. data/spec/functional/resource/template_spec.rb +8 -8
  852. data/spec/functional/resource/user/dscl_spec.rb +3 -3
  853. data/spec/functional/resource/user/useradd_spec.rb +31 -37
  854. data/spec/functional/resource/user/windows_spec.rb +20 -20
  855. data/spec/functional/resource/windows_package_spec.rb +26 -35
  856. data/spec/functional/resource/windows_service_spec.rb +12 -8
  857. data/spec/functional/rest_spec.rb +6 -5
  858. data/spec/functional/run_lock_spec.rb +15 -14
  859. data/spec/functional/shell_spec.rb +11 -10
  860. data/spec/functional/tiny_server_spec.rb +18 -18
  861. data/spec/functional/util/path_helper_spec.rb +5 -5
  862. data/spec/functional/util/powershell/cmdlet_spec.rb +24 -27
  863. data/spec/functional/version_spec.rb +6 -6
  864. data/spec/functional/win32/crypto_spec.rb +7 -10
  865. data/spec/functional/win32/registry_spec.rb +105 -107
  866. data/spec/functional/win32/security_spec.rb +17 -17
  867. data/spec/functional/win32/service_manager_spec.rb +7 -8
  868. data/spec/functional/win32/sid_spec.rb +13 -13
  869. data/spec/functional/win32/version_info_spec.rb +7 -7
  870. data/spec/functional/win32/versions_spec.rb +13 -13
  871. data/spec/integration/client/client_spec.rb +65 -66
  872. data/spec/integration/client/ipv6_spec.rb +15 -16
  873. data/spec/integration/knife/chef_fs_data_store_spec.rb +432 -246
  874. data/spec/integration/knife/chef_repo_path_spec.rb +261 -261
  875. data/spec/integration/knife/chef_repository_file_system_spec.rb +84 -84
  876. data/spec/integration/knife/chefignore_spec.rb +82 -82
  877. data/spec/integration/knife/common_options_spec.rb +41 -41
  878. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +9 -9
  879. data/spec/integration/knife/delete_spec.rb +262 -248
  880. data/spec/integration/knife/deps_spec.rb +301 -301
  881. data/spec/integration/knife/diff_spec.rb +237 -237
  882. data/spec/integration/knife/download_spec.rb +532 -401
  883. data/spec/integration/knife/list_spec.rb +310 -116
  884. data/spec/integration/knife/raw_spec.rb +39 -39
  885. data/spec/integration/knife/redirection_spec.rb +12 -12
  886. data/spec/integration/knife/serve_spec.rb +12 -12
  887. data/spec/integration/knife/show_spec.rb +59 -59
  888. data/spec/integration/knife/upload_spec.rb +661 -550
  889. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +18 -18
  890. data/spec/integration/recipes/lwrp_spec.rb +7 -7
  891. data/spec/integration/recipes/provider_choice.rb +3 -2
  892. data/spec/integration/recipes/recipe_dsl_spec.rb +151 -124
  893. data/spec/integration/recipes/remote_directory.rb +2 -2
  894. data/spec/integration/recipes/resource_action_spec.rb +439 -328
  895. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +12 -11
  896. data/spec/integration/recipes/resource_load_spec.rb +35 -33
  897. data/spec/integration/solo/solo_spec.rb +31 -32
  898. data/spec/scripts/ssl-serve.rb +12 -17
  899. data/spec/spec_helper.rb +48 -43
  900. data/spec/stress/win32/file_spec.rb +5 -5
  901. data/spec/stress/win32/memory_spec.rb +4 -4
  902. data/spec/stress/win32/security_spec.rb +8 -8
  903. data/spec/support/chef_helpers.rb +5 -6
  904. data/spec/support/key_helpers.rb +2 -2
  905. data/spec/support/lib/chef/provider/easy.rb +2 -2
  906. data/spec/support/lib/chef/provider/openldap_includer.rb +2 -2
  907. data/spec/support/lib/chef/provider/snakeoil.rb +2 -2
  908. data/spec/support/lib/chef/resource/cat.rb +4 -4
  909. data/spec/support/lib/chef/resource/one_two_three_four.rb +2 -2
  910. data/spec/support/lib/chef/resource/openldap_includer.rb +2 -3
  911. data/spec/support/lib/chef/resource/with_state.rb +4 -4
  912. data/spec/support/lib/chef/resource/zen_follower.rb +4 -4
  913. data/spec/support/lib/chef/resource/zen_master.rb +5 -6
  914. data/spec/support/lib/library_load_order.rb +0 -2
  915. data/spec/support/matchers/leak.rb +7 -5
  916. data/spec/support/mock/constant.rb +3 -3
  917. data/spec/support/mock/platform.rb +5 -5
  918. data/spec/support/platform_helpers.rb +36 -23
  919. data/spec/support/platforms/prof/gc.rb +2 -3
  920. data/spec/support/platforms/prof/win32.rb +3 -4
  921. data/spec/support/platforms/win32/spec_service.rb +3 -3
  922. data/spec/support/shared/context/client.rb +22 -14
  923. data/spec/support/shared/context/config.rb +3 -3
  924. data/spec/support/shared/context/win32.rb +9 -9
  925. data/spec/support/shared/examples/client.rb +4 -4
  926. data/spec/support/shared/functional/diff_disabled.rb +1 -1
  927. data/spec/support/shared/functional/directory_resource.rb +8 -8
  928. data/spec/support/shared/functional/file_resource.rb +20 -23
  929. data/spec/support/shared/functional/http.rb +33 -34
  930. data/spec/support/shared/functional/knife.rb +3 -3
  931. data/spec/support/shared/functional/securable_resource.rb +48 -48
  932. data/spec/support/shared/functional/securable_resource_with_reporting.rb +8 -12
  933. data/spec/support/shared/functional/win32_service.rb +3 -5
  934. data/spec/support/shared/functional/windows_script.rb +13 -13
  935. data/spec/support/shared/integration/app_server_support.rb +7 -7
  936. data/spec/support/shared/integration/integration_helper.rb +21 -21
  937. data/spec/support/shared/integration/knife_support.rb +13 -13
  938. data/spec/support/shared/matchers/exit_with_code.rb +2 -2
  939. data/spec/support/shared/matchers/match_environment_variable.rb +2 -2
  940. data/spec/support/shared/unit/api_error_inspector.rb +3 -5
  941. data/spec/support/shared/unit/api_versioning.rb +8 -8
  942. data/spec/support/shared/unit/execute_resource.rb +4 -4
  943. data/spec/support/shared/unit/file_system_support.rb +12 -13
  944. data/spec/support/shared/unit/knife_shared.rb +1 -2
  945. data/spec/support/shared/unit/mock_shellout.rb +5 -2
  946. data/spec/support/shared/unit/platform_introspector.rb +35 -37
  947. data/spec/support/shared/unit/provider/file.rb +29 -40
  948. data/spec/support/shared/unit/provider/useradd_based_user_provider.rb +50 -51
  949. data/spec/support/shared/unit/resource/static_provider_resolution.rb +2 -5
  950. data/spec/support/shared/unit/script_resource.rb +10 -10
  951. data/spec/support/shared/unit/user_and_client_shared.rb +5 -6
  952. data/spec/support/shared/unit/windows_script_resource.rb +6 -7
  953. data/spec/tiny_server.rb +24 -24
  954. data/spec/unit/api_client/registration_spec.rb +41 -38
  955. data/spec/unit/api_client_spec.rb +13 -16
  956. data/spec/unit/api_client_v1_spec.rb +17 -19
  957. data/spec/unit/application/apply_spec.rb +3 -3
  958. data/spec/unit/application/client_spec.rb +12 -9
  959. data/spec/unit/application/knife_spec.rb +69 -17
  960. data/spec/unit/application/solo_spec.rb +29 -48
  961. data/spec/unit/application_spec.rb +171 -151
  962. data/spec/unit/audit/audit_event_proxy_spec.rb +13 -13
  963. data/spec/unit/audit/audit_reporter_spec.rb +18 -25
  964. data/spec/unit/audit/control_group_data_spec.rb +16 -17
  965. data/spec/unit/audit/logger_spec.rb +5 -5
  966. data/spec/unit/audit/rspec_formatter_spec.rb +4 -4
  967. data/spec/unit/audit/runner_spec.rb +11 -12
  968. data/spec/unit/chef_class_spec.rb +5 -5
  969. data/spec/unit/chef_fs/config_spec.rb +14 -18
  970. data/spec/unit/chef_fs/data_handler/group_handler_spec.rb +17 -17
  971. data/spec/unit/chef_fs/diff_spec.rb +75 -75
  972. data/spec/unit/chef_fs/file_pattern_spec.rb +368 -369
  973. data/spec/unit/chef_fs/file_system/cookbook_subdir_spec.rb +9 -9
  974. data/spec/unit/chef_fs/file_system/operation_failed_error_spec.rb +9 -9
  975. data/spec/unit/chef_fs/file_system_spec.rb +74 -74
  976. data/spec/unit/chef_fs/parallelizer.rb +63 -66
  977. data/spec/unit/chef_fs/path_util_spec.rb +45 -45
  978. data/spec/unit/chef_spec.rb +3 -3
  979. data/spec/unit/client_spec.rb +44 -44
  980. data/spec/unit/config_fetcher_spec.rb +56 -28
  981. data/spec/unit/config_spec.rb +2 -2
  982. data/spec/unit/cookbook/chefignore_spec.rb +12 -12
  983. data/spec/unit/cookbook/cookbook_version_loader_spec.rb +5 -6
  984. data/spec/unit/cookbook/file_vendor_spec.rb +8 -9
  985. data/spec/unit/cookbook/metadata_spec.rb +73 -76
  986. data/spec/unit/cookbook/synchronizer_spec.rb +31 -32
  987. data/spec/unit/cookbook/syntax_check_spec.rb +22 -22
  988. data/spec/unit/cookbook_loader_spec.rb +9 -10
  989. data/spec/unit/cookbook_manifest_spec.rb +27 -28
  990. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +24 -24
  991. data/spec/unit/cookbook_spec.rb +3 -3
  992. data/spec/unit/cookbook_uploader_spec.rb +10 -11
  993. data/spec/unit/cookbook_version_file_specificity_spec.rb +49 -50
  994. data/spec/unit/cookbook_version_spec.rb +45 -48
  995. data/spec/unit/daemon_spec.rb +5 -5
  996. data/spec/unit/data_bag_item_spec.rb +29 -30
  997. data/spec/unit/data_bag_spec.rb +47 -47
  998. data/spec/unit/deprecation_spec.rb +11 -11
  999. data/spec/unit/digester_spec.rb +5 -6
  1000. data/spec/unit/dsl/audit_spec.rb +5 -5
  1001. data/spec/unit/dsl/data_query_spec.rb +12 -12
  1002. data/spec/unit/dsl/platform_introspection_spec.rb +19 -20
  1003. data/spec/unit/dsl/reboot_pending_spec.rb +17 -17
  1004. data/spec/unit/dsl/recipe_spec.rb +4 -6
  1005. data/spec/unit/dsl/regsitry_helper_spec.rb +9 -12
  1006. data/spec/unit/dsl/resources_spec.rb +13 -13
  1007. data/spec/unit/encrypted_data_bag_item/check_encrypted_spec.rb +7 -7
  1008. data/spec/unit/encrypted_data_bag_item_spec.rb +11 -11
  1009. data/spec/unit/environment_spec.rb +53 -53
  1010. data/spec/unit/event_dispatch/dispatcher_spec.rb +3 -4
  1011. data/spec/unit/event_dispatch/dsl_spec.rb +16 -16
  1012. data/spec/unit/exceptions_spec.rb +10 -10
  1013. data/spec/unit/file_access_control_spec.rb +32 -32
  1014. data/spec/unit/file_cache_spec.rb +19 -19
  1015. data/spec/unit/file_content_management/deploy/cp_spec.rb +3 -5
  1016. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +3 -5
  1017. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +5 -12
  1018. data/spec/unit/formatters/base_spec.rb +29 -6
  1019. data/spec/unit/formatters/doc_spec.rb +7 -7
  1020. data/spec/unit/formatters/error_inspectors/api_error_formatting_spec.rb +9 -10
  1021. data/spec/unit/formatters/error_inspectors/compile_error_inspector_spec.rb +11 -11
  1022. data/spec/unit/formatters/error_inspectors/cookbook_resolve_error_inspector_spec.rb +4 -7
  1023. data/spec/unit/formatters/error_inspectors/cookbook_sync_error_inspector_spec.rb +3 -3
  1024. data/spec/unit/formatters/error_inspectors/node_load_error_inspector_spec.rb +3 -4
  1025. data/spec/unit/formatters/error_inspectors/registration_error_inspector_spec.rb +3 -4
  1026. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +4 -6
  1027. data/spec/unit/formatters/error_inspectors/run_list_expansion_error_inspector_spec.rb +5 -7
  1028. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +9 -9
  1029. data/spec/unit/guard_interpreter_spec.rb +3 -3
  1030. data/spec/unit/handler/json_file_spec.rb +11 -12
  1031. data/spec/unit/handler_spec.rb +7 -7
  1032. data/spec/unit/http/authenticator_spec.rb +9 -7
  1033. data/spec/unit/http/basic_client_spec.rb +3 -3
  1034. data/spec/unit/http/http_request_spec.rb +22 -22
  1035. data/spec/unit/http/json_input_spec.rb +7 -7
  1036. data/spec/unit/http/simple_spec.rb +3 -3
  1037. data/spec/unit/http/socketless_chef_zero_client_spec.rb +3 -4
  1038. data/spec/unit/http/ssl_policies_spec.rb +18 -19
  1039. data/spec/unit/http/validate_content_length_spec.rb +9 -9
  1040. data/spec/unit/http_spec.rb +18 -18
  1041. data/spec/unit/json_compat_spec.rb +16 -9
  1042. data/spec/unit/key_spec.rb +41 -44
  1043. data/spec/unit/knife/bootstrap/chef_vault_handler_spec.rb +41 -42
  1044. data/spec/unit/knife/bootstrap/client_builder_spec.rb +30 -28
  1045. data/spec/unit/knife/bootstrap_spec.rb +75 -37
  1046. data/spec/unit/knife/client_bulk_delete_spec.rb +6 -6
  1047. data/spec/unit/knife/client_create_spec.rb +11 -12
  1048. data/spec/unit/knife/client_delete_spec.rb +13 -13
  1049. data/spec/unit/knife/client_edit_spec.rb +9 -9
  1050. data/spec/unit/knife/client_list_spec.rb +5 -5
  1051. data/spec/unit/knife/client_reregister_spec.rb +13 -13
  1052. data/spec/unit/knife/client_show_spec.rb +12 -12
  1053. data/spec/unit/knife/configure_client_spec.rb +19 -20
  1054. data/spec/unit/knife/configure_spec.rb +37 -39
  1055. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +17 -19
  1056. data/spec/unit/knife/cookbook_create_spec.rb +32 -32
  1057. data/spec/unit/knife/cookbook_delete_spec.rb +79 -79
  1058. data/spec/unit/knife/cookbook_download_spec.rb +84 -85
  1059. data/spec/unit/knife/cookbook_list_spec.rb +26 -26
  1060. data/spec/unit/knife/cookbook_metadata_from_file_spec.rb +5 -5
  1061. data/spec/unit/knife/cookbook_metadata_spec.rb +55 -55
  1062. data/spec/unit/knife/cookbook_show_spec.rb +33 -34
  1063. data/spec/unit/knife/cookbook_site_download_spec.rb +51 -53
  1064. data/spec/unit/knife/cookbook_site_install_spec.rb +10 -8
  1065. data/spec/unit/knife/cookbook_site_share_spec.rb +42 -42
  1066. data/spec/unit/knife/cookbook_site_unshare_spec.rb +20 -20
  1067. data/spec/unit/knife/cookbook_test_spec.rb +6 -6
  1068. data/spec/unit/knife/cookbook_upload_spec.rb +69 -69
  1069. data/spec/unit/knife/core/bootstrap_context_spec.rb +39 -33
  1070. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +32 -32
  1071. data/spec/unit/knife/core/custom_manifest_loader_spec.rb +3 -3
  1072. data/spec/unit/knife/core/gem_glob_loader_spec.rb +23 -24
  1073. data/spec/unit/knife/core/hashed_command_loader_spec.rb +8 -8
  1074. data/spec/unit/knife/core/node_editor_spec.rb +211 -0
  1075. data/spec/unit/knife/core/object_loader_spec.rb +12 -12
  1076. data/spec/unit/knife/core/subcommand_loader_spec.rb +10 -10
  1077. data/spec/unit/knife/core/ui_spec.rb +45 -45
  1078. data/spec/unit/knife/data_bag_create_spec.rb +14 -14
  1079. data/spec/unit/knife/data_bag_edit_spec.rb +12 -12
  1080. data/spec/unit/knife/data_bag_from_file_spec.rb +9 -9
  1081. data/spec/unit/knife/data_bag_secret_options_spec.rb +6 -6
  1082. data/spec/unit/knife/data_bag_show_spec.rb +19 -19
  1083. data/spec/unit/knife/environment_compare_spec.rb +32 -32
  1084. data/spec/unit/knife/environment_create_spec.rb +2 -2
  1085. data/spec/unit/knife/environment_delete_spec.rb +2 -2
  1086. data/spec/unit/knife/environment_edit_spec.rb +2 -2
  1087. data/spec/unit/knife/environment_from_file_spec.rb +5 -5
  1088. data/spec/unit/knife/environment_list_spec.rb +4 -4
  1089. data/spec/unit/knife/environment_show_spec.rb +2 -2
  1090. data/spec/unit/knife/index_rebuild_spec.rb +14 -17
  1091. data/spec/unit/knife/key_create_spec.rb +11 -12
  1092. data/spec/unit/knife/key_delete_spec.rb +8 -10
  1093. data/spec/unit/knife/key_edit_spec.rb +14 -17
  1094. data/spec/unit/knife/key_helper.rb +2 -2
  1095. data/spec/unit/knife/key_list_spec.rb +13 -13
  1096. data/spec/unit/knife/key_show_spec.rb +11 -11
  1097. data/spec/unit/knife/knife_help.rb +2 -2
  1098. data/spec/unit/knife/node_bulk_delete_spec.rb +10 -13
  1099. data/spec/unit/knife/node_delete_spec.rb +4 -4
  1100. data/spec/unit/knife/node_edit_spec.rb +17 -18
  1101. data/spec/unit/knife/node_environment_set_spec.rb +4 -4
  1102. data/spec/unit/knife/node_from_file_spec.rb +5 -5
  1103. data/spec/unit/knife/node_list_spec.rb +5 -6
  1104. data/spec/unit/knife/node_run_list_add_spec.rb +5 -8
  1105. data/spec/unit/knife/node_run_list_remove_spec.rb +27 -27
  1106. data/spec/unit/knife/node_run_list_set_spec.rb +4 -4
  1107. data/spec/unit/knife/node_show_spec.rb +6 -6
  1108. data/spec/unit/knife/osc_user_create_spec.rb +7 -7
  1109. data/spec/unit/knife/osc_user_delete_spec.rb +7 -7
  1110. data/spec/unit/knife/osc_user_edit_spec.rb +6 -6
  1111. data/spec/unit/knife/osc_user_list_spec.rb +3 -3
  1112. data/spec/unit/knife/osc_user_reregister_spec.rb +10 -10
  1113. data/spec/unit/knife/osc_user_show_spec.rb +8 -8
  1114. data/spec/unit/knife/raw_spec.rb +6 -6
  1115. data/spec/unit/knife/role_bulk_delete_spec.rb +4 -4
  1116. data/spec/unit/knife/role_create_spec.rb +4 -4
  1117. data/spec/unit/knife/role_delete_spec.rb +4 -4
  1118. data/spec/unit/knife/role_edit_spec.rb +4 -6
  1119. data/spec/unit/knife/role_env_run_list_add_spec.rb +9 -9
  1120. data/spec/unit/knife/role_env_run_list_clear_spec.rb +38 -44
  1121. data/spec/unit/knife/role_env_run_list_remove_spec.rb +46 -52
  1122. data/spec/unit/knife/role_env_run_list_replace_spec.rb +49 -52
  1123. data/spec/unit/knife/role_env_run_list_set_spec.rb +17 -20
  1124. data/spec/unit/knife/role_from_file_spec.rb +7 -7
  1125. data/spec/unit/knife/role_list_spec.rb +5 -7
  1126. data/spec/unit/knife/role_run_list_add_spec.rb +7 -7
  1127. data/spec/unit/knife/role_run_list_clear_spec.rb +28 -34
  1128. data/spec/unit/knife/role_run_list_remove_spec.rb +36 -42
  1129. data/spec/unit/knife/role_run_list_replace_spec.rb +42 -45
  1130. data/spec/unit/knife/role_run_list_set_spec.rb +6 -9
  1131. data/spec/unit/knife/role_show_spec.rb +14 -14
  1132. data/spec/unit/knife/ssh_spec.rb +36 -36
  1133. data/spec/unit/knife/ssl_check_spec.rb +7 -7
  1134. data/spec/unit/knife/ssl_fetch_spec.rb +8 -8
  1135. data/spec/unit/knife/status_spec.rb +5 -5
  1136. data/spec/unit/knife/tag_create_spec.rb +1 -1
  1137. data/spec/unit/knife/tag_delete_spec.rb +1 -1
  1138. data/spec/unit/knife/tag_list_spec.rb +2 -2
  1139. data/spec/unit/knife/user_create_spec.rb +30 -30
  1140. data/spec/unit/knife/user_delete_spec.rb +11 -11
  1141. data/spec/unit/knife/user_edit_spec.rb +9 -9
  1142. data/spec/unit/knife/user_list_spec.rb +3 -3
  1143. data/spec/unit/knife/user_reregister_spec.rb +13 -13
  1144. data/spec/unit/knife/user_show_spec.rb +12 -12
  1145. data/spec/unit/knife_spec.rb +61 -61
  1146. data/spec/unit/lib_backcompat_spec.rb +34 -0
  1147. data/spec/unit/log/syslog_spec.rb +3 -3
  1148. data/spec/unit/log/winevt_spec.rb +3 -3
  1149. data/spec/unit/log_spec.rb +5 -5
  1150. data/spec/unit/lwrp_spec.rb +41 -43
  1151. data/spec/unit/mash_spec.rb +8 -8
  1152. data/spec/unit/mixin/api_version_request_handling_spec.rb +13 -14
  1153. data/spec/unit/mixin/checksum_spec.rb +5 -6
  1154. data/spec/unit/mixin/command_spec.rb +9 -9
  1155. data/spec/unit/mixin/convert_to_class_name_spec.rb +2 -2
  1156. data/spec/unit/mixin/deep_merge_spec.rb +107 -107
  1157. data/spec/unit/mixin/deprecation_spec.rb +5 -5
  1158. data/spec/unit/mixin/enforce_ownership_and_permissions_spec.rb +9 -9
  1159. data/spec/unit/mixin/homebrew_user_spec.rb +13 -13
  1160. data/spec/unit/mixin/params_validate_spec.rb +71 -71
  1161. data/spec/unit/mixin/path_sanity_spec.rb +16 -16
  1162. data/spec/unit/mixin/powershell_out_spec.rb +9 -9
  1163. data/spec/unit/mixin/powershell_type_coercions_spec.rb +34 -23
  1164. data/spec/unit/mixin/properties_spec.rb +27 -27
  1165. data/spec/unit/mixin/proxified_socket_spec.rb +6 -6
  1166. data/spec/unit/mixin/securable_spec.rb +37 -37
  1167. data/spec/unit/mixin/shell_out_spec.rb +68 -68
  1168. data/spec/unit/mixin/subclass_directive_spec.rb +2 -2
  1169. data/spec/unit/mixin/template_spec.rb +15 -12
  1170. data/spec/unit/mixin/unformatter_spec.rb +3 -3
  1171. data/spec/unit/mixin/uris_spec.rb +8 -8
  1172. data/spec/unit/mixin/windows_architecture_helper_spec.rb +14 -17
  1173. data/spec/unit/mixin/xml_escape_spec.rb +3 -3
  1174. data/spec/unit/monkey_patches/uri_spec.rb +3 -3
  1175. data/spec/unit/monologger_spec.rb +4 -4
  1176. data/spec/unit/node/attribute_spec.rb +203 -248
  1177. data/spec/unit/node/immutable_collections_spec.rb +20 -21
  1178. data/spec/unit/node_map_spec.rb +5 -5
  1179. data/spec/unit/node_spec.rb +165 -135
  1180. data/spec/unit/org_spec.rb +17 -17
  1181. data/spec/unit/platform/query_helpers_spec.rb +23 -23
  1182. data/spec/unit/platform_spec.rb +17 -17
  1183. data/spec/unit/policy_builder/dynamic_spec.rb +8 -10
  1184. data/spec/unit/policy_builder/expand_node_object_spec.rb +16 -14
  1185. data/spec/unit/policy_builder/policyfile_spec.rb +30 -37
  1186. data/spec/unit/policy_builder_spec.rb +4 -4
  1187. data/spec/unit/property/state_spec.rb +58 -56
  1188. data/spec/unit/property/validation_spec.rb +255 -216
  1189. data/spec/unit/property_spec.rb +206 -129
  1190. data/spec/unit/provider/apt_update_spec.rb +113 -0
  1191. data/spec/unit/provider/breakpoint_spec.rb +2 -3
  1192. data/spec/unit/provider/cookbook_file/content_spec.rb +9 -10
  1193. data/spec/unit/provider/cookbook_file_spec.rb +11 -11
  1194. data/spec/unit/provider/cron/unix_spec.rb +7 -7
  1195. data/spec/unit/provider/cron_spec.rb +67 -67
  1196. data/spec/unit/provider/deploy/revision_spec.rb +6 -7
  1197. data/spec/unit/provider/deploy/timestamped_spec.rb +2 -2
  1198. data/spec/unit/provider/deploy_spec.rb +24 -25
  1199. data/spec/unit/provider/directory_spec.rb +12 -12
  1200. data/spec/unit/provider/dsc_resource_spec.rb +29 -27
  1201. data/spec/unit/provider/dsc_script_spec.rb +47 -48
  1202. data/spec/unit/provider/env/windows_spec.rb +21 -21
  1203. data/spec/unit/provider/env_spec.rb +5 -5
  1204. data/spec/unit/provider/erl_call_spec.rb +3 -4
  1205. data/spec/unit/provider/execute_spec.rb +5 -5
  1206. data/spec/unit/provider/file/content_spec.rb +4 -4
  1207. data/spec/unit/provider/file_spec.rb +8 -9
  1208. data/spec/unit/provider/git_spec.rb +64 -65
  1209. data/spec/unit/provider/group/dscl_spec.rb +7 -7
  1210. data/spec/unit/provider/group/gpasswd_spec.rb +3 -3
  1211. data/spec/unit/provider/group/groupadd_spec.rb +9 -9
  1212. data/spec/unit/provider/group/groupmod_spec.rb +12 -12
  1213. data/spec/unit/provider/group/pw_spec.rb +3 -3
  1214. data/spec/unit/provider/group/usermod_spec.rb +6 -6
  1215. data/spec/unit/provider/group/windows_spec.rb +3 -3
  1216. data/spec/unit/provider/group_spec.rb +16 -16
  1217. data/spec/unit/provider/http_request_spec.rb +7 -7
  1218. data/spec/unit/provider/ifconfig/aix_spec.rb +4 -5
  1219. data/spec/unit/provider/ifconfig/debian_spec.rb +6 -6
  1220. data/spec/unit/provider/ifconfig/redhat_spec.rb +3 -3
  1221. data/spec/unit/provider/ifconfig_spec.rb +5 -5
  1222. data/spec/unit/provider/link_spec.rb +12 -12
  1223. data/spec/unit/provider/log_spec.rb +2 -2
  1224. data/spec/unit/provider/mdadm_spec.rb +12 -12
  1225. data/spec/unit/provider/mount/aix_spec.rb +7 -7
  1226. data/spec/unit/provider/mount/mount_spec.rb +20 -20
  1227. data/spec/unit/provider/mount/solaris_spec.rb +26 -26
  1228. data/spec/unit/provider/mount/windows_spec.rb +8 -8
  1229. data/spec/unit/provider/mount_spec.rb +7 -8
  1230. data/spec/unit/provider/ohai_spec.rb +13 -13
  1231. data/spec/unit/provider/osx_profile_spec.rb +249 -0
  1232. data/spec/unit/provider/package/aix_spec.rb +5 -5
  1233. data/spec/unit/provider/package/apt_spec.rb +49 -49
  1234. data/spec/unit/provider/package/chocolatey_spec.rb +504 -0
  1235. data/spec/unit/provider/package/dpkg_spec.rb +32 -36
  1236. data/spec/unit/provider/package/easy_install_spec.rb +11 -15
  1237. data/spec/unit/provider/package/freebsd/pkg_spec.rb +10 -10
  1238. data/spec/unit/provider/package/freebsd/pkgng_spec.rb +12 -19
  1239. data/spec/unit/provider/package/freebsd/port_spec.rb +12 -19
  1240. data/spec/unit/provider/package/homebrew_spec.rb +139 -139
  1241. data/spec/unit/provider/package/ips_spec.rb +10 -11
  1242. data/spec/unit/provider/package/macports_spec.rb +3 -3
  1243. data/spec/unit/provider/package/openbsd_spec.rb +38 -38
  1244. data/spec/unit/provider/package/pacman_spec.rb +8 -9
  1245. data/spec/unit/provider/package/paludis_spec.rb +9 -10
  1246. data/spec/unit/provider/package/portage_spec.rb +2 -2
  1247. data/spec/unit/provider/package/rpm_spec.rb +7 -11
  1248. data/spec/unit/provider/package/rubygems_spec.rb +386 -289
  1249. data/spec/unit/provider/package/smartos_spec.rb +8 -10
  1250. data/spec/unit/provider/package/solaris_spec.rb +4 -4
  1251. data/spec/unit/provider/package/windows/exe_spec.rb +17 -81
  1252. data/spec/unit/provider/package/windows/msi_spec.rb +16 -16
  1253. data/spec/unit/provider/package/windows_spec.rb +50 -40
  1254. data/spec/unit/provider/package/yum_spec.rb +179 -181
  1255. data/spec/unit/provider/package/zypper_spec.rb +53 -50
  1256. data/spec/unit/provider/package_spec.rb +104 -104
  1257. data/spec/unit/provider/powershell_script_spec.rb +20 -20
  1258. data/spec/unit/provider/registry_key_spec.rb +3 -3
  1259. data/spec/unit/provider/remote_directory_spec.rb +46 -46
  1260. data/spec/unit/provider/remote_file/cache_control_data_spec.rb +9 -10
  1261. data/spec/unit/provider/remote_file/content_spec.rb +5 -6
  1262. data/spec/unit/provider/remote_file/fetcher_spec.rb +3 -3
  1263. data/spec/unit/provider/remote_file/ftp_spec.rb +3 -3
  1264. data/spec/unit/provider/remote_file/http_spec.rb +10 -12
  1265. data/spec/unit/provider/remote_file/local_file_spec.rb +2 -2
  1266. data/spec/unit/provider/remote_file/network_file_spec.rb +2 -2
  1267. data/spec/unit/provider/remote_file_spec.rb +9 -11
  1268. data/spec/unit/provider/route_spec.rb +26 -27
  1269. data/spec/unit/provider/ruby_block_spec.rb +4 -5
  1270. data/spec/unit/provider/script_spec.rb +11 -11
  1271. data/spec/unit/provider/service/aix_service_spec.rb +5 -6
  1272. data/spec/unit/provider/service/aixinit_service_spec.rb +26 -23
  1273. data/spec/unit/provider/service/arch_service_spec.rb +15 -15
  1274. data/spec/unit/provider/service/debian_service_spec.rb +37 -37
  1275. data/spec/unit/provider/service/freebsd_service_spec.rb +9 -9
  1276. data/spec/unit/provider/service/gentoo_service_spec.rb +4 -4
  1277. data/spec/unit/provider/service/init_service_spec.rb +9 -9
  1278. data/spec/unit/provider/service/insserv_service_spec.rb +3 -3
  1279. data/spec/unit/provider/service/invokercd_service_spec.rb +9 -9
  1280. data/spec/unit/provider/service/macosx_spec.rb +26 -26
  1281. data/spec/unit/provider/service/openbsd_service_spec.rb +26 -26
  1282. data/spec/unit/provider/service/redhat_spec.rb +16 -16
  1283. data/spec/unit/provider/service/simple_service_spec.rb +5 -5
  1284. data/spec/unit/provider/service/solaris_smf_service_spec.rb +51 -51
  1285. data/spec/unit/provider/service/systemd_service_spec.rb +4 -4
  1286. data/spec/unit/provider/service/upstart_service_spec.rb +13 -13
  1287. data/spec/unit/provider/service/windows_spec.rb +28 -37
  1288. data/spec/unit/provider/service_spec.rb +2 -3
  1289. data/spec/unit/provider/subversion_spec.rb +27 -28
  1290. data/spec/unit/provider/template/content_spec.rb +21 -21
  1291. data/spec/unit/provider/template_spec.rb +15 -16
  1292. data/spec/unit/provider/user/dscl_spec.rb +36 -37
  1293. data/spec/unit/provider/user/pw_spec.rb +12 -12
  1294. data/spec/unit/provider/user/solaris_spec.rb +31 -31
  1295. data/spec/unit/provider/user/useradd_spec.rb +10 -10
  1296. data/spec/unit/provider/user/windows_spec.rb +9 -9
  1297. data/spec/unit/provider/user_spec.rb +19 -20
  1298. data/spec/unit/provider/whyrun_safe_ruby_block_spec.rb +3 -4
  1299. data/spec/unit/provider_resolver_spec.rb +63 -62
  1300. data/spec/unit/provider_spec.rb +7 -8
  1301. data/spec/unit/pure_application_spec.rb +3 -3
  1302. data/spec/unit/recipe_spec.rb +13 -16
  1303. data/spec/unit/resource/apt_package_spec.rb +4 -4
  1304. data/spec/unit/resource/apt_update_spec.rb +38 -0
  1305. data/spec/unit/resource/bash_spec.rb +3 -3
  1306. data/spec/unit/resource/batch_spec.rb +5 -5
  1307. data/spec/unit/resource/breakpoint_spec.rb +3 -3
  1308. data/spec/unit/resource/chef_gem_spec.rb +5 -9
  1309. data/spec/unit/resource/chocolatey_package_spec.rb +67 -0
  1310. data/spec/unit/resource/conditional_action_not_nothing_spec.rb +2 -2
  1311. data/spec/unit/resource/conditional_spec.rb +12 -12
  1312. data/spec/unit/resource/cookbook_file_spec.rb +23 -24
  1313. data/spec/unit/resource/cron_spec.rb +4 -4
  1314. data/spec/unit/resource/csh_spec.rb +3 -3
  1315. data/spec/unit/resource/deploy_revision_spec.rb +3 -3
  1316. data/spec/unit/resource/deploy_spec.rb +23 -24
  1317. data/spec/unit/resource/directory_spec.rb +4 -4
  1318. data/spec/unit/resource/dpkg_package_spec.rb +5 -5
  1319. data/spec/unit/resource/dsc_resource_spec.rb +11 -11
  1320. data/spec/unit/resource/dsc_script_spec.rb +15 -15
  1321. data/spec/unit/resource/easy_install_package_spec.rb +3 -3
  1322. data/spec/unit/resource/env_spec.rb +5 -5
  1323. data/spec/unit/resource/erl_call_spec.rb +3 -3
  1324. data/spec/unit/resource/execute_spec.rb +4 -4
  1325. data/spec/unit/resource/file/verification_spec.rb +11 -11
  1326. data/spec/unit/resource/file_spec.rb +10 -10
  1327. data/spec/unit/resource/freebsd_package_spec.rb +6 -9
  1328. data/spec/unit/resource/gem_package_spec.rb +4 -4
  1329. data/spec/unit/resource/git_spec.rb +3 -3
  1330. data/spec/unit/resource/group_spec.rb +4 -4
  1331. data/spec/unit/resource/homebrew_package_spec.rb +13 -13
  1332. data/spec/unit/resource/http_request_spec.rb +5 -5
  1333. data/spec/unit/resource/ifconfig_spec.rb +9 -9
  1334. data/spec/unit/resource/ips_package_spec.rb +4 -4
  1335. data/spec/unit/resource/ksh_spec.rb +2 -2
  1336. data/spec/unit/resource/link_spec.rb +6 -6
  1337. data/spec/unit/resource/log_spec.rb +3 -3
  1338. data/spec/unit/resource/macports_package_spec.rb +3 -3
  1339. data/spec/unit/resource/mdadm_spec.rb +3 -3
  1340. data/spec/unit/resource/mount_spec.rb +7 -7
  1341. data/spec/unit/resource/ohai_spec.rb +2 -3
  1342. data/spec/unit/resource/openbsd_package_spec.rb +5 -6
  1343. data/spec/unit/resource/osx_profile_spec.rb +61 -0
  1344. data/spec/unit/resource/package_spec.rb +6 -6
  1345. data/spec/unit/resource/pacman_package_spec.rb +3 -3
  1346. data/spec/unit/resource/perl_spec.rb +3 -3
  1347. data/spec/unit/resource/portage_package_spec.rb +2 -2
  1348. data/spec/unit/resource/powershell_script_spec.rb +16 -16
  1349. data/spec/unit/resource/python_spec.rb +3 -3
  1350. data/spec/unit/resource/registry_key_spec.rb +21 -21
  1351. data/spec/unit/resource/remote_directory_spec.rb +3 -3
  1352. data/spec/unit/resource/remote_file_spec.rb +15 -15
  1353. data/spec/unit/resource/resource_notification_spec.rb +18 -18
  1354. data/spec/unit/resource/route_spec.rb +3 -3
  1355. data/spec/unit/resource/rpm_package_spec.rb +4 -4
  1356. data/spec/unit/resource/ruby_block_spec.rb +4 -4
  1357. data/spec/unit/resource/ruby_spec.rb +3 -3
  1358. data/spec/unit/resource/scm_spec.rb +8 -8
  1359. data/spec/unit/resource/script_spec.rb +4 -4
  1360. data/spec/unit/resource/service_spec.rb +4 -5
  1361. data/spec/unit/resource/smartos_package_spec.rb +3 -3
  1362. data/spec/unit/resource/solaris_package_spec.rb +3 -3
  1363. data/spec/unit/resource/subversion_spec.rb +5 -5
  1364. data/spec/unit/resource/template_spec.rb +7 -8
  1365. data/spec/unit/resource/timestamped_deploy_spec.rb +4 -4
  1366. data/spec/unit/resource/user_spec.rb +4 -4
  1367. data/spec/unit/resource/windows_package_spec.rb +7 -7
  1368. data/spec/unit/resource/windows_service_spec.rb +3 -3
  1369. data/spec/unit/resource/yum_package_spec.rb +6 -6
  1370. data/spec/unit/resource_collection/resource_list_spec.rb +7 -7
  1371. data/spec/unit/resource_collection/resource_set_spec.rb +9 -9
  1372. data/spec/unit/resource_collection/stepable_iterator_spec.rb +6 -6
  1373. data/spec/unit/resource_collection_spec.rb +8 -9
  1374. data/spec/unit/resource_definition_spec.rb +3 -3
  1375. data/spec/unit/resource_reporter_spec.rb +56 -64
  1376. data/spec/unit/resource_resolver_spec.rb +5 -6
  1377. data/spec/unit/resource_spec.rb +80 -60
  1378. data/spec/unit/rest/auth_credentials_spec.rb +39 -71
  1379. data/spec/unit/rest_spec.rb +96 -90
  1380. data/spec/unit/role_spec.rb +64 -68
  1381. data/spec/unit/run_context/child_run_context_spec.rb +23 -23
  1382. data/spec/unit/run_context/cookbook_compiler_spec.rb +5 -7
  1383. data/spec/unit/run_context_spec.rb +19 -19
  1384. data/spec/unit/run_list/run_list_expansion_spec.rb +24 -24
  1385. data/spec/unit/run_list/run_list_item_spec.rb +28 -28
  1386. data/spec/unit/run_list/versioned_recipe_list_spec.rb +22 -23
  1387. data/spec/unit/run_list_spec.rb +37 -41
  1388. data/spec/unit/run_lock_spec.rb +10 -10
  1389. data/spec/unit/run_status_spec.rb +4 -5
  1390. data/spec/unit/runner_spec.rb +8 -8
  1391. data/spec/unit/scan_access_control_spec.rb +4 -5
  1392. data/spec/unit/search/query_spec.rb +50 -46
  1393. data/spec/unit/shell/model_wrapper_spec.rb +12 -13
  1394. data/spec/unit/shell/shell_ext_spec.rb +5 -5
  1395. data/spec/unit/shell/shell_session_spec.rb +8 -9
  1396. data/spec/unit/shell_out_spec.rb +1 -1
  1397. data/spec/unit/shell_spec.rb +9 -9
  1398. data/spec/unit/user_spec.rb +14 -15
  1399. data/spec/unit/user_v1_spec.rb +22 -23
  1400. data/spec/unit/util/backup_spec.rb +17 -18
  1401. data/spec/unit/util/diff_spec.rb +6 -9
  1402. data/spec/unit/util/dsc/configuration_generator_spec.rb +48 -48
  1403. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +22 -22
  1404. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +30 -31
  1405. data/spec/unit/util/dsc/resource_store.rb +22 -22
  1406. data/spec/unit/util/editor_spec.rb +65 -65
  1407. data/spec/unit/util/file_edit_spec.rb +7 -7
  1408. data/spec/unit/util/powershell/cmdlet_spec.rb +27 -27
  1409. data/spec/unit/util/powershell/ps_credential_spec.rb +13 -13
  1410. data/spec/unit/util/selinux_spec.rb +8 -9
  1411. data/spec/unit/util/threaded_job_queue_spec.rb +2 -2
  1412. data/spec/unit/version/platform_spec.rb +5 -6
  1413. data/spec/unit/version_class_spec.rb +8 -9
  1414. data/spec/unit/version_constraint/platform_spec.rb +3 -4
  1415. data/spec/unit/version_constraint_spec.rb +19 -19
  1416. data/spec/unit/win32/registry_spec.rb +25 -25
  1417. data/spec/unit/windows_service_spec.rb +20 -20
  1418. data/tasks/cbgb.rb +84 -0
  1419. data/tasks/external_tests.rb +12 -11
  1420. data/tasks/maintainers.rb +15 -15
  1421. data/tasks/rspec.rb +18 -15
  1422. metadata +250 -67
  1423. data/lib/chef/chef_fs/file_system/acl_dir.rb +0 -63
  1424. data/lib/chef/chef_fs/file_system/acl_entry.rb +0 -58
  1425. data/lib/chef/chef_fs/file_system/acls_dir.rb +0 -72
  1426. data/lib/chef/chef_fs/file_system/chef_repository_file_system_cookbook_dir.rb +0 -102
  1427. data/lib/chef/chef_fs/file_system/chef_repository_file_system_cookbook_entry.rb +0 -80
  1428. data/lib/chef/chef_fs/file_system/chef_repository_file_system_cookbooks_dir.rb +0 -82
  1429. data/lib/chef/chef_fs/file_system/chef_repository_file_system_entry.rb +0 -81
  1430. data/lib/chef/chef_fs/file_system/chef_repository_file_system_root_dir.rb +0 -196
  1431. data/lib/chef/chef_fs/file_system/chef_server_root_dir.rb +0 -165
  1432. data/lib/chef/chef_fs/file_system/cookbook_dir.rb +0 -224
  1433. data/lib/chef/chef_fs/file_system/cookbook_file.rb +0 -82
  1434. data/lib/chef/chef_fs/file_system/cookbook_subdir.rb +0 -59
  1435. data/lib/chef/chef_fs/file_system/cookbooks_acl_dir.rb +0 -41
  1436. data/lib/chef/chef_fs/file_system/cookbooks_dir.rb +0 -156
  1437. data/lib/chef/chef_fs/file_system/data_bag_dir.rb +0 -69
  1438. data/lib/chef/chef_fs/file_system/data_bags_dir.rb +0 -71
  1439. data/lib/chef/chef_fs/file_system/environments_dir.rb +0 -60
  1440. data/lib/chef/chef_fs/file_system/file_system_entry.rb +0 -115
  1441. data/lib/chef/chef_fs/file_system/memory_dir.rb +0 -51
  1442. data/lib/chef/chef_fs/file_system/memory_file.rb +0 -17
  1443. data/lib/chef/chef_fs/file_system/memory_root.rb +0 -21
  1444. data/lib/chef/chef_fs/file_system/nodes_dir.rb +0 -55
  1445. data/lib/chef/chef_fs/file_system/org_entry.rb +0 -34
  1446. data/lib/chef/chef_fs/file_system/organization_invites_entry.rb +0 -59
  1447. data/lib/chef/chef_fs/file_system/organization_members_entry.rb +0 -58
  1448. data/lib/chef/chef_fs/file_system/rest_list_dir.rb +0 -110
  1449. data/lib/chef/chef_fs/file_system/rest_list_entry.rb +0 -185
@@ -1,6 +1,6 @@
1
1
  #
2
- # Author:: Daniel DeLeo (<dan@opscode.com>)
3
- # Copyright:: Copyright (c) 2010 Opscode, Inc.
2
+ # Author:: Daniel DeLeo (<dan@chef.io>)
3
+ # Copyright:: Copyright 2010-2016, Chef Software Inc.
4
4
  # License:: Apache License, Version 2.0
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,8 +16,8 @@
16
16
  # limitations under the License.
17
17
  #
18
18
 
19
- require 'spec_helper'
20
- require 'tiny_server'
19
+ require "spec_helper"
20
+ require "tiny_server"
21
21
 
22
22
  describe TinyServer::API do
23
23
  before do
@@ -26,39 +26,39 @@ describe TinyServer::API do
26
26
  end
27
27
 
28
28
  it "is a Singleton" do
29
- expect {TinyServer::API.new}.to raise_error
29
+ expect { TinyServer::API.new }.to raise_error
30
30
  end
31
31
 
32
32
  it "clears the router" do
33
- @api.get('/blargh', 200, "blargh")
33
+ @api.get("/blargh", 200, "blargh")
34
34
  @api.clear
35
35
  expect(@api.routes["GET"]).to be_empty
36
36
  end
37
37
 
38
38
  it "creates a route for a GET request" do
39
- @api.get('/foo/bar', 200, 'hello foobar')
39
+ @api.get("/foo/bar", 200, "hello foobar")
40
40
  # WEBrick gives you the full URI with host, Thin only gave the part after scheme+host+port
41
- response = @api.call("REQUEST_METHOD" => "GET", "REQUEST_URI" => 'http://localhost:1974/foo/bar')
42
- expect(response).to eq([200, {'Content-Type' => 'application/json'}, [ 'hello foobar' ]])
41
+ response = @api.call("REQUEST_METHOD" => "GET", "REQUEST_URI" => "http://localhost:1974/foo/bar")
42
+ expect(response).to eq([200, { "Content-Type" => "application/json" }, [ "hello foobar" ]])
43
43
  end
44
44
 
45
45
  it "creates a route for a request with a block" do
46
46
  block_called = false
47
- @api.get('/bar/baz', 200) { block_called = true; 'hello barbaz' }
48
- response = @api.call("REQUEST_METHOD" => "GET", "REQUEST_URI" => 'http://localhost:1974/bar/baz')
49
- expect(response).to eq([200, {'Content-Type' => 'application/json'}, [ 'hello barbaz' ]])
47
+ @api.get("/bar/baz", 200) { block_called = true; "hello barbaz" }
48
+ response = @api.call("REQUEST_METHOD" => "GET", "REQUEST_URI" => "http://localhost:1974/bar/baz")
49
+ expect(response).to eq([200, { "Content-Type" => "application/json" }, [ "hello barbaz" ]])
50
50
  expect(block_called).to be_truthy
51
51
  end
52
52
 
53
53
  it "returns debugging info for 404s" do
54
- response = @api.call("REQUEST_METHOD" => "GET", "REQUEST_URI" => '/no_such_thing')
54
+ response = @api.call("REQUEST_METHOD" => "GET", "REQUEST_URI" => "/no_such_thing")
55
55
  expect(response[0]).to eq(404)
56
- expect(response[1]).to eq({'Content-Type' => 'application/json'})
56
+ expect(response[1]).to eq({ "Content-Type" => "application/json" })
57
57
  expect(response[2]).to be_a_kind_of(Array)
58
58
  response_obj = Chef::JSONCompat.from_json(response[2].first)
59
59
  expect(response_obj["message"]).to eq("no data matches the request for /no_such_thing")
60
- expect(response_obj["available_routes"]).to eq({"GET"=>[], "PUT"=>[], "POST"=>[], "DELETE"=>[]})
61
- expect(response_obj["request"]).to eq({"REQUEST_METHOD"=>"GET", "REQUEST_URI"=>"/no_such_thing"})
60
+ expect(response_obj["available_routes"]).to eq({ "GET" => [], "PUT" => [], "POST" => [], "DELETE" => [] })
61
+ expect(response_obj["request"]).to eq({ "REQUEST_METHOD" => "GET", "REQUEST_URI" => "/no_such_thing" })
62
62
  end
63
63
 
64
64
  end
@@ -70,8 +70,8 @@ describe TinyServer::Manager do
70
70
 
71
71
  TinyServer::API.instance.get("/index", 200, "[\"hello\"]")
72
72
 
73
- rest = Chef::REST.new('http://localhost:9000', false, false)
74
- expect(rest.get_rest("index")).to eq(["hello"])
73
+ rest = Chef::HTTP.new("http://localhost:9000")
74
+ expect(rest.get("index")).to eq("[\"hello\"]")
75
75
 
76
76
  @server.stop
77
77
  end
@@ -1,5 +1,5 @@
1
1
  #
2
- # Copyright:: Copyright (c) 2014 Chef Software, Inc.
2
+ # Copyright:: Copyright 2014-2016, Chef Software, Inc.
3
3
  # License:: Apache License, Version 2.0
4
4
  #
5
5
  # Licensed under the Apache License, Version 2.0 (the "License");
@@ -14,9 +14,9 @@
14
14
  # See the License for the specific language governing permissions and
15
15
  # limitations under the License.
16
16
 
17
- require 'tmpdir'
18
- require 'chef/util/path_helper'
19
- require 'spec_helper'
17
+ require "tmpdir"
18
+ require "chef/util/path_helper"
19
+ require "spec_helper"
20
20
 
21
21
  describe Chef::Util::PathHelper, "escape_glob" do
22
22
  PathHelper = Chef::Util::PathHelper
@@ -27,7 +27,7 @@ describe Chef::Util::PathHelper, "escape_glob" do
27
27
  # add some files
28
28
  files = ["some.rb", "file.txt", "names.csv"]
29
29
  files.each do |file|
30
- File.new(File.join(dir, file), 'w').close
30
+ File.new(File.join(dir, file), "w").close
31
31
  end
32
32
 
33
33
  pattern = File.join(PathHelper.escape_glob(dir), "*")
@@ -1,7 +1,7 @@
1
1
  #
2
- # Author:: Adam Edwards (<adamed@getchef.com>)
2
+ # Author:: Adam Edwards (<adamed@chef.io>)
3
3
  #
4
- # Copyright:: 2014, Chef Software, Inc.
4
+ # Copyright:: Copyright 2014-2016, Chef Software, Inc.
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -16,24 +16,21 @@
16
16
  # limitations under the License.
17
17
  #
18
18
 
19
- require 'chef/json_compat'
20
- require File.expand_path('../../../../spec_helper', __FILE__)
19
+ require "chef/json_compat"
20
+ require File.expand_path("../../../../spec_helper", __FILE__)
21
21
 
22
- describe Chef::Util::Powershell::Cmdlet, :windows_powershell_dsc_only do
22
+ describe Chef::Util::Powershell::Cmdlet, :windows_powershell_dsc_only do
23
23
  before(:all) do
24
- ohai = Ohai::System.new
25
- ohai.load_plugins
26
- ohai.run_plugins(true, ['platform', 'kernel'])
27
24
  @node = Chef::Node.new
28
- @node.consume_external_attrs(ohai.data, {})
25
+ @node.consume_external_attrs(OHAI_SYSTEM.data, {})
29
26
  end
30
27
  let(:cmd_output_format) { :text }
31
- let(:simple_cmdlet) { Chef::Util::Powershell::Cmdlet.new(@node, 'get-childitem', cmd_output_format, {:depth => 2}) }
32
- let(:invalid_cmdlet) { Chef::Util::Powershell::Cmdlet.new(@node, 'get-idontexist', cmd_output_format) }
33
- let(:cmdlet_get_item_requires_switch_or_argument) { Chef::Util::Powershell::Cmdlet.new(@node, 'get-item', cmd_output_format, {:depth => 2}) }
34
- let(:cmdlet_alias_requires_switch_or_argument) { Chef::Util::Powershell::Cmdlet.new(@node, 'alias', cmd_output_format, {:depth => 2}) }
28
+ let(:simple_cmdlet) { Chef::Util::Powershell::Cmdlet.new(@node, "get-childitem", cmd_output_format, { :depth => 2 }) }
29
+ let(:invalid_cmdlet) { Chef::Util::Powershell::Cmdlet.new(@node, "get-idontexist", cmd_output_format) }
30
+ let(:cmdlet_get_item_requires_switch_or_argument) { Chef::Util::Powershell::Cmdlet.new(@node, "get-item", cmd_output_format, { :depth => 2 }) }
31
+ let(:cmdlet_alias_requires_switch_or_argument) { Chef::Util::Powershell::Cmdlet.new(@node, "alias", cmd_output_format, { :depth => 2 }) }
35
32
  let(:etc_directory) { "#{ENV['systemroot']}\\system32\\drivers\\etc" }
36
- let(:architecture_cmdlet) { Chef::Util::Powershell::Cmdlet.new(@node, "$env:PROCESSOR_ARCHITECTURE")}
33
+ let(:architecture_cmdlet) { Chef::Util::Powershell::Cmdlet.new(@node, "$env:PROCESSOR_ARCHITECTURE") }
37
34
 
38
35
  it "executes a simple process" do
39
36
  result = simple_cmdlet.run
@@ -41,17 +38,17 @@ describe Chef::Util::Powershell::Cmdlet, :windows_powershell_dsc_only do
41
38
  end
42
39
 
43
40
  it "#run does not raise a PowershellCmdletException exception if the command cannot be executed" do
44
- expect {invalid_cmdlet.run}.not_to raise_error
41
+ expect { invalid_cmdlet.run }.not_to raise_error
45
42
  end
46
43
 
47
44
  it "#run! raises a PowershellCmdletException exception if the command cannot be executed" do
48
- expect {invalid_cmdlet.run!}.to raise_error(Chef::Exceptions::PowershellCmdletException)
45
+ expect { invalid_cmdlet.run! }.to raise_error(Chef::Exceptions::PowershellCmdletException)
49
46
  end
50
47
 
51
48
  it "executes a 64-bit command on a 64-bit OS, 32-bit otherwise" do
52
- os_arch = ENV['PROCESSOR_ARCHITEW6432']
49
+ os_arch = ENV["PROCESSOR_ARCHITEW6432"]
53
50
  if os_arch.nil?
54
- os_arch = ENV['PROCESSOR_ARCHITECTURE']
51
+ os_arch = ENV["PROCESSOR_ARCHITECTURE"]
55
52
  end
56
53
 
57
54
  result = architecture_cmdlet.run
@@ -61,17 +58,17 @@ describe Chef::Util::Powershell::Cmdlet, :windows_powershell_dsc_only do
61
58
  end
62
59
 
63
60
  it "passes command line switches to the command" do
64
- result = cmdlet_alias_requires_switch_or_argument.run({:name => 'ls'})
61
+ result = cmdlet_alias_requires_switch_or_argument.run({ :name => "ls" })
65
62
  expect(result.succeeded?).to eq(true)
66
63
  end
67
64
 
68
65
  it "passes command line arguments to the command" do
69
- result = cmdlet_alias_requires_switch_or_argument.run({},{},'ls')
66
+ result = cmdlet_alias_requires_switch_or_argument.run({}, {}, "ls")
70
67
  expect(result.succeeded?).to eq(true)
71
68
  end
72
69
 
73
70
  it "passes command line arguments and switches to the command" do
74
- result = cmdlet_get_item_requires_switch_or_argument.run({:path => etc_directory},{},' | select-object -property fullname | format-table -hidetableheaders')
71
+ result = cmdlet_get_item_requires_switch_or_argument.run({ :path => etc_directory }, {}, " | select-object -property fullname | format-table -hidetableheaders")
75
72
  expect(result.succeeded?).to eq(true)
76
73
  returned_directory = result.return_value
77
74
  returned_directory.strip!
@@ -79,7 +76,7 @@ describe Chef::Util::Powershell::Cmdlet, :windows_powershell_dsc_only do
79
76
  end
80
77
 
81
78
  it "passes execution options to the command" do
82
- result = cmdlet_get_item_requires_switch_or_argument.run({},{:cwd => etc_directory},'. | select-object -property fullname | format-table -hidetableheaders')
79
+ result = cmdlet_get_item_requires_switch_or_argument.run({}, { :cwd => etc_directory }, ". | select-object -property fullname | format-table -hidetableheaders")
83
80
  expect(result.succeeded?).to eq(true)
84
81
  returned_directory = result.return_value
85
82
  returned_directory.strip!
@@ -89,26 +86,26 @@ describe Chef::Util::Powershell::Cmdlet, :windows_powershell_dsc_only do
89
86
  context "when returning json" do
90
87
  let(:cmd_output_format) { :json }
91
88
  it "returns json format data" do
92
- result = cmdlet_alias_requires_switch_or_argument.run({},{},'ls')
89
+ result = cmdlet_alias_requires_switch_or_argument.run({}, {}, "ls")
93
90
  expect(result.succeeded?).to eq(true)
94
- expect(lambda{Chef::JSONCompat.parse(result.return_value)}).not_to raise_error
91
+ expect(lambda { Chef::JSONCompat.parse(result.return_value) }).not_to raise_error
95
92
  end
96
93
  end
97
94
 
98
95
  context "when returning Ruby objects" do
99
96
  let(:cmd_output_format) { :object }
100
97
  it "returns object format data" do
101
- result = simple_cmdlet.run({},{:cwd => etc_directory}, 'hosts')
98
+ result = simple_cmdlet.run({}, { :cwd => etc_directory }, "hosts")
102
99
  expect(result.succeeded?).to eq(true)
103
100
  data = result.return_value
104
- expect(data['Name']).to eq('hosts')
101
+ expect(data["Name"]).to eq("hosts")
105
102
  end
106
103
  end
107
104
 
108
105
  context "when constructor is given invalid arguments" do
109
106
  let(:cmd_output_format) { :invalid }
110
107
  it "throws an exception if an invalid format is passed to the constructor" do
111
- expect(lambda{simple_cmdlet}).to raise_error
108
+ expect(lambda { simple_cmdlet }).to raise_error
112
109
  end
113
110
  end
114
111
  end
@@ -1,6 +1,6 @@
1
1
  #
2
- # Author:: Serdar Sutay (<dan@opscode.com>)
3
- # Copyright:: Copyright (c) 2013 Opscode, Inc.
2
+ # Author:: Serdar Sutay (<dan@chef.io>)
3
+ # Copyright:: Copyright 2013-2016, Chef Software Inc.
4
4
  # License:: Apache License, Version 2.0
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
@@ -15,10 +15,10 @@
15
15
  # See the License for the specific language governing permissions and
16
16
  # limitations under the License.
17
17
 
18
- require File.expand_path('../../spec_helper', __FILE__)
19
- require 'chef/mixin/shell_out'
20
- require 'chef/version'
21
- require 'ohai/version'
18
+ require File.expand_path("../../spec_helper", __FILE__)
19
+ require "chef/mixin/shell_out"
20
+ require "chef/version"
21
+ require "ohai/version"
22
22
 
23
23
  describe "Chef Versions" do
24
24
  include Chef::Mixin::ShellOut
@@ -1,6 +1,6 @@
1
1
  #
2
2
  # Author:: Jay Mundrawala(<jdm@chef.io>)
3
- # Copyright:: Copyright (c) 2015 Chef Software, Inc.
3
+ # Copyright:: Copyright 2015-2016, Chef Software, Inc.
4
4
  # License:: Apache License, Version 2.0
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,28 +16,25 @@
16
16
  # limitations under the License.
17
17
  #
18
18
 
19
- require 'spec_helper'
19
+ require "spec_helper"
20
20
  if Chef::Platform.windows?
21
- require 'chef/win32/crypto'
21
+ require "chef/win32/crypto"
22
22
  end
23
23
 
24
- describe 'Chef::ReservedNames::Win32::Crypto', :windows_only do
24
+ describe "Chef::ReservedNames::Win32::Crypto", :windows_only do
25
25
  describe '#encrypt' do
26
26
  before(:all) do
27
- ohai_reader = Ohai::System.new
28
- ohai_reader.all_plugins("platform")
29
-
30
27
  new_node = Chef::Node.new
31
- new_node.consume_external_attrs(ohai_reader.data,{})
28
+ new_node.consume_external_attrs(OHAI_SYSTEM.data, {})
32
29
 
33
30
  events = Chef::EventDispatch::Dispatcher.new
34
31
 
35
32
  @run_context = Chef::RunContext.new(new_node, {}, events)
36
33
  end
37
34
 
38
- let (:plaintext) { 'p@assword' }
35
+ let (:plaintext) { "p@assword" }
39
36
 
40
- it 'can be decrypted by powershell' do
37
+ it "can be decrypted by powershell" do
41
38
  encrypted = Chef::ReservedNames::Win32::Crypto.encrypt(plaintext)
42
39
  resource = Chef::Resource::WindowsScript::PowershellScript.new("Powershell resource functional test", @run_context)
43
40
  resource.code <<-EOF
@@ -1,7 +1,7 @@
1
1
  #
2
- # Author:: Prajakta Purohit (<prajakta@opscode.com>)
3
- # Author:: Lamont Granquist (<lamont@opscode.com>)
4
- # Copyright:: Copyright (c) 2012 Opscode, Inc.
2
+ # Author:: Prajakta Purohit (<prajakta@chef.io>)
3
+ # Author:: Lamont Granquist (<lamont@chef.io>)
4
+ # Copyright:: Copyright 2012-2016, Chef Software Inc.
5
5
  # License:: Apache License, Version 2.0
6
6
  #
7
7
  # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,10 +17,10 @@
17
17
  # limitations under the License.
18
18
  #
19
19
 
20
- require 'spec_helper'
21
- require 'chef/win32/registry'
20
+ require "spec_helper"
21
+ require "chef/win32/registry"
22
22
 
23
- describe 'Chef::Win32::Registry', :windows_only do
23
+ describe "Chef::Win32::Registry", :windows_only do
24
24
 
25
25
  before(:all) do
26
26
  #Create a registry item
@@ -28,22 +28,20 @@ describe 'Chef::Win32::Registry', :windows_only do
28
28
  ::Win32::Registry::HKEY_CURRENT_USER.create "Software\\Root\\Branch"
29
29
  ::Win32::Registry::HKEY_CURRENT_USER.create "Software\\Root\\Branch\\Flower"
30
30
  ::Win32::Registry::HKEY_CURRENT_USER.open('Software\\Root', Win32::Registry::KEY_ALL_ACCESS) do |reg|
31
- reg['RootType1', Win32::Registry::REG_SZ] = 'fibrous'
32
- reg.write('Roots', Win32::Registry::REG_MULTI_SZ, ["strong roots", "healthy tree"])
31
+ reg["RootType1", Win32::Registry::REG_SZ] = "fibrous"
32
+ reg.write("Roots", Win32::Registry::REG_MULTI_SZ, ["strong roots", "healthy tree"])
33
33
  end
34
34
  ::Win32::Registry::HKEY_CURRENT_USER.open('Software\\Root\\Branch', Win32::Registry::KEY_ALL_ACCESS) do |reg|
35
- reg['Strong', Win32::Registry::REG_SZ] = 'bird nest'
35
+ reg["Strong", Win32::Registry::REG_SZ] = "bird nest"
36
36
  end
37
37
  ::Win32::Registry::HKEY_CURRENT_USER.open('Software\\Root\\Branch\\Flower', Win32::Registry::KEY_ALL_ACCESS) do |reg|
38
- reg['Petals', Win32::Registry::REG_MULTI_SZ] = ["Pink", "Delicate"]
38
+ reg["Petals", Win32::Registry::REG_MULTI_SZ] = ["Pink", "Delicate"]
39
39
  end
40
40
 
41
41
  #Create the node with ohai data
42
42
  events = Chef::EventDispatch::Dispatcher.new
43
43
  @node = Chef::Node.new
44
- ohai = Ohai::System.new
45
- ohai.all_plugins
46
- @node.consume_external_attrs(ohai.data,{})
44
+ @node.consume_external_attrs(OHAI_SYSTEM.data, {})
47
45
  @run_context = Chef::RunContext.new(@node, {}, events)
48
46
 
49
47
  #Create a registry object that has access ot the node previously created
@@ -83,7 +81,7 @@ describe 'Chef::Win32::Registry', :windows_only do
83
81
  end
84
82
 
85
83
  it "throws an exception if the hive does not exist" do
86
- expect {@registry.key_exists?("JKLM\\Software\\Branch\\Flower")}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
84
+ expect { @registry.key_exists?("JKLM\\Software\\Branch\\Flower") }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
87
85
  end
88
86
  end
89
87
 
@@ -93,95 +91,95 @@ describe 'Chef::Win32::Registry', :windows_only do
93
91
  end
94
92
 
95
93
  it "throws an exception if the key path does not exist" do
96
- expect {@registry.key_exists!("HKCU\\Software\\Branch\\Flower")}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
94
+ expect { @registry.key_exists!("HKCU\\Software\\Branch\\Flower") }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
97
95
  end
98
96
 
99
97
  it "throws an exception if the hive does not exist" do
100
- expect {@registry.key_exists!("JKLM\\Software\\Branch\\Flower")}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
98
+ expect { @registry.key_exists!("JKLM\\Software\\Branch\\Flower") }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
101
99
  end
102
100
  end
103
101
 
104
102
  describe "value_exists?" do
105
103
  it "throws an exception if the hive does not exist" do
106
- expect {@registry.value_exists?("JKLM\\Software\\Branch\\Flower", {:name=>"Petals"})}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
104
+ expect { @registry.value_exists?("JKLM\\Software\\Branch\\Flower", { :name => "Petals" }) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
107
105
  end
108
106
  it "throws an exception if the key does not exist" do
109
- expect {@registry.value_exists?("HKCU\\Software\\Branch\\Flower", {:name=>"Petals"})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
107
+ expect { @registry.value_exists?("HKCU\\Software\\Branch\\Flower", { :name => "Petals" }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
110
108
  end
111
109
  it "returns true if the value exists" do
112
- expect(@registry.value_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals"})).to eq(true)
110
+ expect(@registry.value_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals" })).to eq(true)
113
111
  end
114
112
  it "returns true if the value exists with a case mismatch on the value name" do
115
- expect(@registry.value_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"petals"})).to eq(true)
113
+ expect(@registry.value_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "petals" })).to eq(true)
116
114
  end
117
115
  it "returns false if the value does not exist" do
118
- expect(@registry.value_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"FOOBAR"})).to eq(false)
116
+ expect(@registry.value_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "FOOBAR" })).to eq(false)
119
117
  end
120
118
  end
121
119
 
122
120
  describe "value_exists!" do
123
121
  it "throws an exception if the hive does not exist" do
124
- expect {@registry.value_exists!("JKLM\\Software\\Branch\\Flower", {:name=>"Petals"})}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
122
+ expect { @registry.value_exists!("JKLM\\Software\\Branch\\Flower", { :name => "Petals" }) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
125
123
  end
126
124
  it "throws an exception if the key does not exist" do
127
- expect {@registry.value_exists!("HKCU\\Software\\Branch\\Flower", {:name=>"Petals"})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
125
+ expect { @registry.value_exists!("HKCU\\Software\\Branch\\Flower", { :name => "Petals" }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
128
126
  end
129
127
  it "returns true if the value exists" do
130
- expect(@registry.value_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals"})).to eq(true)
128
+ expect(@registry.value_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals" })).to eq(true)
131
129
  end
132
130
  it "returns true if the value exists with a case mismatch on the value name" do
133
- expect(@registry.value_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"petals"})).to eq(true)
131
+ expect(@registry.value_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "petals" })).to eq(true)
134
132
  end
135
133
  it "throws an exception if the value does not exist" do
136
- expect {@registry.value_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"FOOBAR"})}.to raise_error(Chef::Exceptions::Win32RegValueMissing)
134
+ expect { @registry.value_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "FOOBAR" }) }.to raise_error(Chef::Exceptions::Win32RegValueMissing)
137
135
  end
138
136
  end
139
137
 
140
138
  describe "data_exists?" do
141
139
  it "throws an exception if the hive does not exist" do
142
- expect {@registry.data_exists?("JKLM\\Software\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
140
+ expect { @registry.data_exists?("JKLM\\Software\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Pink", "Delicate"] }) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
143
141
  end
144
142
  it "throws an exception if the key does not exist" do
145
- expect {@registry.data_exists?("HKCU\\Software\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
143
+ expect { @registry.data_exists?("HKCU\\Software\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Pink", "Delicate"] }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
146
144
  end
147
145
  it "returns true if all the data matches" do
148
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})).to eq(true)
146
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Pink", "Delicate"] })).to eq(true)
149
147
  end
150
148
  it "returns true if all the data matches with a case mismatch on the data name" do
151
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})).to eq(true)
149
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "petals", :type => :multi_string, :data => ["Pink", "Delicate"] })).to eq(true)
152
150
  end
153
151
  it "returns false if the name does not exist" do
154
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"slateP", :type=>:multi_string, :data=>["Pink", "Delicate"]})).to eq(false)
152
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "slateP", :type => :multi_string, :data => ["Pink", "Delicate"] })).to eq(false)
155
153
  end
156
154
  it "returns false if the types do not match" do
157
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:string, :data=>"Pink"})).to eq(false)
155
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :string, :data => "Pink" })).to eq(false)
158
156
  end
159
157
  it "returns false if the data does not match" do
160
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Mauve", "Delicate"]})).to eq(false)
158
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Mauve", "Delicate"] })).to eq(false)
161
159
  end
162
160
  end
163
161
 
164
162
  describe "data_exists!" do
165
163
  it "throws an exception if the hive does not exist" do
166
- expect {@registry.data_exists!("JKLM\\Software\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
164
+ expect { @registry.data_exists!("JKLM\\Software\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Pink", "Delicate"] }) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
167
165
  end
168
166
  it "throws an exception if the key does not exist" do
169
- expect {@registry.data_exists!("HKCU\\Software\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
167
+ expect { @registry.data_exists!("HKCU\\Software\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Pink", "Delicate"] }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
170
168
  end
171
169
  it "returns true if all the data matches" do
172
- expect(@registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})).to eq(true)
170
+ expect(@registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Pink", "Delicate"] })).to eq(true)
173
171
  end
174
172
  it "returns true if all the data matches with a case mismatch on the data name" do
175
- expect(@registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"petals", :type=>:multi_string, :data=>["Pink", "Delicate"]})).to eq(true)
173
+ expect(@registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "petals", :type => :multi_string, :data => ["Pink", "Delicate"] })).to eq(true)
176
174
  end
177
175
  it "throws an exception if the name does not exist" do
178
- expect {@registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"slateP", :type=>:multi_string, :data=>["Pink", "Delicate"]})}.to raise_error(Chef::Exceptions::Win32RegDataMissing)
176
+ expect { @registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "slateP", :type => :multi_string, :data => ["Pink", "Delicate"] }) }.to raise_error(Chef::Exceptions::Win32RegDataMissing)
179
177
  end
180
178
  it "throws an exception if the types do not match" do
181
- expect {@registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:string, :data=>"Pink"})}.to raise_error(Chef::Exceptions::Win32RegDataMissing)
179
+ expect { @registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :string, :data => "Pink" }) }.to raise_error(Chef::Exceptions::Win32RegDataMissing)
182
180
  end
183
181
  it "throws an exception if the data does not match" do
184
- expect {@registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Mauve", "Delicate"]})}.to raise_error(Chef::Exceptions::Win32RegDataMissing)
182
+ expect { @registry.data_exists!("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Mauve", "Delicate"] }) }.to raise_error(Chef::Exceptions::Win32RegDataMissing)
185
183
  end
186
184
  end
187
185
 
@@ -189,85 +187,85 @@ describe 'Chef::Win32::Registry', :windows_only do
189
187
  it "returns all values for a key if it exists" do
190
188
  values = @registry.get_values("HKCU\\Software\\Root")
191
189
  expect(values).to be_an_instance_of Array
192
- expect(values).to eq([{:name=>"RootType1", :type=>:string, :data=>"fibrous"},
193
- {:name=>"Roots", :type=>:multi_string, :data=>["strong roots", "healthy tree"]}])
190
+ expect(values).to eq([{ :name => "RootType1", :type => :string, :data => "fibrous" },
191
+ { :name => "Roots", :type => :multi_string, :data => ["strong roots", "healthy tree"] }])
194
192
  end
195
193
 
196
194
  it "throws an exception if the key does not exist" do
197
- expect {@registry.get_values("HKCU\\Software\\Branch\\Flower")}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
195
+ expect { @registry.get_values("HKCU\\Software\\Branch\\Flower") }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
198
196
  end
199
197
 
200
198
  it "throws an exception if the hive does not exist" do
201
- expect {@registry.get_values("JKLM\\Software\\Branch\\Flower")}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
199
+ expect { @registry.get_values("JKLM\\Software\\Branch\\Flower") }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
202
200
  end
203
201
  end
204
202
 
205
203
  describe "set_value" do
206
204
  it "updates a value if the key, value exist and type matches and value different" do
207
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})).to eq(true)
208
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})).to eq(true)
205
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Yellow", "Changed Color"] })).to eq(true)
206
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Yellow", "Changed Color"] })).to eq(true)
209
207
  end
210
208
 
211
209
  it "updates a value if the type does match and the values are different" do
212
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:string, :data=>"Yellow"})).to eq(true)
213
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:string, :data=>"Yellow"})).to eq(true)
214
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})).to eq(false)
210
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :string, :data => "Yellow" })).to eq(true)
211
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :string, :data => "Yellow" })).to eq(true)
212
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Yellow", "Changed Color"] })).to eq(false)
215
213
  end
216
214
 
217
215
  it "creates a value if key exists and value does not" do
218
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Stamen", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})).to eq(true)
219
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Stamen", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})).to eq(true)
216
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Stamen", :type => :multi_string, :data => ["Yellow", "Changed Color"] })).to eq(true)
217
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Stamen", :type => :multi_string, :data => ["Yellow", "Changed Color"] })).to eq(true)
220
218
  end
221
219
 
222
220
  it "does nothing if data,type and name parameters for the value are same" do
223
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Stamen", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})).to eq(false)
224
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"Stamen", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})).to eq(true)
221
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Stamen", :type => :multi_string, :data => ["Yellow", "Changed Color"] })).to eq(false)
222
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "Stamen", :type => :multi_string, :data => ["Yellow", "Changed Color"] })).to eq(true)
225
223
  end
226
224
 
227
225
  it "throws an exception if the key does not exist" do
228
- expect {@registry.set_value("HKCU\\Software\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
226
+ expect { @registry.set_value("HKCU\\Software\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Yellow", "Changed Color"] }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
229
227
  end
230
228
 
231
229
  it "throws an exception if the hive does not exist" do
232
- expect {@registry.set_value("JKLM\\Software\\Root\\Branch\\Flower", {:name=>"Petals", :type=>:multi_string, :data=>["Yellow", "Changed Color"]})}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
230
+ expect { @registry.set_value("JKLM\\Software\\Root\\Branch\\Flower", { :name => "Petals", :type => :multi_string, :data => ["Yellow", "Changed Color"] }) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
233
231
  end
234
232
 
235
233
  # we are validating that the data gets .to_i called on it when type is a :dword
236
234
 
237
235
  it "casts an integer string given as a dword into an integer" do
238
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBe32767", :type=>:dword, :data=>"32767"})).to eq(true)
239
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBe32767", :type=>:dword, :data=>32767})).to eq(true)
236
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBe32767", :type => :dword, :data => "32767" })).to eq(true)
237
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBe32767", :type => :dword, :data => 32767 })).to eq(true)
240
238
  end
241
239
 
242
240
  it "casts a nonsense string given as a dword into zero" do
243
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBeZero", :type=>:dword, :data=>"whatdoesthisdo"})).to eq(true)
244
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBeZero", :type=>:dword, :data=>0})).to eq(true)
241
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBeZero", :type => :dword, :data => "whatdoesthisdo" })).to eq(true)
242
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBeZero", :type => :dword, :data => 0 })).to eq(true)
245
243
  end
246
244
 
247
245
  it "throws an exception when trying to cast an array to an int for a dword" do
248
- expect {@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldThrow", :type=>:dword, :data=>["one","two"]})}.to raise_error
246
+ expect { @registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldThrow", :type => :dword, :data => ["one", "two"] }) }.to raise_error
249
247
  end
250
248
 
251
249
  # we are validating that the data gets .to_s called on it when type is a :string
252
250
 
253
251
  it "stores the string representation of an array into a string if you pass it an array" do
254
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBePainful", :type=>:string, :data=>["one","two"]})).to eq(true)
255
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBePainful", :type=>:string, :data=>'["one", "two"]'})).to eq(true)
252
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBePainful", :type => :string, :data => ["one", "two"] })).to eq(true)
253
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBePainful", :type => :string, :data => '["one", "two"]' })).to eq(true)
256
254
  end
257
255
 
258
256
  it "stores the string representation of a number into a string if you pass it an number" do
259
- expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBe65535", :type=>:string, :data=>65535})).to eq(true)
260
- expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBe65535", :type=>:string, :data=>"65535"})).to eq(true)
257
+ expect(@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBe65535", :type => :string, :data => 65535 })).to eq(true)
258
+ expect(@registry.data_exists?("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBe65535", :type => :string, :data => "65535" })).to eq(true)
261
259
  end
262
260
 
263
261
  # we are validating that the data gets .to_a called on it when type is a :multi_string
264
262
 
265
263
  it "throws an exception when a multi-string is passed a number" do
266
- expect {@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldThrow", :type=>:multi_string, :data=>65535})}.to raise_error
264
+ expect { @registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldThrow", :type => :multi_string, :data => 65535 }) }.to raise_error
267
265
  end
268
266
 
269
267
  it "throws an exception when a multi-string is passed a string" do
270
- expect {@registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", {:name=>"ShouldBeWat", :type=>:multi_string, :data=>"foo"})}.to raise_error
268
+ expect { @registry.set_value("HKCU\\Software\\Root\\Branch\\Flower", { :name => "ShouldBeWat", :type => :multi_string, :data => "foo" }) }.to raise_error
271
269
  end
272
270
  end
273
271
 
@@ -282,7 +280,7 @@ describe 'Chef::Win32::Registry', :windows_only do
282
280
  end
283
281
 
284
282
  it "throws an exception if the path has missing keys but recursive set to false" do
285
- expect {@registry.create_key("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", false)}.to raise_error(Chef::Exceptions::Win32RegNoRecursive)
283
+ expect { @registry.create_key("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", false) }.to raise_error(Chef::Exceptions::Win32RegNoRecursive)
286
284
  expect(@registry.key_exists?("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker")).to eq(false)
287
285
  end
288
286
 
@@ -297,7 +295,7 @@ describe 'Chef::Win32::Registry', :windows_only do
297
295
  end
298
296
 
299
297
  it "throws an exception of the hive does not exist" do
300
- expect {@registry.create_key("JKLM\\Software\\Root\\Trunk\\Peck\\Woodpecker", false)}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
298
+ expect { @registry.create_key("JKLM\\Software\\Root\\Trunk\\Peck\\Woodpecker", false) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
301
299
  end
302
300
  end
303
301
 
@@ -305,26 +303,26 @@ describe 'Chef::Win32::Registry', :windows_only do
305
303
  before(:all) do
306
304
  ::Win32::Registry::HKEY_CURRENT_USER.create "Software\\Root\\Trunk\\Peck\\Woodpecker"
307
305
  ::Win32::Registry::HKEY_CURRENT_USER.open('Software\\Root\\Trunk\\Peck\\Woodpecker', Win32::Registry::KEY_ALL_ACCESS) do |reg|
308
- reg['Peter', Win32::Registry::REG_SZ] = 'Tiny'
306
+ reg["Peter", Win32::Registry::REG_SZ] = "Tiny"
309
307
  end
310
308
  end
311
309
 
312
310
  it "deletes values if the value exists" do
313
- expect(@registry.delete_value("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", {:name=>"Peter", :type=>:string, :data=>"Tiny"})).to eq(true)
314
- expect(@registry.value_exists?("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", {:name=>"Peter", :type=>:string, :data=>"Tiny"})).to eq(false)
311
+ expect(@registry.delete_value("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", { :name => "Peter", :type => :string, :data => "Tiny" })).to eq(true)
312
+ expect(@registry.value_exists?("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", { :name => "Peter", :type => :string, :data => "Tiny" })).to eq(false)
315
313
  end
316
314
 
317
315
  it "does nothing if value does not exist" do
318
- expect(@registry.delete_value("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", {:name=>"Peter", :type=>:string, :data=>"Tiny"})).to eq(true)
319
- expect(@registry.value_exists?("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", {:name=>"Peter", :type=>:string, :data=>"Tiny"})).to eq(false)
316
+ expect(@registry.delete_value("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", { :name => "Peter", :type => :string, :data => "Tiny" })).to eq(true)
317
+ expect(@registry.value_exists?("HKCU\\Software\\Root\\Trunk\\Peck\\Woodpecker", { :name => "Peter", :type => :string, :data => "Tiny" })).to eq(false)
320
318
  end
321
319
 
322
320
  it "throws an exception if the key does not exist?" do
323
- expect {@registry.delete_value("HKCU\\Software\\Trunk\\Peck\\Woodpecker", {:name=>"Peter", :type=>:string, :data=>"Tiny"})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
321
+ expect { @registry.delete_value("HKCU\\Software\\Trunk\\Peck\\Woodpecker", { :name => "Peter", :type => :string, :data => "Tiny" }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
324
322
  end
325
323
 
326
324
  it "throws an exception if the hive does not exist" do
327
- expect {@registry.delete_value("JKLM\\Software\\Root\\Trunk\\Peck\\Woodpecker", {:name=>"Peter", :type=>:string, :data=>"Tiny"})}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
325
+ expect { @registry.delete_value("JKLM\\Software\\Root\\Trunk\\Peck\\Woodpecker", { :name => "Peter", :type => :string, :data => "Tiny" }) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
328
326
  end
329
327
  end
330
328
 
@@ -332,11 +330,11 @@ describe 'Chef::Win32::Registry', :windows_only do
332
330
  before (:all) do
333
331
  ::Win32::Registry::HKEY_CURRENT_USER.create "Software\\Root\\Branch\\Fruit"
334
332
  ::Win32::Registry::HKEY_CURRENT_USER.open('Software\\Root\\Branch\\Fruit', Win32::Registry::KEY_ALL_ACCESS) do |reg|
335
- reg['Apple', Win32::Registry::REG_MULTI_SZ] = ["Red", "Juicy"]
333
+ reg["Apple", Win32::Registry::REG_MULTI_SZ] = ["Red", "Juicy"]
336
334
  end
337
335
  ::Win32::Registry::HKEY_CURRENT_USER.create "Software\\Root\\Trunk\\Peck\\Woodpecker"
338
336
  ::Win32::Registry::HKEY_CURRENT_USER.open('Software\\Root\\Trunk\\Peck\\Woodpecker', Win32::Registry::KEY_ALL_ACCESS) do |reg|
339
- reg['Peter', Win32::Registry::REG_SZ] = 'Tiny'
337
+ reg["Peter", Win32::Registry::REG_SZ] = "Tiny"
340
338
  end
341
339
  end
342
340
 
@@ -361,7 +359,7 @@ describe 'Chef::Win32::Registry', :windows_only do
361
359
  end
362
360
 
363
361
  it "throws an exception if the hive does not exist" do
364
- expect {@registry.delete_key("JKLM\\Software\\Root\\Branch\\Flower", false)}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
362
+ expect { @registry.delete_key("JKLM\\Software\\Root\\Branch\\Flower", false) }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
365
363
  end
366
364
  end
367
365
 
@@ -377,11 +375,11 @@ describe 'Chef::Win32::Registry', :windows_only do
377
375
  end
378
376
 
379
377
  it "throws an exception if the hive was missing" do
380
- expect {@registry.has_subkeys?("LMNO\\Software\\Root")}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
378
+ expect { @registry.has_subkeys?("LMNO\\Software\\Root") }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
381
379
  end
382
380
 
383
381
  it "throws an exception if the key is missing" do
384
- expect {@registry.has_subkeys?("HKCU\\Software\\Root\\Trunk\\Red")}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
382
+ expect { @registry.has_subkeys?("HKCU\\Software\\Root\\Trunk\\Red") }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
385
383
  end
386
384
 
387
385
  it "returns true if the key has subkeys" do
@@ -396,16 +394,16 @@ describe 'Chef::Win32::Registry', :windows_only do
396
394
 
397
395
  describe "get_subkeys" do
398
396
  it "throws an exception if the key is missing" do
399
- expect {@registry.get_subkeys("HKCU\\Software\\Trunk\\Red")}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
397
+ expect { @registry.get_subkeys("HKCU\\Software\\Trunk\\Red") }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
400
398
  end
401
399
  it "throws an exception if the hive does not exist" do
402
- expect {@registry.get_subkeys("JKLM\\Software\\Root")}.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
400
+ expect { @registry.get_subkeys("JKLM\\Software\\Root") }.to raise_error(Chef::Exceptions::Win32RegHiveMissing)
403
401
  end
404
402
  it "returns the array of subkeys for a given key" do
405
403
  subkeys = @registry.get_subkeys("HKCU\\Software\\Root")
406
404
  reg_subkeys = []
407
405
  ::Win32::Registry::HKEY_CURRENT_USER.open("Software\\Root", Win32::Registry::KEY_ALL_ACCESS) do |reg|
408
- reg.each_key{|name| reg_subkeys << name}
406
+ reg.each_key { |name| reg_subkeys << name }
409
407
  end
410
408
  expect(reg_subkeys).to eq(subkeys)
411
409
  end
@@ -424,7 +422,7 @@ describe 'Chef::Win32::Registry', :windows_only do
424
422
 
425
423
  context "registry constructor" do
426
424
  it "throws an exception if requested architecture is 64bit but running on 32bit" do
427
- expect {Chef::Win32::Registry.new(@run_context, :x86_64)}.to raise_error(Chef::Exceptions::Win32RegArchitectureIncorrect)
425
+ expect { Chef::Win32::Registry.new(@run_context, :x86_64) }.to raise_error(Chef::Exceptions::Win32RegArchitectureIncorrect)
428
426
  end
429
427
 
430
428
  it "can correctly set the requested architecture to 32-bit" do
@@ -442,7 +440,7 @@ describe 'Chef::Win32::Registry', :windows_only do
442
440
 
443
441
  context "architecture setter" do
444
442
  it "throws an exception if requested architecture is 64bit but running on 32bit" do
445
- expect {@registry.architecture = :x86_64}.to raise_error(Chef::Exceptions::Win32RegArchitectureIncorrect)
443
+ expect { @registry.architecture = :x86_64 }.to raise_error(Chef::Exceptions::Win32RegArchitectureIncorrect)
446
444
  end
447
445
 
448
446
  it "sets the requested architecture to :machine if passed :machine" do
@@ -527,12 +525,12 @@ describe 'Chef::Win32::Registry', :windows_only do
527
525
  # 64-bit
528
526
  ::Win32::Registry::HKEY_LOCAL_MACHINE.create("Software\\Root\\Mauve", ::Win32::Registry::KEY_ALL_ACCESS | 0x0100)
529
527
  ::Win32::Registry::HKEY_LOCAL_MACHINE.open('Software\\Root\\Mauve', Win32::Registry::KEY_ALL_ACCESS | 0x0100) do |reg|
530
- reg['Alert', Win32::Registry::REG_SZ] = 'Universal'
528
+ reg["Alert", Win32::Registry::REG_SZ] = "Universal"
531
529
  end
532
530
  # 32-bit
533
531
  ::Win32::Registry::HKEY_LOCAL_MACHINE.create("Software\\Root\\Poosh", ::Win32::Registry::KEY_ALL_ACCESS | 0x0200)
534
532
  ::Win32::Registry::HKEY_LOCAL_MACHINE.open('Software\\Root\\Poosh', Win32::Registry::KEY_ALL_ACCESS | 0x0200) do |reg|
535
- reg['Status', Win32::Registry::REG_SZ] = 'Lost'
533
+ reg["Status", Win32::Registry::REG_SZ] = "Lost"
536
534
  end
537
535
  end
538
536
 
@@ -547,58 +545,58 @@ describe 'Chef::Win32::Registry', :windows_only do
547
545
 
548
546
  describe "key_exists?" do
549
547
  it "does not find 64-bit keys in the 32-bit registry" do
550
- @registry.architecture=:i386
548
+ @registry.architecture = :i386
551
549
  expect(@registry.key_exists?("HKLM\\Software\\Root\\Mauve")).to eq(false)
552
550
  end
553
551
  it "finds 32-bit keys in the 32-bit registry" do
554
- @registry.architecture=:i386
552
+ @registry.architecture = :i386
555
553
  expect(@registry.key_exists?("HKLM\\Software\\Root\\Poosh")).to eq(true)
556
554
  end
557
555
  it "does not find 32-bit keys in the 64-bit registry" do
558
- @registry.architecture=:x86_64
556
+ @registry.architecture = :x86_64
559
557
  expect(@registry.key_exists?("HKLM\\Software\\Root\\Mauve")).to eq(true)
560
558
  end
561
559
  it "finds 64-bit keys in the 64-bit registry" do
562
- @registry.architecture=:x86_64
560
+ @registry.architecture = :x86_64
563
561
  expect(@registry.key_exists?("HKLM\\Software\\Root\\Poosh")).to eq(false)
564
562
  end
565
563
  end
566
564
 
567
565
  describe "value_exists?" do
568
566
  it "does not find 64-bit values in the 32-bit registry" do
569
- @registry.architecture=:i386
570
- expect{@registry.value_exists?("HKLM\\Software\\Root\\Mauve", {:name=>"Alert"})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
567
+ @registry.architecture = :i386
568
+ expect { @registry.value_exists?("HKLM\\Software\\Root\\Mauve", { :name => "Alert" }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
571
569
  end
572
570
  it "finds 32-bit values in the 32-bit registry" do
573
- @registry.architecture=:i386
574
- expect(@registry.value_exists?("HKLM\\Software\\Root\\Poosh", {:name=>"Status"})).to eq(true)
571
+ @registry.architecture = :i386
572
+ expect(@registry.value_exists?("HKLM\\Software\\Root\\Poosh", { :name => "Status" })).to eq(true)
575
573
  end
576
574
  it "does not find 32-bit values in the 64-bit registry" do
577
- @registry.architecture=:x86_64
578
- expect(@registry.value_exists?("HKLM\\Software\\Root\\Mauve", {:name=>"Alert"})).to eq(true)
575
+ @registry.architecture = :x86_64
576
+ expect(@registry.value_exists?("HKLM\\Software\\Root\\Mauve", { :name => "Alert" })).to eq(true)
579
577
  end
580
578
  it "finds 64-bit values in the 64-bit registry" do
581
- @registry.architecture=:x86_64
582
- expect{@registry.value_exists?("HKLM\\Software\\Root\\Poosh", {:name=>"Status"})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
579
+ @registry.architecture = :x86_64
580
+ expect { @registry.value_exists?("HKLM\\Software\\Root\\Poosh", { :name => "Status" }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
583
581
  end
584
582
  end
585
583
 
586
584
  describe "data_exists?" do
587
585
  it "does not find 64-bit keys in the 32-bit registry" do
588
- @registry.architecture=:i386
589
- expect{@registry.data_exists?("HKLM\\Software\\Root\\Mauve", {:name=>"Alert", :type=>:string, :data=>"Universal"})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
586
+ @registry.architecture = :i386
587
+ expect { @registry.data_exists?("HKLM\\Software\\Root\\Mauve", { :name => "Alert", :type => :string, :data => "Universal" }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
590
588
  end
591
589
  it "finds 32-bit keys in the 32-bit registry" do
592
- @registry.architecture=:i386
593
- expect(@registry.data_exists?("HKLM\\Software\\Root\\Poosh", {:name=>"Status", :type=>:string, :data=>"Lost"})).to eq(true)
590
+ @registry.architecture = :i386
591
+ expect(@registry.data_exists?("HKLM\\Software\\Root\\Poosh", { :name => "Status", :type => :string, :data => "Lost" })).to eq(true)
594
592
  end
595
593
  it "does not find 32-bit keys in the 64-bit registry" do
596
- @registry.architecture=:x86_64
597
- expect(@registry.data_exists?("HKLM\\Software\\Root\\Mauve", {:name=>"Alert", :type=>:string, :data=>"Universal"})).to eq(true)
594
+ @registry.architecture = :x86_64
595
+ expect(@registry.data_exists?("HKLM\\Software\\Root\\Mauve", { :name => "Alert", :type => :string, :data => "Universal" })).to eq(true)
598
596
  end
599
597
  it "finds 64-bit keys in the 64-bit registry" do
600
- @registry.architecture=:x86_64
601
- expect{@registry.data_exists?("HKLM\\Software\\Root\\Poosh", {:name=>"Status", :type=>:string, :data=>"Lost"})}.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
598
+ @registry.architecture = :x86_64
599
+ expect { @registry.data_exists?("HKLM\\Software\\Root\\Poosh", { :name => "Status", :type => :string, :data => "Lost" }) }.to raise_error(Chef::Exceptions::Win32RegKeyMissing)
602
600
  end
603
601
  end
604
602