chef 12.6.0 → 12.7.2

data/spec/unit/deprecation_spec.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Serdar Sutay (<serdar@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Serdar Sutay (<serdar@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,15 +16,15 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'chef/deprecation/warnings'
+require "spec_helper"
+require "chef/deprecation/warnings"
 
 describe Chef::Deprecation do
 
   # Support code for Chef::Deprecation
 
   def self.class_from_string(str)
-    str.split('::').inject(Object) do |mod, class_name|
+    str.split("::").inject(Object) do |mod, class_name|
       mod.const_get(class_name)
     end
   end
@@ -59,33 +59,33 @@ describe Chef::Deprecation do
     end
   end
 
-  context 'when Chef::Config[:treat_deprecation_warnings_as_errors] is off' do
+  context "when Chef::Config[:treat_deprecation_warnings_as_errors] is off" do
     before do
       Chef::Config[:treat_deprecation_warnings_as_errors] = false
     end
 
-    context 'deprecation warning messages' do
+    context "deprecation warning messages" do
       RSpec::Matchers.define_negated_matcher :a_non_empty_array, :be_empty
 
-      it 'should be enabled for deprecated methods' do
+      it "should be enabled for deprecated methods" do
         expect(Chef::Log).to receive(:warn).with(a_non_empty_array)
         TestClass.new.deprecated_method(10)
       end
 
-      it 'should contain stack trace' do
+      it "should contain stack trace" do
         expect(Chef::Log).to receive(:warn).with(a_string_including(".rb"))
         TestClass.new.deprecated_method(10)
       end
     end
 
-    it 'deprecated methods should still be called' do
+    it "deprecated methods should still be called" do
       test_instance = TestClass.new
       test_instance.deprecated_method(10)
       expect(test_instance.get_value).to eq(10)
     end
   end
 
-  it 'should raise when deprecation warnings are treated as errors' do
+  it "should raise when deprecation warnings are treated as errors" do
     # rspec should set this
     expect(Chef::Config[:treat_deprecation_warnings_as_errors]).to be true
     test_instance = TestClass.new

data/spec/unit/digester_spec.rb

@@ -1,8 +1,8 @@
 #
-# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Adam Jacob (<adam@chef.io>)
 # Author:: Daniel DeLeo (<dan@kallistec.com>)
-# Copyright:: Copyright (c) 2009 Opscode, Inc.
-# Copyright:: Copyright (c) 2009 Daniel DeLeo
+# Copyright:: Copyright 2009-2016, Chef Software Inc.
+# Copyright:: Copyright 2009-2016, Daniel DeLeo
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -18,7 +18,7 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Chef::Digester do
   before(:each) do
@@ -40,11 +40,10 @@ describe Chef::Digester do
 
     it "generates a checksum from a non-file IO object" do
       io = StringIO.new("riseofthemachines\nriseofthechefs\n")
-      expected_md5 = '0e157ac1e2dd73191b76067fb6b4bceb'
+      expected_md5 = "0e157ac1e2dd73191b76067fb6b4bceb"
       expect(@cache.generate_md5_checksum(io)).to eq(expected_md5)
     end
 
   end
 
 end
-

data/spec/unit/dsl/audit_spec.rb

@@ -1,6 +1,6 @@
 
-require 'spec_helper'
-require 'chef/dsl/audit'
+require "spec_helper"
+require "chef/dsl/audit"
 
 class AuditDSLTester < Chef::Recipe
   include Chef::DSL::Audit
@@ -17,15 +17,15 @@ describe Chef::DSL::Audit do
   let(:cookbook_collection) { {} }
 
   it "raises an error when a block of audits is not provided" do
-    expect{ auditor.control_group "name" }.to raise_error(Chef::Exceptions::NoAuditsProvided)
+    expect { auditor.control_group "name" }.to raise_error(Chef::Exceptions::NoAuditsProvided)
   end
 
   it "raises an error when no audit name is given" do
-    expect{ auditor.control_group do end }.to raise_error(Chef::Exceptions::AuditNameMissing)
+    expect { auditor.control_group do end }.to raise_error(Chef::Exceptions::AuditNameMissing)
   end
 
   context "audits already populated" do
-    let(:audits) { {"unique" => {} } }
+    let(:audits) { { "unique" => {} } }
 
     it "raises an error if the audit name is a duplicate" do
       expect { auditor.control_group "unique" do end }.to raise_error(Chef::Exceptions::AuditControlGroupDuplicate)

data/spec/unit/dsl/data_query_spec.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Seth Falcon (<seth@opscode.com>)
-# Copyright:: Copyright (c) 2010 Opscode, Inc.
+# Author:: Seth Falcon (<seth@chef.io>)
+# Copyright:: Copyright 2010-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,8 +16,8 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'chef/dsl/data_query'
+require "spec_helper"
+require "chef/dsl/data_query"
 
 class DataQueryDSLTester
   include Chef::DSL::DataQuery
@@ -35,23 +35,23 @@ describe Chef::DSL::DataQuery do
   describe "::data_bag" do
     it "lists the items in a data bag" do
       allow(Chef::DataBag).to receive(:load)
-      .with("bag_name")
-      .and_return("item_1" => "http://url_for/item_1", "item_2" => "http://url_for/item_2")
-      expect( language.data_bag("bag_name").sort ).to eql %w(item_1 item_2)
+        .with("bag_name")
+        .and_return("item_1" => "http://url_for/item_1", "item_2" => "http://url_for/item_2")
+      expect( language.data_bag("bag_name").sort ).to eql %w{item_1 item_2}
     end
   end
 
   shared_examples_for "a data bag item" do
     it "validates the name of the data bag you're trying to load an item from" do
-      expect{ language.send(method_name, " %%^& ", "item_name") }.to raise_error(Chef::Exceptions::InvalidDataBagName)
+      expect { language.send(method_name, " %%^& ", "item_name") }.to raise_error(Chef::Exceptions::InvalidDataBagName)
     end
 
     it "validates the id of the data bag item you're trying to load" do
-      expect{ language.send(method_name, "bag_name", " 987 (*&()") }.to raise_error(Chef::Exceptions::InvalidDataBagItemID)
+      expect { language.send(method_name, "bag_name", " 987 (*&()") }.to raise_error(Chef::Exceptions::InvalidDataBagItemID)
     end
 
     it "validates that the id of the data bag item is not nil" do
-      expect{ language.send(method_name, "bag_name", nil) }.to raise_error(Chef::Exceptions::InvalidDataBagItemID)
+      expect { language.send(method_name, "bag_name", nil) }.to raise_error(Chef::Exceptions::InvalidDataBagItemID)
     end
   end
 
@@ -65,8 +65,8 @@ describe Chef::DSL::DataQuery do
       "greeting" => "hello",
       "nested" => {
         "a1" => [1, 2, 3],
-        "a2" => { "b1" => true }
-      }
+        "a2" => { "b1" => true },
+      },
     }}
 
     let(:item) do

data/spec/unit/dsl/platform_introspection_spec.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Seth Falcon (<seth@opscode.com>)
-# Copyright:: Copyright (c) 2010 Opscode, Inc.
+# Author:: Seth Falcon (<seth@chef.io>)
+# Copyright:: Copyright 2010-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,8 +16,8 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'chef/dsl/platform_introspection'
+require "spec_helper"
+require "chef/dsl/platform_introspection"
 
 class LanguageTester
   attr_reader :node
@@ -39,16 +39,16 @@ end
 describe Chef::DSL::PlatformIntrospection::PlatformDependentValue do
   before do
     platform_hash = {
-      :openbsd => {:default => 'free, functional, secure'},
-      [:redhat, :centos, :fedora, :scientific] => {:default => '"stable"'},
-      :ubuntu => {'10.04' => 'using upstart more', :default => 'using init more'},
-      :default => 'bork da bork'
+      :openbsd => { :default => "free, functional, secure" },
+      [:redhat, :centos, :fedora, :scientific] => { :default => '"stable"' },
+      :ubuntu => { "10.04" => "using upstart more", :default => "using init more" },
+      :default => "bork da bork",
     }
     @platform_specific_value = Chef::DSL::PlatformIntrospection::PlatformDependentValue.new(platform_hash)
   end
 
   it "returns the default value when the platform doesn't match" do
-    expect(@platform_specific_value.value_for_node(:platform => :dos)).to eq('bork da bork')
+    expect(@platform_specific_value.value_for_node(:platform => :dos)).to eq("bork da bork")
   end
 
   it "returns a value for a platform set as a group" do
@@ -60,25 +60,25 @@ describe Chef::DSL::PlatformIntrospection::PlatformDependentValue do
   end
 
   it "returns a value for a specific platform version" do
-    node = {:platform => 'ubuntu', :platform_version => '10.04'}
-    expect(@platform_specific_value.value_for_node(node)).to eq('using upstart more')
+    node = { :platform => "ubuntu", :platform_version => "10.04" }
+    expect(@platform_specific_value.value_for_node(node)).to eq("using upstart more")
   end
 
   it "returns a platform-default value if the platform version doesn't match an explicit one" do
-    node = {:platform => 'ubuntu', :platform_version => '9.10' }
-    expect(@platform_specific_value.value_for_node(node)).to eq('using init more')
+    node = { :platform => "ubuntu", :platform_version => "9.10" }
+    expect(@platform_specific_value.value_for_node(node)).to eq("using init more")
   end
 
   it "returns nil if there is no default and no platforms match" do
     # this matches the behavior in the original implementation.
     # whether or not it's correct is another matter.
     platform_specific_value = Chef::DSL::PlatformIntrospection::PlatformDependentValue.new({})
-    expect(platform_specific_value.value_for_node(:platform => 'foo')).to be_nil
+    expect(platform_specific_value.value_for_node(:platform => "foo")).to be_nil
   end
 
   it "raises an argument error if the platform hash is not correctly structured" do
-    bad_hash = {:ubuntu => :foo} # should be :ubuntu => {:default => 'foo'}
-    expect {Chef::DSL::PlatformIntrospection::PlatformDependentValue.new(bad_hash)}.to raise_error(ArgumentError)
+    bad_hash = { :ubuntu => :foo } # should be :ubuntu => {:default => 'foo'}
+    expect { Chef::DSL::PlatformIntrospection::PlatformDependentValue.new(bad_hash) }.to raise_error(ArgumentError)
   end
 
 end
@@ -91,17 +91,16 @@ describe Chef::DSL::PlatformIntrospection::PlatformFamilyDependentValue do
       [:rhel, "fedora"] => "redhatty value",
       "suse" => @array_values,
       :gentoo => "gentoo value",
-      :default => "default value"
+      :default => "default value",
     }
 
     @platform_family_value = Chef::DSL::PlatformIntrospection::PlatformFamilyDependentValue.new(@platform_family_hash)
   end
 
   it "returns the default value when the platform family doesn't match" do
-    expect(@platform_family_value.value_for_node(:platform_family => :os2)).to eq('default value')
+    expect(@platform_family_value.value_for_node(:platform_family => :os2)).to eq("default value")
   end
 
-
   it "returns a value for the platform family when it was set as a string but fetched as a symbol" do
     expect(@platform_family_value.value_for_node(:platform_family => :debian)).to eq("debian value")
   end
@@ -124,7 +123,7 @@ describe Chef::DSL::PlatformIntrospection::PlatformFamilyDependentValue do
 
   it "returns nil if there is no default and no platforms match" do
     platform_specific_value = Chef::DSL::PlatformIntrospection::PlatformFamilyDependentValue.new({})
-    expect(platform_specific_value.value_for_node(:platform_family => 'foo')).to be_nil
+    expect(platform_specific_value.value_for_node(:platform_family => "foo")).to be_nil
   end
 
 end

data/spec/unit/dsl/reboot_pending_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Bryan McLellan <btm@loftninjas.org>
-# Copyright:: Copyright (c) 2014 Chef Software, Inc.
+# Copyright:: Copyright 2014-2016, Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -30,26 +30,26 @@ describe Chef::DSL::RebootPending do
 
       context "platform is windows" do
         before do
-          allow(recipe).to receive(:platform?).with('windows').and_return(true)
+          allow(recipe).to receive(:platform?).with("windows").and_return(true)
           allow(recipe).to receive(:registry_key_exists?).and_return(false)
           allow(recipe).to receive(:registry_value_exists?).and_return(false)
         end
-  
+
         it 'should return true if "HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\PendingFileRenameOperations" exists' do
-          allow(recipe).to receive(:registry_value_exists?).with('HKLM\SYSTEM\CurrentControlSet\Control\Session Manager', { :name => 'PendingFileRenameOperations' }).and_return(true)
+          allow(recipe).to receive(:registry_value_exists?).with('HKLM\SYSTEM\CurrentControlSet\Control\Session Manager', { :name => "PendingFileRenameOperations" }).and_return(true)
           expect(recipe.reboot_pending?).to be_truthy
         end
-  
+
         it 'should return true if "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update\RebootRequired" exists' do
           allow(recipe).to receive(:registry_key_exists?).with('HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update\RebootRequired').and_return(true)
           expect(recipe.reboot_pending?).to be_truthy
         end
-  
+
         it 'should return true if key "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Component Based Servicing\RebootRequired" exists' do
           allow(recipe).to receive(:registry_key_exists?).with('HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Component Based Servicing\RebootPending').and_return(true)
           expect(recipe.reboot_pending?).to be_truthy
         end
-  
+
         context "version is server 2003" do
           before do
             allow(Chef::Platform).to receive(:windows_server_2003?).and_return(true)
@@ -58,24 +58,24 @@ describe Chef::DSL::RebootPending do
           it 'should return true if value "HKLM\SOFTWARE\Microsoft\Updates\UpdateExeVolatile" contains specific data on 2k3' do
             allow(recipe).to receive(:registry_key_exists?).with('HKLM\SOFTWARE\Microsoft\Updates\UpdateExeVolatile').and_return(true)
             allow(recipe).to receive(:registry_get_values).with('HKLM\SOFTWARE\Microsoft\Updates\UpdateExeVolatile').and_return(
-                  [{:name => "Flags", :type => :dword, :data => 3}])
+                  [{ :name => "Flags", :type => :dword, :data => 3 }])
             expect(recipe.reboot_pending?).to be_truthy
           end
         end
       end
-  
+
       context "platform is ubuntu" do
         before do
-          allow(recipe).to receive(:platform?).with('ubuntu').and_return(true)
+          allow(recipe).to receive(:platform?).with("ubuntu").and_return(true)
         end
-  
-        it 'should return true if /var/run/reboot-required exists' do
-          allow(File).to receive(:exists?).with('/var/run/reboot-required').and_return(true)
+
+        it "should return true if /var/run/reboot-required exists" do
+          allow(File).to receive(:exists?).with("/var/run/reboot-required").and_return(true)
           expect(recipe.reboot_pending?).to be_truthy
         end
-  
-        it 'should return false if /var/run/reboot-required does not exist' do
-          allow(File).to receive(:exists?).with('/var/run/reboot-required').and_return(false)
+
+        it "should return false if /var/run/reboot-required does not exist" do
+          allow(File).to receive(:exists?).with("/var/run/reboot-required").and_return(false)
           expect(recipe.reboot_pending?).to be_falsey
         end
       end
@@ -85,7 +85,7 @@ describe Chef::DSL::RebootPending do
     describe "in a recipe" do
       it "responds to reboot_pending?" do
         # Chef::Recipe.new(cookbook_name, recipe_name, run_context(node, cookbook_collection, events))
-        recipe = Chef::Recipe.new(nil,nil,Chef::RunContext.new(Chef::Node.new, {}, nil))
+        recipe = Chef::Recipe.new(nil, nil, Chef::RunContext.new(Chef::Node.new, {}, nil))
         expect(recipe).to respond_to(:reboot_pending?)
       end
     end # describe in a recipe

data/spec/unit/dsl/recipe_spec.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Daniel DeLeo (<dan@getchef.com>)
-# Copyright:: Copyright (c) 2014 Chef Software, Inc.
+# Author:: Daniel DeLeo (<dan@chef.io>)
+# Copyright:: Copyright 2014-2016, Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,9 +16,8 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'chef/dsl/recipe'
-
+require "spec_helper"
+require "chef/dsl/recipe"
 
 RecipeDSLExampleClass = Struct.new(:cookbook_name, :recipe_name)
 class RecipeDSLExampleClass
@@ -79,4 +78,3 @@ describe Chef::DSL::Recipe do
   end
 
 end
-

data/spec/unit/dsl/regsitry_helper_spec.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Prajakta Purohit (<prajakta@opscode.com>)
-# Copyright:: Copyright (c) 2011 Opscode, Inc.
+# Author:: Prajakta Purohit (<prajakta@chef.io>)
+# Copyright:: Copyright 2011-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -24,32 +24,29 @@ describe Chef::Resource::RegistryKey do
   before (:all) do
     events = Chef::EventDispatch::Dispatcher.new
     node = Chef::Node.new
-    ohai = Ohai::System.new
-    ohai.all_plugins
-    node.consume_external_attrs(ohai.data,{})
+    node.consume_external_attrs(OHAI_SYSTEM.data, {})
     run_context = Chef::RunContext.new(node, {}, events)
     @resource = Chef::Resource::new("foo", run_context)
   end
 
   context "tests registry dsl" do
     it "resource can access registry_helper method registry_key_exists" do
-      expect(@resource.respond_to?('registry_key_exists?')).to eq(true)
+      expect(@resource.respond_to?("registry_key_exists?")).to eq(true)
     end
     it "resource can access registry_helper method registry_get_values" do
-      expect(@resource.respond_to?('registry_get_values')).to eq(true)
+      expect(@resource.respond_to?("registry_get_values")).to eq(true)
     end
     it "resource can access registry_helper method registry_has_subkey" do
-      expect(@resource.respond_to?('registry_has_subkeys?')).to eq(true)
+      expect(@resource.respond_to?("registry_has_subkeys?")).to eq(true)
     end
     it "resource can access registry_helper method registry_get_subkeys" do
-      expect(@resource.respond_to?('registry_get_subkeys')).to eq(true)
+      expect(@resource.respond_to?("registry_get_subkeys")).to eq(true)
     end
     it "resource can access registry_helper method registry_value_exists" do
-      expect(@resource.respond_to?('registry_value_exists?')).to eq(true)
+      expect(@resource.respond_to?("registry_value_exists?")).to eq(true)
     end
     it "resource can access registry_helper method data_value_exists" do
-      expect(@resource.respond_to?('registry_data_exists?')).to eq(true)
+      expect(@resource.respond_to?("registry_data_exists?")).to eq(true)
     end
   end
 end
-

data/spec/unit/dsl/resources_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Noah Kantrowitz (<noah@coderanger.net>)
-# Copyright:: Copyright (c) 2015 Noah Kantrowitz
+# Copyright:: Copyright 2015-2016, Noah Kantrowitz
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,8 +16,8 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'chef/dsl/resources'
+require "spec_helper"
+require "chef/dsl/resources"
 
 describe Chef::DSL::Resources do
   let(:declared_resources) { [] }
@@ -36,21 +36,21 @@ describe Chef::DSL::Resources do
     described_class.remove_resource_dsl(:test_resource)
   end
 
-  context 'with a resource added' do
+  context "with a resource added" do
     before do
       Chef::DSL::Resources.add_resource_dsl(:test_resource)
       test_class.new.instance_eval do
-        test_resource 'test_name' do
+        test_resource "test_name" do
         end
       end
     end
-    it { is_expected.to eq [[:test_resource, 'test_name']]}
+    it { is_expected.to eq [[:test_resource, "test_name"]] }
   end
 
-  context 'with no resource added' do
+  context "with no resource added" do
     subject do
       test_class.new.instance_eval do
-        test_resource 'test_name' do
+        test_resource "test_name" do
         end
       end
     end
@@ -58,14 +58,14 @@ describe Chef::DSL::Resources do
     it { expect { subject }.to raise_error NoMethodError }
   end
 
-  context 'with a resource added and removed' do
+  context "with a resource added and removed" do
     before do
       Chef::DSL::Resources.add_resource_dsl(:test_resource)
       Chef::DSL::Resources.remove_resource_dsl(:test_resource)
     end
     subject do
       test_class.new.instance_eval do
-        test_resource 'test_name' do
+        test_resource "test_name" do
         end
       end
     end
@@ -73,13 +73,13 @@ describe Chef::DSL::Resources do
     it { expect { subject }.to raise_error NoMethodError }
   end
 
-  context 'with a nameless resource' do
+  context "with a nameless resource" do
     before do
       Chef::DSL::Resources.add_resource_dsl(:test_resource)
       test_class.new.instance_eval do
-        test_resource { }
+        test_resource {}
       end
     end
-    it { is_expected.to eq [[:test_resource, nil]]}
+    it { is_expected.to eq [[:test_resource, nil]] }
   end
 end