chef 12.6.0 → 12.7.2

data/spec/integration/recipes/lwrp_inline_resources_spec.rb

@@ -1,5 +1,5 @@
-require 'support/shared/integration/integration_helper'
-require 'chef/mixin/shell_out'
+require "support/shared/integration/integration_helper"
+require "chef/mixin/shell_out"
 
 describe "LWRPs with inline resources" do
   include IntegrationSupport
@@ -29,7 +29,7 @@ describe "LWRPs with inline resources" do
         use_inline_resources
         def action_a
           r = new_resource
-          ruby_block 'run a' do
+          ruby_block "run a" do
             block { r.ran_a "ran a" }
           end
         end
@@ -39,8 +39,8 @@ describe "LWRPs with inline resources" do
     it "this is totally a bug, but for backcompat purposes, it adds the resources to the main resource collection and does not get marked updated" do
       r = nil
       expect_recipe {
-        r = lwrp_inline_resources_test 'hi'
-      }.to have_updated('ruby_block[run a]', :run)
+        r = lwrp_inline_resources_test "hi"
+      }.to have_updated("ruby_block[run a]", :run)
       expect(r.ran_a).to eq "ran a"
     end
   end
@@ -58,7 +58,7 @@ describe "LWRPs with inline resources" do
 
         action :a do
           r = new_resource
-          ruby_block 'run a' do
+          ruby_block "run a" do
             block { r.ran_a "ran a" }
           end
         end
@@ -68,7 +68,7 @@ describe "LWRPs with inline resources" do
           r = new_resource
           # Grab ran_a right now, before we converge
           ran_a = r.ran_a
-          ruby_block 'run b' do
+          ruby_block "run b" do
             block { r.ran_b "ran b: ran_a value was #{ran_a.inspect}" }
           end
         end
@@ -78,34 +78,34 @@ describe "LWRPs with inline resources" do
     it "resources declared in b are executed immediately inline" do
       r = nil
       expect_recipe {
-        r = lwrp_inline_resources_test2 'hi' do
+        r = lwrp_inline_resources_test2 "hi" do
           action :b
         end
-      }.to have_updated('lwrp_inline_resources_test2[hi]', :b).
-       and have_updated('ruby_block[run a]', :run).
-       and have_updated('ruby_block[run b]', :run)
+      }.to have_updated("lwrp_inline_resources_test2[hi]", :b).
+        and have_updated("ruby_block[run a]", :run).
+        and have_updated("ruby_block[run b]", :run)
       expect(r.ran_b).to eq "ran b: ran_a value was \"ran a\""
     end
   end
 
   when_the_repository "has a cookbook with a nested LWRP" do
     before do
-      directory 'cookbooks/x' do
+      directory "cookbooks/x" do
 
-        file 'resources/do_nothing.rb', <<-EOM
+        file "resources/do_nothing.rb", <<-EOM
           actions :create, :nothing
           default_action :create
         EOM
-        file 'providers/do_nothing.rb', <<-EOM
+        file "providers/do_nothing.rb", <<-EOM
           action :create do
           end
         EOM
 
-        file 'resources/my_machine.rb', <<-EOM
+        file "resources/my_machine.rb", <<-EOM
           actions :create, :nothing
           default_action :create
         EOM
-        file 'providers/my_machine.rb', <<-EOM
+        file "providers/my_machine.rb", <<-EOM
           use_inline_resources
           action :create do
             x_do_nothing 'a'
@@ -113,7 +113,7 @@ describe "LWRPs with inline resources" do
           end
         EOM
 
-        file 'recipes/default.rb', <<-EOM
+        file "recipes/default.rb", <<-EOM
           x_my_machine "me"
           x_my_machine "you"
         EOM
@@ -122,7 +122,7 @@ describe "LWRPs with inline resources" do
     end
 
     it "should complete with success" do
-      file 'config/client.rb', <<EOM
+      file "config/client.rb", <<EOM
 local_mode true
 cookbook_path "#{path_to('cookbooks')}"
 log_level :warn

data/spec/integration/recipes/lwrp_spec.rb

@@ -1,5 +1,5 @@
-require 'support/shared/integration/integration_helper'
-require 'chef/mixin/shell_out'
+require "support/shared/integration/integration_helper"
+require "chef/mixin/shell_out"
 
 describe "LWRPs" do
   include IntegrationSupport
@@ -20,17 +20,17 @@ describe "LWRPs" do
 
   when_the_repository "has a cookbook named l-w-r-p" do
     before do
-      directory 'cookbooks/l-w-r-p' do
+      directory "cookbooks/l-w-r-p" do
 
-        file 'resources/foo.rb', <<EOM
+        file "resources/foo.rb", <<EOM
 default_action :create
 EOM
-        file 'providers/foo.rb', <<EOM
+        file "providers/foo.rb", <<EOM
 action :create do
 end
 EOM
 
-        file 'recipes/default.rb', <<EOM
+        file "recipes/default.rb", <<EOM
 l_w_r_p_foo "me"
 EOM
 
@@ -38,7 +38,7 @@ EOM
     end
 
     it "should complete with success" do
-      file 'config/client.rb', <<EOM
+      file "config/client.rb", <<EOM
 local_mode true
 cookbook_path "#{path_to('cookbooks')}"
 log_level :warn

data/spec/integration/recipes/provider_choice.rb

@@ -1,4 +1,4 @@
-require 'support/shared/integration/integration_helper'
+require "support/shared/integration/integration_helper"
 
 describe "Recipe DSL methods" do
   include IntegrationSupport
@@ -18,6 +18,7 @@ describe "Recipe DSL methods" do
         class Chef::Provider::ProviderThingy < Chef::Provider
           def load_current_resource
           end
+
           def action_create
             Chef::Log.warn("hello from #{self.class.name}")
           end
@@ -26,7 +27,7 @@ describe "Recipe DSL methods" do
 
       it "provider_thingy 'blah' runs the provider and warns" do
         recipe = converge {
-          provider_thingy 'blah' do; end
+          provider_thingy "blah" do; end
         }
         expect(recipe.logged_warnings).to match /hello from Chef::Provider::ProviderThingy/
         expect(recipe.logged_warnings).to match /you must use 'provides' to provide DSL/i

data/spec/integration/recipes/recipe_dsl_spec.rb

@@ -1,4 +1,4 @@
-require 'support/shared/integration/integration_helper'
+require "support/shared/integration/integration_helper"
 
 describe "Recipe DSL methods" do
   include IntegrationSupport
@@ -15,7 +15,7 @@ describe "Recipe DSL methods" do
     before(:context) {
 
       class BaseThingy < Chef::Resource
-        resource_name 'base_thingy'
+        resource_name "base_thingy"
         default_action :create
 
         class<<self
@@ -30,6 +30,7 @@ describe "Recipe DSL methods" do
         class Provider < Chef::Provider
           def load_current_resource
           end
+
           def action_create
             BaseThingy.created_name = new_resource.name
             BaseThingy.created_resource = new_resource.class
@@ -51,27 +52,27 @@ describe "Recipe DSL methods" do
 
     it "creates base_thingy when you call base_thingy in a recipe" do
       recipe = converge {
-        base_thingy 'blah' do; end
+        base_thingy "blah" do; end
       }
-      expect(recipe.logged_warnings).to eq ''
-      expect(BaseThingy.created_name).to eq 'blah'
+      expect(recipe.logged_warnings).to eq ""
+      expect(BaseThingy.created_name).to eq "blah"
       expect(BaseThingy.created_resource).to eq BaseThingy
     end
 
     it "errors out when you call base_thingy do ... end in a recipe" do
       expect_converge {
         base_thingy do; end
-      }.to raise_error(ArgumentError, 'You must supply a name when declaring a base_thingy resource')
+      }.to raise_error(ArgumentError, "You must supply a name when declaring a base_thingy resource")
     end
 
     it "emits a warning when you call base_thingy 'foo', 'bar' do ... end in a recipe" do
       Chef::Config[:treat_deprecation_warnings_as_errors] = false
       recipe = converge {
-        base_thingy 'foo', 'bar' do
+        base_thingy "foo", "bar" do
         end
       }
       expect(recipe.logged_warnings).to match(/Cannot create resource base_thingy with more than one argument. All arguments except the name \("foo"\) will be ignored. This will cause an error in Chef 13. Arguments: \["foo", "bar"\]/)
-      expect(BaseThingy.created_name).to eq 'foo'
+      expect(BaseThingy.created_name).to eq "foo"
       expect(BaseThingy.created_resource).to eq BaseThingy
     end
 
@@ -89,6 +90,7 @@ describe "Recipe DSL methods" do
           class Chef::Provider::BackcompatThingy < Chef::Provider
             def load_current_resource
             end
+
             def action_create
               BaseThingy.created_resource = new_resource.class
               BaseThingy.created_provider = self.class
@@ -99,7 +101,7 @@ describe "Recipe DSL methods" do
 
         it "backcompat_thingy creates a Chef::Resource::BackcompatThingy" do
           recipe = converge {
-            backcompat_thingy 'blah' do; end
+            backcompat_thingy "blah" do; end
           }
           expect(BaseThingy.created_resource).to eq Chef::Resource::BackcompatThingy
           expect(BaseThingy.created_provider).to eq Chef::Provider::BackcompatThingy
@@ -117,7 +119,7 @@ describe "Recipe DSL methods" do
 
           it "backcompat_thingy creates a BackcompatThingy" do
             recipe = converge {
-              backcompat_thingy 'blah' do; end
+              backcompat_thingy "blah" do; end
             }
             expect(recipe.logged_warnings).to match(/Class Chef::Provider::BackcompatThingy does not declare 'provides :backcompat_thingy'./)
             expect(BaseThingy.created_resource).not_to be_nil
@@ -135,7 +137,7 @@ describe "Recipe DSL methods" do
 
         it "bar_thingy does not work" do
           expect_converge {
-            bar_thingy 'blah' do; end
+            bar_thingy "blah" do; end
           }.to raise_error(NoMethodError)
         end
       end
@@ -151,7 +153,7 @@ describe "Recipe DSL methods" do
 
         it "no_name_thingy does not work" do
           expect_converge {
-            no_name_thingy 'blah' do; end
+            no_name_thingy "blah" do; end
           }.to raise_error(NoMethodError)
         end
       end
@@ -167,15 +169,15 @@ describe "Recipe DSL methods" do
 
         it "another_no_name_thingy does not work" do
           expect_converge {
-            another_no_name_thingy 'blah' do; end
+            another_no_name_thingy "blah" do; end
           }.to raise_error(NoMethodError)
         end
 
         it "another_thingy_name works" do
           recipe = converge {
-            another_thingy_name 'blah' do; end
+            another_thingy_name "blah" do; end
           }
-          expect(recipe.logged_warnings).to eq ''
+          expect(recipe.logged_warnings).to eq ""
           expect(BaseThingy.created_resource).to eq(AnotherNoNameThingy)
         end
       end
@@ -192,21 +194,21 @@ describe "Recipe DSL methods" do
 
         it "another_no_name_thingy does not work" do
           expect_converge {
-            another_no_name_thingy2 'blah' do; end
+            another_no_name_thingy2 "blah" do; end
           }.to raise_error(NoMethodError)
         end
 
         it "another_thingy_name2 does not work" do
           expect_converge {
-            another_thingy_name2 'blah' do; end
+            another_thingy_name2 "blah" do; end
           }.to raise_error(NoMethodError)
         end
 
         it "yet_another_thingy_name3 works" do
           recipe = converge {
-            another_thingy_name3 'blah' do; end
+            another_thingy_name3 "blah" do; end
           }
-          expect(recipe.logged_warnings).to eq ''
+          expect(recipe.logged_warnings).to eq ""
           expect(BaseThingy.created_resource).to eq(AnotherNoNameThingy2)
         end
       end
@@ -217,7 +219,7 @@ describe "Recipe DSL methods" do
 
             class AnotherNoNameThingy3 < BaseThingy
               resource_name :another_no_name_thingy_3
-              provides :another_no_name_thingy3, os: 'blarghle'
+              provides :another_no_name_thingy3, os: "blarghle"
             end
 
           }
@@ -225,18 +227,18 @@ describe "Recipe DSL methods" do
           it "and os = linux, another_no_name_thingy3 does not work" do
             expect_converge {
               # TODO this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_no_name_thingy3 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_no_name_thingy3 "blah" do; end
             }.to raise_error(Chef::Exceptions::NoSuchResourceType)
           end
 
           it "and os = blarghle, another_no_name_thingy3 works" do
             recipe = converge {
               # TODO this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'blarghle'
-              another_no_name_thingy3 'blah' do; end
+              run_context.node.automatic[:os] = "blarghle"
+              another_no_name_thingy3 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy3)
           end
         end
@@ -246,8 +248,8 @@ describe "Recipe DSL methods" do
 
             class AnotherNoNameThingy4 < BaseThingy
               resource_name :another_no_name_thingy_4
-              provides :another_no_name_thingy4, os: 'blarghle'
-              provides :another_no_name_thingy4, platform_family: 'foo'
+              provides :another_no_name_thingy4, os: "blarghle"
+              provides :another_no_name_thingy4, platform_family: "foo"
             end
 
           }
@@ -255,28 +257,28 @@ describe "Recipe DSL methods" do
           it "and os = linux, another_no_name_thingy4 does not work" do
             expect_converge {
               # TODO this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_no_name_thingy4 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_no_name_thingy4 "blah" do; end
             }.to raise_error(Chef::Exceptions::NoSuchResourceType)
           end
 
           it "and os = blarghle, another_no_name_thingy4 works" do
             recipe = converge {
               # TODO this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'blarghle'
-              another_no_name_thingy4 'blah' do; end
+              run_context.node.automatic[:os] = "blarghle"
+              another_no_name_thingy4 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy4)
           end
 
           it "and platform_family = foo, another_no_name_thingy4 works" do
             recipe = converge {
               # TODO this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:platform_family] = 'foo'
-              another_no_name_thingy4 'blah' do; end
+              run_context.node.automatic[:platform_family] = "foo"
+              another_no_name_thingy4 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy4)
           end
         end
@@ -286,7 +288,7 @@ describe "Recipe DSL methods" do
 
             class AnotherNoNameThingy5 < BaseThingy
               resource_name :another_thingy_name_for_another_no_name_thingy5
-              provides :another_no_name_thingy5, os: 'blarghle'
+              provides :another_no_name_thingy5, os: "blarghle"
             end
 
           }
@@ -294,26 +296,26 @@ describe "Recipe DSL methods" do
           it "and os = linux, another_no_name_thingy5 does not work" do
             expect_converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_no_name_thingy5 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_no_name_thingy5 "blah" do; end
             }.to raise_error(Chef::Exceptions::NoSuchResourceType)
           end
 
           it "and os = blarghle, another_no_name_thingy5 works" do
             recipe = converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'blarghle'
-              another_no_name_thingy5 'blah' do; end
+              run_context.node.automatic[:os] = "blarghle"
+              another_no_name_thingy5 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy5)
           end
 
           it "the new resource name can be used in a recipe" do
             recipe = converge {
-              another_thingy_name_for_another_no_name_thingy5 'blah' do; end
+              another_thingy_name_for_another_no_name_thingy5 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy5)
           end
         end
@@ -322,7 +324,7 @@ describe "Recipe DSL methods" do
           before(:context) {
 
             class AnotherNoNameThingy6 < BaseThingy
-              provides :another_no_name_thingy6, os: 'blarghle'
+              provides :another_no_name_thingy6, os: "blarghle"
               resource_name :another_thingy_name_for_another_no_name_thingy6
             end
 
@@ -331,26 +333,26 @@ describe "Recipe DSL methods" do
           it "and os = linux, another_no_name_thingy6 does not work" do
             expect_converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_no_name_thingy6 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_no_name_thingy6 "blah" do; end
             }.to raise_error(Chef::Exceptions::NoSuchResourceType)
           end
 
           it "and os = blarghle, another_no_name_thingy6 works" do
             recipe = converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'blarghle'
-              another_no_name_thingy6 'blah' do; end
+              run_context.node.automatic[:os] = "blarghle"
+              another_no_name_thingy6 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy6)
           end
 
           it "the new resource name can be used in a recipe" do
             recipe = converge {
-              another_thingy_name_for_another_no_name_thingy6 'blah' do; end
+              another_thingy_name_for_another_no_name_thingy6 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy6)
           end
         end
@@ -360,7 +362,7 @@ describe "Recipe DSL methods" do
 
             class AnotherNoNameThingy7 < BaseThingy
               resource_name :another_thingy_name_for_another_no_name_thingy7
-              provides :another_thingy_name_for_another_no_name_thingy7, os: 'blarghle'
+              provides :another_thingy_name_for_another_no_name_thingy7, os: "blarghle"
             end
 
           }
@@ -368,26 +370,26 @@ describe "Recipe DSL methods" do
           it "and os = linux, another_thingy_name_for_another_no_name_thingy7 does not work" do
             expect_converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_thingy_name_for_another_no_name_thingy7 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_thingy_name_for_another_no_name_thingy7 "blah" do; end
             }.to raise_error(Chef::Exceptions::NoSuchResourceType)
           end
 
           it "and os = blarghle, another_thingy_name_for_another_no_name_thingy7 works" do
             recipe = converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'blarghle'
-              another_thingy_name_for_another_no_name_thingy7 'blah' do; end
+              run_context.node.automatic[:os] = "blarghle"
+              another_thingy_name_for_another_no_name_thingy7 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy7)
           end
 
           it "the old resource name does not work" do
             expect_converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_no_name_thingy_7 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_no_name_thingy_7 "blah" do; end
             }.to raise_error(NoMethodError)
           end
         end
@@ -397,7 +399,7 @@ describe "Recipe DSL methods" do
           before(:context) {
 
             class AnotherNoNameThingy8 < BaseThingy
-              provides :another_thingy_name_for_another_no_name_thingy8, os: 'blarghle'
+              provides :another_thingy_name_for_another_no_name_thingy8, os: "blarghle"
               resource_name :another_thingy_name_for_another_no_name_thingy8
             end
 
@@ -406,26 +408,26 @@ describe "Recipe DSL methods" do
           it "and os = linux, another_thingy_name_for_another_no_name_thingy8 does not work" do
             expect_converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_thingy_name_for_another_no_name_thingy8 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_thingy_name_for_another_no_name_thingy8 "blah" do; end
             }.to raise_error(Chef::Exceptions::NoSuchResourceType)
           end
 
           it "and os = blarghle, another_thingy_name_for_another_no_name_thingy8 works" do
             recipe = converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'blarghle'
-              another_thingy_name_for_another_no_name_thingy8 'blah' do; end
+              run_context.node.automatic[:os] = "blarghle"
+              another_thingy_name_for_another_no_name_thingy8 "blah" do; end
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq (AnotherNoNameThingy8)
           end
 
           it "the old resource name does not work" do
             expect_converge {
               # this is an ugly way to test, make Cheffish expose node attrs
-              run_context.node.automatic[:os] = 'linux'
-              another_thingy_name8 'blah' do; end
+              run_context.node.automatic[:os] = "linux"
+              another_thingy_name8 "blah" do; end
             }.to raise_error(NoMethodError)
           end
         end
@@ -444,13 +446,13 @@ describe "Recipe DSL methods" do
 
         it "my_supplier does not work in a recipe" do
           expect_converge {
-            my_supplier 'blah' do; end
+            my_supplier "blah" do; end
           }.to raise_error(NoMethodError)
         end
 
         it "hemlock works in a recipe" do
           expect_recipe {
-            hemlock 'blah' do; end
+            hemlock "blah" do; end
           }.to emit_no_warnings_or_errors
           expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::MySupplier
         end
@@ -467,7 +469,7 @@ describe "Recipe DSL methods" do
 
         it "thingy3 works in a recipe" do
           expect_recipe {
-            thingy3 'blah' do; end
+            thingy3 "blah" do; end
           }.to emit_no_warnings_or_errors
           expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy3
         end
@@ -483,14 +485,14 @@ describe "Recipe DSL methods" do
 
           it "thingy3 works in a recipe and yields Thingy3 (the alphabetical one)" do
             recipe = converge {
-              thingy3 'blah' do; end
+              thingy3 "blah" do; end
             }
             expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy3
           end
 
           it "thingy4 does not work in a recipe" do
             expect_converge {
-              thingy4 'blah' do; end
+              thingy4 "blah" do; end
             }.to raise_error(NoMethodError)
           end
 
@@ -514,7 +516,7 @@ describe "Recipe DSL methods" do
 
         it "thingy5 works in a recipe" do
           expect_recipe {
-            thingy5 'blah' do; end
+            thingy5 "blah" do; end
           }.to emit_no_warnings_or_errors
           expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy5
         end
@@ -531,14 +533,14 @@ describe "Recipe DSL methods" do
 
           it "thingy6 works in a recipe and yields Thingy6" do
             recipe = converge {
-              thingy6 'blah' do; end
+              thingy6 "blah" do; end
             }
             expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy6
           end
 
           it "thingy5 works in a recipe and yields Foo::Thingy5 (the alphabetical one)" do
             recipe = converge {
-              thingy5 'blah' do; end
+              thingy5 "blah" do; end
             }
             expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy5
           end
@@ -558,7 +560,7 @@ describe "Recipe DSL methods" do
 
             it "thingy5reverse works in a recipe and yields AThingy5 (the alphabetical one)" do
               recipe = converge {
-                thingy5reverse 'blah' do; end
+                thingy5reverse "blah" do; end
               }
               expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::AThingy5
             end
@@ -577,7 +579,7 @@ describe "Recipe DSL methods" do
 
             it "thingy5_2 works in a recipe and yields the RecipeDSLSpaceNamespace one (the alphabetical one)" do
               recipe = converge {
-                thingy5_2 'blah' do; end
+                thingy5_2 "blah" do; end
               }
               expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy5
             end
@@ -596,7 +598,7 @@ describe "Recipe DSL methods" do
 
             it "thingy5_2reverse works in a recipe and yields the ARecipeDSLSpaceNamespace one (the alphabetical one)" do
               recipe = converge {
-                thingy5_2reverse 'blah' do; end
+                thingy5_2reverse "blah" do; end
               }
               expect(BaseThingy.created_resource).to eq ARecipeDSLSpecNamespace::Thingy5
             end
@@ -614,7 +616,7 @@ describe "Recipe DSL methods" do
 
           it "thingy3 works in a recipe" do
             expect_recipe {
-              thingy3 'blah' do; end
+              thingy3 "blah" do; end
             }.to emit_no_warnings_or_errors
             expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy3
           end
@@ -630,14 +632,14 @@ describe "Recipe DSL methods" do
 
             it "thingy3 works in a recipe and yields Thingy3 (the alphabetical one)" do
               recipe = converge {
-                thingy3 'blah' do; end
+                thingy3 "blah" do; end
               }
               expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy3
             end
 
             it "thingy4 does not work in a recipe" do
               expect_converge {
-                thingy4 'blah' do; end
+                thingy4 "blah" do; end
               }.to raise_error(NoMethodError)
             end
 
@@ -657,14 +659,14 @@ describe "Recipe DSL methods" do
 
             it "thingy3 works in a recipe and yields Thingy3 (the alphabetical one)" do
               recipe = converge {
-                thingy3 'blah' do; end
+                thingy3 "blah" do; end
               }
               expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy3
             end
 
             it "thingy4 does not work in a recipe" do
               expect_converge {
-                thingy4 'blah' do; end
+                thingy4 "blah" do; end
               }.to raise_error(NoMethodError)
             end
 
@@ -697,14 +699,14 @@ describe "Recipe DSL methods" do
 
           it "thingy7 works in a recipe and yields Thingy7" do
             recipe = converge {
-              thingy7 'blah' do; end
+              thingy7 "blah" do; end
             }
             expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy7
           end
 
           it "thingy8 works in a recipe and yields Thingy7 (alphabetical)" do
             recipe = converge {
-              thingy8 'blah' do; end
+              thingy8 "blah" do; end
             }
             expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy7
           end
@@ -728,21 +730,21 @@ describe "Recipe DSL methods" do
 
         it "thingy12 works in a recipe and yields Thingy12" do
           expect_recipe {
-            thingy12 'blah' do; end
+            thingy12 "blah" do; end
           }.to emit_no_warnings_or_errors
           expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy12
         end
 
         it "twizzle works in a recipe and yields Thingy12" do
           expect_recipe {
-            twizzle 'blah' do; end
+            twizzle "blah" do; end
           }.to emit_no_warnings_or_errors
           expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy12
         end
 
         it "twizzle2 works in a recipe and yields Thingy12" do
           expect_recipe {
-            twizzle2 'blah' do; end
+            twizzle2 "blah" do; end
           }.to emit_no_warnings_or_errors
           expect(BaseThingy.created_resource).to eq RecipeDSLSpecNamespace::Thingy12
         end
@@ -752,20 +754,20 @@ describe "Recipe DSL methods" do
         before(:context) {
           class MySuperThingyFoo < BaseThingy
             resource_name :my_super_thingy_foo
-            provides :my_super_thingy, platform: 'foo'
+            provides :my_super_thingy, platform: "foo"
           end
 
           class MySuperThingyBar < BaseThingy
             resource_name :my_super_thingy_bar
-            provides :my_super_thingy, platform: 'bar'
+            provides :my_super_thingy, platform: "bar"
           end
         }
 
         it "A run with platform 'foo' uses MySuperThingyFoo" do
           r = Cheffish::ChefRun.new(chef_config)
-          r.client.run_context.node.automatic['platform'] = 'foo'
+          r.client.run_context.node.automatic["platform"] = "foo"
           r.compile_recipe {
-            my_super_thingy 'blah' do; end
+            my_super_thingy "blah" do; end
           }
           r.converge
           expect(r).to emit_no_warnings_or_errors
@@ -774,9 +776,9 @@ describe "Recipe DSL methods" do
 
         it "A run with platform 'bar' uses MySuperThingyBar" do
           r = Cheffish::ChefRun.new(chef_config)
-          r.client.run_context.node.automatic['platform'] = 'bar'
+          r.client.run_context.node.automatic["platform"] = "bar"
           r.compile_recipe {
-            my_super_thingy 'blah' do; end
+            my_super_thingy "blah" do; end
           }
           r.converge
           expect(r).to emit_no_warnings_or_errors
@@ -785,10 +787,10 @@ describe "Recipe DSL methods" do
 
         it "A run with platform 'x' reports that my_super_thingy is not supported" do
           r = Cheffish::ChefRun.new(chef_config)
-          r.client.run_context.node.automatic['platform'] = 'x'
+          r.client.run_context.node.automatic["platform"] = "x"
           expect {
             r.compile_recipe {
-              my_super_thingy 'blah' do; end
+              my_super_thingy "blah" do; end
             }
           }.to raise_error(Chef::Exceptions::NoSuchResourceType)
         end
@@ -819,7 +821,7 @@ describe "Recipe DSL methods" do
         it "declaring a resource providing the same :thingy11 with os: 'linux' does not produce a warning" do
           expect(Chef::Log).not_to receive(:warn)
           class RecipeDSLSpecNamespace::Thingy11AlternateProvider < BaseThingy
-            provides :thingy11, os: 'linux'
+            provides :thingy11, os: "linux"
           end
         end
       end
@@ -832,7 +834,9 @@ describe "Recipe DSL methods" do
           def self.name
             "B"
           end
+
           def self.to_s; name; end
+
           def self.inspect; name.inspect; end
         end
         result.resource_name two_classes_one_dsl
@@ -846,7 +850,9 @@ describe "Recipe DSL methods" do
             def self.name
               "A"
             end
+
             def self.to_s; name; end
+
             def self.inspect; name.inspect; end
           end
           result.resource_name two_classes_one_dsl
@@ -859,7 +865,7 @@ describe "Recipe DSL methods" do
           recipe = converge {
             instance_eval("#{two_classes_one_dsl} 'blah'")
           }
-          expect(recipe.logged_warnings).to eq ''
+          expect(recipe.logged_warnings).to eq ""
           expect(BaseThingy.created_resource).to eq resource_class_a
         end
 
@@ -874,7 +880,9 @@ describe "Recipe DSL methods" do
             def self.name
               "Z"
             end
+
             def self.to_s; name; end
+
             def self.inspect; name.inspect; end
           end
           result.resource_name two_classes_one_dsl
@@ -887,7 +895,7 @@ describe "Recipe DSL methods" do
           recipe = converge {
             instance_eval("#{two_classes_one_dsl} 'blah'")
           }
-          expect(recipe.logged_warnings).to eq ''
+          expect(recipe.logged_warnings).to eq ""
           expect(BaseThingy.created_resource).to eq resource_class
         end
 
@@ -905,7 +913,7 @@ describe "Recipe DSL methods" do
             recipe = converge {
               instance_eval("#{two_classes_one_dsl} 'blah'")
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq resource_class_z
           end
 
@@ -923,7 +931,7 @@ describe "Recipe DSL methods" do
               recipe = converge {
                 instance_eval("#{two_classes_one_dsl} 'blah'")
               }
-              expect(recipe.logged_warnings).to eq ''
+              expect(recipe.logged_warnings).to eq ""
               expect(BaseThingy.created_resource).to eq resource_class
             end
 
@@ -944,7 +952,7 @@ describe "Recipe DSL methods" do
             recipe = converge {
               instance_eval("#{two_classes_one_dsl} 'blah'")
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq resource_class_z
           end
 
@@ -962,7 +970,7 @@ describe "Recipe DSL methods" do
               recipe = converge {
                 instance_eval("#{two_classes_one_dsl} 'blah'")
               }
-              expect(recipe.logged_warnings).to eq ''
+              expect(recipe.logged_warnings).to eq ""
               expect(BaseThingy.created_resource).to eq resource_class
             end
 
@@ -987,7 +995,7 @@ describe "Recipe DSL methods" do
               recipe = converge {
                 instance_eval("#{two_classes_one_dsl} 'blah'")
               }
-              expect(recipe.logged_warnings).to eq ''
+              expect(recipe.logged_warnings).to eq ""
               expect(BaseThingy.created_resource).to eq resource_class
             end
 
@@ -1009,7 +1017,9 @@ describe "Recipe DSL methods" do
             def self.name
               "B"
             end
+
             def self.to_s; name; end
+
             def self.inspect; name.inspect; end
           end
           result.provides two_classes_one_dsl
@@ -1023,7 +1033,9 @@ describe "Recipe DSL methods" do
               def self.name
                 "A"
               end
+
               def self.to_s; name; end
+
               def self.inspect; name.inspect; end
             end
             result
@@ -1036,7 +1048,7 @@ describe "Recipe DSL methods" do
               recipe = converge {
                 instance_eval("#{two_classes_one_dsl} 'blah'")
               }
-              expect(recipe.logged_warnings).to eq ''
+              expect(recipe.logged_warnings).to eq ""
               expect(BaseThingy.created_provider).to eq provider_class_a
             end
           end
@@ -1048,7 +1060,7 @@ describe "Recipe DSL methods" do
               recipe = converge {
                 instance_eval("#{two_classes_one_dsl} 'blah'")
               }
-              expect(recipe.logged_warnings).to eq ''
+              expect(recipe.logged_warnings).to eq ""
               expect(BaseThingy.created_provider).to eq provider_class
             end
           end
@@ -1060,7 +1072,9 @@ describe "Recipe DSL methods" do
               def self.name
                 "Z"
               end
+
               def self.to_s; name; end
+
               def self.inspect; name.inspect; end
             end
             result
@@ -1075,7 +1089,7 @@ describe "Recipe DSL methods" do
               recipe = converge {
                 instance_eval("#{two_classes_one_dsl} 'blah'")
               }
-              expect(recipe.logged_warnings).to eq ''
+              expect(recipe.logged_warnings).to eq ""
               expect(BaseThingy.created_provider).to eq provider_class
             end
 
@@ -1087,7 +1101,7 @@ describe "Recipe DSL methods" do
                 recipe = converge {
                   instance_eval("#{two_classes_one_dsl} 'blah'")
                 }
-                expect(recipe.logged_warnings).to eq ''
+                expect(recipe.logged_warnings).to eq ""
                 expect(BaseThingy.created_provider).to eq provider_class_z
               end
             end
@@ -1104,7 +1118,7 @@ describe "Recipe DSL methods" do
                 recipe = converge {
                   instance_eval("#{two_classes_one_dsl} 'blah'")
                 }
-                expect(recipe.logged_warnings).to eq ''
+                expect(recipe.logged_warnings).to eq ""
                 expect(BaseThingy.created_provider).to eq provider_class
               end
             end
@@ -1118,7 +1132,7 @@ describe "Recipe DSL methods" do
                 recipe = converge {
                   instance_eval("#{two_classes_one_dsl} 'blah'")
                 }
-                expect(recipe.logged_warnings).to eq ''
+                expect(recipe.logged_warnings).to eq ""
                 expect(BaseThingy.created_provider).to eq provider_class
               end
             end
@@ -1132,11 +1146,13 @@ describe "Recipe DSL methods" do
             def self.name
               "Blarghle"
             end
+
             def self.to_s; name; end
+
             def self.inspect; name.inspect; end
           end
           result.resource_name two_classes_one_dsl
-          result.provides two_classes_one_dsl, os: 'blarghle'
+          result.provides two_classes_one_dsl, os: "blarghle"
           result
         }
         before { resource_class_blarghle } # pull on it so it gets defined before the recipe runs
@@ -1145,10 +1161,10 @@ describe "Recipe DSL methods" do
           two_classes_one_dsl = self.two_classes_one_dsl
           recipe = converge {
             # this is an ugly way to test, make Cheffish expose node attrs
-            run_context.node.automatic[:os] = 'blarghle'
+            run_context.node.automatic[:os] = "blarghle"
             instance_eval("#{two_classes_one_dsl} 'blah' do; end")
           }
-          expect(recipe.logged_warnings).to eq ''
+          expect(recipe.logged_warnings).to eq ""
           expect(BaseThingy.created_resource).to eq resource_class_blarghle
         end
 
@@ -1156,10 +1172,10 @@ describe "Recipe DSL methods" do
           two_classes_one_dsl = self.two_classes_one_dsl
           recipe = converge {
             # this is an ugly way to test, make Cheffish expose node attrs
-            run_context.node.automatic[:os] = 'linux'
+            run_context.node.automatic[:os] = "linux"
             instance_eval("#{two_classes_one_dsl} 'blah' do; end")
           }
-          expect(recipe.logged_warnings).to eq ''
+          expect(recipe.logged_warnings).to eq ""
           expect(BaseThingy.created_resource).to eq resource_class
         end
       end
@@ -1170,6 +1186,7 @@ describe "Recipe DSL methods" do
         def self.called_provides
           @called_provides
         end
+
         def to_s
           "MyResource"
         end
@@ -1196,7 +1213,7 @@ describe "Recipe DSL methods" do
             recipe = converge {
               instance_eval("#{dsl_name} 'foo'")
             }
-            expect(recipe.logged_warnings).to eq ''
+            expect(recipe.logged_warnings).to eq ""
             expect(BaseThingy.created_resource).to eq resource_class
             expect(resource_class.called_provides).to be_truthy
           end
@@ -1237,8 +1254,11 @@ describe "Recipe DSL methods" do
               def self.name
                 "MyProvider"
               end
+
               def self.to_s; name; end
+
               def self.inspect; name.inspect; end
+
               def self.called_provides
                 @called_provides
               end
@@ -1256,7 +1276,7 @@ describe "Recipe DSL methods" do
 
             context "with supports? returning true" do
               before do
-                provider_class.define_singleton_method(:supports?) { |resource,action| true }
+                provider_class.define_singleton_method(:supports?) { |resource, action| true }
               end
 
               it "my_resource runs the provider and does not emit a warning" do
@@ -1264,7 +1284,7 @@ describe "Recipe DSL methods" do
                 recipe = converge {
                   instance_eval("#{my_resource} 'foo'")
                 }
-                expect(recipe.logged_warnings).to eq ''
+                expect(recipe.logged_warnings).to eq ""
                 expect(BaseThingy.created_provider).to eq provider_class
               end
 
@@ -1274,8 +1294,11 @@ describe "Recipe DSL methods" do
                     def self.name
                       "MyProvider2"
                     end
+
                     def self.to_s; name; end
+
                     def self.inspect; name.inspect; end
+
                     def self.called_provides
                       @called_provides
                     end
@@ -1291,7 +1314,7 @@ describe "Recipe DSL methods" do
                   recipe = converge {
                     instance_eval("#{my_resource} 'foo'")
                   }
-                  expect(recipe.logged_warnings).to eq ''
+                  expect(recipe.logged_warnings).to eq ""
                   expect(BaseThingy.created_provider).to eq provider_class
                 end
               end
@@ -1299,7 +1322,7 @@ describe "Recipe DSL methods" do
 
             context "with supports? returning false" do
               before do
-                provider_class.define_singleton_method(:supports?) { |resource,action| false }
+                provider_class.define_singleton_method(:supports?) { |resource, action| false }
               end
 
               # TODO no warning? ick
@@ -1308,7 +1331,7 @@ describe "Recipe DSL methods" do
                 recipe = converge {
                   instance_eval("#{my_resource} 'foo'")
                 }
-                expect(recipe.logged_warnings).to eq ''
+                expect(recipe.logged_warnings).to eq ""
                 expect(BaseThingy.created_provider).to eq provider_class
               end
 
@@ -1319,8 +1342,11 @@ describe "Recipe DSL methods" do
                     def self.name
                       "MyProvider2"
                     end
+
                     def self.to_s; name; end
+
                     def self.inspect; name.inspect; end
+
                     def self.called_provides
                       @called_provides
                     end
@@ -1337,7 +1363,7 @@ describe "Recipe DSL methods" do
                   recipe = converge {
                     instance_eval("#{my_resource} 'foo'")
                   }
-                  expect(recipe.logged_warnings).to eq ''
+                  expect(recipe.logged_warnings).to eq ""
                   expect(BaseThingy.created_provider).to eq provider_class2
                 end
               end
@@ -1363,7 +1389,7 @@ describe "Recipe DSL methods" do
                 recipe = converge {
                   instance_eval("#{my_resource} 'foo'")
                 }
-                expect(recipe.logged_warnings).to eq ''
+                expect(recipe.logged_warnings).to eq ""
                 expect(BaseThingy.created_provider).to eq provider_class
                 expect(provider_class.called_provides).to be_truthy
               end
@@ -1475,6 +1501,7 @@ describe "Recipe DSL methods" do
       class Chef::Provider::LwResourceWithHwProviderTestCase < Chef::Provider
         def load_current_resource
         end
+
         def action_create
           new_resource.created_provider = self.class
         end
@@ -1484,7 +1511,7 @@ describe "Recipe DSL methods" do
     it "looks up the provider in Chef::Provider converting the resource name from snake case to camel case" do
       resource = nil
       recipe = converge {
-        resource = lw_resource_with_hw_provider_test_case 'blah' do; end
+        resource = lw_resource_with_hw_provider_test_case "blah" do; end
       }
       expect(resource.created_provider).to eq(Chef::Provider::LwResourceWithHwProviderTestCase)
     end