chef 12.6.0 → 12.7.2

data/spec/unit/provider/service_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: AJ Christensen (<aj@hjksolutions.com>)
-# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# Copyright:: Copyright 2008-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Chef::Provider::Service do
   before do
@@ -49,7 +49,6 @@ describe Chef::Provider::Service do
     end
   end
 
-
   describe "when disabling the service" do
     it "should disable the service if enabled and set the resource as updated" do
       allow(@current_resource).to receive(:enabled).and_return(true)

data/spec/unit/provider/subversion_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Daniel DeLeo (<dan@kallistec.com>)
-# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# Copyright:: Copyright 2008-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Chef::Provider::Subversion do
 
@@ -36,8 +36,8 @@ describe Chef::Provider::Subversion do
 
   it "converts resource attributes to options for run_command and popen4" do
     expect(@provider.run_options).to eq({})
-    @resource.user 'deployninja'
-    expect(@provider.run_options).to eq({:user => "deployninja"})
+    @resource.user "deployninja"
+    expect(@provider.run_options).to eq({ :user => "deployninja" })
   end
 
   context "determining the revision of the currently deployed code" do
@@ -64,18 +64,18 @@ describe Chef::Provider::Subversion do
                           "Last Changed Rev: 11410\n" + # Last Changed Rev is preferred to Revision
                           "Last Changed Date: 2009-03-25 06:09:56 -0600 (Wed, 25 Mar 2009)\n\n"
       expect(::File).to receive(:exist?).at_least(1).times.with("/my/deploy/dir/.svn").and_return(true)
-      expected_command = ["svn info", {:cwd => '/my/deploy/dir', :returns => [0,1]}]
+      expected_command = ["svn info", { :cwd => "/my/deploy/dir", :returns => [0, 1] }]
       expect(@provider).to receive(:shell_out!).with(*expected_command).
-                             and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
+        and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
       expect(@provider.find_current_revision).to eql("11410")
     end
 
     it "gives nil as the current revision if the deploy dir isn't a SVN working copy" do
       example_svn_info = "svn: '/tmp/deploydir' is not a working copy\n"
       expect(::File).to receive(:exist?).with("/my/deploy/dir/.svn").and_return(true)
-      expected_command = ["svn info", {:cwd => '/my/deploy/dir', :returns => [0,1]}]
+      expected_command = ["svn info", { :cwd => "/my/deploy/dir", :returns => [0, 1] }]
       expect(@provider).to receive(:shell_out!).with(*expected_command).
-                             and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
+        and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
       expect(@provider.find_current_revision).to be_nil
     end
 
@@ -119,19 +119,19 @@ describe Chef::Provider::Subversion do
                           "Last Changed Rev: 11410\n" + # Last Changed Rev is preferred to Revision
                           "Last Changed Date: 2009-03-25 06:09:56 -0600 (Wed, 25 Mar 2009)\n\n"
       @resource.revision "HEAD"
-      expected_command = ["svn info http://svn.example.org/trunk/ --no-auth-cache  -rHEAD", {:cwd => '/my/deploy/dir', :returns => [0,1]}]
+      expected_command = ["svn info http://svn.example.org/trunk/ --no-auth-cache  -rHEAD", { :cwd => "/my/deploy/dir", :returns => [0, 1] }]
       expect(@provider).to receive(:shell_out!).with(*expected_command).
-                                        and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
+        and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
       expect(@provider.revision_int).to eql("11410")
     end
 
     it "returns a helpful message if data from `svn info` can't be parsed" do
       example_svn_info =  "some random text from an error message\n"
       @resource.revision "HEAD"
-      expected_command = ["svn info http://svn.example.org/trunk/ --no-auth-cache  -rHEAD", {:cwd => '/my/deploy/dir', :returns => [0,1]}]
+      expected_command = ["svn info http://svn.example.org/trunk/ --no-auth-cache  -rHEAD", { :cwd => "/my/deploy/dir", :returns => [0, 1] }]
       expect(@provider).to receive(:shell_out!).with(*expected_command).
-                             and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
-      expect {@provider.revision_int}.to raise_error(RuntimeError, "Could not parse `svn info` data: some random text from an error message\n")
+        and_return(double("ShellOut result", :stdout => example_svn_info, :stderr => ""))
+      expect { @provider.revision_int }.to raise_error(RuntimeError, "Could not parse `svn info` data: some random text from an error message\n")
 
     end
 
@@ -154,8 +154,7 @@ describe Chef::Provider::Subversion do
 
   it "generates a checkout command with arbitrary options" do
     @resource.svn_arguments "--no-auth-cache"
-    expect(@provider.checkout_command).to eql("svn checkout --no-auth-cache -q  -r12345 "+
-                                          "http://svn.example.org/trunk/ /my/deploy/dir")
+    expect(@provider.checkout_command).to eql("svn checkout --no-auth-cache -q  -r12345 " + "http://svn.example.org/trunk/ /my/deploy/dir")
   end
 
   it "generates a sync command with default options" do
@@ -195,14 +194,14 @@ describe Chef::Provider::Subversion do
   end
 
   it "raises an error if the svn checkout command would fail because the enclosing directory doesn't exist" do
-    expect {@provider.run_action(:sync)}.to raise_error(Chef::Exceptions::MissingParentDirectory)
+    expect { @provider.run_action(:sync) }.to raise_error(Chef::Exceptions::MissingParentDirectory)
   end
 
   it "should not checkout if the destination exists or is a non empty directory" do
     allow(::File).to receive(:exist?).with("/my/deploy/dir/.svn").and_return(false)
     allow(::File).to receive(:exist?).with("/my/deploy/dir").and_return(true)
     allow(::File).to receive(:directory?).with("/my/deploy").and_return(true)
-    allow(::Dir).to receive(:entries).with("/my/deploy/dir").and_return(['.','..','foo','bar'])
+    allow(::Dir).to receive(:entries).with("/my/deploy/dir").and_return([".", "..", "foo", "bar"])
     expect(@provider).not_to receive(:checkout_command)
     @provider.run_action(:checkout)
     expect(@resource).not_to be_updated
@@ -213,7 +212,7 @@ describe Chef::Provider::Subversion do
     @resource.user "whois"
     @resource.group "thisis"
     expected_cmd = "svn checkout -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir"
-    expect(@provider).to receive(:shell_out!).with(expected_cmd, {user: "whois", group: "thisis"})
+    expect(@provider).to receive(:shell_out!).with(expected_cmd, { user: "whois", group: "thisis" })
     @provider.run_action(:checkout)
     expect(@resource).to be_updated
   end
@@ -246,7 +245,7 @@ describe Chef::Provider::Subversion do
   it "does not fetch any updates if the remote revision matches the current revision" do
     allow(::File).to receive(:directory?).with("/my/deploy").and_return(true)
     expect(::File).to receive(:exist?).with("/my/deploy/dir/.svn").and_return(true)
-    allow(@provider).to receive(:find_current_revision).and_return('12345')
+    allow(@provider).to receive(:find_current_revision).and_return("12345")
     allow(@provider).to receive(:current_revision_matches_target_revision?).and_return(true)
     @provider.run_action(:sync)
     expect(@resource).not_to be_updated
@@ -267,29 +266,29 @@ describe Chef::Provider::Subversion do
     it "selects 'svn' as the binary by default" do
       @resource.svn_binary nil
       allow(ChefConfig).to receive(:windows?) { false }
-      expect(@provider).to receive(:svn_binary).and_return('svn')
+      expect(@provider).to receive(:svn_binary).and_return("svn")
       expect(@provider.export_command).to eql(
-        'svn export --force -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir')
+        "svn export --force -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir")
     end
 
     it "selects an svn binary with an exe extension on windows" do
       @resource.svn_binary nil
       allow(ChefConfig).to receive(:windows?) { true }
-      expect(@provider).to receive(:svn_binary).and_return('svn.exe')
+      expect(@provider).to receive(:svn_binary).and_return("svn.exe")
       expect(@provider.export_command).to eql(
-        'svn.exe export --force -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir')
+        "svn.exe export --force -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir")
     end
 
     it "uses a custom svn binary as part of the svn command" do
-      @resource.svn_binary 'teapot'
-      expect(@provider).to receive(:svn_binary).and_return('teapot')
+      @resource.svn_binary "teapot"
+      expect(@provider).to receive(:svn_binary).and_return("teapot")
       expect(@provider.export_command).to eql(
-        'teapot export --force -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir')
+        "teapot export --force -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir")
     end
 
     it "wraps custom svn binary with quotes if it contains whitespace" do
-      @resource.svn_binary 'c:/program files (x86)/subversion/svn.exe'
-      expect(@provider).to receive(:svn_binary).and_return('c:/program files (x86)/subversion/svn.exe')
+      @resource.svn_binary "c:/program files (x86)/subversion/svn.exe"
+      expect(@provider).to receive(:svn_binary).and_return("c:/program files (x86)/subversion/svn.exe")
       expect(@provider.export_command).to eql(
         '"c:/program files (x86)/subversion/svn.exe" export --force -q  -r12345 http://svn.example.org/trunk/ /my/deploy/dir')
     end

data/spec/unit/provider/template/content_spec.rb

@@ -1,6 +1,6 @@
 #
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2013-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Chef::Provider::Template::Content do
 
@@ -30,13 +30,13 @@ describe Chef::Provider::Template::Content do
 
   let(:new_resource) do
     double("Chef::Resource::Template (new)",
-         :cookbook_name => 'openldap',
-         :recipe_name => 'default',
+         :cookbook_name => "openldap",
+         :recipe_name => "default",
          :source_line => "/Users/lamont/solo/cookbooks/openldap/recipes/default.rb:2:in `from_file'",
          :source_line_file => "/Users/lamont/solo/cookbooks/openldap/recipes/default.rb",
          :source_line_number => "2",
-         :source => 'openldap_stuff.conf.erb',
-         :name => 'openldap_stuff.conf',
+         :source => "openldap_stuff.conf.erb",
+         :name => "openldap_stuff.conf",
          :path => resource_path,
          :local => false,
          :cookbook => nil,
@@ -47,8 +47,8 @@ describe Chef::Provider::Template::Content do
   end
 
   let(:rendered_file_locations) {
-    [Dir.tmpdir + '/openldap_stuff.conf',
-     enclosing_directory + '/openldap_stuff.conf']
+    [Dir.tmpdir + "/openldap_stuff.conf",
+     enclosing_directory + "/openldap_stuff.conf"]
   }
 
   let(:run_context) do
@@ -73,20 +73,20 @@ describe Chef::Provider::Template::Content do
   end
 
   it "finds the template file in the cookbook cache if it isn't local" do
-    expect(content.template_location).to eq(CHEF_SPEC_DATA + '/cookbooks/openldap/templates/default/openldap_stuff.conf.erb')
+    expect(content.template_location).to eq(CHEF_SPEC_DATA + "/cookbooks/openldap/templates/default/openldap_stuff.conf.erb")
   end
 
   it "finds the template file locally if it is local" do
     allow(new_resource).to receive(:local).and_return(true)
-    allow(new_resource).to receive(:source).and_return('/tmp/its_on_disk.erb')
-    expect(content.template_location).to eq('/tmp/its_on_disk.erb')
+    allow(new_resource).to receive(:source).and_return("/tmp/its_on_disk.erb")
+    expect(content.template_location).to eq("/tmp/its_on_disk.erb")
   end
 
   it "should use the cookbook name if defined in the template resource" do
-    allow(new_resource).to receive(:cookbook_name).and_return('apache2')
-    allow(new_resource).to receive(:cookbook).and_return('openldap')
+    allow(new_resource).to receive(:cookbook_name).and_return("apache2")
+    allow(new_resource).to receive(:cookbook).and_return("openldap")
     allow(new_resource).to receive(:source).and_return("test.erb")
-    expect(content.template_location).to eq(CHEF_SPEC_DATA + '/cookbooks/openldap/templates/default/test.erb')
+    expect(content.template_location).to eq(CHEF_SPEC_DATA + "/cookbooks/openldap/templates/default/test.erb")
   end
 
   it "returns a tempfile in the tempdir when :file_staging_uses_destdir is not set" do
@@ -113,7 +113,7 @@ describe Chef::Provider::Template::Content do
 
     it "fails when :file_desployment_uses_destdir is set" do
       Chef::Config[:file_staging_uses_destdir] = true
-      expect{content.tempfile}.to raise_error(Chef::Exceptions::FileContentStagingError)
+      expect { content.tempfile }.to raise_error(Chef::Exceptions::FileContentStagingError)
     end
 
     it "returns a tempfile in the tempdir when :file_desployment_uses_destdir is not set" do
@@ -130,14 +130,14 @@ describe Chef::Provider::Template::Content do
   describe "when using location helpers" do
     let(:new_resource) do
       double("Chef::Resource::Template (new)",
-             :cookbook_name => 'openldap',
-             :recipe_name => 'default',
+             :cookbook_name => "openldap",
+             :recipe_name => "default",
              :source_line => CHEF_SPEC_DATA + "/cookbooks/openldap/recipes/default.rb:2:in `from_file'",
              :source_line_file => CHEF_SPEC_DATA + "/cookbooks/openldap/recipes/default.rb",
              :source_line_number => "2",
-             :source => 'helpers.erb',
-             :name => 'helpers.erb',
-             :path => CHEF_SPEC_DATA + '/cookbooks/openldap/templates/default/helpers.erb',
+             :source => "helpers.erb",
+             :name => "helpers.erb",
+             :path => CHEF_SPEC_DATA + "/cookbooks/openldap/templates/default/helpers.erb",
              :local => false,
              :cookbook => nil,
              :variables => {},

data/spec/unit/provider/template_spec.rb

@@ -1,7 +1,7 @@
 #
-# Author:: Adam Jacob (<adam@opscode.com>)
-# Author:: Lamont Granquist (<lamont@opscode.com>)
-# Copyright:: Copyright (c) 2008-2013 Opscode, Inc.
+# Author:: Adam Jacob (<adam@chef.io>)
+# Author:: Lamont Granquist (<lamont@chef.io>)
+# Copyright:: Copyright 2008-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,17 +17,16 @@
 # limitations under the License.
 #
 
-require 'stringio'
-require 'spec_helper'
-require 'etc'
-require 'ostruct'
-require 'support/shared/unit/provider/file'
-
+require "stringio"
+require "spec_helper"
+require "etc"
+require "ostruct"
+require "support/shared/unit/provider/file"
 
 describe Chef::Provider::Template do
-  let(:node) { double('Chef::Node') }
-  let(:events) { double('Chef::Events').as_null_object }  # mock all the methods
-  let(:run_context) { double('Chef::RunContext', :node => node, :events => events) }
+  let(:node) { double("Chef::Node") }
+  let(:events) { double("Chef::Events").as_null_object } # mock all the methods
+  let(:run_context) { double("Chef::RunContext", :node => node, :events => events) }
   let(:enclosing_directory) {
     canonicalize_path(File.expand_path(File.join(CHEF_SPEC_DATA, "templates")))
   }
@@ -50,7 +49,7 @@ describe Chef::Provider::Template do
   end
 
   let(:content) do
-    content = double('Chef::Provider::File::Content::Template', :template_location => "/foo/bar/baz")
+    content = double("Chef::Provider::File::Content::Template", :template_location => "/foo/bar/baz")
     allow(File).to receive(:exists?).with("/foo/bar/baz").and_return(true)
     content
   end
@@ -59,9 +58,9 @@ describe Chef::Provider::Template do
 
   context "when creating the template" do
 
-    let(:node) { double('Chef::Node') }
-    let(:events) { double('Chef::Events').as_null_object }  # mock all the methods
-    let(:run_context) { double('Chef::RunContext', :node => node, :events => events) }
+    let(:node) { double("Chef::Node") }
+    let(:events) { double("Chef::Events").as_null_object } # mock all the methods
+    let(:run_context) { double("Chef::RunContext", :node => node, :events => events) }
     let(:enclosing_directory) {
       canonicalize_path(File.expand_path(File.join(CHEF_SPEC_DATA, "templates")))
     }

data/spec/unit/provider/user/dscl_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Dreamcat4 (<dreamcat4@gmail.com>)
-# Copyright:: Copyright (c) 2009 OpsCode, Inc.
+# Copyright:: Copyright 2009-2016, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -18,9 +18,9 @@
 
 ShellCmdResult = Struct.new(:stdout, :stderr, :exitstatus)
 
-require 'spec_helper'
-require 'ostruct'
-require 'mixlib/shellout'
+require "spec_helper"
+require "ostruct"
+require "mixlib/shellout"
 
 describe Chef::Provider::User::Dscl do
   before do
@@ -114,32 +114,32 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
 
   describe "when shelling out to dscl" do
     it "should run dscl with the supplied cmd /Path args" do
-      shell_return = ShellCmdResult.new('stdout', 'err', 0)
+      shell_return = ShellCmdResult.new("stdout", "err", 0)
       expect(provider).to receive(:shell_out).with("dscl . -cmd /Path args").and_return(shell_return)
-      expect(provider.run_dscl("cmd /Path args")).to eq('stdout')
+      expect(provider.run_dscl("cmd /Path args")).to eq("stdout")
     end
 
     it "returns an empty string from delete commands" do
-      shell_return = ShellCmdResult.new('out', 'err', 23)
+      shell_return = ShellCmdResult.new("out", "err", 23)
       expect(provider).to receive(:shell_out).with("dscl . -delete /Path args").and_return(shell_return)
       expect(provider.run_dscl("delete /Path args")).to eq("")
     end
 
     it "should raise an exception for any other command" do
-      shell_return = ShellCmdResult.new('out', 'err', 23)
-      expect(provider).to receive(:shell_out).with('dscl . -cmd /Path arguments').and_return(shell_return)
+      shell_return = ShellCmdResult.new("out", "err", 23)
+      expect(provider).to receive(:shell_out).with("dscl . -cmd /Path arguments").and_return(shell_return)
       expect { provider.run_dscl("cmd /Path arguments") }.to raise_error(Chef::Exceptions::DsclCommandFailed)
     end
 
     it "raises an exception when dscl reports 'no such key'" do
-      shell_return = ShellCmdResult.new("No such key: ", 'err', 23)
-      expect(provider).to receive(:shell_out).with('dscl . -cmd /Path args').and_return(shell_return)
+      shell_return = ShellCmdResult.new("No such key: ", "err", 23)
+      expect(provider).to receive(:shell_out).with("dscl . -cmd /Path args").and_return(shell_return)
       expect { provider.run_dscl("cmd /Path args") }.to raise_error(Chef::Exceptions::DsclCommandFailed)
     end
 
     it "raises an exception when dscl reports 'eDSRecordNotFound'" do
-      shell_return = ShellCmdResult.new("<dscl_cmd> DS Error: -14136 (eDSRecordNotFound)", 'err', -14136)
-      expect(provider).to receive(:shell_out).with('dscl . -cmd /Path args').and_return(shell_return)
+      shell_return = ShellCmdResult.new("<dscl_cmd> DS Error: -14136 (eDSRecordNotFound)", "err", -14136)
+      expect(provider).to receive(:shell_out).with("dscl . -cmd /Path args").and_return(shell_return)
       expect { provider.run_dscl("cmd /Path args") }.to raise_error(Chef::Exceptions::DsclCommandFailed)
     end
   end
@@ -197,7 +197,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
     end
 
     it "finds a valid, unused uid when none is specified" do
-      expect(provider).to receive(:run_dscl).with("list /Users uid").and_return('')
+      expect(provider).to receive(:run_dscl).with("list /Users uid").and_return("")
       expect(provider).to receive(:run_dscl).with("create /Users/toor UniqueID 501")
       expect(provider).to receive(:get_free_uid).and_return(501)
       provider.dscl_set_uid
@@ -207,7 +207,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
     it "sets the uid specified in the resource" do
       new_resource.uid(1000)
       expect(provider).to receive(:run_dscl).with("create /Users/toor UniqueID 1000").and_return(true)
-      expect(provider).to receive(:run_dscl).with("list /Users uid").and_return('')
+      expect(provider).to receive(:run_dscl).with("list /Users uid").and_return("")
       provider.dscl_set_uid
     end
   end
@@ -219,7 +219,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
 
     before do
       new_resource.supports({ :manage_home => true })
-      new_resource.home('/Users/toor')
+      new_resource.home("/Users/toor")
 
       provider.current_resource = current_resource
     end
@@ -230,40 +230,39 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
       provider.dscl_set_home
     end
 
-
     it "raises InvalidHomeDirectory when the resource's home directory doesn't look right" do
-      new_resource.home('epic-fail')
+      new_resource.home("epic-fail")
       expect { provider.dscl_set_home }.to raise_error(Chef::Exceptions::InvalidHomeDirectory)
     end
 
     it "moves the users home to the new location if it exists and the target location is different" do
       new_resource.supports(:manage_home => true)
 
-      current_home = CHEF_SPEC_DATA + '/old_home_dir'
-      current_home_files = [current_home + '/my-dot-emacs', current_home + '/my-dot-vim']
+      current_home = CHEF_SPEC_DATA + "/old_home_dir"
+      current_home_files = [current_home + "/my-dot-emacs", current_home + "/my-dot-vim"]
       current_resource.home(current_home)
       new_resource.gid(23)
-      allow(::File).to receive(:exists?).with('/old/home/toor').and_return(true)
-      allow(::File).to receive(:exists?).with('/Users/toor').and_return(true)
+      allow(::File).to receive(:exists?).with("/old/home/toor").and_return(true)
+      allow(::File).to receive(:exists?).with("/Users/toor").and_return(true)
 
-      expect(FileUtils).to receive(:mkdir_p).with('/Users/toor').and_return(true)
+      expect(FileUtils).to receive(:mkdir_p).with("/Users/toor").and_return(true)
       expect(FileUtils).to receive(:rmdir).with(current_home)
-      expect(::Dir).to receive(:glob).with("#{CHEF_SPEC_DATA}/old_home_dir/*",::File::FNM_DOTMATCH).and_return(current_home_files)
+      expect(::Dir).to receive(:glob).with("#{CHEF_SPEC_DATA}/old_home_dir/*", ::File::FNM_DOTMATCH).and_return(current_home_files)
       expect(FileUtils).to receive(:mv).with(current_home_files, "/Users/toor", :force => true)
-      expect(FileUtils).to receive(:chown_R).with('toor','23','/Users/toor')
+      expect(FileUtils).to receive(:chown_R).with("toor", "23", "/Users/toor")
 
       expect(provider).to receive(:run_dscl).with("create /Users/toor NFSHomeDirectory '/Users/toor'")
       provider.dscl_set_home
     end
 
     it "should raise an exception when the systems user template dir (skel) cannot be found" do
-      allow(::File).to receive(:exists?).and_return(false,false,false)
+      allow(::File).to receive(:exists?).and_return(false, false, false)
       expect { provider.dscl_set_home }.to raise_error(Chef::Exceptions::User)
     end
 
     it "should run ditto to copy any missing files from skel to the new home dir" do
       expect(::File).to receive(:exists?).with("/System/Library/User\ Template/English.lproj").and_return(true)
-      expect(FileUtils).to receive(:chown_R).with('toor', '', '/Users/toor')
+      expect(FileUtils).to receive(:chown_R).with("toor", "", "/Users/toor")
       expect(provider).to receive(:shell_out!).with("ditto '/System/Library/User Template/English.lproj' '/Users/toor'")
       provider.ditto_home
     end
@@ -382,7 +381,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
       expect(provider).to receive(:shell_out).with("dscacheutil '-flushcache'")
       expect(provider).to receive(:shell_out).with("plutil -convert xml1 -o - /var/db/dslocal/nodes/Default/users/toor.plist") do
         if user_plist_file.nil?
-          ShellCmdResult.new('Can not find the file', 'Sorry!!', 1)
+          ShellCmdResult.new("Can not find the file", "Sorry!!", 1)
         else
           ShellCmdResult.new(File.read(File.join(CHEF_SPEC_DATA, "mac_users/#{user_plist_file}.plist.xml")), "", 0)
         end
@@ -656,7 +655,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30")
         it "password_shadow_info should have salted-sha-512 format" do
           shadow_info = provider.prepare_password_shadow_info
           expect(shadow_info).to have_key("SALTED-SHA512")
-          info = shadow_info["SALTED-SHA512"].string.unpack('H*').first
+          info = shadow_info["SALTED-SHA512"].string.unpack("H*").first
           expect(provider.salted_sha512?(info)).to be_truthy
         end
       end
@@ -667,7 +666,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30")
         it "password_shadow_info should have salted-sha-512 format" do
           shadow_info = provider.prepare_password_shadow_info
           expect(shadow_info).to have_key("SALTED-SHA512")
-          info = shadow_info["SALTED-SHA512"].string.unpack('H*').first
+          info = shadow_info["SALTED-SHA512"].string.unpack("H*").first
           expect(provider.salted_sha512?(info)).to be_truthy
           expect(info).to eq(vagrant_sha_512)
         end
@@ -689,7 +688,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30")
             expect(shadow_info["SALTED-SHA512-PBKDF2"]).to have_key("entropy")
             expect(shadow_info["SALTED-SHA512-PBKDF2"]).to have_key("salt")
             expect(shadow_info["SALTED-SHA512-PBKDF2"]).to have_key("iterations")
-            info = shadow_info["SALTED-SHA512-PBKDF2"]["entropy"].string.unpack('H*').first
+            info = shadow_info["SALTED-SHA512-PBKDF2"]["entropy"].string.unpack("H*").first
             expect(provider.salted_sha512_pbkdf2?(info)).to be_truthy
           end
         end
@@ -705,7 +704,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30")
             expect(shadow_info["SALTED-SHA512-PBKDF2"]).to have_key("entropy")
             expect(shadow_info["SALTED-SHA512-PBKDF2"]).to have_key("salt")
             expect(shadow_info["SALTED-SHA512-PBKDF2"]).to have_key("iterations")
-            info = shadow_info["SALTED-SHA512-PBKDF2"]["entropy"].string.unpack('H*').first
+            info = shadow_info["SALTED-SHA512-PBKDF2"]["entropy"].string.unpack("H*").first
             expect(provider.salted_sha512_pbkdf2?(info)).to be_truthy
             expect(info).to eq(vagrant_sha_512_pbkdf2)
           end
@@ -720,7 +719,7 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30")
     end
 
     it "should sleep and flush the dscl cache before saving the password" do
-      expect(provider).to receive(:prepare_password_shadow_info).and_return({ })
+      expect(provider).to receive(:prepare_password_shadow_info).and_return({})
       mock_shellout = double("Mock::Shellout")
       allow(mock_shellout).to receive(:run_command)
       expect(Mixlib::ShellOut).to receive(:new).and_return(mock_shellout)
@@ -791,8 +790,8 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30")
       end
 
       it "should raise an exception when the group does not exist" do
-        shell_return = ShellCmdResult.new("<dscl_cmd> DS Error: -14136 (eDSRecordNotFound)", 'err', -14136)
-        expect(provider).to receive(:shell_out).with('dscl . -read /Groups/newgroup PrimaryGroupID').and_return(shell_return)
+        shell_return = ShellCmdResult.new("<dscl_cmd> DS Error: -14136 (eDSRecordNotFound)", "err", -14136)
+        expect(provider).to receive(:shell_out).with("dscl . -read /Groups/newgroup PrimaryGroupID").and_return(shell_return)
         expect { provider.dscl_set_gid }.to raise_error(Chef::Exceptions::GroupIDNotFound)
       end
     end
@@ -814,8 +813,8 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30")
       new_resource.username "mud"
       new_resource.uid 2342
       new_resource.gid 2342
-      new_resource.home '/Users/death'
-      new_resource.password 'goaway'
+      new_resource.home "/Users/death"
+      new_resource.password "goaway"
     end
 
     it "sets the user, comment field, uid, gid, moves the home directory, sets the shell, and sets the password" do