chef 12.0.3-x86-mingw32 → 12.1.0.rc.0-x86-mingw32

data/spec/unit/org_spec.rb

@@ -0,0 +1,196 @@
+#
+# Author:: Steven Danna (steve@opscode.com)
+# Copyright:: Copyright (c) 2014 Chef Software, Inc
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+require 'chef/org'
+require 'tempfile'
+
+describe Chef::Org do
+  let(:org) { Chef::Org.new("an_org") }
+
+  describe "initialize" do
+    it "is a Chef::Org" do
+      expect(org).to be_a_kind_of(Chef::Org)
+    end
+  end
+
+  describe "name" do
+    it "lets you set the name to a string" do
+      org.name "sg1"
+      expect(org.name).to eq("sg1")
+    end
+
+    # It is not feasible to check all invalid characters.  Here are a few
+    # that we probably care about.
+    it "raises on invalid characters" do
+      # capital letters
+      expect { org.name "Bar" }.to raise_error(ArgumentError)
+      # slashes
+      expect { org.name "foo/bar" }.to raise_error(ArgumentError)
+      # ?
+      expect { org.name "foo?" }.to raise_error(ArgumentError)
+      # &
+      expect { org.name "foo&" }.to raise_error(ArgumentError)
+      # spaces
+      expect { org.name "foo " }.to raise_error(ArgumentError)
+    end
+
+    it "raises an ArgumentError if you feed it anything but a string" do
+      expect { org.name Hash.new }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe "full_name" do
+    it "lets you set the full name" do
+      org.full_name "foo"
+      expect(org.full_name).to eq("foo")
+    end
+
+    it "raises an ArgumentError if you feed it anything but a string" do
+      expect { org.name Hash.new }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe "private_key" do
+    it "returns the private key" do
+      org.private_key("super private")
+      expect(org.private_key).to eq("super private")
+    end
+
+    it "raises an ArgumentError if you feed it something lame" do
+      expect { org.private_key Hash.new }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe "when serializing to JSON" do
+    let(:json) do
+      org.name("black")
+      org.full_name("black crowes")
+      org.to_json
+    end
+
+    it "serializes as a JSON object" do
+      expect(json).to match(/^\{.+\}$/)
+    end
+
+    it "includes the name value" do
+      expect(json).to include(%q{"name":"black"})
+    end
+
+    it "includes the full name value" do
+      expect(json).to include(%q{"full_name":"black crowes"})
+    end
+
+    it "includes the private key when present" do
+      org.private_key("monkeypants")
+      expect(org.to_json).to include(%q{"private_key":"monkeypants"})
+    end
+
+    it "does not include the private key if not present" do
+      expect(json).to_not include("private_key")
+    end
+  end
+
+  describe "when deserializing from JSON" do
+    let(:org) do
+      o = { "name" => "turtle",
+        "full_name" => "turtle_club",
+        "private_key" => "pandas" }
+      Chef::Org.from_json(o.to_json)
+    end
+
+    it "deserializes to a Chef::Org object" do
+      expect(org).to be_a_kind_of(Chef::Org)
+    end
+
+    it "preserves the name" do
+      expect(org.name).to eq("turtle")
+    end
+
+    it "preserves the full_name" do
+      expect(org.full_name).to eq("turtle_club")
+    end
+
+    it "includes the private key if present" do
+      expect(org.private_key).to eq("pandas")
+    end
+  end
+
+  describe "API Interactions" do
+    let(:rest) do
+      Chef::Config[:chef_server_root] = "http://www.example.com"
+      r = double('rest')
+      allow(Chef::REST).to receive(:new).and_return(r)
+      r
+    end
+
+    let(:org) do
+      o = Chef::Org.new("foobar")
+      o.full_name "foo bar bat"
+      o
+    end
+
+    describe "list" do
+      let(:response) { {"foobar" => "http://www.example.com/organizations/foobar"} }
+      let(:inflated_response) { {"foobar" => org } }
+
+      it "lists all orgs" do
+        expect(rest).to receive(:get_rest).with("organizations").and_return(response)
+        expect(Chef::Org.list).to eq(response)
+      end
+
+      it "inflate all orgs" do
+        allow(Chef::Org).to receive(:load).with("foobar").and_return(org)
+        expect(rest).to receive(:get_rest).with("organizations").and_return(response)
+        expect(Chef::Org.list(true)).to eq(inflated_response)
+      end
+    end
+
+    describe "create" do
+      it "creates a new org via the API" do
+        expect(rest).to receive(:post_rest).with("organizations", {:name => "foobar", :full_name => "foo bar bat"}).and_return({})
+        org.create
+      end
+    end
+
+    describe "read" do
+      it "loads a named org from the API" do
+        expect(rest).to receive(:get_rest).with("organizations/foobar").and_return({"name" => "foobar", "full_name" => "foo bar bat", "private_key" => "private"})
+        org = Chef::Org.load("foobar")
+        expect(org.name).to eq("foobar")
+        expect(org.full_name).to eq("foo bar bat")
+        expect(org.private_key).to eq("private")
+      end
+    end
+
+    describe "update" do
+      it "updates an existing org on via the API" do
+        expect(rest).to receive(:put_rest).with("organizations/foobar", {:name => "foobar", :full_name => "foo bar bat"}).and_return({})
+        org.update
+      end
+    end
+
+    describe "destroy" do
+      it "deletes the specified org via the API" do
+        expect(rest).to receive(:delete_rest).with("organizations/foobar")
+        org.destroy
+      end
+    end
+  end
+end

data/spec/unit/platform/query_helpers_spec.rb

@@ -20,9 +20,9 @@ require 'spec_helper'
 
 describe "Chef::Platform#windows_server_2003?" do
   it "returns false early when not on windows" do
-    Chef::Platform.stub(:windows?).and_return(false)
+    allow(Chef::Platform).to receive(:windows?).and_return(false)
     expect(Chef::Platform).not_to receive(:require) 
-    expect(Chef::Platform.windows_server_2003?).to be_false
+    expect(Chef::Platform.windows_server_2003?).to be_falsey
   end
 
   # CHEF-4888: Need to call WIN32OLE.ole_initialize in new threads
@@ -34,14 +34,14 @@ end
 describe 'Chef::Platform#supports_dsc?' do 
   it 'returns false if powershell is not present' do
     node = Chef::Node.new
-    Chef::Platform.supports_dsc?(node).should be_false
+    expect(Chef::Platform.supports_dsc?(node)).to be_falsey
   end
 
   ['1.0', '2.0', '3.0'].each do |version|
     it "returns false for Powershell #{version}" do
       node = Chef::Node.new
       node.automatic[:languages][:powershell][:version] = version
-      Chef::Platform.supports_dsc?(node).should be_false
+      expect(Chef::Platform.supports_dsc?(node)).to be_falsey
     end
   end
 
@@ -49,7 +49,7 @@ describe 'Chef::Platform#supports_dsc?' do
     it "returns true for Powershell #{version}" do
       node = Chef::Node.new
       node.automatic[:languages][:powershell][:version] = version
-      Chef::Platform.supports_dsc?(node).should be_true
+      expect(Chef::Platform.supports_dsc?(node)).to be_truthy
     end
   end
 end

data/spec/unit/platform_spec.rb

@@ -41,7 +41,7 @@ describe "Chef::Platform supports" do
     :ibm_powerkvm
   ].each do |platform|
     it "#{platform}" do
-      Chef::Platform.platforms.should have_key(platform)
+      expect(Chef::Platform.platforms).to have_key(platform)
     end
   end
 end
@@ -86,57 +86,57 @@ describe Chef::Platform do
 
     it "should allow you to look up a platform by name and version, returning the provider map for it" do
       pmap = Chef::Platform.find("Darwin", "9.2.2")
-      pmap.should be_a_kind_of(Hash)
-      pmap[:file].should eql("darwinian")
+      expect(pmap).to be_a_kind_of(Hash)
+      expect(pmap[:file]).to eql("darwinian")
     end
 
     it "should allow you to look up a platform by name and version using \"greater than\" style operators" do
       pmap = Chef::Platform.find("Darwin", "11.1.0")
-      pmap.should be_a_kind_of(Hash)
-      pmap[:file].should eql("new_darwinian")
+      expect(pmap).to be_a_kind_of(Hash)
+      expect(pmap[:file]).to eql("new_darwinian")
     end
 
     it "should use the default providers for an os if the specific version does not exist" do
       pmap = Chef::Platform.find("Darwin", "1")
-      pmap.should be_a_kind_of(Hash)
-      pmap[:file].should eql("old school")
+      expect(pmap).to be_a_kind_of(Hash)
+      expect(pmap[:file]).to eql("old school")
     end
 
     it "should use the default providers if the os doesn't give me a default, but does exist" do
       pmap = Chef::Platform.find("mars_volta", "1")
-      pmap.should be_a_kind_of(Hash)
-      pmap[:file].should eql(Chef::Provider::File)
+      expect(pmap).to be_a_kind_of(Hash)
+      expect(pmap[:file]).to eql(Chef::Provider::File)
     end
 
     it "should use the default provider if the os does not exist" do
       pmap = Chef::Platform.find("AIX", "1")
-      pmap.should be_a_kind_of(Hash)
-      pmap[:file].should eql(Chef::Provider::File)
+      expect(pmap).to be_a_kind_of(Hash)
+      expect(pmap[:file]).to eql(Chef::Provider::File)
     end
 
     it "should merge the defaults for an os with the specific version" do
       pmap = Chef::Platform.find("Darwin", "9.2.2")
-      pmap[:file].should eql("darwinian")
-      pmap[:snicker].should eql("snack")
+      expect(pmap[:file]).to eql("darwinian")
+      expect(pmap[:snicker]).to eql("snack")
     end
 
     it "should merge the defaults for an os with the universal defaults" do
       pmap = Chef::Platform.find("Darwin", "9.2.2")
-      pmap[:file].should eql("darwinian")
-      pmap[:pax].should eql("brittania")
+      expect(pmap[:file]).to eql("darwinian")
+      expect(pmap[:pax]).to eql("brittania")
     end
 
     it "should allow you to look up a provider for a platform directly by symbol" do
-      Chef::Platform.find_provider("Darwin", "9.2.2", :file).should eql("darwinian")
+      expect(Chef::Platform.find_provider("Darwin", "9.2.2", :file)).to eql("darwinian")
     end
 
     it "should raise an exception if a provider cannot be found for a resource type" do
-      lambda { Chef::Platform.find_provider("Darwin", "9.2.2", :coffee) }.should raise_error(ArgumentError)
+      expect { Chef::Platform.find_provider("Darwin", "9.2.2", :coffee) }.to raise_error(ArgumentError)
     end
 
     it "should look up a provider for a resource with a Chef::Resource object" do
       kitty = Chef::Resource::Cat.new("loulou")
-      Chef::Platform.find_provider("Darwin", "9.2.2", kitty).should eql("nice")
+      expect(Chef::Platform.find_provider("Darwin", "9.2.2", kitty)).to eql("nice")
     end
 
     it "should look up a provider with a node and a Chef::Resource object" do
@@ -145,21 +145,21 @@ describe Chef::Platform do
       node.name("Intel")
       node.automatic_attrs[:platform] = "mac_os_x"
       node.automatic_attrs[:platform_version] = "9.2.2"
-      Chef::Platform.find_provider_for_node(node, kitty).should eql("nice")
+      expect(Chef::Platform.find_provider_for_node(node, kitty)).to eql("nice")
     end
 
     it "should not throw an exception when the platform version has an unknown format" do
-      Chef::Platform.find_provider(:darwin, "bad-version", :file).should eql("old school")
+      expect(Chef::Platform.find_provider(:darwin, "bad-version", :file)).to eql("old school")
     end
 
     it "should prefer an explicit provider" do
       kitty = Chef::Resource::Cat.new("loulou")
-      kitty.stub(:provider).and_return(Chef::Provider::File)
+      allow(kitty).to receive(:provider).and_return(Chef::Provider::File)
       node = Chef::Node.new
       node.name("Intel")
       node.automatic_attrs[:platform] = "mac_os_x"
       node.automatic_attrs[:platform_version] = "9.2.2"
-      Chef::Platform.find_provider_for_node(node, kitty).should eql(Chef::Provider::File)
+      expect(Chef::Platform.find_provider_for_node(node, kitty)).to eql(Chef::Provider::File)
     end
 
     it "should look up a provider based on the resource name if nothing else matches" do
@@ -170,7 +170,7 @@ describe Chef::Platform do
       node.name("Intel")
       node.automatic_attrs[:platform] = "mac_os_x"
       node.automatic_attrs[:platform_version] = "8.5"
-      Chef::Platform.find_provider_for_node(node, kitty).should eql(Chef::Provider::Cat)
+      expect(Chef::Platform.find_provider_for_node(node, kitty)).to eql(Chef::Provider::Cat)
     end
 
     def setup_file_resource
@@ -184,26 +184,26 @@ describe Chef::Platform do
     it "returns a provider object given a Chef::Resource object which has a valid run context and an action" do
       file, run_context = setup_file_resource
       provider = Chef::Platform.provider_for_resource(file, :foo)
-      provider.should be_an_instance_of(Chef::Provider::File)
-      provider.new_resource.should equal(file)
-      provider.run_context.should equal(run_context)
+      expect(provider).to be_an_instance_of(Chef::Provider::File)
+      expect(provider.new_resource).to equal(file)
+      expect(provider.run_context).to equal(run_context)
     end
 
     it "returns a provider object given a Chef::Resource object which has a valid run context without an action" do
       file, run_context = setup_file_resource
       provider = Chef::Platform.provider_for_resource(file)
-      provider.should be_an_instance_of(Chef::Provider::File)
-      provider.new_resource.should equal(file)
-      provider.run_context.should equal(run_context)
+      expect(provider).to be_an_instance_of(Chef::Provider::File)
+      expect(provider.new_resource).to equal(file)
+      expect(provider.run_context).to equal(run_context)
     end
 
     it "raises an error when trying to find the provider for a resource with no run context" do
       file = Chef::Resource::File.new("whateva")
-      lambda {Chef::Platform.provider_for_resource(file)}.should raise_error(ArgumentError)
+      expect {Chef::Platform.provider_for_resource(file)}.to raise_error(ArgumentError)
     end
 
     it "does not support finding a provider by resource and node -- a run context is required" do
-      lambda {Chef::Platform.provider_for_node('node', 'resource')}.should raise_error(NotImplementedError)
+      expect {Chef::Platform.provider_for_node('node', 'resource')}.to raise_error(NotImplementedError)
     end
 
     it "should update the provider map with map" do
@@ -213,18 +213,18 @@ describe Chef::Platform do
            :resource => :file,
            :provider => "masterful"
       )
-      Chef::Platform.platforms[:darwin]["9.2.2"][:file].should eql("masterful")
+      expect(Chef::Platform.platforms[:darwin]["9.2.2"][:file]).to eql("masterful")
       Chef::Platform.set(
            :platform => :darwin,
            :resource => :file,
            :provider => "masterful"
       )
-      Chef::Platform.platforms[:darwin][:default][:file].should eql("masterful")
+      expect(Chef::Platform.platforms[:darwin][:default][:file]).to eql("masterful")
       Chef::Platform.set(
            :resource => :file,
            :provider => "masterful"
       )
-      Chef::Platform.platforms[:default][:file].should eql("masterful")
+      expect(Chef::Platform.platforms[:default][:file]).to eql("masterful")
 
       Chef::Platform.set(
            :platform => :hero,
@@ -232,13 +232,13 @@ describe Chef::Platform do
            :resource => :file,
            :provider => "masterful"
       )
-      Chef::Platform.platforms[:hero]["9.2.2"][:file].should eql("masterful")
+      expect(Chef::Platform.platforms[:hero]["9.2.2"][:file]).to eql("masterful")
 
       Chef::Platform.set(
            :resource => :file,
            :provider => "masterful"
       )
-      Chef::Platform.platforms[:default][:file].should eql("masterful")
+      expect(Chef::Platform.platforms[:default][:file]).to eql("masterful")
 
       Chef::Platform.platforms = {}
 
@@ -246,11 +246,11 @@ describe Chef::Platform do
            :resource => :file,
            :provider => "masterful"
       )
-      Chef::Platform.platforms[:default][:file].should eql("masterful")
+      expect(Chef::Platform.platforms[:default][:file]).to eql("masterful")
 
       Chef::Platform.platforms = { :neurosis => {} }
       Chef::Platform.set(:platform => :neurosis, :resource => :package, :provider => "masterful")
-      Chef::Platform.platforms[:neurosis][:default][:package].should eql("masterful")
+      expect(Chef::Platform.platforms[:neurosis][:default][:package]).to eql("masterful")
 
     end
 
@@ -260,8 +260,8 @@ describe Chef::Platform do
         :platform => :default,
         :provider => "new school"
       )
-      Chef::Platform.platforms[:default][:file].should eql("new school")
-      Chef::Platform.platforms[:default][:cat].should eql("nice")
+      expect(Chef::Platform.platforms[:default][:file]).to eql("new school")
+      expect(Chef::Platform.platforms[:default][:cat]).to eql("nice")
     end
 
   end
@@ -270,36 +270,36 @@ describe Chef::Platform do
 
     it "should use the solaris package provider on Solaris <11" do
       pmap = Chef::Platform.find("Solaris2", "5.9")
-      pmap[:package].should eql(Chef::Provider::Package::Solaris)
+      expect(pmap[:package]).to eql(Chef::Provider::Package::Solaris)
     end
 
     it "should use the IPS package provider on Solaris 11" do
       pmap = Chef::Platform.find("Solaris2", "5.11")
-      pmap[:package].should eql(Chef::Provider::Package::Ips)
+      expect(pmap[:package]).to eql(Chef::Provider::Package::Ips)
     end
 
     it "should use the Redhat service provider on SLES11" do
       1.upto(3) do |sp|
         pmap = Chef::Platform.find("SUSE", "11.#{sp}")
-        pmap[:service].should eql(Chef::Provider::Service::Redhat)
+        expect(pmap[:service]).to eql(Chef::Provider::Service::Redhat)
       end
     end
 
     it "should use the Systemd service provider on SLES12" do
       pmap = Chef::Platform.find("SUSE", "12.0")
-      pmap[:service].should eql(Chef::Provider::Service::Systemd)
+      expect(pmap[:service]).to eql(Chef::Provider::Service::Systemd)
     end
 
     it "should use the SUSE group provider on SLES11" do
       1.upto(3) do |sp|
         pmap = Chef::Platform.find("SUSE", "11.#{sp}")
-        pmap[:group].should eql(Chef::Provider::Group::Suse)
+        expect(pmap[:group]).to eql(Chef::Provider::Group::Suse)
       end
     end
 
     it "should use the Gpasswd group provider on SLES12" do
       pmap = Chef::Platform.find("SUSE", "12.0")
-      pmap[:group].should eql(Chef::Provider::Group::Gpasswd)
+      expect(pmap[:group]).to eql(Chef::Provider::Group::Gpasswd)
     end
   end