chef 12.0.3-x86-mingw32 → 12.1.0.rc.0-x86-mingw32

data/spec/unit/knife/role_create_spec.rb

@@ -26,45 +26,45 @@ describe Chef::Knife::RoleCreate do
       :description => nil
     }
     @knife.name_args = [ "adam" ]
-    @knife.stub(:output).and_return(true)
+    allow(@knife).to receive(:output).and_return(true)
     @role = Chef::Role.new()
-    @role.stub(:save)
-    Chef::Role.stub(:new).and_return(@role)
-    @knife.stub(:edit_data).and_return(@role)
+    allow(@role).to receive(:save)
+    allow(Chef::Role).to receive(:new).and_return(@role)
+    allow(@knife).to receive(:edit_data).and_return(@role)
     @stdout = StringIO.new
-    @knife.ui.stub(:stdout).and_return(@stdout)
+    allow(@knife.ui).to receive(:stdout).and_return(@stdout)
   end
 
   describe "run" do
     it "should create a new role" do
-      Chef::Role.should_receive(:new).and_return(@role)
+      expect(Chef::Role).to receive(:new).and_return(@role)
       @knife.run
     end
 
     it "should set the role name" do
-      @role.should_receive(:name).with("adam")
+      expect(@role).to receive(:name).with("adam")
       @knife.run
     end
 
     it "should not print the role" do
-      @knife.should_not_receive(:output)
+      expect(@knife).not_to receive(:output)
       @knife.run
     end
 
     it "should allow you to edit the data" do
-      @knife.should_receive(:edit_data).with(@role)
+      expect(@knife).to receive(:edit_data).with(@role)
       @knife.run
     end
 
     it "should save the role" do
-      @role.should_receive(:save)
+      expect(@role).to receive(:save)
       @knife.run
     end
 
     describe "with -d or --description" do
       it "should set the description" do
         @knife.config[:description] = "All is bob"
-        @role.should_receive(:description).with("All is bob")
+        expect(@role).to receive(:description).with("All is bob")
         @knife.run
       end
     end
@@ -72,7 +72,7 @@ describe Chef::Knife::RoleCreate do
     describe "with -p or --print-after" do
       it "should pretty print the node, formatted for display" do
         @knife.config[:print_after] = true
-        @knife.should_receive(:output).with(@role)
+        expect(@knife).to receive(:output).with(@role)
         @knife.run
       end
     end

data/spec/unit/knife/role_delete_spec.rb

@@ -26,40 +26,40 @@ describe Chef::Knife::RoleDelete do
       :print_after => nil
     }
     @knife.name_args = [ "adam" ]
-    @knife.stub(:output).and_return(true)
-    @knife.stub(:confirm).and_return(true)
+    allow(@knife).to receive(:output).and_return(true)
+    allow(@knife).to receive(:confirm).and_return(true)
     @role = Chef::Role.new()
-    @role.stub(:destroy).and_return(true)
-    Chef::Role.stub(:load).and_return(@role)
+    allow(@role).to receive(:destroy).and_return(true)
+    allow(Chef::Role).to receive(:load).and_return(@role)
     @stdout = StringIO.new
-    @knife.ui.stub(:stdout).and_return(@stdout)
+    allow(@knife.ui).to receive(:stdout).and_return(@stdout)
   end
 
   describe "run" do
     it "should confirm that you want to delete" do
-      @knife.should_receive(:confirm)
+      expect(@knife).to receive(:confirm)
       @knife.run
     end
 
     it "should load the Role" do
-      Chef::Role.should_receive(:load).with("adam").and_return(@role)
+      expect(Chef::Role).to receive(:load).with("adam").and_return(@role)
       @knife.run
     end
 
     it "should delete the Role" do
-      @role.should_receive(:destroy).and_return(@role)
+      expect(@role).to receive(:destroy).and_return(@role)
       @knife.run
     end
 
     it "should not print the Role" do
-      @knife.should_not_receive(:output)
+      expect(@knife).not_to receive(:output)
       @knife.run
     end
 
     describe "with -p or --print-after" do
       it "should pretty print the Role, formatted for display" do
         @knife.config[:print_after] = true
-        @knife.should_receive(:output)
+        expect(@knife).to receive(:output)
         @knife.run
       end
     end

data/spec/unit/knife/role_edit_spec.rb

@@ -24,22 +24,22 @@ describe Chef::Knife::RoleEdit do
     @knife = Chef::Knife::RoleEdit.new
     @knife.config[:print_after] = nil
     @knife.name_args = [ "adam" ]
-    @knife.ui.stub(:output).and_return(true)
+    allow(@knife.ui).to receive(:output).and_return(true)
     @role = Chef::Role.new()
-    @role.stub(:save)
-    Chef::Role.stub(:load).and_return(@role)
-    @knife.ui.stub(:edit_data).and_return(@role)
-    @knife.ui.stub(:msg)
+    allow(@role).to receive(:save)
+    allow(Chef::Role).to receive(:load).and_return(@role)
+    allow(@knife.ui).to receive(:edit_data).and_return(@role)
+    allow(@knife.ui).to receive(:msg)
   end
 
   describe "run" do
     it "should load the role" do
-      Chef::Role.should_receive(:load).with("adam").and_return(@role)
+      expect(Chef::Role).to receive(:load).with("adam").and_return(@role)
       @knife.run
     end
 
     it "should edit the role data" do
-      @knife.ui.should_receive(:edit_data).with(@role)
+      expect(@knife.ui).to receive(:edit_data).with(@role)
       @knife.run
     end
 
@@ -47,29 +47,29 @@ describe Chef::Knife::RoleEdit do
       pansy = Chef::Role.new
 
       @role.name("new_role_name")
-      @knife.ui.should_receive(:edit_data).with(@role).and_return(pansy)
-      pansy.should_receive(:save)
+      expect(@knife.ui).to receive(:edit_data).with(@role).and_return(pansy)
+      expect(pansy).to receive(:save)
       @knife.run
     end
 
     it "should not save the unedited role data" do
       pansy = Chef::Role.new
 
-      @knife.ui.should_receive(:edit_data).with(@role).and_return(pansy)
-      pansy.should_not_receive(:save)
+      expect(@knife.ui).to receive(:edit_data).with(@role).and_return(pansy)
+      expect(pansy).not_to receive(:save)
       @knife.run
 
     end
 
     it "should not print the role" do
-      @knife.ui.should_not_receive(:output)
+      expect(@knife.ui).not_to receive(:output)
       @knife.run
     end
 
     describe "with -p or --print-after" do
       it "should pretty print the role, formatted for display" do
         @knife.config[:print_after] = true
-        @knife.ui.should_receive(:output).with(@role)
+        expect(@knife.ui).to receive(:output).with(@role)
         @knife.run
       end
     end

data/spec/unit/knife/role_env_run_list_add_spec.rb

@@ -0,0 +1,217 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Will Albenzi (<walbenzi@gmail.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# 
+#     http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Knife::RoleEnvRunListAdd do
+  before(:each) do
+#    Chef::Config[:role_name]  = "websimian"
+#    Chef::Config[:env_name]  = "QA"
+    @knife = Chef::Knife::RoleEnvRunListAdd.new
+    @knife.config = {
+      :after => nil
+    }
+    @knife.name_args = [ "will", "QA", "role[monkey]" ]
+    allow(@knife).to receive(:output).and_return(true)
+    @role = Chef::Role.new() 
+    allow(@role).to receive(:save).and_return(true)
+    allow(Chef::Role).to receive(:load).and_return(@role)
+  end
+
+  describe "run" do
+
+#    it "should display all the things" do
+#      @knife.run
+#      @role.to_json.should == 'show all the things'
+#    end
+
+    it "should have an empty default run list" do
+      @knife.run
+      expect(@role.run_list[0]).to be_nil
+    end
+
+    it "should have a QA environment" do
+      @knife.run
+      expect(@role.active_run_list_for('QA')).to eq('QA')
+    end
+
+    it "should load the role named will" do
+      expect(Chef::Role).to receive(:load).with("will")
+      @knife.run
+    end
+
+    it "should be able to add an environment specific run list" do
+      @knife.run
+      expect(@role.run_list_for('QA')[0]).to eq('role[monkey]')
+    end
+
+    it "should save the role" do
+      expect(@role).to receive(:save)
+      @knife.run
+    end
+
+    it "should print the run list" do
+      expect(@knife).to receive(:output).and_return(true)
+      @knife.run
+    end
+
+    describe "with -a or --after specified" do
+      it "should not create a change if the specified 'after' never comes" do
+        @role.run_list_for("_default") << "role[acorns]"
+        @role.run_list_for("_default") << "role[barn]"
+        @knife.config[:after] = "role[acorns]"
+        @knife.name_args = [ "will", "QA", "role[pad]" ]
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to be_nil
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[barn]")
+        expect(@role.run_list[2]).to be_nil
+      end
+
+      it "should add to the run list after the specified entries in the QA run list" do
+        #Setup
+        @role.run_list_for("_default") << "role[acorns]"
+        @role.run_list_for("_default") << "role[barn]"
+        @knife.run
+        @role.run_list_for("QA") << "role[pencil]"
+        @role.run_list_for("QA") << "role[pen]"
+        #Configuration we are testing
+        @knife.config[:after] = "role[pencil]"
+        @knife.name_args = [ "will", "QA", "role[pad]", "role[whackadoo]" ]
+        @knife.run
+        #The actual tests
+        expect(@role.run_list_for("QA")[0]).to eq("role[monkey]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[pencil]")
+        expect(@role.run_list_for("QA")[2]).to eq("role[pad]")
+        expect(@role.run_list_for("QA")[3]).to eq("role[whackadoo]")
+        expect(@role.run_list_for("QA")[4]).to eq("role[pen]")
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[barn]")
+        expect(@role.run_list[2]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe" do
+      it "should add to the QA run list all the entries" do
+        @knife.name_args = [ "will", "QA", "role[monkey],role[duck]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to eq("role[monkey]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[duck]")
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe with space between items" do
+      it "should add to the run list all the entries" do
+        @knife.name_args = [ "will", "QA", "role[monkey], role[duck]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to eq("role[monkey]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[duck]")
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe as different arguments" do
+      it "should add to the run list all the entries" do
+        @knife.name_args = [ "will", "QA", "role[monkey]", "role[duck]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to eq("role[monkey]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[duck]")
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe as different arguments and list separated by comas" do
+      it "should add to the run list all the entries" do
+        @knife.name_args = [ "will", "QA", "role[monkey]", "role[duck],recipe[bird::fly]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to eq("role[monkey]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[duck]")
+        expect(@role.run_list_for("QA")[2]).to eq("recipe[bird::fly]")
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to be_nil
+      end
+    end
+
+    describe "Recipe with version number is allowed" do
+      it "should add to the run list all the entries including the versioned recipe" do
+        @knife.name_args = [ "will", "QA", "role[monkey]", "role[duck],recipe[bird::fly@1.1.3]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to eq("role[monkey]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[duck]")
+        expect(@role.run_list_for("QA")[2]).to eq("recipe[bird::fly@1.1.3]")
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to be_nil
+      end
+    end
+
+    describe "with one role or recipe but with an extraneous comma" do
+      it "should add to the run list one item" do
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.name_args = [ "will", "QA", "role[monkey]," ]
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to eq("role[monkey]")
+        expect(@role.run_list_for("QA")[1]).to be_nil
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to be_nil
+      end
+    end
+    
+    describe "with more than one command" do
+      it "should be able to the environment run list by running multiple knife commands" do
+        @knife.name_args = [ "will", "QA", "role[blue]," ]
+        @knife.run
+        @knife.name_args = [ "will", "QA", "role[black]," ]
+        @knife.run
+        expect(@role.run_list_for("QA")[0]).to eq("role[blue]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[black]")
+        expect(@role.run_list[0]).to be_nil
+      end
+    end
+
+    describe "with more than one environment" do
+      it "should add to the run list a second environment in the specific run list" do
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.name_args = [ "will", "QA", "role[blue]," ]
+        @knife.run
+        @role.run_list_for("QA") << "role[walnuts]"
+
+        @knife.name_args = [ "will", "PRD", "role[ball]," ]
+        @knife.run
+        @role.run_list_for("PRD") << "role[pen]"
+
+        expect(@role.run_list_for("QA")[0]).to eq("role[blue]")
+        expect(@role.run_list_for("PRD")[0]).to eq("role[ball]")
+        expect(@role.run_list_for("QA")[1]).to eq("role[walnuts]")
+        expect(@role.run_list_for("PRD")[1]).to eq("role[pen]")
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to be_nil
+      end
+    end
+
+  end
+end

data/spec/unit/knife/role_env_run_list_clear_spec.rb

@@ -0,0 +1,100 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Will Albenzi (<walbenzi@gmail.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Knife::RoleEnvRunListClear do
+  before(:each) do
+    Chef::Config[:role_name]  = "will"
+    Chef::Config[:env_name]  = "QA"
+    @setup = Chef::Knife::RoleEnvRunListAdd.new
+    @setup.name_args = [ "will", "QA", "role[monkey]", "role[person]" ]
+
+    @knife = Chef::Knife::RoleEnvRunListClear.new
+    @knife.config = {
+      :print_after => nil
+    }
+    @knife.name_args = [ "will", "QA" ]
+    allow(@knife).to receive(:output).and_return(true)
+
+    @role = Chef::Role.new()
+    @role.name("will")
+    allow(@role).to receive(:save).and_return(true)
+
+    allow(@knife.ui).to receive(:confirm).and_return(true)
+    allow(Chef::Role).to receive(:load).and_return(@role)
+
+  end
+
+
+
+  describe "run" do
+
+
+#    it "should display all the things" do
+#      @knife.run
+#      @role.to_json.should == 'show all the things'
+#    end
+
+    it "should load the node" do
+      expect(Chef::Role).to receive(:load).with("will").and_return(@role)
+      @knife.run
+    end
+
+     it "should remove the item from the run list" do
+       @setup.run
+       @knife.run
+       expect(@role.run_list_for('QA')[0]).to be_nil
+       expect(@role.run_list[0]).to be_nil
+     end
+
+     it "should save the node" do
+       expect(@role).to receive(:save).and_return(true)
+       @knife.run
+     end
+
+     it "should print the run list" do
+       expect(@knife).to receive(:output).and_return(true)
+       @knife.config[:print_after] = true
+       @setup.run
+       @knife.run
+     end
+
+     describe "should clear an environmental run list of roles and recipes" do
+       it "should remove the items from the run list" do
+         @setup.name_args = [ "will", "QA", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+         @setup.run
+         @setup.name_args = [ "will", "PRD", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+         @setup.run
+         @knife.name_args = [ 'will', 'QA' ]
+         @knife.run
+         expect(@role.run_list_for('QA')[0]).to be_nil
+         expect(@role.run_list_for('PRD')[0]).to eq('recipe[orange::chicken]')
+         expect(@role.run_list_for('PRD')[1]).to eq('role[monkey]')
+         expect(@role.run_list_for('PRD')[2]).to eq('recipe[duck::type]')
+         expect(@role.run_list_for('PRD')[3]).to eq('role[person]')
+         expect(@role.run_list_for('PRD')[4]).to eq('role[bird]')
+         expect(@role.run_list_for('PRD')[5]).to eq('role[town]')
+       end
+     end
+  end
+end
+
+
+