chef 12.0.3-x86-mingw32 → 12.1.0.rc.0-x86-mingw32

data/spec/unit/knife/role_env_run_list_remove_spec.rb

@@ -0,0 +1,108 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Will Albenzi (<walbenzi@gmail.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Knife::RoleEnvRunListRemove do
+  before(:each) do
+    Chef::Config[:role_name]  = "will"
+    Chef::Config[:env_name]  = "QA"
+    @setup = Chef::Knife::RoleEnvRunListAdd.new
+    @setup.name_args = [ "will", "QA", "role[monkey]", "role[person]" ]
+
+    @knife = Chef::Knife::RoleEnvRunListRemove.new
+    @knife.config = {
+      :print_after => nil
+    }
+    @knife.name_args = [ "will", "QA", "role[monkey]" ]
+    allow(@knife).to receive(:output).and_return(true)
+
+    @role = Chef::Role.new()
+    @role.name("will")
+    allow(@role).to receive(:save).and_return(true)
+
+    allow(@knife.ui).to receive(:confirm).and_return(true)
+    allow(Chef::Role).to receive(:load).and_return(@role)
+
+  end
+
+
+
+  describe "run" do
+
+
+#    it "should display all the things" do
+#      @knife.run
+#      @role.to_json.should == 'show all the things'
+#    end
+
+    it "should load the node" do
+      expect(Chef::Role).to receive(:load).with("will").and_return(@role)
+      @knife.run
+    end
+
+     it "should remove the item from the run list" do
+       @setup.run
+       @knife.run
+       expect(@role.run_list_for('QA')[0]).not_to eq('role[monkey]')
+       expect(@role.run_list_for('QA')[0]).to eq('role[person]')
+       expect(@role.run_list[0]).to be_nil
+     end
+
+     it "should save the node" do
+       expect(@role).to receive(:save).and_return(true)
+       @knife.run
+     end
+
+     it "should print the run list" do
+       expect(@knife).to receive(:output).and_return(true)
+       @knife.config[:print_after] = true
+       @setup.run
+       @knife.run
+     end
+
+     describe "run with a list of roles and recipes" do
+       it "should remove the items from the run list" do
+         @setup.name_args = [ "will", "QA", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+         @setup.run
+         @setup.name_args = [ "will", "PRD", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+         @setup.run
+         @knife.name_args = [ 'will', 'QA', 'role[monkey]' ]
+         @knife.run
+         @knife.name_args = [ 'will', 'QA', 'recipe[duck::type]' ]
+         @knife.run
+         expect(@role.run_list_for('QA')).not_to include('role[monkey]')
+         expect(@role.run_list_for('QA')).not_to include('recipe[duck::type]')
+         expect(@role.run_list_for('QA')[0]).to eq('recipe[orange::chicken]')
+         expect(@role.run_list_for('QA')[1]).to eq('role[person]')
+         expect(@role.run_list_for('QA')[2]).to eq('role[bird]')
+         expect(@role.run_list_for('QA')[3]).to eq('role[town]')
+         expect(@role.run_list_for('PRD')[0]).to eq('recipe[orange::chicken]')
+         expect(@role.run_list_for('PRD')[1]).to eq('role[monkey]')
+         expect(@role.run_list_for('PRD')[2]).to eq('recipe[duck::type]')
+         expect(@role.run_list_for('PRD')[3]).to eq('role[person]')
+         expect(@role.run_list_for('PRD')[4]).to eq('role[bird]')
+         expect(@role.run_list_for('PRD')[5]).to eq('role[town]')
+       end
+     end
+  end
+end
+
+
+

data/spec/unit/knife/role_env_run_list_replace_spec.rb

@@ -0,0 +1,108 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Will Albenzi (<walbenzi@gmail.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Knife::RoleEnvRunListReplace do
+  before(:each) do
+    Chef::Config[:role_name]  = "will"
+    Chef::Config[:env_name]  = "QA"
+    @setup = Chef::Knife::RoleEnvRunListAdd.new
+    @setup.name_args = [ "will", "QA", "role[monkey]", "role[dude]", "role[fixer]" ]
+
+    @knife = Chef::Knife::RoleEnvRunListReplace.new
+    @knife.config = {
+      :print_after => nil
+    }
+    @knife.name_args = [ "will", "QA", "role[dude]", "role[person]" ]
+    allow(@knife).to receive(:output).and_return(true)
+
+    @role = Chef::Role.new()
+    @role.name("will")
+    allow(@role).to receive(:save).and_return(true)
+
+    allow(@knife.ui).to receive(:confirm).and_return(true)
+    allow(Chef::Role).to receive(:load).and_return(@role)
+
+  end
+
+
+
+  describe "run" do
+
+
+#    it "should display all the things" do
+#      @knife.run
+#      @role.to_json.should == 'show all the things'
+#    end
+
+    it "should load the node" do
+      expect(Chef::Role).to receive(:load).with("will").and_return(@role)
+      @knife.run
+    end
+
+     it "should remove the item from the run list" do
+       @setup.run
+       @knife.run
+       expect(@role.run_list_for('QA')[1]).not_to eq('role[dude]')
+       expect(@role.run_list_for('QA')[1]).to eq('role[person]')
+       expect(@role.run_list[0]).to be_nil
+     end
+
+     it "should save the node" do
+       expect(@role).to receive(:save).and_return(true)
+       @knife.run
+     end
+
+     it "should print the run list" do
+       expect(@knife).to receive(:output).and_return(true)
+       @knife.config[:print_after] = true
+       @setup.run
+       @knife.run
+     end
+
+     describe "run with a list of roles and recipes" do
+       it "should replace the items from the run list" do
+         @setup.name_args = [ "will", "QA", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+         @setup.run
+         @setup.name_args = [ "will", "PRD", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+         @setup.run
+         @knife.name_args = [ 'will', 'QA', 'role[monkey]', 'role[gibbon]' ]
+         @knife.run
+         @knife.name_args = [ 'will', 'QA', 'recipe[duck::type]', 'recipe[duck::mallard]' ]
+         @knife.run
+         expect(@role.run_list_for('QA')).not_to include('role[monkey]')
+         expect(@role.run_list_for('QA')).not_to include('recipe[duck::type]')
+         expect(@role.run_list_for('QA')[0]).to eq('recipe[orange::chicken]')
+         expect(@role.run_list_for('QA')[1]).to eq('role[gibbon]')
+         expect(@role.run_list_for('QA')[2]).to eq('recipe[duck::mallard]')
+         expect(@role.run_list_for('QA')[3]).to eq('role[person]')
+         expect(@role.run_list_for('QA')[4]).to eq('role[bird]')
+         expect(@role.run_list_for('QA')[5]).to eq('role[town]')
+         expect(@role.run_list_for('PRD')[0]).to eq('recipe[orange::chicken]')
+         expect(@role.run_list_for('PRD')[1]).to eq('role[monkey]')
+         expect(@role.run_list_for('PRD')[2]).to eq('recipe[duck::type]')
+         expect(@role.run_list_for('PRD')[3]).to eq('role[person]')
+         expect(@role.run_list_for('PRD')[4]).to eq('role[bird]')
+         expect(@role.run_list_for('PRD')[5]).to eq('role[town]')
+         expect(@role.run_list[0]).to be_nil
+       end
+     end
+  end
+end

data/spec/unit/knife/role_env_run_list_set_spec.rb

@@ -0,0 +1,102 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Will Albenzi (<walbenzi@gmail.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Knife::RoleEnvRunListSet do
+  before(:each) do
+    Chef::Config[:role_name]  = "will"
+    Chef::Config[:env_name]  = "QA"
+    @setup = Chef::Knife::RoleEnvRunListAdd.new
+    @setup.name_args = [ "will", "QA", "role[monkey]", "role[person]", "role[bucket]" ]
+
+    @knife = Chef::Knife::RoleEnvRunListSet.new
+    @knife.config = {
+      :print_after => nil
+    }
+    @knife.name_args = [ "will", "QA", "role[owen]", "role[mauntel]" ]
+    allow(@knife).to receive(:output).and_return(true)
+
+    @role = Chef::Role.new()
+    @role.name("will")
+    allow(@role).to receive(:save).and_return(true)
+
+    allow(@knife.ui).to receive(:confirm).and_return(true)
+    allow(Chef::Role).to receive(:load).and_return(@role)
+
+  end
+
+
+
+  describe "run" do
+
+
+#    it "should display all the things" do
+#      @knife.run
+#      @role.to_json.should == 'show all the things'
+#    end
+
+    it "should load the node" do
+      expect(Chef::Role).to receive(:load).with("will").and_return(@role)
+      @knife.run
+    end
+
+    it "should replace all the items in the runlist with what is specified" do
+      @setup.run
+      @knife.run
+      expect(@role.run_list_for('QA')[0]).to eq("role[owen]") 
+      expect(@role.run_list_for('QA')[1]).to eq("role[mauntel]") 
+      expect(@role.run_list_for('QA')[2]).to be_nil
+      expect(@role.run_list[0]).to be_nil
+    end
+
+    it "should save the node" do
+      expect(@role).to receive(:save).and_return(true)
+      @knife.run
+    end
+
+    it "should print the run list" do
+      expect(@knife).to receive(:output).and_return(true)
+      @knife.config[:print_after] = true
+      @setup.run
+      @knife.run
+    end
+
+    describe "should clear an environmental run list of roles and recipes" do
+      it "should remove the items from the run list" do
+        @setup.name_args = [ "will", "QA", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+        @setup.run
+        @setup.name_args = [ "will", "PRD", "recipe[orange::chicken]", "role[monkey]", "recipe[duck::type]", "role[person]", "role[bird]", "role[town]" ]
+        @setup.run
+        @knife.name_args = [ "will", "QA", "role[coke]", "role[pepsi]" ]
+        @knife.run
+        expect(@role.run_list_for('QA')[0]).to eq("role[coke]")
+        expect(@role.run_list_for('QA')[1]).to eq("role[pepsi]")
+        expect(@role.run_list_for('QA')[2]).to be_nil
+        expect(@role.run_list_for('PRD')[0]).to eq('recipe[orange::chicken]')
+        expect(@role.run_list_for('PRD')[1]).to eq('role[monkey]')
+        expect(@role.run_list_for('PRD')[2]).to eq('recipe[duck::type]')
+        expect(@role.run_list_for('PRD')[3]).to eq('role[person]')
+        expect(@role.run_list_for('PRD')[4]).to eq('role[bird]')
+        expect(@role.run_list_for('PRD')[5]).to eq('role[town]')
+        expect(@role.run_list[0]).to be_nil
+      end
+    end
+  end
+end

data/spec/unit/knife/role_from_file_spec.rb

@@ -28,30 +28,30 @@ describe Chef::Knife::RoleFromFile do
       :print_after => nil
     }
     @knife.name_args = [ "adam.rb" ]
-    @knife.stub(:output).and_return(true)
-    @knife.stub(:confirm).and_return(true)
+    allow(@knife).to receive(:output).and_return(true)
+    allow(@knife).to receive(:confirm).and_return(true)
     @role = Chef::Role.new()
-    @role.stub(:save)
-    @knife.loader.stub(:load_from).and_return(@role)
+    allow(@role).to receive(:save)
+    allow(@knife.loader).to receive(:load_from).and_return(@role)
     @stdout = StringIO.new
-    @knife.ui.stub(:stdout).and_return(@stdout)
+    allow(@knife.ui).to receive(:stdout).and_return(@stdout)
   end
 
   describe "run" do
     it "should load from a file" do
-      @knife.loader.should_receive(:load_from).with('roles', 'adam.rb').and_return(@role)
+      expect(@knife.loader).to receive(:load_from).with('roles', 'adam.rb').and_return(@role)
       @knife.run
     end
 
     it "should not print the role" do
-      @knife.should_not_receive(:output)
+      expect(@knife).not_to receive(:output)
       @knife.run
     end
 
     describe "with -p or --print-after" do
       it "should print the role" do
         @knife.config[:print_after] = true
-        @knife.should_receive(:output)
+        expect(@knife).to receive(:output)
         @knife.run
       end
     end
@@ -60,8 +60,8 @@ describe Chef::Knife::RoleFromFile do
   describe "run with multiple arguments" do
     it "should load each file" do
       @knife.name_args = [ "adam.rb", "caleb.rb" ]
-      @knife.loader.should_receive(:load_from).with('roles', 'adam.rb').and_return(@role)
-      @knife.loader.should_receive(:load_from).with('roles', 'caleb.rb').and_return(@role)
+      expect(@knife.loader).to receive(:load_from).with('roles', 'adam.rb').and_return(@role)
+      expect(@knife.loader).to receive(:load_from).with('roles', 'caleb.rb').and_return(@role)
       @knife.run
     end
   end

data/spec/unit/knife/role_list_spec.rb

@@ -22,31 +22,31 @@ describe Chef::Knife::RoleList do
   before(:each) do
     Chef::Config[:node_name]  = "webmonkey.example.com"
     @knife = Chef::Knife::RoleList.new
-    @knife.stub(:output).and_return(true)
+    allow(@knife).to receive(:output).and_return(true)
     @list = {
       "foo" => "http://example.com/foo",
       "bar" => "http://example.com/foo"
     }
-    Chef::Role.stub(:list).and_return(@list)
+    allow(Chef::Role).to receive(:list).and_return(@list)
   end
 
   describe "run" do
     it "should list the roles" do
-      Chef::Role.should_receive(:list).and_return(@list)
+      expect(Chef::Role).to receive(:list).and_return(@list)
       @knife.run
     end
 
     it "should pretty print the list" do
-      Chef::Role.should_receive(:list).and_return(@list)
-      @knife.should_receive(:output).with([ "bar", "foo" ])
+      expect(Chef::Role).to receive(:list).and_return(@list)
+      expect(@knife).to receive(:output).with([ "bar", "foo" ])
       @knife.run
     end
 
     describe "with -w or --with-uri" do
       it "should pretty print the hash" do
         @knife.config[:with_uri] = true
-        Chef::Role.should_receive(:list).and_return(@list)
-        @knife.should_receive(:output).with(@list)
+        expect(Chef::Role).to receive(:list).and_return(@list)
+        expect(@knife).to receive(:output).with(@list)
         @knife.run
       end
     end

data/spec/unit/knife/role_run_list_add_spec.rb

@@ -0,0 +1,179 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Will Albenzi (<walbenzi@gmail.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# 
+#     http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Knife::RoleRunListAdd do
+  before(:each) do
+#    Chef::Config[:role_name]  = "websimian"
+#    Chef::Config[:env_name]  = "QA"
+    @knife = Chef::Knife::RoleRunListAdd.new
+    @knife.config = {
+      :after => nil
+    }
+    @knife.name_args = [ "will", "role[monkey]" ]
+    allow(@knife).to receive(:output).and_return(true)
+    @role = Chef::Role.new() 
+    allow(@role).to receive(:save).and_return(true)
+    allow(Chef::Role).to receive(:load).and_return(@role)
+  end
+
+  describe "run" do
+
+#    it "should display all the things" do
+#      @knife.run
+#      @role.to_json.should == 'show all the things'
+#    end
+
+    it "should have a run list with the monkey role" do
+      @knife.run
+      expect(@role.run_list[0]).to eq("role[monkey]")
+    end
+
+    it "should load the role named will" do
+      expect(Chef::Role).to receive(:load).with("will")
+      @knife.run
+    end
+
+    it "should save the role" do
+      expect(@role).to receive(:save)
+      @knife.run
+    end
+
+    it "should print the run list" do
+      expect(@knife).to receive(:output).and_return(true)
+      @knife.run
+    end
+
+    describe "with -a or --after specified" do
+      it "should not create a change if the specified 'after' never comes" do
+        @role.run_list_for("_default") << "role[acorns]"
+        @role.run_list_for("_default") << "role[barn]"
+        @knife.config[:after] = "role[tree]"
+        @knife.name_args = [ "will", "role[pad]" ]
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[barn]")
+        expect(@role.run_list[2]).to be_nil
+      end
+
+      it "should add to the run list after the specified entries in the default run list" do
+        #Setup
+        @role.run_list_for("_default") << "role[acorns]"
+        @role.run_list_for("_default") << "role[barn]"
+        #Configuration we are testing
+        @knife.config[:after] = "role[acorns]"
+        @knife.name_args = [ "will", "role[pad]", "role[whackadoo]" ]
+        @knife.run
+        #The actual tests
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[pad]")
+        expect(@role.run_list[2]).to eq("role[whackadoo]")
+        expect(@role.run_list[3]).to eq("role[barn]")
+        expect(@role.run_list[4]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe" do
+      it "should add to the QA run list all the entries" do
+        @knife.name_args = [ "will", "role[monkey],role[duck]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[monkey]")
+        expect(@role.run_list[2]).to eq("role[duck]")
+        expect(@role.run_list[3]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe with space between items" do
+      it "should add to the run list all the entries" do
+        @knife.name_args = [ "will", "role[monkey], role[duck]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[monkey]")
+        expect(@role.run_list[2]).to eq("role[duck]")
+        expect(@role.run_list[3]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe as different arguments" do
+      it "should add to the run list all the entries" do
+        @knife.name_args = [ "will", "role[monkey]", "role[duck]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[monkey]")
+        expect(@role.run_list[2]).to eq("role[duck]")
+        expect(@role.run_list[3]).to be_nil
+      end
+    end
+
+    describe "with more than one role or recipe as different arguments and list separated by comas" do
+      it "should add to the run list all the entries" do
+        @knife.name_args = [ "will", "role[monkey]", "role[duck],recipe[bird::fly]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[monkey]")
+        expect(@role.run_list[2]).to eq("role[duck]")
+        expect(@role.run_list[3]).to eq("recipe[bird::fly]")
+        expect(@role.run_list[4]).to be_nil
+      end
+    end
+
+    describe "Recipe with version number is allowed" do
+      it "should add to the run list all the entries including the versioned recipe" do
+        @knife.name_args = [ "will", "role[monkey]", "role[duck],recipe[bird::fly@1.1.3]" ]
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[monkey]")
+        expect(@role.run_list[2]).to eq("role[duck]")
+        expect(@role.run_list[3]).to eq("recipe[bird::fly@1.1.3]")
+        expect(@role.run_list[4]).to be_nil
+      end
+    end
+
+    describe "with one role or recipe but with an extraneous comma" do
+      it "should add to the run list one item" do
+        @role.run_list_for("_default") << "role[acorns]"
+        @knife.name_args = [ "will", "role[monkey]," ]
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[acorns]")
+        expect(@role.run_list[1]).to eq("role[monkey]")
+        expect(@role.run_list[2]).to be_nil
+      end
+    end
+    
+    describe "with more than one command" do
+      it "should be able to the environment run list by running multiple knife commands" do
+        @knife.name_args = [ "will", "role[blue]," ]
+        @knife.run
+        @knife.name_args = [ "will", "role[black]," ]
+        @knife.run
+        expect(@role.run_list[0]).to eq("role[blue]")
+        expect(@role.run_list[1]).to eq("role[black]")
+        expect(@role.run_list[2]).to be_nil
+      end
+    end
+
+  end
+end