chef 12.0.3-x86-mingw32 → 12.1.0.rc.0-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.
Files changed (653) hide show
  1. checksums.yaml +4 -4
  2. data/CONTRIBUTING.md +4 -1
  3. data/README.md +42 -18
  4. data/distro/common/html/_sources/ctl_chef_client.txt +1 -1
  5. data/distro/common/html/_sources/ctl_chef_server.txt +53 -35
  6. data/distro/common/html/_sources/ctl_chef_solo.txt +1 -1
  7. data/distro/common/html/_sources/knife_bootstrap.txt +1 -1
  8. data/distro/common/html/_sources/knife_cookbook_site.txt +1 -1
  9. data/distro/common/html/_sources/knife_data_bag.txt +4 -4
  10. data/distro/common/html/_sources/knife_status.txt +1 -1
  11. data/distro/common/html/_static/searchtools.js +1 -1
  12. data/distro/common/html/ctl_chef_client.html +55 -7
  13. data/distro/common/html/ctl_chef_server.html +84 -41
  14. data/distro/common/html/ctl_chef_shell.html +45 -1
  15. data/distro/common/html/ctl_chef_solo.html +51 -5
  16. data/distro/common/html/index.html +2 -2
  17. data/distro/common/html/knife.html +1 -1
  18. data/distro/common/html/knife_bootstrap.html +30 -10
  19. data/distro/common/html/knife_cookbook_site.html +2 -0
  20. data/distro/common/html/knife_data_bag.html +4 -4
  21. data/distro/common/html/knife_node.html +2 -2
  22. data/distro/common/html/knife_raw.html +1 -1
  23. data/distro/common/html/knife_role.html +1 -1
  24. data/distro/common/html/knife_search.html +3 -3
  25. data/distro/common/html/knife_status.html +4 -0
  26. data/distro/common/html/searchindex.js +1 -1
  27. data/distro/common/man/man1/chef-shell.1 +72 -1
  28. data/distro/common/man/man1/knife-bootstrap.1 +71 -63
  29. data/distro/common/man/man1/knife-client.1 +1 -1
  30. data/distro/common/man/man1/knife-configure.1 +1 -1
  31. data/distro/common/man/man1/knife-cookbook-site.1 +4 -1
  32. data/distro/common/man/man1/knife-cookbook.1 +1 -1
  33. data/distro/common/man/man1/knife-data-bag.1 +5 -5
  34. data/distro/common/man/man1/knife-delete.1 +1 -1
  35. data/distro/common/man/man1/knife-deps.1 +1 -1
  36. data/distro/common/man/man1/knife-diff.1 +1 -1
  37. data/distro/common/man/man1/knife-download.1 +1 -1
  38. data/distro/common/man/man1/knife-edit.1 +1 -1
  39. data/distro/common/man/man1/knife-environment.1 +1 -1
  40. data/distro/common/man/man1/knife-exec.1 +1 -1
  41. data/distro/common/man/man1/knife-index-rebuild.1 +1 -1
  42. data/distro/common/man/man1/knife-list.1 +1 -1
  43. data/distro/common/man/man1/knife-node.1 +3 -3
  44. data/distro/common/man/man1/knife-raw.1 +2 -2
  45. data/distro/common/man/man1/knife-recipe-list.1 +1 -1
  46. data/distro/common/man/man1/knife-role.1 +2 -2
  47. data/distro/common/man/man1/knife-search.1 +4 -4
  48. data/distro/common/man/man1/knife-serve.1 +1 -1
  49. data/distro/common/man/man1/knife-show.1 +1 -1
  50. data/distro/common/man/man1/knife-ssh.1 +1 -1
  51. data/distro/common/man/man1/knife-ssl-check.1 +1 -1
  52. data/distro/common/man/man1/knife-ssl-fetch.1 +1 -1
  53. data/distro/common/man/man1/knife-status.1 +1 -1
  54. data/distro/common/man/man1/knife-tag.1 +1 -1
  55. data/distro/common/man/man1/knife-upload.1 +1 -1
  56. data/distro/common/man/man1/knife-user.1 +1 -1
  57. data/distro/common/man/man1/knife-xargs.1 +1 -1
  58. data/distro/common/man/man1/knife.1 +1 -1
  59. data/distro/common/man/man8/chef-apply.8 +86 -0
  60. data/distro/common/man/man8/chef-client.8 +76 -5
  61. data/distro/common/man/man8/chef-solo.8 +79 -6
  62. data/distro/common/markdown/man1/knife-bootstrap.mkd +1 -1
  63. data/distro/common/markdown/man1/knife-cookbook-site.mkd +1 -1
  64. data/distro/common/markdown/man1/knife-data-bag.mkd +1 -1
  65. data/distro/common/markdown/man1/knife-environment.mkd +1 -1
  66. data/distro/common/markdown/man1/knife.mkd +1 -1
  67. data/lib/chef.rb +0 -7
  68. data/lib/chef/api_client.rb +10 -2
  69. data/lib/chef/api_client/registration.rb +7 -9
  70. data/lib/chef/application.rb +28 -12
  71. data/lib/chef/application/apply.rb +17 -1
  72. data/lib/chef/application/client.rb +74 -6
  73. data/lib/chef/application/knife.rb +1 -2
  74. data/lib/chef/application/solo.rb +30 -0
  75. data/lib/chef/application/windows_service.rb +1 -0
  76. data/lib/chef/application/windows_service_manager.rb +8 -2
  77. data/lib/chef/applications.rb +0 -1
  78. data/lib/chef/audit/audit_event_proxy.rb +93 -0
  79. data/lib/chef/audit/audit_reporter.rb +169 -0
  80. data/lib/chef/audit/control_group_data.rb +140 -0
  81. data/lib/chef/audit/rspec_formatter.rb +37 -0
  82. data/lib/chef/audit/runner.rb +178 -0
  83. data/lib/chef/chef_fs/chef_fs_data_store.rb +11 -2
  84. data/lib/chef/chef_fs/config.rb +25 -4
  85. data/lib/chef/chef_fs/data_handler/policy_data_handler.rb +15 -0
  86. data/lib/chef/chef_fs/data_handler/user_data_handler.rb +1 -0
  87. data/lib/chef/chef_fs/file_system.rb +1 -1
  88. data/lib/chef/chef_fs/file_system/base_fs_dir.rb +5 -0
  89. data/lib/chef/chef_fs/file_system/chef_repository_file_system_cookbook_entry.rb +3 -2
  90. data/lib/chef/{shef/ext.rb → chef_fs/file_system/chef_repository_file_system_policies_dir.rb} +22 -3
  91. data/lib/chef/chef_fs/file_system/chef_repository_file_system_root_dir.rb +4 -0
  92. data/lib/chef/client.rb +81 -52
  93. data/lib/chef/config.rb +35 -3
  94. data/lib/chef/cookbook/metadata.rb +3 -3
  95. data/lib/chef/cookbook_manifest.rb +275 -0
  96. data/lib/chef/cookbook_site_streaming_uploader.rb +24 -23
  97. data/lib/chef/cookbook_uploader.rb +11 -2
  98. data/lib/chef/cookbook_version.rb +71 -194
  99. data/lib/chef/data_bag.rb +5 -2
  100. data/lib/chef/data_bag_item.rb +6 -3
  101. data/lib/chef/deprecation/warnings.rb +5 -4
  102. data/lib/chef/dsl/audit.rb +51 -0
  103. data/lib/chef/dsl/include_recipe.rb +2 -3
  104. data/lib/chef/dsl/reboot_pending.rb +1 -1
  105. data/lib/chef/dsl/recipe.rb +49 -31
  106. data/lib/chef/encrypted_data_bag_item/assertions.rb +0 -3
  107. data/lib/chef/environment.rb +5 -2
  108. data/lib/chef/event_dispatch/base.rb +36 -1
  109. data/lib/chef/event_dispatch/dispatcher.rb +3 -5
  110. data/lib/chef/exceptions.rb +61 -2
  111. data/lib/chef/file_access_control/unix.rb +12 -0
  112. data/lib/chef/file_access_control/windows.rb +14 -0
  113. data/lib/chef/formatters/doc.rb +47 -1
  114. data/{spec/unit/monkey_patches/string_spec.rb → lib/chef/guard_interpreter.rb} +11 -16
  115. data/lib/chef/guard_interpreter/resource_guard_interpreter.rb +3 -2
  116. data/lib/chef/http.rb +1 -2
  117. data/lib/chef/knife.rb +5 -3
  118. data/lib/chef/knife/bootstrap.rb +84 -15
  119. data/lib/chef/knife/bootstrap/chef_vault_handler.rb +165 -0
  120. data/lib/chef/knife/bootstrap/client_builder.rb +190 -0
  121. data/lib/chef/knife/bootstrap/{README.md → templates/README.md} +0 -0
  122. data/lib/chef/knife/bootstrap/{archlinux-gems.erb → templates/archlinux-gems.erb} +9 -0
  123. data/lib/chef/knife/bootstrap/{chef-aix.erb → templates/chef-aix.erb} +9 -0
  124. data/lib/chef/knife/bootstrap/{chef-full.erb → templates/chef-full.erb} +10 -1
  125. data/lib/chef/knife/client_create.rb +8 -7
  126. data/lib/chef/knife/cookbook_site_download.rb +1 -1
  127. data/lib/chef/knife/cookbook_site_install.rb +1 -1
  128. data/lib/chef/knife/cookbook_site_list.rb +1 -1
  129. data/lib/chef/knife/cookbook_site_search.rb +1 -1
  130. data/lib/chef/knife/cookbook_site_share.rb +39 -28
  131. data/lib/chef/knife/cookbook_site_show.rb +3 -3
  132. data/lib/chef/knife/cookbook_site_unshare.rb +1 -1
  133. data/lib/chef/knife/cookbook_test.rb +1 -0
  134. data/lib/chef/knife/cookbook_upload.rb +13 -8
  135. data/lib/chef/knife/core/bootstrap_context.rb +14 -3
  136. data/lib/chef/knife/core/generic_presenter.rb +5 -2
  137. data/lib/chef/knife/core/object_loader.rb +1 -1
  138. data/lib/chef/knife/core/subcommand_loader.rb +24 -0
  139. data/lib/chef/knife/core/ui.rb +9 -1
  140. data/lib/chef/knife/node_run_list_remove.rb +11 -3
  141. data/lib/chef/knife/raw.rb +14 -3
  142. data/lib/chef/knife/role_env_run_list_add.rb +86 -0
  143. data/lib/chef/knife/role_env_run_list_clear.rb +55 -0
  144. data/lib/chef/knife/role_env_run_list_remove.rb +57 -0
  145. data/lib/chef/knife/role_env_run_list_replace.rb +59 -0
  146. data/lib/chef/knife/role_env_run_list_set.rb +70 -0
  147. data/lib/chef/knife/role_run_list_add.rb +86 -0
  148. data/lib/chef/knife/role_run_list_clear.rb +55 -0
  149. data/lib/chef/knife/role_run_list_remove.rb +57 -0
  150. data/lib/chef/knife/role_run_list_replace.rb +59 -0
  151. data/lib/chef/knife/role_run_list_set.rb +70 -0
  152. data/lib/chef/knife/search.rb +4 -4
  153. data/lib/chef/knife/serve.rb +3 -0
  154. data/lib/chef/knife/ssh.rb +1 -1
  155. data/lib/chef/knife/ssl_check.rb +2 -2
  156. data/lib/chef/knife/ssl_fetch.rb +14 -1
  157. data/lib/chef/log.rb +10 -1
  158. data/lib/chef/mixin/command.rb +1 -1
  159. data/lib/chef/mixin/command/windows.rb +1 -5
  160. data/lib/chef/mixin/get_source_from_package.rb +1 -0
  161. data/lib/chef/mixin/params_validate.rb +2 -2
  162. data/lib/chef/mixin/securable.rb +1 -7
  163. data/lib/chef/mixin/shell_out.rb +7 -1
  164. data/lib/chef/mixin/template.rb +2 -14
  165. data/lib/chef/mixin/why_run.rb +1 -1
  166. data/lib/chef/monkey_patches/net_http.rb +4 -0
  167. data/lib/chef/monologger.rb +0 -2
  168. data/lib/chef/node.rb +5 -2
  169. data/lib/chef/node/attribute.rb +11 -9
  170. data/lib/chef/node/attribute_collections.rb +8 -12
  171. data/lib/chef/node/immutable_collections.rb +4 -10
  172. data/lib/chef/org.rb +148 -0
  173. data/lib/chef/platform/provider_mapping.rb +3 -2
  174. data/lib/chef/platform/provider_priority_map.rb +2 -0
  175. data/lib/chef/platform/query_helpers.rb +0 -3
  176. data/lib/chef/policy_builder/policyfile.rb +51 -8
  177. data/lib/chef/provider/deploy.rb +1 -2
  178. data/lib/chef/provider/directory.rb +3 -3
  179. data/lib/chef/provider/dsc_script.rb +13 -7
  180. data/lib/chef/provider/env.rb +8 -8
  181. data/lib/chef/provider/execute.rb +55 -36
  182. data/lib/chef/provider/file.rb +8 -0
  183. data/lib/chef/provider/group.rb +2 -0
  184. data/lib/chef/provider/group/dscl.rb +3 -4
  185. data/lib/chef/provider/ifconfig.rb +25 -25
  186. data/lib/chef/provider/ifconfig/aix.rb +25 -27
  187. data/lib/chef/provider/lwrp_base.rb +1 -1
  188. data/lib/chef/provider/mount.rb +2 -2
  189. data/lib/chef/provider/mount/mount.rb +3 -4
  190. data/lib/chef/provider/mount/solaris.rb +1 -1
  191. data/lib/chef/provider/package.rb +297 -48
  192. data/lib/chef/provider/package/aix.rb +25 -30
  193. data/lib/chef/provider/package/apt.rb +63 -19
  194. data/lib/chef/provider/package/dpkg.rb +15 -16
  195. data/lib/chef/provider/package/macports.rb +7 -7
  196. data/lib/chef/provider/package/openbsd.rb +107 -0
  197. data/lib/chef/provider/package/pacman.rb +13 -15
  198. data/lib/chef/provider/package/portage.rb +3 -4
  199. data/lib/chef/provider/package/rpm.rb +28 -17
  200. data/lib/chef/provider/package/rubygems.rb +9 -9
  201. data/lib/chef/provider/package/solaris.rb +17 -21
  202. data/lib/chef/provider/package/windows/msi.rb +1 -1
  203. data/lib/chef/provider/package/yum-dump.py +2 -2
  204. data/lib/chef/provider/package/yum.rb +117 -51
  205. data/lib/chef/provider/package/zypper.rb +17 -18
  206. data/lib/chef/provider/powershell_script.rb +4 -4
  207. data/lib/chef/provider/registry_key.rb +2 -2
  208. data/lib/chef/provider/remote_directory.rb +1 -1
  209. data/lib/chef/provider/script.rb +25 -16
  210. data/lib/chef/provider/service.rb +1 -1
  211. data/lib/chef/provider/service/freebsd.rb +1 -1
  212. data/lib/chef/provider/service/openbsd.rb +216 -0
  213. data/lib/chef/provider/service/upstart.rb +1 -1
  214. data/lib/chef/provider/service/windows.rb +99 -1
  215. data/lib/chef/provider/user.rb +1 -1
  216. data/lib/chef/provider/user/dscl.rb +19 -4
  217. data/lib/chef/providers.rb +2 -0
  218. data/lib/chef/recipe.rb +11 -5
  219. data/lib/chef/request_id.rb +1 -1
  220. data/lib/chef/resource.rb +839 -444
  221. data/lib/chef/resource/chef_gem.rb +20 -3
  222. data/lib/chef/resource/conditional.rb +3 -14
  223. data/lib/chef/resource/dsc_script.rb +14 -0
  224. data/lib/chef/resource/execute.rb +14 -7
  225. data/lib/chef/resource/file.rb +14 -0
  226. data/lib/chef/resource/file/verification.rb +122 -0
  227. data/lib/chef/resource/ips_package.rb +1 -1
  228. data/lib/chef/resource/lwrp_base.rb +2 -11
  229. data/lib/chef/resource/macports_package.rb +2 -1
  230. data/lib/chef/resource/openbsd_package.rb +51 -0
  231. data/lib/chef/resource/package.rb +2 -2
  232. data/lib/chef/resource/paludis_package.rb +1 -1
  233. data/lib/chef/resource/reboot.rb +1 -1
  234. data/lib/chef/resource/remote_file.rb +1 -0
  235. data/lib/chef/resource/rpm_package.rb +9 -0
  236. data/lib/chef/resource/script.rb +11 -0
  237. data/lib/chef/resource/template.rb +2 -3
  238. data/lib/chef/resource/windows_package.rb +1 -1
  239. data/lib/chef/resource/windows_service.rb +18 -0
  240. data/lib/chef/resource_builder.rb +137 -0
  241. data/lib/chef/resource_definition.rb +1 -1
  242. data/lib/chef/resource_reporter.rb +1 -1
  243. data/lib/chef/resources.rb +1 -0
  244. data/lib/chef/role.rb +17 -4
  245. data/lib/chef/run_context.rb +10 -6
  246. data/lib/chef/search/query.rb +66 -87
  247. data/lib/chef/shell/ext.rb +2 -2
  248. data/lib/chef/util/diff.rb +1 -4
  249. data/lib/chef/util/dsc/configuration_generator.rb +30 -6
  250. data/lib/chef/util/dsc/lcm_output_parser.rb +7 -3
  251. data/lib/chef/util/dsc/local_configuration_manager.rb +8 -8
  252. data/lib/chef/util/file_edit.rb +2 -2
  253. data/lib/chef/util/path_helper.rb +1 -4
  254. data/lib/chef/util/windows/net_use.rb +3 -3
  255. data/lib/chef/version.rb +1 -1
  256. data/lib/chef/win32/api.rb +1 -0
  257. data/lib/chef/win32/api/security.rb +26 -0
  258. data/lib/chef/win32/file.rb +21 -0
  259. data/lib/chef/win32/security.rb +46 -0
  260. data/lib/chef/win32/security/token.rb +8 -0
  261. data/lib/chef/win32/version.rb +0 -4
  262. data/spec/data/recipes.tgz +0 -0
  263. data/spec/functional/application_spec.rb +1 -1
  264. data/spec/functional/audit/rspec_formatter_spec.rb +54 -0
  265. data/spec/functional/audit/runner_spec.rb +137 -0
  266. data/spec/functional/dsl/reboot_pending_spec.rb +10 -10
  267. data/spec/functional/dsl/registry_helper_spec.rb +6 -6
  268. data/spec/functional/event_loggers/windows_eventlog_spec.rb +5 -5
  269. data/spec/functional/file_content_management/deploy_strategies_spec.rb +12 -21
  270. data/spec/functional/http/simple_spec.rb +1 -1
  271. data/spec/functional/knife/cookbook_delete_spec.rb +24 -24
  272. data/spec/functional/knife/exec_spec.rb +2 -4
  273. data/spec/functional/knife/smoke_test.rb +1 -1
  274. data/spec/functional/knife/ssh_spec.rb +23 -23
  275. data/spec/functional/provider/remote_file/cache_control_data_spec.rb +8 -8
  276. data/spec/functional/provider/whyrun_safe_ruby_block_spec.rb +2 -2
  277. data/spec/functional/rebooter_spec.rb +1 -1
  278. data/spec/functional/resource/aix_service_spec.rb +3 -0
  279. data/spec/functional/resource/aixinit_service_spec.rb +3 -3
  280. data/spec/functional/resource/bash_spec.rb +88 -0
  281. data/spec/functional/resource/deploy_revision_spec.rb +99 -100
  282. data/spec/functional/resource/env_spec.rb +3 -3
  283. data/spec/functional/resource/execute_spec.rb +97 -63
  284. data/spec/functional/resource/file_spec.rb +7 -7
  285. data/spec/functional/resource/git_spec.rb +13 -13
  286. data/spec/functional/resource/group_spec.rb +28 -25
  287. data/spec/functional/resource/ifconfig_spec.rb +2 -2
  288. data/spec/functional/resource/link_spec.rb +77 -78
  289. data/spec/functional/resource/mount_spec.rb +5 -5
  290. data/spec/functional/resource/ohai_spec.rb +1 -1
  291. data/spec/functional/resource/package_spec.rb +22 -22
  292. data/spec/functional/resource/powershell_spec.rb +57 -42
  293. data/spec/functional/resource/reboot_spec.rb +2 -2
  294. data/spec/functional/resource/registry_spec.rb +91 -91
  295. data/spec/functional/resource/remote_directory_spec.rb +19 -19
  296. data/spec/functional/resource/remote_file_spec.rb +18 -18
  297. data/spec/functional/resource/template_spec.rb +4 -4
  298. data/spec/functional/resource/user/dscl_spec.rb +4 -4
  299. data/spec/functional/resource/user/useradd_spec.rb +64 -51
  300. data/spec/functional/resource/windows_service_spec.rb +98 -0
  301. data/spec/functional/run_lock_spec.rb +9 -9
  302. data/spec/functional/shell_spec.rb +3 -3
  303. data/spec/functional/tiny_server_spec.rb +12 -12
  304. data/spec/functional/util/path_helper_spec.rb +1 -1
  305. data/spec/functional/version_spec.rb +1 -1
  306. data/spec/functional/win32/registry_helper_spec.rb +125 -125
  307. data/spec/functional/win32/security_spec.rb +65 -2
  308. data/spec/functional/win32/service_manager_spec.rb +30 -84
  309. data/spec/functional/win32/versions_spec.rb +6 -6
  310. data/spec/integration/client/client_spec.rb +102 -9
  311. data/spec/integration/knife/chef_fs_data_store_spec.rb +12 -8
  312. data/spec/integration/knife/common_options_spec.rb +3 -3
  313. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +2 -2
  314. data/spec/integration/knife/deps_spec.rb +4 -4
  315. data/spec/integration/knife/diff_spec.rb +6 -6
  316. data/spec/integration/knife/download_spec.rb +6 -6
  317. data/spec/integration/knife/list_spec.rb +2 -2
  318. data/spec/integration/knife/raw_spec.rb +5 -5
  319. data/spec/integration/knife/serve_spec.rb +3 -3
  320. data/spec/integration/knife/show_spec.rb +3 -3
  321. data/spec/integration/knife/upload_spec.rb +18 -18
  322. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +1 -1
  323. data/spec/integration/solo/solo_spec.rb +11 -12
  324. data/spec/spec_helper.rb +27 -15
  325. data/spec/stress/win32/file_spec.rb +4 -4
  326. data/spec/stress/win32/security_spec.rb +4 -4
  327. data/spec/support/chef_helpers.rb +3 -3
  328. data/spec/support/matchers/leak.rb +2 -2
  329. data/spec/support/mock/platform.rb +1 -1
  330. data/spec/support/pedant/Gemfile +3 -0
  331. data/spec/support/pedant/pedant_config.rb +9 -2
  332. data/spec/support/pedant/run_pedant.rb +15 -16
  333. data/spec/support/platform_helpers.rb +8 -12
  334. data/spec/support/shared/functional/directory_resource.rb +13 -13
  335. data/spec/support/shared/functional/file_resource.rb +83 -83
  336. data/spec/support/shared/functional/http.rb +1 -1
  337. data/spec/support/shared/functional/securable_resource.rb +64 -64
  338. data/spec/support/shared/functional/securable_resource_with_reporting.rb +43 -41
  339. data/spec/support/shared/functional/win32_service.rb +60 -0
  340. data/spec/support/shared/functional/windows_script.rb +8 -8
  341. data/spec/support/shared/integration/knife_support.rb +8 -5
  342. data/spec/support/shared/matchers/exit_with_code.rb +6 -2
  343. data/spec/support/shared/unit/api_error_inspector.rb +8 -8
  344. data/spec/support/shared/unit/execute_resource.rb +24 -20
  345. data/spec/support/shared/unit/file_system_support.rb +2 -2
  346. data/spec/support/shared/unit/platform_introspector.rb +21 -21
  347. data/spec/support/shared/unit/provider/file.rb +239 -210
  348. data/spec/support/shared/unit/provider/useradd_based_user_provider.rb +69 -69
  349. data/spec/support/shared/unit/script_resource.rb +40 -32
  350. data/spec/support/shared/unit/windows_script_resource.rb +8 -8
  351. data/spec/unit/api_client/registration_spec.rb +47 -47
  352. data/spec/unit/api_client_spec.rb +107 -69
  353. data/spec/unit/application/apply_spec.rb +31 -15
  354. data/spec/unit/application/client_spec.rb +146 -45
  355. data/spec/unit/application/knife_spec.rb +31 -31
  356. data/spec/unit/application/solo_spec.rb +59 -43
  357. data/spec/unit/application_spec.rb +109 -74
  358. data/spec/unit/audit/audit_event_proxy_spec.rb +311 -0
  359. data/spec/unit/audit/audit_reporter_spec.rb +393 -0
  360. data/spec/unit/audit/control_group_data_spec.rb +478 -0
  361. data/{lib/chef/monkey_patches/file.rb → spec/unit/audit/rspec_formatter_spec.rb} +11 -8
  362. data/spec/unit/audit/runner_spec.rb +135 -0
  363. data/spec/unit/chef_fs/config_spec.rb +52 -0
  364. data/spec/unit/chef_fs/diff_spec.rb +12 -12
  365. data/spec/unit/chef_fs/file_pattern_spec.rb +276 -277
  366. data/spec/unit/chef_fs/file_system/operation_failed_error_spec.rb +6 -6
  367. data/spec/unit/chef_fs/file_system_spec.rb +26 -13
  368. data/spec/unit/chef_fs/parallelizer.rb +87 -87
  369. data/spec/unit/chef_spec.rb +1 -1
  370. data/spec/unit/client_spec.rb +263 -97
  371. data/spec/unit/config_fetcher_spec.rb +13 -13
  372. data/spec/unit/config_spec.rb +105 -66
  373. data/spec/unit/cookbook/chefignore_spec.rb +6 -6
  374. data/spec/unit/cookbook/cookbook_version_loader_spec.rb +3 -3
  375. data/spec/unit/cookbook/metadata_spec.rb +149 -149
  376. data/spec/unit/cookbook/syntax_check_spec.rb +36 -31
  377. data/spec/unit/cookbook_loader_spec.rb +62 -58
  378. data/spec/unit/cookbook_manifest_spec.rb +141 -468
  379. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +27 -27
  380. data/spec/unit/cookbook_spec.rb +15 -15
  381. data/spec/unit/cookbook_uploader_spec.rb +37 -3
  382. data/spec/unit/cookbook_version_file_specificity_spec.rb +554 -0
  383. data/spec/unit/cookbook_version_spec.rb +98 -240
  384. data/spec/unit/daemon_spec.rb +31 -31
  385. data/spec/unit/data_bag_item_spec.rb +121 -89
  386. data/spec/unit/data_bag_spec.rb +35 -35
  387. data/spec/unit/deprecation_spec.rb +27 -14
  388. data/spec/unit/digester_spec.rb +3 -3
  389. data/spec/unit/dsl/audit_spec.rb +43 -0
  390. data/spec/unit/dsl/data_query_spec.rb +1 -1
  391. data/spec/unit/dsl/platform_introspection_spec.rb +14 -14
  392. data/spec/unit/dsl/reboot_pending_spec.rb +18 -18
  393. data/spec/unit/dsl/regsitry_helper_spec.rb +6 -6
  394. data/spec/unit/encrypted_data_bag_item_spec.rb +58 -82
  395. data/spec/unit/environment_spec.rb +105 -105
  396. data/spec/unit/exceptions_spec.rb +47 -1
  397. data/spec/unit/file_access_control_spec.rb +62 -56
  398. data/spec/unit/file_cache_spec.rb +11 -11
  399. data/spec/unit/file_content_management/deploy/cp_spec.rb +2 -2
  400. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +10 -10
  401. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +23 -23
  402. data/spec/unit/formatters/error_inspectors/compile_error_inspector_spec.rb +14 -14
  403. data/spec/unit/formatters/error_inspectors/cookbook_resolve_error_inspector_spec.rb +12 -12
  404. data/spec/unit/formatters/error_inspectors/cookbook_sync_error_inspector_spec.rb +1 -1
  405. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +16 -16
  406. data/spec/unit/formatters/error_inspectors/run_list_expansion_error_inspector_spec.rb +4 -4
  407. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +103 -13
  408. data/spec/unit/guard_interpreter_spec.rb +41 -0
  409. data/spec/unit/handler/json_file_spec.rb +10 -10
  410. data/spec/unit/handler_spec.rb +39 -39
  411. data/spec/unit/http/basic_client_spec.rb +3 -3
  412. data/spec/unit/http/http_request_spec.rb +10 -10
  413. data/spec/unit/http/simple_spec.rb +3 -3
  414. data/spec/unit/http/ssl_policies_spec.rb +15 -15
  415. data/spec/unit/http/validate_content_length_spec.rb +18 -13
  416. data/spec/unit/http_spec.rb +16 -9
  417. data/spec/unit/knife/bootstrap/chef_vault_handler_spec.rb +153 -0
  418. data/spec/unit/knife/bootstrap/client_builder_spec.rb +178 -0
  419. data/spec/unit/knife/bootstrap_spec.rb +144 -91
  420. data/spec/unit/knife/client_bulk_delete_spec.rb +24 -24
  421. data/spec/unit/knife/client_create_spec.rb +57 -43
  422. data/spec/unit/knife/client_delete_spec.rb +15 -15
  423. data/spec/unit/knife/client_edit_spec.rb +4 -4
  424. data/spec/unit/knife/client_list_spec.rb +2 -2
  425. data/spec/unit/knife/client_reregister_spec.rb +9 -9
  426. data/spec/unit/knife/configure_client_spec.rb +20 -20
  427. data/spec/unit/knife/configure_spec.rb +85 -85
  428. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +15 -15
  429. data/spec/unit/knife/cookbook_create_spec.rb +59 -59
  430. data/spec/unit/knife/cookbook_delete_spec.rb +49 -49
  431. data/spec/unit/knife/cookbook_download_spec.rb +56 -56
  432. data/spec/unit/knife/cookbook_list_spec.rb +9 -9
  433. data/spec/unit/knife/cookbook_metadata_from_file_spec.rb +8 -8
  434. data/spec/unit/knife/cookbook_metadata_spec.rb +44 -44
  435. data/spec/unit/knife/cookbook_show_spec.rb +29 -29
  436. data/spec/unit/knife/cookbook_site_download_spec.rb +26 -26
  437. data/spec/unit/knife/cookbook_site_install_spec.rb +5 -1
  438. data/spec/unit/knife/cookbook_site_share_spec.rb +68 -59
  439. data/spec/unit/knife/cookbook_site_unshare_spec.rb +15 -15
  440. data/spec/unit/knife/cookbook_test_spec.rb +16 -16
  441. data/spec/unit/knife/cookbook_upload_spec.rb +105 -71
  442. data/spec/unit/knife/core/bootstrap_context_spec.rb +37 -22
  443. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +36 -36
  444. data/spec/unit/knife/core/object_loader_spec.rb +3 -3
  445. data/spec/unit/knife/core/subcommand_loader_spec.rb +107 -33
  446. data/spec/unit/knife/core/ui_spec.rb +84 -72
  447. data/spec/unit/knife/data_bag_from_file_spec.rb +1 -1
  448. data/spec/unit/knife/environment_compare_spec.rb +12 -12
  449. data/spec/unit/knife/environment_create_spec.rb +16 -16
  450. data/spec/unit/knife/environment_delete_spec.rb +14 -14
  451. data/spec/unit/knife/environment_edit_spec.rb +15 -15
  452. data/spec/unit/knife/environment_from_file_spec.rb +17 -17
  453. data/spec/unit/knife/environment_list_spec.rb +7 -7
  454. data/spec/unit/knife/environment_show_spec.rb +10 -10
  455. data/spec/unit/knife/index_rebuild_spec.rb +17 -17
  456. data/spec/unit/knife/knife_help.rb +24 -24
  457. data/spec/unit/knife/node_bulk_delete_spec.rb +14 -14
  458. data/spec/unit/knife/node_delete_spec.rb +11 -11
  459. data/spec/unit/knife/node_edit_spec.rb +17 -17
  460. data/spec/unit/knife/node_environment_set_spec.rb +12 -12
  461. data/spec/unit/knife/node_from_file_spec.rb +8 -8
  462. data/spec/unit/knife/node_list_spec.rb +9 -9
  463. data/spec/unit/knife/node_run_list_add_spec.rb +29 -29
  464. data/spec/unit/knife/node_run_list_remove_spec.rb +28 -13
  465. data/spec/unit/knife/node_run_list_set_spec.rb +27 -27
  466. data/spec/unit/knife/raw_spec.rb +43 -0
  467. data/spec/unit/knife/role_bulk_delete_spec.rb +12 -12
  468. data/spec/unit/knife/role_create_spec.rb +12 -12
  469. data/spec/unit/knife/role_delete_spec.rb +10 -10
  470. data/spec/unit/knife/role_edit_spec.rb +13 -13
  471. data/spec/unit/knife/role_env_run_list_add_spec.rb +217 -0
  472. data/spec/unit/knife/role_env_run_list_clear_spec.rb +100 -0
  473. data/spec/unit/knife/role_env_run_list_remove_spec.rb +108 -0
  474. data/spec/unit/knife/role_env_run_list_replace_spec.rb +108 -0
  475. data/spec/unit/knife/role_env_run_list_set_spec.rb +102 -0
  476. data/spec/unit/knife/role_from_file_spec.rb +10 -10
  477. data/spec/unit/knife/role_list_spec.rb +7 -7
  478. data/spec/unit/knife/role_run_list_add_spec.rb +179 -0
  479. data/spec/unit/knife/role_run_list_clear_spec.rb +90 -0
  480. data/spec/unit/knife/role_run_list_remove_spec.rb +98 -0
  481. data/spec/unit/knife/role_run_list_replace_spec.rb +101 -0
  482. data/spec/unit/knife/role_run_list_set_spec.rb +92 -0
  483. data/spec/unit/knife/ssh_spec.rb +66 -66
  484. data/spec/unit/knife/ssl_check_spec.rb +27 -27
  485. data/spec/unit/knife/ssl_fetch_spec.rb +45 -12
  486. data/spec/unit/knife/status_spec.rb +5 -5
  487. data/spec/unit/knife/tag_create_spec.rb +5 -5
  488. data/spec/unit/knife/tag_delete_spec.rb +6 -6
  489. data/spec/unit/knife/tag_list_spec.rb +4 -4
  490. data/spec/unit/knife/user_create_spec.rb +18 -18
  491. data/spec/unit/knife/user_delete_spec.rb +4 -4
  492. data/spec/unit/knife/user_edit_spec.rb +7 -7
  493. data/spec/unit/knife/user_list_spec.rb +2 -2
  494. data/spec/unit/knife/user_reregister_spec.rb +10 -10
  495. data/spec/unit/knife/user_show_spec.rb +5 -5
  496. data/spec/unit/knife_spec.rb +36 -36
  497. data/spec/unit/lwrp_spec.rb +63 -39
  498. data/spec/unit/mash_spec.rb +6 -6
  499. data/spec/unit/mixin/checksum_spec.rb +2 -2
  500. data/spec/unit/mixin/command_spec.rb +13 -13
  501. data/spec/unit/mixin/convert_to_class_name_spec.rb +6 -6
  502. data/spec/unit/mixin/deep_merge_spec.rb +49 -49
  503. data/spec/unit/mixin/deprecation_spec.rb +5 -5
  504. data/spec/unit/mixin/enforce_ownership_and_permissions_spec.rb +14 -14
  505. data/spec/unit/mixin/homebrew_user_spec.rb +3 -3
  506. data/spec/unit/mixin/params_validate_spec.rb +71 -71
  507. data/spec/unit/mixin/path_sanity_spec.rb +14 -14
  508. data/spec/unit/mixin/securable_spec.rb +177 -177
  509. data/spec/unit/mixin/shell_out_spec.rb +56 -27
  510. data/spec/unit/mixin/template_spec.rb +31 -31
  511. data/spec/unit/mixin/windows_architecture_helper_spec.rb +5 -5
  512. data/spec/unit/mixin/xml_escape_spec.rb +7 -7
  513. data/spec/unit/monkey_patches/uri_spec.rb +1 -1
  514. data/spec/unit/monologger_spec.rb +3 -3
  515. data/spec/unit/node/attribute_spec.rb +185 -136
  516. data/spec/unit/node/immutable_collections_spec.rb +22 -22
  517. data/spec/unit/node_spec.rb +210 -179
  518. data/spec/unit/org_spec.rb +196 -0
  519. data/spec/unit/platform/query_helpers_spec.rb +5 -5
  520. data/spec/unit/platform_spec.rb +46 -46
  521. data/spec/unit/policy_builder/expand_node_object_spec.rb +17 -18
  522. data/spec/unit/policy_builder/policyfile_spec.rb +159 -71
  523. data/spec/unit/provider/directory_spec.rb +5 -5
  524. data/spec/unit/provider/dsc_script_spec.rb +6 -6
  525. data/spec/unit/provider/env_spec.rb +27 -14
  526. data/spec/unit/provider/execute_spec.rb +139 -68
  527. data/spec/unit/provider/file/content_spec.rb +8 -8
  528. data/spec/unit/provider/git_spec.rb +10 -5
  529. data/spec/unit/provider/group/dscl_spec.rb +8 -11
  530. data/spec/unit/provider/group_spec.rb +13 -13
  531. data/spec/unit/provider/ifconfig/aix_spec.rb +3 -2
  532. data/spec/unit/provider/ifconfig/debian_spec.rb +19 -19
  533. data/spec/unit/provider/ifconfig_spec.rb +2 -2
  534. data/spec/unit/provider/mdadm_spec.rb +2 -2
  535. data/spec/unit/provider/mount/aix_spec.rb +5 -5
  536. data/spec/unit/provider/mount/mount_spec.rb +22 -22
  537. data/spec/unit/provider/mount/solaris_spec.rb +20 -20
  538. data/spec/unit/provider/package/aix_spec.rb +23 -22
  539. data/spec/unit/provider/package/apt_spec.rb +23 -4
  540. data/spec/unit/provider/package/dpkg_spec.rb +14 -15
  541. data/spec/unit/provider/package/freebsd/pkgng_spec.rb +1 -1
  542. data/spec/unit/provider/package/freebsd/port_spec.rb +1 -1
  543. data/spec/unit/provider/package/ips_spec.rb +1 -2
  544. data/spec/unit/provider/package/macports_spec.rb +14 -14
  545. data/spec/unit/provider/package/openbsd_spec.rb +66 -0
  546. data/spec/unit/provider/package/pacman_spec.rb +15 -14
  547. data/spec/unit/provider/package/portage_spec.rb +11 -11
  548. data/spec/unit/provider/package/rpm_spec.rb +132 -84
  549. data/spec/unit/provider/package/rubygems_spec.rb +54 -25
  550. data/spec/unit/provider/package/solaris_spec.rb +22 -25
  551. data/spec/unit/provider/package/yum_spec.rb +237 -36
  552. data/spec/unit/provider/package/zypper_spec.rb +9 -12
  553. data/spec/unit/provider/package_spec.rb +276 -2
  554. data/spec/unit/provider/package_spec.rbe +0 -0
  555. data/spec/unit/provider/remote_directory_spec.rb +25 -25
  556. data/spec/unit/provider/remote_file/ftp_spec.rb +3 -3
  557. data/spec/unit/provider/route_spec.rb +3 -3
  558. data/spec/unit/provider/script_spec.rb +61 -43
  559. data/spec/unit/provider/service/aix_service_spec.rb +5 -5
  560. data/spec/unit/provider/service/arch_service_spec.rb +5 -5
  561. data/spec/unit/provider/service/debian_service_spec.rb +8 -8
  562. data/spec/unit/provider/service/freebsd_service_spec.rb +16 -2
  563. data/spec/unit/provider/service/gentoo_service_spec.rb +8 -8
  564. data/spec/unit/provider/service/init_service_spec.rb +5 -5
  565. data/spec/unit/provider/service/insserv_service_spec.rb +2 -2
  566. data/spec/unit/provider/service/invokercd_service_spec.rb +5 -5
  567. data/spec/unit/provider/service/macosx_spec.rb +7 -7
  568. data/spec/unit/provider/service/openbsd_service_spec.rb +543 -0
  569. data/spec/unit/provider/service/redhat_spec.rb +4 -4
  570. data/spec/unit/provider/service/simple_service_spec.rb +2 -2
  571. data/spec/unit/provider/service/solaris_smf_service_spec.rb +14 -14
  572. data/spec/unit/provider/service/systemd_service_spec.rb +15 -7
  573. data/spec/unit/provider/service/upstart_service_spec.rb +4 -4
  574. data/spec/unit/provider/service/windows_spec.rb +119 -25
  575. data/spec/unit/provider/service_spec.rb +1 -1
  576. data/spec/unit/provider/user/dscl_spec.rb +38 -30
  577. data/spec/unit/provider/user_spec.rb +1 -1
  578. data/spec/unit/provider_resolver_spec.rb +7 -7
  579. data/spec/unit/provider_spec.rb +23 -23
  580. data/spec/unit/recipe_spec.rb +194 -83
  581. data/spec/unit/registry_helper_spec.rb +143 -143
  582. data/spec/unit/resource/chef_gem_spec.rb +117 -3
  583. data/spec/unit/resource/conditional_action_not_nothing_spec.rb +2 -2
  584. data/spec/unit/resource/conditional_spec.rb +56 -15
  585. data/spec/unit/resource/deploy_spec.rb +2 -2
  586. data/spec/unit/resource/dsc_script_spec.rb +32 -0
  587. data/spec/unit/resource/execute_spec.rb +4 -0
  588. data/spec/unit/resource/file/verification_spec.rb +111 -0
  589. data/spec/unit/resource/file_spec.rb +14 -0
  590. data/spec/unit/resource/openbsd_package_spec.rb +49 -0
  591. data/spec/unit/resource/remote_file_spec.rb +12 -12
  592. data/spec/unit/resource/resource_notification_spec.rb +18 -18
  593. data/spec/unit/resource/rpm_package_spec.rb +12 -0
  594. data/spec/unit/resource/scm_spec.rb +4 -4
  595. data/spec/unit/resource/script_spec.rb +3 -5
  596. data/spec/unit/resource/subversion_spec.rb +1 -1
  597. data/spec/unit/resource_builder_spec.rb +1 -0
  598. data/spec/unit/resource_collection/resource_list_spec.rb +2 -2
  599. data/spec/unit/resource_collection/resource_set_spec.rb +3 -3
  600. data/spec/unit/resource_collection/stepable_iterator_spec.rb +24 -24
  601. data/spec/unit/resource_collection_spec.rb +52 -52
  602. data/spec/unit/resource_definition_spec.rb +1 -1
  603. data/spec/unit/resource_reporter_spec.rb +118 -118
  604. data/spec/unit/resource_spec.rb +131 -125
  605. data/spec/unit/rest/auth_credentials_spec.rb +73 -73
  606. data/spec/unit/rest_spec.rb +12 -12
  607. data/spec/unit/role_spec.rb +85 -84
  608. data/spec/unit/run_context/cookbook_compiler_spec.rb +18 -18
  609. data/spec/unit/run_context_spec.rb +39 -68
  610. data/spec/unit/run_list/run_list_expansion_spec.rb +21 -21
  611. data/spec/unit/run_list/run_list_item_spec.rb +28 -28
  612. data/spec/unit/run_list/versioned_recipe_list_spec.rb +14 -14
  613. data/spec/unit/run_list_spec.rb +55 -55
  614. data/spec/unit/run_lock_spec.rb +14 -14
  615. data/spec/unit/run_status_spec.rb +24 -24
  616. data/spec/unit/scan_access_control_spec.rb +23 -23
  617. data/spec/unit/search/query_spec.rb +54 -66
  618. data/spec/unit/shell/model_wrapper_spec.rb +13 -13
  619. data/spec/unit/shell/shell_ext_spec.rb +32 -32
  620. data/spec/unit/shell/shell_session_spec.rb +24 -24
  621. data/spec/unit/shell_out_spec.rb +4 -4
  622. data/spec/unit/shell_spec.rb +27 -27
  623. data/spec/unit/user_spec.rb +50 -50
  624. data/spec/unit/util/backup_spec.rb +32 -32
  625. data/spec/unit/util/diff_spec.rb +31 -31
  626. data/spec/unit/util/dsc/configuration_generator_spec.rb +38 -16
  627. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +21 -26
  628. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +10 -10
  629. data/spec/unit/util/editor_spec.rb +10 -10
  630. data/spec/unit/util/file_edit_spec.rb +10 -10
  631. data/spec/unit/util/path_helper_spec.rb +38 -46
  632. data/spec/unit/util/powershell/cmdlet_spec.rb +9 -9
  633. data/spec/unit/util/selinux_spec.rb +30 -30
  634. data/spec/unit/util/threaded_job_queue_spec.rb +6 -6
  635. data/spec/unit/version/platform_spec.rb +5 -5
  636. data/spec/unit/version_class_spec.rb +15 -15
  637. data/spec/unit/version_constraint/platform_spec.rb +7 -7
  638. data/spec/unit/version_constraint_spec.rb +43 -43
  639. data/spec/unit/windows_service_spec.rb +15 -15
  640. data/spec/unit/workstation_config_loader_spec.rb +2 -2
  641. data/tasks/rspec.rb +16 -18
  642. metadata +126 -49
  643. data/bin/shef +0 -35
  644. data/lib/chef/application/agent.rb +0 -18
  645. data/lib/chef/monkey_patches/fileutils.rb +0 -65
  646. data/lib/chef/monkey_patches/numeric.rb +0 -15
  647. data/lib/chef/monkey_patches/object.rb +0 -9
  648. data/lib/chef/monkey_patches/pathname.rb +0 -32
  649. data/lib/chef/monkey_patches/regexp.rb +0 -34
  650. data/lib/chef/monkey_patches/securerandom.rb +0 -44
  651. data/lib/chef/monkey_patches/string.rb +0 -49
  652. data/lib/chef/monkey_patches/tempfile.rb +0 -64
  653. data/lib/chef/monkey_patches/uri.rb +0 -70
@@ -131,7 +131,7 @@ module ChefHTTPShared
131
131
  }
132
132
 
133
133
  #
134
- # in the presense of a transfer-encoding header, we must ignore the content-length (this bad content-length should work)
134
+ # in the presence of a transfer-encoding header, we must ignore the content-length (this bad content-length should work)
135
135
  #
136
136
 
137
137
  # (expected_content should be uncompressed)
@@ -163,8 +163,8 @@ shared_examples_for "a securable resource with existing target" do
163
163
  let(:desired_gid) { 1337 }
164
164
  let(:expected_gid) { 1337 }
165
165
 
166
- pending "should set an owner (Rerun specs under root)", :requires_unprivileged_user => true
167
- pending "should set a group (Rerun specs under root)", :requires_unprivileged_user => true
166
+ skip "should set an owner (Rerun specs under root)", :requires_unprivileged_user => true
167
+ skip "should set a group (Rerun specs under root)", :requires_unprivileged_user => true
168
168
 
169
169
  describe "when setting the owner", :requires_root do
170
170
  before do
@@ -173,11 +173,11 @@ shared_examples_for "a securable resource with existing target" do
173
173
  end
174
174
 
175
175
  it "should set an owner" do
176
- File.lstat(path).uid.should == expected_uid
176
+ expect(File.lstat(path).uid).to eq(expected_uid)
177
177
  end
178
178
 
179
179
  it "is marked as updated only if changes are made" do
180
- resource.updated_by_last_action?.should == expect_updated?
180
+ expect(resource.updated_by_last_action?).to eq(expect_updated?)
181
181
  end
182
182
 
183
183
  end
@@ -189,11 +189,11 @@ shared_examples_for "a securable resource with existing target" do
189
189
  end
190
190
 
191
191
  it "should set a group" do
192
- File.lstat(path).gid.should == expected_gid
192
+ expect(File.lstat(path).gid).to eq(expected_gid)
193
193
  end
194
194
 
195
195
  it "is marked as updated only if changes are made" do
196
- resource.updated_by_last_action?.should == expect_updated?
196
+ expect(resource.updated_by_last_action?).to eq(expect_updated?)
197
197
  end
198
198
 
199
199
  end
@@ -206,13 +206,12 @@ shared_examples_for "a securable resource with existing target" do
206
206
  end
207
207
 
208
208
  it "should set permissions as specified" do
209
- pending('Linux does not support lchmod', :if => resource.instance_of?(Chef::Resource::Link) && !os_x? && !freebsd?) do
210
- (File.lstat(path).mode & 007777).should == (@mode_string.oct & 007777)
211
- end
209
+ pending("Linux does not support lchmod")
210
+ expect{ File.lstat(path).mode & 007777 }.to eq(@mode_string.oct & 007777)
212
211
  end
213
212
 
214
213
  it "is marked as updated only if changes are made" do
215
- resource.updated_by_last_action?.should == expect_updated?
214
+ expect(resource.updated_by_last_action?).to eq(expect_updated?)
216
215
  end
217
216
  end
218
217
 
@@ -224,13 +223,12 @@ shared_examples_for "a securable resource with existing target" do
224
223
  end
225
224
 
226
225
  it "should set permissions in numeric form as a ruby-interpreted octal" do
227
- pending('Linux does not support lchmod', :if => resource.instance_of?(Chef::Resource::Link) && !os_x? && !freebsd?) do
228
- (File.lstat(path).mode & 007777).should == (@mode_integer & 007777)
229
- end
226
+ pending('Linux does not support lchmod')
227
+ expect{ File.lstat(path).mode & 007777 }.to eq(@mode_integer & 007777)
230
228
  end
231
229
 
232
230
  it "is marked as updated only if changes are made" do
233
- resource.updated_by_last_action?.should == expect_updated?
231
+ expect(resource.updated_by_last_action?).to eq(expect_updated?)
234
232
  end
235
233
  end
236
234
  end
@@ -245,11 +243,11 @@ shared_examples_for "a securable resource with existing target" do
245
243
  end
246
244
 
247
245
  it "should set the owner" do
248
- descriptor.owner.should == SID.Administrator
246
+ expect(descriptor.owner).to eq(SID.Administrator)
249
247
  end
250
248
 
251
249
  it "is marked as updated only if changes are made" do
252
- resource.updated_by_last_action?.should == expect_updated?
250
+ expect(resource.updated_by_last_action?).to eq(expect_updated?)
253
251
  end
254
252
  end
255
253
 
@@ -260,11 +258,11 @@ shared_examples_for "a securable resource with existing target" do
260
258
  end
261
259
 
262
260
  it "should set the group" do
263
- descriptor.group.should == SID.Administrators
261
+ expect(descriptor.group).to eq(SID.Administrators)
264
262
  end
265
263
 
266
264
  it "is marked as updated only if changes are made" do
267
- resource.updated_by_last_action?.should == expect_updated?
265
+ expect(resource.updated_by_last_action?).to eq(expect_updated?)
268
266
  end
269
267
  end
270
268
 
@@ -276,11 +274,11 @@ shared_examples_for "a securable resource with existing target" do
276
274
  end
277
275
 
278
276
  it "should set the rights and deny_rights" do
279
- explicit_aces.should == denied_acl(SID.Guest, expected_modify_perms) + allowed_acl(SID.Guest, expected_read_perms)
277
+ expect(explicit_aces).to eq(denied_acl(SID.Guest, expected_modify_perms) + allowed_acl(SID.Guest, expected_read_perms))
280
278
  end
281
279
 
282
280
  it "is marked as updated only if changes are made" do
283
- resource.updated_by_last_action?.should == expect_updated?
281
+ expect(resource.updated_by_last_action?).to eq(expect_updated?)
284
282
  end
285
283
  end
286
284
  end
@@ -291,81 +289,80 @@ shared_examples_for "a securable resource without existing target" do
291
289
  include_context "diff disabled"
292
290
 
293
291
  context "on Unix", :unix_only do
294
- pending "if we need any securable resource tests on Unix without existing target resource."
292
+ skip "if we need any securable resource tests on Unix without existing target resource."
295
293
  end
296
294
 
297
295
  context "on Windows", :windows_only do
298
296
  include_context "use Windows permissions"
299
297
 
300
298
  it "sets owner to Administrators on create if owner is not specified" do
301
- File.exist?(path).should == false
299
+ expect(File.exist?(path)).to eq(false)
302
300
  resource.run_action(:create)
303
- descriptor.owner.should == SID.Administrators
301
+ expect(descriptor.owner).to eq(SID.Administrators)
304
302
  end
305
303
 
306
304
  it "sets owner when owner is specified" do
307
305
  resource.owner 'Guest'
308
306
  resource.run_action(:create)
309
- descriptor.owner.should == SID.Guest
307
+ expect(descriptor.owner).to eq(SID.Guest)
310
308
  end
311
309
 
312
310
  it "fails to set owner when owner has invalid characters" do
313
- lambda { resource.owner 'Lance "The Nose" Glindenberry III' }.should raise_error#(Chef::Exceptions::ValidationFailed)
311
+ expect { resource.owner 'Lance "The Nose" Glindenberry III' }.to raise_error#(Chef::Exceptions::ValidationFailed)
314
312
  end
315
313
 
316
314
  it "sets owner when owner is specified with a \\" do
317
315
  resource.owner "#{ENV['USERDOMAIN']}\\Guest"
318
316
  resource.run_action(:create)
319
- descriptor.owner.should == SID.Guest
317
+ expect(descriptor.owner).to eq(SID.Guest)
320
318
  end
321
319
 
322
320
  it "leaves owner alone if owner is not specified and resource already exists" do
323
321
  # Set owner to Guest so it's not the same as the current user (which is the default on create)
324
322
  resource.owner 'Guest'
325
323
  resource.run_action(:create)
326
- descriptor.owner.should == SID.Guest
324
+ expect(descriptor.owner).to eq(SID.Guest)
327
325
 
328
326
  new_resource = create_resource
329
- new_resource.owner.should == nil
327
+ expect(new_resource.owner).to eq(nil)
330
328
  new_resource.run_action(:create)
331
- descriptor.owner.should == SID.Guest
329
+ expect(descriptor.owner).to eq(SID.Guest)
332
330
  end
333
331
 
334
332
  it "sets group to None on create if group is not specified" do
335
- resource.group.should == nil
336
- File.exist?(path).should == false
333
+ expect(resource.group).to eq(nil)
334
+ expect(File.exist?(path)).to eq(false)
337
335
  resource.run_action(:create)
338
- descriptor.group.should == SID.None
336
+ expect(descriptor.group).to eq(SID.None)
339
337
  end
340
338
 
341
339
  it "sets group when group is specified" do
342
340
  resource.group 'Everyone'
343
341
  resource.run_action(:create)
344
- descriptor.group.should == SID.Everyone
342
+ expect(descriptor.group).to eq(SID.Everyone)
345
343
  end
346
344
 
347
345
  it "fails to set group when group has invalid characters" do
348
- lambda { resource.group 'Lance "The Nose" Glindenberry III' }.should raise_error(Chef::Exceptions::ValidationFailed)
346
+ expect { resource.group 'Lance "The Nose" Glindenberry III' }.to raise_error(Chef::Exceptions::ValidationFailed)
349
347
  end
350
348
 
351
349
  it "sets group when group is specified with a \\" do
352
- pending "Need to find a group containing a backslash that is on most peoples' machines" do
353
- resource.group "#{ENV['COMPUTERNAME']}\\Administrators"
354
- resource.run_action(:create)
355
- descriptor.group.should == SID.Everyone
356
- end
350
+ pending("Need to find a group containing a backslash that is on most peoples' machines")
351
+ resource.group "#{ENV['COMPUTERNAME']}\\Administrators"
352
+ resource.run_action(:create)
353
+ expect{ descriptor.group }.to eq(SID.Everyone)
357
354
  end
358
355
 
359
356
  it "leaves group alone if group is not specified and resource already exists" do
360
357
  # Set group to Everyone so it's not the default (None)
361
358
  resource.group 'Everyone'
362
359
  resource.run_action(:create)
363
- descriptor.group.should == SID.Everyone
360
+ expect(descriptor.group).to eq(SID.Everyone)
364
361
 
365
362
  new_resource = create_resource
366
- new_resource.group.should == nil
363
+ expect(new_resource.group).to eq(nil)
367
364
  new_resource.run_action(:create)
368
- descriptor.group.should == SID.Everyone
365
+ expect(descriptor.group).to eq(SID.Everyone)
369
366
  end
370
367
 
371
368
  describe "with rights and deny_rights attributes" do
@@ -373,38 +370,38 @@ shared_examples_for "a securable resource without existing target" do
373
370
  it "correctly sets :read rights" do
374
371
  resource.rights(:read, 'Guest')
375
372
  resource.run_action(:create)
376
- explicit_aces.should == allowed_acl(SID.Guest, expected_read_perms)
373
+ expect(explicit_aces).to eq(allowed_acl(SID.Guest, expected_read_perms))
377
374
  end
378
375
 
379
376
  it "correctly sets :read_execute rights" do
380
377
  resource.rights(:read_execute, 'Guest')
381
378
  resource.run_action(:create)
382
- explicit_aces.should == allowed_acl(SID.Guest, expected_read_execute_perms)
379
+ expect(explicit_aces).to eq(allowed_acl(SID.Guest, expected_read_execute_perms))
383
380
  end
384
381
 
385
382
  it "correctly sets :write rights" do
386
383
  resource.rights(:write, 'Guest')
387
384
  resource.run_action(:create)
388
- explicit_aces.should == allowed_acl(SID.Guest, expected_write_perms)
385
+ expect(explicit_aces).to eq(allowed_acl(SID.Guest, expected_write_perms))
389
386
  end
390
387
 
391
388
  it "correctly sets :modify rights" do
392
389
  resource.rights(:modify, 'Guest')
393
390
  resource.run_action(:create)
394
- explicit_aces.should == allowed_acl(SID.Guest, expected_modify_perms)
391
+ expect(explicit_aces).to eq(allowed_acl(SID.Guest, expected_modify_perms))
395
392
  end
396
393
 
397
394
  it "correctly sets :full_control rights" do
398
395
  resource.rights(:full_control, 'Guest')
399
396
  resource.run_action(:create)
400
- explicit_aces.should == allowed_acl(SID.Guest, expected_full_control_perms)
397
+ expect(explicit_aces).to eq(allowed_acl(SID.Guest, expected_full_control_perms))
401
398
  end
402
399
 
403
400
  it "correctly sets deny_rights" do
404
401
  # deny is an ACE with full rights, but is a deny type ace, not an allow type
405
402
  resource.deny_rights(:full_control, 'Guest')
406
403
  resource.run_action(:create)
407
- explicit_aces.should == denied_acl(SID.Guest, expected_full_control_perms)
404
+ expect(explicit_aces).to eq(denied_acl(SID.Guest, expected_full_control_perms))
408
405
  end
409
406
 
410
407
  it "Sets multiple rights" do
@@ -412,9 +409,10 @@ shared_examples_for "a securable resource without existing target" do
412
409
  resource.rights(:modify, 'Guest')
413
410
  resource.run_action(:create)
414
411
 
415
- explicit_aces.should ==
412
+ expect(explicit_aces).to eq(
416
413
  allowed_acl(SID.Everyone, expected_read_perms) +
417
414
  allowed_acl(SID.Guest, expected_modify_perms)
415
+ )
418
416
  end
419
417
 
420
418
  it "Sets deny_rights ahead of rights" do
@@ -422,9 +420,10 @@ shared_examples_for "a securable resource without existing target" do
422
420
  resource.deny_rights(:modify, 'Guest')
423
421
  resource.run_action(:create)
424
422
 
425
- explicit_aces.should ==
423
+ expect(explicit_aces).to eq(
426
424
  denied_acl(SID.Guest, expected_modify_perms) +
427
425
  allowed_acl(SID.Everyone, expected_read_perms)
426
+ )
428
427
  end
429
428
 
430
429
  it "Sets deny_rights ahead of rights when specified in reverse order" do
@@ -432,9 +431,10 @@ shared_examples_for "a securable resource without existing target" do
432
431
  resource.rights(:read, 'Everyone')
433
432
  resource.run_action(:create)
434
433
 
435
- explicit_aces.should ==
434
+ expect(explicit_aces).to eq(
436
435
  denied_acl(SID.Guest, expected_modify_perms) +
437
436
  allowed_acl(SID.Everyone, expected_read_perms)
437
+ )
438
438
  end
439
439
 
440
440
  end
@@ -452,7 +452,7 @@ shared_examples_for "a securable resource without existing target" do
452
452
  resource.group 'Everyone'
453
453
  resource.run_action(:create)
454
454
 
455
- explicit_aces.should == [ ACE.access_allowed(SID.Guest, Security::FILE_GENERIC_READ) ]
455
+ expect(explicit_aces).to eq([ ACE.access_allowed(SID.Guest, Security::FILE_GENERIC_READ) ])
456
456
  end
457
457
 
458
458
  it "respects mode in numeric form as a ruby-interpreted octal" do
@@ -460,7 +460,7 @@ shared_examples_for "a securable resource without existing target" do
460
460
  resource.owner 'Guest'
461
461
  resource.run_action(:create)
462
462
 
463
- explicit_aces.should == [ ACE.access_allowed(SID.Guest, Security::FILE_GENERIC_READ | Security::FILE_GENERIC_WRITE | Security::FILE_GENERIC_EXECUTE | Security::DELETE) ]
463
+ expect(explicit_aces).to eq([ ACE.access_allowed(SID.Guest, Security::FILE_GENERIC_READ | Security::FILE_GENERIC_WRITE | Security::FILE_GENERIC_EXECUTE | Security::DELETE) ])
464
464
  end
465
465
 
466
466
  it "respects the owner, group and everyone bits of mode" do
@@ -469,11 +469,11 @@ shared_examples_for "a securable resource without existing target" do
469
469
  resource.group 'Administrators'
470
470
  resource.run_action(:create)
471
471
 
472
- explicit_aces.should == [
472
+ expect(explicit_aces).to eq([
473
473
  ACE.access_allowed(SID.Guest, Security::FILE_GENERIC_READ | Security::FILE_GENERIC_WRITE | Security::FILE_GENERIC_EXECUTE | Security::DELETE),
474
474
  ACE.access_allowed(SID.Administrators, Security::FILE_GENERIC_READ | Security::FILE_GENERIC_EXECUTE),
475
475
  ACE.access_allowed(SID.Everyone, Security::FILE_GENERIC_READ)
476
- ]
476
+ ])
477
477
  end
478
478
 
479
479
  it "respects the individual read, write and execute bits of mode" do
@@ -482,31 +482,31 @@ shared_examples_for "a securable resource without existing target" do
482
482
  resource.group 'Administrators'
483
483
  resource.run_action(:create)
484
484
 
485
- explicit_aces.should == [
485
+ expect(explicit_aces).to eq([
486
486
  ACE.access_allowed(SID.Guest, Security::FILE_GENERIC_READ),
487
487
  ACE.access_allowed(SID.Administrators, Security::FILE_GENERIC_WRITE | Security::DELETE),
488
488
  ACE.access_allowed(SID.Everyone, Security::FILE_GENERIC_EXECUTE)
489
- ]
489
+ ])
490
490
  end
491
491
 
492
492
  it 'warns when mode tries to set owner bits but owner is not specified' do
493
493
  @warn = []
494
- Chef::Log.stub(:warn) { |msg| @warn << msg }
494
+ allow(Chef::Log).to receive(:warn) { |msg| @warn << msg }
495
495
 
496
496
  resource.mode 0400
497
497
  resource.run_action(:create)
498
498
 
499
- @warn.include?("Mode 400 includes bits for the owner, but owner is not specified").should be_true
499
+ expect(@warn.include?("Mode 400 includes bits for the owner, but owner is not specified")).to be_truthy
500
500
  end
501
501
 
502
502
  it 'warns when mode tries to set group bits but group is not specified' do
503
503
  @warn = []
504
- Chef::Log.stub(:warn) { |msg| @warn << msg }
504
+ allow(Chef::Log).to receive(:warn) { |msg| @warn << msg }
505
505
 
506
506
  resource.mode 0040
507
507
  resource.run_action(:create)
508
508
 
509
- @warn.include?("Mode 040 includes bits for the group, but group is not specified").should be_true
509
+ expect(@warn.include?("Mode 040 includes bits for the group, but group is not specified")).to be_truthy
510
510
  end
511
511
  end
512
512
 
@@ -518,12 +518,12 @@ shared_examples_for "a securable resource without existing target" do
518
518
  resource.run_action(:create)
519
519
 
520
520
  descriptor.dacl.each do | ace |
521
- ace.inherited?.should == false
521
+ expect(ace.inherited?).to eq(false)
522
522
  end
523
523
  end
524
524
 
525
525
  it "has the inheritable acls of parent directory if no acl is specified" do
526
- File.exist?(path).should == false
526
+ expect(File.exist?(path)).to eq(false)
527
527
 
528
528
  # Collect the inheritable acls form the parent by creating a file without
529
529
  # any specific ACLs
@@ -542,7 +542,7 @@ shared_examples_for "a securable resource without existing target" do
542
542
  ace.inherited?
543
543
  end
544
544
 
545
- resource_inherited_acls.should == parent_inherited_acls
545
+ expect(resource_inherited_acls).to eq(parent_inherited_acls)
546
546
  end
547
547
 
548
548
  end
@@ -56,18 +56,18 @@ shared_examples_for "a securable resource with reporting" do
56
56
  end
57
57
 
58
58
  it "has empty values for file metadata in 'current_resource'" do
59
- current_resource.owner.should be_nil
60
- current_resource.group.should be_nil
61
- current_resource.mode.should be_nil
59
+ expect(current_resource.owner).to be_nil
60
+ expect(current_resource.group).to be_nil
61
+ expect(current_resource.mode).to be_nil
62
62
  end
63
63
 
64
64
  context "and no security metadata is specified in new_resource" do
65
65
  it "sets the metadata values on the new_resource as strings after creating" do
66
66
  resource.run_action(:create)
67
67
  # TODO: most stable way to specify?
68
- resource.owner.should == Etc.getpwuid(Process.uid).name
69
- resource.group.should == @expected_group_name
70
- resource.mode.should == "0#{default_mode}"
68
+ expect(resource.owner).to eq(Etc.getpwuid(Process.uid).name)
69
+ expect(resource.group).to eq(@expected_group_name)
70
+ expect(resource.mode).to eq("0#{default_mode}")
71
71
  end
72
72
  end
73
73
 
@@ -87,7 +87,7 @@ shared_examples_for "a securable resource with reporting" do
87
87
  end
88
88
 
89
89
  it "sets the owner on new_resource to the username (String) of the desired owner" do
90
- resource.owner.should == expected_user_name
90
+ expect(resource.owner).to eq(expected_user_name)
91
91
  end
92
92
 
93
93
  end
@@ -110,7 +110,7 @@ shared_examples_for "a securable resource with reporting" do
110
110
  end
111
111
 
112
112
  it "sets the owner on new_resource to the uid (Integer) of the desired owner" do
113
- resource.owner.should == expected_uid
113
+ expect(resource.owner).to eq(expected_uid)
114
114
  end
115
115
  end
116
116
 
@@ -124,7 +124,7 @@ shared_examples_for "a securable resource with reporting" do
124
124
  end
125
125
 
126
126
  it "sets the group on new_resource to the group name (String) of the group" do
127
- resource.group.should == expected_group_name
127
+ expect(resource.group).to eq(expected_group_name)
128
128
  end
129
129
 
130
130
  end
@@ -138,7 +138,7 @@ shared_examples_for "a securable resource with reporting" do
138
138
  end
139
139
 
140
140
  it "sets the group on new_resource to the gid (Integer)" do
141
- resource.group.should == expected_gid
141
+ expect(resource.group).to eq(expected_gid)
142
142
  end
143
143
 
144
144
  end
@@ -155,7 +155,7 @@ shared_examples_for "a securable resource with reporting" do
155
155
  end
156
156
 
157
157
  it "sets mode on the new_resource as a String" do
158
- resource.mode.should == expected_mode
158
+ expect(resource.mode).to eq(expected_mode)
159
159
  end
160
160
  end
161
161
 
@@ -169,7 +169,7 @@ shared_examples_for "a securable resource with reporting" do
169
169
  end
170
170
 
171
171
  it "sets mode on the new resource as a String" do
172
- resource.mode.should == expected_mode
172
+ expect(resource.mode).to eq(expected_mode)
173
173
  end
174
174
  end
175
175
  end
@@ -183,9 +183,9 @@ shared_examples_for "a securable resource with reporting" do
183
183
  context "and no security metadata is specified in new_resource" do
184
184
  it "sets the current values on current resource as strings" do
185
185
  # TODO: most stable way to specify?
186
- current_resource.owner.should == Etc.getpwuid(Process.uid).name
187
- current_resource.group.should == @expected_group_name
188
- current_resource.mode.should == "0#{((0100666 - File.umask) & 07777).to_s(8)}"
186
+ expect(current_resource.owner).to eq(Etc.getpwuid(Process.uid).name)
187
+ expect(current_resource.group).to eq(@expected_group_name)
188
+ expect(current_resource.mode).to eq("0#{((0100666 - File.umask) & 07777).to_s(8)}")
189
189
  end
190
190
  end
191
191
 
@@ -198,7 +198,7 @@ shared_examples_for "a securable resource with reporting" do
198
198
  end
199
199
 
200
200
  it "sets the owner on new_resource to the username (String) of the desired owner" do
201
- current_resource.owner.should == expected_user_name
201
+ expect(current_resource.owner).to eq(expected_user_name)
202
202
  end
203
203
 
204
204
  end
@@ -212,7 +212,7 @@ shared_examples_for "a securable resource with reporting" do
212
212
  end
213
213
 
214
214
  it "sets the owner on new_resource to the uid (Integer) of the desired owner" do
215
- current_resource.owner.should == expected_uid
215
+ expect(current_resource.owner).to eq(expected_uid)
216
216
  end
217
217
  end
218
218
 
@@ -222,7 +222,7 @@ shared_examples_for "a securable resource with reporting" do
222
222
  end
223
223
 
224
224
  it "sets the group on new_resource to the group name (String) of the group" do
225
- current_resource.group.should == @expected_group_name
225
+ expect(current_resource.group).to eq(@expected_group_name)
226
226
  end
227
227
 
228
228
  end
@@ -233,7 +233,7 @@ shared_examples_for "a securable resource with reporting" do
233
233
  end
234
234
 
235
235
  it "sets the group on new_resource to the gid (Integer)" do
236
- current_resource.group.should == @expected_gid
236
+ expect(current_resource.group).to eq(@expected_gid)
237
237
  end
238
238
 
239
239
  end
@@ -247,7 +247,7 @@ shared_examples_for "a securable resource with reporting" do
247
247
  end
248
248
 
249
249
  it "sets mode on the new_resource as a String" do
250
- current_resource.mode.should == expected_mode
250
+ expect(current_resource.mode).to eq(expected_mode)
251
251
  end
252
252
  end
253
253
 
@@ -260,7 +260,7 @@ shared_examples_for "a securable resource with reporting" do
260
260
  end
261
261
 
262
262
  it "sets mode on the new resource as a String" do
263
- current_resource.mode.should == expected_mode
263
+ expect(current_resource.mode).to eq(expected_mode)
264
264
  end
265
265
  end
266
266
  end
@@ -268,11 +268,6 @@ shared_examples_for "a securable resource with reporting" do
268
268
 
269
269
  describe "reading file security metadata for reporting on windows", :windows_only do
270
270
 
271
- before do
272
- pending "windows reporting not yet fully supported"
273
- end
274
-
275
-
276
271
  context "when the target file doesn't exist" do
277
272
 
278
273
  # Windows reporting data should look like this (+/- ish):
@@ -284,23 +279,28 @@ shared_examples_for "a securable resource with reporting" do
284
279
  end
285
280
 
286
281
  it "has empty values for file metadata in 'current_resource'" do
287
- current_resource.owner.should be_nil
288
- current_resource.expanded_rights.should be_nil
282
+ pending "windows reporting not yet fully supported"
283
+ expect(current_resource.owner).to be_nil
284
+ expect(current_resource.expanded_rights).to be_nil
289
285
  end
290
286
 
291
287
  context "and no security metadata is specified in new_resource" do
288
+ before do
289
+ pending "windows reporting not yet fully supported"
290
+ end
291
+
292
292
  it "sets the metadata values on the new_resource as strings after creating" do
293
293
  resource.run_action(:create)
294
294
  # TODO: most stable way to specify?
295
- resource.owner.should == etc.getpwuid(process.uid).name
296
- resource.state[:expanded_rights].should == { "CURRENTUSER" => { "permissions" => ALL_EXPANDED_PERMISSIONS, "flags" => [] }}
297
- resource.state[:expanded_deny_rights].should == {}
298
- resource.state[:inherits].should be_true
295
+ expect(resource.owner).to eq(etc.getpwuid(process.uid).name)
296
+ expect(resource.state[:expanded_rights]).to eq({ "CURRENTUSER" => { "permissions" => ALL_EXPANDED_PERMISSIONS, "flags" => [] }})
297
+ expect(resource.state[:expanded_deny_rights]).to eq({})
298
+ expect(resource.state[:inherits]).to be_truthy
299
299
  end
300
300
  end
301
301
 
302
302
 
303
- context "and owner is specified with a string (username) in new_resource" do
303
+ context "and owner is specified with a string (username) in new_resource" do
304
304
 
305
305
  # TODO/bug: duplicated from the "securable resource" tests
306
306
  let(:expected_user_name) { 'Guest' }
@@ -311,7 +311,7 @@ shared_examples_for "a securable resource with reporting" do
311
311
  end
312
312
 
313
313
  it "sets the owner on new_resource to the username (string) of the desired owner" do
314
- resource.owner.should == expected_user_name
314
+ expect(resource.owner).to eq(expected_user_name)
315
315
  end
316
316
 
317
317
  end
@@ -322,12 +322,13 @@ shared_examples_for "a securable resource with reporting" do
322
322
  let(:expected_user_name) { 'domain\user' }
323
323
 
324
324
  before do
325
+ pending "windows reporting not yet fully supported"
325
326
  resource.owner(expected_user_name)
326
327
  resource.run_action(:create)
327
328
  end
328
329
 
329
330
  it "sets the owner on new_resource to the fully qualified name of the desired owner" do
330
- resource.owner.should == expected_user_name
331
+ expect(resource.owner).to eq(expected_user_name)
331
332
  end
332
333
  end
333
334
 
@@ -335,6 +336,7 @@ shared_examples_for "a securable resource with reporting" do
335
336
 
336
337
  context "when the target file exists" do
337
338
  before do
339
+ pending "windows reporting not yet fully supported"
338
340
  FileUtils.touch(resource.path)
339
341
  resource.action(:create)
340
342
  end
@@ -342,8 +344,8 @@ shared_examples_for "a securable resource with reporting" do
342
344
  context "and no security metadata is specified in new_resource" do
343
345
  it "sets the current values on current resource as strings" do
344
346
  # TODO: most stable way to specify?
345
- current_resource.owner.should == etc.getpwuid(process.uid).name
346
- current_resource.expanded_rights.should == { "CURRENTUSER" => ALL_EXPANDED_PERMISSIONS }
347
+ expect(current_resource.owner).to eq(etc.getpwuid(process.uid).name)
348
+ expect(current_resource.expanded_rights).to eq({ "CURRENTUSER" => ALL_EXPANDED_PERMISSIONS })
347
349
  end
348
350
  end
349
351
 
@@ -356,7 +358,7 @@ shared_examples_for "a securable resource with reporting" do
356
358
  end
357
359
 
358
360
  it "sets the owner on current_resource to the username (string) of the desired owner" do
359
- current_resource.owner.should == expected_user_name
361
+ expect(current_resource.owner).to eq(expected_user_name)
360
362
  end
361
363
 
362
364
  end
@@ -370,7 +372,7 @@ shared_examples_for "a securable resource with reporting" do
370
372
  end
371
373
 
372
374
  it "sets the owner on current_resource to the fully qualified name of the desired owner" do
373
- current_resource.owner.should == expected_uid
375
+ expect(current_resource.owner).to eq(expected_uid)
374
376
  end
375
377
  end
376
378
 
@@ -378,7 +380,7 @@ shared_examples_for "a securable resource with reporting" do
378
380
  # TODO: before do blah
379
381
 
380
382
  it "sets the expanded_rights on the current resource" do
381
- pending
383
+ skip
382
384
  end
383
385
  end
384
386
 
@@ -386,7 +388,7 @@ shared_examples_for "a securable resource with reporting" do
386
388
  # TODO: before do blah
387
389
 
388
390
  it "sets the expanded rights on the current resource" do
389
- pending
391
+ skip
390
392
  end
391
393
  end
392
394