braintree 3.3.0 → 3.4.0

data/spec/integration/braintree/dispute_search_spec.rb

@@ -18,16 +18,16 @@ describe Braintree::Dispute, "search" do
 
   let(:transaction) do
     result = Braintree::Transaction.sale(
-      :amount => '10.00',
+      :amount => "10.00",
       :credit_card => {
-        :expiration_date => '01/2020',
+        :expiration_date => "01/2020",
         :number => Braintree::Test::CreditCardNumbers::Disputes::Chargeback,
       },
       :customer_id => customer.id,
       :merchant_account_id => "14LaddersLLC_instant",
       :options => {
         :submit_for_settlement => true,
-      }
+      },
     )
 
     result.transaction

data/spec/integration/braintree/dispute_spec.rb

@@ -11,14 +11,14 @@ describe Braintree::Dispute do
 
   let(:transaction) do
     result = Braintree::Transaction.sale(
-      :amount => '10.00',
+      :amount => "10.00",
       :credit_card => {
-        :expiration_date => '01/2020',
+        :expiration_date => "01/2020",
         :number => Braintree::Test::CreditCardNumbers::Disputes::Chargeback
       },
       :options => {
         :submit_for_settlement => true
-      }
+      },
     )
 
     result.transaction
@@ -50,7 +50,7 @@ describe Braintree::Dispute do
     it "raises a NotFound exception if the dispute cannot be found" do
       expect do
         Braintree::Dispute.accept("invalid-id")
-      end.to raise_error(Braintree::NotFoundError, 'dispute with id invalid-id not found')
+      end.to raise_error(Braintree::NotFoundError, "dispute with id invalid-id not found")
     end
   end
 
@@ -141,7 +141,7 @@ describe Braintree::Dispute do
     end
 
     it "creates text evidence for the dispute with optional parameters" do
-      result = Braintree::Dispute.add_text_evidence(dispute.id, { content: "123456789", category: "REFUND_ID", sequence_number: 7 })
+      result = Braintree::Dispute.add_text_evidence(dispute.id, {content: "123456789", category: "REFUND_ID", sequence_number: 7})
 
       result.success?.should == true
       result.evidence.category.should == "REFUND_ID"
@@ -174,7 +174,7 @@ describe Braintree::Dispute do
     it "raises a NotFound exception if the dispute cannot be found" do
       expect do
         Braintree::Dispute.finalize("invalid-id")
-      end.to raise_error(Braintree::NotFoundError, 'dispute with id invalid-id not found')
+      end.to raise_error(Braintree::NotFoundError, "dispute with id invalid-id not found")
     end
   end
 

data/spec/integration/braintree/error_codes_spec.rb

@@ -6,7 +6,7 @@ describe Braintree::ErrorCodes do
       result = Braintree::Customer.create(
         :credit_card => {
           :cardholder_name => "x" * 256
-        }
+        },
       )
       result.success?.should == false
       result.errors.for(:customer).for(:credit_card).map { |e| e.code }.should \

data/spec/integration/braintree/http_spec.rb

@@ -54,7 +54,7 @@ describe Braintree::Http do
             :customer_id => customer.id,
             :cardholder_name => "Sam Jones",
             :number => Braintree::Test::CreditCardNumbers::Visa,
-            :expiration_date => "05/2009"
+            :expiration_date => "05/2009",
           )
           result.success?.should == true
           utc_or_gmt = Time.now.utc.strftime("%Z")
@@ -156,7 +156,7 @@ describe Braintree::Http do
           # Random CA root file from a different certificate authority
           config = Braintree::Configuration.instantiate
           config.stub(:ca_file).and_return(
-            File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "ssl", "geotrust_global.crt"))
+            File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "ssl", "geotrust_global.crt")),
           )
           config.stub(:ssl?).and_return(true)
           config.stub(:port).and_return(SSL_TEST_PORT)

data/spec/integration/braintree/merchant_account_spec.rb

@@ -65,7 +65,7 @@ describe Braintree::MerchantAccount do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       code = Braintree::OAuthTestHelper.create_grant(gateway, {
@@ -75,12 +75,12 @@ describe Braintree::MerchantAccount do
 
       result = gateway.oauth.create_token_from_code(
         :code => code,
-        :scope => "read_write"
+        :scope => "read_write",
       )
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.all
@@ -92,18 +92,18 @@ describe Braintree::MerchantAccount do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant.create(
         :email => "name@email.com",
         :country_code_alpha3 => "USA",
-        :payment_methods => ["credit_card", "paypal"]
+        :payment_methods => ["credit_card", "paypal"],
       )
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.all
@@ -118,7 +118,7 @@ describe Braintree::MerchantAccount do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       code = Braintree::OAuthTestHelper.create_grant(gateway, {
@@ -128,12 +128,12 @@ describe Braintree::MerchantAccount do
 
       result = gateway.oauth.create_token_from_code(
         :code => code,
-        :scope => "read_only"
+        :scope => "read_only",
       )
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.all
@@ -164,8 +164,8 @@ describe Braintree::MerchantAccount do
       sub_merchant_account_id = "sub_merchant_account_id#{random_number}"
       result = Braintree::MerchantAccount.create(
         VALID_APPLICATION_PARAMS.merge(
-          :id => sub_merchant_account_id
-        )
+          :id => sub_merchant_account_id,
+        ),
       )
 
       result.should be_success
@@ -182,7 +182,7 @@ describe Braintree::MerchantAccount do
 
     it "requires all fields" do
       result = Braintree::MerchantAccount.create(
-        :master_merchant_account_id => "sandbox_master_merchant_account"
+        :master_merchant_account_id => "sandbox_master_merchant_account",
       )
       result.should_not be_success
       result.errors.for(:merchant_account).on(:tos_accepted).first.code.should == Braintree::ErrorCodes::MerchantAccount::TosAcceptedIsRequired
@@ -233,11 +233,11 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "JPY"
+        :currency => "JPY",
       )
       result.should be_success
       result.merchant_account.currency_iso_code.should == "JPY"
@@ -249,16 +249,16 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "USD"
+        :currency => "USD",
       )
       result.should be_success
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "USD"
+        :currency => "USD",
       )
       result.should_not be_success
 
@@ -272,11 +272,11 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => nil
+        :currency => nil,
       )
       result.should_not be_success
 
@@ -296,11 +296,11 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "FAKE_CURRENCY"
+        :currency => "FAKE_CURRENCY",
       )
       result.should_not be_success
 
@@ -314,13 +314,13 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       merchant = result.merchant
       result = gateway.merchant_account.create_for_currency(
         :currency => "USD",
-        :id => merchant.merchant_accounts.first.id
+        :id => merchant.merchant_accounts.first.id,
       )
       result.should_not be_success
 
@@ -338,7 +338,6 @@ describe Braintree::MerchantAccount do
       id = result.merchant_account.id
       merchant_account = Braintree::MerchantAccount.find(id)
 
-      merchant_account.status.should == Braintree::MerchantAccount::Status::Active
       merchant_account.individual_details.first_name.should == VALID_APPLICATION_PARAMS[:individual][:first_name]
       merchant_account.individual_details.last_name.should == VALID_APPLICATION_PARAMS[:individual][:last_name]
     end
@@ -352,7 +351,7 @@ describe Braintree::MerchantAccount do
     it "raises a NotFoundError exception if merchant account cannot be found" do
       expect do
         Braintree::MerchantAccount.find("non-existant")
-      end.to raise_error(Braintree::NotFoundError, 'Merchant account with id non-existant not found')
+      end.to raise_error(Braintree::NotFoundError, "Merchant account with id non-existant not found")
     end
   end
 
@@ -412,7 +411,7 @@ describe Braintree::MerchantAccount do
     end
 
     it "does not require all fields" do
-      result = Braintree::MerchantAccount.update("sandbox_sub_merchant_account", { :individual => { :first_name => "Jose" } })
+      result = Braintree::MerchantAccount.update("sandbox_sub_merchant_account", {:individual => {:first_name => "Jose"}})
       result.should be_success
     end
 

data/spec/integration/braintree/merchant_spec.rb

@@ -6,13 +6,13 @@ describe Braintree::MerchantGateway do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant.create(
         :email => "name@email.com",
         :country_code_alpha3 => "USA",
-        :payment_methods => ["credit_card", "paypal"]
+        :payment_methods => ["credit_card", "paypal"],
       )
 
       result.should be_success
@@ -37,13 +37,13 @@ describe Braintree::MerchantGateway do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant.create(
         :email => "name@email.com",
         :country_code_alpha3 => "USA",
-        :payment_methods => ["fake_money"]
+        :payment_methods => ["fake_money"],
       )
 
       result.should_not be_success
@@ -71,7 +71,7 @@ describe Braintree::MerchantGateway do
         result = gateway.merchant.create(
           :email => "name@email.com",
           :country_code_alpha3 => "USA",
-          :payment_methods => ["credit_card", "paypal"]
+          :payment_methods => ["credit_card", "paypal"],
         )
 
         result.should be_success
@@ -83,7 +83,7 @@ describe Braintree::MerchantGateway do
         @gateway = Braintree::Gateway.new(
           :client_id => "client_id$development$signup_client_id",
           :client_secret => "client_secret$development$signup_client_secret",
-          :logger => Logger.new("/dev/null")
+          :logger => Logger.new("/dev/null"),
         )
       end
 
@@ -92,7 +92,7 @@ describe Braintree::MerchantGateway do
           :email => "name@email.com",
           :country_code_alpha3 => "USA",
           :payment_methods => ["credit_card", "paypal"],
-          :currencies => ["GBP", "USD"]
+          :currencies => ["GBP", "USD"],
         )
 
         merchant = result.merchant
@@ -127,7 +127,7 @@ describe Braintree::MerchantGateway do
           :email => "name@email.com",
           :country_code_alpha3 => "GBR",
           :payment_methods => ["credit_card", "paypal"],
-          :currencies => ["GBP", "USD"]
+          :currencies => ["GBP", "USD"],
         )
 
         merchant = result.merchant
@@ -167,7 +167,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should be_success
@@ -207,7 +207,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should be_success
@@ -243,7 +243,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should be_success
@@ -280,7 +280,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should_not be_success

data/spec/integration/braintree/oauth_spec.rb

@@ -5,7 +5,7 @@ describe "OAuth" do
     @gateway = Braintree::Gateway.new(
       :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
       :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-      :logger => Logger.new("/dev/null")
+      :logger => Logger.new("/dev/null"),
     )
   end
 
@@ -18,7 +18,7 @@ describe "OAuth" do
 
       result = @gateway.oauth.create_token_from_code(
         :code => code,
-        :scope => "read_write"
+        :scope => "read_write",
       )
 
       result.should be_success
@@ -32,7 +32,7 @@ describe "OAuth" do
     it "returns validation errors for bad params" do
       result = @gateway.oauth.create_token_from_code(
         :code => "bad_code",
-        :scope => "read_write"
+        :scope => "read_write",
       )
 
       result.should_not be_success
@@ -43,13 +43,13 @@ describe "OAuth" do
     it "raises with a helpful error if client_id and client_secret are not set" do
       gateway = Braintree::Gateway.new(
         :access_token => "access_token$development$integration_merchant_id$fb27c79dd",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       expect do
         gateway.oauth.create_token_from_code(
           :code => "some code",
-          :scope => "read_write"
+          :scope => "read_write",
         )
       end.to raise_error(Braintree::ConfigurationError, /client_id and client_secret are required/);
     end
@@ -63,12 +63,12 @@ describe "OAuth" do
       })
       refresh_token = @gateway.oauth.create_token_from_code(
         :code => code,
-        :scope => "read_write"
+        :scope => "read_write",
       ).credentials.refresh_token
 
       result = @gateway.oauth.create_token_from_refresh_token(
         :refresh_token => refresh_token,
-        :scope => "read_write"
+        :scope => "read_write",
       )
 
       result.should be_success
@@ -88,7 +88,7 @@ describe "OAuth" do
       })
       access_token = @gateway.oauth.create_token_from_code(
         :code => code,
-        :scope => "read_write"
+        :scope => "read_write",
       ).credentials.access_token
 
       result = @gateway.oauth.revoke_access_token(access_token)
@@ -96,7 +96,7 @@ describe "OAuth" do
 
       gateway = Braintree::Gateway.new(
         :access_token => access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       expect do
@@ -146,7 +146,7 @@ describe "OAuth" do
           :currency => "USD",
           :website => "http://example.com"
         },
-        :payment_methods => ["credit_card", "paypal"]
+        :payment_methods => ["credit_card", "paypal"],
       )
 
       uri = URI.parse(url)
@@ -201,7 +201,7 @@ describe "OAuth" do
         :redirect_uri => "http://bar.example.com",
         :scope => "read_write",
         :state => "baz_state",
-        :payment_methods => ["credit_card", "paypal"]
+        :payment_methods => ["credit_card", "paypal"],
       )
 
       uri = URI.parse(url)