braintree 3.3.0 → 3.4.0

data/spec/spec_helper.rb

@@ -40,6 +40,7 @@ unless defined?(SPEC_HELPER_LOADED)
     AdyenMerchantAccountId = "adyen_ma"
     HiperBRLMerchantAccountId = "hiper_brl"
     CardProcessorBRLMerchantAccountId = "card_processor_brl"
+    FakeFirstDataMerchantAccountId = "fake_first_data_merchant_account"
 
     TrialPlan = {
       :description => "Plan for integration tests -- with trial",
@@ -88,13 +89,13 @@ unless defined?(SPEC_HELPER_LOADED)
                                                       :environment => Braintree::Configuration.environment,
                                                       :merchant_id => "test_merchant_id",
                                                       :public_key => "test_public_key",
-                                                      :private_key => "test_private_key"
+                                                      :private_key => "test_private_key",
                                                       )
 
     def self.make_past_due(subscription, number_of_days_past_due = 1)
       config = Braintree::Configuration.instantiate
       config.http.put(
-        "#{config.base_merchant_path}/subscriptions/#{subscription.id}/make_past_due?days_past_due=#{number_of_days_past_due}"
+        "#{config.base_merchant_path}/subscriptions/#{subscription.id}/make_past_due?days_past_due=#{number_of_days_past_due}",
       )
     end
 
@@ -113,7 +114,7 @@ unless defined?(SPEC_HELPER_LOADED)
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       gateway.merchant.create({

data/spec/unit/braintree/address_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Address do
   describe "==" do
     it "returns true if given an address with the same id and customer_id" do
-      first = Braintree::Address._new(:gateway, :customer_id => "c1", :id => 'a1')
+      first = Braintree::Address._new(:gateway, :customer_id => "c1", :id => "a1")
       second = Braintree::Address._new(:gateway, :customer_id => "c1", :id => "a1")
 
       first.should == second

data/spec/unit/braintree/apple_pay_card_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::ApplePayCard do
   describe "bin" do
     it "returns Apple pay card bin" do
-      Braintree::ApplePayCard._new(:gateway, bin: '411111').bin.should == '411111'
+      Braintree::ApplePayCard._new(:gateway, bin: "411111").bin.should == "411111"
     end
   end
 

data/spec/unit/braintree/client_token_spec.rb

@@ -16,7 +16,7 @@ module Braintree
         expect {
           client_token = Braintree::ClientToken.generate(
             :public_key => "bad_key",
-            :created_at => "bad_time"
+            :created_at => "bad_time",
           )
         }.to raise_error(ArgumentError, /created_at, public_key/)
       end
@@ -27,7 +27,7 @@ module Braintree
         it "raises an ArgumentError if #{option_name} is present" do
           expect do
             Braintree::ClientToken.generate(
-              option_name.to_sym => true
+              option_name.to_sym => true,
             )
           end.to raise_error(ArgumentError, /#{option_name}/)
         end

data/spec/unit/braintree/configuration_spec.rb

@@ -1,4 +1,4 @@
-require 'stringio'
+require "stringio"
 
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
@@ -22,26 +22,26 @@ describe Braintree::Configuration do
   describe "initialize" do
     it "accepts merchant credentials" do
       config = Braintree::Configuration.new(
-        :merchant_id => 'merchant_id',
-        :public_key => 'public_key',
-        :private_key => 'private_key'
+        :merchant_id => "merchant_id",
+        :public_key => "public_key",
+        :private_key => "private_key",
       )
 
-      config.merchant_id.should == 'merchant_id'
-      config.public_key.should == 'public_key'
-      config.private_key.should == 'private_key'
+      config.merchant_id.should == "merchant_id"
+      config.public_key.should == "public_key"
+      config.private_key.should == "private_key"
     end
 
     it "accepts partner credentials" do
       config = Braintree::Configuration.new(
-        :partner_id => 'partner_id',
-        :public_key => 'public_key',
-        :private_key => 'private_key'
+        :partner_id => "partner_id",
+        :public_key => "public_key",
+        :private_key => "private_key",
       )
 
-      config.merchant_id.should == 'partner_id'
-      config.public_key.should == 'public_key'
-      config.private_key.should == 'private_key'
+      config.merchant_id.should == "partner_id"
+      config.public_key.should == "public_key"
+      config.private_key.should == "private_key"
     end
 
     it "raises if combining client_id/secret with access_token" do
@@ -49,7 +49,7 @@ describe Braintree::Configuration do
         Braintree::Configuration.new(
           :client_id => "client_id$development$integration_client_id",
           :client_secret => "client_secret$development$integration_client_secret",
-          :access_token => "access_token$development$integration_merchant_id$fb27c79dd"
+          :access_token => "access_token$development$integration_merchant_id$fb27c79dd",
         )
       end.to raise_error(Braintree::ConfigurationError, /mixed credential types/)
     end
@@ -62,7 +62,7 @@ describe Braintree::Configuration do
           :merchant_id => "merchant_id",
           :public_key => "public_key",
           :private_key => "private_key",
-          :environment => "development"
+          :environment => "development",
         )
       end.to raise_error(Braintree::ConfigurationError, /mixed credential types/)
     end
@@ -96,21 +96,21 @@ describe Braintree::Configuration do
 
     it "accepts proxy params" do
       config = Braintree::Configuration.new(
-        :proxy_address => 'localhost',
+        :proxy_address => "localhost",
         :proxy_port => 8080,
-        :proxy_user => 'user',
-        :proxy_pass => 'test'
+        :proxy_user => "user",
+        :proxy_pass => "test",
       )
 
-      config.proxy_address.should == 'localhost'
+      config.proxy_address.should == "localhost"
       config.proxy_port.should == 8080
-      config.proxy_user.should == 'user'
-      config.proxy_pass.should == 'test'
+      config.proxy_user.should == "user"
+      config.proxy_pass.should == "test"
     end
 
     it "accepts ssl version" do
       config = Braintree::Configuration.new(
-        :ssl_version => :TLSv1_2
+        :ssl_version => :TLSv1_2,
       )
 
       config.ssl_version.should == :TLSv1_2
@@ -146,14 +146,14 @@ describe Braintree::Configuration do
       Braintree::Configuration.environment = :sandbox
       ca_file = Braintree::Configuration.instantiate.ca_file
       ca_file.should match(/api_braintreegateway_com\.ca\.crt$/)
-      File.exists?(ca_file).should == true
+      File.exist?(ca_file).should == true
     end
 
     it "production" do
       Braintree::Configuration.environment = :production
       ca_file = Braintree::Configuration.instantiate.ca_file
       ca_file.should match(/api_braintreegateway_com\.ca\.crt$/)
-      File.exists?(ca_file).should == true
+      File.exist?(ca_file).should == true
     end
   end
 
@@ -238,12 +238,12 @@ describe Braintree::Configuration do
 
     it "allows the environment to be set with a string value" do
       expect do
-        Braintree::Configuration.environment = 'sandbox'
+        Braintree::Configuration.environment = "sandbox"
       end.not_to raise_error
     end
 
     it "sets the environment as a symbol" do
-      Braintree::Configuration.environment = 'sandbox'
+      Braintree::Configuration.environment = "sandbox"
       expect(Braintree::Configuration.environment).to eq :sandbox
     end
   end
@@ -326,15 +326,15 @@ describe Braintree::Configuration do
 
     it "is 3000 or GATEWAY_PORT environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_port = ENV['GATEWAY_PORT']
+      old_gateway_port = ENV["GATEWAY_PORT"]
       begin
-        ENV['GATEWAY_PORT'] = nil
+        ENV["GATEWAY_PORT"] = nil
         Braintree::Configuration.instantiate.port.should == 3000
 
-        ENV['GATEWAY_PORT'] = '1234'
-        Braintree::Configuration.instantiate.port.should == '1234'
+        ENV["GATEWAY_PORT"] = "1234"
+        Braintree::Configuration.instantiate.port.should == "1234"
       ensure
-        ENV['GATEWAY_PORT'] = old_gateway_port
+        ENV["GATEWAY_PORT"] = old_gateway_port
       end
     end
   end
@@ -359,15 +359,15 @@ describe Braintree::Configuration do
   describe "graphql_server" do
     it "is localhost or GRAPHQL_HOST environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_url = ENV['GRAPHQL_HOST']
+      old_gateway_url = ENV["GRAPHQL_HOST"]
       begin
-        ENV['GRAPHQL_HOST'] = nil
+        ENV["GRAPHQL_HOST"] = nil
         Braintree::Configuration.instantiate.graphql_server.should == "graphql.bt.local"
 
-        ENV['GRAPHQL_HOST'] = 'gateway'
-        Braintree::Configuration.instantiate.graphql_server.should == 'gateway'
+        ENV["GRAPHQL_HOST"] = "gateway"
+        Braintree::Configuration.instantiate.graphql_server.should == "gateway"
       ensure
-        ENV['GRAPHQL_HOST'] = old_gateway_url
+        ENV["GRAPHQL_HOST"] = old_gateway_url
       end
     end
   end
@@ -375,15 +375,15 @@ describe Braintree::Configuration do
   describe "server" do
     it "is localhost or GATEWAY_HOST environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_url = ENV['GATEWAY_HOST']
+      old_gateway_url = ENV["GATEWAY_HOST"]
       begin
-        ENV['GATEWAY_HOST'] = nil
+        ENV["GATEWAY_HOST"] = nil
         Braintree::Configuration.instantiate.server.should == "localhost"
 
-        ENV['GATEWAY_HOST'] = 'gateway'
-        Braintree::Configuration.instantiate.server.should == 'gateway'
+        ENV["GATEWAY_HOST"] = "gateway"
+        Braintree::Configuration.instantiate.server.should == "gateway"
       ensure
-        ENV['GATEWAY_HOST'] = old_gateway_url
+        ENV["GATEWAY_HOST"] = old_gateway_url
       end
     end
 
@@ -468,7 +468,7 @@ describe Braintree::Configuration do
     it "masks the private_key" do
       config = Braintree::Configuration.new(:private_key => "secret_key")
       config.inspect.should include('@private_key="[FILTERED]"')
-      config.inspect.should_not include('secret_key')
+      config.inspect.should_not include("secret_key")
     end
   end
 

data/spec/unit/braintree/credit_card_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::CreditCard do
   describe "self.create" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::CreditCard.create(:invalid_key => 'val')
+        Braintree::CreditCard.create(:invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
@@ -203,7 +203,7 @@ describe Braintree::CreditCard do
       credit_card = Braintree::CreditCard._new(
         :gateway,
         :bin => "510510",
-        :last_4 => "5100"
+        :last_4 => "5100",
       )
       credit_card.masked_number.should == "510510******5100"
     end
@@ -215,7 +215,7 @@ describe Braintree::CreditCard do
         :gateway,
         :bin => "510510",
         :last_4 => "5100",
-        :is_network_tokenized => true
+        :is_network_tokenized => true,
       )
       credit_card.is_network_tokenized?.should == true
     end
@@ -225,7 +225,7 @@ describe Braintree::CreditCard do
         :gateway,
         :bin => "510510",
         :last_4 => "5100",
-        :is_network_tokenized => false
+        :is_network_tokenized => false,
       )
       credit_card.is_network_tokenized?.should == false
     end
@@ -234,7 +234,7 @@ describe Braintree::CreditCard do
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::CreditCard.update(:gateway, :invalid_key => 'val')
+        Braintree::CreditCard.update(:gateway, :invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
@@ -250,8 +250,8 @@ describe Braintree::CreditCard do
   describe "self._new" do
     describe "initializing verification" do
       it "picks the youngest verification" do
-        verification1 = { :created_at => Time.now, :id => 123 }
-        verification2 = { :created_at => Time.now - 3600, :id => 456 }
+        verification1 = {:created_at => Time.now, :id => 123}
+        verification2 = {:created_at => Time.now - 3600, :id => 456}
         credit_card = Braintree::CreditCard._new(Braintree::Configuration.gateway, {:verifications => [verification1, verification2]})
         credit_card.verification.id.should == 123
       end

data/spec/unit/braintree/credit_card_verification_search_spec.rb

@@ -9,7 +9,7 @@ module Braintree
 
         lambda do
           search.credit_card_card_type.in(
-            *Braintree::CreditCard::CardType::All
+            *Braintree::CreditCard::CardType::All,
           )
         end.should_not raise_error
       end

data/spec/unit/braintree/credit_card_verification_spec.rb

@@ -30,7 +30,7 @@ describe Braintree::CreditCardVerification do
         :cvv_response_code => "I",
         :processor_response_code => "2000",
         :processor_response_text => "Do Not Honor",
-        :merchant_account_id => "some_id"
+        :merchant_account_id => "some_id",
       )
 
       verification.status.should == Braintree::CreditCardVerification::Status::Verified
@@ -44,7 +44,7 @@ describe Braintree::CreditCardVerification do
 
   it "accepts network_transaction_id" do
     verification = Braintree::CreditCardVerification._new(
-      :network_transaction_id => "123456789012345"
+      :network_transaction_id => "123456789012345",
     )
     expect(verification.network_transaction_id).to eq "123456789012345"
   end

data/spec/unit/braintree/customer_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Customer do
   describe "inspect" do
     it "includes the id first" do
-      output = Braintree::Customer._new(:gateway, {:first_name => 'Dan', :id => '1234'}).inspect
+      output = Braintree::Customer._new(:gateway, {:first_name => "Dan", :id => "1234"}).inspect
       output.should include("#<Braintree::Customer id: \"1234\",")
     end
 
@@ -18,7 +18,7 @@ describe Braintree::Customer do
         :phone => "802-483-5932",
         :website => "patrick.smith.com",
         :created_at => Time.now,
-        :updated_at => Time.now
+        :updated_at => Time.now,
       )
       output = customer.inspect
       output.should include(%q(company: "Company"))
@@ -290,7 +290,7 @@ describe Braintree::Customer do
         :paypal_accounts => [
           {:token => "paypal_1"},
           {:token => "paypal_2"}
-        ]
+        ],
       )
 
       customer.credit_cards.size.should == 2

data/spec/unit/braintree/disbursement_spec.rb

@@ -28,18 +28,18 @@ describe Braintree::Disbursement do
         :exception_message => "invalid_account_number",
         :follow_up_action => "update",
         :retry => false,
-        :success => false
+        :success => false,
       )
 
       disbursement.inspect.should include('id: "123456"')
       disbursement.inspect.should include('amount: "100.0"')
       disbursement.inspect.should include('exception_message: "invalid_account_number"')
-      disbursement.inspect.should include('disbursement_date: 2013-04-10')
+      disbursement.inspect.should include("disbursement_date: 2013-04-10")
       disbursement.inspect.should include('follow_up_action: "update"')
-      disbursement.inspect.should include('merchant_account: #<Braintree::MerchantAccount: ')
+      disbursement.inspect.should include("merchant_account: #<Braintree::MerchantAccount: ")
       disbursement.inspect.should include('transaction_ids: ["sub_merchant_transaction"]')
-      disbursement.inspect.should include('retry: false')
-      disbursement.inspect.should include('success: false')
+      disbursement.inspect.should include("retry: false")
+      disbursement.inspect.should include("success: false")
     end
   end
 
@@ -56,7 +56,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => false,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == false
 
@@ -71,7 +71,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => true,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == true
     end

data/spec/unit/braintree/dispute_spec.rb

@@ -137,13 +137,13 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: "GENERAL", document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: "GENERAL", document_id: "document_id"})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
@@ -151,7 +151,7 @@ describe Braintree::Dispute do
         Braintree::Http.stub(:new).and_return double.as_null_object
 
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: 3, document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: 3, document_id: "document_id"})
         end.to raise_error(ArgumentError)
       end
     end
@@ -200,31 +200,31 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { content: "a", category: "", sequence_number: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {content: "a", category: "", sequence_number: 3})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if sequence_number is provided and not an integer" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { sequence_number: "abc" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {sequence_number: "abc"})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param tag is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { tag: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {tag: 3})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param category is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { category: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {category: 3})
         end.to raise_error(ArgumentError)
       end
     end