braintree 3.3.0 → 3.4.0

data/spec/integration/braintree/advanced_search_spec.rb

@@ -6,7 +6,7 @@ describe Braintree::AdvancedSearch do
       :credit_card => {
         :number => Braintree::Test::CreditCardNumbers::Visa,
         :expiration_date => "05/2010"
-      }
+      },
     ).credit_cards[0]
   end
 
@@ -16,13 +16,13 @@ describe Braintree::AdvancedSearch do
       subscription1 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription1_#{id}"
+        :id => "subscription1_#{id}",
       ).subscription
 
       subscription2 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription2_#{id}"
+        :id => "subscription2_#{id}",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -39,14 +39,14 @@ describe Braintree::AdvancedSearch do
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
         :price => "11",
-        :id => "subscription1_#{id}"
+        :id => "subscription1_#{id}",
       ).subscription
 
       subscription2 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
         :price => "11",
-        :id => "subscription2_#{id}"
+        :id => "subscription2_#{id}",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -63,13 +63,13 @@ describe Braintree::AdvancedSearch do
       subscription1 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription1_#{id}"
+        :id => "subscription1_#{id}",
       ).subscription
 
       subscription2 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription2_#{id}"
+        :id => "subscription2_#{id}",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -85,13 +85,13 @@ describe Braintree::AdvancedSearch do
       subscription1 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription1_#{id}"
+        :id => "subscription1_#{id}",
       ).subscription
 
       subscription2 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription2_#{id}"
+        :id => "subscription2_#{id}",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -107,13 +107,13 @@ describe Braintree::AdvancedSearch do
       subscription1 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription1_#{id}"
+        :id => "subscription1_#{id}",
       ).subscription
 
       subscription2 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :id => "subscription2_#{id}"
+        :id => "subscription2_#{id}",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -131,13 +131,13 @@ describe Braintree::AdvancedSearch do
         subscription1 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "12"
+          :price => "12",
         ).subscription
 
         subscription2 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "12"
+          :price => "12",
         ).subscription
 
         Braintree::Subscription.cancel(subscription2.id)
@@ -155,13 +155,13 @@ describe Braintree::AdvancedSearch do
         subscription1 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "13"
+          :price => "13",
         ).subscription
 
         subscription2 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "13"
+          :price => "13",
         ).subscription
 
         Braintree::Subscription.cancel(subscription2.id)
@@ -179,13 +179,13 @@ describe Braintree::AdvancedSearch do
         subscription1 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "14"
+          :price => "14",
         ).subscription
 
         subscription2 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "14"
+          :price => "14",
         ).subscription
 
         Braintree::Subscription.cancel(subscription2.id)
@@ -204,13 +204,13 @@ describe Braintree::AdvancedSearch do
           subscription1 = Braintree::Subscription.create(
             :payment_method_token => @credit_card.token,
             :plan_id => SpecHelper::TriallessPlan[:id],
-            :price => "15"
+            :price => "15",
           ).subscription
 
           subscription2 = Braintree::Subscription.create(
             :payment_method_token => @credit_card.token,
             :plan_id => SpecHelper::TriallessPlan[:id],
-            :price => "15"
+            :price => "15",
           ).subscription
 
           Braintree::Subscription.cancel(subscription2.id)
@@ -229,13 +229,13 @@ describe Braintree::AdvancedSearch do
         subscription1 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "16"
+          :price => "16",
         ).subscription
 
         subscription2 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "16"
+          :price => "16",
         ).subscription
 
         Braintree::Subscription.cancel(subscription2.id)
@@ -266,19 +266,19 @@ describe Braintree::AdvancedSearch do
         subscription1 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "17"
+          :price => "17",
         ).subscription
 
         subscription2 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
-          :price => "17"
+          :price => "17",
         ).subscription
 
         subscription3 = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::AddOnDiscountPlan[:id],
-          :price => "17"
+          :price => "17",
         ).subscription
 
         plan_ids = [SpecHelper::TriallessPlan[:id], SpecHelper::TrialPlan[:id]]
@@ -307,13 +307,13 @@ describe Braintree::AdvancedSearch do
         trialless_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "18"
+          :price => "18",
         ).subscription
 
         trial_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
-          :price => "18"
+          :price => "18",
         ).subscription
 
         collection = Braintree::Subscription.search do |search|
@@ -331,13 +331,13 @@ describe Braintree::AdvancedSearch do
         trialless_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "19"
+          :price => "19",
         ).subscription
 
         trial_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
-          :price => "19"
+          :price => "19",
         ).subscription
 
         collection = Braintree::Subscription.search do |search|
@@ -355,13 +355,13 @@ describe Braintree::AdvancedSearch do
         trialless_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "20"
+          :price => "20",
         ).subscription
 
         trial_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
-          :price => "20"
+          :price => "20",
         ).subscription
 
         collection = Braintree::Subscription.search do |search|
@@ -379,13 +379,13 @@ describe Braintree::AdvancedSearch do
         trialless_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "21"
+          :price => "21",
         ).subscription
 
         trial_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
-          :price => "21"
+          :price => "21",
         ).subscription
 
         collection = Braintree::Subscription.search do |search|
@@ -403,13 +403,13 @@ describe Braintree::AdvancedSearch do
         trialless_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
-          :price => "22"
+          :price => "22",
         ).subscription
 
         trial_subscription = Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
-          :price => "22"
+          :price => "22",
         ).subscription
 
         collection = Braintree::Subscription.search do |search|
@@ -428,13 +428,13 @@ describe Braintree::AdvancedSearch do
       subscription_500 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :price => "5.00"
+        :price => "5.00",
       ).subscription
 
       subscription_501 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TrialPlan[:id],
-        :price => "5.01"
+        :price => "5.01",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -449,19 +449,19 @@ describe Braintree::AdvancedSearch do
       subscription_499 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TrialPlan[:id],
-        :price => "4.99"
+        :price => "4.99",
       ).subscription
 
       subscription_500 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :price => "5.00"
+        :price => "5.00",
       ).subscription
 
       subscription_501 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TrialPlan[:id],
-        :price => "5.01"
+        :price => "5.01",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -477,19 +477,19 @@ describe Braintree::AdvancedSearch do
       subscription_499 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TrialPlan[:id],
-        :price => "999.99"
+        :price => "999.99",
       ).subscription
 
       subscription_500 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :price => "1000.00"
+        :price => "1000.00",
       ).subscription
 
       subscription_501 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TrialPlan[:id],
-        :price => "1000.01"
+        :price => "1000.01",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|
@@ -505,19 +505,19 @@ describe Braintree::AdvancedSearch do
       subscription_499 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TrialPlan[:id],
-        :price => "4.99"
+        :price => "4.99",
       ).subscription
 
       subscription_500 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TriallessPlan[:id],
-        :price => "5.00"
+        :price => "5.00",
       ).subscription
 
       subscription_502 = Braintree::Subscription.create(
         :payment_method_token => @credit_card.token,
         :plan_id => SpecHelper::TrialPlan[:id],
-        :price => "5.02"
+        :price => "5.02",
       ).subscription
 
       collection = Braintree::Subscription.search do |search|

data/spec/integration/braintree/apple_pay_spec.rb

@@ -5,18 +5,18 @@ describe Braintree::ApplePayGateway do
     gateway = Braintree::Gateway.new(
       :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
       :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-      :logger => Logger.new("/dev/null")
+      :logger => Logger.new("/dev/null"),
     )
 
     result = gateway.merchant.create(
       :email => "name@email.com",
       :country_code_alpha3 => "USA",
-      :payment_methods => ["credit_card", "paypal"]
+      :payment_methods => ["credit_card", "paypal"],
     )
 
     @gateway = Braintree::Gateway.new(
       :access_token => result.credentials.access_token,
-      :logger => Logger.new("/dev/null")
+      :logger => Logger.new("/dev/null"),
     )
   end
 

data/spec/integration/braintree/braintree_gateway_spec.rb

@@ -12,7 +12,8 @@ describe Braintree::Gateway do
   end
 
   describe "query" do
-    it "makes valid GraphQL queries when given a definition" do
+    # we are temporarily skipping this test until we have a more stable CI env
+    xit "makes valid GraphQL queries when given a definition" do
       definition = <<-GRAPHQL
       mutation ExampleServerSideSingleUseToken($input: TokenizeCreditCardInput!) {
         tokenizeCreditCard(input: $input) {

data/spec/integration/braintree/client_api/client_token_spec.rb

@@ -12,7 +12,7 @@ describe Braintree::ClientToken do
         config,
         :authorization_fingerprint => client_token["authorizationFingerprint"],
         :shared_customer_identifier => "fake_identifier",
-        :shared_customer_identifier_type => "testing"
+        :shared_customer_identifier_type => "testing",
       )
 
       response = http.get_payment_methods
@@ -49,7 +49,7 @@ describe Braintree::ClientToken do
         :customer_id => result.customer.id,
         :options => {
           :verify_card => true
-        }
+        },
       )
       client_token = decode_client_token(raw_client_token)
 
@@ -57,7 +57,7 @@ describe Braintree::ClientToken do
         config,
         :authorization_fingerprint => client_token["authorizationFingerprint"],
         :shared_customer_identifier => "fake_identifier",
-        :shared_customer_identifier_type => "testing"
+        :shared_customer_identifier_type => "testing",
       )
 
       response = http.add_payment_method(
@@ -65,7 +65,7 @@ describe Braintree::ClientToken do
           :number => "4000111111111115",
           :expiration_month => "11",
           :expiration_year => "2099"
-        }
+        },
       )
 
       response.code.should == "422"
@@ -79,7 +79,7 @@ describe Braintree::ClientToken do
         :customer_id => customer_id,
         :options => {
           :make_default => true
-        }
+        },
       )
       client_token = decode_client_token(raw_client_token)
 
@@ -87,7 +87,7 @@ describe Braintree::ClientToken do
         config,
         :authorization_fingerprint => client_token["authorizationFingerprint"],
         :shared_customer_identifier => "fake_identifier",
-        :shared_customer_identifier_type => "testing"
+        :shared_customer_identifier_type => "testing",
       )
 
       response = http.add_payment_method(
@@ -95,7 +95,7 @@ describe Braintree::ClientToken do
           :number => "4111111111111111",
           :expiration_month => "11",
           :expiration_year => "2099"
-        }
+        },
       )
 
       response.code.should == "201"
@@ -105,7 +105,7 @@ describe Braintree::ClientToken do
           :number => "4005519200000004",
           :expiration_month => "11",
           :expiration_year => "2099"
-        }
+        },
       )
 
       response.code.should == "201"
@@ -119,7 +119,7 @@ describe Braintree::ClientToken do
       result = Braintree::Customer.create
       customer_id = result.customer.id
       raw_client_token = Braintree::ClientToken.generate(
-        :customer_id => customer_id
+        :customer_id => customer_id,
       )
       client_token = decode_client_token(raw_client_token)
 
@@ -127,7 +127,7 @@ describe Braintree::ClientToken do
         config,
         :authorization_fingerprint => client_token["authorizationFingerprint"],
         :shared_customer_identifier => "fake_identifier",
-        :shared_customer_identifier_type => "testing"
+        :shared_customer_identifier_type => "testing",
       )
 
       response = http.add_payment_method(
@@ -135,7 +135,7 @@ describe Braintree::ClientToken do
           :number => "4111111111111111",
           :expiration_month => "11",
           :expiration_year => "2099"
-        }
+        },
       )
 
       response.code.should == "201"
@@ -144,7 +144,7 @@ describe Braintree::ClientToken do
         :customer_id => customer_id,
         :options => {
           :fail_on_duplicate_payment_method => true
-        }
+        },
       )
       second_client_token = decode_client_token(second_raw_client_token)
 
@@ -155,7 +155,7 @@ describe Braintree::ClientToken do
           :number => "4111111111111111",
           :expiration_month => "11",
           :expiration_year => "2099"
-        }
+        },
       )
 
       response.code.should == "422"
@@ -165,7 +165,7 @@ describe Braintree::ClientToken do
       merchant_account_id = SpecHelper::NonDefaultMerchantAccountId
 
       raw_client_token = Braintree::ClientToken.generate(
-        :merchant_account_id => merchant_account_id
+        :merchant_account_id => merchant_account_id,
       )
       client_token = decode_client_token(raw_client_token)