braintree 3.3.0 → 3.4.0

data/spec/integration/braintree/test/transaction_amounts_spec.rb

@@ -8,7 +8,7 @@ describe Braintree::Test::TransactionAmounts do
         :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "12/2012"
-        }
+        },
       )
       transaction.status.should == Braintree::Transaction::Status::Authorized
     end
@@ -21,7 +21,7 @@ describe Braintree::Test::TransactionAmounts do
         :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "12/2012"
-        }
+        },
       )
       result.transaction.status.should == Braintree::Transaction::Status::ProcessorDeclined
     end

data/spec/integration/braintree/test_transaction_spec.rb

@@ -9,7 +9,7 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
         :submit_for_settlement => true
-      }
+      },
       )
       sale_result.success?.should == true
       sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
@@ -25,7 +25,7 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
           :submit_for_settlement => true
-        }
+        },
       )
       sale_result.success?.should == true
       sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
@@ -41,7 +41,7 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
           :submit_for_settlement => true
-        }
+        },
       )
       sale_result.success?.should == true
       sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
@@ -57,7 +57,7 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
           :submit_for_settlement => true
-        }
+        },
       )
       sale_result.success?.should == true
       sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
@@ -70,7 +70,7 @@ describe Braintree::TestTransaction do
     it "returns a validation error when invalid transition is specified" do
       sale_result = Braintree::Transaction.sale(
         :amount => "100",
-        :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa
+        :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
       )
       sale_result.success?.should == true
 
@@ -97,10 +97,10 @@ describe Braintree::TestTransaction do
         in_prod do
           config = Braintree::Configuration.new(
             :environment => (original_env == :production ? :development : original_env),
-            :merchant_id => 'integration_merchant_id',
-            :public_key => 'integration_public_key',
-            :private_key => 'integration_private_key',
-            :logger => Logger.new(StringIO.new)
+            :merchant_id => "integration_merchant_id",
+            :public_key => "integration_public_key",
+            :private_key => "integration_private_key",
+            :logger => Logger.new(StringIO.new),
           )
 
           gateway = Braintree::Gateway.new(config)
@@ -110,7 +110,7 @@ describe Braintree::TestTransaction do
 
           sale_result = transaction_gateway.sale(
             :amount => "100",
-            :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa
+            :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
           )
           testing_gateway.settle(sale_result.transaction.id)
         end

data/spec/integration/braintree/transaction_search_spec.rb

@@ -60,7 +60,7 @@ describe Braintree::Transaction, "search" do
           :postal_code => "54321",
           :region => "MA",
           :street_address => "456 Road"
-        }
+        },
       )
 
       SpecHelper.settle_transaction transaction.id
@@ -133,20 +133,20 @@ describe Braintree::Transaction, "search" do
     it "searches on users" do
       transaction = Braintree::Transaction.sale!(
         :amount => Braintree::Test::TransactionAmounts::Authorize,
-        :payment_method_nonce => Braintree::Test::Nonce::PayPalFuturePayment
+        :payment_method_nonce => Braintree::Test::Nonce::PayPalFuturePayment,
       )
 
       collection = Braintree::Transaction.search do |search|
         search.user.is "integration_user_public_id"
       end
 
-      collection.any?{ |t| t.id == transaction.id }.should == true
+      collection.any? { |t| t.id == transaction.id }.should == true
     end
 
     it "searches on paypal transactions" do
       transaction = Braintree::Transaction.sale!(
         :amount => Braintree::Test::TransactionAmounts::Authorize,
-        :payment_method_nonce => Braintree::Test::Nonce::PayPalFuturePayment
+        :payment_method_nonce => Braintree::Test::Nonce::PayPalFuturePayment,
       )
 
       paypal_details = transaction.paypal_details
@@ -161,6 +161,19 @@ describe Braintree::Transaction, "search" do
       collection.first.id.should == transaction.id
     end
 
+    it "searches on store_id" do
+      transaction_id = "contact_visa_transaction"
+      store_id = "store-id"
+
+      collection = Braintree::Transaction.search do |search|
+        search.id.is transaction_id
+        search.store_ids.in store_id
+      end
+
+      collection.maximum_size.should == 1
+      collection.first.id.should == transaction_id
+    end
+
     context "multiple value fields" do
       it "searches on created_using" do
         transaction = Braintree::Transaction.sale!(
@@ -168,7 +181,7 @@ describe Braintree::Transaction, "search" do
           :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "05/12"
-        }
+        },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -199,7 +212,7 @@ describe Braintree::Transaction, "search" do
           :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "05/12"
-        }
+        },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -230,7 +243,7 @@ describe Braintree::Transaction, "search" do
           :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "05/12"
-        }
+        },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -261,7 +274,7 @@ describe Braintree::Transaction, "search" do
           :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "05/12"
-        }
+        },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -301,7 +314,7 @@ describe Braintree::Transaction, "search" do
             :number => Braintree::Test::CreditCardNumbers::Elo,
             :cvv => "737",
             :expiration_date => "10/2020"
-          }
+          },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -318,7 +331,7 @@ describe Braintree::Transaction, "search" do
           :credit_card => {
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/12"
-          }
+          },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -333,7 +346,7 @@ describe Braintree::Transaction, "search" do
       it "searches by payment instrument type PayPal" do
         transaction = Braintree::Transaction.sale!(
           :amount => Braintree::Test::TransactionAmounts::Authorize,
-          :payment_method_nonce => Braintree::Test::Nonce::PayPalFuturePayment
+          :payment_method_nonce => Braintree::Test::Nonce::PayPalFuturePayment,
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -348,7 +361,7 @@ describe Braintree::Transaction, "search" do
       it "searches by payment instrument type LocalPaymentDetail" do
         transaction = Braintree::Transaction.sale!(
           :amount => Braintree::Test::TransactionAmounts::Authorize,
-          :payment_method_nonce => Braintree::Test::Nonce::LocalPayment
+          :payment_method_nonce => Braintree::Test::Nonce::LocalPayment,
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -363,7 +376,7 @@ describe Braintree::Transaction, "search" do
       it "searches by payment instrument type ApplePay" do
         transaction = Braintree::Transaction.sale!(
           :amount => Braintree::Test::TransactionAmounts::Authorize,
-          :payment_method_nonce => Braintree::Test::Nonce::ApplePayVisa
+          :payment_method_nonce => Braintree::Test::Nonce::ApplePayVisa,
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -381,7 +394,7 @@ describe Braintree::Transaction, "search" do
           :credit_card => {
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/12"
-          }
+          },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -421,7 +434,7 @@ describe Braintree::Transaction, "search" do
           :credit_card => {
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/12"
-          }
+          },
         )
 
         collection = Braintree::Transaction.search do |search|
@@ -454,7 +467,7 @@ describe Braintree::Transaction, "search" do
           :cardholder_name => cardholder_name,
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "05/12"
-        }
+        },
         )
 
         transaction = Braintree::Transaction.sale!(
@@ -464,7 +477,7 @@ describe Braintree::Transaction, "search" do
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "05/12"
         },
-        :options => { :submit_for_settlement => true }
+        :options => {:submit_for_settlement => true},
         )
         SpecHelper.settle_transaction transaction.id
 
@@ -495,6 +508,19 @@ describe Braintree::Transaction, "search" do
         collection.maximum_size.should == 1
         collection.first.id.should == credit_transaction.id
       end
+
+      it "searches on store_ids" do
+        transaction_id = "contact_visa_transaction"
+        store_ids = ["store-id"]
+
+        collection = Braintree::Transaction.search do |search|
+          search.id.is transaction_id
+          search.store_ids.in store_ids
+        end
+
+        collection.maximum_size.should == 1
+        collection.first.id.should == transaction_id
+      end
     end
 
     context "invalid search" do
@@ -516,7 +542,7 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/12"
-          }
+          },
           )
 
           collection = Braintree::Transaction.search do |search|
@@ -557,7 +583,7 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/12"
-          }
+          },
           )
 
           collection = Braintree::Transaction.search do |search|
@@ -576,7 +602,7 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
               :number => Braintree::Test::CreditCardNumbers::Visa,
               :expiration_date => "05/12"
-            }
+            },
           )
 
           created_at = transaction.created_at
@@ -586,7 +612,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.created_at.between(
               created_at - 60,
-              created_at + 60
+              created_at + 60,
             )
           end
 
@@ -613,7 +639,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.created_at.between(
               created_at - 300,
-              created_at - 100
+              created_at - 100,
             )
           end
 
@@ -634,7 +660,7 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/12"
-          }
+          },
           )
 
           now = Time.now
@@ -643,7 +669,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.created_at.between(
               now - 60,
-              now + 60
+              now + 60,
             )
           end
 
@@ -670,7 +696,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.created_at.between(
               now - 300,
-              now - 100
+              now - 100,
             )
           end
 
@@ -683,14 +709,14 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
               :number => Braintree::Test::CreditCardNumbers::Visa,
               :expiration_date => "05/12"
-            }
+            },
           )
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction.id
             search.created_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -708,7 +734,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction_id
             search.disbursement_date.between(
               disbursement_time - 60,
-              disbursement_time + 60
+              disbursement_time + 60,
             )
           end
 
@@ -735,7 +761,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction_id
             search.disbursement_date.between(
               disbursement_time - 300,
-              disbursement_time - 100
+              disbursement_time - 100,
             )
           end
 
@@ -758,7 +784,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction_id
             search.disbursement_date.between(
               now - 60,
-              now + 60
+              now + 60,
             )
           end
 
@@ -785,7 +811,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction_id
             search.disbursement_date.between(
               now - 300,
-              now - 100
+              now - 100,
             )
           end
 
@@ -800,7 +826,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction_id
             search.disbursement_date.between(
               disbursement_date - 1,
-              disbursement_date + 1
+              disbursement_date + 1,
             )
           end
 
@@ -816,7 +842,7 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
               :number => Braintree::Test::CreditCardNumbers::Disputes::Chargeback,
               :expiration_date => "03/18"
-            }
+            },
           )
 
           @disputed_date = @disputed_transaction.disputes.first.received_date
@@ -841,7 +867,7 @@ describe Braintree::Transaction, "search" do
             search.id.is @disputed_transaction.id
             search.dispute_date.between(
               @disputed_time - 60,
-              @disputed_time + 60
+              @disputed_time + 60,
             )
           end
 
@@ -880,7 +906,7 @@ describe Braintree::Transaction, "search" do
             search.id.is @disputed_transaction.id
             search.dispute_date.between(
               now - 60,
-              now + 60
+              now + 60,
             )
           end
 
@@ -908,7 +934,7 @@ describe Braintree::Transaction, "search" do
             search.id.is @disputed_transaction.id
             search.dispute_date.between(
               @disputed_date - 1,
-              @disputed_date + 1
+              @disputed_date + 1,
             )
           end
 
@@ -924,14 +950,14 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
               :number => Braintree::Test::CreditCardNumbers::Visa,
               :expiration_date => "05/12"
-            }
+            },
           )
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction.id
             search.authorized_at.between(
               Date.today - 2,
-              Date.today - 1
+              Date.today - 1,
             )
           end
 
@@ -941,7 +967,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.authorized_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -955,14 +981,14 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
               :number => Braintree::Test::CreditCardNumbers::Visa,
               :expiration_date => "05/12"
-            }
+            },
           ).transaction
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction.id
             search.failed_at.between(
               Date.today - 2,
-              Date.today - 1
+              Date.today - 1,
             )
           end
 
@@ -972,7 +998,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.failed_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -984,7 +1010,7 @@ describe Braintree::Transaction, "search" do
           collection = Braintree::Transaction.search do |search|
             search.authorization_expired_at.between(
               Date.today - 2,
-              Date.today - 1
+              Date.today - 1,
             )
           end
 
@@ -993,7 +1019,7 @@ describe Braintree::Transaction, "search" do
           collection = Braintree::Transaction.search do |search|
             search.authorization_expired_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -1017,14 +1043,14 @@ describe Braintree::Transaction, "search" do
                 :number => Braintree::Test::CreditCardNumbers::Visa,
                 :expiration_date => "05/12",
                 :cvv => "200"
-              }
+              },
             ).transaction
 
             collection = Braintree::Transaction.search do |search|
               search.id.is transaction.id
               search.gateway_rejected_at.between(
                 Date.today - 2,
-                Date.today - 1
+                Date.today - 1,
               )
             end
 
@@ -1034,7 +1060,7 @@ describe Braintree::Transaction, "search" do
               search.id.is transaction.id
               search.gateway_rejected_at.between(
                 Date.today - 1,
-                Date.today + 1
+                Date.today + 1,
               )
             end
 
@@ -1053,14 +1079,14 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
               :number => Braintree::Test::CreditCardNumbers::Visa,
               :expiration_date => "05/12"
-            }
+            },
           ).transaction
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction.id
             search.processor_declined_at.between(
               Date.today - 2,
-              Date.today - 1
+              Date.today - 1,
             )
           end
 
@@ -1070,7 +1096,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.processor_declined_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -1087,7 +1113,7 @@ describe Braintree::Transaction, "search" do
             },
             :options => {
               :submit_for_settlement => true
-            }
+            },
           ).transaction
 
           SpecHelper.settle_transaction transaction.id
@@ -1096,7 +1122,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.settled_at.between(
               Date.today - 2,
-              Date.today - 1
+              Date.today - 1,
             )
           end
 
@@ -1106,7 +1132,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.settled_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -1123,14 +1149,14 @@ describe Braintree::Transaction, "search" do
             },
             :options => {
               :submit_for_settlement => true
-            }
+            },
           ).transaction
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction.id
             search.submitted_for_settlement_at.between(
               Date.today - 2,
-              Date.today - 1
+              Date.today - 1,
             )
           end
 
@@ -1140,7 +1166,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.submitted_for_settlement_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -1154,7 +1180,7 @@ describe Braintree::Transaction, "search" do
             :credit_card => {
               :number => Braintree::Test::CreditCardNumbers::Visa,
               :expiration_date => "05/12"
-            }
+            },
           )
           transaction = Braintree::Transaction.void(transaction.id).transaction
 
@@ -1162,7 +1188,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.voided_at.between(
               Date.today - 2,
-              Date.today - 1
+              Date.today - 1,
             )
           end
 
@@ -1172,7 +1198,7 @@ describe Braintree::Transaction, "search" do
             search.id.is transaction.id
             search.voided_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -1190,18 +1216,18 @@ describe Braintree::Transaction, "search" do
             },
             :options => {
               :submit_for_settlement => true
-            }
+            },
           )
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction.id
             search.authorized_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
             search.submitted_for_settlement_at.between(
               Date.today - 1,
-              Date.today + 1
+              Date.today + 1,
             )
           end
 
@@ -1213,7 +1239,7 @@ describe Braintree::Transaction, "search" do
       collection = Braintree::Transaction.search
       collection.maximum_size.should > 100
 
-      transaction_ids = collection.map {|t| t.id }.uniq.compact
+      transaction_ids = collection.map { |t| t.id }.uniq.compact
       transaction_ids.size.should == collection.maximum_size
     end
 
@@ -1225,7 +1251,7 @@ describe Braintree::Transaction, "search" do
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/2012",
             :cardholder_name => "Tom Smith"
-          }
+          },
         )
       end
 
@@ -1319,7 +1345,7 @@ describe Braintree::Transaction, "search" do
       it "raises a UnexpectedError" do
         expect {
           collection = Braintree::Transaction.search do |search|
-            search.amount.is -10
+            search.amount.is(-10)
           end
         }.to raise_error(Braintree::UnexpectedError)
       end
@@ -1336,7 +1362,7 @@ describe Braintree::Transaction, "search" do
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/2012",
             :cardholder_name => "#{cardholder_name} #{index}"
-          }
+          },
         )
       end
 
@@ -1353,7 +1379,7 @@ describe Braintree::Transaction, "search" do
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/2012",
             :cardholder_name => new_cardholder_name,
-          }
+          },
         )
 
       transactions = collection.to_a