braintree 3.3.0 → 3.4.0

data/spec/unit/braintree/error_result_spec.rb

@@ -10,7 +10,7 @@ describe Braintree::ErrorResult do
           :params => "params",
           :errors => {:errors => []},
           :extra => "is ignored",
-          :message => "foo bar"
+          :message => "foo bar",
         )
       end.to_not raise_error
     end
@@ -36,7 +36,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => {},
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should include("credit_card_verification: #<Braintree::CreditCardVerification status: ")
     end
@@ -47,7 +47,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("credit_card_verification")
     end
@@ -58,7 +58,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => {}
+        :transaction => {},
       )
       result.inspect.should include("transaction: #<Braintree::Transaction id: ")
     end
@@ -69,7 +69,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("transaction")
     end

data/spec/unit/braintree/errors_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::Errors do
   describe "for" do
     it "accesses errors for the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:level1).size.should == 1
       errors.for(:level1)[0].code.should == "code1"
@@ -12,7 +12,7 @@ describe Braintree::Errors do
 
     it "returns nil if there are no errors at the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:no_errors_here).should == nil
     end
@@ -21,7 +21,7 @@ describe Braintree::Errors do
   describe "inspect" do
     it "is better than the default inspect" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message]>"
     end
@@ -33,7 +33,7 @@ describe Braintree::Errors do
           :level2 => {
             :errors => [{:code => "code2", :attribute => "attr2", :message => "message2"}],
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2]>"
     end
@@ -48,7 +48,7 @@ describe Braintree::Errors do
               :errors => [{:code => "code3", :attribute => "attr3", :message => "message3"}],
             }
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2], level1/level2/level3:[(code3) message3]>"
     end
@@ -65,7 +65,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.map { |e| e.code }.sort.should == %w[1 2 3]
     end
@@ -74,7 +74,7 @@ describe Braintree::Errors do
   describe "size" do
     it "returns the number of validation errors at the first level if only has one level" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]},
       )
       errors.size.should == 1
     end
@@ -89,7 +89,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.size.should == 3
     end

data/spec/unit/braintree/http_spec.rb

@@ -67,7 +67,7 @@ END
         :proxy_address => "localhost",
         :proxy_port => 8080,
         :proxy_user => "user",
-        :proxy_pass => "test"
+        :proxy_pass => "test",
       )
 
       http = Braintree::Http.new(config)
@@ -75,7 +75,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, "user", "test").and_return(net_http_instance)
@@ -86,7 +86,7 @@ END
     it "accepts a partially specified proxy" do
       config = Braintree::Configuration.new(
         :proxy_address => "localhost",
-        :proxy_port => 8080
+        :proxy_port => 8080,
       )
 
       http = Braintree::Http.new(config)
@@ -94,7 +94,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, nil, nil).and_return(net_http_instance)
@@ -109,7 +109,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil).and_return(net_http_instance)

data/spec/unit/braintree/merchant_account_spec.rb

@@ -13,7 +13,7 @@ describe Braintree::MerchantAccount do
         nil,
         :id => "merchant_account",
         :status => "active",
-        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil}
+        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil},
       )
 
       master_merchant_account = "#<Braintree::MerchantAccount: id: \"master_merchant_account\", status: \"active\", master_merchant_account: nil>"

data/spec/unit/braintree/payment_method_spec.rb

@@ -28,7 +28,7 @@ describe Braintree::PaymentMethod do
   end
 
   describe "delete" do
-    let(:http_stub) { double('http_stub').as_null_object }
+    let(:http_stub) { double("http_stub").as_null_object }
     it "accepts revoke_all_grants option with value true" do
       Braintree::Http.stub(:new).and_return http_stub
       http_stub.should_receive(:delete).with("/merchants/integration_merchant_id/payment_methods/any/some_token?revoke_all_grants=true")

data/spec/unit/braintree/paypal_account_spec.rb

@@ -8,7 +8,7 @@ describe Braintree::PayPalAccount do
           :invalid_key => "bad stuff",
           :options => {
             :invalid_option => "bad option",
-          }
+          },
         )
       end.to raise_error(ArgumentError, "invalid keys: invalid_key, options[invalid_option]")
     end
@@ -17,7 +17,7 @@ describe Braintree::PayPalAccount do
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::PayPalAccount.update("some_token", :invalid_key => 'val')
+        Braintree::PayPalAccount.update("some_token", :invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end

data/spec/unit/braintree/resource_collection_spec.rb

@@ -5,7 +5,7 @@ describe "Braintree::ResourceCollection" do
     it "iterates over the elements, yielding to the block in pages" do
       values = %w(a b c d e)
       collection = Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2}) do |ids|
-        ids.map {|id| values[id] }
+        ids.map { |id| values[id] }
       end
 
       count = 0
@@ -19,30 +19,30 @@ describe "Braintree::ResourceCollection" do
   end
 
   describe "#first" do
-    it 'returns nil with no results' do
+    it "returns nil with no results" do
       values = %w(a b c d e)
       collection = Braintree::ResourceCollection.new(:search_results => {:ids => [], :page_size => 2}) do |ids|
-        ids.map {|id| values[id] }
+        ids.map { |id| values[id] }
       end
 
       collection.first.should == nil
     end
 
-    context 'with results' do
+    context "with results" do
       let(:collection) do
         values = %w(a b c d e)
 
         Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2}) do |ids|
-          ids.map {|id| values[id] }
+          ids.map { |id| values[id] }
         end
       end
 
-      it 'returns the first occourence' do
-        collection.first.should == 'a'
+      it "returns the first occourence" do
+        collection.first.should == "a"
       end
 
-      it 'returns the first N occourences' do
-        collection.first(4).should == ['a','b','c','d']
+      it "returns the first N occourences" do
+        collection.first(4).should == ["a","b","c","d"]
       end
     end
   end

data/spec/unit/braintree/subscription_search_spec.rb

@@ -11,7 +11,7 @@ module Braintree
             Subscription::Status::Active,
             Subscription::Status::Canceled,
             Subscription::Status::Expired,
-            Subscription::Status::PastDue
+            Subscription::Status::PastDue,
           )
         end.should_not raise_error
       end

data/spec/unit/braintree/successful_result_spec.rb

@@ -5,7 +5,7 @@ describe Braintree::SuccessfulResult do
     it "sets instance variables from the values in the hash" do
       result = Braintree::SuccessfulResult.new(
         :transaction => "transaction_value",
-        :credit_card => "credit_card_value"
+        :credit_card => "credit_card_value",
       )
       result.success?.should == true
       result.transaction.should == "transaction_value"

data/spec/unit/braintree/three_d_secure_info_spec.rb

@@ -23,7 +23,7 @@ describe Braintree::ThreeDSecureInfo do
       :lookup => {
         :trans_status => "lookupstatus",
         :trans_status_reason => "lookupstatusreason"
-      }
+      },
     )
   }
 

data/spec/unit/braintree/transaction/credit_card_details_spec.rb

@@ -5,7 +5,7 @@ describe Braintree::Transaction::CreditCardDetails do
     it "concats expiration_month and expiration_year" do
       details = Braintree::Transaction::CreditCardDetails.new(
         :expiration_month => "08",
-        :expiration_year => "2009"
+        :expiration_year => "2009",
       )
       details.expiration_date.should == "08/2009"
     end
@@ -32,7 +32,7 @@ describe Braintree::Transaction::CreditCardDetails do
         :country_of_issuance => "Lilliput",
         :issuing_bank => "Gulliver Bank",
         :image_url => "example.com/visa.png",
-        :unique_number_identifier => "abc123"
+        :unique_number_identifier => "abc123",
       )
       details.inspect.should == %(#<token: "token", bin: "123456", last_4: "6789", card_type: "Visa", expiration_date: "05/2012", cardholder_name: "The Cardholder", customer_location: "US", prepaid: "Yes", healthcare: "No", durbin_regulated: "No", debit: "Yes", commercial: "Unknown", payroll: "Unknown", product_id: "Unknown", country_of_issuance: "Lilliput", issuing_bank: "Gulliver Bank", image_url: "example.com/visa.png", unique_number_identifier: "abc123">)
     end
@@ -41,7 +41,7 @@ describe Braintree::Transaction::CreditCardDetails do
   describe "masked_number" do
     it "concatenates the bin, some *'s, and the last_4" do
       details = Braintree::Transaction::CreditCardDetails.new(
-        :bin => "510510", :last_4 => "5100"
+        :bin => "510510", :last_4 => "5100",
       )
       details.masked_number.should == "510510******5100"
     end

data/spec/unit/braintree/transaction/customer_details_spec.rb

@@ -11,7 +11,7 @@ describe Braintree::Transaction::CustomerDetails do
         :company => "Smith Co.",
         :website => "http://www.example.com",
         :phone => "6145551234",
-        :fax => "3125551234"
+        :fax => "3125551234",
       )
       details.inspect.should == %(#<id: "id", first_name: "Amy", last_name: "Smith", email: "amy.smith@example.com", company: "Smith Co.", website: "http://www.example.com", phone: "6145551234", fax: "3125551234">)
     end

data/spec/unit/braintree/transaction/deposit_details_spec.rb

@@ -4,13 +4,13 @@ describe Braintree::Transaction::DisbursementDetails do
   describe "valid?" do
     it "returns true if disbursement details are initialized" do
       details = Braintree::Transaction::DisbursementDetails.new(
-        :disbursement_date => Date.new(2013, 4, 1)
+        :disbursement_date => Date.new(2013, 4, 1),
       )
       details.valid?.should == true
     end
     it "returns true if disbursement details are initialized" do
       details = Braintree::Transaction::DisbursementDetails.new(
-        :disbursement_date => nil
+        :disbursement_date => nil,
       )
       details.valid?.should == false
     end

data/spec/unit/braintree/transaction/paypal_details_spec.rb

@@ -27,7 +27,7 @@ describe Braintree::Transaction::PayPalDetails do
         :seller_protection_status => "seller-protection-status",
         :token => "token",
         :transaction_fee_amount => "2.00",
-        :transaction_fee_currency_iso_code => "123"
+        :transaction_fee_currency_iso_code => "123",
       )
 
       expect(details.authorization_id).to eq("id")

data/spec/unit/braintree/transaction_search_spec.rb

@@ -1,19 +1,19 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe Braintree::TransactionSearch do
-	it "overrides previous 'is' with new 'is' for the same field" do
-		search = Braintree::TransactionSearch.new
-		search.billing_company.is "one"
-		search.billing_company.is "two"
-		search.to_hash.should == {:billing_company => {:is => "two"}}
-	end
+  it "overrides previous 'is' with new 'is' for the same field" do
+    search = Braintree::TransactionSearch.new
+    search.billing_company.is "one"
+    search.billing_company.is "two"
+    search.to_hash.should == {:billing_company => {:is => "two"}}
+  end
 
-	it "overrides previous 'in' with new 'in' for the same field" do
-		search = Braintree::TransactionSearch.new
-		search.status.in Braintree::Transaction::Status::Authorized
-		search.status.in Braintree::Transaction::Status::SubmittedForSettlement
-		search.to_hash.should == {:status => [Braintree::Transaction::Status::SubmittedForSettlement]}
-	end
+  it "overrides previous 'in' with new 'in' for the same field" do
+    search = Braintree::TransactionSearch.new
+    search.status.in Braintree::Transaction::Status::Authorized
+    search.status.in Braintree::Transaction::Status::SubmittedForSettlement
+    search.to_hash.should == {:status => [Braintree::Transaction::Status::SubmittedForSettlement]}
+  end
 
   it "raises if the operator 'is' is left off" do
     search = Braintree::TransactionSearch.new

data/spec/unit/braintree/transaction_spec.rb

@@ -45,6 +45,14 @@ describe Braintree::Transaction do
     end
   end
 
+  describe "self.adjust_authorization" do
+    it "raises an ArgumentError if transaction_id is an invalid format" do
+      expect do
+        Braintree::Transaction.adjust_authorization("invalid-transaction-id", "10.00")
+      end.to raise_error(ArgumentError, "transaction_id is invalid")
+    end
+  end
+
   describe "self.update_details" do
     it "raises an ArgumentError if transaction_id is an invalid format" do
       expect do
@@ -66,7 +74,7 @@ describe Braintree::Transaction do
           :website => "lednerllc.com",
           :phone => "1-999-652-4189 x56883",
           :fax => "012-161-8055"
-        }
+        },
       )
       transaction.customer_details.id.should == "123"
       transaction.customer_details.first_name.should == "Adam"
@@ -88,7 +96,7 @@ describe Braintree::Transaction do
           :settlement_currency_exchange_rate => "1",
           :funds_held => false,
           :success => true
-        }
+        },
       )
       disbursement = transaction.disbursement_details
       disbursement.disbursement_date.should == Date.parse("2013-04-03")
@@ -119,7 +127,7 @@ describe Braintree::Transaction do
           :product_id => "Unknown",
           :country_of_issuance => "Narnia",
           :issuing_bank => "Mr Tumnus"
-        }
+        },
       )
       transaction.credit_card_details.token.should == "mzg2"
       transaction.credit_card_details.bin.should == "411111"
@@ -147,7 +155,7 @@ describe Braintree::Transaction do
           :liability_shifted => true,
           :liability_shift_possible => true,
           :status => "authenticate_successful",
-        }
+        },
       )
 
       transaction.three_d_secure_info.enrolled.should == "Y"
@@ -161,9 +169,9 @@ describe Braintree::Transaction do
       transaction = Braintree::Transaction._new(
         :gateway,
         :status_history => [
-          { :timestamp => time, :amount => "12.00", :transaction_source => "API",
-            :user => "larry", :status => Braintree::Transaction::Status::Authorized },
-          { :timestamp => Time.utc(2010,1,15), :amount => "12.00", :transaction_source => "API",
+          {:timestamp => time, :amount => "12.00", :transaction_source => "API",
+            :user => "larry", :status => Braintree::Transaction::Status::Authorized},
+          {:timestamp => Time.utc(2010,1,15), :amount => "12.00", :transaction_source => "API",
             :user => "curly", :status => "scheduled_for_settlement"}
         ])
       transaction.status_history.size.should == 2
@@ -180,8 +188,8 @@ describe Braintree::Transaction do
       transaction = Braintree::Transaction._new(
         :gateway,
         :authorization_adjustments => [
-          { :timestamp => timestamp, :processor_response_code => "1000", :processor_response_text => "Approved", :amount => "12.00", :success => true },
-          { :timestamp => timestamp, :processor_response_code => "3000", :processor_response_text => "Processor Network Unavailable - Try Again", :amount => "12.34", :success => false },
+          {:timestamp => timestamp, :processor_response_code => "1000", :processor_response_text => "Approved", :amount => "12.00", :success => true},
+          {:timestamp => timestamp, :processor_response_code => "3000", :processor_response_text => "Processor Network Unavailable - Try Again", :amount => "12.34", :success => false},
         ])
       transaction.authorization_adjustments.size.should == 2
       transaction.authorization_adjustments[0].amount.should == "12.00"
@@ -199,7 +207,7 @@ describe Braintree::Transaction do
     it "handles receiving custom as an empty string" do
       transaction = Braintree::Transaction._new(
         :gateway,
-        :custom => "\n    "
+        :custom => "\n    ",
       )
     end
 
@@ -217,7 +225,7 @@ describe Braintree::Transaction do
     it "handles nil risk_data" do
       transaction = Braintree::Transaction._new(
         :gateway,
-        :risk_data => nil
+        :risk_data => nil,
       )
       transaction.risk_data.should be_nil
     end
@@ -225,7 +233,7 @@ describe Braintree::Transaction do
     it "accepts network_transaction_id" do
       transaction = Braintree::Transaction._new(
         :gateway,
-        :network_transaction_id => "123456789012345"
+        :network_transaction_id => "123456789012345",
       )
       transaction.network_transaction_id.should == "123456789012345"
     end
@@ -307,8 +315,8 @@ describe Braintree::Transaction do
   end
 
   describe "sale" do
-    let(:mock_response) { {:transaction => {}}}
-    let(:http_stub) { double('http_stub').as_null_object }
+    let(:mock_response) { {:transaction => {}} }
+    let(:http_stub) { double("http_stub").as_null_object }
 
     RSpec::Matchers.define :skip_advanced_fraud_check_value_is do |value|
         match { |params| params[:transaction][:options][:skip_advanced_fraud_checking] == value }
@@ -326,7 +334,7 @@ describe Braintree::Transaction do
         },
         :options => {
           :skip_advanced_fraud_checking => true
-        }
+        },
       )
     end
 
@@ -342,7 +350,7 @@ describe Braintree::Transaction do
         },
         :options => {
           :skip_advanced_fraud_checking => false
-        }
+        },
       )
     end
 
@@ -358,7 +366,7 @@ describe Braintree::Transaction do
         },
         :options => {
           :submit_for_settlement => false
-        }
+        },
       )
     end
   end