artifactory 2.5.2 → 2.6.0

data/spec/support/api_server/repository_endpoints.rb

@@ -1,112 +1,112 @@
 module Artifactory
   module APIServer::RepositoryEndpoints
     def self.registered(app)
-      app.get('/api/repositories') do
-        content_type 'application/vnd.org.jfrog.artifactory.repositories.RepositoryDetailsList+json'
+      app.get("/api/repositories") do
+        content_type "application/vnd.org.jfrog.artifactory.repositories.RepositoryDetailsList+json"
         JSON.fast_generate([
           {
-            'key'         => 'libs-release-local',
-            'type'        => 'LOCAL',
-            'description' => 'Local repository for in-house libraries',
-            'url'         => server_url.join('libs-release-local'),
+            "key"         => "libs-release-local",
+            "type"        => "LOCAL",
+            "description" => "Local repository for in-house libraries",
+            "url"         => server_url.join("libs-release-local"),
           },
           {
-            'key'         => 'libs-snapshots-local',
-            'type'        => 'LOCAL',
-            'description' => 'Local repository for in-house snapshots',
-            'url'         => server_url.join('libs-snapshots-local'),
+            "key"         => "libs-snapshots-local",
+            "type"        => "LOCAL",
+            "description" => "Local repository for in-house snapshots",
+            "url"         => server_url.join("libs-snapshots-local"),
           },
         ])
       end
 
-      app.get('/api/repositories/libs-release-local') do
-        content_type 'application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json'
+      app.get("/api/repositories/libs-release-local") do
+        content_type "application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json"
         JSON.fast_generate({
-          'key'                          => 'libs-release-local',
-          'description'                  => 'Local repository for in-house libraries',
-          'notes'                        => '',
-          'includesPattern'              => '**/*',
-          'excludesPattern'              => '',
-          'repoLayoutRef'                => 'simple-default',
-          'enableNuGetSupport'           => false,
-          'enableGemsSupport'            => false,
-          'checksumPolicyType'           => 'client-checksums',
-          'handleReleases'               => true,
-          'handleSnapshots'              => false,
-          'maxUniqueSnapshots'           => 0,
-          'snapshotVersionBehavior'      => 'unique',
-          'suppressPomConsistencyChecks' => false,
-          'blackedOut'                   => false,
-          'propertySets'                 => ['artifactory'],
-          'archiveBrowsingEnabled'       => false,
-          'calculateYumMetadata'         => false,
-          'yumRootDepth'                 => 0,
-          'rclass'                       => 'local',
-          'packageType'                  => 'generic'
+          "key"                          => "libs-release-local",
+          "description"                  => "Local repository for in-house libraries",
+          "notes"                        => "",
+          "includesPattern"              => "**/*",
+          "excludesPattern"              => "",
+          "repoLayoutRef"                => "simple-default",
+          "enableNuGetSupport"           => false,
+          "enableGemsSupport"            => false,
+          "checksumPolicyType"           => "client-checksums",
+          "handleReleases"               => true,
+          "handleSnapshots"              => false,
+          "maxUniqueSnapshots"           => 0,
+          "snapshotVersionBehavior"      => "unique",
+          "suppressPomConsistencyChecks" => false,
+          "blackedOut"                   => false,
+          "propertySets"                 => ["artifactory"],
+          "archiveBrowsingEnabled"       => false,
+          "calculateYumMetadata"         => false,
+          "yumRootDepth"                 => 0,
+          "rclass"                       => "local",
+          "packageType"                  => "generic",
         })
       end
 
-      app.get('/api/repositories/libs-snapshots-local') do
-        content_type 'application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json'
+      app.get("/api/repositories/libs-snapshots-local") do
+        content_type "application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json"
         JSON.fast_generate({
-          'key'                          => 'libs-snapshots-local',
-          'description'                  => 'Local repository for in-house snapshots',
-          'notes'                        => '',
-          'includesPattern'              => '**/*',
-          'excludesPattern'              => '',
-          'repoLayoutRef'                => 'simple-default',
-          'enableNuGetSupport'           => false,
-          'enableGemsSupport'            => false,
-          'checksumPolicyType'           => 'client-checksums',
-          'handleReleases'               => false,
-          'handleSnapshots'              => true,
-          'maxUniqueSnapshots'           => 10,
-          'snapshotVersionBehavior'      => 'unique',
-          'suppressPomConsistencyChecks' => false,
-          'blackedOut'                   => false,
-          'propertySets'                 => ['artifactory'],
-          'archiveBrowsingEnabled'       => false,
-          'calculateYumMetadata'         => false,
-          'yumRootDepth'                 => 0,
-          'rclass'                       => 'local',
-          'packageType'                  => 'generic'
+          "key"                          => "libs-snapshots-local",
+          "description"                  => "Local repository for in-house snapshots",
+          "notes"                        => "",
+          "includesPattern"              => "**/*",
+          "excludesPattern"              => "",
+          "repoLayoutRef"                => "simple-default",
+          "enableNuGetSupport"           => false,
+          "enableGemsSupport"            => false,
+          "checksumPolicyType"           => "client-checksums",
+          "handleReleases"               => false,
+          "handleSnapshots"              => true,
+          "maxUniqueSnapshots"           => 10,
+          "snapshotVersionBehavior"      => "unique",
+          "suppressPomConsistencyChecks" => false,
+          "blackedOut"                   => false,
+          "propertySets"                 => ["artifactory"],
+          "archiveBrowsingEnabled"       => false,
+          "calculateYumMetadata"         => false,
+          "yumRootDepth"                 => 0,
+          "rclass"                       => "local",
+          "packageType"                  => "generic",
         })
       end
 
-      app.get('/api/repositories/libs-debian-local') do
-        content_type 'application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json'
+      app.get("/api/repositories/libs-debian-local") do
+        content_type "application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json"
         JSON.fast_generate({
-            'key'                          => 'libs-debian-local',
-            'description'                  => 'Local repository for in-house snapshots',
-            'notes'                        => '',
-            'includesPattern'              => '**/*',
-            'excludesPattern'              => '',
-            'repoLayoutRef'                => 'simple-default',
-            'enableNuGetSupport'           => false,
-            'enableGemsSupport'            => false,
-            'checksumPolicyType'           => 'client-checksums',
-            'handleReleases'               => false,
-            'handleSnapshots'              => true,
-            'maxUniqueSnapshots'           => 10,
-            'snapshotVersionBehavior'      => 'unique',
-            'suppressPomConsistencyChecks' => false,
-            'blackedOut'                   => false,
-            'propertySets'                 => ['artifactory'],
-            'archiveBrowsingEnabled'       => false,
-            'calculateYumMetadata'         => false,
-            'yumRootDepth'                 => 0,
-            'rclass'                       => 'local',
-            'packageType'                  => 'debian'
+            "key"                          => "libs-debian-local",
+            "description"                  => "Local repository for in-house snapshots",
+            "notes"                        => "",
+            "includesPattern"              => "**/*",
+            "excludesPattern"              => "",
+            "repoLayoutRef"                => "simple-default",
+            "enableNuGetSupport"           => false,
+            "enableGemsSupport"            => false,
+            "checksumPolicyType"           => "client-checksums",
+            "handleReleases"               => false,
+            "handleSnapshots"              => true,
+            "maxUniqueSnapshots"           => 10,
+            "snapshotVersionBehavior"      => "unique",
+            "suppressPomConsistencyChecks" => false,
+            "blackedOut"                   => false,
+            "propertySets"                 => ["artifactory"],
+            "archiveBrowsingEnabled"       => false,
+            "calculateYumMetadata"         => false,
+            "yumRootDepth"                 => 0,
+            "rclass"                       => "local",
+            "packageType"                  => "debian",
           })
       end
 
       # Simulate a non-existent repository
-      app.get('/api/repositories/libs-testing-local') do
+      app.get("/api/repositories/libs-testing-local") do
         status 400
       end
 
-      app.put('/api/repositories/libs-testing-local') do
-        content_type 'text/plain'
+      app.put("/api/repositories/libs-testing-local") do
+        content_type "text/plain"
         "Repository libs-resting-local created successfully!\n"
       end
     end

data/spec/support/api_server/status_endpoints.rb

@@ -1,11 +1,11 @@
 module Artifactory
   module APIServer::StatusEndpoints
     def self.registered(app)
-      app.get('/status/:code') { code.to_i }
-      app.post('/status/:code') { code.to_i }
-      app.patch('/status/:code') { code.to_i }
-      app.put('/status/:code') { code.to_i }
-      app.delete('/status/:code') { code.to_i }
+      app.get("/status/:code") { code.to_i }
+      app.post("/status/:code") { code.to_i }
+      app.patch("/status/:code") { code.to_i }
+      app.put("/status/:code") { code.to_i }
+      app.delete("/status/:code") { code.to_i }
     end
   end
 end

data/spec/support/api_server/system_endpoints.rb

@@ -1,17 +1,17 @@
 module Artifactory
   module APIServer::SystemEndpoints
     def self.registered(app)
-      app.get('/api/system') do
-        'This is some serious system info right here'
+      app.get("/api/system") do
+        "This is some serious system info right here"
       end
 
-      app.get('/api/system/ping') do
-        'OK'
+      app.get("/api/system/ping") do
+        "OK"
       end
 
-      app.get('/api/system/configuration') do
-        content_type 'application/xml'
-        <<-EOH.gsub(/^ {10}/, '')
+      app.get("/api/system/configuration") do
+        content_type "application/xml"
+        <<-EOH.gsub(/^ {10}/, "")
           <?xml version='1.0' encoding='UTF-8' standalone='yes'?>
           <config xsi:schemaLocation='http://www.jfrog.org/xsd/artifactory-v1_5_3.xsd'
                   xmlns='http://artifactory.jfrog.org/xsd/1.5.3'
@@ -77,27 +77,26 @@ module Artifactory
                 <sendMailOnError>true</sendMailOnError>
                 <excludeBuilds>false</excludeBuilds>
              </backup>
-           </backups> 
+           </backups>
          </config>
         EOH
       end
 
-      app.post('/api/system/configuration') do
+      app.post("/api/system/configuration") do
         # Just echo the response we got back, since it seems that's what a real
         # Artifactory server does...
         request.body.read
       end
 
-      app.get('/api/system/version') do
-        content_type 'application/vnd.org.jfrog.artifactory.system.Version+json'
+      app.get("/api/system/version") do
+        content_type "application/vnd.org.jfrog.artifactory.system.Version+json"
         JSON.generate({
-          'version' => '3.1.0',
-          'revision' => '30062',
-          'addons' => [
-            'ldap',
-            'license',
-            'yum'
-          ]
+          "version" => "3.1.0",
+          "revision" => "30062",
+          "addons" => %w{
+ldap
+license
+yum},
         })
       end
     end

data/spec/support/api_server/user_endpoints.rb

@@ -1,57 +1,57 @@
 module Artifactory
   module APIServer::UserEndpoints
     def self.registered(app)
-      app.get('/api/security/users') do
-        content_type 'application/vnd.org.jfrog.artifactory.security.Users+json'
+      app.get("/api/security/users") do
+        content_type "application/vnd.org.jfrog.artifactory.security.Users+json"
         JSON.fast_generate([
           {
-            'name' => 'sethvargo',
-            'uri'  => server_url.join('/api/security/users/sethvargo'),
+            "name" => "sethvargo",
+            "uri"  => server_url.join("/api/security/users/sethvargo"),
           },
           {
-            'name' => 'yzl',
-            'uri'  => server_url.join('/api/security/users/yzl')
-          }
+            "name" => "yzl",
+            "uri"  => server_url.join("/api/security/users/yzl"),
+          },
         ])
       end
 
-      app.get('/api/security/users/sethvargo') do
-        content_type 'application/vnd.org.jfrog.artifactory.security.User+json'
+      app.get("/api/security/users/sethvargo") do
+        content_type "application/vnd.org.jfrog.artifactory.security.User+json"
         JSON.fast_generate(
-          'admin'                    => false,
-          'email'                    => 'sethvargo@gmail.com',
-          'groups'                   => ['admin'],
-          'internalPasswordDisabled' => true,
-          'lastLoggedIn'             => nil,
-          'name'                     => 'sethvargo',
-          'profileUpdatable'         => true,
-          'realm'                    => 'artifactory',
+          "admin"                    => false,
+          "email"                    => "sethvargo@gmail.com",
+          "groups"                   => ["admin"],
+          "internalPasswordDisabled" => true,
+          "lastLoggedIn"             => nil,
+          "name"                     => "sethvargo",
+          "profileUpdatable"         => true,
+          "realm"                    => "artifactory"
         )
       end
 
-      app.get('/api/security/users/yzl') do
-        content_type 'application/vnd.org.jfrog.artifactory.security.User+json'
+      app.get("/api/security/users/yzl") do
+        content_type "application/vnd.org.jfrog.artifactory.security.User+json"
         JSON.fast_generate(
-          'admin'                    => true,
-          'email'                    => 'yvonne@getchef.com',
-          'groups'                   => ['admin'],
-          'internalPasswordDisabled' => true,
-          'lastLoggedIn'             => nil,
-          'name'                     => 'yzl',
-          'profileUpdatable'         => true,
-          'realm'                    => 'crowd',
+          "admin"                    => true,
+          "email"                    => "yvonne@getchef.com",
+          "groups"                   => ["admin"],
+          "internalPasswordDisabled" => true,
+          "lastLoggedIn"             => nil,
+          "name"                     => "yzl",
+          "profileUpdatable"         => true,
+          "realm"                    => "crowd"
         )
       end
 
-      app.put('/api/security/users/:name') do
-        return 415 unless request.content_type == 'application/vnd.org.jfrog.artifactory.security.User+json'
+      app.put("/api/security/users/:name") do
+        return 415 unless request.content_type == "application/vnd.org.jfrog.artifactory.security.User+json"
 
         # Attempt to parse the response; if this succeeds, all is well...
         JSON.parse(request.body.read)
         nil
       end
 
-      app.delete('/api/security/users/:name') do
+      app.delete("/api/security/users/:name") do
         nil
       end
     end

data/spec/unit/artifactory_spec.rb

@@ -1,27 +1,27 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Artifactory do
-  it 'sets the default values' do
+  it "sets the default values" do
     Artifactory::Configurable.keys.each do |key|
       value = Artifactory::Defaults.send(key)
       expect(Artifactory.instance_variable_get(:"@#{key}")).to eq(value)
     end
   end
 
-  describe '.client' do
-    it 'creates an Artifactory::Client' do
+  describe ".client" do
+    it "creates an Artifactory::Client" do
       expect(Artifactory.client).to be_a(Artifactory::Client)
     end
 
-    it 'caches the client when the same options are passed' do
+    it "caches the client when the same options are passed" do
       expect(Artifactory.client).to eq(Artifactory.client)
     end
 
-    it 'returns a fresh client when options are not the same' do
+    it "returns a fresh client when options are not the same" do
       original_client = Artifactory.client
 
       # Change settings
-      Artifactory.username = 'admin'
+      Artifactory.username = "admin"
       new_client = Artifactory.client
 
       # Get it one more tmie
@@ -32,9 +32,9 @@ describe Artifactory do
     end
   end
 
-  describe '.configure' do
+  describe ".configure" do
     Artifactory::Configurable.keys.each do |key|
-      it "sets the #{key.to_s.gsub('_', ' ')}" do
+      it "sets the #{key.to_s.tr('_', ' ')}" do
         Artifactory.configure do |config|
           config.send("#{key}=", key)
         end
@@ -44,29 +44,29 @@ describe Artifactory do
     end
   end
 
-  describe '.method_missing' do
-    context 'when the client responds to the method' do
+  describe ".method_missing" do
+    context "when the client responds to the method" do
       let(:client) { double(:client) }
       before { allow(Artifactory).to receive(:client).and_return(client) }
 
-      it 'delegates the method to the client' do
-        allow(client).to receive(:bacon).and_return('awesome')
+      it "delegates the method to the client" do
+        allow(client).to receive(:bacon).and_return("awesome")
         expect { Artifactory.bacon }.to_not raise_error
       end
     end
 
-    context 'when the client does not respond to the method' do
-      it 'calls super' do
+    context "when the client does not respond to the method" do
+      it "calls super" do
         expect { Artifactory.bacon }.to raise_error(NoMethodError)
       end
     end
   end
 
-  describe '.respond_to_missing?' do
+  describe ".respond_to_missing?" do
     let(:client) { double(:client) }
     before { allow(Artifactory).to receive(:client).and_return(client) }
 
-    it 'delegates to the client' do
+    it "delegates to the client" do
       expect { Artifactory.respond_to_missing?(:foo) }.to_not raise_error
     end
   end

data/spec/unit/client_spec.rb

@@ -1,106 +1,106 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Client do
     let(:client) { subject }
 
-    context 'configuration' do
-      it 'is a configurable object' do
+    context "configuration" do
+      it "is a configurable object" do
         expect(client).to be_a(Configurable)
       end
 
-      it 'users the default configuration' do
+      it "users the default configuration" do
         Defaults.options.each do |key, value|
           expect(client.send(key)).to eq(value)
         end
       end
 
-      it 'uses the values in the initializer' do
-        client = described_class.new(username: 'admin')
-        expect(client.username).to eq('admin')
+      it "uses the values in the initializer" do
+        client = described_class.new(username: "admin")
+        expect(client.username).to eq("admin")
       end
 
-      it 'can be modified after initialization' do
+      it "can be modified after initialization" do
         expect(client.username).to eq(Defaults.username)
-        client.username = 'admin'
-        expect(client.username).to eq('admin')
+        client.username = "admin"
+        expect(client.username).to eq("admin")
       end
     end
 
-    describe '.proxy' do
+    describe ".proxy" do
       before { described_class.proxy(Resource::Artifact) }
 
-      it 'defines a new method' do
+      it "defines a new method" do
         expect(described_class).to be_method_defined(:artifact_search)
       end
 
-      it 'delegates to the class, injecting the client' do
+      it "delegates to the class, injecting the client" do
         allow(Resource::Artifact).to receive(:search)
         expect(Resource::Artifact).to receive(:search).with(client: subject)
         subject.artifact_search
       end
     end
 
-    describe '#get' do
-      it 'delegates to the #request method' do
-        expect(subject).to receive(:request).with(:get, '/foo', {}, {})
-        subject.get('/foo')
+    describe "#get" do
+      it "delegates to the #request method" do
+        expect(subject).to receive(:request).with(:get, "/foo", {}, {})
+        subject.get("/foo")
       end
     end
 
-    describe '#post' do
+    describe "#post" do
       let(:data) { double }
 
-      it 'delegates to the #request method' do
-        expect(subject).to receive(:request).with(:post, '/foo', data, {})
-        subject.post('/foo', data)
+      it "delegates to the #request method" do
+        expect(subject).to receive(:request).with(:post, "/foo", data, {})
+        subject.post("/foo", data)
       end
     end
 
-    describe '#put' do
+    describe "#put" do
       let(:data) { double }
 
-      it 'delegates to the #request method' do
-        expect(subject).to receive(:request).with(:put, '/foo', data, {})
-        subject.put('/foo', data)
+      it "delegates to the #request method" do
+        expect(subject).to receive(:request).with(:put, "/foo", data, {})
+        subject.put("/foo", data)
       end
     end
 
-    describe '#patch' do
+    describe "#patch" do
       let(:data) { double }
 
-      it 'delegates to the #request method' do
-        expect(subject).to receive(:request).with(:patch, '/foo', data, {})
-        subject.patch('/foo', data)
+      it "delegates to the #request method" do
+        expect(subject).to receive(:request).with(:patch, "/foo", data, {})
+        subject.patch("/foo", data)
       end
     end
 
-    describe '#delete' do
-      it 'delegates to the #request method' do
-        expect(subject).to receive(:request).with(:delete, '/foo', {}, {})
-        subject.delete('/foo')
+    describe "#delete" do
+      it "delegates to the #request method" do
+        expect(subject).to receive(:request).with(:delete, "/foo", {}, {})
+        subject.delete("/foo")
       end
     end
 
-    describe '#request' do
-      context 'when the response is a 400' do
-        before { stub_request(:get, /.+/).to_return(status: 5000, body: 'No!') }
+    describe "#request" do
+      context "when the response is a 400" do
+        before { stub_request(:get, /.+/).to_return(status: 5000, body: "No!") }
 
-        it 'raises an HTTPError error' do
-          expect { subject.request(:get, '/') }.to raise_error(Error::HTTPError)
+        it "raises an HTTPError error" do
+          expect { subject.request(:get, "/") }.to raise_error(Error::HTTPError)
         end
       end
     end
 
-    describe '#to_query_string' do
+    describe "#to_query_string" do
       it 'converts spaces to "+" characters' do
-        params = {user: 'Seth Chisamore'}
-        expect(subject.to_query_string(params)).to eq('user=Seth+Chisamore')
+        params = { user: "Seth Chisamore" }
+        expect(subject.to_query_string(params)).to eq("user=Seth+Chisamore")
       end
 
       it 'converts "+" to "%2B"' do
-        params = {version: '12.0.0-alpha.1+20140826080510.git.50.f5ff271'}
-        expect(subject.to_query_string(params)).to eq('version=12.0.0-alpha.1%2B20140826080510.git.50.f5ff271')
+        params = { version: "12.0.0-alpha.1+20140826080510.git.50.f5ff271" }
+        expect(subject.to_query_string(params)).to eq("version=12.0.0-alpha.1%2B20140826080510.git.50.f5ff271")
       end
     end
   end