artifactory 2.5.2 → 2.6.0

data/spec/unit/resources/defaults_spec.rb

@@ -4,22 +4,22 @@ module Artifactory
   describe Defaults do
     describe "read_timeout" do
       before(:each) do
-        ENV['ARTIFACTORY_READ_TIMEOUT'] = "60"
+        ENV["ARTIFACTORY_READ_TIMEOUT"] = "60"
       end
 
       after(:each) do
-        ENV.delete('ARTIFACTORY_READ_TIMEOUT')
+        ENV.delete("ARTIFACTORY_READ_TIMEOUT")
       end
 
       it "returns Fixnums even when given strings" do
         expect(subject.read_timeout).to be_an_instance_of Fixnum
       end
 
-      it 'returns a non-zero value' do
+      it "returns a non-zero value" do
         expect(subject.read_timeout).to be > 0
       end
 
-      it 'does not return a nil value' do
+      it "does not return a nil value" do
         expect(subject.read_timeout).not_to be nil
       end
     end

data/spec/unit/resources/group_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::Group do
     let(:client) { double(:client) }
-    let(:endpoint_host) { 'http://33.33.33.11' }
+    let(:endpoint_host) { "http://33.33.33.11" }
     let(:endpoint) { "#{endpoint_host}/" }
 
     before(:each) do
@@ -11,94 +11,94 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.all' do
+    describe ".all" do
       let(:response) do
         [
-          { 'uri' => 'a' },
-          { 'uri' => 'b' },
-          { 'uri' => 'c' },
+          { "uri" => "a" },
+          { "uri" => "b" },
+          { "uri" => "c" },
         ]
       end
       before do
-        allow(described_class).to receive(:from_url).with('a', client: client).and_return('a')
-        allow(described_class).to receive(:from_url).with('b', client: client).and_return('b')
-        allow(described_class).to receive(:from_url).with('c', client: client).and_return('c')
+        allow(described_class).to receive(:from_url).with("a", client: client).and_return("a")
+        allow(described_class).to receive(:from_url).with("b", client: client).and_return("b")
+        allow(described_class).to receive(:from_url).with("c", client: client).and_return("c")
       end
 
-      it 'gets /api/security/groups' do
-        expect(client).to receive(:get).with('/api/security/groups').once
+      it "gets /api/security/groups" do
+        expect(client).to receive(:get).with("/api/security/groups").once
         described_class.all
       end
 
-      it 'returns the groups' do
-        expect(described_class.all).to eq(['a', 'b', 'c'])
+      it "returns the groups" do
+        expect(described_class.all).to eq(%w{a b c})
       end
     end
 
-    describe '.find' do
+    describe ".find" do
       let(:response) { {} }
 
       it 'gets /api/repositories/#{name}' do
-        expect(client).to receive(:get).with('/api/security/groups/readers').once
-        described_class.find('readers')
+        expect(client).to receive(:get).with("/api/security/groups/readers").once
+        described_class.find("readers")
       end
     end
 
-    describe '.from_url' do
+    describe ".from_url" do
       let(:response) { {} }
 
-      it 'constructs a new instance from the result' do
+      it "constructs a new instance from the result" do
         expect(client).to receive(:endpoint).and_return(endpoint)
         expect(described_class).to receive(:from_hash).once
-        described_class.from_url('/api/security/groups/readers')
+        described_class.from_url("/api/security/groups/readers")
       end
     end
 
-    describe '.from_hash' do
+    describe ".from_hash" do
       let(:hash) do
         {
-          'name'            => 'readers',
-          'description'     => 'This list of read-only users',
-          'autoJoin'        => true,
-          'realm'           => 'artifactory',
-          'realmAttributes' => nil,
+          "name"            => "readers",
+          "description"     => "This list of read-only users",
+          "autoJoin"        => true,
+          "realm"           => "artifactory",
+          "realmAttributes" => nil,
         }
       end
 
-      it 'creates a new instance' do
+      it "creates a new instance" do
         instance = described_class.from_hash(hash)
-        expect(instance.name).to eq('readers')
-        expect(instance.description).to eq('This list of read-only users')
+        expect(instance.name).to eq("readers")
+        expect(instance.description).to eq("This list of read-only users")
         expect(instance.auto_join).to be_truthy
-        expect(instance.realm).to eq('artifactory')
+        expect(instance.realm).to eq("artifactory")
         expect(instance.realm_attributes).to be_nil
       end
     end
 
-    describe '#save' do
+    describe "#save" do
       let(:client) { double }
       before do
         subject.client = client
-        subject.name = 'deployers'
+        subject.name = "deployers"
       end
 
-      context 'when the group is new' do
+      context "when the group is new" do
         before do
           allow(described_class).to receive(:find).with(subject.name, client: client).and_return(nil)
         end
 
-        it 'PUTS the group to the server' do
+        it "PUTS the group to the server" do
           expect(client).to receive(:put).with("/api/security/groups/#{subject.name}", kind_of(String), kind_of(Hash))
           subject.save
         end
       end
 
-      context 'when the group exists' do
+      context "when the group exists" do
         before do
-          allow(described_class).to receive(:find).with(subject.name, client: client).and_return({name: subject.name})
+          allow(described_class).to receive(:find).with(subject.name, client: client).and_return({ name: subject.name })
         end
 
-        it 'POSTS the group to the server' do
+        it "POSTS the group to the server" do
           expect(client).to receive(:post).with("/api/security/groups/#{subject.name}", kind_of(String), kind_of(Hash))
           subject.save
         end

data/spec/unit/resources/layout_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::Layout do
@@ -9,7 +9,7 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.all' do
+    describe ".all" do
       doc = <<-XML
         <config>
           <repoLayouts>
@@ -27,14 +27,14 @@ module Artifactory
         allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
-      it 'returns the layouts' do
+      it "returns the layouts" do
         expect(described_class.all).to be_a(Array)
         expect(described_class.all.first).to be_a(described_class)
-        expect(described_class.all.first.name).to eq('fake-layout')
+        expect(described_class.all.first.name).to eq("fake-layout")
       end
     end
 
-    describe '.find' do
+    describe ".find" do
       doc = <<-XML
         <config>
           <repoLayouts>
@@ -52,9 +52,9 @@ module Artifactory
         allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
-      it 'returns the found layout' do
-        expect(described_class.find('found-layout')).to be_a(described_class)
-        expect(described_class.find('found-layout').name).to eq('found-layout')
+      it "returns the found layout" do
+        expect(described_class.find("found-layout")).to be_a(described_class)
+        expect(described_class.find("found-layout").name).to eq("found-layout")
       end
     end
   end

data/spec/unit/resources/ldap_setting_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::LDAPSetting do
@@ -9,7 +9,7 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.all' do
+    describe ".all" do
       doc = <<-XML
         <config>
           <security>
@@ -29,14 +29,14 @@ module Artifactory
         allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
-      it 'returns the ldap settings' do
+      it "returns the ldap settings" do
         expect(described_class.all).to be_a(Array)
         expect(described_class.all.first).to be_a(described_class)
-        expect(described_class.all.first.key).to eq('example-ldap')
+        expect(described_class.all.first.key).to eq("example-ldap")
       end
     end
 
-    describe '.find' do
+    describe ".find" do
       doc = <<-XML
         <config>
           <security>
@@ -56,9 +56,9 @@ module Artifactory
         allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
-      it 'returns the found ldap setting' do
-        expect(described_class.find('viridian-ldap')).to be_a(described_class)
-        expect(described_class.find('viridian-ldap').key).to eq('viridian-ldap')
+      it "returns the found ldap setting" do
+        expect(described_class.find("viridian-ldap")).to be_a(described_class)
+        expect(described_class.find("viridian-ldap").key).to eq("viridian-ldap")
       end
     end
   end

data/spec/unit/resources/mail_server_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::MailServer do
@@ -9,7 +9,7 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.all' do
+    describe ".all" do
       doc = <<-XML
         <config>
           <mailServer>
@@ -25,14 +25,14 @@ module Artifactory
         allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
-      it 'returns the mail server settings' do
+      it "returns the mail server settings" do
         expect(described_class.all).to be_a(Array)
         expect(described_class.all.first).to be_a(described_class)
-        expect(described_class.all.first.host).to eq('smtp.gmail.com')
+        expect(described_class.all.first.host).to eq("smtp.gmail.com")
       end
     end
 
-    describe '.find' do
+    describe ".find" do
       doc = <<-XML
         <config>
           <mailServer>
@@ -48,9 +48,9 @@ module Artifactory
         allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
-      it 'returns the found mail server setting' do
-        expect(described_class.find('mailserver.example.com')).to be_a(described_class)
-        expect(described_class.find('mailserver.example.com').host).to eq('mailserver.example.com')
+      it "returns the found mail server setting" do
+        expect(described_class.find("mailserver.example.com")).to be_a(described_class)
+        expect(described_class.find("mailserver.example.com").host).to eq("mailserver.example.com")
       end
     end
   end

data/spec/unit/resources/permission_target_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::PermissionTarget do
     let(:client) { double(:client) }
-    let(:endpoint_host) { 'http://33.33.33.11' }
+    let(:endpoint_host) { "http://33.33.33.11" }
     let(:endpoint) { "#{endpoint_host}/" }
 
     before(:each) do
@@ -11,178 +11,178 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.all' do
+    describe ".all" do
       let(:response) do
         [
-          { 'uri' => 'a' },
-          { 'uri' => 'b' },
-          { 'uri' => 'c' },
+          { "uri" => "a" },
+          { "uri" => "b" },
+          { "uri" => "c" },
         ]
       end
       before do
-        allow(described_class).to receive(:from_url).with('a', client: client).and_return('a')
-        allow(described_class).to receive(:from_url).with('b', client: client).and_return('b')
-        allow(described_class).to receive(:from_url).with('c', client: client).and_return('c')
+        allow(described_class).to receive(:from_url).with("a", client: client).and_return("a")
+        allow(described_class).to receive(:from_url).with("b", client: client).and_return("b")
+        allow(described_class).to receive(:from_url).with("c", client: client).and_return("c")
       end
 
-      it 'gets /api/security/permissions' do
-        expect(client).to receive(:get).with('/api/security/permissions').once
+      it "gets /api/security/permissions" do
+        expect(client).to receive(:get).with("/api/security/permissions").once
         described_class.all
       end
 
-      it 'returns the permissions' do
-        expect(described_class.all).to eq(['a', 'b', 'c'])
+      it "returns the permissions" do
+        expect(described_class.all).to eq(%w{a b c})
       end
     end
 
-    describe '.find' do
+    describe ".find" do
       let(:response) { {} }
 
       it 'gets /api/security/permissions/#{name}' do
-        expect(client).to receive(:get).with('/api/security/permissions/Any%20Remote').once
-        described_class.find('Any Remote')
+        expect(client).to receive(:get).with("/api/security/permissions/Any%20Remote").once
+        described_class.find("Any Remote")
       end
     end
 
-    describe '.from_url' do
+    describe ".from_url" do
       let(:response) { {} }
 
-      it 'constructs a new instance from the result' do
+      it "constructs a new instance from the result" do
         expect(client).to receive(:endpoint).and_return(endpoint)
         expect(described_class).to receive(:from_hash).once
-        described_class.from_url('/api/security/permissions/AnyRemote')
+        described_class.from_url("/api/security/permissions/AnyRemote")
       end
     end
 
-    describe '.from_hash' do
+    describe ".from_hash" do
       let(:hash) do
         {
-          'name'             => 'Test Remote',
-          'includes_pattern'  => '**',
-          'excludes_pattern' => '',
-          'repositories'     => ['ANY REMOTE'],
-          'principals'       => { 'users' => { 'anonymous' => ['w', 'r'] }, 'groups'  => {} }
+          "name" => "Test Remote",
+          "includes_pattern" => "**",
+          "excludes_pattern" => "",
+          "repositories"     => ["ANY REMOTE"],
+          "principals"       => { "users" => { "anonymous" => %w{w r} }, "groups" => {} },
         }
       end
 
-      it 'creates a new instance' do
+      it "creates a new instance" do
         instance = described_class.from_hash(hash)
-        expect(instance.name).to eq('Test Remote')
-        expect(instance.includes_pattern).to eq('**')
-        expect(instance.excludes_pattern).to eq('')
-        expect(instance.repositories).to eq(['ANY REMOTE'])
-        expect(instance.principals).to eq({ 'users' => { 'anonymous' => ['deploy', 'read'] }, 'groups' => {} })
+        expect(instance.name).to eq("Test Remote")
+        expect(instance.includes_pattern).to eq("**")
+        expect(instance.excludes_pattern).to eq("")
+        expect(instance.repositories).to eq(["ANY REMOTE"])
+        expect(instance.principals).to eq({ "users" => { "anonymous" => %w{deploy read} }, "groups" => {} })
       end
     end
 
     describe Artifactory::Resource::PermissionTarget::Principal do
-      context 'principal object' do
-        users = { 'anonymous_users' => ['admin', 'deploy', 'read'] }
-        groups = { 'anonymous_groups' => ['delete', 'read'] }
+      context "principal object" do
+        users = { "anonymous_users" => %w{admin deploy read} }
+        groups = { "anonymous_groups" => %w{delete read} }
         instance = described_class.new(users, groups)
 
-        it 'has unabbreviated users' do
-          expect(instance.users).to eq( { 'anonymous_users' => ['admin', 'deploy', 'read'] } )
+        it "has unabbreviated users" do
+          expect(instance.users).to eq( { "anonymous_users" => %w{admin deploy read} } )
         end
 
-        it 'has unabbreviated groups' do
-          expect(instance.groups).to eq( { 'anonymous_groups' => ['delete', 'read'] } )
+        it "has unabbreviated groups" do
+          expect(instance.groups).to eq( { "anonymous_groups" => %w{delete read} } )
         end
 
-        it 'abbreviates' do
-          expect(instance.to_abbreviated).to eq( { 'users' => { 'anonymous_users' => ['m', 'r', 'w'] }, 'groups' => { 'anonymous_groups' => ['d', 'r'] } } )
+        it "abbreviates" do
+          expect(instance.to_abbreviated).to eq( { "users" => { "anonymous_users" => %w{m r w} }, "groups" => { "anonymous_groups" => %w{d r} } } )
         end
       end
     end
 
-    describe '#save' do
+    describe "#save" do
       let(:client) { double }
       before do
         subject.client = client
-        subject.name = 'TestRemote'
+        subject.name = "TestRemote"
         subject.includes_pattern = nil
-        subject.excludes_pattern = ''
-        subject.repositories = ['ANY']
+        subject.excludes_pattern = ""
+        subject.repositories = ["ANY"]
         subject.principals = {
-          'users' => {
-            'anonymous_users' => ['read']
+          "users" => {
+            "anonymous_users" => ["read"],
+          },
+          "groups" => {
+            "anonymous_readers" => ["read"],
           },
-          'groups' => {
-            'anonymous_readers' => ['read']
-          }
         }
         allow(described_class).to receive(:find).with(subject.name, client: client).and_return(nil)
       end
 
-      it 'PUTS the permission target to the server' do
+      it "PUTS the permission target to the server" do
         expect(client).to receive(:put).with("/api/security/permissions/TestRemote",
           "{\"name\":\"TestRemote\",\"includesPattern\":\"**\",\"excludesPattern\":\"\",\"repositories\":[\"ANY\"],\"principals\":{\"users\":{\"anonymous_users\":[\"r\"]},\"groups\":{\"anonymous_readers\":[\"r\"]}}}",
-          { "Content-Type" => "application/vnd.org.jfrog.artifactory.security.PermissionTarget+json"})
+          { "Content-Type" => "application/vnd.org.jfrog.artifactory.security.PermissionTarget+json" })
         subject.save
       end
     end
 
-    describe '#delete' do
+    describe "#delete" do
       let(:client) { double }
 
-      it 'sends DELETE to the client' do
+      it "sends DELETE to the client" do
         subject.client = client
-        subject.name = 'My Permissions'
+        subject.name = "My Permissions"
 
-        expect(client).to receive(:delete).with('/api/security/permissions/My%20Permissions')
+        expect(client).to receive(:delete).with("/api/security/permissions/My%20Permissions")
         subject.delete
       end
     end
 
-    describe 'getters' do
+    describe "getters" do
       let(:client) { double }
       before do
         subject.client = client
-        subject.name = 'TestGetters'
+        subject.name = "TestGetters"
         subject.principals = {
-          'users' => {
-            'anonymous' => ['read']
+          "users" => {
+            "anonymous" => ["read"],
+          },
+          "groups" => {
+            "readers" => ["read"],
           },
-          'groups' => {
-            'readers' => ['read']
-          }
         }
         allow(described_class).to receive(:find).with(subject.name, client: client).and_return(nil)
       end
 
-      it '#users returns the users hash' do
-        expect(subject.users).to eq({ 'anonymous' => ['read'] })
+      it "#users returns the users hash" do
+        expect(subject.users).to eq({ "anonymous" => ["read"] })
       end
 
-      it '#groups returns the groups hash' do
-        expect(subject.groups).to eq({ 'readers' => ['read'] })
+      it "#groups returns the groups hash" do
+        expect(subject.groups).to eq({ "readers" => ["read"] })
       end
     end
 
-    describe 'setters' do
+    describe "setters" do
       let(:client) { double }
       before do
         subject.client = client
-        subject.name = 'TestSetters'
+        subject.name = "TestSetters"
         subject.principals = {
-          'users' => {
-            'anonymous' => ['read']
+          "users" => {
+            "anonymous" => ["read"],
+          },
+          "groups" => {
+            "readers" => ["read"],
           },
-          'groups' => {
-            'readers' => ['read']
-          }
         }
         allow(described_class).to receive(:find).with(subject.name, client: client).and_return(nil)
       end
 
-      it '#users= sets the users hash' do
-        subject.users = { 'spiders' => [ 'read', 'admin'] }
-        expect(subject.users).to eq({ 'spiders' => ['admin', 'read'] })
+      it "#users= sets the users hash" do
+        subject.users = { "spiders" => %w{read admin} }
+        expect(subject.users).to eq({ "spiders" => %w{admin read} })
       end
 
-      it '#groups= sets the groups hash' do
-        subject.groups = { 'beatles' => [ 'deploy', 'delete'] }
-        expect(subject.groups).to eq({ 'beatles' => ['delete', 'deploy'] })
+      it "#groups= sets the groups hash" do
+        subject.groups = { "beatles" => %w{deploy delete} }
+        expect(subject.groups).to eq({ "beatles" => %w{delete deploy} })
       end
     end
   end