artifactory 2.5.2 → 2.6.0

data/lib/artifactory/resources/layout.rb

@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-require 'rexml/document'
+require "rexml/document"
 
 module Artifactory
   class Resource::Layout < Resource::Base
@@ -33,7 +33,7 @@ module Artifactory
       #
       def all(options = {})
         config = Resource::System.configuration(options)
-        list_from_config('config/repoLayouts/repoLayout', config, options)
+        list_from_config("config/repoLayouts/repoLayout", config, options)
       end
 
       #
@@ -63,7 +63,7 @@ module Artifactory
       end
     end
 
-    attribute :name, ->{ raise 'Name missing!' }
+    attribute :name, -> { raise "Name missing!" }
     attribute :artifact_path_pattern
     attribute :distinctive_descriptor_path_pattern, true
     attribute :descriptor_path_pattern

data/lib/artifactory/resources/ldap_setting.rb

@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-require 'rexml/document'
+require "rexml/document"
 
 module Artifactory
   class Resource::LDAPSetting < Resource::Base
@@ -33,7 +33,7 @@ module Artifactory
       #
       def all(options = {})
         config = Resource::System.configuration(options)
-        list_from_config('config/security/ldapSettings/ldapSetting', config, options)
+        list_from_config("config/security/ldapSettings/ldapSetting", config, options)
       end
 
       #
@@ -63,6 +63,7 @@ module Artifactory
       end
 
       private
+
       #
       # List all the child text elements in the Artifactory configuration file
       # of a node matching the specified xpath
@@ -78,7 +79,7 @@ module Artifactory
       #
       def list_from_config(xpath, config, options = {})
         REXML::XPath.match(config, xpath).map do |r|
-          hash = Util.xml_to_hash(r, 'search')
+          hash = Util.xml_to_hash(r, "search")
           from_hash(hash, options)
         end
       end
@@ -99,7 +100,7 @@ module Artifactory
       def find_from_config(xpath, config, options = {})
         name_node = REXML::XPath.match(config, xpath)
         return nil if name_node.empty?
-        properties = Util.xml_to_hash(name_node[0].parent, 'search')
+        properties = Util.xml_to_hash(name_node[0].parent, "search")
         from_hash(properties, options)
       end
     end
@@ -107,7 +108,7 @@ module Artifactory
     # Ordered to match the artifactory xsd to make consuming the attributes
     # hash when writing artifactory xml more convenient.
     # http://bit.ly/UHMrHc
-    attribute :key, ->{ raise 'name missing!' }
+    attribute :key, -> { raise "name missing!" }
     attribute :enabled, true
     attribute :ldap_url
     attribute :search_filter
@@ -116,6 +117,6 @@ module Artifactory
     attribute :manager_dn
     attribute :manager_password
     attribute :auto_create_user
-    attribute :email_attribute, 'mail'
+    attribute :email_attribute, "mail"
   end
 end

data/lib/artifactory/resources/mail_server.rb

@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-require 'rexml/document'
+require "rexml/document"
 
 module Artifactory
   class Resource::MailServer < Resource::Base
@@ -33,7 +33,7 @@ module Artifactory
       #
       def all(options = {})
         config = Resource::System.configuration(options)
-        list_from_config('config/mailServer', config, options)
+        list_from_config("config/mailServer", config, options)
       end
 
       #
@@ -64,7 +64,7 @@ module Artifactory
     end
 
     attribute :enabled
-    attribute :host, ->{ raise 'host missing!' }
+    attribute :host, -> { raise "host missing!" }
     attribute :port
     attribute :username
     attribute :password

data/lib/artifactory/resources/permission_target.rb

@@ -1,11 +1,11 @@
 module Artifactory
   class Resource::PermissionTarget < Resource::Base
     VERBOSE_PERMS = {
-      'd' => 'delete',
-      'm' => 'admin',
-      'n' => 'annotate',
-      'r' => 'read',
-      'w' => 'deploy',
+      "d" => "delete",
+      "m" => "admin",
+      "n" => "annotate",
+      "r" => "read",
+      "w" => "deploy",
     }
     class << self
       #
@@ -22,8 +22,8 @@ module Artifactory
       #
       def all(options = {})
         client = extract_client!(options)
-        client.get('/api/security/permissions').map do |hash|
-          from_url(hash['uri'], client: client)
+        client.get("/api/security/permissions").map do |hash|
+          from_url(hash["uri"], client: client)
         end
       end
 
@@ -61,7 +61,7 @@ module Artifactory
       #
       def from_hash(hash, options = {})
         super.tap do |instance|
-          %w(users groups).each do |key|
+          %w{users groups}.each do |key|
             if instance.principals[key] && !instance.principals[key].nil?
               instance.principals[key] = Hash[instance.principals[key].map { |k, v| [k, verbose(v)] } ]
             end
@@ -93,7 +93,7 @@ module Artifactory
       # @return [Hash]
       #
       def to_abbreviated
-        { 'users' => abbreviate_principal(@users), 'groups' => abbreviate_principal(@groups) }
+        { "users" => abbreviate_principal(@users), "groups" => abbreviate_principal(@groups) }
       end
 
       private
@@ -103,7 +103,7 @@ module Artifactory
       #
       def abbreviate_permissions(array)
         inverse = VERBOSE_PERMS.invert
-        if (inverse.keys & array).sort != array.sort then
+        if (inverse.keys & array).sort != array.sort
           raise "One of your principals contains an invalid permission.  Valid permissions are #{inverse.keys.join(', ')}"
         end
         array.map { |elt| inverse[elt] }.sort
@@ -117,14 +117,14 @@ module Artifactory
       end
     end
 
-    attribute :name, ->{ raise 'Name missing!' }
-    attribute :includes_pattern, '**'
-    attribute :excludes_pattern, ''
+    attribute :name, -> { raise "Name missing!" }
+    attribute :includes_pattern, "**"
+    attribute :excludes_pattern, ""
     attribute :repositories
-    attribute :principals, { 'users' => {}, 'groups' => {} }
+    attribute :principals, { "users" => {}, "groups" => {} }
 
     def client_principal
-      @client_principal ||= Principal.new(principals['users'], principals['groups'])
+      @client_principal ||= Principal.new(principals["users"], principals["groups"])
     end
 
     #
@@ -136,9 +136,9 @@ module Artifactory
     #
     def delete
       client.delete(api_path)
-        true
-      rescue Error::HTTPError
-        false
+      true
+    rescue Error::HTTPError
+      false
     end
 
     #
@@ -148,7 +148,7 @@ module Artifactory
     # @return [Boolean]
     #
     def save
-      send("#{:principals}=", client_principal.to_abbreviated)
+      send("principals=", client_principal.to_abbreviated)
       client.put(api_path, to_json, headers)
       true
     end
@@ -199,7 +199,7 @@ module Artifactory
     #
     def headers
       @headers ||= {
-        'Content-Type' => 'application/vnd.org.jfrog.artifactory.security.PermissionTarget+json'
+        "Content-Type" => "application/vnd.org.jfrog.artifactory.security.PermissionTarget+json",
       }
     end
   end

data/lib/artifactory/resources/plugin.rb

@@ -31,7 +31,7 @@ module Artifactory
       #
       def all(options = {})
         client = extract_client!(options)
-        client.get('/api/plugins')
+        client.get("/api/plugins")
       end
     end
   end

data/lib/artifactory/resources/repository.rb

@@ -31,8 +31,8 @@ module Artifactory
       #
       def all(options = {})
         client = extract_client!(options)
-        client.get('/api/repositories').map do |hash|
-          find(hash['key'], client: client)
+        client.get("/api/repositories").map do |hash|
+          find(hash["key"], client: client)
         end.compact
       end
 
@@ -67,21 +67,21 @@ module Artifactory
 
     attribute :blacked_out, false
     attribute :description
-    attribute :checksum_policy_type, 'client-checksums'
-    attribute :excludes_pattern, ''
+    attribute :checksum_policy_type, "client-checksums"
+    attribute :excludes_pattern, ""
     attribute :handle_releases, true
     attribute :handle_snapshots, true
-    attribute :includes_pattern, '**/*'
-    attribute :key, ->{ raise 'Key is missing!' }
+    attribute :includes_pattern, "**/*"
+    attribute :key, -> { raise "Key is missing!" }
     attribute :max_unique_snapshots, 0
     attribute :notes
-    attribute :package_type, 'generic'
+    attribute :package_type, "generic"
     attribute :property_sets, []
-    attribute :repo_layout_ref, 'simple-default'
-    attribute :rclass, 'local'
-    attribute :snapshot_version_behavior, 'non-unique'
+    attribute :repo_layout_ref, "simple-default"
+    attribute :rclass, "local"
+    attribute :snapshot_version_behavior, "non-unique"
     attribute :suppress_pom_consistency_checks, false
-    attribute :url, ''
+    attribute :url, ""
     attribute :yum_root_depth, 0
     attribute :calculate_yum_metadata, false
 
@@ -154,7 +154,7 @@ module Artifactory
     #
     def artifacts
       @artifacts ||= Collection::Artifact.new(self, repos: key) do
-        Resource::Artifact.search(name: '.*', repos: key)
+        Resource::Artifact.search(name: ".*", repos: key)
       end
     end
 
@@ -169,7 +169,7 @@ module Artifactory
         includeRootPath: 0,
       })
 
-      response['children']
+      response["children"]
     end
 
     #
@@ -204,7 +204,7 @@ module Artifactory
     #
     def headers
       @headers ||= {
-        'Content-Type' => content_type
+        "Content-Type" => content_type,
       }
     end
 
@@ -216,12 +216,12 @@ module Artifactory
     #
     def content_type
       case rclass.to_s.downcase
-      when 'local'
-        'application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json'
-      when 'remote'
-        'application/vnd.org.jfrog.artifactory.repositories.RemoteRepositoryConfiguration+json'
-      when 'virtual'
-        'application/vnd.org.jfrog.artifactory.repositories.VirtualRepositoryConfiguration+json'
+      when "local"
+        "application/vnd.org.jfrog.artifactory.repositories.LocalRepositoryConfiguration+json"
+      when "remote"
+        "application/vnd.org.jfrog.artifactory.repositories.RemoteRepositoryConfiguration+json"
+      when "virtual"
+        "application/vnd.org.jfrog.artifactory.repositories.VirtualRepositoryConfiguration+json"
       else
         raise "Unknown Repository type `#{rclass}'!"
       end

data/lib/artifactory/resources/system.rb

@@ -34,7 +34,7 @@ module Artifactory
       #
       def info(options = {})
         client = extract_client!(options)
-        client.get('/api/system')
+        client.get("/api/system")
       end
 
       #
@@ -59,7 +59,7 @@ module Artifactory
       #
       def ping(options = {})
         client = extract_client!(options)
-        !!client.get('/api/system/ping')
+        !!client.get("/api/system/ping")
       rescue Error::ConnectionError
         false
       end
@@ -81,7 +81,7 @@ module Artifactory
       #
       def configuration(options = {})
         client   = extract_client!(options)
-        response = client.get('/api/system/configuration')
+        response = client.get("/api/system/configuration")
 
         REXML::Document.new(response)
       end
@@ -106,8 +106,8 @@ module Artifactory
 
         # The Artifactory api requires a content type of 'application/xml'.
         # See http://bit.ly/1l2IvZY
-        headers = { 'Content-Type' => 'application/xml' }
-        client.post('/api/system/configuration', xml, headers)
+        headers = { "Content-Type" => "application/xml" }
+        client.post("/api/system/configuration", xml, headers)
       end
 
       #
@@ -127,7 +127,7 @@ module Artifactory
       #
       def version(options = {})
         client = extract_client!(options)
-        client.get('/api/system/version')
+        client.get("/api/system/version")
       end
     end
   end

data/lib/artifactory/resources/url_base.rb

@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-require 'rexml/document'
+require "rexml/document"
 
 module Artifactory
   class Resource::URLBase < Resource::Base
@@ -33,7 +33,7 @@ module Artifactory
       #
       def all(options = {})
         config = Resource::System.configuration(options)
-        simple_text_from_config('config/urlBase', config, options)
+        simple_text_from_config("config/urlBase", config, options)
       end
 
       #
@@ -63,6 +63,7 @@ module Artifactory
       end
 
       private
+
       #
       # List all the text elements in the Artifactory configuration file
       # matching the given xpath.  Ignore any children of elements that match the xpath.
@@ -85,6 +86,6 @@ module Artifactory
       end
     end
 
-    attribute :url_base, ->{ raise 'URL base missing!' }
+    attribute :url_base, -> { raise "URL base missing!" }
   end
 end

data/lib/artifactory/resources/user.rb

@@ -31,8 +31,8 @@ module Artifactory
       #
       def all(options = {})
         client = extract_client!(options)
-        client.get('/api/security/users').map do |hash|
-          from_url(hash['uri'], client: client)
+        client.get("/api/security/users").map do |hash|
+          from_url(hash["uri"], client: client)
         end
       end
 
@@ -70,7 +70,7 @@ module Artifactory
     attribute :groups, []
     attribute :internal_password_disabled, false
     attribute :last_logged_in
-    attribute :name, -> { raise 'Name missing' }
+    attribute :name, -> { raise "Name missing" }
     attribute :password # write only, never returned
     attribute :profile_updatable, true
     attribute :realm
@@ -122,7 +122,7 @@ module Artifactory
     #
     def headers
       @headers ||= {
-        'Content-Type' => 'application/vnd.org.jfrog.artifactory.security.User+json'
+        "Content-Type" => "application/vnd.org.jfrog.artifactory.security.User+json",
       }
     end
   end

data/lib/artifactory/util.rb

@@ -30,10 +30,10 @@ module Artifactory
     def underscore(string)
       string
         .to_s
-        .gsub(/::/, '/')
-        .gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2')
-        .gsub(/([a-z\d])([A-Z])/,'\1_\2')
-        .tr('-', '_')
+        .gsub(/::/, "/")
+        .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
+        .gsub(/([a-z\d])([A-Z])/, '\1_\2')
+        .tr("-", "_")
         .downcase
     end
 
@@ -48,12 +48,12 @@ module Artifactory
     def camelize(string, lowercase = false)
       result = string
         .to_s
-        .split('_')
+        .split("_")
         .map { |e| e.capitalize }
         .join
 
       if lowercase
-        result[0,1].downcase + result[1..-1]
+        result[0, 1].downcase + result[1..-1]
       else
         result
       end
@@ -71,7 +71,7 @@ module Artifactory
       length = options[:length] || 30
 
       if string.length > length
-        string[0..length-3] + '...'
+        string[0..length - 3] + "..."
       else
         string
       end
@@ -119,7 +119,7 @@ module Artifactory
     # @param [REXML] element
     #   xml element
     #
-    def xml_to_hash(element, child_with_children = '', unique_children = true)
+    def xml_to_hash(element, child_with_children = "", unique_children = true)
       properties = {}
       element.each_element_with_text do |e|
         if e.name.eql?(child_with_children)
@@ -141,8 +141,8 @@ module Artifactory
     end
 
     def to_type(string)
-      return true if string.eql?('true')
-      return false if string.eql?('false')
+      return true if string.eql?("true")
+      return false if string.eql?("false")
       return string.to_i if numeric?(string)
       return string
     end