artifactory 2.5.2 → 2.6.0

data/spec/integration/resources/repository_spec.rb

@@ -1,38 +1,38 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::Repository, :integration do
-    describe '.all' do
-      it 'returns an array of repository objects' do
+    describe ".all" do
+      it "returns an array of repository objects" do
         results = described_class.all
         expect(results).to be_a(Array)
         expect(results.first).to be_a(described_class)
       end
     end
 
-    describe '.find' do
-      it 'finds a repository by key' do
-        repository = described_class.find('libs-snapshots-local')
+    describe ".find" do
+      it "finds a repository by key" do
+        repository = described_class.find("libs-snapshots-local")
 
         expect(repository).to be_a(described_class)
-        expect(repository.key).to eq('libs-snapshots-local')
+        expect(repository.key).to eq("libs-snapshots-local")
         expect(repository.max_unique_snapshots).to eq(10)
-        expect(repository.package_type).to eql('generic')
+        expect(repository.package_type).to eql("generic")
       end
 
-      it 'finds debian repositories' do
-        repo = 'libs-debian-local'
+      it "finds debian repositories" do
+        repo = "libs-debian-local"
 
         repository = described_class.find(repo)
 
-        expect(repository.package_type).to eql('debian')
+        expect(repository.package_type).to eql("debian")
         expect(repository.key).to eql(repo)
       end
     end
 
-    describe '#save' do
-      it 'saves the repository to the server' do
-        repository = described_class.new(key: 'libs-testing-local')
+    describe "#save" do
+      it "saves the repository to the server" do
+        repository = described_class.new(key: "libs-testing-local")
         expect(repository.save).to be_truthy
       end
     end

data/spec/integration/resources/system_spec.rb

@@ -1,29 +1,29 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::System, :integration do
-    describe '.info' do
-      it 'gets the system information' do
-        expect(described_class.info).to eq('This is some serious system info right here')
+    describe ".info" do
+      it "gets the system information" do
+        expect(described_class.info).to eq("This is some serious system info right here")
       end
     end
 
-    describe '.ping' do
-      it 'returns ok' do
+    describe ".ping" do
+      it "returns ok" do
         expect(described_class.ping).to be_truthy
       end
     end
 
-    describe '.configuration' do
-      it 'returns the system configuration' do
+    describe ".configuration" do
+      it "returns the system configuration" do
         expect(described_class.configuration).to be_a(REXML::Document)
       end
     end
 
-    describe '.update_configuration' do
-      let(:tempfile) { Tempfile.new(['config', 'xml']) }
+    describe ".update_configuration" do
+      let(:tempfile) { Tempfile.new(%w{config xml}) }
       let(:content) do
-        <<-EOH.strip.gsub(/^ {10}/, '')
+        <<-EOH.strip.gsub(/^ {10}/, "")
           <?xml version='1.0' encoding='UTF-8' standalone='yes'?>
           <newConfig>true</newConfig>
         EOH
@@ -34,7 +34,7 @@ module Artifactory
         tempfile.unlink
       end
 
-      it 'posts the new configuration to the server' do
+      it "posts the new configuration to the server" do
         tempfile.write(content)
         tempfile.rewind
 
@@ -42,16 +42,15 @@ module Artifactory
       end
     end
 
-    describe '.version' do
-      it 'gets the version information' do
+    describe ".version" do
+      it "gets the version information" do
         expect(described_class.version).to eq({
-          'version' => '3.1.0',
-          'revision' => '30062',
-          'addons' => [
-            'ldap',
-            'license',
-            'yum'
-          ]
+          "version" => "3.1.0",
+          "revision" => "30062",
+          "addons" => %w{
+ldap
+license
+yum},
         })
       end
     end

data/spec/integration/resources/url_base_spec.rb

@@ -1,21 +1,21 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::URLBase, :integration do
-    describe '.all' do
-      it 'returns an array of UrlBases' do
+    describe ".all" do
+      it "returns an array of UrlBases" do
         results = described_class.all
         expect(results).to be_a(Array)
         expect(results.first).to be_a(described_class)
       end
     end
 
-    describe '.find' do
-      it 'finds a urlBase by url' do
-        base = described_class.find('http://33.33.33.20/artifactory')
+    describe ".find" do
+      it "finds a urlBase by url" do
+        base = described_class.find("http://33.33.33.20/artifactory")
 
         expect(base).to be_a(described_class)
-        expect(base.url_base).to eq('http://33.33.33.20/artifactory')
+        expect(base.url_base).to eq("http://33.33.33.20/artifactory")
       end
     end
   end

data/spec/integration/resources/user_spec.rb

@@ -1,43 +1,43 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::User, :integration do
-    describe '.all' do
-      it 'returns an array of user objects' do
+    describe ".all" do
+      it "returns an array of user objects" do
         results = described_class.all
         expect(results).to be_a(Array)
         expect(results.first).to be_a(described_class)
       end
 
-      it 'includes the information from the server' do
+      it "includes the information from the server" do
         results = described_class.all
         seth    = results[0]
         yvonne  = results[1]
 
-        expect(seth.name).to eq('sethvargo')
-        expect(yvonne.name).to eq('yzl')
+        expect(seth.name).to eq("sethvargo")
+        expect(yvonne.name).to eq("yzl")
       end
     end
 
-    describe '.find' do
-      it 'finds a user by name' do
-        seth = described_class.find('sethvargo')
+    describe ".find" do
+      it "finds a user by name" do
+        seth = described_class.find("sethvargo")
 
         expect(seth).to be_a(described_class)
-        expect(seth.name).to eq('sethvargo')
+        expect(seth.name).to eq("sethvargo")
       end
     end
 
-    describe '#delete' do
-      it 'deletes the user from the server' do
-        sethvargo = described_class.find('sethvargo')
+    describe "#delete" do
+      it "deletes the user from the server" do
+        sethvargo = described_class.find("sethvargo")
         expect(sethvargo.delete).to be_truthy
       end
     end
 
-    describe '#save' do
-      it 'saves the user to the server' do
-        user = described_class.new(name: 'schisamo')
+    describe "#save" do
+      it "saves the user to the server" do
+        user = described_class.new(name: "schisamo")
         expect(user.save).to be_truthy
       end
     end

data/spec/spec_helper.rb

@@ -1,12 +1,12 @@
-require 'bundler/setup'
-require 'rspec'
-require 'webmock/rspec'
+require "bundler/setup"
+require "rspec"
+require "webmock/rspec"
 
-if ENV['COVERAGE']
-  require 'simplecov'
-  require 'simplecov-console'
+if ENV["COVERAGE"]
+  require "simplecov"
+  require "simplecov-console"
   SimpleCov.start do
-    add_filter 'spec/'
+    add_filter "spec/"
     formatter SimpleCov::Formatter::MultiFormatter.new [
       SimpleCov::Formatter::HTMLFormatter,
       SimpleCov::Formatter::Console,
@@ -15,10 +15,10 @@ if ENV['COVERAGE']
 end
 
 # Require our main library
-require 'artifactory'
+require "artifactory"
 
 # Require helpers
-require_relative 'support/api_server'
+require_relative "support/api_server"
 
 RSpec.configure do |config|
   # Custom helper modules and extensions
@@ -38,7 +38,7 @@ RSpec.configure do |config|
   config.after(:each)  { Artifactory.reset! }
 
   config.before(:each, :integration) do
-    Artifactory.endpoint = 'http://localhost:8889'
+    Artifactory.endpoint = "http://localhost:8889"
     Artifactory.username = nil
     Artifactory.password = nil
     stub_request(:any, /#{Artifactory.endpoint}/).to_rack(Artifactory::APIServer)
@@ -48,5 +48,5 @@ RSpec.configure do |config|
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = 'random'
+  config.order = "random"
 end

data/spec/support/api_server.rb

@@ -1,4 +1,4 @@
-require 'sinatra/base'
+require "sinatra/base"
 
 module Artifactory
   #
@@ -6,15 +6,15 @@ module Artifactory
   # fake, but it is based off of real responses from the Artifactory server.
   #
   class APIServer < Sinatra::Base
-    require_relative 'api_server/artifact_endpoints'
-    require_relative 'api_server/build_component_endpoints'
-    require_relative 'api_server/build_endpoints'
-    require_relative 'api_server/group_endpoints'
-    require_relative 'api_server/repository_endpoints'
-    require_relative 'api_server/permission_target_endpoints'
-    require_relative 'api_server/status_endpoints'
-    require_relative 'api_server/system_endpoints'
-    require_relative 'api_server/user_endpoints'
+    require_relative "api_server/artifact_endpoints"
+    require_relative "api_server/build_component_endpoints"
+    require_relative "api_server/build_endpoints"
+    require_relative "api_server/group_endpoints"
+    require_relative "api_server/repository_endpoints"
+    require_relative "api_server/permission_target_endpoints"
+    require_relative "api_server/status_endpoints"
+    require_relative "api_server/system_endpoints"
+    require_relative "api_server/user_endpoints"
 
     register APIServer::ArtifactEndpoints
     register APIServer::BuildComponentEndpoints
@@ -38,9 +38,9 @@ module Artifactory
     #
     def server_url
       @server_url ||= begin
-        scheme  = request.env['rack.url_scheme']
-        address = request.env['SERVER_NAME']
-        port    = request.env['SERVER_PORT']
+        scheme  = request.env["rack.url_scheme"]
+        address = request.env["SERVER_NAME"]
+        port    = request.env["SERVER_PORT"]
 
         Pathname.new("#{scheme}://#{address}:#{port}")
       end

data/spec/support/api_server/artifact_endpoints.rb

@@ -1,156 +1,156 @@
 module Artifactory
   module APIServer::ArtifactEndpoints
     def self.registered(app)
-      app.get('/api/search/artifact') do
-        content_type 'application/vnd.org.jfrog.artifactory.search.ArtifactSearchResult+json'
+      app.get("/api/search/artifact") do
+        content_type "application/vnd.org.jfrog.artifactory.search.ArtifactSearchResult+json"
         artifacts_for_conditions do
-          params['name'] == 'artifact.deb'
+          params["name"] == "artifact.deb"
         end
       end
 
-      app.get('/api/search/gavc') do
-        content_type 'application/vnd.org.jfrog.artifactory.search.GavcSearchResult+json'
+      app.get("/api/search/gavc") do
+        content_type "application/vnd.org.jfrog.artifactory.search.GavcSearchResult+json"
         artifacts_for_conditions do
-          params['g'] == 'org.acme' &&
-          params['a'] == 'artifact.deb' &&
-          params['v'] == '1.0' &&
-          params['c'] == 'sources'
+          params["g"] == "org.acme" &&
+            params["a"] == "artifact.deb" &&
+            params["v"] == "1.0" &&
+            params["c"] == "sources"
         end
       end
 
-      app.get('/api/search/prop') do
-        content_type 'application/vnd.org.jfrog.artifactory.search.MetadataSearchResult+json'
+      app.get("/api/search/prop") do
+        content_type "application/vnd.org.jfrog.artifactory.search.MetadataSearchResult+json"
         artifacts_for_conditions do
-          params['branch'] == 'master' && params['committer'] == 'Seth Vargo'
+          params["branch"] == "master" && params["committer"] == "Seth Vargo"
         end
       end
 
-      app.get('/api/search/checksum') do
-        content_type 'application/vnd.org.jfrog.artifactory.search.ChecksumSearchResult+json'
+      app.get("/api/search/checksum") do
+        content_type "application/vnd.org.jfrog.artifactory.search.ChecksumSearchResult+json"
         artifacts_for_conditions do
-          params['md5'] == 'abcd1234'
+          params["md5"] == "abcd1234"
         end
       end
 
-      app.get('/api/search/usage') do
-        content_type 'application/vnd.org.jfrog.artifactory.search.ArtifactUsageResult+json'
+      app.get("/api/search/usage") do
+        content_type "application/vnd.org.jfrog.artifactory.search.ArtifactUsageResult+json"
         artifacts_for_conditions do
-          params['notUsedSince'] == '1414800000'
+          params["notUsedSince"] == "1414800000"
         end
       end
 
-      app.get('/api/search/creation') do
-        content_type 'application/vnd.org.jfrog.artifactory.search.ArtifactCreationResult+json'
+      app.get("/api/search/creation") do
+        content_type "application/vnd.org.jfrog.artifactory.search.ArtifactCreationResult+json"
         artifacts_for_conditions do
-          params['from'] == '1414800000'
+          params["from"] == "1414800000"
         end
       end
 
-      app.get('/api/search/versions') do
-        content_type 'application/vnd.org.jfrog.artifactory.search.ArtifactVersionsResult+json'
+      app.get("/api/search/versions") do
+        content_type "application/vnd.org.jfrog.artifactory.search.ArtifactVersionsResult+json"
         JSON.fast_generate(
-          'results' => [
-            { 'version' => '1.2',          'integration' => false },
-            { 'version' => '1.0-SNAPSHOT', 'integration' => true  },
-            { 'version' => '1.0',          'integration' => false },
+          "results" => [
+            { "version" => "1.2",          "integration" => false },
+            { "version" => "1.0-SNAPSHOT", "integration" => true  },
+            { "version" => "1.0",          "integration" => false },
           ]
         )
       end
 
-      app.get('/api/search/latestVersion') do
-        '1.0-201203131455-2'
+      app.get("/api/search/latestVersion") do
+        "1.0-201203131455-2"
       end
 
-      app.get('/api/storage/libs-release-local/org/acme/artifact.deb') do
-        content_type 'application/vnd.org.jfrog.artifactory.storage.FileInfo+json'
+      app.get("/api/storage/libs-release-local/org/acme/artifact.deb") do
+        content_type "application/vnd.org.jfrog.artifactory.storage.FileInfo+json"
         JSON.fast_generate(
-          'uri'          => server_url.join('/api/storage/libs-release-local/org/acme/artifact.deb'),
-          'downloadUri'  => server_url.join('/artifactory/libs-release-local/org/acme/artifact.deb'),
-          'repo'         => 'libs-release-local',
-          'path'         => '/org/acme/artifact.deb',
-          'created'      => Time.parse('1991-07-23 12:07am'),
-          'createdBy'    => 'schisamo',
-          'lastModified' => Time.parse('2013-12-24 11:50pm'),
-          'modifiedBy'   => 'sethvargo',
-          'lastUpdated'  => Time.parse('2014-01-01 1:00pm'),
-          'size'         => '1024',
-          'mimeType'     => 'application/tgz',
-          'checksums'    => {
-            'md5' => 'MD5123',
-            'sha' => 'SHA456'
+          "uri"          => server_url.join("/api/storage/libs-release-local/org/acme/artifact.deb"),
+          "downloadUri"  => server_url.join("/artifactory/libs-release-local/org/acme/artifact.deb"),
+          "repo"         => "libs-release-local",
+          "path"         => "/org/acme/artifact.deb",
+          "created"      => Time.parse("1991-07-23 12:07am"),
+          "createdBy"    => "schisamo",
+          "lastModified" => Time.parse("2013-12-24 11:50pm"),
+          "modifiedBy"   => "sethvargo",
+          "lastUpdated"  => Time.parse("2014-01-01 1:00pm"),
+          "size"         => "1024",
+          "mimeType"     => "application/tgz",
+          "checksums"    => {
+            "md5" => "MD5123",
+            "sha" => "SHA456",
           },
-          'originalChecksums' => {
-            'md5' => 'MD5123',
-            'sha' => 'SHA456'
+          "originalChecksums" => {
+            "md5" => "MD5123",
+            "sha" => "SHA456",
           }
         )
       end
 
-      app.get('/api/storage/ext-release-local/org/acme/artifact.deb') do
-        content_type 'application/vnd.org.jfrog.artifactory.storage.FileInfo+json'
+      app.get("/api/storage/ext-release-local/org/acme/artifact.deb") do
+        content_type "application/vnd.org.jfrog.artifactory.storage.FileInfo+json"
         JSON.fast_generate(
-          'uri'          => server_url.join('/api/storage/ext-release-local/org/acme/artifact.deb'),
-          'downloadUri'  => server_url.join('/artifactory/ext-release-local/org/acme/artifact.deb'),
-          'repo'         => 'ext-release-local',
-          'path'         => '/org/acme/artifact.deb',
-          'created'      => Time.parse('1995-04-11 11:05am'),
-          'createdBy'    => 'yzl',
-          'lastModified' => Time.parse('2013-11-10 10:10pm'),
-          'modifiedBy'   => 'schisamo',
-          'lastUpdated'  => Time.parse('2014-02-02 2:00pm'),
-          'size'         => '1024',
-          'mimeType'     => 'application/tgz',
-          'checksums'    => {
-            'md5' => 'MD5789',
-            'sha' => 'SHA101'
+          "uri"          => server_url.join("/api/storage/ext-release-local/org/acme/artifact.deb"),
+          "downloadUri"  => server_url.join("/artifactory/ext-release-local/org/acme/artifact.deb"),
+          "repo"         => "ext-release-local",
+          "path"         => "/org/acme/artifact.deb",
+          "created"      => Time.parse("1995-04-11 11:05am"),
+          "createdBy"    => "yzl",
+          "lastModified" => Time.parse("2013-11-10 10:10pm"),
+          "modifiedBy"   => "schisamo",
+          "lastUpdated"  => Time.parse("2014-02-02 2:00pm"),
+          "size"         => "1024",
+          "mimeType"     => "application/tgz",
+          "checksums"    => {
+            "md5" => "MD5789",
+            "sha" => "SHA101",
           },
-          'originalChecksums' => {
-            'md5' => 'MD5789',
-            'sha' => 'SHA101'
+          "originalChecksums" => {
+            "md5" => "MD5789",
+            "sha" => "SHA101",
           }
         )
       end
 
-      app.get('/api/storage/bin-release-local/org/acme/artifact 1.0.0.msi') do
-        content_type 'application/vnd.org.jfrog.artifactory.storage.FileInfo+json'
+      app.get("/api/storage/bin-release-local/org/acme/artifact 1.0.0.msi") do
+        content_type "application/vnd.org.jfrog.artifactory.storage.FileInfo+json"
         JSON.fast_generate(
-          'uri'          => server_url.join('/api/storage/bin-release-local/org/acme/artifact 1.0.0.msi'),
-          'downloadUri'  => server_url.join('/artifactory/bin-release-local/org/acme/artifact 1.0.0.msi'),
-          'repo'         => 'bin-release-local',
-          'path'         => '/org/acme/artifact 1.0.0.msi',
-          'created'      => Time.parse('1995-04-11 11:05am'),
-          'createdBy'    => 'yzl',
-          'lastModified' => Time.parse('2013-11-10 10:10pm'),
-          'modifiedBy'   => 'schisamo',
-          'lastUpdated'  => Time.parse('2014-02-02 2:00pm'),
-          'size'         => '1024',
-          'mimeType'     => 'application/octet-stream',
-          'checksums'    => {
-            'md5' => 'MD5789',
-            'sha' => 'SHA101'
+          "uri"          => server_url.join("/api/storage/bin-release-local/org/acme/artifact 1.0.0.msi"),
+          "downloadUri"  => server_url.join("/artifactory/bin-release-local/org/acme/artifact 1.0.0.msi"),
+          "repo"         => "bin-release-local",
+          "path"         => "/org/acme/artifact 1.0.0.msi",
+          "created"      => Time.parse("1995-04-11 11:05am"),
+          "createdBy"    => "yzl",
+          "lastModified" => Time.parse("2013-11-10 10:10pm"),
+          "modifiedBy"   => "schisamo",
+          "lastUpdated"  => Time.parse("2014-02-02 2:00pm"),
+          "size"         => "1024",
+          "mimeType"     => "application/octet-stream",
+          "checksums"    => {
+            "md5" => "MD5789",
+            "sha" => "SHA101",
           },
-          'originalChecksums' => {
-            'md5' => 'MD5789',
-            'sha' => 'SHA101'
+          "originalChecksums" => {
+            "md5" => "MD5789",
+            "sha" => "SHA101",
           }
         )
       end
 
       app.class_eval do
         def artifacts_for_conditions(&block)
-          if block.call
-            if params['repos'] == 'libs-release-local'
+          if yield
+            if params["repos"] == "libs-release-local"
               JSON.fast_generate(
-                'results' => [
-                  { 'uri' => server_url.join('/api/storage/libs-release-local/org/acme/artifact.deb') },
+                "results" => [
+                  { "uri" => server_url.join("/api/storage/libs-release-local/org/acme/artifact.deb") },
                 ]
               )
             else
               JSON.fast_generate(
-                'results' => [
-                  { 'uri' => server_url.join('/api/storage/libs-release-local/org/acme/artifact.deb') },
-                  { 'uri' => server_url.join('/api/storage/ext-release-local/org/acme/artifact.deb') },
-                  { 'uri' => server_url.join('/api/storage/bin-release-local/org/acme/artifact 1.0.0.msi') },
+                "results" => [
+                  { "uri" => server_url.join("/api/storage/libs-release-local/org/acme/artifact.deb") },
+                  { "uri" => server_url.join("/api/storage/ext-release-local/org/acme/artifact.deb") },
+                  { "uri" => server_url.join("/api/storage/bin-release-local/org/acme/artifact 1.0.0.msi") },
                 ]
               )
             end