artifactory 2.5.2 → 2.6.0

data/spec/unit/resources/plugin_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::Plugin do
@@ -9,16 +9,16 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.all' do
-      let(:response) { ['a', 'b', 'c'] }
+    describe ".all" do
+      let(:response) { %w{a b c} }
 
-      it 'gets /api/plugins' do
-        expect(client).to receive(:get).with('/api/plugins').once
+      it "gets /api/plugins" do
+        expect(client).to receive(:get).with("/api/plugins").once
         described_class.all
       end
 
-      it 'returns the plugins' do
-        expect(described_class.all).to eq(['a', 'b', 'c'])
+      it "returns the plugins" do
+        expect(described_class.all).to eq(%w{a b c})
       end
     end
   end

data/spec/unit/resources/repository_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::Repository do
@@ -9,208 +9,208 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.all' do
+    describe ".all" do
       let(:response) do
         [
-          { 'key' => 'a' },
-          { 'key' => 'b' },
-          { 'key' => 'c' },
+          { "key" => "a" },
+          { "key" => "b" },
+          { "key" => "c" },
         ]
       end
       before do
-        allow(described_class).to receive(:find).with('a', client: client).and_return('a')
-        allow(described_class).to receive(:find).with('b', client: client).and_return('b')
-        allow(described_class).to receive(:find).with('c', client: client).and_return('c')
+        allow(described_class).to receive(:find).with("a", client: client).and_return("a")
+        allow(described_class).to receive(:find).with("b", client: client).and_return("b")
+        allow(described_class).to receive(:find).with("c", client: client).and_return("c")
       end
 
-      it 'gets /api/repositories' do
-        expect(client).to receive(:get).with('/api/repositories').once
+      it "gets /api/repositories" do
+        expect(client).to receive(:get).with("/api/repositories").once
         described_class.all
       end
 
-      it 'returns the repositories' do
-        expect(described_class.all).to eq(['a', 'b', 'c'])
+      it "returns the repositories" do
+        expect(described_class.all).to eq(%w{a b c})
       end
     end
 
-    describe '.find' do
+    describe ".find" do
       let(:response) { {} }
 
       it 'gets /api/repositories/#{name}' do
-        expect(client).to receive(:get).with('/api/repositories/libs-release-local').once
-        described_class.find('libs-release-local')
+        expect(client).to receive(:get).with("/api/repositories/libs-release-local").once
+        described_class.find("libs-release-local")
       end
     end
 
-    describe '.from_hash' do
+    describe ".from_hash" do
       let(:hash) do
         {
-          'key'                          => 'libs-release-local',
-          'description'                  => 'Local repository for in-house libraries',
-          'notes'                        => '',
-          'includesPattern'              => '**/*',
-          'excludesPattern'              => '',
-          'enableNuGetSupport'           => false,
-          'enableGemsSupport'            => false,
-          'checksumPolicyType'           => 'server-generated-checksums',
-          'handleReleases'               => true,
-          'handleSnapshots'              => false,
-          'maxUniqueSnapshots'           => 10,
-          'snapshotVersionBehavior'      => 'unique',
-          'suppressPomConsistencyChecks' => true,
-          'blackedOut'                   => false,
-          'propertySets'                 => ['artifactory'],
-          'archiveBrowsingEnabled'       => false,
-          'calculateYumMetadata'         => false,
-          'yumRootDepth'                 => 3,
-          'rclass'                       => 'local',
-          'url'                          => 'someurl',
+          "key"                          => "libs-release-local",
+          "description"                  => "Local repository for in-house libraries",
+          "notes"                        => "",
+          "includesPattern"              => "**/*",
+          "excludesPattern"              => "",
+          "enableNuGetSupport"           => false,
+          "enableGemsSupport"            => false,
+          "checksumPolicyType"           => "server-generated-checksums",
+          "handleReleases"               => true,
+          "handleSnapshots"              => false,
+          "maxUniqueSnapshots"           => 10,
+          "snapshotVersionBehavior"      => "unique",
+          "suppressPomConsistencyChecks" => true,
+          "blackedOut"                   => false,
+          "propertySets"                 => ["artifactory"],
+          "archiveBrowsingEnabled"       => false,
+          "calculateYumMetadata"         => false,
+          "yumRootDepth"                 => 3,
+          "rclass"                       => "local",
+          "url"                          => "someurl",
         }
       end
 
-      it 'creates a new instance' do
+      it "creates a new instance" do
         instance = described_class.from_hash(hash)
         expect(instance.blacked_out).to be_falsey
-        expect(instance.description).to eq('Local repository for in-house libraries')
-        expect(instance.checksum_policy_type).to eq('server-generated-checksums')
-        expect(instance.excludes_pattern).to eq('')
+        expect(instance.description).to eq("Local repository for in-house libraries")
+        expect(instance.checksum_policy_type).to eq("server-generated-checksums")
+        expect(instance.excludes_pattern).to eq("")
         expect(instance.handle_releases).to be_truthy
         expect(instance.handle_snapshots).to be_falsey
-        expect(instance.includes_pattern).to eq('**/*')
-        expect(instance.key).to eq('libs-release-local')
+        expect(instance.includes_pattern).to eq("**/*")
+        expect(instance.key).to eq("libs-release-local")
         expect(instance.max_unique_snapshots).to eq(10)
-        expect(instance.notes).to eq('')
-        expect(instance.package_type).to eq('generic')
-        expect(instance.property_sets).to eq(['artifactory'])
-        expect(instance.rclass).to eq('local')
-        expect(instance.repo_layout_ref).to eq('simple-default')
-        expect(instance.snapshot_version_behavior).to eq('unique')
+        expect(instance.notes).to eq("")
+        expect(instance.package_type).to eq("generic")
+        expect(instance.property_sets).to eq(["artifactory"])
+        expect(instance.rclass).to eq("local")
+        expect(instance.repo_layout_ref).to eq("simple-default")
+        expect(instance.snapshot_version_behavior).to eq("unique")
         expect(instance.suppress_pom_consistency_checks).to be_truthy
-        expect(instance.url).to eq('someurl')
+        expect(instance.url).to eq("someurl")
         expect(instance.yum_root_depth).to eq(3)
         expect(instance.calculate_yum_metadata).to eq(false)
       end
     end
 
-    describe '#save' do
+    describe "#save" do
       let(:client) { double }
       before do
         subject.client = client
-        subject.key = 'libs-release-local'
+        subject.key = "libs-release-local"
       end
 
-      context 'when the repository is new' do
+      context "when the repository is new" do
         before do
           allow(described_class).to receive(:find).with(subject.key, client: client).and_return(nil)
         end
 
-        it 'PUTS the file to the server' do
+        it "PUTS the file to the server" do
           expect(client).to receive(:put).with("/api/repositories/#{subject.key}", kind_of(String), kind_of(Hash))
           subject.save
         end
       end
 
-      context 'when the repository exists' do
+      context "when the repository exists" do
         before do
-          allow(described_class).to receive(:find).with(subject.key, client: client).and_return({key: subject.key})
+          allow(described_class).to receive(:find).with(subject.key, client: client).and_return({ key: subject.key })
         end
 
-        it 'POSTS the file to the server' do
+        it "POSTS the file to the server" do
           expect(client).to receive(:post).with("/api/repositories/#{subject.key}", kind_of(String), kind_of(Hash))
           subject.save
         end
       end
     end
 
-    describe '#upload' do
+    describe "#upload" do
       let(:client) { double(put: {}) }
       let(:file) { double(File) }
-      let(:path) { '/fake/path' }
+      let(:path) { "/fake/path" }
       before do
         subject.client = client
-        subject.key    = 'libs-release-local'
+        subject.key    = "libs-release-local"
         allow(File).to receive(:new).with(/\A(\w:)?#{path}\z/).and_return(file)
       end
 
-      context 'when the artifact is a file path' do
-        it 'PUTs the file at the path to the server' do
-          expect(client).to receive(:put).with('libs-release-local/remote/path', file, {})
+      context "when the artifact is a file path" do
+        it "PUTs the file at the path to the server" do
+          expect(client).to receive(:put).with("libs-release-local/remote/path", file, {})
 
-          subject.upload(path, '/remote/path')
+          subject.upload(path, "/remote/path")
         end
       end
 
-      context 'when matrix properties are given' do
-        it 'converts the hash into matrix properties' do
-          expect(client).to receive(:put).with('libs-release-local;branch=master;user=Seth+Vargo%2B1/remote/path', file, {})
+      context "when matrix properties are given" do
+        it "converts the hash into matrix properties" do
+          expect(client).to receive(:put).with("libs-release-local;branch=master;user=Seth+Vargo%2B1/remote/path", file, {})
 
-          subject.upload(path, '/remote/path',
-            branch: 'master',
-            user: 'Seth Vargo+1',
+          subject.upload(path, "/remote/path",
+            branch: "master",
+            user: "Seth Vargo+1"
           )
         end
 
-        it 'converts the hash into matrix properties' do
-          expect(client).to receive(:put).with('libs-release-local;branch=master;user=Seth/remote/path', file, {})
+        it "converts the hash into matrix properties" do
+          expect(client).to receive(:put).with("libs-release-local;branch=master;user=Seth/remote/path", file, {})
 
-          subject.upload(path, '/remote/path',
-            branch: 'master',
-            user: 'Seth',
+          subject.upload(path, "/remote/path",
+            branch: "master",
+            user: "Seth"
           )
         end
 
         it 'converts spaces to "+" characters' do
-          expect(client).to receive(:put).with('libs-release-local;user=Seth+Vargo/remote/path', file, {})
+          expect(client).to receive(:put).with("libs-release-local;user=Seth+Vargo/remote/path", file, {})
 
-          subject.upload(path, '/remote/path',
-            user: 'Seth Vargo',
+          subject.upload(path, "/remote/path",
+            user: "Seth Vargo"
           )
         end
 
         it 'converts "+" to "%2B"' do
-          expect(client).to receive(:put).with('libs-release-local;version=12.0.0-alpha.1%2B20140826080510.git.50.f5ff271/remote/path', file, {})
+          expect(client).to receive(:put).with("libs-release-local;version=12.0.0-alpha.1%2B20140826080510.git.50.f5ff271/remote/path", file, {})
 
-          subject.upload(path, '/remote/path',
-            version: '12.0.0-alpha.1+20140826080510.git.50.f5ff271',
+          subject.upload(path, "/remote/path",
+            version: "12.0.0-alpha.1+20140826080510.git.50.f5ff271"
           )
         end
       end
 
-      context 'when custom headers are given' do
-        it 'passes the headers to the client' do
-          headers = { 'Content-Type' => 'text/plain' }
-          expect(client).to receive(:put).with('libs-release-local/remote/path', file, headers)
+      context "when custom headers are given" do
+        it "passes the headers to the client" do
+          headers = { "Content-Type" => "text/plain" }
+          expect(client).to receive(:put).with("libs-release-local/remote/path", file, headers)
 
-          subject.upload(path, '/remote/path', {}, headers)
+          subject.upload(path, "/remote/path", {}, headers)
         end
       end
     end
 
-    describe '#artifacts' do
-      before { subject.key = 'libs-release-local' }
+    describe "#artifacts" do
+      before { subject.key = "libs-release-local" }
 
-      it 'returns an artifact collection' do
+      it "returns an artifact collection" do
         expect(subject.artifacts).to be_a(Collection::Artifact)
       end
     end
 
-    describe '#upload_with_checksum' do
-      it 'delecates to artifact' do
-        artifact = double('Artifact')
+    describe "#upload_with_checksum" do
+      it "delecates to artifact" do
+        artifact = double("Artifact")
         allow(Resource::Artifact).to receive(:new) { artifact }
-        subject.key = 'libs-release-local'
+        subject.key = "libs-release-local"
         expect(artifact).to receive(:upload_with_checksum).once
-        subject.upload_with_checksum('/local/path', '/remote/path', 'checksum', {properties: :foobar})
+        subject.upload_with_checksum("/local/path", "/remote/path", "checksum", { properties: :foobar })
       end
     end
 
-    describe '#upload_from_archive' do
-      it 'delecates to artifact' do
-        artifact = double('Artifact')
+    describe "#upload_from_archive" do
+      it "delecates to artifact" do
+        artifact = double("Artifact")
         allow(Resource::Artifact).to receive(:new) { artifact }
-        subject.key = 'libs-release-local'
+        subject.key = "libs-release-local"
         expect(artifact).to receive(:upload_from_archive).once
-        subject.upload_from_archive('/local/path', '/remote/path', {properties: :foobar})
+        subject.upload_from_archive("/local/path", "/remote/path", { properties: :foobar })
       end
     end
   end

data/spec/unit/resources/system_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Artifactory
   describe Resource::System do
@@ -9,35 +9,35 @@ module Artifactory
       allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
-    describe '.info' do
-      let(:response) { 'This is the response...' }
+    describe ".info" do
+      let(:response) { "This is the response..." }
 
-      it 'calls /api/system' do
-        expect(client).to receive(:get).with('/api/system').once
+      it "calls /api/system" do
+        expect(client).to receive(:get).with("/api/system").once
         described_class.info
       end
 
-      it 'returns the plan-text body' do
+      it "returns the plan-text body" do
         expect(described_class.info).to eq(response)
       end
     end
 
-    describe '.ping' do
-      let(:response) { '' }
+    describe ".ping" do
+      let(:response) { "" }
 
-      it 'gets /api/system/ping' do
-        expect(client).to receive(:get).with('/api/system/ping').once
+      it "gets /api/system/ping" do
+        expect(client).to receive(:get).with("/api/system/ping").once
         described_class.ping
       end
 
-      context 'when the system is ok' do
-        it 'returns true' do
+      context "when the system is ok" do
+        it "returns true" do
           expect(described_class.ping).to be_truthy
         end
       end
 
-      context 'when the system is not running' do
-        it 'returns false' do
+      context "when the system is not running" do
+        it "returns false" do
           allow(client).to receive(:get)
             .and_raise(Error::ConnectionError.new(Artifactory.endpoint))
           expect(described_class.ping).to be_falsey
@@ -45,44 +45,44 @@ module Artifactory
       end
     end
 
-    describe '.configuration' do
-      let(:response) { '<config></config>' }
+    describe ".configuration" do
+      let(:response) { "<config></config>" }
 
-      it 'gets /api/system/configuration' do
-        expect(client).to receive(:get).with('/api/system/configuration').once
+      it "gets /api/system/configuration" do
+        expect(client).to receive(:get).with("/api/system/configuration").once
         described_class.configuration
       end
 
-      it 'returns the xml' do
+      it "returns the xml" do
         expect(described_class.configuration).to be_a(REXML::Document)
       end
     end
 
-    describe '.update_configuration' do
+    describe ".update_configuration" do
       let(:xml) { double(:xml) }
-      let(:response) { double(body: '...') }
+      let(:response) { double(body: "...") }
       before { allow(client).to receive(:post).and_return(response) }
 
-      it 'posts /api/system/configuration' do
-        headers = { 'Content-Type' => 'application/xml' }
-        expect(client).to receive(:post).with('/api/system/configuration', xml, headers).once
+      it "posts /api/system/configuration" do
+        headers = { "Content-Type" => "application/xml" }
+        expect(client).to receive(:post).with("/api/system/configuration", xml, headers).once
         described_class.update_configuration(xml)
       end
 
-      it 'returns the body of the response' do
+      it "returns the body of the response" do
         expect(described_class.update_configuration(xml)).to eq(response)
       end
     end
 
-    describe '.version' do
-      let(:response) { double(json: { 'foo' => 'bar' }) }
+    describe ".version" do
+      let(:response) { double(json: { "foo" => "bar" }) }
 
-      it 'gets /api/system/version' do
-        expect(client).to receive(:get).with('/api/system/version').once
+      it "gets /api/system/version" do
+        expect(client).to receive(:get).with("/api/system/version").once
         described_class.version
       end
 
-      it 'returns the parsed JSON of the response' do
+      it "returns the parsed JSON of the response" do
         expect(described_class.version).to eq(response)
       end
     end