alexandria-book-collection-manager 0.7.3 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c5ce199935fd434ee40793e79cf4f8ad31c4f140e26844ae0bad7f6d111d5486
-  data.tar.gz: 76f857b281f0b11c6485d4196b2f47e3980eb4ff8ea7fe89797e7321388f0cf2
+  metadata.gz: 44744940c1b1d1eabd2f062869295dcbd42a67347ebc7390e4150ed406de1768
+  data.tar.gz: c9e295c6171d7f88e118c5c998cf6d6507841e78f7dab2f65ccf1a611a8bdd0d
 SHA512:
-  metadata.gz: 4f49799facc13291bac2d34f82af36fc2cd9461eddf21b0f2cb30fa089517f4f5f2ed41713cba354c72a9143df5273059614969257834836ea604213fe05f47a
-  data.tar.gz: 89ab1a4b55b5df6b1ae9c2ec5f0ebcf82ad79e10208c6ff51572f59ccfa59ebeed51dfecac96b15e4442ffe081c5f717b2491478d3cad870aa1ae9be0012572e
+  metadata.gz: 9791ac87a6456ec74446ac6a8ce2791f2c0b464c4b843ac69dad561a83bacb286716c9fa940d41b15342e9212339aaa85383e0460128823e711fbe935a1b823f
+  data.tar.gz: b1b803f65c8b88fcfd35f50e3e1aebde2677de06343baaa4b57f359aba9cc6803240ff50d66dfc80c6fffbc1c8eae6a37574588365714e0f656cd7c513cddea2

data/.rubocop.yml

@@ -1,18 +1,20 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-performance
+  - rubocop-rspec
+
 AllCops:
   Exclude:
     - 'lib/alexandria/default_preferences.rb'
     - 'pkg/**/*'
-  TargetRubyVersion: 2.3
-
-# Dot at end of line makes it clearer that the line is not done
-Layout/DotPosition:
-  EnforcedStyle: trailing
+  TargetRubyVersion: 2.4
 
-# Multi-line assignment should be simply indented. Aligning them makes it even
-# harder to keep a sane line length.
-Layout/MultilineOperationIndentation:
-  EnforcedStyle: indented
+Layout/AlignHash:
+  EnforcedColonStyle: key
+  EnforcedHashRocketStyle: table
 
+# Don't force lonely closing parentheses
 Layout/MultilineMethodCallBraceLayout:
   EnforcedStyle: same_line
 
@@ -21,14 +23,15 @@ Layout/MultilineMethodCallBraceLayout:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
-# Make syntax for empty and filled blocks consistent
+# Multi-line assignment should be simply indented. Aligning them makes it even
+# harder to keep a sane line length.
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+# Force consistent spacing independent of block contents
 Layout/SpaceBeforeBlockBraces:
   EnforcedStyleForEmptyBraces: space
 
-Layout/AlignHash:
-  EnforcedColonStyle: key
-  EnforcedHashRocketStyle: table
-
 # Allow if (foo = get_foo) style
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
@@ -45,13 +48,13 @@ Metrics/LineLength:
 Naming/AccessorMethodName:
   Enabled: false
 
-# Allow multi-line blocks of all sorts
-Style/BlockDelimiters:
-  Enabled: false
+# Avoid one-letter exception variable name
+Naming/RescuedExceptionsVariableName:
+  PreferredName: ex
 
 # Allow and/or for control flow only
 Style/AndOr:
-  Enabled: conditionals
+  EnforcedStyle: conditionals
 
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
@@ -74,17 +77,19 @@ Style/PercentLiteralDelimiters:
 Style/RedundantReturn:
   AllowMultipleReturnValues: true
 
-# Always use raise to raise exceptions
-Style/SignalException:
-  EnforcedStyle: only_raise
-
 Style/SingleLineBlockParams:
   Enabled: false
 
-# I like to have symbols always look like symbols
+# Do not commit to use of interpolation
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+# Prefer symbols to look like symbols
 Style/SymbolArray:
   EnforcedStyle: brackets
 
+# Project-specific configuration goes here.
+
 # Accessors are only trivial if they match the ivar name.
 Style/TrivialAccessors:
   ExactNameMatch: true
@@ -100,5 +105,3 @@ Style/WordArray:
 # Not all objects that handle #length also handle #empty?
 Style/ZeroLengthPredicate:
   Enabled: false
-
-inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-02-27 08:50:25 +0100 using RuboCop version 0.65.0.
+# on 2019-10-16 21:37:35 +0200 using RuboCop version 0.75.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,6 +12,11 @@ Lint/IneffectiveAccessModifier:
     - 'lib/alexandria/logging.rb'
     - 'lib/alexandria/web_themes.rb'
 
+# Offense count: 1
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'lib/alexandria/ui/libraries_combo.rb'
+
 # Offense count: 1
 Lint/UriEscapeUnescape:
   Exclude:
@@ -23,9 +28,9 @@ Lint/UselessAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 165
+# Offense count: 162
 Metrics/AbcSize:
-  Max: 161
+  Max: 159
 
 # Offense count: 21
 # Configuration parameters: CountComments, ExcludedMethods.
@@ -33,7 +38,7 @@ Metrics/AbcSize:
 Metrics/BlockLength:
   Max: 66
 
-# Offense count: 13
+# Offense count: 8
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
@@ -55,14 +60,14 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 338
+  Max: 340
 
 # Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 62
+# Offense count: 63
 Metrics/PerceivedComplexity:
   Max: 23
 
@@ -84,7 +89,7 @@ Naming/HeredocDelimiterNaming:
     - 'Rakefile'
     - 'bin/alexandria'
     - 'lib/alexandria/export_library.rb'
-    - 'lib/alexandria/ui/dialogs/about_dialog.rb'
+    - 'lib/alexandria/ui/about_dialog.rb'
 
 # Offense count: 2
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
@@ -103,7 +108,7 @@ Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/smart_library_properties_dialog_base.rb'
     - 'lib/alexandria/web_themes.rb'
 
 # Offense count: 10
@@ -119,16 +124,77 @@ Naming/UncommunicativeMethodParamName:
     - 'lib/alexandria/ui/init.rb'
     - 'util/rake/fileinstall.rb'
 
+# Offense count: 1
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/end_to_end/basic_run_spec.rb'
+
+# Offense count: 17
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/alexandria/book_providers_spec.rb'
+    - 'spec/alexandria/book_spec.rb'
+    - 'spec/alexandria/console_spec.rb'
+    - 'spec/alexandria/export_library_spec.rb'
+    - 'spec/alexandria/library_spec.rb'
+    - 'spec/alexandria/library_store_spec.rb'
+    - 'spec/alexandria/ui/provider_preferences_dialog_spec.rb'
+    - 'spec/alexandria/ui/smart_library_properties_dialog_spec.rb'
+    - 'spec/end_to_end/basic_run_spec.rb'
+
+# Offense count: 1
+RSpec/ExpectInHook:
+  Exclude:
+    - 'spec/alexandria/export_library_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/alexandria/ui/iconview_spec.rb'
+    - 'spec/alexandria/ui/sidepane_manager_spec.rb'
+    - 'spec/alexandria/ui/sound_spec.rb'
+
+# Offense count: 11
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/alexandria/export_library_spec.rb'
+
+# Offense count: 3
+RSpec/MultipleDescribes:
+  Exclude:
+    - 'spec/alexandria/ui/main_app_spec.rb'
+    - 'spec/alexandria/ui/ui_utilities_spec.rb'
+    - 'spec/alexandria/utilities_spec.rb'
+
+# Offense count: 13
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 11
+
+# Offense count: 34
+# Cop supports --auto-correct.
+# Configuration parameters: Strict, EnforcedStyle.
+# SupportedStyles: inflected, explicit
+RSpec/PredicateMatcher:
+  Exclude:
+    - 'spec/alexandria/export_library_spec.rb'
+    - 'spec/alexandria/library_spec.rb'
+    - 'spec/alexandria/library_store_spec.rb'
+    - 'spec/alexandria/scanners/cue_cat_spec.rb'
+
 # Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
-    - 'lib/alexandria/ui/dialogs/import_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/preferences_dialog.rb'
     - 'lib/alexandria/ui/icons.rb'
+    - 'lib/alexandria/ui/import_dialog.rb'
     - 'lib/alexandria/ui/init.rb'
+    - 'lib/alexandria/ui/provider_preferences_base_dialog.rb'
 
 # Offense count: 17
 Style/ClassVars:
@@ -138,9 +204,9 @@ Style/ClassVars:
     - 'lib/alexandria/logging.rb'
     - 'lib/alexandria/models/library.rb'
     - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
+    - 'lib/alexandria/ui/acquire_dialog.rb'
+    - 'lib/alexandria/ui/book_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/new_book_dialog.rb'
 
 # Offense count: 11
 Style/CommentedKeyword:
@@ -148,44 +214,27 @@ Style/CommentedKeyword:
     - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/book_providers/barnes_and_noble.rb'
     - 'lib/alexandria/book_providers/worldcat.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
+    - 'lib/alexandria/ui/new_book_dialog.rb'
     - 'util/rake/fileinstall.rb'
 
-# Offense count: 112
+# Offense count: 113
 Style/Documentation:
   Enabled: false
 
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: each, for
-Style/For:
+# Offense count: 1
+Style/DoubleNegation:
   Exclude:
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/book_providers/douban.rb'
-    - 'lib/alexandria/book_providers/renaud.rb'
-    - 'spec/alexandria/library_spec.rb'
+    - 'lib/alexandria/ui/listview.rb'
 
-# Offense count: 65
+# Offense count: 10
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Exclude:
-    - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/ui/callbacks.rb'
-    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/keep_bad_isbn_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/misc_dialogs.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog_manual.rb'
-    - 'lib/alexandria/ui/dialogs/preferences_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog.rb'
+    - 'lib/alexandria/ui/acquire_dialog.rb'
     - 'lib/alexandria/ui/dndable.rb'
     - 'lib/alexandria/ui/listview.rb'
-    - 'lib/alexandria/ui/sidepane.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
+    - 'lib/alexandria/ui/new_book_dialog.rb'
 
 # Offense count: 34
 # Configuration parameters: MinBodyLength.
@@ -207,32 +256,3 @@ Style/MissingRespondToMissing:
   Exclude:
     - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/preferences.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: Whitelist.
-# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
-Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'spec/alexandria/library_spec.rb'
-    - 'spec/alexandria/library_store_spec.rb'
-
-# Offense count: 21
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/alexandria/book_providers/adlibris.rb'
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/book_providers/douban.rb'
-    - 'lib/alexandria/book_providers/proxis.rb'
-    - 'lib/alexandria/book_providers/pseudomarc.rb'
-    - 'lib/alexandria/book_providers/renaud.rb'
-    - 'lib/alexandria/book_providers/siciliano.rb'
-    - 'lib/alexandria/book_providers/thalia.rb'
-    - 'lib/alexandria/library_store.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/sidepane.rb'
-    - 'util/rake/fileinstall.rb'
-    - 'util/rake/gettextgenerate.rb'

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.7.4 / 2019-10-24
+
+* Drop support for Ruby 2.3
+* Avoid passing nil to Gtk method #visible=, which expects a boolean
+  ([#22], by [Joseph Haig][jrmhaig])
+* Update dependencies on gtk3 and gstreamer to 3.4.1
+* Fix WorldCat provider to use https
+
 ## 0.7.3 / 2019-02-27
 
 * Remove DeaStore provider since the site is no longer online
@@ -64,6 +72,9 @@
   Amazon's Product Advertising API. Thanks to Stephen McCamant for
   providing the patch.
 
-<!-- references -->
+<!-- contributors -->
+[jrmhaig]: https://github.com/jrmhaig
 
+<!-- issues and pull requests -->
+[#23]: https://github.com/mvz/alexandria-book-collection-manager/pull/23
 [#19]: https://github.com/mvz/alexandria-book-collection-manager/issues/19

data/Gemfile

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # The gem's dependencies are specified in the gemspec
 gemspec
 
 group :development, :test do
-  gem 'simplecov'
-  gem 'yard', '~> 0.9.5'
+  gem "pry"
+  gem "simplecov"
+  gem "yard", "~> 0.9.5"
 end

data/README.md

@@ -99,6 +99,7 @@ The following people have contributed to Alexandria over the years:
 * Constantine Evans <cevans@costinet.org>
 * Dafydd Harries <daf@muse.19inch.net>
 * Javier Fernandez-Sanguino Pena <jfs@debian.org>
+* Joseph Haig <josephhaig@gmail.com>
 * Joseph Method <tristil@gmail.com>
 * Kevin Schultz <schultkl@ieee.org>
 * Laurent Sansonetti <lrz@gnome.org>
@@ -119,6 +120,11 @@ The following people have contributed to Alexandria over the years:
 * Cathal Mc Ginley <cathal.alexandria@gnostai.org>
 * Liam Davison <registrations@liamjdavison.info>
 
+### Artists
+
+* Andreas Nilsson <nisses.mail@home.se>
+* Stefanie Dijoux <stefanie.dijoux@gmail.com>
+
 ### Translators
 
 * Adrián Chaves Fernández <adriyetichaves@gmail.com> (gl)
@@ -140,18 +146,22 @@ The following people have contributed to Alexandria over the years:
 * Piotr Drąg <piotrdrag@gmail.com> (pl)
 * Serhij Dubyk <dubyk@library.lviv.ua> (uk)
 
-### Artists
-
-* Andreas Nilsson <nisses.mail@home.se>
-* Stefanie Dijoux <stefanie.dijoux@gmail.com>
+### Former translators
+* David Weinehall <tao@debian.org> (sv)
+* Jiří Pejchal <jiri.pejchal@gmail.com> (cs)
+* Laurent Sansonetti <lrz@gnome.org> (fr)
+* Lucas Rocha <lucasr@im.ufba.br> (pt_BR)
+* Marco Costantini <costanti@science.unitn.it> (it)
+* Masao Mutoh <mutoh@highway.ne.jp> (ja)
+* Mirko Maischberger <mirko@lilik.it> (it)
 
 ## License
 
 Unless otherwise noted, the following license applies to all files that are
 part of Alexandria:
 
-Copyright (C) 2004-2006 Laurent Sansonetti
-Copyright (C) 2007-2010,2014-2018 Alexandria Contributors
+Copyright (C) 2004 Laurent Sansonetti
+Copyright (C) 2005-2010,2014-2019 Alexandria Contributors
 
 Alexandria is free software; you can redistribute it and/or modify it under the
 terms of the GNU General Public License as published by the Free Software