alexandria-book-collection-manager 0.7.3 → 0.7.4

data/lib/alexandria/book_providers/barnes_and_noble.rb

@@ -28,24 +28,24 @@
 
 # NOTE: this modified version is based on the Alexandria WorldCat provider.
 
-require 'cgi'
-require 'alexandria/net'
-require 'alexandria/book_providers/web'
+require "cgi"
+require "alexandria/net"
+require "alexandria/book_providers/web"
 
 module Alexandria
   class BookProviders
     class BarnesAndNobleProvider < WebsiteBasedProvider
       include Alexandria::Logging
 
-      SITE = 'http://www.barnesandnoble.com'
+      SITE = "http://www.barnesandnoble.com"
 
-      BASE_ISBN_SEARCH_URL = 'http://www.barnesandnoble.com/s/%s'
+      BASE_ISBN_SEARCH_URL = "http://www.barnesandnoble.com/s/%s"
 
-      BASE_SEARCH_URL = 'http://search.barnesandnoble.com/booksearch' \
-        '/results.asp?%s=%s' # type, term
+      BASE_SEARCH_URL = "http://search.barnesandnoble.com/booksearch" \
+        "/results.asp?%s=%s" # type, term
 
       def initialize
-        super('BarnesAndNoble', 'BarnesAndNoble')
+        super("BarnesAndNoble", "BarnesAndNoble")
         @agent = nil
         prefs.read
       end
@@ -56,7 +56,7 @@ module Alexandria
       end
 
       def fetch_redirectly(uri_str, limit = 5)
-        raise NoResultsError, 'HTTP redirect too deep' if limit.zero?
+        raise NoResultsError, "HTTP redirect too deep" if limit.zero?
 
         if limit < 10
           sleep 0.1
@@ -69,7 +69,7 @@ module Alexandria
         case response
         when Net::HTTPSuccess     then response
         when Net::HTTPRedirection then
-          redirect = URI.parse response['Location']
+          redirect = URI.parse response["Location"]
           redirect = URI.parse(uri_str) + redirect if redirect.relative?
           fetch_redirectly(redirect.to_s, (limit - 1))
         else
@@ -101,10 +101,10 @@ module Alexandria
 
       def create_search_uri(search_type, search_term)
         (search_type_code = {
-          SEARCH_BY_AUTHORS => 'ATH',
-          SEARCH_BY_TITLE   => 'TTL',
-          SEARCH_BY_KEYWORD => 'WRD' # SEARCH_BY_PUBLISHER => 'PBL' # not implemented
-        }[search_type]) || ''
+          SEARCH_BY_AUTHORS => "ATH",
+          SEARCH_BY_TITLE   => "TTL",
+          SEARCH_BY_KEYWORD => "WRD" # SEARCH_BY_PUBLISHER => 'PBL' # not implemented
+        }[search_type]) || ""
         if search_type == SEARCH_BY_ISBN
           BASE_ISBN_SEARCH_URL % Library.canonicalise_ean(search_term) # isbn-13
         else
@@ -128,19 +128,19 @@ module Alexandria
             result = {}
             # img = div % 'div.book-image/a/img'
             # result[:image_url] = img['src'] if img
-            title_header = div % 'h2'
-            title_links = title_header / 'a'
+            title_header = div % "h2"
+            title_links = title_header / "a"
             result[:title] = title_links.first.inner_text
-            result[:url] = title_links.first['href']
+            result[:url] = title_links.first["href"]
 
             book_search_results << result
           end
         rescue StandardError => ex
           trace = ex.backtrace.join("\n> ")
-          log.warn {
-            'Failed parsing search results for Barnes & Noble ' \
+          log.warn do
+            "Failed parsing search results for Barnes & Noble " \
             "#{ex.message} #{trace}"
-          }
+          end
         end
         book_search_results
       end
@@ -150,8 +150,8 @@ module Alexandria
         begin
           book_data = {}
 
-          dl = (doc / 'dl').first
-          dts = dl.children_of_type('dt')
+          dl = (doc / "dl").first
+          dts = dl.children_of_type("dt")
           dts.each do |dt|
             value = dt.next_sibling.inner_text
             case dt.inner_text
@@ -166,26 +166,26 @@ module Alexandria
             end
           end
 
-          meta = doc / 'meta'
+          meta = doc / "meta"
           meta.each do |it|
             attrs = it.attributes
-            property = attrs['property']
+            property = attrs["property"]
             next unless property
 
             case property
-            when 'og:title'
-              book_data[:title] = attrs['content']
-            when 'og:image'
-              book_data[:image_url] = attrs['content']
+            when "og:title"
+              book_data[:title] = attrs["content"]
+            when "og:image"
+              book_data[:image_url] = attrs["content"]
             end
           end
 
-          author_links = doc / 'span.contributors a'
+          author_links = doc / "span.contributors a"
           authors = author_links.map(&:inner_text)
           book_data[:authors] = authors
 
-          book_data[:binding] = ''
-          selected_format = (doc / '#availableFormats li.selected a.tabTitle').first
+          book_data[:binding] = ""
+          selected_format = (doc / "#availableFormats li.selected a.tabTitle").first
           book_data[:binding] = selected_format.inner_text if selected_format
 
           book = Book.new(book_data[:title], book_data[:authors],
@@ -197,10 +197,10 @@ module Alexandria
           raise ex if ex.instance_of? NoResultsError
 
           trace = ex.backtrace.join("\n> ")
-          log.warn {
-            'Failed parsing search results for BarnesAndNoble ' \
+          log.warn do
+            "Failed parsing search results for BarnesAndNoble " \
             "#{ex.message} #{trace}"
-          }
+          end
           raise NoResultsError
         end
       end

data/lib/alexandria/book_providers/douban.rb

@@ -1,44 +1,28 @@
 # frozen_string_literal: true
 
-# -*- ruby -*-
+# This file is part of Alexandria.
 #
-# Copyright (C) 2009 Cathal Mc Ginley
-# Copyright (C) 2010 Sun Ning
-#
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
 # http://book.douban.com/
 # Douban.com book repository, provides many Chinese books.
 
 # Author: Sun Ning <classicning@gmail.com>, http://sunng.info/
 
-require 'cgi'
-require 'alexandria/net'
-require 'yaml'
+require "cgi"
+require "alexandria/net"
+require "yaml"
 
 module Alexandria
   class BookProviders
     class DoubanProvider < GenericProvider
       include Alexandria::Logging
 
-      SITE = 'http://www.douban.com'
-      BASE_URL = 'http://api.douban.com/book/subjects?q=%s&max-results=5&alt=json'
+      SITE = "http://www.douban.com"
+      BASE_URL = "http://api.douban.com/book/subjects?q=%s&max-results=5&alt=json"
 
       def initialize
-        super('Douban', 'Douban (China)')
+        super("Douban", "Douban (China)")
         prefs.read
       end
 
@@ -77,7 +61,7 @@ module Alexandria
         yaml = json.gsub(/(\:|\,)([0-9'"{\[])/) do |_match|
           "#{Regexp.last_match[1]} #{Regexp.last_match[2]}"
         end
-        yaml.gsub!(/\\\//, '/') # unescape forward slashes
+        yaml.gsub!(%r{\\/}, "/") # unescape forward slashes
         yaml
       end
 
@@ -89,27 +73,27 @@ module Alexandria
           # dbresult = JSON.parse(response)
           dbresult = YAML.safe_load(json2yaml(response))
           # File.open(",douban.yaml", "wb") {|f| f.write(json2yaml(response)) }
-          if dbresult['opensearch:totalResults']['$t'].to_i > 0
-            for item in dbresult['entry']
-              name = item['title']['$t']
+          if dbresult["opensearch:totalResults"]["$t"].to_i > 0
+            dbresult["entry"].each do |item|
+              name = item["title"]["$t"]
               isbn = nil
               publisher = nil
               pubdate = nil
               binding = nil
-              for av in item['db:attribute']
-                isbn = av['$t'] if av['@name'] == 'isbn13'
-                publisher = av['$t'] if av['@name'] == 'publisher'
-                pubdate = av['$t'] if av['@name'] == 'pubdate'
-                binding = av['$t'] if av['@name'] == 'binding'
+              item["db:attribute"].each do |av|
+                isbn = av["$t"] if av["@name"] == "isbn13"
+                publisher = av["$t"] if av["@name"] == "publisher"
+                pubdate = av["$t"] if av["@name"] == "pubdate"
+                binding = av["$t"] if av["@name"] == "binding"
               end
-              authors = if item['author']
-                          item['author'].map { |a| a['name']['$t'] }
+              authors = if item["author"]
+                          item["author"].map { |a| a["name"]["$t"] }
                         else
                           []
                         end
               image_url = nil
-              for av in item['link']
-                image_url = av['@href'] if av['@rel'] == 'image'
+              item["link"].each do |av|
+                image_url = av["@href"] if av["@rel"] == "image"
               end
               book = Book.new(name, authors, isbn, publisher, pubdate, binding)
               book_search_results << [book, image_url]

data/lib/alexandria/book_providers/proxis.rb

@@ -7,8 +7,8 @@
 # New Proxis provider, taken from Palatina MetaDataSource and modified
 # for Alexandria. (20 Dec 2009)
 
-require 'cgi'
-require 'alexandria/book_providers/web'
+require "cgi"
+require "alexandria/book_providers/web"
 
 module Alexandria
   class BookProviders
@@ -22,14 +22,14 @@ module Alexandria
       # it adds most to Alexandria (Amazon already has French and
       # English titles).
 
-      SITE = 'http://www.proxis.nl'
+      SITE = "http://www.proxis.nl"
       BASE_SEARCH_URL = "#{SITE}/NLNL/Search/IndexGSA.aspx?search=%s" \
-        '&shop=100001NL&SelRubricLevel1Id=100001NL'
+        "&shop=100001NL&SelRubricLevel1Id=100001NL"
       ISBN_REDIRECT_BASE_URL = "#{SITE}/NLNL/Search/Index.aspx?search=%s" \
-        '&shop=100001NL&SelRubricLevel1Id=100001NL'
+        "&shop=100001NL&SelRubricLevel1Id=100001NL"
 
       def initialize
-        super('Proxis', 'Proxis (Belgium)')
+        super("Proxis", "Proxis (Belgium)")
         # prefs.add("lang", _("Language"), "fr",
         #          LANGUAGES.keys)
         prefs.read
@@ -79,7 +79,7 @@ module Alexandria
             nil
           else
             node_text = node.children.map { |n| text_of(n) }.join
-            node_text.strip.squeeze(' ')
+            node_text.strip.squeeze(" ")
           end
         end
       end
@@ -87,14 +87,14 @@ module Alexandria
       def parse_search_result_data(html)
         doc = html_to_doc(html)
         book_search_results = []
-        items = doc.search('table.searchResult tr')
+        items = doc.search("table.searchResult tr")
         items.each do |item|
           result = {}
-          title_link = item % 'h5 a'
+          title_link = item % "h5 a"
           if title_link
             result[:title] = text_of(title_link)
-            result[:lookup_url] = title_link['href']
-            result[:lookup_url] = "#{SITE}#{result[:lookup_url]}" unless result[:lookup_url] =~ /^http/
+            result[:lookup_url] = title_link["href"]
+            result[:lookup_url] = "#{SITE}#{result[:lookup_url]}" unless /^http/.match?(result[:lookup_url])
           end
           book_search_results << result
         end
@@ -106,7 +106,7 @@ module Alexandria
 
       def data_for_header(th)
         tr = th.parent
-        td = tr.at('td')
+        td = tr.at("td")
         text_of(td) if td
       end
 
@@ -115,19 +115,19 @@ module Alexandria
         book_data = {}
         book_data[:authors] = []
         # TITLE
-        if (title_header = doc.search('div.detailBlock h3'))
-          header_spans = title_header.first.search('span')
+        if (title_header = doc.search("div.detailBlock h3"))
+          header_spans = title_header.first.search("span")
           title = text_of(header_spans.first)
           title = Regexp.last_match[1].strip if title =~ /(.+)-$/
           book_data[:title] = title
         end
 
-        info_headers = doc.search('table.productInfoTable th')
+        info_headers = doc.search("table.productInfoTable th")
 
         isbns = []
         unless info_headers.empty?
           info_headers.each do |th|
-            isbns << data_for_header(th) if th.inner_text =~ /(ISBN|EAN)/
+            isbns << data_for_header(th) if /(ISBN|EAN)/.match?(th.inner_text)
           end
           book_data[:isbn] = Library.canonicalise_ean(isbns.first)
         end
@@ -137,15 +137,15 @@ module Alexandria
         unless info_headers.empty?
           info_headers.each do |th|
             header_text = th.inner_text
-            if header_text =~ /Type/
+            if /Type/.match?(header_text)
               book_data[:binding] = data_for_header(th)
-            elsif header_text =~ /Verschijningsdatum/
+            elsif /Verschijningsdatum/.match?(header_text)
               date = data_for_header(th)
-              date =~ /\/([\d]{4})/
+              date =~ %r{/([\d]{4})}
               book_data[:publish_year] = Regexp.last_match[1].to_i
-            elsif header_text =~ /Auteur/
+            elsif /Auteur/.match?(header_text)
               book_data[:authors] << data_for_header(th)
-            elsif header_text =~ /Uitgever/
+            elsif /Uitgever/.match?(header_text)
               book_data[:publisher] = data_for_header(th)
             end
           end
@@ -153,12 +153,12 @@ module Alexandria
 
         image_url = nil
         if (cover_img = doc.at("img[@id$='imgProduct']"))
-          image_url = if cover_img['src'] =~ /^http/
-                        cover_img['src']
+          image_url = if /^http/.match?(cover_img["src"])
+                        cover_img["src"]
                       else
                         "#{SITE}/#{cover_img['src']}" # TODO: use html <base>
                       end
-          image_url = nil if image_url =~ /ProductNoCover/
+          image_url = nil if /ProductNoCover/.match?(image_url)
         end
 
         book = Book.new(book_data[:title], book_data[:authors],

data/lib/alexandria/book_providers/pseudomarc.rb

@@ -22,27 +22,27 @@ module Alexandria
   # A really simple regex-based parser to grab data out of marc text records.
   class PseudoMarcParser
     BNF_FR_MAPPINGS = {
-      title: ['200', 'a'],
-      authors: ['700', 'a'],
-      isbn: ['010', 'a'],
-      publisher: ['210', 'g'],
-      year: ['210', 'd'],
-      binding: ['225', 'a'],
-      notes: ['520', 'a']
+      title: ["200", "a"],
+      authors: ["700", "a"],
+      isbn: ["010", "a"],
+      publisher: ["210", "g"],
+      year: ["210", "d"],
+      binding: ["225", "a"],
+      notes: ["520", "a"]
     }.freeze
 
     USMARC_MAPPINGS = {
-      title: ['245', 'a', 'b'],
-      authors: ['100', 'a'],
-      isbn: ['020', 'a'],
-      publisher: ['490', 'a'],
-      year: ['260', 'c'],
-      binding: ['020', 'a'], # listed with isbn here
-      notes: ['520', 'a']
+      title: ["245", "a", "b"],
+      authors: ["100", "a"],
+      isbn: ["020", "a"],
+      publisher: ["490", "a"],
+      year: ["260", "c"],
+      binding: ["020", "a"], # listed with isbn here
+      notes: ["520", "a"]
     }.freeze
 
     def self.get_fields(data, type, stripping, m = USMARC_MAPPINGS)
-      field = ''
+      field = ""
       m[type][1..m[type].length - 1].each do |part|
         if data.first[part]
           part_data = data.first[part].strip
@@ -50,11 +50,11 @@ module Alexandria
             part_data = Regexp.last_match[1]
             part_data = part_data.strip
           end
-          field += ': ' if field != ''
+          field += ": " if field != ""
           field += part_data
         end
       end
-      field = nil if field == ''
+      field = nil if field == ""
       field
     end
 
@@ -64,7 +64,7 @@ module Alexandria
         title = nil
         title_data = details[m[:title][0]]
         if title_data
-          title_data_all = get_fields(title_data, :title, /(.*)[\/:]$/, m)
+          title_data_all = get_fields(title_data, :title, %r{(.*)[/:]$}, m)
           title = title_data_all if title_data_all
         end
 
@@ -102,7 +102,7 @@ module Alexandria
           year = Regexp.last_match[1].to_i if year =~ /(\d+)/
         end
 
-        notes = ''
+        notes = ""
         notes_data = details[m[:notes][0]]
         notes_data&.each do |note|
           txt = note[m[:notes][1]]

data/lib/alexandria/book_providers/renaud.rb

@@ -1,57 +1,44 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2005-2006-2006 Mathieu Leduc-Hamel
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
 # http://en.wikipedia.org/wiki/Renaud-Bray
 
-require 'net/http'
-require 'cgi'
+require "net/http"
+require "cgi"
 
 module Alexandria
   class BookProviders
     class RENAUDProvider < GenericProvider
       include GetText
       # GetText.bindtextdomain(Alexandria::TEXTDOMAIN, :charset => "UTF-8")
-      BASE_URI = 'http://www.renaud-bray.com/'
-      ACCENTUATED_CHARS = 'áàâäçéèêëíìîïóòôöúùûü'
+      BASE_URI = "http://www.renaud-bray.com/"
+      ACCENTUATED_CHARS = "áàâäçéèêëíìîïóòôöúùûü"
 
       def initialize
-        super('RENAUD', 'Renaud-Bray (Canada)')
+        super("RENAUD", "Renaud-Bray (Canada)")
       end
 
       def search(criterion, type)
-        criterion = criterion.encode('ISO-8859-1')
+        criterion = criterion.encode("ISO-8859-1")
         req = BASE_URI +
-          'francais/menu/gabarit.asp?Rubrique=&Recherche=&Entete=Livre' \
-          '&Page=Recherche_wsc.asp&OnlyAvailable=false&Tri='
+          "francais/menu/gabarit.asp?Rubrique=&Recherche=&Entete=Livre" \
+          "&Page=Recherche_wsc.asp&OnlyAvailable=false&Tri="
         req += case type
                when SEARCH_BY_ISBN
-                 'ISBN'
+                 "ISBN"
                when SEARCH_BY_TITLE
-                 'Titre'
+                 "Titre"
                when SEARCH_BY_AUTHORS
-                 'Auteur'
+                 "Auteur"
                when SEARCH_BY_KEYWORD
-                 ''
+                 ""
                else
                  raise InvalidSearchTypeError
                end
-        req += '&Phrase='
+        req += "&Phrase="
 
         req += CGI.escape(criterion)
         p req if $DEBUG
@@ -61,16 +48,16 @@ module Alexandria
             return to_books(data).pop
           else
             results = []
-            to_books(data).each { |book|
+            to_books(data).each do |book|
               results << book
-            }
+            end
             while /Suivant/ =~ data
-              md = /Enteterouge\">([\d]*)<\/b>/.match(data)
+              md = %r{Enteterouge\">([\d]*)</b>}.match(data)
               num = md[1].to_i + 1
-              data = transport.get(URI.parse(req + '&PageActuelle=' + num.to_s))
-              to_books(data).each { |book|
+              data = transport.get(URI.parse(req + "&PageActuelle=" + num.to_s))
+              to_books(data).each do |book|
                 results << book
-              }
+              end
             end
             return results
           end
@@ -80,72 +67,72 @@ module Alexandria
       end
 
       def url(book)
-        'http://www.renaud-bray.com/francais/menu/gabarit.asp?Rubrique=&Recherche=' \
-          '&Entete=Livre&Page=Recherche_wsc.asp&OnlyAvailable=false&Tri=ISBN&Phrase=' + book.isbn
+        "http://www.renaud-bray.com/francais/menu/gabarit.asp?Rubrique=&Recherche=" \
+          "&Entete=Livre&Page=Recherche_wsc.asp&OnlyAvailable=false&Tri=ISBN&Phrase=" + book.isbn
       end
 
       private
 
       NO_BOOKS_FOUND_REGEXP =
-        /<strong class="Promotion">Aucun article trouv. selon les crit.res demand.s<\/strong>/.freeze
+        %r{<strong class="Promotion">Aucun article trouv. selon les crit.res demand.s</strong>}.freeze
       HYPERLINK_SCAN_REGEXP =
-        /"(Jeune|Lire)Hyperlien" href.*><strong>([-,'\(\)&\#;\w\s#{ACCENTUATED_CHARS}]*)<\/strong><\/a><br>/.
-          freeze
+        %r{"(Jeune|Lire)Hyperlien" href.*><strong>([-,'\(\)&\#;\w\s#{ACCENTUATED_CHARS}]*)</strong></a><br>}
+          .freeze
 
       def to_books(data)
         data = CGI.unescapeHTML(data)
-        data = data.encode('UTF-8')
-        raise NoResultsError if data =~ NO_BOOKS_FOUND_REGEXP
+        data = data.encode("UTF-8")
+        raise NoResultsError if NO_BOOKS_FOUND_REGEXP.match?(data)
 
         titles = []
-        data.scan(HYPERLINK_SCAN_REGEXP).each { |md|
+        data.scan(HYPERLINK_SCAN_REGEXP).each do |md|
           titles << md[1].strip
-        }
+        end
         raise if titles.empty?
 
         authors = []
-        data.scan(/Nom_Auteur.*><i>([,'.&\#;\w\s#{ACCENTUATED_CHARS}]*)<\/i>/).each { |md|
+        data.scan(%r{Nom_Auteur.*><i>([,'.&\#;\w\s#{ACCENTUATED_CHARS}]*)</i>}).each do |md|
           authors2 = []
-          for author in md[0].split('  ')
+          md[0].split("  ").each do |author|
             authors2 << author.strip
           end
           authors << authors2
-        }
+        end
         raise if authors.empty?
 
         isbns = []
-        data.scan(/ISBN : ?<\/td><td>(\d+)/).each { |md|
+        data.scan(%r{ISBN : ?</td><td>(\d+)}).each do |md|
           isbns << md[0].strip
-        }
+        end
         raise if isbns.empty?
 
         editions = []
         publish_years = []
-        data.scan(/Parution : <br>(\d{4,}-\d{2,}-\d{2,})/).each { |md|
+        data.scan(/Parution : <br>(\d{4,}-\d{2,}-\d{2,})/).each do |md|
           editions << md[0].strip
           publish_years << md[0].strip.split(/-/)[0].to_i
-        }
+        end
         raise if editions.empty? || publish_years.empty?
 
         publishers = []
-        data.scan(/diteur : ([,'.&\#;\w\s#{ACCENTUATED_CHARS}]*)<\/span><br>/).each { |md|
+        data.scan(%r{diteur : ([,'.&\#;\w\s#{ACCENTUATED_CHARS}]*)</span><br>}).each do |md|
           publishers << md[0].strip
-        }
+        end
         raise if publishers.empty?
 
         book_covers = []
-        data.scan(/(\/ImagesEditeurs\/[\d]*\/([\dX]*-f.(jpg|gif))
-                    |\/francais\/suggestion\/images\/livre\/livre.gif)/x).each { |md|
+        data.scan(%r{(/ImagesEditeurs/[\d]*/([\dX]*-f.(jpg|gif))
+                    |/francais/suggestion/images/livre/livre.gif)}x).each do |md|
           book_covers << BASE_URI + md[0].strip
-        }
+        end
         raise if book_covers.empty?
 
         books = []
-        titles.each_with_index { |title, i|
+        titles.each_with_index do |title, i|
           books << [Book.new(title, authors[i], isbns[i], publishers[i], publish_years[i], editions[i]),
                     book_covers[i]]
           # print books
-        }
+        end
         raise if books.empty?
 
         books