alexandria-book-collection-manager 0.7.3 → 0.7.4

data/spec/alexandria/ui/ui_manager_spec.rb

@@ -1,28 +1,14 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2008 Joseph Method
-# Copyright (C) 2014 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + '/../../spec_helper'
+require File.dirname(__FILE__) + "/../../spec_helper"
 
 describe Alexandria::UI::UIManager do
-  it 'should work' do
-    main_app = double(Object)
-    Alexandria::UI::UIManager.new main_app
+  it "works" do
+    main_app = instance_double(Alexandria::UI::MainApp)
+    described_class.new main_app
   end
 end

data/spec/alexandria/ui/ui_utilities_spec.rb

@@ -18,45 +18,45 @@
 # write to the Free Software Foundation, Inc., 51 Franklin Street,
 # Fifth Floor, Boston, MA 02110-1301 USA.
 
-require File.dirname(__FILE__) + '/../../spec_helper'
+require File.dirname(__FILE__) + "/../../spec_helper"
 
 # from completion_models
 describe Gtk::Entry do
-  it 'should extend Gtk::Entry'
+  it "should extend Gtk::Entry"
 end
 
 describe Alexandria::UI::CompletionModels do
-  it 'should work'
+  it "should work"
 end
 
 # from glade_base
 
 describe Alexandria::UI::BuilderBase do
-  it 'should be revisited'
+  it "should be revisited"
 end
 
 # from icons
 
 describe GdkPixbuf::Pixbuf do
-  it 'should extend GdkPixbuf::PixBuf'
+  it "should extend GdkPixbuf::PixBuf"
 end
 
 describe Alexandria::UI::Icons do
-  it 'should aid identification'
+  it "should aid identification"
 end
 
 # from libraries_combo
 
 describe Gtk::ComboBox do
-  it 'should extend Gtk::ComboBox'
+  it "should extend Gtk::ComboBox"
 end
 
 # from multi_drag_treeview
 
 describe Gdk::Event do
-  it 'should extend Gdk::Event'
+  it "should extend Gdk::Event"
 end
 
 describe Gtk::TreeView do
-  it 'should extend Gtk::TreeView'
+  it "should extend Gtk::TreeView"
 end

data/spec/alexandria/utilities_spec.rb

@@ -17,14 +17,14 @@
 # write to the Free Software Foundation, Inc., 51 Franklin Street,
 # Fifth Floor, Boston, MA 02110-1301 USA.
 
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
 
 describe Alexandria::ExecutionQueue do
   it "should not have so many u's and e's"
 end
 
 describe Alexandria::ExportFormat do
-  it 'should justify its existence'
+  it "should justify its existence"
 end
 
 describe Alexandria::ImportFilter do
@@ -32,11 +32,11 @@ describe Alexandria::ImportFilter do
 end
 
 describe Alexandria::Logger do
-  it 'should fulfill its function'
+  it "should fulfill its function"
 end
 
 describe Alexandria::UndoManager do
-  it 'should make right what is wrong'
+  it "should make right what is wrong"
 end
 
 describe Time do
@@ -44,9 +44,9 @@ describe Time do
 end
 
 describe String do
-  it 'should do what it does'
+  it "should do what it does"
 end
 
 describe Alexandria::WebTheme do
-  it 'should be themeable'
+  it "should be themeable"
 end

data/spec/end_to_end/basic_run_spec.rb

@@ -1,50 +1,42 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2018 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
+
+require "gnome_app_driver"
+require "tmpdir"
 
-require 'gnome_app_driver'
-require 'tmpdir'
+describe "The Alexandria application" do
+  let(:driver) { GnomeAppDriver.new "alexandria" }
 
-describe 'The Alexandria application' do
   before do
-    ENV['HOME'] = Dir.mktmpdir
-    @driver = GnomeAppDriver.new 'alexandria'
-    @driver.boot
+    ENV["HOME"] = Dir.mktmpdir
+    driver.boot
   end
 
-  it 'starts and can be quit with Ctrl-q' do
-    @driver.press_ctrl_q
+  after do
+    driver.cleanup
+  end
 
-    status = @driver.cleanup
+  it "starts and can be quit with Ctrl-q" do
+    driver.press_ctrl_q
+
+    status = driver.cleanup
     expect(status.exitstatus).to eq 0
   end
 
-  it 'starts and can be quit with the menu' do
-    frame = @driver.frame
+  it "starts and can be quit with the menu" do
+    frame = driver.frame
     menu = frame.find_role :menu_item, /Quit/
     menu.do_action 0
 
-    status = @driver.cleanup
+    status = driver.cleanup
     expect(status.exitstatus).to eq 0
   end
 
-  it 'can be interacted with' do
-    frame = @driver.frame
+  it "can be interacted with" do
+    frame = driver.frame
     frame.find_role(:menu_item, /Title contains/).do_action 0
     frame.find_role(:menu_item, /View as Icons/).do_action 0
     frame.find_role(:menu_item, /View as List/).do_action 0
@@ -54,16 +46,12 @@ describe 'The Alexandria application' do
 
     table_cell.n_actions.times do |idx|
       name = table_cell.get_action_name idx
-      table_cell.do_action idx if name == 'activate'
+      table_cell.do_action idx if name == "activate"
     end
 
-    @driver.press_ctrl_q
+    driver.press_ctrl_q
 
-    status = @driver.cleanup
+    status = driver.cleanup
     expect(status.exitstatus).to eq 0
   end
-
-  after do
-    @driver.cleanup
-  end
 end

data/spec/spec_helper.rb

@@ -4,19 +4,19 @@
 #
 # See the file README.md for authorship and licensing information.
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '/../lib'))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "/../lib"))
 
-require 'alexandria'
+require "alexandria"
 
-LIBDIR = File.expand_path(File.join(File.dirname(__FILE__), '/data/libraries'))
-TESTDIR = File.join(LIBDIR, 'test')
+LIBDIR = File.expand_path(File.join(File.dirname(__FILE__), "/data/libraries"))
+TESTDIR = File.join(LIBDIR, "test")
 
 def an_artist_of_the_floating_world
-  Alexandria::Book.new('An Artist of the Floating World',
-                       ['Kazuo Ishiguro'],
-                       '9780571147168',
-                       'Faber and Faber', 1999,
-                       'Paperback')
+  Alexandria::Book.new("An Artist of the Floating World",
+                       ["Kazuo Ishiguro"],
+                       "9780571147168",
+                       "Faber and Faber", 1999,
+                       "Paperback")
 end
 
 Alexandria::UI::Icons.init

data/tasks/dogtail.rake

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-desc 'run dogtail integration tests'
+desc "run dogtail integration tests"
 task :dogtail do
   `RUBYOPT='-rbundler/setup -Ilib' python dogtail/*.py`
 end

data/tasks/setup.rb

@@ -24,9 +24,9 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
-require 'rake/clean'
+require "rake/clean"
 
 # Load the other rake files in the tasks folder
 tasks_dir = __dir__
-rakefiles = Dir.glob(File.join(tasks_dir, '*.rake')).sort
+rakefiles = Dir.glob(File.join(tasks_dir, "*.rake")).sort
 import(*rakefiles)

data/tasks/spec.rake

@@ -26,21 +26,21 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
-namespace 'spec' do
-  RSpec::Core::RakeTask.new('unit') do |t|
-    t.pattern = 'spec/alexandria/**/*_spec.rb'
-    t.ruby_opts = ['-rbundler/setup -rsimplecov -Ilib -w']
+namespace "spec" do
+  RSpec::Core::RakeTask.new("unit") do |t|
+    t.pattern = "spec/alexandria/**/*_spec.rb"
+    t.ruby_opts = ["-rbundler/setup -rsimplecov -Ilib -w"]
   end
 
-  RSpec::Core::RakeTask.new('end_to_end') do |t|
-    t.pattern = 'spec/end_to_end/**/*_spec.rb'
-    t.ruby_opts = ['-rbundler/setup -rsimplecov -Ilib -w']
+  RSpec::Core::RakeTask.new("end_to_end") do |t|
+    t.pattern = "spec/end_to_end/**/*_spec.rb"
+    t.ruby_opts = ["-rbundler/setup -rsimplecov -Ilib -w"]
   end
 
-  desc 'Runs all unit and end-to-end specs'
-  task 'all' => ['spec:unit', 'spec:end_to_end']
+  desc "Runs all unit and end-to-end specs"
+  task "all" => ["spec:unit", "spec:end_to_end"]
 end
 
-task default: 'spec:all'
+task default: "spec:all"

data/util/rake/fileinstall.rb

@@ -27,10 +27,10 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
-require 'fileutils'
-require 'pathname'
-require 'set'
-require 'rake/tasklib'
+require "fileutils"
+require "pathname"
+require "set"
+require "rake/tasklib"
 
 # A file installer task, capable of installing into the system
 # directories, or doing a staged install to a given directory
@@ -84,8 +84,8 @@ class FileInstallTask < Rake::TaskLib
 
     # INSTALL TASK
 
-    description = 'Install package files'
-    description += ' to staging directory' if @stage_dir
+    description = "Install package files"
+    description += " to staging directory" if @stage_dir
     desc description
     task tasknames[:install] do
       @file_groups.each { |g| g.install(@stage_dir) }
@@ -105,7 +105,7 @@ class FileInstallTask < Rake::TaskLib
       @dirs_to_remove_globs.each do |glob|
         regex = glob2regex(glob)
         all_dirs.each do |dir|
-          dir += '/' unless dir =~ /\/$/
+          dir += "/" unless dir =~ %r{/$}
           to_delete << Regexp.last_match[1] if regex =~ dir
         end
       end
@@ -116,8 +116,8 @@ class FileInstallTask < Rake::TaskLib
       end
     end
 
-    uninstall_description = 'Uninstall package files'
-    uninstall_description += ' from staging directory' if @stage_dir
+    uninstall_description = "Uninstall package files"
+    uninstall_description += " from staging directory" if @stage_dir
     desc uninstall_description
     task tasknames[:uninstall] => [tasknames[:uninstall_files],
                                    tasknames[:uninstall_dirs]]
@@ -145,7 +145,7 @@ class FileInstallTask < Rake::TaskLib
 
   # Install icon files. This method splits up the source file name and
   # determines where they should be put in the destination hierarchy.
-  def install_icons(file_globs, dest_dir, theme = 'hicolor', icon_type = 'apps')
+  def install_icons(file_globs, dest_dir, theme = "hicolor", icon_type = "apps")
     file_globs.each do |fg|
       files = FileList.new(fg)
       files.each do |f|
@@ -154,7 +154,7 @@ class FileInstallTask < Rake::TaskLib
         icon_size = Pathname.new(icon_dir).basename
         icon_dest_dir = "#{dest_dir}/#{theme}/#{icon_size}/#{icon_type}"
         group = FileGroup.new(icon_dir, f, icon_dest_dir)
-        group.description = 'icons'
+        group.description = "icons"
         @file_groups << group
       end
     end
@@ -169,16 +169,16 @@ class FileInstallTask < Rake::TaskLib
   private
 
   def calculate_ruby_dir
-    ruby_prefix = RbConfig::CONFIG['prefix']
+    ruby_prefix = RbConfig::CONFIG["prefix"]
 
     ruby_libdir = if @install_to_rubylibdir
-                    RbConfig::CONFIG['rubylibdir']
+                    RbConfig::CONFIG["rubylibdir"]
                   else
-                    RbConfig::CONFIG['sitelibdir']
+                    RbConfig::CONFIG["sitelibdir"]
                   end
-    ruby_libdir = ENV['RUBYLIBDIR'] if ENV.key?('RUBYLIBDIR')
+    ruby_libdir = ENV["RUBYLIBDIR"] if ENV.key?("RUBYLIBDIR")
 
-    @prefix = ENV['PREFIX'] || ruby_prefix
+    @prefix = ENV["PREFIX"] || ruby_prefix
     if @prefix == ruby_prefix
       @rubylib = ruby_libdir
     elsif ruby_libdir.index(ruby_prefix).zero?
@@ -190,12 +190,12 @@ class FileInstallTask < Rake::TaskLib
   end
 
   def glob2regex(pathglob)
-    pathglob += '/' if pathglob =~ /\*\*$/
-    real_parts = pathglob.split('**/')
+    pathglob += "/" if /\*\*$/.match?(pathglob)
+    real_parts = pathglob.split("**/")
     real_parts.each do |part|
-      part.gsub!('.', '\\.')
-      part.gsub!('*', '[^\\/]*')
-      part.gsub!('?', '[^\\/]')
+      part.gsub!(".", '\\.')
+      part.gsub!("*", '[^\\/]*')
+      part.gsub!("?", '[^\\/]')
     end
     pattern = real_parts.join("([^\/]+\/)*")
     /(#{pattern})/
@@ -234,7 +234,7 @@ class FileInstallTask < Rake::TaskLib
       @file_glob = file_glob
       @dest_dir = dest_dir
       @mode = mode
-      @description = 'files'
+      @description = "files"
     end
 
     def to_s
@@ -264,8 +264,8 @@ class FileInstallTask < Rake::TaskLib
       puts "Installing #{@description} to #{base_dir}#{@dest_dir}"
       files.each do |f|
         dest = dest_dir(f, base_dir)
-        FileUtils.mkdir_p(dest) unless test('d', dest)
-        FileUtils.install(f, dest, mode: mode) if test('f', f)
+        FileUtils.mkdir_p(dest) unless test("d", dest)
+        FileUtils.install(f, dest, mode: mode) if test("f", f)
       end
     end
 
@@ -274,7 +274,7 @@ class FileInstallTask < Rake::TaskLib
         dest = dest_dir(f, base_dir)
         filename = File.basename(f)
         file = File.join(dest, filename)
-        if test('f', file)
+        if test("f", file)
           FileUtils::Verbose.rm_f(file) # , :noop => true)
         end
       end

data/util/rake/gettextgenerate.rb

@@ -26,9 +26,9 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
-require 'fileutils'
-require 'pathname'
-require 'rake/tasklib'
+require "fileutils"
+require "pathname"
+require "rake/tasklib"
 
 class GettextGenerateTask < Rake::TaskLib
   def initialize(projectname)
@@ -39,7 +39,7 @@ class GettextGenerateTask < Rake::TaskLib
   end
 
   def make_task
-    desc 'Generate gettext localization files'
+    desc "Generate gettext localization files"
     task gettext: @generated_files
 
     @generated_files.each { |gen| CLOBBER << gen } if CLOBBER
@@ -49,7 +49,7 @@ class GettextGenerateTask < Rake::TaskLib
     @po_dir = po_dir
     @po_files_glob = file_glob
     @mo_dir = dest_dir
-    @mo_files_regex = /.*\/(.+)\/LC_MESSAGES\/.+\.mo/
+    @mo_files_regex = %r{.*/(.+)/LC_MESSAGES/.+\.mo}
 
     # create MO files
     rule(/\.mo$/ => [->(dest) { source_file(dest) }]) do |t|
@@ -72,14 +72,14 @@ class GettextGenerateTask < Rake::TaskLib
       begin
         `intltool-merge --version`
       rescue Errno::ENOENT
-        raise 'Need to install intltool'
+        raise "Need to install intltool"
       end
       system("intltool-merge -d #{@po_dir} #{infile} #{outfile}")
     end
   end
 
   def locales
-    po_files.map { |po| File.basename(po).split('.')[0] }
+    po_files.map { |po| File.basename(po).split(".")[0] }
   end
 
   def mo_files