activemerchant 1.79.2 → 1.129.0

data/lib/active_merchant/billing/gateways/pro_pay.rb

@@ -6,202 +6,202 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://xmltest.propay.com/API/PropayAPI.aspx'
       self.live_url = 'https://epay.propay.com/api/propayapi.aspx'
 
-      self.supported_countries = ['US', 'CA']
+      self.supported_countries = %w[US CA]
       self.default_currency = 'USD'
       self.money_format = :cents
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       self.homepage_url = 'https://www.propay.com/'
       self.display_name = 'ProPay'
 
       STATUS_RESPONSE_CODES = {
-        "00" => "Success",
-        "20" => "Invalid username",
-        "21" => "Invalid transType",
-        "22" => "Invalid Currency Code",
-        "23" => "Invalid accountType",
-        "24" => "Invalid sourceEmail",
-        "25" => "Invalid firstName",
-        "26" => "Invalid mInitial",
-        "27" => "Invalid lastName",
-        "28" => "Invalid billAddr",
-        "29" => "Invalid aptNum",
-        "30" => "Invalid city",
-        "31" => "Invalid state",
-        "32" => "Invalid billZip",
-        "33" => "Invalid mailAddr",
-        "34" => "Invalid mailApt",
-        "35" => "Invalid mailCity",
-        "36" => "Invalid mailState",
-        "37" => "Invalid mailZip",
-        "38" => "Invalid dayPhone",
-        "39" => "Invalid evenPhone",
-        "40" => "Invalid ssn",
-        "41" => "Invalid dob",
-        "42" => "Invalid recEmail",
-        "43" => "Invalid knownAccount",
-        "44" => "Invalid amount",
-        "45" => "Invalid invNum",
-        "46" => "Invalid rtNum",
-        "47" => "Invalid accntNum",
-        "48" => "Invalid ccNum",
-        "49" => "Invalid expDate",
-        "50" => "Invalid cvv2",
-        "51" => "Invalid transNum and/or Unable to act perform actions on transNum due to funding",
-        "52" => "Invalid splitNum",
-        "53" => "A ProPay account with this email address already exists AND/OR User has no account number",
-        "54" => "A ProPay account with this social security number already exists",
-        "55" => "The email address provided does not correspond to a ProPay account.",
-        "56" => "Recipient’s email address shouldn’t have a ProPay account and does",
-        "57" => "Cannot settle transaction because it already expired",
-        "58" => "Credit card declined",
-        "59" => "Invalid Credential or IP address not allowed",
-        "60" => "Credit card authorization timed out; retry at a later time",
-        "61" => "Amount exceeds single transaction limit",
-        "62" => "Amount exceeds monthly volume limit",
-        "63" => "Insufficient funds in account",
-        "64" => "Over credit card use limit",
-        "65" => "Miscellaneous error",
-        "66" => "Denied a ProPay account",
-        "67" => "Unauthorized service requested",
-        "68" => "Account not affiliated",
-        "69" => "Duplicate invoice number (The same card was charged for the same amount with the same invoice number (including blank invoices) in a 1 minute period. Details about the original transaction are included whenever a 69 response is returned. These details include a repeat of the auth code, the original AVS response, and the original CVV response.)",
-        "70" => "Duplicate external ID",
-        "71" => "Account previously set up, but problem affiliating it with partner",
-        "72" => "The ProPay Account has already been upgraded to a Premium Account",
-        "73" => "Invalid Destination Account",
-        "74" => "Account or Trans Error",
-        "75" => "Money already pulled",
-        "76" => "Not Premium (used only for push/pull transactions)",
-        "77" => "Empty results",
-        "78" => "Invalid Authentication",
-        "79" => "Generic account status error",
-        "80" => "Invalid Password",
-        "81" => "Account Expired",
-        "82" => "InvalidUserID",
-        "83" => "BatchTransCountError",
-        "84" => "InvalidBeginDate",
-        "85" => "InvalidEndDate",
-        "86" => "InvalidExternalID",
-        "87" => "DuplicateUserID",
-        "88" => "Invalid track 1",
-        "89" => "Invalid track 2",
-        "90" => "Transaction already refunded",
-        "91" => "Duplicate Batch ID"
+        '00' => 'Success',
+        '20' => 'Invalid username',
+        '21' => 'Invalid transType',
+        '22' => 'Invalid Currency Code',
+        '23' => 'Invalid accountType',
+        '24' => 'Invalid sourceEmail',
+        '25' => 'Invalid firstName',
+        '26' => 'Invalid mInitial',
+        '27' => 'Invalid lastName',
+        '28' => 'Invalid billAddr',
+        '29' => 'Invalid aptNum',
+        '30' => 'Invalid city',
+        '31' => 'Invalid state',
+        '32' => 'Invalid billZip',
+        '33' => 'Invalid mailAddr',
+        '34' => 'Invalid mailApt',
+        '35' => 'Invalid mailCity',
+        '36' => 'Invalid mailState',
+        '37' => 'Invalid mailZip',
+        '38' => 'Invalid dayPhone',
+        '39' => 'Invalid evenPhone',
+        '40' => 'Invalid ssn',
+        '41' => 'Invalid dob',
+        '42' => 'Invalid recEmail',
+        '43' => 'Invalid knownAccount',
+        '44' => 'Invalid amount',
+        '45' => 'Invalid invNum',
+        '46' => 'Invalid rtNum',
+        '47' => 'Invalid accntNum',
+        '48' => 'Invalid ccNum',
+        '49' => 'Invalid expDate',
+        '50' => 'Invalid cvv2',
+        '51' => 'Invalid transNum and/or Unable to act perform actions on transNum due to funding',
+        '52' => 'Invalid splitNum',
+        '53' => 'A ProPay account with this email address already exists AND/OR User has no account number',
+        '54' => 'A ProPay account with this social security number already exists',
+        '55' => 'The email address provided does not correspond to a ProPay account.',
+        '56' => 'Recipient’s email address shouldn’t have a ProPay account and does',
+        '57' => 'Cannot settle transaction because it already expired',
+        '58' => 'Credit card declined',
+        '59' => 'Invalid Credential or IP address not allowed',
+        '60' => 'Credit card authorization timed out; retry at a later time',
+        '61' => 'Amount exceeds single transaction limit',
+        '62' => 'Amount exceeds monthly volume limit',
+        '63' => 'Insufficient funds in account',
+        '64' => 'Over credit card use limit',
+        '65' => 'Miscellaneous error',
+        '66' => 'Denied a ProPay account',
+        '67' => 'Unauthorized service requested',
+        '68' => 'Account not affiliated',
+        '69' => 'Duplicate invoice number (The same card was charged for the same amount with the same invoice number (including blank invoices) in a 1 minute period. Details about the original transaction are included whenever a 69 response is returned. These details include a repeat of the auth code, the original AVS response, and the original CVV response.)',
+        '70' => 'Duplicate external ID',
+        '71' => 'Account previously set up, but problem affiliating it with partner',
+        '72' => 'The ProPay Account has already been upgraded to a Premium Account',
+        '73' => 'Invalid Destination Account',
+        '74' => 'Account or Trans Error',
+        '75' => 'Money already pulled',
+        '76' => 'Not Premium (used only for push/pull transactions)',
+        '77' => 'Empty results',
+        '78' => 'Invalid Authentication',
+        '79' => 'Generic account status error',
+        '80' => 'Invalid Password',
+        '81' => 'Account Expired',
+        '82' => 'InvalidUserID',
+        '83' => 'BatchTransCountError',
+        '84' => 'InvalidBeginDate',
+        '85' => 'InvalidEndDate',
+        '86' => 'InvalidExternalID',
+        '87' => 'DuplicateUserID',
+        '88' => 'Invalid track 1',
+        '89' => 'Invalid track 2',
+        '90' => 'Transaction already refunded',
+        '91' => 'Duplicate Batch ID'
       }
 
       TRANSACTION_RESPONSE_CODES = {
-        "00" => "Success",
-        "1" => "Transaction blocked by issuer",
-        "4" => "Pick up card and deny transaction",
-        "5" => "Problem with the account",
-        "6" => "Customer requested stop to recurring payment",
-        "7" => "Customer requested stop to all recurring payments",
-        "8" => "Honor with ID only",
-        "9" => "Unpaid items on customer account",
-        "12" => "Invalid transaction",
-        "13" => "Amount Error",
-        "14" => "Invalid card number",
-        "15" => "No such issuer. Could not route transaction",
-        "16" => "Refund error",
-        "17" => "Over limit",
-        "19" => "Reenter transaction or the merchant account may be boarded incorrectly",
-        "25" => "Invalid terminal 41 Lost card",
-        "43" => "Stolen card",
-        "51" => "Insufficient funds",
-        "52" => "No such account",
-        "54" => "Expired card",
-        "55" => "Incorrect PIN",
-        "57" => "Bank does not allow this type of purchase",
-        "58" => "Credit card network does not allow this type of purchase for your merchant account.",
-        "61" => "Exceeds issuer withdrawal limit",
-        "62" => "Issuer does not allow this card to be charged for your business.",
-        "63" => "Security Violation",
-        "65" => "Activity limit exceeded",
-        "75" => "PIN tries exceeded",
-        "76" => "Unable to locate account",
-        "78" => "Account not recognized",
-        "80" => "Invalid Date",
-        "82" => "Invalid CVV2",
-        "83" => "Cannot verify the PIN",
-        "85" => "Service not supported for this card",
-        "93" => "Cannot complete transaction. Customer should call 800 number.",
-        "95" => "Misc Error Transaction failure",
-        "96" => "Issuer system malfunction or timeout.",
-        "97" => "Approved for a lesser amount. ProPay will not settle and consider this a decline.",
-        "98" => "Failure HV",
-        "99" => "Generic decline or unable to parse issuer response code"
+        '00' => 'Success',
+        '1' => 'Transaction blocked by issuer',
+        '4' => 'Pick up card and deny transaction',
+        '5' => 'Problem with the account',
+        '6' => 'Customer requested stop to recurring payment',
+        '7' => 'Customer requested stop to all recurring payments',
+        '8' => 'Honor with ID only',
+        '9' => 'Unpaid items on customer account',
+        '12' => 'Invalid transaction',
+        '13' => 'Amount Error',
+        '14' => 'Invalid card number',
+        '15' => 'No such issuer. Could not route transaction',
+        '16' => 'Refund error',
+        '17' => 'Over limit',
+        '19' => 'Reenter transaction or the merchant account may be boarded incorrectly',
+        '25' => 'Invalid terminal 41 Lost card',
+        '43' => 'Stolen card',
+        '51' => 'Insufficient funds',
+        '52' => 'No such account',
+        '54' => 'Expired card',
+        '55' => 'Incorrect PIN',
+        '57' => 'Bank does not allow this type of purchase',
+        '58' => 'Credit card network does not allow this type of purchase for your merchant account.',
+        '61' => 'Exceeds issuer withdrawal limit',
+        '62' => 'Issuer does not allow this card to be charged for your business.',
+        '63' => 'Security Violation',
+        '65' => 'Activity limit exceeded',
+        '75' => 'PIN tries exceeded',
+        '76' => 'Unable to locate account',
+        '78' => 'Account not recognized',
+        '80' => 'Invalid Date',
+        '82' => 'Invalid CVV2',
+        '83' => 'Cannot verify the PIN',
+        '85' => 'Service not supported for this card',
+        '93' => 'Cannot complete transaction. Customer should call 800 number.',
+        '95' => 'Misc Error Transaction failure',
+        '96' => 'Issuer system malfunction or timeout.',
+        '97' => 'Approved for a lesser amount. ProPay will not settle and consider this a decline.',
+        '98' => 'Failure HV',
+        '99' => 'Generic decline or unable to parse issuer response code'
       }
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :cert_str)
         super
       end
 
-      def purchase(money, payment, options={})
+      def purchase(money, payment, options = {})
         request = build_xml_request do |xml|
           add_invoice(xml, money, options)
           add_payment(xml, payment, options)
           add_address(xml, options)
           add_account(xml, options)
           add_recurring(xml, options)
-          xml.transType "04"
+          xml.transType '04'
         end
 
         commit(request)
       end
 
-      def authorize(money, payment, options={})
+      def authorize(money, payment, options = {})
         request = build_xml_request do |xml|
           add_invoice(xml, money, options)
           add_payment(xml, payment, options)
           add_address(xml, options)
           add_account(xml, options)
           add_recurring(xml, options)
-          xml.transType "05"
+          xml.transType '05'
         end
 
         commit(request)
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         request = build_xml_request do |xml|
           add_invoice(xml, money, options)
           add_account(xml, options)
           xml.transNum authorization
-          xml.transType "06"
+          xml.transType '06'
         end
 
         commit(request)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         request = build_xml_request do |xml|
           add_invoice(xml, money, options)
           add_account(xml, options)
           xml.transNum authorization
-          xml.transType "07"
+          xml.transType '07'
         end
 
         commit(request)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         refund(nil, authorization, options)
       end
 
-      def credit(money, payment, options={})
+      def credit(money, payment, options = {})
         request = build_xml_request do |xml|
           add_invoice(xml, money, options)
           add_payment(xml, payment, options)
           add_account(xml, options)
-          xml.transType "35"
+          xml.transType '35'
         end
 
         commit(request)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }
@@ -234,7 +234,7 @@ module ActiveMerchant #:nodoc:
           xml.aptNum address[:address2]
           xml.city address[:city]
           xml.state address[:state]
-          xml.zip address[:zip]
+          xml.zip address[:zip].to_s.delete('-')
         end
       end
 
@@ -253,9 +253,9 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(body)
-        results  = {}
+        results = {}
         xml = Nokogiri::XML(body)
-        resp = xml.xpath("//XMLResponse/XMLTrans")
+        resp = xml.xpath('//XMLResponse/XMLTrans')
         resp.children.each do |element|
           results[element.name.underscore.downcase.to_sym] = element.text
         end
@@ -279,11 +279,12 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response[:status] == "00"
+        response[:status] == '00'
       end
 
       def message_from(response)
-        return "Success" if success_from(response)
+        return 'Success' if success_from(response)
+
         message = STATUS_RESPONSE_CODES[response[:status]]
         message += " - #{TRANSACTION_RESPONSE_CODES[response[:response_code]]}" if response[:response_code]
 
@@ -295,16 +296,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def error_code_from(response)
-        unless success_from(response)
-          response[:status]
-        end
+        response[:status] unless success_from(response)
       end
 
       def build_xml_request
         builder = Nokogiri::XML::Builder.new do |xml|
           xml.XMLRequest do
             xml.certStr @options[:cert_str]
-            xml.class_ "partner"
+            xml.class_ 'partner'
             xml.XMLTrans do
               yield(xml)
             end
@@ -317,9 +316,9 @@ module ActiveMerchant #:nodoc:
 
     def underscore(camel_cased_word)
       camel_cased_word.to_s.gsub(/::/, '/').
-        gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
-        gsub(/([a-z\d])([A-Z])/,'\1_\2').
-        tr("-", "_").
+        gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
+        gsub(/([a-z\d])([A-Z])/, '\1_\2').
+        tr('-', '_').
         downcase
     end
   end

data/lib/active_merchant/billing/gateways/psigate.rb

@@ -35,10 +35,10 @@ module ActiveMerchant #:nodoc:
     #   :email => 'jack@yahoo.com'
     # )
     class PsigateGateway < Gateway
-      self.test_url  = 'https://staging.psigate.com:17989/Messenger/XMLMessenger'
-      self.live_url  = 'https://secure.psigate.com:17934/Messenger/XMLMessenger'
+      self.test_url  = 'https://realtimestaging.psigate.com/xml'
+      self.live_url  = 'https://realtime.psigate.com/xml'
 
-      self.supported_cardtypes = [:visa, :master, :american_express]
+      self.supported_cardtypes = %i[visa master american_express]
       self.supported_countries = ['CA']
       self.homepage_url = 'http://www.psigate.com/'
       self.display_name = 'Psigate'
@@ -53,18 +53,18 @@ module ActiveMerchant #:nodoc:
 
       def authorize(money, creditcard, options = {})
         requires!(options, :order_id)
-        options[:CardAction] = "1"
+        options[:CardAction] = '1'
         commit(money, creditcard, options)
       end
 
       def purchase(money, creditcard, options = {})
         requires!(options, :order_id)
-        options[:CardAction] = "0"
+        options[:CardAction] = '0'
         commit(money, creditcard, options)
       end
 
       def capture(money, authorization, options = {})
-        options[:CardAction] = "2"
+        options[:CardAction] = '2'
         options[:order_id], options[:trans_ref_number] = split_authorization(authorization)
         commit(money, nil, options)
       end
@@ -75,13 +75,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def refund(money, authorization, options = {})
-        options[:CardAction] = "3"
+        options[:CardAction] = '3'
         options[:order_id], options[:trans_ref_number] = split_authorization(authorization)
         commit(money, nil, options)
       end
 
       def void(authorization, options = {})
-        options[:CardAction] = "9"
+        options[:CardAction] = '9'
         options[:order_id], options[:trans_ref_number] = split_authorization(authorization)
         commit(nil, nil, options)
       end
@@ -103,11 +103,10 @@ module ActiveMerchant #:nodoc:
         response = parse(ssl_post(url, post_data(money, creditcard, options)))
 
         Response.new(successful?(response), message_from(response), response,
-          :test => test?,
-          :authorization => build_authorization(response) ,
-          :avs_result => { :code => response[:avsresult] },
-          :cvv_result => response[:cardidresult]
-        )
+          test: test?,
+          authorization: build_authorization(response),
+          avs_result: { code: response[:avsresult] },
+          cvv_result: response[:cardidresult])
       end
 
       def url
@@ -115,11 +114,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def successful?(response)
-        response[:approved] == "APPROVED"
+        response[:approved] == 'APPROVED'
       end
 
       def parse(xml)
-        response = {:message => "Global Error Receipt", :complete => false}
+        response = { message: 'Global Error Receipt', complete: false }
 
         xml = REXML::Document.new(xml)
         xml.elements.each('//Result/*') do |node|
@@ -132,7 +131,7 @@ module ActiveMerchant #:nodoc:
       def post_data(money, creditcard, options)
         xml = REXML::Document.new
         xml << REXML::XMLDecl.new
-        root = xml.add_element("Order")
+        root = xml.add_element('Order')
 
         parameters(money, creditcard, options).each do |key, value|
           root.add_element(key.to_s).text = value if value
@@ -144,43 +143,43 @@ module ActiveMerchant #:nodoc:
       def parameters(money, creditcard, options = {})
         params = {
           # General order parameters
-          :StoreID => @options[:login],
-          :Passphrase => @options[:password],
-          :TestResult => options[:test_result],
-          :OrderID => options[:order_id],
-          :UserID => options[:user_id],
-          :Phone => options[:phone],
-          :Fax => options[:fax],
-          :Email => options[:email],
-          :TransRefNumber => options[:trans_ref_number],
+          StoreID: @options[:login],
+          Passphrase: @options[:password],
+          TestResult: options[:test_result],
+          OrderID: options[:order_id],
+          UserID: options[:user_id],
+          Phone: options[:phone],
+          Fax: options[:fax],
+          Email: options[:email],
+          TransRefNumber: options[:trans_ref_number],
 
           # Credit Card parameters
-          :PaymentType => "CC",
-          :CardAction => options[:CardAction],
+          PaymentType: 'CC',
+          CardAction: options[:CardAction],
 
           # Financial parameters
-          :CustomerIP => options[:ip],
-          :SubTotal => amount(money),
-          :Tax1 => options[:tax1],
-          :Tax2 => options[:tax2],
-          :ShippingTotal => options[:shipping_total],
+          CustomerIP: options[:ip],
+          SubTotal: amount(money),
+          Tax1: options[:tax1],
+          Tax2: options[:tax2],
+          ShippingTotal: options[:shipping_total]
         }
 
         if creditcard
-          exp_month = sprintf("%.2i", creditcard.month) unless creditcard.month.blank?
-          exp_year = creditcard.year.to_s[2,2] unless creditcard.year.blank?
-          card_id_code = (creditcard.verification_value.blank? ? nil : "1")
+          exp_month = sprintf('%.2i', creditcard.month) unless creditcard.month.blank?
+          exp_year = creditcard.year.to_s[2, 2] unless creditcard.year.blank?
+          card_id_code = (creditcard.verification_value.blank? ? nil : '1')
 
           params.update(
-            :CardNumber => creditcard.number,
-            :CardExpMonth => exp_month,
-            :CardExpYear => exp_year,
-            :CardIDCode => card_id_code,
-            :CardIDNumber => creditcard.verification_value
+            CardNumber: creditcard.number,
+            CardExpMonth: exp_month,
+            CardExpYear: exp_year,
+            CardIDCode: card_id_code,
+            CardIDNumber: creditcard.verification_value
           )
         end
 
-        if(address = (options[:billing_address] || options[:address]))
+        if (address = (options[:billing_address] || options[:address]))
           params[:Bname] = address[:name] || creditcard.name
           params[:Baddress1]    = address[:address1] unless address[:address1].blank?
           params[:Baddress2]    = address[:address2] unless address[:address2].blank?
@@ -206,11 +205,12 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(response)
-        if response[:approved] == "APPROVED"
+        if response[:approved] == 'APPROVED'
           return SUCCESS_MESSAGE
         else
           return FAILURE_MESSAGE if response[:errmsg].blank?
-          return response[:errmsg].gsub(/[^\w]/, ' ').split.join(" ").capitalize
+
+          return response[:errmsg].gsub(/[^\w]/, ' ').split.join(' ').capitalize
         end
       end
 
@@ -220,7 +220,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_authorization(response)
-        [response[:orderid], response[:transrefnumber]].join(";")
+        [response[:orderid], response[:transrefnumber]].join(';')
       end
     end
   end