activemerchant 1.79.2 → 1.129.0

data/lib/active_merchant/billing/gateways/transact_pro.rb

@@ -12,17 +12,17 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['US']
       self.default_currency = 'USD'
       self.money_format = :cents
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       self.homepage_url = 'https://www.transactpro.lv/business/online-payments-acceptance'
       self.display_name = 'Transact Pro'
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :guid, :password, :terminal)
         super
       end
 
-      def purchase(amount, payment, options={})
+      def purchase(amount, payment, options = {})
         post = PostData.new
         add_invoice(post, amount, options)
         add_payment(post, payment)
@@ -32,7 +32,7 @@ module ActiveMerchant #:nodoc:
         post[:rs] = @options[:terminal]
 
         MultiResponse.run do |r|
-          r.process{commit('init', post)}
+          r.process { commit('init', post) }
           r.process do
             post = PostData.new
             post[:init_transaction_id] = r.authorization
@@ -44,7 +44,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def authorize(amount, payment, options={})
+      def authorize(amount, payment, options = {})
         post = PostData.new
         add_invoice(post, amount, options)
         add_payment(post, payment)
@@ -54,7 +54,7 @@ module ActiveMerchant #:nodoc:
         post[:rs] = @options[:terminal]
 
         MultiResponse.run do |r|
-          r.process{commit('init_dms', post)}
+          r.process { commit('init_dms', post) }
           r.process do
             post = PostData.new
             post[:init_transaction_id] = r.authorization
@@ -66,11 +66,9 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         identifier, original_amount = split_authorization(authorization)
-        if amount && (amount != original_amount)
-          raise ArgumentError.new("Partial capture is not supported, and #{amount.inspect} != #{original_amount.inspect}")
-        end
+        raise ArgumentError.new("Partial capture is not supported, and #{amount.inspect} != #{original_amount.inspect}") if amount && (amount != original_amount)
 
         post = PostData.new
         add_credentials(post)
@@ -80,7 +78,7 @@ module ActiveMerchant #:nodoc:
         commit('charge_hold', post, original_amount)
       end
 
-      def refund(amount, authorization, options={})
+      def refund(amount, authorization, options = {})
         identifier, original_amount = split_authorization(authorization)
 
         post = PostData.new
@@ -91,7 +89,7 @@ module ActiveMerchant #:nodoc:
         commit('refund', post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         identifier, amount = split_authorization(authorization)
 
         post = PostData.new
@@ -101,7 +99,7 @@ module ActiveMerchant #:nodoc:
         commit('cancel_dms', post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }
@@ -122,7 +120,7 @@ module ActiveMerchant #:nodoc:
           post[:state]   = (address[:state].blank? ? 'NA' : address[:state].to_s)
           post[:zip]     = address[:zip].to_s
           post[:country] = address[:country].to_s
-          post[:phone]   = (address[:phone].to_s.gsub(/[^0-9]/, '') || "0000000")
+          post[:phone]   = (address[:phone].to_s.gsub(/[^0-9]/, '') || '0000000')
         end
 
         if address = options[:shipping_address]
@@ -153,34 +151,34 @@ module ActiveMerchant #:nodoc:
       def add_payment_cc(post, credit_card)
         post[:cc] = credit_card.number
         post[:cvv] = credit_card.verification_value if credit_card.verification_value?
-        year  = sprintf("%.4i", credit_card.year)
-        month = sprintf("%.2i", credit_card.month)
+        year  = sprintf('%.4i', credit_card.year)
+        month = sprintf('%.2i', credit_card.month)
         post[:expire] = "#{month}/#{year[2..3]}"
       end
 
-      def add_credentials(post, key=:guid)
+      def add_credentials(post, key = :guid)
         post[key] = @options[:guid]
         post[:pwd] = Digest::SHA1.hexdigest(@options[:password])
       end
 
       def parse(body)
-        if body =~ /^ID:/
-          body.split('~').reduce(Hash.new) { |h,v|
-            m = v.match("(.*?):(.*)")
+        if /^ID:/.match?(body)
+          body.split('~').reduce(Hash.new) { |h, v|
+            m = v.match('(.*?):(.*)')
             h.merge!(m[1].underscore.to_sym => m[2])
           }
-        elsif (m = body.match("(.*?):(.*)"))
+        elsif (m = body.match('(.*?):(.*)'))
           m[1] == 'OK' ?
             { status: 'success', id: m[2] } :
             { status: 'failure', message: m[2] }
         else
-          Hash[ status: body ]
+          Hash[status: body]
         end
       end
 
-      def commit(action, parameters, amount=nil)
+      def commit(action, parameters, amount = nil)
         url = (test? ? test_url : live_url)
-        response = parse(ssl_post(url, post_data(action,parameters)))
+        response = parse(ssl_post(url, post_data(action, parameters)))
 
         Response.new(
           success_from(response),
@@ -195,12 +193,12 @@ module ActiveMerchant #:nodoc:
         identifier = (response[:id] || parameters[:init_transaction_id])
         authorization = [identifier]
         authorization << amount if amount
-        authorization.join("|")
+        authorization.join('|')
       end
 
       def split_authorization(authorization)
-        if authorization =~ /|/
-          identifier, amount = authorization.split("|")
+        if /|/.match?(authorization)
+          identifier, amount = authorization.split('|')
           [identifier, amount.to_i]
         else
           authorization

data/lib/active_merchant/billing/gateways/transax.rb

@@ -1,23 +1,21 @@
-require File.join(File.dirname(__FILE__),'smart_ps.rb')
+require File.join(File.dirname(__FILE__), 'smart_ps.rb')
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class TransaxGateway < SmartPs
       self.live_url = self.test_url = 'https://secure.nelixtransax.net/api/transact.php'
-      
+
       # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['US']
-      
+
       # The card types supported by the payment gateway
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
-      
+      self.supported_cardtypes = %i[visa master american_express discover]
+
       # The homepage URL of the gateway
       self.homepage_url = 'https://www.nelixtransax.com/'
-      
+
       # The name of the gateway
       self.display_name = 'NELiX TransaX'
-
     end
   end
 end
-

data/lib/active_merchant/billing/gateways/transnational.rb

@@ -3,8 +3,7 @@ module ActiveMerchant #:nodoc:
     class TransnationalGateway < NetworkMerchantsGateway
       self.homepage_url = 'http://www.tnbci.com/'
       self.display_name = 'Transnational'
-      self.supported_countries = ["US"]
+      self.supported_countries = ['US']
     end
   end
 end
-

data/lib/active_merchant/billing/gateways/trexle.rb

@@ -10,7 +10,7 @@ module ActiveMerchant #:nodoc:
                                     GI GR HK HU ID IE IL IM IN IS IT JO KW LB LI LK LT LU LV MC
                                     MT MU MV MX MY NL NO NZ OM PH PL PT QA RO SA SE SG SI SK SM
                                     TR TT UM US VA VN ZA)
-      self.supported_cardtypes = [:visa, :master, :american_express]
+      self.supported_cardtypes = %i[visa master american_express]
       self.homepage_url = 'https://trexle.com'
       self.display_name = 'Trexle'
 
@@ -90,6 +90,7 @@ module ActiveMerchant #:nodoc:
           gsub(/(number\\?":\\?")(\d*)/, '\1[FILTERED]').
           gsub(/(cvc\\?":\\?")(\d*)/, '\1[FILTERED]')
       end
+
       private
 
       def add_amount(post, money, options)
@@ -105,6 +106,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, creditcard, options)
         return if creditcard.kind_of?(String)
+
         address = (options[:billing_address] || options[:address])
         return unless address
 
@@ -120,7 +122,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_invoice(post, options)
-        post[:description] = options[:description] || "Active Merchant Purchase"
+        post[:description] = options[:description] || 'Active Merchant Purchase'
       end
 
       def add_creditcard(post, creditcard)
@@ -135,7 +137,7 @@ module ActiveMerchant #:nodoc:
             name: creditcard.name
           )
         elsif creditcard.kind_of?(String)
-          if creditcard =~ /^token_/
+          if /^token_/.match?(creditcard)
             post[:card_token] = creditcard
           else
             post[:customer_token] = creditcard
@@ -145,41 +147,42 @@ module ActiveMerchant #:nodoc:
 
       def headers(params = {})
         result = {
-          "Content-Type" => "application/json",
-          "Authorization" => "Basic #{Base64.strict_encode64(options[:api_key] + ':').strip}"
+          'Content-Type' => 'application/json',
+          'Authorization' => "Basic #{Base64.strict_encode64(options[:api_key] + ':').strip}"
         }
 
         result['X-Partner-Key'] = params[:partner_key] if params[:partner_key]
         result['X-Safe-Card'] = params[:safe_card] if params[:safe_card]
         result
       end
-      
+
       def commit(method, action, params, options)
         url = "#{test? ? test_url : live_url}/#{action}"
         raw_response = ssl_request(method, url, post_data(params), headers(options))
         parsed_response = parse(raw_response)
-        success_response(parsed_response) 
+        success_response(parsed_response)
       rescue ResponseError => e
         error_response(parse(e.response.body))
       rescue JSON::ParserError
         unparsable_response(raw_response)
       end
-  
+
       def success_response(body)
         return invalid_response unless body['response']
-      
+
         response = body['response']
         Response.new(
-         true,
-         response['status_message'],
-         body,
-         authorization: token(response),
-         test: test?
+          true,
+          response['status_message'],
+          body,
+          authorization: token(response),
+          test: test?
         )
       end
 
       def error_response(body)
         return invalid_response unless body['error']
+
         Response.new(
           false,
           body['error'],
@@ -190,13 +193,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def unparsable_response(raw_response)
-        message = "Invalid JSON response received from Trexle. Please contact support@trexle.com if you continue to receive this message."
+        message = 'Invalid JSON response received from Trexle. Please contact support@trexle.com if you continue to receive this message.'
         message += " (The raw response returned by the API was #{raw_response.inspect})"
         return Response.new(false, message)
       end
-      
+
       def invalid_response
-        message = "Invalid response."
+        message = 'Invalid response.'
         return Response.new(false, message)
       end
 
@@ -206,7 +209,8 @@ module ActiveMerchant #:nodoc:
 
       def parse(body)
         return {} if body.blank?
-        JSON.parse(body) 
+
+        JSON.parse(body)
       end
 
       def post_data(parameters = {})