activemerchant 1.79.2 → 1.129.0

data/lib/active_merchant/billing/gateways/braintree_orange.rb

@@ -7,7 +7,7 @@ module ActiveMerchant #:nodoc:
       include BraintreeCommon
 
       self.display_name = 'Braintree (Orange Platform)'
-      self.supported_countries = ["US"]
+      self.supported_countries = ['US']
 
       self.live_url = self.test_url = 'https://secure.braintreepaymentgateway.com/api/transact.php'
 

data/lib/active_merchant/billing/gateways/bridge_pay.rb

@@ -1,29 +1,28 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class BridgePayGateway < Gateway
-      self.display_name = "BridgePay"
-      self.homepage_url = "http://www.bridgepaynetwork.com/"
+      self.display_name = 'BridgePay'
+      self.homepage_url = 'http://www.bridgepaynetwork.com/'
 
-      self.test_url = "https://gatewaystage.itstgate.com/SmartPayments/transact3.asmx"
-      self.live_url = "https://gateway.itstgate.com/SmartPayments/transact3.asmx"
+      self.test_url = 'https://gatewaystage.itstgate.com/SmartPayments/transact3.asmx'
+      self.live_url = 'https://gateway.itstgate.com/SmartPayments/transact3.asmx'
 
-      self.supported_countries = ["CA", "US"]
-      self.default_currency = "USD"
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb]
+      self.supported_countries = %w[CA US]
+      self.default_currency = 'USD'
+      self.supported_cardtypes = %i[visa master american_express discover diners_club jcb]
 
-
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :user_name, :password)
         super
       end
 
-      def purchase(amount, payment_method, options={})
-        post = initialize_required_fields("Sale")
+      def purchase(amount, payment_method, options = {})
+        post = initialize_required_fields('Sale')
 
         # Allow the same amount in multiple transactions.
-        post[:ExtData] = "<Force>T</Force>"
+        post[:ExtData] = '<Force>T</Force>'
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
@@ -31,8 +30,8 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def authorize(amount, payment_method, options={})
-        post = initialize_required_fields("Auth")
+      def authorize(amount, payment_method, options = {})
+        post = initialize_required_fields('Auth')
 
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
@@ -41,8 +40,8 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def capture(amount, authorization, options={})
-        post = initialize_required_fields("Force")
+      def capture(amount, authorization, options = {})
+        post = initialize_required_fields('Force')
 
         add_invoice(post, amount, options)
         add_reference(post, authorization)
@@ -51,8 +50,8 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def refund(amount, authorization, options={})
-        post = initialize_required_fields("Return")
+      def refund(amount, authorization, options = {})
+        post = initialize_required_fields('Return')
 
         add_invoice(post, amount, options)
         add_reference(post, authorization)
@@ -60,8 +59,8 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def void(authorization, options={})
-        post = initialize_required_fields("Void")
+      def void(authorization, options = {})
+        post = initialize_required_fields('Void')
 
         add_reference(post, authorization)
 
@@ -75,10 +74,10 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def store(creditcard, options={})
+      def store(creditcard, options = {})
         post = initialize_required_fields('')
         post[:transaction] = 'Create'
-        post[:CardNumber]    = creditcard.number
+        post[:CardNumber] = creditcard.number
         post[:CustomerPaymentInfoKey] = ''
         post[:token] = ''
         add_payment_method(post, creditcard)
@@ -114,41 +113,41 @@ module ActiveMerchant #:nodoc:
           post[:TransitNum] = payment_method.routing_number
           post[:AccountNum] = payment_method.account_number
           post[:NameOnCheck] = payment_method.name
-          post[:ExtData] = "<AccountType>#{payment_method.account_type.capitalize}</AccountType>"
+          post[:ExtData] = "<AccountType>#{payment_method.account_type.capitalize}</AccountType>" if payment_method.account_type
         end
       end
 
       def add_token(post, payment_method)
-        payment_method = payment_method.split("|")
+        payment_method = payment_method.split('|')
         post[:ExtData] = "<Force>T</Force><CardVault><Transaction>Read</Transaction><CustomerPaymentInfoKey>#{payment_method[1]}</CustomerPaymentInfoKey><Token>#{payment_method[0]}</Token><ExpDate>#{payment_method[2]}</ExpDate></CardVault>"
       end
 
       def initialize_required_fields(transaction_type)
         post = {}
         post[:TransType] = transaction_type
-        post[:Amount] = ""
-        post[:PNRef] = ""
-        post[:InvNum] = ""
-        post[:CardNum] = ""
-        post[:ExpDate] = ""
-        post[:MagData] = ""
-        post[:NameOnCard] = ""
-        post[:Zip] = ""
-        post[:Street] = ""
-        post[:CVNum] = ""
-        post[:MagData] = ""
-        post[:ExtData] = ""
-        post[:MICR] = ""
-        post[:DL] = ""
-        post[:SS] = ""
-        post[:DOB] = ""
-        post[:StateCode] = ""
-        post[:CheckType] = ""
+        post[:Amount] = ''
+        post[:PNRef] = ''
+        post[:InvNum] = ''
+        post[:CardNum] = ''
+        post[:ExpDate] = ''
+        post[:MagData] = ''
+        post[:NameOnCard] = ''
+        post[:Zip] = ''
+        post[:Street] = ''
+        post[:CVNum] = ''
+        post[:MagData] = ''
+        post[:ExtData] = ''
+        post[:MICR] = ''
+        post[:DL] = ''
+        post[:SS] = ''
+        post[:DOB] = ''
+        post[:StateCode] = ''
+        post[:CheckType] = ''
         post
       end
 
       def add_customer_data(post, options)
-        if(billing_address = (options[:billing_address] || options[:address]))
+        if (billing_address = (options[:billing_address] || options[:address]))
           post[:Street] = billing_address[:address1]
           post[:Zip]    = billing_address[:zip]
         end
@@ -167,8 +166,8 @@ module ActiveMerchant #:nodoc:
         response = {}
 
         doc = Nokogiri::XML(xml)
-        doc.root.xpath("*").each do |node|
-          if (node.elements.size == 0)
+        doc.root&.xpath('*')&.each do |node|
+          if node.elements.size == 0
             response[node.name.downcase.to_sym] = node.text
           else
             node.elements.each do |childnode|
@@ -176,7 +175,7 @@ module ActiveMerchant #:nodoc:
               response[name.to_sym] = childnode.text
             end
           end
-        end unless doc.root.nil?
+        end
 
         response
       end
@@ -208,7 +207,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response[:result] == "0"
+        response[:result] == '0'
       end
 
       def message_from(response)
@@ -217,14 +216,14 @@ module ActiveMerchant #:nodoc:
 
       def authorization_from(response)
         if response[:token]
-          [response[:token], response[:customerpaymentinfokey], response[:expdate]].join("|")
+          [response[:token], response[:customerpaymentinfokey], response[:expdate]].join('|')
         else
-          [response[:authcode], response[:pnref]].join("|")
+          [response[:authcode], response[:pnref]].join('|')
         end
       end
 
       def split_authorization(authorization)
-        authcode, pnref = authorization.split("|")
+        authcode, pnref = authorization.split('|')
         [authcode, pnref]
       end
 
@@ -236,9 +235,9 @@ module ActiveMerchant #:nodoc:
 
       def post_data(post)
         {
-          :UserName => @options[:user_name],
-          :Password => @options[:password]
-        }.merge(post).collect{|k,v| "#{k}=#{CGI.escape(v.to_s)}"}.join("&")
+          UserName: @options[:user_name],
+          Password: @options[:password]
+        }.merge(post).collect { |k, v| "#{k}=#{CGI.escape(v.to_s)}" }.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/cams.rb

@@ -1,11 +1,11 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CamsGateway < Gateway
-      self.live_url = "https://secure.centralams.com/gw/api/transact.php"
+      self.live_url = 'https://secure.centralams.com/gw/api/transact.php'
 
       self.supported_countries = ['US']
       self.default_currency = 'USD'
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       self.homepage_url = 'https://www.centralams.com/'
       self.display_name = 'CAMS: Central Account Management System'
@@ -67,12 +67,12 @@ module ActiveMerchant #:nodoc:
         '894' => STANDARD_ERROR_CODE[:processing_error]
       }
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :username, :password)
         super
       end
 
-      def purchase(money, payment, options={})
+      def purchase(money, payment, options = {})
         post = {}
         add_invoice(post, money, options)
 
@@ -83,10 +83,10 @@ module ActiveMerchant #:nodoc:
           post[:transactionid] = split_authorization(payment)[0]
         end
 
-        commit("sale", post)
+        commit('sale', post)
       end
 
-      def authorize(money, payment, options={})
+      def authorize(money, payment, options = {})
         post = {}
         add_invoice(post, money, options)
         add_payment(post, payment)
@@ -95,7 +95,7 @@ module ActiveMerchant #:nodoc:
         commit('auth', post)
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         post = {}
         add_reference(post, authorization)
         add_invoice(post, money, options)
@@ -103,20 +103,20 @@ module ActiveMerchant #:nodoc:
         commit('capture', post)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         post = {}
         add_reference(post, authorization)
         add_invoice(post, money, options)
         commit('refund', post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         post = {}
         add_reference(post, authorization)
         commit('void', post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         post = {}
         add_invoice(post, 0, options)
         add_payment(post, credit_card)
@@ -138,26 +138,26 @@ module ActiveMerchant #:nodoc:
 
       private
 
-      def add_address(post, creditcard, options={})
+      def add_address(post, creditcard, options = {})
         post[:firstname] = creditcard.first_name
-        post[:lastname ] = creditcard.last_name
+        post[:lastname]  = creditcard.last_name
 
         return unless options[:billing_address]
 
         address = options[:billing_address]
-        post[:address1 ] = address[:address1]
-        post[:address2 ] = address[:address2]
-        post[:city     ] = address[:city]
-        post[:state    ] = address[:state]
-        post[:zip      ] = address[:zip]
-        post[:country  ] = address[:country]
-        post[:phone    ] = address[:phone]
+        post[:address1] = address[:address1]
+        post[:address2] = address[:address2]
+        post[:city]     = address[:city]
+        post[:state]    = address[:state]
+        post[:zip]      = address[:zip]
+        post[:country]  = address[:country]
+        post[:phone]    = address[:phone]
       end
 
       def add_reference(post, authorization)
         transaction_id, authcode = split_authorization(authorization)
-        post["transactionid"] = transaction_id
-        post["authcode"]      = authcode
+        post['transactionid'] = transaction_id
+        post['authcode']      = authcode
       end
 
       def add_invoice(post, money, options)
@@ -167,15 +167,15 @@ module ActiveMerchant #:nodoc:
 
       def add_payment(post, payment)
         post[:ccnumber] = payment.number
-        post[:ccexp   ] = "#{payment.month.to_s.rjust(2,"0")}#{payment.year.to_s[-2..-1]}"
-        post[:cvv     ] = payment.verification_value
+        post[:ccexp] = "#{payment.month.to_s.rjust(2, '0')}#{payment.year.to_s[-2..-1]}"
+        post[:cvv] = payment.verification_value
       end
 
       def parse(body)
-        kvs = body.split("&")
+        kvs = body.split('&')
 
         kvs.inject({}) { |h, kv|
-          k,v = kv.split("=")
+          k, v = kv.split('=')
           h[k] = v
           h
         }
@@ -199,19 +199,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response["response_code"] == "100"
+        response['response_code'] == '100'
       end
 
       def message_from(response)
-        response["responsetext"]
+        response['responsetext']
       end
 
       def authorization_from(response)
-        [response["transactionid"], response["authcode"]].join("#")
+        [response['transactionid'], response['authcode']].join('#')
       end
 
       def split_authorization(authorization)
-        transaction_id, authcode = authorization.split("#")
+        transaction_id, authcode = authorization.split('#')
         [transaction_id, authcode]
       end
 
@@ -219,11 +219,11 @@ module ActiveMerchant #:nodoc:
         parameters[:password] = @options[:password]
         parameters[:username] = @options[:username]
 
-        parameters.collect{|k,v| "#{k}=#{v}" }.join("&")
+        parameters.collect { |k, v| "#{k}=#{v}" }.join('&')
       end
 
       def error_code_from(response)
-        STANDARD_ERROR_CODE_MAPPING[response["response_code"]]
+        STANDARD_ERROR_CODE_MAPPING[response['response_code']]
       end
     end
   end

data/lib/active_merchant/billing/gateways/card_connect.rb

@@ -1,12 +1,12 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CardConnectGateway < Gateway
-      self.test_url = 'https://fts.cardconnect.com:6443/cardconnect/rest/'
-      self.live_url = 'https://fts.cardconnect.com:8443/cardconnect/rest/'
+      self.test_url = 'https://fts-uat.cardconnect.com/cardconnect/rest/'
+      self.live_url = 'https://fts.cardconnect.com/cardconnect/rest/'
 
       self.supported_countries = ['US']
       self.default_currency = 'USD'
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       self.homepage_url = 'https://cardconnect.com/'
       self.display_name = 'Card Connect'
@@ -61,6 +61,8 @@ module ActiveMerchant #:nodoc:
         '60' => STANDARD_ERROR_CODE[:pickup_card]
       }
 
+      SCHEDULED_PAYMENT_TYPES = %w(recurring installment)
+
       def initialize(options = {})
         requires!(options, :merchant_id, :username, :password)
         require_valid_domain!(options, :domain)
@@ -68,8 +70,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def require_valid_domain!(options, param)
-        if options.key?(param)
-          raise ArgumentError.new('not a valid cardconnect domain') unless /\Dcardconnect.com:\d{1,}\D/ =~ options[param]
+        if options[param]
+          raise ArgumentError.new('not a valid cardconnect domain') unless /https:\/\/\D*cardconnect.com/ =~ options[param]
         end
       end
 
@@ -87,7 +89,9 @@ module ActiveMerchant #:nodoc:
           add_currency(post, money, options)
           add_address(post, options)
           add_customer_data(post, options)
-          add_3DS(post, options)
+          add_three_ds_mpi_data(post, options)
+          add_additional_data(post, options)
+          add_stored_credential(post, options)
           post[:capture] = 'Y'
           commit('auth', post)
         end
@@ -101,7 +105,9 @@ module ActiveMerchant #:nodoc:
         add_payment(post, payment)
         add_address(post, options)
         add_customer_data(post, options)
-        add_3DS(post, options)
+        add_three_ds_mpi_data(post, options)
+        add_additional_data(post, options)
+        add_stored_credential(post, options)
         commit('auth', post)
       end
 
@@ -130,17 +136,32 @@ module ActiveMerchant #:nodoc:
         authorize(0, credit_card, options)
       end
 
+      def store(payment, options = {})
+        post = {}
+        add_payment(post, payment)
+        add_address(post, options)
+        add_customer_data(post, options)
+        commit('profile', post)
+      end
+
+      def unstore(authorization, options = {})
+        account_id, profile_id = authorization.split('|')
+        commit('profile', {},
+          verb: :delete,
+          path: "/#{profile_id}/#{account_id}/#{@options[:merchant_id]}")
+      end
+
       def supports_scrubbing?
         true
       end
 
       def scrub(transcript)
-        transcript
-          .gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]')
-          .gsub(%r(("cvv2\\":\\")\d*), '\1[FILTERED]')
-          .gsub(%r(("merchid\\":\\")\d*), '\1[FILTERED]')
-          .gsub(%r((&?"account\\":\\")\d*), '\1[FILTERED]')
-          .gsub(%r((&?"token\\":\\")\d*), '\1[FILTERED]')
+        transcript.
+          gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]').
+          gsub(%r(("cvv2\\":\\")\d*), '\1[FILTERED]').
+          gsub(%r(("merchid\\":\\")\d*), '\1[FILTERED]').
+          gsub(%r((&?"account\\":\\")\d*), '\1[FILTERED]').
+          gsub(%r((&?"token\\":\\")\d*), '\1[FILTERED]')
       end
 
       private
@@ -152,7 +173,7 @@ module ActiveMerchant #:nodoc:
       def add_address(post, options)
         if address = options[:billing_address] || options[:address]
           post[:address] = address[:address1] if address[:address1]
-          post[:address].concat(" #{address[:address2]}") if address[:address2]
+          post[:address2] = address[:address2] if address[:address2]
           post[:city] = address[:city] if address[:city]
           post[:region] = address[:state] if address[:state]
           post[:country] = address[:country] if address[:country]
@@ -171,17 +192,27 @@ module ActiveMerchant #:nodoc:
 
       def add_invoice(post, options)
         post[:orderid] = options[:order_id]
-        post[:ecomind] = (options[:recurring] ? 'R' : 'E')
+        post[:ecomind] = if options[:ecomind]
+                           options[:ecomind].capitalize
+                         else
+                           (options[:recurring] ? 'R' : 'E')
+                         end
       end
 
       def add_payment(post, payment)
-        post[:name] = payment.name
-        if card_brand(payment) == 'check'
-          add_echeck(post, payment)
+        if payment.is_a?(String)
+          account_id, profile_id = payment.split('|')
+          post[:profile] = profile_id
+          post[:acctid] = account_id
         else
-          post[:account] = payment.number
-          post[:expiry] = expdate(payment)
-          post[:cvv2] = payment.verification_value
+          post[:name] = payment.name
+          if card_brand(payment) == 'check'
+            add_echeck(post, payment)
+          else
+            post[:account] = payment.number
+            post[:expiry] = expdate(payment)
+            post[:cvv2] = payment.verification_value
+          end
         end
       end
 
@@ -210,16 +241,28 @@ module ActiveMerchant #:nodoc:
           post[:items] = options[:items].map do |item|
             updated = {}
             item.each_pair do |k, v|
-              updated.merge!(k.to_s.gsub(/_/, '') => v)
+              updated.merge!(k.to_s.delete('_') => v)
             end
+            updated
           end
         end
+        post[:userfields] = options[:user_fields] if options[:user_fields]
       end
 
-      def add_3DS(post, options)
-        post[:secureflag] = options[:secure_flag] if options[:secure_flag]
-        post[:securevalue] = options[:secure_value] if options[:secure_value]
-        post[:securexid] = options[:secure_xid] if options[:secure_xid]
+      def add_three_ds_mpi_data(post, options)
+        return unless three_d_secure = options[:three_d_secure]
+
+        post[:secureflag]  = three_d_secure[:eci]
+        post[:securevalue] = three_d_secure[:cavv]
+        post[:securedstid] = three_d_secure[:ds_transaction_id]
+      end
+
+      def add_stored_credential(post, options)
+        return unless stored_credential = options[:stored_credential]
+
+        post[:cof] = stored_credential[:initiator] == 'merchant' ? 'M' : 'C'
+        post[:cofscheduled] = SCHEDULED_PAYMENT_TYPES.include?(stored_credential[:reason_type]) ? 'Y' : 'N'
+        post[:cofpermission] = stored_credential[:initial_transaction] ? 'Y' : 'N'
       end
 
       def headers
@@ -237,18 +280,19 @@ module ActiveMerchant #:nodoc:
         JSON.parse(body)
       end
 
-      def url(action)
+      def url(action, path)
         if test?
-          test_url + action
+          test_url + action + path
         else
-          (@options[:domain] ? @options[:domain] : live_url) + action
+          (@options[:domain] || live_url) + action + path
         end
       end
 
-      def commit(action, parameters)
+      def commit(action, parameters, verb: :put, path: '')
+        parameters[:frontendid] = application_id
         parameters[:merchid] = @options[:merchant_id]
-        url = url(action)
-        response = parse(ssl_request(:put, url, post_data(parameters), headers))
+        url = url(action, path)
+        response = parse(ssl_request(verb, url, post_data(parameters), headers))
 
         Response.new(
           success_from(response),
@@ -260,6 +304,10 @@ module ActiveMerchant #:nodoc:
           test: test?,
           error_code: error_code_from(response)
         )
+      rescue ResponseError => e
+        return Response.new(false, 'Unable to authenticate.  Please check your credentials.', {}, test: test?) if e.response.code == '401'
+
+        raise
       end
 
       def success_from(response)
@@ -271,7 +319,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_from(response)
-        response['retref']
+        if response['profileid']
+          "#{response['acctid']}|#{response['profileid']}"
+        else
+          response['retref']
+        end
       end
 
       def post_data(parameters = {})

data/lib/active_merchant/billing/gateways/card_save.rb

@@ -1,23 +1,21 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CardSaveGateway < IridiumGateway
-      #CardSave lets you handle failovers on payments by providing 3 gateways in case one happens to be down
-      #URLS = ['https://gw1.cardsaveonlinepayments.com:4430/','https://gw2.cardsaveonlinepayments.com:4430/','https://gw3.cardsaveonlinepayments.com:4430/']      
-      
+      # CardSave lets you handle failovers on payments by providing 3 gateways in case one happens to be down
+      # URLS = ['https://gw1.cardsaveonlinepayments.com:4430/','https://gw2.cardsaveonlinepayments.com:4430/','https://gw3.cardsaveonlinepayments.com:4430/']
+
       self.money_format = :cents
       self.default_currency = 'GBP'
-      self.supported_cardtypes = [ :visa, :switch, :maestro, :master, :solo, :american_express, :jcb ]
-      self.supported_countries = [ 'GB' ]
+      self.supported_cardtypes = %i[visa maestro master american_express jcb]
+      self.supported_countries = ['GB']
       self.homepage_url = 'http://www.cardsave.net/'
       self.display_name = 'CardSave'
-      
-      def initialize(options={})
+
+      def initialize(options = {})
         super
         @test_url = 'https://gw1.cardsaveonlinepayments.com:4430/'
         @live_url = 'https://gw1.cardsaveonlinepayments.com:4430/'
       end
-      
     end
   end
 end
-