activemerchant 1.79.2 → 1.129.0

data/lib/active_merchant/billing/gateways/payscout.rb

@@ -4,7 +4,7 @@ module ActiveMerchant #:nodoc:
       self.live_url = self.test_url = 'https://secure.payscout.com/api/transact.php'
 
       self.supported_countries = ['US']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
       self.default_currency = 'USD'
       self.homepage_url = 'http://www.payscout.com/'
       self.display_name = 'Payscout'
@@ -41,7 +41,6 @@ module ActiveMerchant #:nodoc:
         commit('capture', money, post)
       end
 
-
       def refund(money, authorization, options = {})
         post = {}
         post[:transactionid] = authorization
@@ -63,7 +62,7 @@ module ActiveMerchant #:nodoc:
           post[:address1] = address[:address1].to_s
           post[:address2] = address[:address2].to_s
           post[:city]     = address[:city].to_s
-          post[:state]    = (address[:state].blank?  ? 'n/a' : address[:state])
+          post[:state]    = (address[:state].blank? ? 'n/a' : address[:state])
           post[:zip]      = address[:zip].to_s
           post[:country]  = address[:country].to_s
           post[:phone]    = address[:phone].to_s
@@ -79,7 +78,7 @@ module ActiveMerchant #:nodoc:
           post[:shipping_address2]  = address[:address2].to_s
           post[:shipping_city]      = address[:city].to_s
           post[:shipping_country]   = address[:country].to_s
-          post[:shipping_state]     = (address[:state].blank?  ? 'n/a' : address[:state])
+          post[:shipping_state]     = (address[:state].blank? ? 'n/a' : address[:state])
           post[:shipping_zip]       = address[:zip].to_s
           post[:shipping_email]     = address[:email].to_s
         end
@@ -103,7 +102,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(body)
-        Hash[body.split('&').map{|x|x.split('=')}]
+        Hash[body.split('&').map { |x| x.split('=') }]
       end
 
       def commit(action, money, parameters)
@@ -117,12 +116,11 @@ module ActiveMerchant #:nodoc:
         message = message_from(response)
         test_mode = (test? || message =~ /TESTMODE/)
         Response.new(success?(response), message, response,
-          :test => test_mode,
-          :authorization => response['transactionid'],
-          :fraud_review => fraud_review?(response),
-          :avs_result => { :code => response['avsresponse'] },
-          :cvv_result => response['cvvresponse']
-        )
+          test: test_mode,
+          authorization: response['transactionid'],
+          fraud_review: fraud_review?(response),
+          avs_result: { code: response['avsresponse'] },
+          cvv_result: response['cvvresponse'])
       end
 
       def message_from(response)
@@ -153,10 +151,9 @@ module ActiveMerchant #:nodoc:
         post[:password]       = @options[:password]
         post[:type]           = action
 
-        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
         request
       end
     end
   end
 end
-

data/lib/active_merchant/billing/gateways/paystation.rb

@@ -1,8 +1,7 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PaystationGateway < Gateway
-
-      self.live_url = self.test_url = "https://www.paystation.co.nz/direct/paystation.dll"
+      self.live_url = self.test_url = 'https://www.paystation.co.nz/direct/paystation.dll'
 
       # an "error code" of "0" means "No error - transaction successful"
       SUCCESSFUL_RESPONSE_CODE = '0'
@@ -14,7 +13,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['NZ']
 
       # TODO: check this with paystation (amex and diners need to be enabled)
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club ]
+      self.supported_cardtypes = %i[visa master american_express diners_club]
 
       self.homepage_url        = 'http://paystation.co.nz'
       self.display_name        = 'Paystation'
@@ -75,7 +74,7 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         post = new_request
         add_amount(post, money, options)
         add_invoice(post, options)
@@ -84,7 +83,7 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         authorize(0, credit_card, options)
       end
 
@@ -100,107 +99,105 @@ module ActiveMerchant #:nodoc:
 
       private
 
-        def new_request
-          {
-            :pi    => @options[:paystation_id], # paystation account id
-            :gi    => @options[:gateway_id],    # paystation gateway id
-            "2p"   => "t",                      # two-party transaction type
-            :nr    => "t",                      # -- redirect??
-            :df    => "yymm"                    # date format: optional sometimes, required others
-          }
-        end
-
-        def add_customer_data(post, options)
-          post[:mc] = options[:customer]
-        end
+      def new_request
+        {
+          :pi    => @options[:paystation_id], # paystation account id
+          :gi    => @options[:gateway_id],    # paystation gateway id
+          '2p'   => 't',                      # two-party transaction type
+          :nr    => 't',                      # -- redirect??
+          :df    => 'yymm'                    # date format: optional sometimes, required others
+        }
+      end
 
-        def add_invoice(post, options)
-          post[:ms] = generate_unique_id
-          post[:mo] = options[:description]
-          post[:mr] = options[:order_id]
-        end
+      def add_customer_data(post, options)
+        post[:mc] = options[:customer]
+      end
 
-        def add_credit_card(post, credit_card)
-          post[:cn] = credit_card.number
-          post[:ct] = credit_card.brand
-          post[:ex] = format_date(credit_card.month, credit_card.year)
-          post[:cc] = credit_card.verification_value if credit_card.verification_value?
-        end
+      def add_invoice(post, options)
+        post[:ms] = generate_unique_id
+        post[:mo] = options[:description]
+        post[:mr] = options[:order_id]
+      end
 
-        def add_token(post, token)
-          post[:fp] = "t"    # turn on "future payments" - what paystation calls Token Billing
-          post[:ft] = token
-        end
+      def add_credit_card(post, credit_card)
+        post[:cn] = credit_card.number
+        post[:ct] = credit_card.brand
+        post[:ex] = format_date(credit_card.month, credit_card.year)
+        post[:cc] = credit_card.verification_value if credit_card.verification_value?
+      end
 
-        def store_credit_card(post, options)
-          post[:fp] = "t"                                # turn on "future payments" - what paystation calls Token Billing
-          post[:fs] = "t"                                # tells paystation to store right now, not bill
-          post[:ft] = options[:token] if options[:token] # specify a token to use that, or let Paystation generate one
-        end
+      def add_token(post, token)
+        post[:fp] = 't' # turn on "future payments" - what paystation calls Token Billing
+        post[:ft] = token
+      end
 
-        def add_authorize_flag(post, options)
-          post[:pa] = "t" # tells Paystation that this is a pre-auth authorisation payment (account must be in pre-auth mode)
-        end
+      def store_credit_card(post, options)
+        post[:fp] = 't'                                # turn on "future payments" - what paystation calls Token Billing
+        post[:fs] = 't'                                # tells paystation to store right now, not bill
+        post[:ft] = options[:token] if options[:token] # specify a token to use that, or let Paystation generate one
+      end
 
-        def add_refund_specific_fields(post, authorization)
-          post[:rc] = "t"
-          post[:rt] = authorization
-        end
+      def add_authorize_flag(post, options)
+        post[:pa] = 't' # tells Paystation that this is a pre-auth authorisation payment (account must be in pre-auth mode)
+      end
 
-        def add_authorization_token(post, auth_token, verification_value = nil)
-          post[:cp] = "t" # Capture Payment flag – tells Paystation this transaction should be treated as a capture payment
-          post[:cx] = auth_token
-          post[:cc] = verification_value
-        end
+      def add_refund_specific_fields(post, authorization)
+        post[:rc] = 't'
+        post[:rt] = authorization
+      end
 
-        def add_amount(post, money, options)
-          post[:am] = amount(money)
-          post[:cu] = options[:currency] || currency(money)
-        end
+      def add_authorization_token(post, auth_token, verification_value = nil)
+        post[:cp] = 't' # Capture Payment flag – tells Paystation this transaction should be treated as a capture payment
+        post[:cx] = auth_token
+        post[:cc] = verification_value
+      end
 
-        def parse(xml_response)
-          response = {}
+      def add_amount(post, money, options)
+        post[:am] = amount(money)
+        post[:cu] = options[:currency] || currency(money)
+      end
 
-          xml = REXML::Document.new(xml_response)
+      def parse(xml_response)
+        response = {}
 
-          xml.elements.each("#{xml.root.name}/*") do |element|
-            response[element.name.underscore.to_sym] = element.text
-          end
+        xml = REXML::Document.new(xml_response)
 
-          response
+        xml.elements.each("#{xml.root.name}/*") do |element|
+          response[element.name.underscore.to_sym] = element.text
         end
 
-        def commit(post)
-          post[:tm] = "T" if test?
-          pstn_prefix_params = post.collect { |key, value| "pstn_#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        response
+      end
 
-          data     = ssl_post(self.live_url, "#{pstn_prefix_params}&paystation=_empty")
-          response = parse(data)
-          message  = message_from(response)
+      def commit(post)
+        post[:tm] = 'T' if test?
+        pstn_prefix_params = post.collect { |key, value| "pstn_#{key}=#{CGI.escape(value.to_s)}" }.join('&')
 
-          PaystationResponse.new(success?(response), message, response,
-              :test          => (response[:tm] && response[:tm].downcase == "t"),
-              :authorization => response[:paystation_transaction_id]
-          )
-        end
+        data     = ssl_post(self.live_url, "#{pstn_prefix_params}&paystation=_empty")
+        response = parse(data)
+        message  = message_from(response)
 
-        def success?(response)
-          (response[:ec] == SUCCESSFUL_RESPONSE_CODE) || (response[:ec] == SUCCESSFUL_FUTURE_PAYMENT)
-        end
+        PaystationResponse.new(success?(response), message, response,
+          test: (response[:tm]&.casecmp('t')&.zero?),
+          authorization: response[:paystation_transaction_id])
+      end
 
-        def message_from(response)
-          response[:em]
-        end
+      def success?(response)
+        (response[:ec] == SUCCESSFUL_RESPONSE_CODE) || (response[:ec] == SUCCESSFUL_FUTURE_PAYMENT)
+      end
 
-        def format_date(month, year)
-          "#{format(year, :two_digits)}#{format(month, :two_digits)}"
-        end
+      def message_from(response)
+        response[:em]
+      end
 
+      def format_date(month, year)
+        "#{format(year, :two_digits)}#{format(month, :two_digits)}"
+      end
     end
 
     class PaystationResponse < Response
       def token
-        @params["future_payment_token"]
+        @params['future_payment_token']
       end
     end
   end

data/lib/active_merchant/billing/gateways/payu_in.rb

@@ -3,25 +3,25 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PayuInGateway < Gateway
-      self.test_url = "https://test.payu.in/_payment"
-      self.live_url = "https://secure.payu.in/_payment"
+      self.test_url = 'https://test.payu.in/_payment'
+      self.live_url = 'https://secure.payu.in/_payment'
 
-      TEST_INFO_URL = "https://test.payu.in/merchant/postservice.php?form=2"
-      LIVE_INFO_URL = "https://info.payu.in/merchant/postservice.php?form=2"
+      TEST_INFO_URL = 'https://test.payu.in/merchant/postservice.php?form=2'
+      LIVE_INFO_URL = 'https://info.payu.in/merchant/postservice.php?form=2'
 
       self.supported_countries = ['IN']
       self.default_currency = 'INR'
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :maestro]
+      self.supported_cardtypes = %i[visa master american_express diners_club maestro]
 
       self.homepage_url = 'https://www.payu.in/'
       self.display_name = 'PayU India'
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :key, :salt)
         super
       end
 
-      def purchase(money, payment, options={})
+      def purchase(money, payment, options = {})
         requires!(options, :order_id)
 
         post = {}
@@ -32,28 +32,28 @@ module ActiveMerchant #:nodoc:
         add_auth(post)
 
         MultiResponse.run do |r|
-          r.process{commit(url("purchase"), post)}
-          if(r.params["enrolled"].to_s == "0")
-            r.process{commit(r.params["post_uri"], r.params["form_post_vars"])}
+          r.process { commit(url('purchase'), post) }
+          if r.params['enrolled'].to_s == '0'
+            r.process { commit(r.params['post_uri'], r.params['form_post_vars']) }
           else
-            r.process{handle_3dsecure(r)}
+            r.process { handle_3dsecure(r) }
           end
         end
       end
 
-      def refund(money, authorization, options={})
-        raise ArgumentError, "Amount is required" unless money
+      def refund(money, authorization, options = {})
+        raise ArgumentError, 'Amount is required' unless money
 
         post = {}
 
-        post[:command] = "cancel_refund_transaction"
+        post[:command] = 'cancel_refund_transaction'
         post[:var1] = authorization
         post[:var2] = generate_unique_id
         post[:var3] = amount(money)
 
         add_auth(post, :command, :var1)
 
-        commit(url("refund"), post)
+        commit(url('refund'), post)
       end
 
       def supports_scrubbing?
@@ -82,17 +82,17 @@ module ActiveMerchant #:nodoc:
 
         digest_keys = PAYMENT_DIGEST_KEYS if digest_keys.empty?
         digest = Digest::SHA2.new(512)
-        digest << @options[:key] << "|"
+        digest << @options[:key] << '|'
         digest_keys.each do |key|
-          digest << (post[key.to_sym] || "") << "|"
+          digest << (post[key.to_sym] || '') << '|'
         end
         digest << @options[:salt]
         post[:hash] = digest.hexdigest
       end
 
       def add_customer_data(post, options)
-        post[:email] = clean(options[:email] || "unknown@example.com", nil, 50)
-        post[:phone] = clean((options[:billing_address] && options[:billing_address][:phone]) || "11111111111", :numeric, 50)
+        post[:email] = clean(options[:email] || 'unknown@example.com', nil, 50)
+        post[:phone] = clean((options[:billing_address] && options[:billing_address][:phone]) || '11111111111', :numeric, 50)
       end
 
       def add_addresses(post, options)
@@ -109,7 +109,7 @@ module ActiveMerchant #:nodoc:
           if options[:shipping_address][:name]
             first, *rest = options[:shipping_address][:name].split(/\s+/)
             post[:shipping_firstname] = clean(first, :name, 60)
-            post[:shipping_lastname] = clean(rest.join(" "), :name, 20)
+            post[:shipping_lastname] = clean(rest.join(' '), :name, 20)
           end
           post[:shipping_address1] = clean(options[:shipping_address][:address1], :text, 100)
           post[:shipping_address2] = clean(options[:shipping_address][:address2], :text, 100)
@@ -125,22 +125,22 @@ module ActiveMerchant #:nodoc:
         post[:amount] = amount(money)
 
         post[:txnid] = clean(options[:order_id], :alphanumeric, 30)
-        post[:productinfo] = clean(options[:description] || "Purchase", nil, 100)
+        post[:productinfo] = clean(options[:description] || 'Purchase', nil, 100)
 
-        post[:surl] = "http://example.com"
-        post[:furl] = "http://example.com"
+        post[:surl] = 'http://example.com'
+        post[:furl] = 'http://example.com'
       end
 
       BRAND_MAP = {
-        visa: "VISA",
-        master: "MAST",
-        american_express: "AMEX",
-        diners_club: "DINR",
-        maestro: "MAES"
+        visa: 'VISA',
+        master: 'MAST',
+        american_express: 'AMEX',
+        diners_club: 'DINR',
+        maestro: 'MAES'
       }
 
       def add_payment(post, payment)
-        post[:pg] = "CC"
+        post[:pg] = 'CC'
         post[:firstname] = clean(payment.first_name, :name, 60)
         post[:lastname] = clean(payment.last_name, :name, 20)
 
@@ -153,31 +153,32 @@ module ActiveMerchant #:nodoc:
       end
 
       def clean(value, format, maxlength)
-        value ||= ""
-        value = case format
-        when :alphanumeric
-          value.gsub(/[^A-Za-z0-9]/, "")
-        when :name
-          value.gsub(/[^A-Za-z ]/, "")
-        when :numeric
-          value.gsub(/[^0-9]/, "")
-        when :text
-          value.gsub(/[^A-Za-z0-9@\-_\/\. ]/, "")
-        when nil
-          value
-        else
-          raise "Unknown format #{format} for #{value}"
-        end
+        value ||= ''
+        value =
+          case format
+          when :alphanumeric
+            value.gsub(/[^A-Za-z0-9]/, '')
+          when :name
+            value.gsub(/[^A-Za-z ]/, '')
+          when :numeric
+            value.gsub(/[^0-9]/, '')
+          when :text
+            value.gsub(/[^A-Za-z0-9@\-_\/\. ]/, '')
+          when nil
+            value
+          else
+            raise "Unknown format #{format} for #{value}"
+          end
         value[0...maxlength]
       end
 
       def parse(body)
         top = JSON.parse(body)
 
-        if result = top.delete("result")
-          result.split("&").inject({}) do |hash, string|
-            key, value = string.split("=")
-            hash[CGI.unescape(key).downcase] = CGI.unescape(value || "")
+        if result = top.delete('result')
+          result.split('&').inject({}) do |hash, string|
+            key, value = string.split('=')
+            hash[CGI.unescape(key).downcase] = CGI.unescape(value || '')
             hash
           end.each do |key, value|
             if top[key]
@@ -188,19 +189,19 @@ module ActiveMerchant #:nodoc:
           end
         end
 
-        if response = top.delete("response")
+        if response = top.delete('response')
           top.merge!(response)
         end
 
         top
       rescue JSON::ParserError
         {
-          "error" => "Invalid response received from the PayU API. (The raw response was `#{body}`)."
+          'error' => "Invalid response received from the PayU API. (The raw response was `#{body}`)."
         }
       end
 
       def commit(url, parameters)
-        response = parse(ssl_post(url, post_data(parameters), "Accept-Encoding" => "identity"))
+        response = parse(ssl_post(url, post_data(parameters), 'Accept-Encoding' => 'identity'))
 
         Response.new(
           success_from(response),
@@ -213,7 +214,7 @@ module ActiveMerchant #:nodoc:
 
       def url(action)
         case action
-        when "purchase"
+        when 'purchase'
           (test? ? test_url : live_url)
         else
           (test? ? TEST_INFO_URL : LIVE_INFO_URL)
@@ -221,19 +222,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        if response["result_status"]
-          (response["status"] == "success" && response["result_status"] == "success")
+        if response['result_status']
+          (response['status'] == 'success' && response['result_status'] == 'success')
         else
-          (response["status"] == "success" || response["status"].to_s == "1")
+          (response['status'] == 'success' || response['status'].to_s == '1')
         end
       end
 
       def message_from(response)
-        (response["error_message"] || response["error"] || response["msg"])
+        (response['error_message'] || response['error'] || response['msg'])
       end
 
       def authorization_from(response)
-        response["mihpayid"]
+        response['mihpayid']
       end
 
       def post_data(parameters = {})
@@ -241,7 +242,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def handle_3dsecure(response)
-        Response.new(false, "3D-secure enrolled cards are not supported.")
+        Response.new(false, '3D-secure enrolled cards are not supported.')
       end
     end
   end