activemerchant 1.79.2 → 1.129.0

data/lib/active_merchant/billing/gateways/evo_ca.rb

@@ -36,7 +36,7 @@ module ActiveMerchant #:nodoc:
       self.live_url = 'https://secure.evoepay.com/api/transact.php'
 
       self.supported_countries  = ['CA']
-      self.supported_cardtypes  = [:visa, :master, :american_express, :jcb, :discover]
+      self.supported_cardtypes  = %i[visa master american_express jcb discover]
       self.money_format         = :dollars
       self.homepage_url         = 'http://www.evocanada.com/'
       self.display_name         = 'EVO Canada'
@@ -139,8 +139,8 @@ module ActiveMerchant #:nodoc:
       # <tt>options</tt>.
       def capture(money, authorization, options = {})
         post = {
-          :amount         => amount(money),
-          :transactionid  => authorization
+          amount: amount(money),
+          transactionid: authorization
         }
         add_order(post, options)
         commit('capture', money, post)
@@ -153,7 +153,7 @@ module ActiveMerchant #:nodoc:
       # The <tt>identification</tt> parameter is the transaction ID, retrieved
       # from {Response#authorization}.
       def refund(money, identification)
-        post = {:transactionid => identification}
+        post = { transactionid: identification }
         commit('refund', money, post)
       end
 
@@ -181,7 +181,7 @@ module ActiveMerchant #:nodoc:
       # The <tt>identification</tt> parameter is the transaction ID, retrieved
       # from {Response#authorization}.
       def void(identification)
-        post = {:transactionid => identification}
+        post = { transactionid: identification }
         commit('void', nil, post)
       end
 
@@ -192,7 +192,7 @@ module ActiveMerchant #:nodoc:
       # The <tt>identification</tt> parameter is the transaction ID, retrieved
       # from {Response#authorization}.
       def update(identification, options)
-        post = {:transactionid => identification}
+        post = { transactionid: identification }
         add_order(post, options)
         commit('update', nil, post)
       end
@@ -245,7 +245,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_paymentmethod(post, payment)
-        if card_brand(payment)=='check'
+        if card_brand(payment) == 'check'
           post[:payment]              = 'check'
           post[:checkname]            = payment.name
           post[:checkaba]             = payment.routing_number
@@ -280,11 +280,10 @@ module ActiveMerchant #:nodoc:
         message = message_from(response)
 
         Response.new(success?(response), message, response,
-          :test          => test?,
-          :authorization => response['transactionid'],
-          :avs_result    => { :code => response['avsresponse'] },
-          :cvv_result    => response['cvvresponse']
-        )
+          test: test?,
+          authorization: response['transactionid'],
+          avs_result: { code: response['avsresponse'] },
+          cvv_result: response['cvvresponse'])
       end
 
       def message_from(response)
@@ -292,7 +291,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def post_data(action, parameters = {})
-        post = {:type => action}
+        post = { type: action }
 
         if test?
           post[:username] = 'demo'
@@ -301,7 +300,7 @@ module ActiveMerchant #:nodoc:
           post[:username] = options[:username]
           post[:password] = options[:password]
         end
-        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" unless value.nil? }.compact.join("&")
+        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" unless value.nil? }.compact.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/eway.rb

@@ -9,7 +9,7 @@ module ActiveMerchant #:nodoc:
 
       self.money_format = :cents
       self.supported_countries = ['AU']
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express diners_club]
       self.homepage_url = 'http://www.eway.com.au/'
       self.display_name = 'eWAY'
 
@@ -38,7 +38,7 @@ module ActiveMerchant #:nodoc:
         commit(purchase_url(post[:CVN]), money, post)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         post = {}
 
         add_customer_id(post)
@@ -64,14 +64,15 @@ module ActiveMerchant #:nodoc:
       end
 
       private
+
       def requires_address!(options)
-        raise ArgumentError.new("Missing eWay required parameters: address or billing_address") unless (options.has_key?(:address) or options.has_key?(:billing_address))
+        raise ArgumentError.new('Missing eWay required parameters: address or billing_address') unless options.has_key?(:address) || options.has_key?(:billing_address)
       end
 
       def add_creditcard(post, creditcard)
-        post[:CardNumber]  = creditcard.number
-        post[:CardExpiryMonth]  = sprintf("%.2i", creditcard.month)
-        post[:CardExpiryYear] = sprintf("%.4i", creditcard.year)[-2..-1]
+        post[:CardNumber] = creditcard.number
+        post[:CardExpiryMonth] = sprintf('%.2i', creditcard.month)
+        post[:CardExpiryYear] = sprintf('%.4i', creditcard.year)[-2..-1]
         post[:CustomerFirstName] = creditcard.first_name
         post[:CustomerLastName]  = creditcard.last_name
         post[:CardHoldersName] = creditcard.name
@@ -81,7 +82,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, options)
         if address = options[:billing_address] || options[:address]
-          post[:CustomerAddress]    = [ address[:address1], address[:address2], address[:city], address[:state], address[:country] ].compact.join(', ')
+          post[:CustomerAddress]    = [address[:address1], address[:address2], address[:city], address[:state], address[:country]].compact.join(', ')
           post[:CustomerPostcode]   = address[:zip]
         end
       end
@@ -113,13 +114,12 @@ module ActiveMerchant #:nodoc:
         Response.new(success?(response),
           message_from(response[:ewaytrxnerror]),
           response,
-          :authorization => response[:ewaytrxnnumber],
-          :test => test?
-        )
+          authorization: response[:ewaytrxnnumber],
+          test: test?)
       end
 
       def success?(response)
-        response[:ewaytrxnstatus] == "True"
+        response[:ewaytrxnstatus] == 'True'
       end
 
       def parse(xml)
@@ -134,7 +134,7 @@ module ActiveMerchant #:nodoc:
 
       def post_data(parameters = {})
         xml   = REXML::Document.new
-        root  = xml.add_element("ewaygateway")
+        root  = xml.add_element('ewaygateway')
 
         parameters.each do |key, value|
           root.add_element("eway#{key}").text = value
@@ -144,7 +144,8 @@ module ActiveMerchant #:nodoc:
 
       def message_from(message)
         return '' if message.blank?
-        MESSAGES[message[0,2]] || message
+
+        MESSAGES[message[0, 2]] || message
       end
 
       def purchase_url(cvn)
@@ -159,66 +160,66 @@ module ActiveMerchant #:nodoc:
       end
 
       MESSAGES = {
-        "00" => "Transaction Approved",
-        "01" => "Refer to Issuer",
-        "02" => "Refer to Issuer, special",
-        "03" => "No Merchant",
-        "04" => "Pick Up Card",
-        "05" => "Do Not Honour",
-        "06" => "Error",
-        "07" => "Pick Up Card, Special",
-        "08" => "Honour With Identification",
-        "09" => "Request In Progress",
-        "10" => "Approved For Partial Amount",
-        "11" => "Approved, VIP",
-        "12" => "Invalid Transaction",
-        "13" => "Invalid Amount",
-        "14" => "Invalid Card Number",
-        "15" => "No Issuer",
-        "16" => "Approved, Update Track 3",
-        "19" => "Re-enter Last Transaction",
-        "21" => "No Action Taken",
-        "22" => "Suspected Malfunction",
-        "23" => "Unacceptable Transaction Fee",
-        "25" => "Unable to Locate Record On File",
-        "30" => "Format Error",
-        "31" => "Bank Not Supported By Switch",
-        "33" => "Expired Card, Capture",
-        "34" => "Suspected Fraud, Retain Card",
-        "35" => "Card Acceptor, Contact Acquirer, Retain Card",
-        "36" => "Restricted Card, Retain Card",
-        "37" => "Contact Acquirer Security Department, Retain Card",
-        "38" => "PIN Tries Exceeded, Capture",
-        "39" => "No Credit Account",
-        "40" => "Function Not Supported",
-        "41" => "Lost Card",
-        "42" => "No Universal Account",
-        "43" => "Stolen Card",
-        "44" => "No Investment Account",
-        "51" => "Insufficient Funds",
-        "52" => "No Cheque Account",
-        "53" => "No Savings Account",
-        "54" => "Expired Card",
-        "55" => "Incorrect PIN",
-        "56" => "No Card Record",
-        "57" => "Function Not Permitted to Cardholder",
-        "58" => "Function Not Permitted to Terminal",
-        "59" => "Suspected Fraud",
-        "60" => "Acceptor Contact Acquirer",
-        "61" => "Exceeds Withdrawal Limit",
-        "62" => "Restricted Card",
-        "63" => "Security Violation",
-        "64" => "Original Amount Incorrect",
-        "66" => "Acceptor Contact Acquirer, Security",
-        "67" => "Capture Card",
-        "75" => "PIN Tries Exceeded",
-        "82" => "CVV Validation Error",
-        "90" => "Cutoff In Progress",
-        "91" => "Card Issuer Unavailable",
-        "92" => "Unable To Route Transaction",
-        "93" => "Cannot Complete, Violation Of The Law",
-        "94" => "Duplicate Transaction",
-        "96" => "System Error"
+        '00' => 'Transaction Approved',
+        '01' => 'Refer to Issuer',
+        '02' => 'Refer to Issuer, special',
+        '03' => 'No Merchant',
+        '04' => 'Pick Up Card',
+        '05' => 'Do Not Honour',
+        '06' => 'Error',
+        '07' => 'Pick Up Card, Special',
+        '08' => 'Honour With Identification',
+        '09' => 'Request In Progress',
+        '10' => 'Approved For Partial Amount',
+        '11' => 'Approved, VIP',
+        '12' => 'Invalid Transaction',
+        '13' => 'Invalid Amount',
+        '14' => 'Invalid Card Number',
+        '15' => 'No Issuer',
+        '16' => 'Approved, Update Track 3',
+        '19' => 'Re-enter Last Transaction',
+        '21' => 'No Action Taken',
+        '22' => 'Suspected Malfunction',
+        '23' => 'Unacceptable Transaction Fee',
+        '25' => 'Unable to Locate Record On File',
+        '30' => 'Format Error',
+        '31' => 'Bank Not Supported By Switch',
+        '33' => 'Expired Card, Capture',
+        '34' => 'Suspected Fraud, Retain Card',
+        '35' => 'Card Acceptor, Contact Acquirer, Retain Card',
+        '36' => 'Restricted Card, Retain Card',
+        '37' => 'Contact Acquirer Security Department, Retain Card',
+        '38' => 'PIN Tries Exceeded, Capture',
+        '39' => 'No Credit Account',
+        '40' => 'Function Not Supported',
+        '41' => 'Lost Card',
+        '42' => 'No Universal Account',
+        '43' => 'Stolen Card',
+        '44' => 'No Investment Account',
+        '51' => 'Insufficient Funds',
+        '52' => 'No Cheque Account',
+        '53' => 'No Savings Account',
+        '54' => 'Expired Card',
+        '55' => 'Incorrect PIN',
+        '56' => 'No Card Record',
+        '57' => 'Function Not Permitted to Cardholder',
+        '58' => 'Function Not Permitted to Terminal',
+        '59' => 'Suspected Fraud',
+        '60' => 'Acceptor Contact Acquirer',
+        '61' => 'Exceeds Withdrawal Limit',
+        '62' => 'Restricted Card',
+        '63' => 'Security Violation',
+        '64' => 'Original Amount Incorrect',
+        '66' => 'Acceptor Contact Acquirer, Security',
+        '67' => 'Capture Card',
+        '75' => 'PIN Tries Exceeded',
+        '82' => 'CVV Validation Error',
+        '90' => 'Cutoff In Progress',
+        '91' => 'Card Issuer Unavailable',
+        '92' => 'Unable To Route Transaction',
+        '93' => 'Cannot Complete, Violation Of The Law',
+        '94' => 'Duplicate Transaction',
+        '96' => 'System Error'
       }
     end
   end

data/lib/active_merchant/billing/gateways/eway_managed.rb

@@ -8,11 +8,11 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['AU']
 
       # The card types supported by the payment gateway
-      self.supported_cardtypes = [:visa, :master]
+      self.supported_cardtypes = %i[visa master]
 
       self.default_currency = 'AUD'
 
-      #accepted money format
+      # accepted money format
       self.money_format = :cents
 
       # The homepage URL of the gateway
@@ -46,10 +46,10 @@ module ActiveMerchant #:nodoc:
         add_address(post, billing_address)
         add_misc_fields(post, options)
 
-        commit("CreateCustomer", post)
+        commit('CreateCustomer', post)
       end
 
-      def update(billing_id, creditcard, options={})
+      def update(billing_id, creditcard, options = {})
         post = {}
 
         # Handle our required fields
@@ -59,12 +59,12 @@ module ActiveMerchant #:nodoc:
         billing_address = options[:billing_address]
         eway_requires!(billing_address)
 
-        post[:managedCustomerID]=billing_id
+        post[:managedCustomerID] = billing_id
         add_creditcard(post, creditcard)
         add_address(post, billing_address)
         add_misc_fields(post, options)
 
-        commit("UpdateCustomer", post)
+        commit('UpdateCustomer', post)
       end
 
       # Process a payment in the given amount against the stored credit card given by billing_id
@@ -80,13 +80,13 @@ module ActiveMerchant #:nodoc:
       # * <tt>:order_id</tt> -- The order number, passed to eWay as the "Invoice Reference"
       # * <tt>:invoice</tt> -- The invoice number, passed to eWay as the "Invoice Reference" unless :order_id is also given
       # * <tt>:description</tt> -- A description of the payment, passed to eWay as the "Invoice Description"
-      def purchase(money, billing_id, options={})
+      def purchase(money, billing_id, options = {})
         post = {}
         post[:managedCustomerID] = billing_id.to_s
-        post[:amount]=money
+        post[:amount] = money
         add_invoice(post, options)
 
-        commit("ProcessPayment", post)
+        commit('ProcessPayment', post)
       end
 
       # Get customer's stored credit card details given by billing_id
@@ -98,7 +98,7 @@ module ActiveMerchant #:nodoc:
         post = {}
         post[:managedCustomerID] = billing_id.to_s
 
-        commit("QueryCustomer", post)
+        commit('QueryCustomer', post)
       end
 
       # TODO: eWay API also provides QueryPayment
@@ -106,8 +106,8 @@ module ActiveMerchant #:nodoc:
       private
 
       def eway_requires!(hash)
-        raise ArgumentError.new("Missing eWay required parameter in `billing_address`: title") unless hash.has_key?(:title)
-        raise ArgumentError.new("Missing eWay required parameter in `billing_address`: country") unless hash.has_key?(:country)
+        raise ArgumentError.new('Missing eWay required parameter in `billing_address`: title') unless hash.has_key?(:title)
+        raise ArgumentError.new('Missing eWay required parameter in `billing_address`: country') unless hash.has_key?(:country)
       end
 
       def add_address(post, address)
@@ -122,13 +122,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_misc_fields(post, options)
-        post[:CustomerRef]=options[:billing_address][:customer_ref] || options[:customer]
-        post[:Title]=options[:billing_address][:title]
-        post[:Company]=options[:billing_address][:company]
-        post[:JobDesc]=options[:billing_address][:job_desc]
-        post[:Email]=options[:billing_address][:email] || options[:email]
-        post[:URL]=options[:billing_address][:url]
-        post[:Comments]=options[:description]
+        post[:CustomerRef] = options[:billing_address][:customer_ref] || options[:customer]
+        post[:Title] = options[:billing_address][:title]
+        post[:Company] = options[:billing_address][:company]
+        post[:JobDesc] = options[:billing_address][:job_desc]
+        post[:Email] = options[:billing_address][:email] || options[:email]
+        post[:URL] = options[:billing_address][:url]
+        post[:Comments] = options[:description]
       end
 
       def add_invoice(post, options)
@@ -136,12 +136,11 @@ module ActiveMerchant #:nodoc:
         post[:invoiceDescription] = options[:description]
       end
 
-
       # add credit card details to be stored by eway. NOTE eway requires "title" field
       def add_creditcard(post, creditcard)
-        post[:CCNumber]  = creditcard.number
-        post[:CCExpiryMonth]  = sprintf("%.2i", creditcard.month)
-        post[:CCExpiryYear] = sprintf("%.4i", creditcard.year)[-2..-1]
+        post[:CCNumber] = creditcard.number
+        post[:CCExpiryMonth] = sprintf('%.2i', creditcard.month)
+        post[:CCExpiryYear] = sprintf('%.4i', creditcard.year)[-2..-1]
         post[:CCNameOnCard] = creditcard.name
         post[:FirstName] = creditcard.first_name
         post[:LastName]  = creditcard.last_name
@@ -150,35 +149,35 @@ module ActiveMerchant #:nodoc:
       def parse(body)
         reply = {}
         xml = REXML::Document.new(body)
-        if root = REXML::XPath.first(xml, "//soap:Fault") then
-           reply=parse_fault(root)
+        if root = REXML::XPath.first(xml, '//soap:Fault') then
+          reply = parse_fault(root)
         else
           if root = REXML::XPath.first(xml, '//ProcessPaymentResponse/ewayResponse') then
             # Successful payment
-            reply=parse_purchase(root)
+            reply = parse_purchase(root)
           else
             if root = REXML::XPath.first(xml, '//QueryCustomerResult') then
-              reply=parse_query_customer(root)
+              reply = parse_query_customer(root)
             else
               if root = REXML::XPath.first(xml, '//CreateCustomerResult') then
-                reply[:message]='OK'
-                reply[:CreateCustomerResult]=root.text
-                reply[:success]=true
+                reply[:message] = 'OK'
+                reply[:CreateCustomerResult] = root.text
+                reply[:success] = true
               else
                 if root = REXML::XPath.first(xml, '//UpdateCustomerResult') then
-                  if root.text.downcase == 'true' then
-                    reply[:message]='OK'
-                    reply[:success]=true
+                  if root.text.casecmp('true').zero? then
+                    reply[:message] = 'OK'
+                    reply[:success] = true
                   else
                     # ERROR: This state should never occur. If there is a problem,
                     #        a soap:Fault will be returned. The presence of this
                     #        element always means a success.
-                    raise StandardError, "Unexpected \"false\" in UpdateCustomerResult"
+                    raise StandardError, 'Unexpected "false" in UpdateCustomerResult'
                   end
                 else
                   # ERROR: This state should never occur currently. We have handled
                   #        responses for all the methods which we support.
-                  raise StandardError, "Unexpected response"
+                  raise StandardError, 'Unexpected response'
                 end
               end
             end
@@ -188,93 +187,93 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse_fault(node)
-        reply={}
-        reply[:message]=REXML::XPath.first(node, '//soap:Reason/soap:Text').text
-        reply[:success]=false
+        reply = {}
+        reply[:message] = REXML::XPath.first(node, '//soap:Reason/soap:Text').text
+        reply[:success] = false
         reply
       end
 
       def parse_purchase(node)
-        reply={}
-        reply[:message]=REXML::XPath.first(node, '//ewayTrxnError').text
-        reply[:success]=(REXML::XPath.first(node, '//ewayTrxnStatus').text == 'True')
-        reply[:auth_code]=REXML::XPath.first(node, '//ewayAuthCode').text
-        reply[:transaction_number]=REXML::XPath.first(node, '//ewayTrxnNumber').text
+        reply = {}
+        reply[:message] = REXML::XPath.first(node, '//ewayTrxnError').text
+        reply[:success] = (REXML::XPath.first(node, '//ewayTrxnStatus').text == 'True')
+        reply[:auth_code] = REXML::XPath.first(node, '//ewayAuthCode').text
+        reply[:transaction_number] = REXML::XPath.first(node, '//ewayTrxnNumber').text
         reply
       end
 
       def parse_query_customer(node)
-        reply={}
-        reply[:message]='OK'
-        reply[:success]=true
-        reply[:CCNumber]=REXML::XPath.first(node, '//CCNumber').text
-        reply[:CCName]=REXML::XPath.first(node, '//CCName').text
-        reply[:CCExpiryMonth]=REXML::XPath.first(node, '//CCExpiryMonth').text
-        reply[:CCExpiryYear]=REXML::XPath.first(node, '//CCExpiryYear').text
+        reply = {}
+        reply[:message] = 'OK'
+        reply[:success] = true
+        reply[:CCNumber] = REXML::XPath.first(node, '//CCNumber').text
+        reply[:CCName] = REXML::XPath.first(node, '//CCName').text
+        reply[:CCExpiryMonth] = REXML::XPath.first(node, '//CCExpiryMonth').text
+        reply[:CCExpiryYear] = REXML::XPath.first(node, '//CCExpiryYear').text
         reply
       end
 
       def commit(action, post)
-        raw = begin
-          ssl_post(test? ? self.test_url : self.live_url, soap_request(post, action), 'Content-Type' => 'application/soap+xml; charset=utf-8')
-        rescue ResponseError => e
-          e.response.body
-        end
+        raw =
+          begin
+            ssl_post(test? ? self.test_url : self.live_url, soap_request(post, action), 'Content-Type' => 'application/soap+xml; charset=utf-8')
+          rescue ResponseError => e
+            e.response.body
+          end
         response = parse(raw)
 
         EwayResponse.new(response[:success], response[:message], response,
-          :test => test?,
-          :authorization => response[:auth_code]
-        )
+          test: test?,
+          authorization: response[:auth_code])
       end
 
       # Where we build the full SOAP 1.2 request using builder
       def soap_request(arguments, action)
         # eWay demands all fields be sent, but contain an empty string if blank
         post = case action
-                when 'QueryCustomer'
-                  arguments
-                when 'ProcessPayment'
-                  default_payment_fields.merge(arguments)
-                when 'CreateCustomer'
-                  default_customer_fields.merge(arguments)
-                when 'UpdateCustomer'
-                  default_customer_fields.merge(arguments)
+               when 'QueryCustomer'
+                 arguments
+               when 'ProcessPayment'
+                 default_payment_fields.merge(arguments)
+               when 'CreateCustomer'
+                 default_customer_fields.merge(arguments)
+               when 'UpdateCustomer'
+                 default_customer_fields.merge(arguments)
                end
 
-        xml = Builder::XmlMarkup.new :indent => 2
-          xml.instruct!
-          xml.tag! 'soap12:Envelope', {'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance', 'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema', 'xmlns:soap12' => 'http://www.w3.org/2003/05/soap-envelope'} do
-            xml.tag! 'soap12:Header' do
-              xml.tag! 'eWAYHeader', {'xmlns' => 'https://www.eway.com.au/gateway/managedpayment'} do
-                xml.tag! 'eWAYCustomerID', @options[:login]
-                xml.tag! 'Username', @options[:username]
-                xml.tag! 'Password', @options[:password]
-              end
+        xml = Builder::XmlMarkup.new indent: 2
+        xml.instruct!
+        xml.tag! 'soap12:Envelope', { 'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance', 'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema', 'xmlns:soap12' => 'http://www.w3.org/2003/05/soap-envelope' } do
+          xml.tag! 'soap12:Header' do
+            xml.tag! 'eWAYHeader', { 'xmlns' => 'https://www.eway.com.au/gateway/managedpayment' } do
+              xml.tag! 'eWAYCustomerID', @options[:login]
+              xml.tag! 'Username', @options[:username]
+              xml.tag! 'Password', @options[:password]
             end
-            xml.tag! 'soap12:Body' do |x|
-              x.tag! "#{action}", {'xmlns' => 'https://www.eway.com.au/gateway/managedpayment'} do |y|
-                post.each do |key, value|
-                  y.tag! "#{key}", "#{value}"
-                end
+          end
+          xml.tag! 'soap12:Body' do |x|
+            x.tag! action, { 'xmlns' => 'https://www.eway.com.au/gateway/managedpayment' } do |y|
+              post.each do |key, value|
+                y.tag! key, value
               end
             end
           end
+        end
         xml.target!
       end
 
       def default_customer_fields
-        hash={}
-        %w( CustomerRef Title FirstName LastName Company JobDesc Email Address Suburb State PostCode Country Phone Mobile Fax URL Comments CCNumber CCNameOnCard CCExpiryMonth CCExpiryYear ).each do |field|
-          hash[field.to_sym]=''
+        hash = {}
+        %w(CustomerRef Title FirstName LastName Company JobDesc Email Address Suburb State PostCode Country Phone Mobile Fax URL Comments CCNumber CCNameOnCard CCExpiryMonth CCExpiryYear).each do |field|
+          hash[field.to_sym] = ''
         end
         return hash
       end
 
       def default_payment_fields
-        hash={}
-        %w( managedCustomerID amount invoiceReference invoiceDescription ).each do |field|
-          hash[field.to_sym]=''
+        hash = {}
+        %w(managedCustomerID amount invoiceReference invoiceDescription).each do |field|
+          hash[field.to_sym] = ''
         end
         return hash
       end
@@ -285,7 +284,6 @@ module ActiveMerchant #:nodoc:
           @params['CreateCustomerResult']
         end
       end
-
     end
   end
 end