odoo-addon-pms 16.0.1.1.0__py3-none-any.whl → 16.0.2.1.0__py3-none-any.whl

odoo/addons/pms/models/pms_checkin_partner.py

@@ -5,12 +5,8 @@
 import json
 from datetime import datetime
 
-from dateutil.relativedelta import relativedelta
-
 from odoo import _, api, fields, models
-from odoo.exceptions import UserError, ValidationError
-from odoo.tools import DEFAULT_SERVER_DATE_FORMAT
-from odoo.tools.safe_eval import safe_eval
+from odoo.exceptions import ValidationError
 
 
 class PmsCheckinPartner(models.Model):
@@ -28,12 +24,9 @@ class PmsCheckinPartner(models.Model):
     partner_id = fields.Many2one(
         string="Partner",
         help="Partner associated with checkin partner",
-        readonly=False,
         index=True,
-        store=True,
         comodel_name="res.partner",
         domain="[('is_company', '=', False)]",
-        compute="_compute_partner_id",
     )
     reservation_id = fields.Many2one(
         string="Reservation",
@@ -213,50 +206,6 @@ class PmsCheckinPartner(models.Model):
         compute="_compute_birth_date",
         inverse=lambda r: r._inverse_partner_fields("birthdate_date", "birthdate_date"),
     )
-    document_number = fields.Char(
-        help="Host document number",
-        readonly=False,
-        store=True,
-        compute="_compute_document_number",
-    )
-    document_type = fields.Many2one(
-        help="Select a valid document type",
-        readonly=False,
-        store=True,
-        index=True,
-        comodel_name="res.partner.id_category",
-        compute="_compute_document_type",
-        domain="['|', ('country_ids', '=', False),"
-        " ('country_ids', 'in', document_country_id)]",
-    )
-    document_expedition_date = fields.Date(
-        string="Expedition Date",
-        help="Date on which document_type was issued",
-        readonly=False,
-        store=True,
-        compute="_compute_document_expedition_date",
-    )
-
-    document_id = fields.Many2one(
-        string="Document",
-        help="Technical field",
-        readonly=False,
-        store=True,
-        index=True,
-        comodel_name="res.partner.id_number",
-        compute="_compute_document_id",
-        ondelete="restrict",
-    )
-
-    document_country_id = fields.Many2one(
-        string="Document Country",
-        help="Country of the document",
-        comodel_name="res.country",
-        compute="_compute_document_country_id",
-        store=True,
-        readonly=False,
-    )
-
     partner_incongruences = fields.Char(
         help="indicates that some partner fields \
             on the checkin do not correspond to that of \
@@ -286,50 +235,6 @@ class PmsCheckinPartner(models.Model):
             if record.partner_id:
                 record.partner_id[partner_field_name] = record[checkin_field_name]
 
-    @api.depends("partner_id")
-    def _compute_document_number(self):
-        for record in self:
-            if not record.document_number and record.partner_id.id_numbers:
-                last_update_document = record.partner_id.id_numbers.filtered(
-                    lambda x, record=record: x.write_date
-                    == max(record.partner_id.id_numbers.mapped("write_date"))
-                )
-                if last_update_document and last_update_document[0].name:
-                    record.document_number = last_update_document[0].name
-
-    @api.depends("partner_id")
-    def _compute_document_type(self):
-        for record in self:
-            if not record.document_type and record.partner_id.id_numbers:
-                last_update_document = record.partner_id.id_numbers.filtered(
-                    lambda x, record=record: x.write_date
-                    == max(record.partner_id.id_numbers.mapped("write_date"))
-                )
-                if last_update_document and last_update_document[0].category_id:
-                    record.document_type = last_update_document[0].category_id
-
-    @api.depends("partner_id")
-    def _compute_document_expedition_date(self):
-        for record in self:
-            if not record.document_expedition_date and record.partner_id.id_numbers:
-                last_update_document = record.partner_id.id_numbers.filtered(
-                    lambda x, record=record: x.write_date
-                    == max(record.partner_id.id_numbers.mapped("write_date"))
-                )
-                if last_update_document and last_update_document[0].valid_from:
-                    record.document_expedition_date = last_update_document[0].valid_from
-
-    @api.depends("partner_id")
-    def _compute_document_country_id(self):
-        for record in self:
-            if not record.document_country_id and record.partner_id.id_numbers:
-                last_update_document = record.partner_id.id_numbers.filtered(
-                    lambda x, record=record: x.write_date
-                    == max(record.partner_id.id_numbers.mapped("write_date"))
-                )
-                if last_update_document and last_update_document[0].country_id:
-                    record.document_country_id = last_update_document[0].country_id
-
     @api.depends("partner_id")
     def _compute_firstname(self):
         for record in self:
@@ -433,11 +338,7 @@ class PmsCheckinPartner(models.Model):
                     record.state = "dummy"
                 elif any(
                     not getattr(record, field)
-                    for field in record._checkin_mandatory_fields(
-                        country=record.country_id,
-                        document_type=record.document_type,
-                        birthdate_date=record.birthdate_date,
-                    )
+                    for field in record._checkin_mandatory_fields()
                 ):
                     record.state = "draft"
                 else:
@@ -473,49 +374,6 @@ class PmsCheckinPartner(models.Model):
             elif not record.phone:
                 record.phone = False
 
-    @api.depends("partner_id")
-    def _compute_document_id(self):
-        for record in self:
-            if record.partner_id:
-                if (
-                    not record.document_id
-                    and record.document_number
-                    and record.document_type
-                ):
-                    id_number_id = (
-                        self.sudo()
-                        .env["res.partner.id_number"]
-                        .search(
-                            [
-                                ("partner_id", "=", record.partner_id.id),
-                                ("name", "=", record.document_number),
-                                ("category_id", "=", record.document_type.id),
-                            ]
-                        )
-                    )
-                    if not id_number_id:
-                        document_vals = record.get_document_vals()
-                        id_number_id = self.env["res.partner.id_number"].create(
-                            document_vals
-                        )
-
-                    record.document_id = id_number_id
-            else:
-                record.document_id = False
-
-    def get_document_vals(self):
-        return {
-            "name": self.document_number,
-            "partner_id": self.partner_id.id,
-            "category_id": self.document_type.id,
-            "valid_from": self.document_expedition_date,
-            "country_id": self.document_country_id.id,
-        }
-
-    @api.model
-    def _get_compute_partner_id_field_names(self):
-        return ["document_number", "document_type", "firstname", "lastname"]
-
     def _completed_partner_creation_fields(self):
         self.ensure_one()
         if self.firstname or self.lastname:
@@ -531,40 +389,6 @@ class PmsCheckinPartner(models.Model):
             "nationality_id": self.nationality_id.id,
         }
 
-    @api.depends(lambda self: self._get_compute_partner_id_field_names())
-    def _compute_partner_id(self):
-        for record in self:
-            if not record.partner_id:
-                if record.document_number and record.document_type:
-                    partner = self._get_partner_by_document(
-                        record.document_number, record.document_type
-                    )
-                    if not partner:
-                        if self._completed_partner_creation_fields():
-                            partner_values = self._get_partner_create_vals()
-                            partner = (
-                                self.env["res.partner"]
-                                .with_context(avoid_document_restriction=True)
-                                .create(partner_values)
-                            )
-                    record.partner_id = partner
-
-    @api.model
-    def _get_partner_by_document(self, document_number, document_type):
-        number = (
-            self.sudo()
-            .env["res.partner.id_number"]
-            .search(
-                [
-                    ("name", "=", document_number),
-                    ("category_id", "=", document_type.id),
-                ]
-            )
-        )
-        return (
-            self.sudo().env["res.partner"].search([("id", "=", number.partner_id.id)])
-        )
-
     @api.depends("email", "mobile")
     def _compute_possible_existing_customer_ids(self):
         for record in self:
@@ -658,77 +482,10 @@ class PmsCheckinPartner(models.Model):
                         _("This guest is already registered in the room")
                     )
 
-    @api.constrains("document_number")
-    def check_document_number(self):
-        for record in self:
-            if record.partner_id:
-                for number in record.partner_id.id_numbers:
-                    if record.document_type == number.category_id:
-                        if record.document_number != number.name:
-                            raise ValidationError(_("Document_type has already exists"))
-
     def _validation_eval_context(self, id_number):
         self.ensure_one()
         return {"self": self, "id_number": id_number}
 
-    @api.constrains("document_number", "document_type")
-    def validate_id_number(self):
-        """Validate the given ID number
-        The method raises an odoo.exceptions.ValidationError if the eval of
-        python validation code fails
-        """
-        for record in self:
-            if record.document_number and record.document_type:
-                id_number = self.env["res.partner.id_number"].new(
-                    {
-                        "name": record.document_number,
-                        "category_id": record.document_type,
-                    }
-                )
-                if (
-                    self.env.context.get("id_no_validate")
-                    or not record.document_type.validation_code
-                ):
-                    return
-                eval_context = record._validation_eval_context(id_number)
-                try:
-                    safe_eval(
-                        record.document_type.validation_code,
-                        eval_context,
-                        mode="exec",
-                        nocopy=True,
-                    )
-                except Exception as e:
-                    raise UserError(
-                        _(
-                            "Error when evaluating the id_category "
-                            "validation code:\n %(name)s \n(%(error)s)",
-                            name=self.name,
-                            error=e,
-                        )
-                    ) from e
-                if eval_context.get("failed", False):
-                    raise ValidationError(
-                        _(
-                            "%(doc_number)s is not a valid %(doc_type)s identifier",
-                            doc_number=record.document_number,
-                            doc_type=record.document_type.name,
-                        )
-                    )
-
-    @api.constrains("document_country_id", "document_type")
-    def _check_document_country_id_document_type_consistence(self):
-        for record in self:
-            if record.document_country_id and record.document_type:
-                if (
-                    record.document_type.country_ids
-                    and record.document_country_id
-                    not in record.document_type.country_ids
-                ):
-                    raise ValidationError(
-                        _("Document type and country of document do not match")
-                    )
-
     @api.constrains("state_id", "country_id")
     def _check_state_id_country_id_consistence(self):
         for record in self:
@@ -761,6 +518,14 @@ class PmsCheckinPartner(models.Model):
                     if not any(record.partner_id[field] for field in address_fields):
                         record.partner_id.write(residence_vals)
 
+    def set_partner_id(self):
+        for record in self:
+            if not record.partner_id:
+                if record._completed_partner_creation_fields():
+                    partner_values = record._get_partner_create_vals()
+                    partner = self.env["res.partner"].create(partner_values)
+                    record.partner_id = partner
+
     @api.model_create_multi
     def create(self, vals_list):
         records = self.env["pms.checkin.partner"]
@@ -795,6 +560,9 @@ class PmsCheckinPartner(models.Model):
                         "check-in in this reservation"
                     )
                 )
+        records_without_partner = records.filtered(lambda r: not r.partner_id)
+        if records_without_partner:
+            records_without_partner.set_partner_id()
         records.set_partner_address()
         return records
 
@@ -805,6 +573,10 @@ class PmsCheckinPartner(models.Model):
             tourist_tax_services_cmds = reservation._compute_tourist_tax_lines()
             if tourist_tax_services_cmds:
                 reservation.write({"service_ids": tourist_tax_services_cmds})
+        records_without_partner = self.filtered(lambda r: not r.partner_id)
+        if records_without_partner:
+            records_without_partner.set_partner_id()
+
         self.set_partner_address()
         return res
 
@@ -826,8 +598,6 @@ class PmsCheckinPartner(models.Model):
             "firstname",
             "lastname",
             "birthdate_date",
-            "document_number",
-            "document_expedition_date",
             "nationality_id",
             "street",
             "street2",
@@ -835,8 +605,6 @@ class PmsCheckinPartner(models.Model):
             "city",
             "country_id",
             "state_id",
-            "document_country_id",
-            "document_type",
         ]
         return manual_fields
 
@@ -846,12 +614,13 @@ class PmsCheckinPartner(models.Model):
         manual_fields.append("reservation_id.state")
         return manual_fields
 
-    @api.model
-    def _checkin_mandatory_fields(
-        self, country=False, document_type=False, birthdate_date=False
-    ):
-        mandatory_fields = []
-        return mandatory_fields
+    def _checkin_mandatory_fields(self):
+        """
+        Auxiliar method to return the mandatory fields for checkin.
+        It can be extended by modules that need to add more mandatory fields.
+        """
+        self.ensure_one()
+        return []
 
     @api.model
     def _checkin_partner_fields(self):
@@ -893,28 +662,6 @@ class PmsCheckinPartner(models.Model):
                 checkin_vals[key] = value
             checkin.write(checkin_vals)
 
-    @api.model
-    def calculate_doc_type_expedition_date_from_validity_date(
-        self, doc_type, doc_date, birthdate
-    ):
-        today = fields.datetime.today()
-        datetime_doc_date = datetime.strptime(doc_date, DEFAULT_SERVER_DATE_FORMAT)
-        if datetime_doc_date < today:
-            return datetime_doc_date
-        datetime_birthdate = datetime.strptime(birthdate, DEFAULT_SERVER_DATE_FORMAT)
-        age = today.year - datetime_birthdate.year
-
-        document_expedition_date = False
-        if doc_type.code == "D" or doc_type.code == "P":
-            if age < 30:
-                document_expedition_date = datetime_doc_date - relativedelta(years=5)
-            else:
-                document_expedition_date = datetime_doc_date - relativedelta(years=10)
-        if doc_type.code == "C":
-            if age < 70:
-                document_expedition_date = datetime_doc_date - relativedelta(years=10)
-        return document_expedition_date
-
     def action_on_board(self):
         for record in self:
             if record.reservation_id.checkin > fields.Date.today():
@@ -923,7 +670,8 @@ class PmsCheckinPartner(models.Model):
                 raise ValidationError(_("Its too late to checkin"))
 
             if any(
-                not getattr(record, field) for field in self._checkin_mandatory_fields()
+                not getattr(record, field)
+                for field in record._checkin_mandatory_fields()
             ):
                 raise ValidationError(_("Personal data is missing for check-in"))
             vals = {
@@ -984,50 +732,6 @@ class PmsCheckinPartner(models.Model):
             "context": ctx,
         }
 
-    def _save_data_from_portal(self, values):
-        checkin_partner = values.get("checkin_partner", "")
-        values.pop("checkin_partner")
-        values.pop("folio_access_token") if "folio_access_token" in values else None
-        if values.get("nationality"):
-            values.update({"nationality_id": int(values.get("nationality_id"))})
-
-        doc_type = (
-            self.sudo()
-            .env["res.partner.id_category"]
-            .browse(int(values.get("document_type")))
-        )
-        if values.get("document_type"):
-            values.update({"document_type": int(values.get("document_type"))})
-        if values.get("state_id"):
-            values.update({"state_id": int(values.get("state_id"))})
-        if values.get("country_id"):
-            values.update({"country_id": int(values.get("country_id"))})
-
-        if values.get("document_expedition_date"):
-            values.update(
-                {
-                    "document_expedition_date": datetime.strptime(
-                        values.get("document_expedition_date"), "%d/%m/%Y"
-                    ).strftime("%Y-%m-%d"),
-                    "birthdate_date": datetime.strptime(
-                        values.get("birthdate_date"), "%d/%m/%Y"
-                    ).strftime("%Y-%m-%d"),
-                }
-            )
-            doc_date = values.get("document_expedition_date")
-            birthdate = values.get("birthdate_date")
-            document_expedition_date = (
-                self.calculate_doc_type_expedition_date_from_validity_date(
-                    doc_type, doc_date, birthdate
-                )
-            )
-            values.update(
-                {
-                    "document_expedition_date": document_expedition_date,
-                }
-            )
-        checkin_partner.sudo().write(values)
-
     def send_portal_invitation_email(self, invitation_firstname=None, email=None):
         template = self.sudo().env.ref(
             "pms.precheckin_invitation_email", raise_if_not_found=False

odoo/addons/pms/models/res_company.py

@@ -43,12 +43,6 @@ class ResCompany(models.Model):
         default="no",
     )
 
-    document_partner_required = fields.Boolean(
-        help="""If true, the partner document is required
-        to create a new contact""",
-        default=False,
-    )
-
     cancel_penalty_product_id = fields.Many2one(
         string="Cancel penalty product",
         help="Product used to calculate the cancel penalty",

odoo/addons/pms/models/res_partner.py

@@ -4,7 +4,6 @@
 import logging
 
 from odoo import _, api, fields, models
-from odoo.exceptions import ValidationError
 
 _logger = logging.getLogger(__name__)
 
@@ -261,78 +260,6 @@ class ResPartner(models.Model):
         # Template to be inherited by localization modules
         return True
 
-    @api.model_create_multi
-    def create(self, vals_list):
-        for vals in vals_list:
-            check_missing_document = self._check_document_partner_required(vals)
-            if check_missing_document:
-                raise ValidationError(_("A document identification is required"))
-        return super().create(vals_list)
-
-    def write(self, vals):
-        check_missing_document = self._check_document_partner_required(
-            vals, partners=self
-        )
-        if check_missing_document:
-            # REVIEW: Deactivate this check for now, because it can generate problems
-            # with other modules that update technical partner fields
-            _logger.warning(
-                _("Partner without document identification, update vals %s"), vals
-            )
-            # We only check if the vat or document_number is updated
-            if "vat" in vals or "document_number" in vals:
-                raise ValidationError(_("A document identification is required"))
-        return super().write(vals)
-
-    @api.model
-    def _check_document_partner_required(self, vals, partners=False):
-        company_ids = (
-            self.env["res.company"].sudo().search([]).ids
-            if (not partners or any([not partner.company_id for partner in partners]))
-            else partners.mapped("company_id.id")
-        )
-        if not self.env.context.get("avoid_document_restriction") and any(
-            [
-                self.env["res.company"]
-                .sudo()
-                .browse(company_id)
-                .document_partner_required
-                for company_id in company_ids
-            ]
-        ):
-            return self._missing_document(vals, partners)
-        return False
-
-    @api.model
-    def _missing_document(self, vals, partners=False):
-        # If not is a partner contact and not have vat,
-        # then return missing document True
-        if (
-            not vals.get("parent_id")
-            or (partners and any([not partner.parent_id for partner in partners]))
-        ) and (
-            vals.get("vat") is False
-            or vals.get("vat") == ""
-            or (
-                "vat" not in vals
-                and (
-                    any([not partner.vat for partner in partners]) if partners else True
-                )
-            )
-            or vals.get("country_id") is False
-            or vals.get("country_id") == ""
-            or (
-                "country_id" not in vals
-                and (
-                    any([not partner.country_id for partner in partners])
-                    if partners
-                    else True
-                )
-            )
-        ):
-            return True
-        return False
-
     @api.constrains("is_agency", "property_product_pricelist")
     def _check_agency_pricelist(self):
         if any(

odoo/addons/pms/static/description/index.html

@@ -372,7 +372,7 @@ ul.auto-toc {
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:7a9133a071292495a65eeaa21c559b55701ed046c6b661f3728055fedda6f778
+!! source digest: sha256:aad37def55422d9d18b819885a02cc7d3903c0e7203d81ba07c4c893243c9165
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/pms/tree/16.0/pms"><img alt="OCA/pms" src="https://img.shields.io/badge/github-OCA%2Fpms-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/pms-16-0/pms-16-0-pms"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/pms&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module is an all-in-one property management system (PMS) focused on medium-sized properties