odoo-addon-account-commission 16.0.2.4.0__py3-none-any.whl → 17.0.1.0.0.2__py3-none-any.whl

odoo/addons/account_commission/static/description/index.html

@@ -366,11 +366,13 @@ ul.auto-toc {
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:8ba2b2321dee20dece1882cb3f664fb78a27b4fbccb785d1f5410b7d009889c6
+!! source digest: sha256:0fb13edf183d9d1ecf7c4415929fabd687f91bd51e719c0e149a7148c57da4ef
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/commission/tree/16.0/account_commission"><img alt="OCA/commission" src="https://img.shields.io/badge/github-OCA%2Fcommission-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-account_commission"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/commission&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
-<p>This module adds the function to calculate commissions in invoices (account moves).</p>
-<p>It also allows to create vendor bills from settlements for external agents.</p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/commission/tree/17.0/account_commission"><img alt="OCA/commission" src="https://img.shields.io/badge/github-OCA%2Fcommission-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-account_commission"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/commission&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p>This module adds the function to calculate commissions in invoices
+(account moves).</p>
+<p>It also allows to create vendor bills from settlements for external
+agents.</p>
 <p>This module depends on the commission module.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -390,11 +392,12 @@ ul.auto-toc {
 <h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
 <p>For selecting invoice status in commissions:</p>
 <ol class="arabic simple">
-<li>Edit or create a new record to select the invoice status for settling the commissions.<ul>
-<li><strong>Invoice Based</strong>: Commissions are settled when the invoice is issued.</li>
-<li><strong>Payment Based</strong>: Commissions are settled when the invoice is paid or refunded.
-Note that when refunding an invoice, the corresponding reversed commission will
-be settled as well, resulting in a 0 net commission between both operations.</li>
+<li>Edit or create a new record to select the invoice status for settling
+the commissions.<ul>
+<li><strong>Invoice Based</strong>: Commissions are settled when the invoice is
+issued.</li>
+<li><strong>Payment Based</strong>: Commissions are settled when the invoice is
+paid.</li>
 </ul>
 </li>
 </ol>
@@ -405,19 +408,20 @@ be settled as well, resulting in a 0 net commission between both operations.</li
 <ol class="arabic simple">
 <li>Go to <em>Invoicing &gt; Customers &gt; Invoices</em>.</li>
 <li>Edit or create a new record.</li>
-<li>When you have selected a partner, each new invoice line you add will have
-the agents and commissions set at customer level.</li>
+<li>When you have selected a partner, each new invoice line you add will
+have the agents and commissions set at customer level.</li>
 <li>You can add, modify or delete these agents discretely clicking on the
-icon with several persons represented, next to the “Commission” field in the
-list. This icon will be available only if the line hasn’t been invoiced yet.</li>
-<li>If you have configured your system for editing lines in a popup window,
-agents will appear also in this window.</li>
-<li>The agents icon will be in this ocassion visible when the line hasn’t been
-settled.</li>
+icon with several persons represented, next to the “Commission” field
+in the list. This icon will be available only if the line hasn’t been
+invoiced yet.</li>
+<li>If you have configured your system for editing lines in a popup
+window, agents will appear also in this window.</li>
+<li>The agents icon will be in this ocassion visible when the line hasn’t
+been settled.</li>
 <li>You have a button “Regenerate agents” on the bottom of the page
-“Invoice Lines” for forcing a recompute of all agents from the partner setup.
-This is needed for example when you have changed the partner on the
-invoice having already inserted lines.</li>
+“Invoice Lines” for forcing a recompute of all agents from the
+partner setup. This is needed for example when you have changed the
+partner on the invoice having already inserted lines.</li>
 </ol>
 <p>For invoicing the settlements (only for external agents):</p>
 <ol class="arabic simple">
@@ -425,10 +429,11 @@ invoice having already inserted lines.</li>
 <li>On the window that appears, you can select following data:<ul>
 <li>Product. It should be a service product for being coherent.</li>
 <li>Journal: To be selected between existing purchase journals.</li>
-<li>Date: If you want to choose a specific invoice date. You can leave it
-blank if you prefer.</li>
-<li>Settlements: For selecting specific settlements to invoice. You can leave
-it blank as well for invoicing all the pending settlements.</li>
+<li>Date: If you want to choose a specific invoice date. You can leave
+it blank if you prefer.</li>
+<li>Settlements: For selecting specific settlements to invoice. You
+can leave it blank as well for invoicing all the pending
+settlements.</li>
 </ul>
 </li>
 </ol>
@@ -437,8 +442,8 @@ it blank as well for invoicing all the pending settlements.</li>
 <li>Navigate to <em>Invoicing &gt; Commissions &gt; Invoices Settlements</em>.</li>
 <li>Select it/them on the list.</li>
 <li>Click on <em>Action &gt; Create Commission Invoices</em>.</li>
-<li>You can as well enter in one settlement, and click on the “Make invoice”
-button.</li>
+<li>You can as well enter in one settlement, and click on the “Make
+invoice” button.</li>
 </ol>
 </div>
 <div class="section" id="bug-tracker">
@@ -446,7 +451,7 @@ button.</li>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/commission/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/commission/issues/new?body=module:%20account_commission%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/commission/issues/new?body=module:%20account_commission%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -470,10 +475,10 @@ If you spotted it first, help us to smash it by providing a detailed and welcome
 <li>Nicola Malcontenti &lt;<a class="reference external" href="mailto:nicola.malcontenti&#64;agilebg.com">nicola.malcontenti&#64;agilebg.com</a>&gt;</li>
 <li>Aitor Bouzas &lt;<a class="reference external" href="mailto:aitor.bouzas&#64;adaptivecity.com">aitor.bouzas&#64;adaptivecity.com</a>&gt;</li>
 <li>Alexei Rivera &lt;<a class="reference external" href="mailto:arivera&#64;archeti.com">arivera&#64;archeti.com</a>&gt;</li>
+<li>Mina Samir &lt;<a class="reference external" href="mailto:minaw349&#64;outlook.com">minaw349&#64;outlook.com</a>&gt;</li>
 <li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a>:<ul>
 <li>Pedro M. Baeza</li>
 <li>Manuel Calero</li>
-<li>Sergio Teruel</li>
 </ul>
 </li>
 <li><a class="reference external" href="https://www.quartile.co">Quartile</a>:<ul>
@@ -485,6 +490,10 @@ If you spotted it first, help us to smash it by providing a detailed and welcome
 <li>Ethan Hildick</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://www.sygel.es">Sygel</a>:<ul>
+<li>Alberto Martínez</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -496,7 +505,7 @@ mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/pedrobaeza"><img alt="pedrobaeza" src="https://github.com/pedrobaeza.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/commission/tree/16.0/account_commission">OCA/commission</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/commission/tree/17.0/account_commission">OCA/commission</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

odoo/addons/account_commission/tests/test_account_commission.py

@@ -7,7 +7,7 @@ from dateutil.relativedelta import relativedelta
 
 from odoo import fields
 from odoo.exceptions import UserError, ValidationError
-from odoo.tests import Form, tagged
+from odoo.tests import tagged
 
 from odoo.addons.commission.tests.test_commission import TestCommissionBase
 
@@ -532,165 +532,3 @@ class TestAccountCommission(TestCommissionBase):
             ]
         )
         self.assertEqual(2, len(settlements))
-
-    def test_invoice_partial_refund(self):
-        commission = self.commission_net_paid
-        agent = self.agent_monthly
-        today = fields.Date.today()
-        # Create an invoice
-        invoice = self._create_invoice(agent, commission, today, currency=None)
-        invoice.action_post()
-        # Register payment for invoice
-        payment_journal = self.env["account.journal"].search(
-            [("type", "=", "cash"), ("company_id", "=", invoice.company_id.id)],
-            limit=1,
-        )
-        register_payments = (
-            self.env["account.payment.register"]
-            .with_context(active_ids=invoice.id, active_model="account.move")
-            .create({"journal_id": payment_journal.id})
-        )
-        register_payments.action_create_payments()
-        # Make a parcial refund for the invoice
-        move_reversal = (
-            self.env["account.move.reversal"]
-            .with_context(active_model="account.move", active_ids=invoice.id)
-            .create(
-                {
-                    "reason": "no reason",
-                    "refund_method": "refund",
-                    "journal_id": invoice.journal_id.id,
-                }
-            )
-        )
-        refund_form = Form(
-            self.env["account.move"].browse(move_reversal.reverse_moves()["res_id"])
-        )
-        with refund_form.invoice_line_ids.edit(0) as line:
-            line.price_unit -= 2
-        refund = refund_form.save()
-        refund.action_post()
-        # Register payment for the refund
-        register_payments = (
-            self.env["account.payment.register"]
-            .with_context(active_ids=refund.id, active_model="account.move")
-            .create({"journal_id": payment_journal.id})
-        )
-        register_payments.action_create_payments()
-        # check settlement creation. The commission must be (5 - 3) * 0.2 = 0.4
-        self._settle_agent_invoice(agent, 1)
-        settlements = self.settle_model.search([("agent_id", "=", agent.id)])
-        self.assertEqual(2, len(settlements.line_ids))
-        self.assertEqual(0.4, sum(settlements.mapped("total")))
-
-    def test_invoice_full_refund(self):
-        commission = self.commission_net_paid
-        agent = self.agent_monthly
-        today = fields.Date.today()
-        # Create an invoice and refund it
-        invoice = self._create_invoice(agent, commission, today, currency=None)
-        invoice.action_post()
-        move_reversal = (
-            self.env["account.move.reversal"]
-            .with_context(active_model="account.move", active_ids=invoice.id)
-            .create(
-                {
-                    "reason": "no reason",
-                    "refund_method": "cancel",
-                    "journal_id": invoice.journal_id.id,
-                }
-            )
-        )
-        move_reversal.reverse_moves()
-        # check settlement creation. The commission must be: (5 - 5) * 0.2 = 0
-        self._settle_agent_invoice(agent, 1)
-        settlements = self.settle_model.search(
-            [
-                ("agent_id", "=", agent.id),
-            ]
-        )
-        self.assertEqual(2, len(settlements.line_ids))
-        self.assertEqual(0, sum(settlements.mapped("total")))
-
-    def test_invoice_modify_refund(self):
-        commission = self.commission_net_paid
-        agent = self.agent_monthly
-        today = fields.Date.today()
-        # Create an invoice
-        invoice = self._create_invoice(agent, commission, today, currency=None)
-        invoice.action_post()
-        # Create a full refund and a new invoice
-        move_reversal = (
-            self.env["account.move.reversal"]
-            .with_context(active_model="account.move", active_ids=invoice.id)
-            .create(
-                {
-                    "reason": "no reason",
-                    "refund_method": "modify",
-                    "journal_id": invoice.journal_id.id,
-                }
-            )
-        )
-        invoice2_form = Form(
-            self.env["account.move"].browse(move_reversal.reverse_moves()["res_id"])
-        )
-        with invoice2_form.invoice_line_ids.edit(0) as line:
-            line.price_unit -= 2
-        invoice2 = invoice2_form.save()
-        invoice2.action_post()
-        # Register payment for the new invoice
-        payment_journal = self.env["account.journal"].search(
-            [("type", "=", "cash"), ("company_id", "=", invoice.company_id.id)],
-            limit=1,
-        )
-        register_payments = (
-            self.env["account.payment.register"]
-            .with_context(active_ids=invoice2.id, active_model="account.move")
-            .create({"journal_id": payment_journal.id})
-        )
-        register_payments.action_create_payments()
-
-        # check settlement creation. The commission must be (5 - 5 + 3) * 0.2 = 0.6
-        self._settle_agent_invoice(agent, 1)
-        settlements = self.settle_model.search(
-            [
-                ("agent_id", "=", agent.id),
-            ]
-        )
-        self.assertEqual(3, len(settlements.line_ids))
-        self.assertAlmostEqual(0.6, sum(settlements.mapped("total")), 2)
-
-    def _register_payment(self, invoice):
-        payment_journal = self.env["account.journal"].search(
-            [("type", "=", "cash"), ("company_id", "=", self.env.company.id)],
-            limit=1,
-        )
-        register_payments = (
-            self.env["account.payment.register"]
-            .with_context(active_ids=invoice.id, active_model="account.move")
-            .create({"journal_id": payment_journal.id})
-        )
-        register_payments.action_create_payments()
-
-    def test_invoice_pending_settlement(self):
-        """Make in one settlement all pending invoices to wizard date"""
-        fields.Date.today()
-        self.commission_net_paid.invoice_state = "paid"
-        invoice1 = self._create_invoice(
-            self.agent_pending, self.commission_net_paid, "2024-02-15", currency=None
-        )
-        # Register payment for the new invoice
-        invoice2 = self._create_invoice(
-            self.agent_pending, self.commission_net_paid, "2024-03-15", currency=None
-        )
-        invoice3 = self._create_invoice(
-            self.agent_pending, self.commission_net_paid, "2024-04-15", currency=None
-        )
-        # invoice1.invoice_line_ids.agent_ids._compute_amount()
-        (invoice1 + invoice2 + invoice3).action_post()
-        self._register_payment(invoice1)
-        self._register_payment(invoice2)
-        self._register_payment(invoice3)
-        self._settle_agent_invoice(self.agent_pending, 1)
-        settlements = self.settle_model.search([("state", "=", "settled")])
-        self.assertEqual(len(settlements.line_ids), 3)

odoo/addons/account_commission/views/account_move_views.xml

@@ -15,7 +15,7 @@
                     widget="monetary"
                     options="{'currency_field': 'currency_id'}"
                 />
-                <field name="currency_id" invisible="1" />
+                <field name="currency_id" column_invisible="1" />
             </tree>
         </field>
     </record>
@@ -28,15 +28,12 @@
                 <group
                     string="Commissions"
                     name="group_commission"
-                    attrs="{'invisible': [('agent_ids', '=', [])], 'readonly': [('any_settled', '=', True)]}"
+                    invisible="not agent_ids"
+                    readonly="any_settled"
                 >
                     <field name="any_settled" invisible="1" />
                     <field name="commission_free" force_save="1" />
-                    <field
-                        name="agent_ids"
-                        attrs="{'readonly': [('commission_free', '=', True)]}"
-                        force_save="1"
-                    />
+                    <field name="agent_ids" readonly="commission_free" force_save="1" />
                 </group>
             </xpath>
         </field>
@@ -52,7 +49,7 @@
                     type="object"
                     class="oe_stat_button"
                     icon="fa-pencil-square-o"
-                    attrs="{'invisible': [('settlement_count', '=', 0)]}"
+                    invisible="(settlement_count == 0)"
                 >
                     <field
                         name="settlement_count"
@@ -65,28 +62,20 @@
                 expr="//field[@name='invoice_line_ids']/tree//field[@name='price_subtotal']"
                 position="after"
             >
-                <field name="settlement_id" invisible="1" />
-                <field name="commission_free" invisible="1" />
-                <field name="any_settled" invisible="1" />
+                <field name="settlement_id" column_invisible="1" />
+                <field name="commission_free" column_invisible="1" />
+                <field name="any_settled" column_invisible="1" />
                 <button
                     name="button_edit_agents"
                     title="Edit agents"
                     icon="fa-users"
-                    attrs="{'invisible': [
-                        '|',
-                        ('commission_free', '=', True),
-                        ('any_settled', '=', True),
-                    ],
-                    'column_invisible': [
-                        ('parent.move_type', 'not in', ['out_invoice', 'out_refund'])
-                    ]}"
+                    invisible="commission_free or any_settled"
+                    column_invisible="(parent.move_type not in ('out_invoice', 'out_refund'))"
                     type="object"
                 />
                 <field
                     name="commission_status"
-                    attrs="{'column_invisible': [
-                        ('parent.move_type', 'not in', ['out_invoice', 'out_refund'])
-                    ]}"
+                    column_invisible="(parent.move_type not in ('out_invoice', 'out_refund'))"
                 />
             </xpath>
             <xpath expr="//field[@name='invoice_line_ids']" position="after">
@@ -94,28 +83,22 @@
                     name="recompute_lines_agents"
                     type="object"
                     string="Regenerate agents"
-                    attrs="{'invisible': [
-                        '|',
-                        ('move_type', 'not in', ['out_invoice', 'out_refund']),
-                        ('state', '!=', 'draft')
-                    ]}"
+                    invisible="(move_type not in ['out_invoice', 'out_refund']) or (state != 'draft')"
                 />
             </xpath>
             <!-- Needed for fields in invoice lines to be saved -->
             <xpath expr="//field[@name='line_ids']/tree" position="inside">
-                <field name="settlement_id" invisible="1" />
-                <field name="commission_free" invisible="1" />
-                <field name="any_settled" invisible="1" />
-                <field name="commission_status" invisible="1" />
+                <field name="settlement_id" column_invisible="1" />
+                <field name="commission_free" column_invisible="1" />
+                <field name="any_settled" column_invisible="1" />
+                <field name="commission_status" column_invisible="1" />
             </xpath>
             <field name="tax_totals" position="after">
                 <field
                     name="commission_total"
                     widget="monetary"
                     options="{'currency_field': 'currency_id'}"
-                    attrs="{'invisible': [
-                        ('move_type', 'not in', ['out_invoice', 'out_refund'])
-                    ]}"
+                    invisible="(move_type not in ('out_invoice', 'out_refund'))"
                 />
             </field>
         </field>
@@ -132,9 +115,9 @@
                     class="oe_stat_button"
                     icon="fa-pencil-square-o"
                     string="Settlements"
-                    attrs="{'invisible': [('settlement_count', '=', 0)]}"
+                    invisible="(settlement_count == 0)"
                 />
-                <field name="settlement_count" invisible="1" />
+                <field name="settlement_count" column_invisible="1" />
             </field>
         </field>
     </record>

odoo/addons/account_commission/views/commission_settlement_views.xml

@@ -21,7 +21,7 @@
             <button name="action_cancel" position="before">
                 <button
                     string="Make invoice"
-                    attrs="{'invisible': ['|', ('state', '!=', 'settled'), ('agent_type', '!=', 'agent')]}"
+                    invisible="(state != 'settled') or (agent_type != 'agent')"
                     class="oe_highlight"
                     type="object"
                     name="action_invoice"
@@ -29,7 +29,7 @@
                 />
                 <button
                     string="Reset to draft"
-                    attrs="{'invisible': [('state', '!=', 'except_invoice')]}"
+                    invisible="(state != 'except_invoice')"
                     type="object"
                     name="action_draft"
                     groups="account.group_account_invoice"
@@ -38,7 +38,7 @@
             <field name="settlement_type" position="after">
                 <field
                     name="invoice_id"
-                    attrs="{'invisible': [('state', '!=', 'invoiced')]}"
+                    invisible="(state != 'invoiced')"
                     groups="account.group_account_invoice"
                 />
             </field>
@@ -48,7 +48,7 @@
             >
                 <field
                     name="invoice_line_id"
-                    attrs="{'column_invisible': [('parent.settlement_type', '!=', 'sale_invoice')]}"
+                    column_invisible="(parent.settlement_type != 'sale_invoice')"
                     groups="account.group_account_invoice"
                 />
             </xpath>

odoo/addons/account_commission/views/commission_views.xml

@@ -8,7 +8,7 @@
             <xpath expr="//group[@name='commision_params']" position="inside">
                 <field
                     name="invoice_state"
-                    attrs="{'required': [('settlement_type', '=', 'sale_invoice')]}"
+                    required="(settlement_type == 'sale_invoice')"
                 />
             </xpath>
         </field>

odoo/addons/account_commission/views/report_settlement_templates.xml

@@ -12,30 +12,24 @@
         </xpath>
         <xpath expr="//th" position="after">
             <t t-if="o.settlement_type == 'sale_invoice'">
-                <th class="text-start">Invoice</th>
-                <th class="text-start">Customer</th>
-                <th class="text-start">Description</th>
+                <th class="text-start">Invoice line</th>
                 <th class="text-start">Quantity</th>
-                <th class="text-start">Amount</th>
             </t>
         </xpath>
         <xpath expr="//table/tbody/tr/td" position="after">
             <t t-if="o.settlement_type == 'sale_invoice'">
                 <td>
-                    <span t-field="l.invoice_line_id.move_id.name" />
-                </td>
-                <td>
-                    <span t-field="l.invoice_line_id.move_id.partner_id" />
-                </td>
-                <td>
-                    <span t-field="l.invoice_line_id.name" />
+                    <span t-field="l.invoice_line_id" />
                 </td>
                 <td>
                     <span t-field="l.invoice_line_id.quantity" />
                 </td>
-                <td>
-                    <span t-field="l.invoice_line_id.price_subtotal" />
-                </td>
+            </t>
+        </xpath>
+        <xpath expr="//table/tfoot/tr/td" position="before">
+            <t t-if="o.settlement_type == 'sale_invoice'">
+                <td />
+                <td />
             </t>
         </xpath>
     </template>

odoo/addons/account_commission/wizards/wizard_invoice.xml

@@ -11,10 +11,7 @@
                     <field name="product_id" />
                     <field name="date" />
                 </group>
-                <group
-                    string="Settlements"
-                    attrs="{'invisible': [('from_settlement', '=', True)]}"
-                >
+                <group string="Settlements" invisible="from_settlement">
                     <p
                         colspan="4"
                     >(keep empty for invoicing all the pending settlements)</p>