moai-adk 0.34.0__py3-none-any.whl → 1.1.0__py3-none-any.whl

moai_adk/templates/.claude/hooks/moai/session_start__show_project_info.py

@@ -14,13 +14,54 @@ Enhanced Features:
 - Risk assessment with performance metrics
 """
 
+from __future__ import annotations
+
 import json
 import logging
 import sys
 from datetime import datetime
 from pathlib import Path
-from typing import Any, Dict
+from typing import Any
 
+# =============================================================================
+# Windows UTF-8 Encoding Fix (Issue #249)
+# Ensures emoji characters are properly displayed on Windows terminals
+# =============================================================================
+if sys.platform == "win32":
+    try:
+        sys.stdout.reconfigure(encoding="utf-8", errors="replace")
+        sys.stderr.reconfigure(encoding="utf-8", errors="replace")
+    except (AttributeError, OSError):
+        # Python < 3.7 or reconfigure not available
+        pass
+
+# =============================================================================
+# Constants - Risk Assessment Thresholds
+# =============================================================================
+# These thresholds determine project risk level based on various factors
+RISK_SCORE_HIGH = 20  # Score >= this is HIGH risk
+RISK_SCORE_MEDIUM = 10  # Score >= this (and < HIGH) is MEDIUM risk
+
+# Git changes thresholds for risk calculation
+GIT_CHANGES_HIGH_THRESHOLD = 20  # Adds 10 to risk score
+GIT_CHANGES_MEDIUM_THRESHOLD = 10  # Adds 5 to risk score
+
+# SPEC progress thresholds
+SPEC_PROGRESS_LOW = 50  # Below this adds 15 to risk score
+SPEC_PROGRESS_MEDIUM = 80  # Below this adds 8 to risk score
+
+# Risk score contributions
+RISK_GIT_CHANGES_HIGH = 10
+RISK_GIT_CHANGES_MEDIUM = 5
+RISK_SPEC_LOW = 15
+RISK_SPEC_MEDIUM = 8
+RISK_TEST_FAILED = 12
+RISK_COVERAGE_UNKNOWN = 5
+
+# Setup message suppression period (days)
+SETUP_MESSAGE_RESCAN_DAYS = 7
+
+# =============================================================================
 # Setup import path for shared modules
 HOOKS_DIR = Path(__file__).parent
 LIB_DIR = HOOKS_DIR / "lib"
@@ -28,6 +69,7 @@ if str(LIB_DIR) not in sys.path:
     sys.path.insert(0, str(LIB_DIR))
 
 # Import path utils for project root resolution
+from lib.file_utils import check_file_size  # noqa: E402
 from lib.path_utils import find_project_root  # noqa: E402
 
 # Import unified timeout manager and Git operations manager
@@ -98,10 +140,10 @@ except ImportError:
 
         Handles:
         - Top-level keys with nested values
-        - String values (quoted or unquoted)
+        - String values (quoted or unquoted, including empty strings)
         - Boolean values (true/false)
         - Numeric values
-        - Comments (lines starting with #)
+        - Comments (lines starting with # or inline after values)
 
         Does NOT handle:
         - Lists
@@ -127,18 +169,39 @@ except ImportError:
                 key = key_part.strip()
                 value = value_part.strip()
 
-                # Remove inline comments
-                if "#" in value and not value.startswith('"') and not value.startswith("'"):
-                    value = value.split("#")[0].strip()
-
-                # Handle quoted strings
-                if (value.startswith('"') and value.endswith('"')) or (value.startswith("'") and value.endswith("'")):
-                    value = value[1:-1]
+                # Track if value was explicitly quoted (including empty strings)
+                was_quoted = False
+
+                # Handle quoted strings first - extract value within quotes
+                if value.startswith('"'):
+                    # Find the closing quote
+                    close_quote = value.find('"', 1)
+                    if close_quote > 0:
+                        value = value[1:close_quote]
+                        was_quoted = True
+                    elif value == '""':
+                        # Handle explicit empty string ""
+                        value = ""
+                        was_quoted = True
+                elif value.startswith("'"):
+                    # Find the closing quote
+                    close_quote = value.find("'", 1)
+                    if close_quote > 0:
+                        value = value[1:close_quote]
+                        was_quoted = True
+                    elif value == "''":
+                        # Handle explicit empty string ''
+                        value = ""
+                        was_quoted = True
+                else:
+                    # Remove inline comments for unquoted values
+                    if "#" in value:
+                        value = value.split("#")[0].strip()
 
                 # Top-level key (no indentation or minimal indentation)
                 if indent == 0:
-                    if value:
-                        # Simple key: value
+                    if value or was_quoted:
+                        # Simple key: value (including empty quoted strings)
                         result[key] = _parse_simple_value(value)
                     else:
                         # Section header (e.g., "user:", "language:")
@@ -146,10 +209,11 @@ except ImportError:
                         result[current_section] = {}
                 elif current_section and indent > 0:
                     # Nested key under current section
-                    if value:
+                    if value or was_quoted:
+                        # Store value (including empty quoted strings)
                         result[current_section][key] = _parse_simple_value(value)
                     else:
-                        # Nested section (2-level nesting)
+                        # Nested section (2-level nesting) - only when no value at all
                         result[current_section][key] = {}
 
         return result
@@ -189,6 +253,13 @@ except ImportError:
         """Load a YAML file using PyYAML or simple parser."""
         if not file_path.exists():
             return {}
+
+        # Check file size before reading (H2: 10MB limit)
+        is_safe, error_msg = check_file_size(file_path)
+        if not is_safe:
+            # File too large or other error, skip loading
+            return {}
+
         try:
             content = file_path.read_text(encoding="utf-8")
             if HAS_YAML_FALLBACK:
@@ -219,9 +290,14 @@ except ImportError:
         if not config:
             json_config_path = config_dir / "config.json"
             if json_config_path.exists():
-                try:
-                    config = json.loads(json_config_path.read_text(encoding="utf-8"))
-                except (json.JSONDecodeError, OSError):
+                # Check file size before reading (H2: 10MB limit)
+                is_safe, _ = check_file_size(json_config_path)
+                if is_safe:
+                    try:
+                        config = json.loads(json_config_path.read_text(encoding="utf-8"))
+                    except (json.JSONDecodeError, OSError):
+                        config = {}
+                else:
                     config = {}
 
         # Merge section files (they take priority for their specific keys)
@@ -326,7 +402,7 @@ def should_show_setup_messages() -> bool:
         # Flag is False, show messages
         return True
 
-    # Flag is True, check time threshold (7 days)
+    # Flag is True, check time threshold
     suppressed_at_str = session_config.get("setup_messages_suppressed_at")
     if not suppressed_at_str:
         # No timestamp recorded, show messages
@@ -337,8 +413,8 @@ def should_show_setup_messages() -> bool:
         now = datetime.now(suppressed_at.tzinfo) if suppressed_at.tzinfo else datetime.now()
         days_passed = (now - suppressed_at).days
 
-        # Show messages if more than 7 days have passed
-        return days_passed >= 7
+        # Show messages if threshold exceeded
+        return days_passed >= SETUP_MESSAGE_RESCAN_DAYS
     except (ValueError, TypeError):
         # If timestamp is invalid, show messages
         return True
@@ -358,7 +434,7 @@ def check_git_initialized() -> bool:
         return False
 
 
-def get_git_info() -> Dict[str, Any]:
+def get_git_info() -> dict[str, Any]:
     """Get comprehensive git information using optimized Git operations manager
 
     FIXED: Handles git not initialized state properly
@@ -407,6 +483,7 @@ def get_git_info() -> Dict[str, Any]:
 
     # Fallback to basic Git operations
     try:
+        import concurrent.futures
         from concurrent.futures import ThreadPoolExecutor, as_completed
 
         # Define git commands to run in parallel
@@ -425,14 +502,27 @@ def get_git_info() -> Dict[str, Any]:
             # Submit all tasks
             futures = {executor.submit(_run_git_command_fallback, cmd): key for cmd, key in git_commands}
 
-            # Collect results as they complete
-            for future in as_completed(futures):
-                key = futures[future]
-                try:
-                    results[key] = future.result()
-                except (TimeoutError, RuntimeError):
-                    # Future execution timeout or runtime errors
-                    results[key] = ""
+            # Collect results as they complete with overall timeout
+            # FIX #254: Add timeout to prevent infinite waiting on stuck git operations
+            try:
+                for future in as_completed(futures, timeout=8):
+                    key = futures[future]
+                    try:
+                        results[key] = future.result()
+                    except (TimeoutError, RuntimeError):
+                        # Future execution timeout or runtime errors
+                        results[key] = ""
+            except concurrent.futures.TimeoutError:
+                # Overall timeout exceeded - use whatever results we have
+                logging.warning("Git operations timeout after 8 seconds - using partial results")
+                # Collect any completed futures before timeout
+                for future, key in futures.items():
+                    if future.done():
+                        try:
+                            if key not in results:
+                                results[key] = future.result()
+                        except (TimeoutError, RuntimeError):
+                            results[key] = ""
 
         # Process results with proper handling for empty values
         branch = results.get("branch", "")
@@ -628,31 +718,31 @@ def get_spec_progress() -> dict[str, Any]:
 
 
 def calculate_risk(git_info: dict, spec_progress: dict, test_info: dict) -> str:
-    """Calculate overall project risk level"""
+    """Calculate overall project risk level using defined thresholds."""
     risk_score = 0
 
     # Git changes contribute to risk
-    if git_info["changes"] > 20:
-        risk_score += 10
-    elif git_info["changes"] > 10:
-        risk_score += 5
+    if git_info["changes"] > GIT_CHANGES_HIGH_THRESHOLD:
+        risk_score += RISK_GIT_CHANGES_HIGH
+    elif git_info["changes"] > GIT_CHANGES_MEDIUM_THRESHOLD:
+        risk_score += RISK_GIT_CHANGES_MEDIUM
 
     # SPEC progress contributes to risk
-    if spec_progress["percentage"] < 50:
-        risk_score += 15
-    elif spec_progress["percentage"] < 80:
-        risk_score += 8
+    if spec_progress["percentage"] < SPEC_PROGRESS_LOW:
+        risk_score += RISK_SPEC_LOW
+    elif spec_progress["percentage"] < SPEC_PROGRESS_MEDIUM:
+        risk_score += RISK_SPEC_MEDIUM
 
     # Test status contributes to risk
     if test_info["status"] != "✅":
-        risk_score += 12
+        risk_score += RISK_TEST_FAILED
     elif test_info["coverage"] == "unknown":
-        risk_score += 5
+        risk_score += RISK_COVERAGE_UNKNOWN
 
     # Determine risk level
-    if risk_score >= 20:
+    if risk_score >= RISK_SCORE_HIGH:
         return "HIGH"
-    elif risk_score >= 10:
+    elif risk_score >= RISK_SCORE_MEDIUM:
         return "MEDIUM"
     else:
         return "LOW"
@@ -871,31 +961,35 @@ def format_session_output() -> str:
     ]
 
     # FIX #5: Add personalization or setup guidance (never show template variables)
+    # Multilingual support: ko, en, ja, zh
+    conv_lang = personalization.get("conversation_language", "en")
+
     if personalization.get("needs_setup", False):
         # Show setup guidance (based on conversation_language)
-        if personalization["is_korean"]:
-            output.append(
-                "   👋 환영합니다! 프로젝트를 시작하기 전에 "
-                "'/moai:0-project setting' 명령어로 사용자 이름과 설정을 구성해주세요"
-            )
-        else:
-            output.append(
-                "   👋 Welcome! Before starting, please run '/moai:0-project setting' "
-                "to configure your name and project settings"
-            )
+        # Guide user to generate project documentation with /moai:0-project
+        setup_messages = {
+            "ko": "   👋 환영합니다! '/moai:0-project' 명령어로 프로젝트 문서를 생성해주세요",
+            "ja": "   👋 ようこそ！'/moai:0-project' コマンドでプロジェクトドキュメントを生成してください",
+            "zh": "   👋 欢迎！请运行 '/moai:0-project' 命令生成项目文档",
+            "en": "   👋 Welcome! Please run '/moai:0-project' to generate project documentation",
+        }
+        output.append(setup_messages.get(conv_lang, setup_messages["en"]))
     elif personalization["has_personalization"]:
         user_greeting = personalization.get("personalized_greeting", "")
-        if user_greeting:
-            if personalization["is_korean"]:
-                greeting = f"   👋 다시 오신 것을 환영합니다, {user_greeting}!"
-            else:
-                greeting = f"   👋 Welcome back, {user_greeting}!"
-        else:
-            if personalization["is_korean"]:
-                greeting = f"   👋 다시 오신 것을 환영합니다, {personalization['user_name']}님!"
-            else:
-                greeting = f"   👋 Welcome back, {personalization['user_name']}!"
-        output.append(greeting)
+        user_name = personalization.get("user_name", "")
+        display_name = user_greeting if user_greeting else user_name
+
+        # Prevent duplicate honorifics (e.g., "님님" in Korean, "さんさん" in Japanese)
+        ko_suffix = "" if display_name.endswith("님") else "님"
+        ja_suffix = "" if display_name.endswith("さん") else "さん"
+
+        welcome_back_messages = {
+            "ko": f"   👋 다시 오신 것을 환영합니다, {display_name}{ko_suffix}!",
+            "ja": f"   👋 おかえりなさい、{display_name}{ja_suffix}！",
+            "zh": f"   👋 欢迎回来，{display_name}！",
+            "en": f"   👋 Welcome back, {display_name}!",
+        }
+        output.append(welcome_back_messages.get(conv_lang, welcome_back_messages["en"]))
 
     # Configuration source is now handled silently for cleaner output
     # Users can check configuration using dedicated tools if needed
@@ -938,8 +1032,9 @@ def main() -> None:
         """Execute session start logic with proper error handling"""
         # Read JSON payload from stdin (for compatibility)
         # Handle Docker/non-interactive environments by checking TTY
+        # Note: SessionStart hook receives session info but we don't need it currently
         input_data = sys.stdin.read() if not sys.stdin.isatty() else "{}"
-        json.loads(input_data) if input_data.strip() else {}
+        _ = json.loads(input_data) if input_data.strip() else {}  # Explicitly ignore
 
         # Check if setup messages should be shown
         show_messages = should_show_setup_messages()
@@ -948,7 +1043,7 @@ def main() -> None:
         session_output = format_session_output() if show_messages else ""
 
         # Return as system message
-        result: Dict[str, Any] = {
+        result: dict[str, Any] = {
             "continue": True,
             "systemMessage": session_output,
             "performance": {
@@ -974,7 +1069,7 @@ def main() -> None:
 
         except HookTimeoutError as e:
             # Enhanced timeout error handling
-            timeout_response: Dict[str, Any] = {
+            timeout_response: dict[str, Any] = {
                 "continue": True,
                 "systemMessage": "⚠️ Session start timeout - continuing without project info",
                 "error_details": {
@@ -990,7 +1085,7 @@ def main() -> None:
 
         except Exception as e:
             # Enhanced error handling with context
-            error_response: Dict[str, Any] = {
+            error_response: dict[str, Any] = {
                 "continue": True,
                 "systemMessage": "⚠️ Session start encountered an error - continuing",
                 "error_details": {
@@ -1020,7 +1115,7 @@ def main() -> None:
 
             except PlatformTimeoutError:
                 # Timeout - return minimal valid response
-                timeout_response_legacy: Dict[str, Any] = {
+                timeout_response_legacy: dict[str, Any] = {
                     "continue": True,
                     "systemMessage": "⚠️ Session start timeout - continuing without project info",
                 }
@@ -1052,7 +1147,7 @@ def main() -> None:
 
         except json.JSONDecodeError as e:
             # JSON parse error
-            json_error_response: Dict[str, Any] = {
+            json_error_response: dict[str, Any] = {
                 "continue": True,
                 "hookSpecificOutput": {"error": f"JSON parse error: {e}"},
             }
@@ -1062,7 +1157,7 @@ def main() -> None:
 
         except Exception as e:
             # Unexpected error
-            general_error_response: Dict[str, Any] = {
+            general_error_response: dict[str, Any] = {
                 "continue": True,
                 "hookSpecificOutput": {"error": f"SessionStart error: {e}"},
             }

moai_adk/templates/.claude/hooks/moai/shared/utils/announcement_translator.py

@@ -0,0 +1,206 @@
+#!/usr/bin/env python3
+"""Announcement translator for multi-language companyAnnouncements support.
+
+This module loads language-specific announcements from .moai/announcements/{lang}.json
+based on the conversation_language setting in language.yaml.
+
+Supported languages: ko, en, ja, zh
+Fallback: en (English)
+"""
+
+from __future__ import annotations
+
+import json
+
+# Import atomic_write from lib directory (go up two levels from shared/utils/)
+import sys
+from pathlib import Path
+from pathlib import Path as _Path
+
+_lib_path = _Path(__file__).parent.parent.parent / "lib"
+if str(_lib_path) not in sys.path:
+    sys.path.insert(0, str(_lib_path))
+from atomic_write import atomic_write_json  # noqa: E402
+
+# Default language if not configured
+DEFAULT_LANGUAGE = "en"
+
+# Supported languages
+SUPPORTED_LANGUAGES = {"ko", "en", "ja", "zh"}
+
+
+def get_language_from_config(project_path: Path | str) -> str:
+    """Get conversation_language from language.yaml config.
+
+    Args:
+        project_path: Path to the project root directory
+
+    Returns:
+        Language code (ko, en, ja, zh). Defaults to 'en' if not found.
+    """
+    project_path = Path(project_path)
+    language_file = project_path / ".moai" / "config" / "sections" / "language.yaml"
+
+    if not language_file.exists():
+        return DEFAULT_LANGUAGE
+
+    try:
+        import yaml
+
+        with open(language_file, encoding="utf-8") as f:
+            config = yaml.safe_load(f)
+
+        language = config.get("language", {}).get("conversation_language", DEFAULT_LANGUAGE)
+
+        # Validate language code
+        if language not in SUPPORTED_LANGUAGES:
+            return DEFAULT_LANGUAGE
+
+        return language
+
+    except Exception:
+        return DEFAULT_LANGUAGE
+
+
+def get_announcements_path(project_path: Path | str) -> Path:
+    """Get the path to announcements directory.
+
+    Args:
+        project_path: Path to the project root directory
+
+    Returns:
+        Path to .moai/announcements directory
+    """
+    project_path = Path(project_path)
+    return project_path / ".moai" / "announcements"
+
+
+def load_announcements_from_file(announcements_file: Path) -> list[str]:
+    """Load announcements from a JSON file.
+
+    Args:
+        announcements_file: Path to the announcements JSON file
+
+    Returns:
+        List of announcement strings
+    """
+    if not announcements_file.exists():
+        return []
+
+    try:
+        with open(announcements_file, encoding="utf-8") as f:
+            data = json.load(f)
+        return data.get("companyAnnouncements", [])
+    except Exception:
+        return []
+
+
+def translate_announcements(language: str, project_path: Path | str) -> list[str]:
+    """Get announcements for the specified language.
+
+    Args:
+        language: Language code (ko, en, ja, zh)
+        project_path: Path to the project root directory
+
+    Returns:
+        List of announcement strings in the specified language.
+        Falls back to English if language file not found.
+    """
+    project_path = Path(project_path)
+    announcements_dir = get_announcements_path(project_path)
+
+    # Try requested language first
+    language_file = announcements_dir / f"{language}.json"
+    announcements = load_announcements_from_file(language_file)
+
+    if announcements:
+        return announcements
+
+    # Fallback to English
+    if language != DEFAULT_LANGUAGE:
+        english_file = announcements_dir / f"{DEFAULT_LANGUAGE}.json"
+        announcements = load_announcements_from_file(english_file)
+        if announcements:
+            return announcements
+
+    # Final fallback: return default announcements
+    return get_default_announcements()
+
+
+def get_default_announcements() -> list[str]:
+    """Get default English announcements as fallback.
+
+    Returns:
+        List of default announcement strings in English
+    """
+    return [
+        "🗿 MoAI-ADK: SPEC-First TDD with 48 Skills and Context7 integration",
+        "⚡ /moai:alfred: One-stop Plan→Run→Sync automation with intelligent routing",
+        "🌳 moai-worktree: Parallel SPEC development - work on multiple features simultaneously",
+        "🤖 20 Agents: 8 Expert + 8 Manager + 4 Builder for specialized tasks",
+        "📋 Workflow: /moai:1-plan (SPEC) → /moai:2-run (TDD) → /moai:3-sync (Docs)",
+        "✅ Quality: TRUST 5 + ≥85% coverage + Ralph Engine (LSP + AST-grep)",
+        "📚 Tip: moai update --templates-only syncs latest skills and agents",
+        "🏆 moai rank: Track your Claude token usage on rank.mo.ai.kr",
+    ]
+
+
+def update_settings_announcements(project_path: Path | str) -> bool:
+    """Update companyAnnouncements in settings.local.json based on language config.
+
+    This function is called during 'moai update' to refresh announcements
+    according to the current language setting.
+
+    Args:
+        project_path: Path to the project root directory
+
+    Returns:
+        True if update successful, False otherwise
+    """
+    project_path = Path(project_path)
+    settings_file = project_path / ".claude" / "settings.local.json"
+
+    if not settings_file.exists():
+        return False
+
+    try:
+        # Load current settings
+        with open(settings_file, encoding="utf-8") as f:
+            settings = json.load(f)
+
+        # Get language and announcements
+        language = get_language_from_config(project_path)
+        announcements = translate_announcements(language, project_path)
+
+        # Update announcements
+        settings["companyAnnouncements"] = announcements
+
+        # Write back using atomic write (H3)
+        atomic_write_json(settings_file, settings, indent=2, ensure_ascii=False)
+
+        return True
+
+    except Exception:
+        return False
+
+
+# Alias for backward compatibility with update.py
+auto_translate_and_update = update_settings_announcements
+
+
+if __name__ == "__main__":
+    # Test the module
+    import sys
+
+    if len(sys.argv) > 1:
+        test_path = Path(sys.argv[1])
+    else:
+        test_path = Path.cwd()
+
+    lang = get_language_from_config(test_path)
+    print(f"Detected language: {lang}")
+
+    announcements = translate_announcements(lang, test_path)
+    print(f"Announcements ({len(announcements)} items):")
+    for ann in announcements:
+        print(f"  - {ann}")