thanh-kit 2.5.0

package/templates/hooks/scout-block/tests/test-monorepo-scenarios.js

@@ -0,0 +1,225 @@
+#!/usr/bin/env node
+/**
+ * test-monorepo-scenarios.js - Integration tests for monorepo patterns
+ *
+ * THIS IS THE CRITICAL TEST FILE FOR THE BUG FIX!
+ * Tests that subfolder blocked directories (node_modules, dist, etc.)
+ * are properly blocked in monorepo structures.
+ */
+
+const { execSync } = require('child_process');
+const path = require('path');
+
+const hookPath = path.join(__dirname, '..', '..', 'scout-block.cjs');
+
+const scenarios = [
+  // === THE BUG CASES - These MUST be BLOCKED ===
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'ls packages/web/node_modules' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] ls subfolder node_modules'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'cd apps/api/node_modules' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] cd subfolder node_modules'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'cat packages/shared/node_modules/lodash/index.js' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] cat file in subfolder node_modules'
+  },
+  {
+    input: { tool_name: 'Read', tool_input: { file_path: 'packages/web/node_modules/react/package.json' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] Read subfolder node_modules'
+  },
+  {
+    input: { tool_name: 'Grep', tool_input: { pattern: 'export', path: 'packages/web/node_modules' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] Grep in subfolder node_modules'
+  },
+  {
+    input: { tool_name: 'Glob', tool_input: { pattern: 'packages/web/node_modules/**/*.js' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] Glob subfolder node_modules'
+  },
+
+  // === Deep nesting (also bug cases) ===
+  {
+    input: { tool_name: 'Read', tool_input: { file_path: 'a/b/c/d/node_modules/pkg/index.js' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] Deep nested node_modules'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'ls packages/web/dist' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] ls subfolder dist'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'cat apps/api/build/server.js' } },
+    expected: 'BLOCKED',
+    desc: '[BUG FIX] cat subfolder build'
+  },
+
+  // === Root level blocking (should still work) ===
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'ls node_modules' } },
+    expected: 'BLOCKED',
+    desc: 'ls root node_modules'
+  },
+  {
+    input: { tool_name: 'Read', tool_input: { file_path: 'node_modules/lodash/index.js' } },
+    expected: 'BLOCKED',
+    desc: 'Read root node_modules'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'cat .git/config' } },
+    expected: 'BLOCKED',
+    desc: 'cat .git file'
+  },
+
+  // === Build commands - MUST be ALLOWED ===
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'npm run build' } },
+    expected: 'ALLOWED',
+    desc: 'npm run build'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'pnpm build' } },
+    expected: 'ALLOWED',
+    desc: 'pnpm build'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'yarn build' } },
+    expected: 'ALLOWED',
+    desc: 'yarn build'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'npm test' } },
+    expected: 'ALLOWED',
+    desc: 'npm test'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'npm install' } },
+    expected: 'ALLOWED',
+    desc: 'npm install'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'pnpm --filter web run build' } },
+    expected: 'ALLOWED',
+    desc: 'pnpm filter build'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'npx tsc' } },
+    expected: 'ALLOWED',
+    desc: 'npx tsc'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'jest --coverage' } },
+    expected: 'ALLOWED',
+    desc: 'jest with flags'
+  },
+
+  // === Safe operations - MUST be ALLOWED ===
+  {
+    input: { tool_name: 'Read', tool_input: { file_path: 'packages/web/src/App.tsx' } },
+    expected: 'ALLOWED',
+    desc: 'Read safe path'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'ls packages/web/src' } },
+    expected: 'ALLOWED',
+    desc: 'ls safe path'
+  },
+  {
+    input: { tool_name: 'Grep', tool_input: { pattern: 'import', path: 'src' } },
+    expected: 'ALLOWED',
+    desc: 'Grep in src'
+  },
+  {
+    input: { tool_name: 'Glob', tool_input: { pattern: '**/*.ts' } },
+    expected: 'ALLOWED',
+    desc: 'Glob all .ts files'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'find packages -name "*.json" | head' } },
+    expected: 'ALLOWED',
+    desc: 'find without blocked dirs'
+  },
+
+  // === Edge cases - names containing blocked words but NOT the dirs ===
+  {
+    input: { tool_name: 'Read', tool_input: { file_path: 'my-node_modules-project/file.js' } },
+    expected: 'ALLOWED',
+    desc: 'node_modules in project name'
+  },
+  {
+    input: { tool_name: 'Bash', tool_input: { command: 'ls build-tools' } },
+    expected: 'ALLOWED',
+    desc: 'build- prefix directory'
+  },
+];
+
+console.log('Testing monorepo scenarios (scout-block integration)...\n');
+console.log('Hook path:', hookPath, '\n');
+
+let passed = 0;
+let failed = 0;
+
+for (const scenario of scenarios) {
+  try {
+    execSync(`node "${hookPath}"`, {
+      input: JSON.stringify(scenario.input),
+      encoding: 'utf-8',
+      stdio: ['pipe', 'pipe', 'pipe']
+    });
+    // Exit 0 = ALLOWED
+    const actual = 'ALLOWED';
+    const success = actual === scenario.expected;
+    if (success) {
+      console.log(`\x1b[32m✓\x1b[0m ${scenario.desc}: ${actual}`);
+      passed++;
+    } else {
+      console.log(`\x1b[31m✗\x1b[0m ${scenario.desc}: expected ${scenario.expected}, got ${actual}`);
+      failed++;
+    }
+  } catch (error) {
+    // Exit 2 = BLOCKED
+    const actual = error.status === 2 ? 'BLOCKED' : `ERROR(${error.status})`;
+    const success = actual === scenario.expected;
+    if (success) {
+      console.log(`\x1b[32m✓\x1b[0m ${scenario.desc}: ${actual}`);
+      passed++;
+    } else {
+      console.log(`\x1b[31m✗\x1b[0m ${scenario.desc}: expected ${scenario.expected}, got ${actual}`);
+      if (error.stderr) {
+        console.log(`  stderr: ${error.stderr.toString().trim().split('\n')[0]}`);
+      }
+      failed++;
+    }
+  }
+}
+
+console.log(`\nResults: ${passed} passed, ${failed} failed`);
+
+// Highlight if any bug fix cases failed
+const bugFixFailed = scenarios.filter(s => s.desc.includes('[BUG FIX]')).some(s => {
+  try {
+    execSync(`node "${hookPath}"`, {
+      input: JSON.stringify(s.input),
+      encoding: 'utf-8',
+      stdio: ['pipe', 'pipe', 'pipe']
+    });
+    return s.expected === 'BLOCKED'; // Should have been blocked but wasn't
+  } catch (error) {
+    return error.status !== 2 && s.expected === 'BLOCKED';
+  }
+});
+
+if (bugFixFailed) {
+  console.log('\n\x1b[31mWARNING: Some bug fix test cases failed!\x1b[0m');
+  console.log('The subfolder blocking bug has NOT been fixed properly.');
+}
+
+process.exit(failed > 0 ? 1 : 0);

package/templates/hooks/scout-block/tests/test-path-extractor.js

@@ -0,0 +1,138 @@
+#!/usr/bin/env node
+/**
+ * test-path-extractor.js - Unit tests for path-extractor module
+ */
+
+const { extractFromToolInput, extractFromCommand, looksLikePath } = require('../path-extractor.cjs');
+
+const toolInputTests = [
+  {
+    input: { file_path: 'packages/web/src/index.js' },
+    expected: ['packages/web/src/index.js'],
+    desc: 'file_path extraction'
+  },
+  {
+    input: { path: 'node_modules' },
+    expected: ['node_modules'],
+    desc: 'path extraction'
+  },
+  {
+    input: { pattern: '**/node_modules/**' },
+    expected: ['**/node_modules/**'],
+    desc: 'pattern extraction'
+  },
+  {
+    input: { command: 'ls packages/web/node_modules' },
+    hasPath: 'packages/web/node_modules',
+    desc: 'command path extraction'
+  },
+  {
+    input: { file_path: '/home/user/project/node_modules/pkg/index.js' },
+    expected: ['/home/user/project/node_modules/pkg/index.js'],
+    desc: 'absolute path extraction'
+  },
+  {
+    input: { file_path: 'packages/web/node_modules/react/package.json', path: 'src' },
+    hasPath: 'packages/web/node_modules',
+    desc: 'multiple params extraction'
+  }
+];
+
+const commandTests = [
+  { cmd: 'ls packages/web/node_modules', hasPath: 'packages/web/node_modules', desc: 'ls with subfolder' },
+  { cmd: 'cat "path with spaces/file.js"', hasPath: 'path with spaces/file.js', desc: 'quoted path' },
+  { cmd: "cat 'single/quoted/path.js'", hasPath: 'single/quoted/path.js', desc: 'single quoted path' },
+  { cmd: 'cd apps/api/node_modules && ls', hasPath: 'apps/api/node_modules', desc: 'cd with chained command' },
+  { cmd: 'rm -rf node_modules', hasPath: 'node_modules', desc: 'rm with flags' },
+  { cmd: 'cp -r dist/ backup/', hasPath: 'dist', desc: 'cp with flags' },
+
+  // Note: Build commands may extract 'build' as a blocked dir name, but this is handled
+  // at the dispatcher level (build commands bypass path checking entirely).
+  // The path extractor correctly identifies blocked dir names like 'build'.
+  { cmd: 'npm run build', hasPath: 'build', desc: 'npm run build (extracts build)' },
+  { cmd: 'pnpm build', hasPath: 'build', desc: 'pnpm build (extracts build)' },
+  { cmd: 'cd build', hasPath: 'build', desc: 'cd build (extracts build)' },
+  { cmd: 'yarn test', hasPath: null, desc: 'yarn test (no blocked paths)' },
+  { cmd: 'npm install', hasPath: null, desc: 'npm install (no blocked paths)' },
+];
+
+const looksLikePathTests = [
+  { str: 'packages/web/src', expected: true, desc: 'relative path with slashes' },
+  { str: '/home/user/project', expected: true, desc: 'absolute path' },
+  { str: './src/index.js', expected: true, desc: 'dot-relative path' },
+  { str: '../parent/file.js', expected: true, desc: 'parent-relative path' },
+  { str: 'file.txt', expected: true, desc: 'file with extension' },
+  { str: 'node_modules', expected: true, desc: 'blocked dir name' },
+  { str: 'ls', expected: false, desc: 'command word' },
+  { str: 'npm', expected: false, desc: 'package manager' },
+  { str: '-rf', expected: false, desc: 'flag' },
+  { str: '123', expected: false, desc: 'number' },
+];
+
+console.log('Testing path-extractor module...\n');
+
+let passed = 0;
+let failed = 0;
+
+// Tool input tests
+console.log('--- Tool Input Tests ---');
+for (const test of toolInputTests) {
+  const result = extractFromToolInput(test.input);
+  let success;
+
+  if (test.expected) {
+    success = test.expected.every(e => result.includes(e));
+  } else if (test.hasPath) {
+    success = result.some(p => p.includes(test.hasPath));
+  }
+
+  if (success) {
+    console.log(`\x1b[32m✓\x1b[0m ${test.desc}`);
+    passed++;
+  } else {
+    console.log(`\x1b[31m✗\x1b[0m ${test.desc}: got ${JSON.stringify(result)}`);
+    failed++;
+  }
+}
+
+// Command tests
+console.log('\n--- Command Tests ---');
+for (const test of commandTests) {
+  const result = extractFromCommand(test.cmd);
+  let success;
+
+  if (test.hasPath === null) {
+    // Build commands should extract few/no blocked-related paths
+    success = result.length === 0 || !result.some(p =>
+      p.includes('node_modules') || p.includes('dist') || p.includes('build')
+    );
+  } else {
+    success = result.some(p => p.includes(test.hasPath));
+  }
+
+  if (success) {
+    console.log(`\x1b[32m✓\x1b[0m ${test.desc}: ${JSON.stringify(result)}`);
+    passed++;
+  } else {
+    console.log(`\x1b[31m✗\x1b[0m ${test.desc}: expected path containing '${test.hasPath}', got ${JSON.stringify(result)}`);
+    failed++;
+  }
+}
+
+// looksLikePath tests
+console.log('\n--- looksLikePath Tests ---');
+for (const test of looksLikePathTests) {
+  const result = looksLikePath(test.str);
+  const success = result === test.expected;
+
+  if (success) {
+    console.log(`\x1b[32m✓\x1b[0m ${test.desc}: '${test.str}' -> ${result}`);
+    passed++;
+  } else {
+    console.log(`\x1b[31m✗\x1b[0m ${test.desc}: expected ${test.expected}, got ${result}`);
+    failed++;
+  }
+}
+
+console.log(`\nResults: ${passed} passed, ${failed} failed`);
+process.exit(failed > 0 ? 1 : 0);

package/templates/hooks/scout-block/tests/test-pattern-matcher.js

@@ -0,0 +1,64 @@
+#!/usr/bin/env node
+/**
+ * test-pattern-matcher.js - Unit tests for pattern-matcher module
+ */
+
+const path = require('path');
+const { loadPatterns, createMatcher, matchPath, DEFAULT_PATTERNS } = require('../pattern-matcher.cjs');
+
+const tests = [
+  // === Basic blocking at root ===
+  { path: 'node_modules/lodash', expected: true, desc: 'root node_modules with content' },
+  { path: 'node_modules', expected: true, desc: 'root node_modules bare' },
+  { path: '.git/objects', expected: true, desc: 'root .git' },
+  { path: 'dist/bundle.js', expected: true, desc: 'root dist' },
+  { path: 'build/output', expected: true, desc: 'root build' },
+  { path: '__pycache__/file.pyc', expected: true, desc: 'root __pycache__' },
+
+  // === Subfolder blocking (THE BUG FIX!) ===
+  { path: 'packages/web/node_modules/react', expected: true, desc: 'subfolder node_modules (monorepo)' },
+  { path: 'apps/api/node_modules', expected: true, desc: 'subfolder node_modules bare' },
+  { path: 'packages/.git/HEAD', expected: true, desc: 'subfolder .git' },
+  { path: 'packages/web/dist/index.js', expected: true, desc: 'subfolder dist' },
+  { path: 'apps/backend/build/server.js', expected: true, desc: 'subfolder build' },
+  { path: 'packages/shared/__pycache__/module.pyc', expected: true, desc: 'subfolder __pycache__' },
+
+  // === Deep nesting ===
+  { path: 'a/b/c/d/node_modules/e', expected: true, desc: 'deep nested node_modules' },
+  { path: 'projects/monorepo/packages/web/node_modules/react/index.js', expected: true, desc: 'very deep nested' },
+
+  // === Allowed paths ===
+  { path: 'src/index.js', expected: false, desc: 'src directory' },
+  { path: 'packages/web/src/App.tsx', expected: false, desc: 'nested src' },
+  { path: 'lib/utils.js', expected: false, desc: 'lib directory' },
+  { path: 'README.md', expected: false, desc: 'root file' },
+  { path: 'apps/api/server.ts', expected: false, desc: 'nested app file' },
+
+  // === Edge cases (should NOT be blocked) ===
+  { path: 'my-node_modules-project/file.js', expected: false, desc: 'node_modules in project name' },
+  { path: 'build-tools/script.sh', expected: false, desc: 'build- prefix in name' },
+  { path: 'src/dist-utils.js', expected: false, desc: 'dist- prefix in name' },
+  { path: 'nodemodulesbackup/file.js', expected: false, desc: 'node_modules without separator' },
+  { path: 'distro/file.js', expected: false, desc: 'dist prefix without separator' },
+];
+
+console.log('Testing pattern-matcher module...\n');
+
+const matcher = createMatcher(DEFAULT_PATTERNS);
+let passed = 0;
+let failed = 0;
+
+for (const test of tests) {
+  const result = matchPath(matcher, test.path);
+  const success = result.blocked === test.expected;
+  if (success) {
+    console.log(`\x1b[32m✓\x1b[0m ${test.desc}: ${test.path} -> ${result.blocked ? 'BLOCKED' : 'ALLOWED'}`);
+    passed++;
+  } else {
+    console.log(`\x1b[31m✗\x1b[0m ${test.desc}: expected ${test.expected ? 'BLOCKED' : 'ALLOWED'}, got ${result.blocked ? 'BLOCKED' : 'ALLOWED'}`);
+    failed++;
+  }
+}
+
+console.log(`\nResults: ${passed} passed, ${failed} failed`);
+process.exit(failed > 0 ? 1 : 0);