thanh-kit 2.5.0

package/templates/skills/skill-creator/scripts/quick_validate.py

@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+"""
+Quick validation script for skills - minimal version
+"""
+
+import sys
+import os
+import re
+from pathlib import Path
+
+def validate_skill(skill_path):
+    """Basic validation of a skill"""
+    skill_path = Path(skill_path)
+    
+    # Check SKILL.md exists
+    skill_md = skill_path / 'SKILL.md'
+    if not skill_md.exists():
+        return False, "SKILL.md not found"
+    
+    # Read and validate frontmatter
+    content = skill_md.read_text()
+    if not content.startswith('---'):
+        return False, "No YAML frontmatter found"
+    
+    # Extract frontmatter
+    match = re.match(r'^---\n(.*?)\n---', content, re.DOTALL)
+    if not match:
+        return False, "Invalid frontmatter format"
+    
+    frontmatter = match.group(1)
+    
+    # Check required fields
+    if 'name:' not in frontmatter:
+        return False, "Missing 'name' in frontmatter"
+    if 'description:' not in frontmatter:
+        return False, "Missing 'description' in frontmatter"
+    
+    # Extract name for validation
+    name_match = re.search(r'name:\s*(.+)', frontmatter)
+    if name_match:
+        name = name_match.group(1).strip()
+        # Check naming convention (hyphen-case: lowercase with hyphens)
+        if not re.match(r'^[a-z0-9-]+$', name):
+            return False, f"Name '{name}' should be hyphen-case (lowercase letters, digits, and hyphens only)"
+        if name.startswith('-') or name.endswith('-') or '--' in name:
+            return False, f"Name '{name}' cannot start/end with hyphen or contain consecutive hyphens"
+
+    # Extract and validate description
+    desc_match = re.search(r'description:\s*(.+)', frontmatter)
+    if desc_match:
+        description = desc_match.group(1).strip()
+        # Check for angle brackets
+        if '<' in description or '>' in description:
+            return False, "Description cannot contain angle brackets (< or >)"
+
+    return True, "Skill is valid!"
+
+if __name__ == "__main__":
+    if len(sys.argv) != 2:
+        print("Usage: python quick_validate.py <skill_directory>")
+        sys.exit(1)
+    
+    valid, message = validate_skill(sys.argv[1])
+    print(message)
+    sys.exit(0 if valid else 1)

package/templates/skills/skill-share/SKILL.md

@@ -0,0 +1,80 @@
+---
+name: skill-share
+description: A skill that creates new Claude skills and automatically shares them on Slack using Rube for seamless team collaboration and skill discovery.
+license: Complete terms in LICENSE.txt
+---
+
+## When to use this skill
+
+Use this skill when you need to:
+- **Create new Claude skills** with proper structure and metadata
+- **Generate skill packages** ready for distribution
+- **Automatically share created skills** on Slack channels for team visibility
+- **Validate skill structure** before sharing
+- **Package and distribute** skills to your team
+
+Also use this skill when:
+- **User says he wants to create/share his skill** 
+
+This skill is ideal for:
+- Creating skills as part of team workflows
+- Building internal tools that need skill creation + team notification
+- Automating the skill development pipeline
+- Collaborative skill creation with team notifications
+
+## Key Features
+
+### 1. Skill Creation
+- Creates properly structured skill directories with SKILL.md
+- Generates standardized scripts/, references/, and assets/ directories
+- Auto-generates YAML frontmatter with required metadata
+- Enforces naming conventions (hyphen-case)
+
+### 2. Skill Validation
+- Validates SKILL.md format and required fields
+- Checks naming conventions
+- Ensures metadata completeness before packaging
+
+### 3. Skill Packaging
+- Creates distributable zip files
+- Includes all skill assets and documentation
+- Runs validation automatically before packaging
+
+### 4. Slack Integration via Rube
+- Automatically sends created skill information to designated Slack channels
+- Shares skill metadata (name, description, link)
+- Posts skill summary for team discovery
+- Provides direct links to skill files
+
+## How It Works
+
+1. **Initialization**: Provide skill name and description
+2. **Creation**: Skill directory is created with proper structure
+3. **Validation**: Skill metadata is validated for correctness
+4. **Packaging**: Skill is packaged into a distributable format
+5. **Slack Notification**: Skill details are posted to your team's Slack channel
+
+## Example Usage
+
+```
+When you ask Claude to create a skill called "pdf-analyzer":
+1. Creates /skill-pdf-analyzer/ with SKILL.md template
+2. Generates structured directories (scripts/, references/, assets/)
+3. Validates the skill structure
+4. Packages the skill as a zip file
+5. Posts to Slack: "New Skill Created: pdf-analyzer - Advanced PDF analysis and extraction capabilities"
+```
+
+## Integration with Rube
+
+This skill leverages Rube for:
+- **SLACK_SEND_MESSAGE**: Posts skill information to team channels
+- **SLACK_POST_MESSAGE_WITH_BLOCKS**: Shares rich formatted skill metadata
+- **SLACK_FIND_CHANNELS**: Discovers target channels for skill announcements
+
+## Requirements
+
+- Slack workspace connection via Rube
+- Write access to skill creation directory
+- Python 3.7+ for skill creation scripts
+- Target Slack channel for skill notifications

package/templates/skills/tasks-code-review/SKILL.md

@@ -0,0 +1,298 @@
+---
+name: code-review
+description: Use for QUICK PR reviews with structured checklists (architecture, patterns, security, performance). Provides step-by-step review process, git diff commands, and review report templates. Best for pull request reviews and pre-commit checks. NOT for deep refactoring analysis (use code-review instead).
+allowed-tools: Read, Write, Edit, Grep, Glob, Bash, Task
+---
+
+# Code Review Workflow
+
+## When to Use This Skill
+
+- Reviewing pull requests
+- Analyzing code for refactoring
+- Pre-commit code quality check
+- Security and performance audit
+
+## Review Dimensions
+
+### 1. Architecture Compliance
+
+- [ ] Follows Clean Architecture layers
+- [ ] Uses correct repository pattern
+- [ ] No cross-service boundary violations
+- [ ] Proper separation of concerns
+
+### 2. Pattern Adherence
+
+- [ ] CQRS patterns followed (Command/Query/Handler in ONE file)
+- [ ] Entity patterns correct (expressions, computed properties)
+- [ ] Frontend component hierarchy respected
+- [ ] Platform base classes used correctly
+
+### 3. Code Quality
+
+- [ ] Single Responsibility Principle
+- [ ] No code duplication
+- [ ] Meaningful naming
+- [ ] Appropriate abstractions
+
+### 4. Security
+
+- [ ] No SQL injection vulnerabilities
+- [ ] Authorization checks present
+- [ ] Sensitive data handling
+- [ ] Input validation
+
+### 5. Performance
+
+- [ ] N+1 query prevention (eager loading)
+- [ ] Proper paging for large datasets
+- [ ] Parallel operations where applicable
+- [ ] Caching considerations
+
+## Review Process
+
+### Step 1: Understand Context
+
+```bash
+# Get changed files
+git diff --name-only main...HEAD
+
+# Get full diff
+git diff main...HEAD
+
+# Check commit messages
+git log main...HEAD --oneline
+```
+
+### Step 2: Categorize Changes
+
+```markdown
+## Files Changed
+
+### Domain Layer
+
+- `Entity.cs` - New entity
+
+### Application Layer
+
+- `SaveEntityCommand.cs` - New command
+
+### Persistence Layer
+
+- `EntityConfiguration.cs` - EF configuration
+
+### Frontend
+
+- `entity-list.component.ts` - List component
+```
+
+### Step 3: Review Each Category
+
+#### Backend Review Checklist
+
+```markdown
+## Entity Review
+
+- [ ] Inherits from correct base (RootEntity/RootAuditedEntity)
+- [ ] Static expressions for queries
+- [ ] Computed properties have empty `set { }`
+- [ ] Navigation properties have `[JsonIgnore]`
+- [ ] `[TrackFieldUpdatedDomainEvent]` on tracked fields
+
+## Command/Query Review
+
+- [ ] Command + Handler + Result in ONE file
+- [ ] Uses service-specific repository
+- [ ] Validation uses fluent API
+- [ ] No side effects in command handler
+- [ ] DTO mapping in DTO class, not handler
+
+## Repository Usage Review
+
+- [ ] Uses `GetQueryBuilder` for reusable queries
+- [ ] Uses `WhereIf` for optional filters
+- [ ] Parallel tuple queries for count + data
+- [ ] Proper eager loading
+
+## Event Handler Review
+
+- [ ] In `UseCaseEvents/` folder
+- [ ] Uses `PlatformCqrsEntityEventApplicationHandler<T>`
+- [ ] `HandleWhen` is `public override async Task<bool>`
+- [ ] Filters by `CrudAction` appropriately
+```
+
+#### Frontend Review Checklist
+
+```markdown
+## Component Review
+
+- [ ] Correct base class for use case
+- [ ] Store provided at component level
+- [ ] Loading/error states handled
+- [ ] `untilDestroyed()` on subscriptions
+- [ ] Track-by in `@for` loops
+
+## Store Review
+
+- [ ] State interface defined
+- [ ] `vmConstructor` provides defaults
+- [ ] Effects use `observerLoadingErrorState`
+- [ ] Immutable state updates
+
+## Form Review
+
+- [ ] `validateForm()` before submit
+- [ ] Async validators conditional
+- [ ] Dependent validations configured
+- [ ] Error messages for all rules
+
+## API Service Review
+
+- [ ] Extends `PlatformApiService`
+- [ ] Typed responses
+- [ ] Caching where appropriate
+```
+
+### Step 4: Security Review
+
+```markdown
+## Security Checklist
+
+### Authorization
+
+- [ ] `[PlatformAuthorize]` on controllers
+- [ ] Role checks in handlers
+- [ ] Data filtered by company/user context
+
+### Input Validation
+
+- [ ] All inputs validated
+- [ ] No raw SQL strings
+- [ ] File upload validation
+
+### Sensitive Data
+
+- [ ] No secrets in code
+- [ ] Passwords hashed
+- [ ] PII handled correctly
+```
+
+### Step 5: Performance Review
+
+```markdown
+## Performance Checklist
+
+### Database
+
+- [ ] Indexes on filtered columns
+- [ ] Eager loading for N+1 prevention
+- [ ] Paging for large datasets
+
+### API
+
+- [ ] Response size reasonable
+- [ ] Parallel operations used
+- [ ] Caching for static data
+
+### Frontend
+
+- [ ] Lazy loading for routes
+- [ ] Track-by for lists
+- [ ] OnPush change detection
+```
+
+## Common Issues to Flag
+
+### :x: Anti-Patterns
+
+```csharp
+// Issue: Side effect in command handler
+await notificationService.SendAsync(...);
+
+// Issue: Wrong repository type
+IPlatformRootRepository<Entity>  // Should be service-specific
+
+// Issue: DTO mapping in handler
+var entity = new Entity { Name = request.Name };  // Should use DTO.MapToEntity()
+
+// Issue: Missing eager loading
+var items = await repo.GetAllAsync(...);  // Missing relations
+items.ForEach(i => Console.WriteLine(i.Related.Name));  // N+1!
+```
+
+```typescript
+// Issue: No loading state
+this.api.getItems().subscribe(items => this.items = items);
+
+// Issue: Direct mutation
+this.state.items.push(newItem);
+
+// Issue: Missing cleanup
+this.data$.subscribe(...);  // Missing untilDestroyed()
+```
+
+## Review Report Template
+
+```markdown
+# Code Review Report
+
+## Summary
+
+- **PR/Changes**: [Description]
+- **Reviewer**: AI
+- **Date**: [Date]
+
+## Overall Assessment
+
+[APPROVED | APPROVED WITH COMMENTS | CHANGES REQUESTED]
+
+## Strengths
+
+1. [Positive point 1]
+2. [Positive point 2]
+
+## Issues Found
+
+### Critical (Must Fix)
+
+1. **[File:Line]**: [Description]
+    - Problem: [Explanation]
+    - Suggestion: [Fix]
+
+### Major (Should Fix)
+
+1. **[File:Line]**: [Description]
+
+### Minor (Consider Fixing)
+
+1. **[File:Line]**: [Description]
+
+## Recommendations
+
+1. [Recommendation 1]
+2. [Recommendation 2]
+```
+
+## Review Commands
+
+```bash
+# Find potential issues
+grep -r "new Entity {" --include="*.cs"  # DTO mapping in handler
+grep -r "SendAsync\|NotifyAsync" --include="*CommandHandler.cs"  # Side effects
+grep -r "IPlatformRootRepository" --include="*.cs"  # Generic repository
+
+# Check patterns
+grep -r "observerLoadingErrorState" --include="*.ts"  # Loading tracking
+grep -r "untilDestroyed" --include="*.ts"  # Subscription cleanup
+```
+
+## Verification Checklist
+
+- [ ] All changed files reviewed
+- [ ] Architecture compliance verified
+- [ ] Platform patterns followed
+- [ ] Security concerns addressed
+- [ ] Performance considered
+- [ ] Review report generated