shipwright-cli 3.2.0 → 3.3.0

package/scripts/skills/validation-thoroughness.md

@@ -0,0 +1,55 @@
+## Validation Thoroughness: Prove It Works in Production
+
+Smoke tests are necessary but not sufficient. Validate the actual user experience.
+
+### Smoke Test Design
+- Test the critical user path end-to-end (not just health endpoints)
+- Verify the SPECIFIC functionality from this issue works
+- Include authentication flow if the feature requires auth
+- Test with realistic data, not just empty/default states
+
+### Health Check Layers
+1. **Liveness** — Is the process running? (HTTP 200 on /health)
+2. **Readiness** — Can it serve traffic? (dependencies connected, workers initialized)
+3. **Functional** — Does the new feature actually work? (feature-specific endpoint test)
+
+### Regression Detection
+- Run the full test suite against the deployed environment (not just smoke)
+- Compare response times to baseline — >20% regression is a red flag
+- Verify existing features still work (not just the new one)
+- Check error rates in logs for the first 100 requests
+
+### Production Readiness Checklist
+- [ ] Health endpoint returns 200
+- [ ] Key feature endpoint returns expected response
+- [ ] Error rate is below baseline threshold
+- [ ] Response latency is within acceptable range (p95 < SLO)
+- [ ] No new error patterns in logs
+- [ ] Database connections are healthy
+- [ ] External service integrations are working
+
+### Issue Closure Criteria
+Before automatically closing the issue:
+1. Smoke tests pass
+2. Health checks pass (5 consecutive successes)
+3. No error rate spike in first 5 minutes
+4. Feature-specific validation passes
+5. PR is merged and deployed
+
+### Failure Response
+If validation fails:
+1. Do NOT close the issue
+2. Create an incident issue with validation failure details
+3. Trigger rollback if auto-rollback is configured
+4. Preserve deploy logs and smoke test output for debugging
+
+### Required Output (Mandatory)
+
+Your output MUST include these sections when this skill is active:
+
+1. **Smoke Test Specification**: Explicit test cases covering the critical user path with realistic data (not just health endpoints)
+2. **Health Check Results**: Liveness check (process running), Readiness check (dependencies connected), Functional check (feature works)
+3. **Regression Detection**: Comparison of response times to baseline, error rate against baseline threshold, log analysis for new error patterns
+4. **Issue Closure Decision**: PASS/FAIL verdict with supporting evidence (all health checks passed, no error rate spike, feature-specific validation passed)
+
+If any section is not applicable, explicitly state why it's skipped.

package/scripts/sw

@@ -5,7 +5,7 @@
 # ╚═══════════════════════════════════════════════════════════════════════════╝
 set -euo pipefail
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 
 # Resolve symlinks (required for npm global install where bin/ symlinks to node_modules/)
 SOURCE="${BASH_SOURCE[0]}"
@@ -19,6 +19,7 @@ SCRIPT_DIR="$(cd "$(dirname "$SOURCE")" && pwd)"
 # ─── Colors (matches Seth's tmux theme) ─────────────────────────────────────
 CYAN='\033[38;2;0;212;255m'     # #00d4ff — primary accent
 PURPLE='\033[38;2;124;58;237m'  # #7c3aed — secondary
+# shellcheck disable=SC2034
 BLUE='\033[38;2;0;102;255m'     # #0066ff — tertiary
 GREEN='\033[38;2;74;222;128m'   # success
 YELLOW='\033[38;2;250;204;21m'  # warning
@@ -36,6 +37,7 @@ _sw_github_repo() {
         echo "${SHIPWRIGHT_GITHUB_REPO:-sethdford/shipwright}"
     fi
 }
+# shellcheck disable=SC2155
 _sw_github_owner() { local r="$(_sw_github_repo)"; echo "${r%%/*}"; }
 _sw_docs_url() { echo "${SHIPWRIGHT_DOCS_URL:-https://$(_sw_github_owner).github.io/shipwright}"; }
 _sw_github_url() { echo "https://github.com/$(_sw_github_repo)"; }
@@ -162,7 +164,7 @@ show_help_all() {
     echo -e "  ${CYAN}auth${RESET}          ${CYAN}webhook${RESET}       ${CYAN}eventbus${RESET}      ${CYAN}otel${RESET}          ${CYAN}context${RESET}"
     echo -e "  ${CYAN}trace${RESET}         ${CYAN}widgets${RESET}       ${CYAN}connect${RESET}       ${CYAN}remote${RESET}        ${CYAN}launchd${RESET}"
     echo -e "  ${CYAN}jira${RESET}          ${CYAN}linear${RESET}        ${CYAN}tracker${RESET}       ${CYAN}heartbeat${RESET}     ${CYAN}checkpoint${RESET}"
-    echo -e "  ${CYAN}durable${RESET}       ${CYAN}autonomous${RESET}    ${CYAN}pm${RESET}            ${CYAN}strategic${RESET}     ${CYAN}team-stages${RESET}"
+    echo -e "  ${CYAN}stall-detector${RESET} ${CYAN}durable${RESET}       ${CYAN}autonomous${RESET}    ${CYAN}pm${RESET}            ${CYAN}strategic${RESET}"
     echo -e "  ${CYAN}ux${RESET}            ${CYAN}mission-control${RESET}  ${CYAN}tmux${RESET}       ${CYAN}reaper${RESET}        ${CYAN}e2e${RESET}"
     echo -e "  ${CYAN}init${RESET}          ${CYAN}setup${RESET}         ${CYAN}doctor${RESET}        ${CYAN}cleanup${RESET}       ${CYAN}upgrade${RESET}"
     echo -e "  ${CYAN}templates${RESET}     ${CYAN}version${RESET}"
@@ -265,6 +267,7 @@ main() {
 
     shift 2>/dev/null || true
 
+    # shellcheck disable=SC2221,SC2222
     case "$cmd" in
         # Command groups
         agent)          route_agent "$@" ;;
@@ -402,6 +405,9 @@ main() {
         checkpoint)
             exec "$SCRIPT_DIR/sw-checkpoint.sh" "$@"
             ;;
+        stall-detector)
+            exec "$SCRIPT_DIR/sw-stall-detector.sh" "$@"
+            ;;
         durable)
             exec "$SCRIPT_DIR/sw-durable.sh" "$@"
             ;;
@@ -600,7 +606,7 @@ main() {
             show_version
             ;;
         hello)
-            echo "hello world"
+            exec "$SCRIPT_DIR/sw-hello.sh" "$@"
             ;;
         *)
             error "Unknown command: ${cmd}"

package/scripts/sw-activity.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -28,7 +29,8 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
+    local payload
+    payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
@@ -39,7 +41,9 @@ FILTER_TYPE=""
 FILTER_AGENT=""
 FILTER_TEAM=""
 FILTER_STAGE=""
+# shellcheck disable=SC2034
 FILTER_START=""
+# shellcheck disable=SC2034
 FILTER_END=""
 
 # Event type icons for terminal display (bash 3.2 compatible)
@@ -223,7 +227,9 @@ cmd_snapshot() {
 
     # Group by agent, show last event for each
     local last_agent=""
+    # shellcheck disable=SC2034
     local last_time=""
+    # shellcheck disable=SC2034
     local last_event=""
 
     tac "$EVENTS_FILE" 2>/dev/null | while IFS= read -r line; do
@@ -443,6 +449,7 @@ main() {
     shift 2>/dev/null || true
 
     # Parse global options
+    # shellcheck disable=SC2034
     while [ $# -gt 0 ]; do
         case "$1" in
             --type)   FILTER_TYPE="$2"; shift 2 ;;

package/scripts/sw-adaptive.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -31,6 +31,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"

package/scripts/sw-adversarial.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,6 +29,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"

package/scripts/sw-architecture-enforcer.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,12 +29,14 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
 # ─── Structured Event Log ────────────────────────────────────────────────
+# shellcheck disable=SC2034
 EVENTS_FILE="${HOME}/.shipwright/events.jsonl"
 
 # ─── Source Intelligence Core ─────────────────────────────────────────────

package/scripts/sw-auth.sh

@@ -6,8 +6,10 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck disable=SC2034
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -30,7 +32,8 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
+    local payload
+    payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
@@ -40,6 +43,7 @@ AUTH_FILE="${HOME}/.shipwright/auth.json"
 DEVICE_FLOW_ENDPOINT="$(_config_get "urls.github_device_login" "https://github.com/login/device")"
 API_ENDPOINT="$(_config_get "urls.github_api" "https://api.github.com")"
 OAUTH_CLIENT_ID="${GITHUB_OAUTH_CLIENT_ID:-Iv1.d3f6a7e8c9b2a1d4}"  # Shipwright app ID
+# shellcheck disable=SC2034
 OAUTH_TIMEOUT=900  # 15 minutes
 
 # Ensure auth storage directory exists
@@ -202,6 +206,8 @@ store_user() {
 
     local temp_file
     temp_file=$(mktemp)
+    # shellcheck disable=SC2064
+    # shellcheck disable=SC2064
     trap "rm -f '$temp_file'" RETURN
 
     local updated
@@ -246,6 +252,8 @@ switch_user() {
 
     local temp_file
     temp_file=$(mktemp)
+    # shellcheck disable=SC2064
+    # shellcheck disable=SC2064
     trap "rm -f '$temp_file'" RETURN
 
     jq --arg login "$login" '.active_user = $login' "$AUTH_FILE" > "$temp_file"
@@ -261,6 +269,8 @@ remove_user() {
 
     local temp_file
     temp_file=$(mktemp)
+    # shellcheck disable=SC2064
+    # shellcheck disable=SC2064
     trap "rm -f '$temp_file'" RETURN
 
     jq --arg login "$login" \

package/scripts/sw-autonomous.sh

@@ -7,7 +7,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,6 +30,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -53,6 +55,7 @@ STATE_DIR="${HOME}/.shipwright/autonomous"
 STATE_FILE="${STATE_DIR}/state.json"
 HISTORY_FILE="${STATE_DIR}/history.jsonl"
 CONFIG_FILE="${STATE_DIR}/config.json"
+# shellcheck disable=SC2034
 CYCLE_COUNTER="${STATE_DIR}/cycle-counter.txt"
 AUTONOMOUS_OVERLAP_FILE="${HOME}/.shipwright/autonomous-state.json"
 
@@ -581,6 +584,7 @@ record_finding_pending() {
     local issue_num="$1"
     local finding_title="$2"
     ensure_state_dir
+    # shellcheck disable=SC2034
     local state_file="${STATE_DIR}/state.json"
     local pending_file="${STATE_DIR}/pending_findings.jsonl"
     [[ ! -f "$pending_file" ]] && touch "$pending_file"

package/scripts/sw-changelog.sh

@@ -7,7 +7,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,6 +30,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -109,6 +111,7 @@ parse_commits() {
     docs_changes=""
     chores=""
     local contributors=""
+    # shellcheck disable=SC2034
     local pr_links=""
 
     while IFS='|' read -r hash author email date subject body; do

package/scripts/sw-checkpoint.sh

@@ -8,7 +8,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -30,6 +30,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"

package/scripts/sw-ci.sh

@@ -6,8 +6,9 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck disable=SC2034
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -29,6 +30,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -77,6 +79,7 @@ jobs:
         stage_config=$(jq ".stages[] | select(.id==\"$stage_id\")" "$pipeline_config" 2>/dev/null || echo "{}")
 
         local gate
+        # shellcheck disable=SC2034
         gate=$(jq -r '.gate // "auto"' <<< "$stage_config")
 
         yaml_content+="  ${stage_id}:
@@ -301,6 +304,7 @@ cmd_secrets() {
             info "Checking secret availability in GitHub"
 
             local repo="${2:-.}"
+            # shellcheck disable=SC2034
             local owner org_name
 
             # Parse owner from git remote

package/scripts/sw-cleanup.sh

@@ -5,38 +5,16 @@
 # ║  Default: dry-run (shows what would be cleaned).                         ║
 # ║  Use --force to actually kill sessions and remove files.                 ║
 # ╚═══════════════════════════════════════════════════════════════════════════╝
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 set -euo pipefail
-trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=lib/bootstrap.sh
+source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/bootstrap.sh"
 
-# Canonical helpers (colors, output, events)
-# shellcheck source=lib/helpers.sh
-[[ -f "$SCRIPT_DIR/lib/helpers.sh" ]] && source "$SCRIPT_DIR/lib/helpers.sh"
-# shellcheck source=lib/compat.sh
-[[ -f "$SCRIPT_DIR/lib/compat.sh" ]] && source "$SCRIPT_DIR/lib/compat.sh"
 [[ -f "$SCRIPT_DIR/lib/config.sh" ]] && source "$SCRIPT_DIR/lib/config.sh"
 
 PROJECT_ROOT="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"
-
-# Fallbacks when helpers not loaded (e.g. test env with overridden SCRIPT_DIR)
-[[ "$(type -t info 2>/dev/null)" == "function" ]]    || info()    { echo -e "\033[38;2;0;212;255m\033[1m▸\033[0m $*"; }
-[[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
-[[ "$(type -t warn 2>/dev/null)" == "function" ]]    || warn()    { echo -e "\033[38;2;250;204;21m\033[1m⚠\033[0m $*"; }
-[[ "$(type -t error 2>/dev/null)" == "function" ]]   || error()   { echo -e "\033[38;2;248;113;113m\033[1m✗\033[0m $*" >&2; }
-if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
-  now_iso()   { date -u +"%Y-%m-%dT%H:%M:%SZ"; }
-  now_epoch() { date +%s; }
-fi
-if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
-  emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
-    while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
-  }
-fi
 # ─── Parse Args ──────────────────────────────────────────────────────────────
 
 FORCE=false

package/scripts/sw-code-review.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -431,7 +432,8 @@ review_changes() {
 
     mkdir -p "${REPO_DIR}/.claude/pipeline-artifacts"
 
-    local review_output="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"scope\":\"$review_scope\",\"findings\":{}}"
+    local review_output
+    review_output="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"scope\":\"$review_scope\",\"findings\":{}}"
     local total_issues=0
 
     # Get changed files (Bash 3.2 compatible — no mapfile)
@@ -514,9 +516,12 @@ review_changes() {
 scan_codebase() {
     info "Running full codebase quality scan..."
 
-    local scan_output="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"files\":[]}"
+    local scan_output
+    # shellcheck disable=SC2034
+    scan_output="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"files\":[]}"
     local total_issues=0
 
+    # shellcheck disable=SC2178,SC2128
     find "$REPO_DIR/scripts" -name "*.sh" -type f 2>/dev/null | while read -r file; do
         local file_rel="${file#$REPO_DIR/}"
         local smells=0
@@ -547,7 +552,8 @@ scan_codebase() {
 complexity_report() {
     info "Analyzing code complexity metrics..."
 
-    local complexity_data="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"files\":[]}"
+    local complexity_data
+    complexity_data="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"files\":[]}"
 
     find "$REPO_DIR/scripts" -name "*.sh" -type f 2>/dev/null | while read -r file; do
         local file_metrics

package/scripts/sw-connect.sh

@@ -8,7 +8,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -33,6 +33,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"

package/scripts/sw-context.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="${SHIPWRIGHT_REPO_DIR:-$(cd "$SCRIPT_DIR/.." && pwd)}"
 
@@ -387,6 +387,7 @@ gather_context() {
 
     local tmp_file
     tmp_file=$(mktemp "${TMPDIR:-/tmp}/sw-context-bundle.XXXXXX")
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" RETURN
 
     # Write bundle header

package/scripts/sw-cost.sh

@@ -6,8 +6,9 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck disable=SC2034
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -29,6 +30,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -150,10 +152,10 @@ cost_record() {
     # Always write to JSON (dual-write period)
     (
         if command -v flock >/dev/null 2>&1; then
-            flock -w 10 200 2>/dev/null || { warn "Cost lock timeout"; }
+            flock -w 10 200 2>/dev/null || { warn "Cost lock timeout — proceeding without lock"; }
         fi
         local tmp_file
-        tmp_file=$(mktemp "${COST_FILE}.tmp.XXXXXX")
+        tmp_file=$(mktemp "${COST_FILE}.tmp.XXXXXX") || { error "mktemp failed for cost record"; exit 1; }
         if ! jq --argjson input "$input_tokens" \
            --argjson output "$output_tokens" \
            --arg model "$model" \
@@ -611,6 +613,49 @@ cost_dashboard() {
 
     if [[ "$entry_count" -eq 0 ]]; then
         warn "No cost entries in the last ${period_days} day(s)."
+        # Still show context efficiency data if available
+        local events_file="${HOME}/.shipwright/events.jsonl"
+        if [[ -f "$events_file" ]]; then
+            local ctx_events
+            ctx_events=$(grep '"type":"loop.context_efficiency"' "$events_file" 2>/dev/null | tail -200 || true)
+            local ctx_count
+            ctx_count=$(echo "$ctx_events" | grep -c '"loop.context_efficiency"' 2>/dev/null || echo "0")
+            ctx_count="${ctx_count:-0}"
+            if [[ "$ctx_count" -gt 0 ]]; then
+                local avg_utilization avg_trim_ratio total_raw total_trimmed trim_count
+                eval "$(echo "$ctx_events" | awk -F'"' '
+                    /"loop.context_efficiency"/ {
+                        for (i=1; i<=NF; i++) {
+                            if ($i == "budget_utilization") util = $(i+2)
+                            if ($i == "trim_ratio") ratio = $(i+2)
+                            if ($i == "raw_prompt_chars") raw = $(i+2)
+                            if ($i == "trimmed_prompt_chars") trimmed = $(i+2)
+                        }
+                        total_util += util; total_ratio += ratio
+                        total_raw += raw; total_trimmed += trimmed
+                        if (ratio + 0 > 0) trim_events++
+                        n++
+                    }
+                    END {
+                        if (n > 0) {
+                            printf "avg_utilization=%.1f\n", total_util / n
+                            printf "avg_trim_ratio=%.1f\n", total_ratio / n
+                        } else {
+                            printf "avg_utilization=0\navg_trim_ratio=0\n"
+                        }
+                        printf "total_raw=%d\ntotal_trimmed=%d\ntrim_count=%d\n", total_raw, total_trimmed, (trim_events+0)
+                    }
+                ')"
+                local total_discarded=$(( total_raw - total_trimmed ))
+                echo -e "${BOLD}  CONTEXT EFFICIENCY${RESET}"
+                echo -e "    Avg budget used     ${avg_utilization}%"
+                echo -e "    Avg trim ratio      ${avg_trim_ratio}%"
+                echo -e "    Chars generated     $(printf "%'d" "$total_raw")"
+                echo -e "    Chars discarded     $(printf "%'d" "$total_discarded")"
+                echo -e "    Trim events         ${trim_count} / ${ctx_count} iterations"
+                echo ""
+            fi
+        fi
         return 0
     fi