shipwright-cli 3.2.0 → 3.3.0

package/scripts/sw-regression.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,7 +30,8 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
+    local payload
+    payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
@@ -46,6 +48,7 @@ format_duration() {
 }
 
 # ─── Structured Event Log ──────────────────────────────────────────────────
+# shellcheck disable=SC2034
 EVENTS_FILE="${HOME}/.shipwright/events.jsonl"
 
 # ─── Regression Storage ────────────────────────────────────────────────────
@@ -116,10 +119,10 @@ collect_script_metrics() {
     script_count=$(find "$REPO_DIR/scripts" -maxdepth 1 -name "*.sh" -type f 2>/dev/null | wc -l)
 
     # Count total lines in all scripts
-    total_lines=$(find "$REPO_DIR/scripts" -maxdepth 1 -name "*.sh" -type f 2>/dev/null -exec wc -l {} + | awk '{sum+=$1} END {print sum}')
+    total_lines=$(find "$REPO_DIR/scripts" -maxdepth 1 -name "*.sh" -type f -exec wc -l {} + 2>/dev/null | awk '{sum+=$1} END {print sum}')
 
     # Count functions (grep for function definitions)
-    function_count=$(find "$REPO_DIR/scripts" -maxdepth 1 -name "*.sh" -type f 2>/dev/null -exec grep -h "^[a-z_][a-z0-9_]*() {" {} + 2>/dev/null | wc -l)
+    function_count=$(find "$REPO_DIR/scripts" -maxdepth 1 -name "*.sh" -type f -exec grep -h "^[a-z_][a-z0-9_]*() {" {} + 2>/dev/null | wc -l)
 
     # Check for syntax errors
     while IFS= read -r script; do
@@ -138,17 +141,17 @@ collect_script_metrics() {
 collect_all_metrics() {
     local test_data
     test_data=$(collect_test_metrics)
-    local test_count=$(echo "$test_data" | sed -n '1p')
-    local pass_count=$(echo "$test_data" | sed -n '2p')
-    local fail_count=$(echo "$test_data" | sed -n '3p')
-    local pass_rate=$(echo "$test_data" | sed -n '4p')
+    local test_count; test_count=$(echo "$test_data" | sed -n '1p')
+    local pass_count; pass_count=$(echo "$test_data" | sed -n '2p')
+    local fail_count; fail_count=$(echo "$test_data" | sed -n '3p')
+    local pass_rate; pass_rate=$(echo "$test_data" | sed -n '4p')
 
     local script_data
     script_data=$(collect_script_metrics)
-    local script_count=$(echo "$script_data" | sed -n '1p')
-    local total_lines=$(echo "$script_data" | sed -n '2p')
-    local function_count=$(echo "$script_data" | sed -n '3p')
-    local syntax_errors=$(echo "$script_data" | sed -n '4p')
+    local script_count; script_count=$(echo "$script_data" | sed -n '1p')
+    local total_lines; total_lines=$(echo "$script_data" | sed -n '2p')
+    local function_count; function_count=$(echo "$script_data" | sed -n '3p')
+    local syntax_errors; syntax_errors=$(echo "$script_data" | sed -n '4p')
 
     cat <<METRICS
 {
@@ -180,6 +183,7 @@ cmd_baseline() {
     local timestamp
     timestamp=$(echo "$metrics" | jq -r '.timestamp')
     local epoch
+    # shellcheck disable=SC2034
     epoch=$(echo "$metrics" | jq -r '.epoch')
 
     # Create timestamped baseline file
@@ -188,6 +192,7 @@ cmd_baseline() {
 
     local tmp_file
     tmp_file=$(mktemp "${baseline_file}.tmp.XXXXXX")
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" RETURN
 
     echo "$metrics" > "$tmp_file"
@@ -260,6 +265,7 @@ cmd_check() {
         local name="$1"
         local baseline_val="$2"
         local current_val="$3"
+        # shellcheck disable=SC2034
         local threshold_key="$4"
         local threshold_val="$5"
         local direction="${6:-decrease}"  # decrease or increase
@@ -271,6 +277,7 @@ cmd_check() {
             return
         fi
 
+        # shellcheck disable=SC2034
         local diff
         local pct_diff=0
         if [[ "$baseline_val_num" != "0" ]]; then

package/scripts/sw-release-manager.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -27,6 +28,7 @@ if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
   now_epoch() { date +%s; }
 fi
 # ─── Structured Event Log ──────────────────────────────────────────────────
+# shellcheck disable=SC2034
 EVENTS_FILE="${HOME}/.shipwright/events.jsonl"
 
 # ─── Release State Storage ─────────────────────────────────────────────────

package/scripts/sw-release.sh

@@ -7,7 +7,8 @@ set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 trap 'rm -f "${tmp_file:-}" "${tmp_changelog:-}"' EXIT
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -31,6 +32,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -338,6 +340,7 @@ update_version_in_files() {
             # This is shell-safe: VERSION="1.11.0" → VERSION="1.12.0"
             local tmp_file
             tmp_file=$(mktemp)
+            # shellcheck disable=SC2064
             trap "rm -f '$tmp_file'" RETURN
             sed 's/^VERSION="[^"]*"$/VERSION="'"$version_num"'"/' "$file" > "$tmp_file"
             mv "$tmp_file" "$file"

package/scripts/sw-remote.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,6 +29,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -496,6 +497,7 @@ HEALTHEOF
         [[ ! "$hb_val" =~ ^[0-9]+$ ]] && hb_val=0
         [[ ! "$active_val" =~ ^[0-9]+$ ]] && active_val=0
         heartbeat_count="$hb_val"
+        # shellcheck disable=SC2034
         active_workers="$active_val"
 
         if [[ "$daemon_pid" == "error" ]]; then

package/scripts/sw-replay.sh

@@ -6,8 +6,10 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck disable=SC2034
 EVENTS_FILE="${HOME}/.shipwright/events.jsonl"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -32,6 +34,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -89,6 +92,7 @@ cmd_list() {
     echo ""
 
     # Extract unique pipeline runs, sorted by start time
+    # shellcheck disable=SC2034
     echo "$events_json" | jq -r '.[] | select(.type == "pipeline.started") | [.ts, .issue, .pipeline, .model, .goal] | @tsv' 2>/dev/null | \
     sort -r | \
     while IFS=$'\t' read -r ts issue pipeline model goal; do
@@ -444,11 +448,13 @@ cmd_compare() {
 
     # Extract details
     local goal1 type1 model1
+    # shellcheck disable=SC2034
     goal1=$(echo "$run1" | cut -f1)
     type1=$(echo "$run1" | cut -f2)
     model1=$(echo "$run1" | cut -f3)
 
     local goal2 type2 model2
+    # shellcheck disable=SC2034
     goal2=$(echo "$run2" | cut -f1)
     type2=$(echo "$run2" | cut -f2)
     model2=$(echo "$run2" | cut -f3)

package/scripts/sw-retro.sh

@@ -6,11 +6,13 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
 _COMPAT="$SCRIPT_DIR/lib/compat.sh"
+# shellcheck disable=SC1090
 [[ -f "$_COMPAT" ]] && source "$_COMPAT"
 
 # Canonical helpers (colors, output, events)
@@ -356,6 +358,7 @@ generate_retro_report() {
     } >> "$report_file"
 
     # Capture full analysis to JSON
+    # shellcheck disable=SC2046
     jq -n \
         --argjson analysis "$analysis_json" \
         --argjson agents "$agent_json" \
@@ -582,6 +585,155 @@ cmd_history() {
     done
 }
 
+# ─── Negative-Critical Retrospective ───────────────────────────────────────
+# Analyze pipelines for silent failures and quality gate skipping
+cmd_negative_audit() {
+    local from_date="${1:-}"
+    local to_date="${2:-}"
+
+    if [[ -z "$from_date" ]]; then
+        to_date=$(date -u +"%Y-%m-%d")
+        from_date=$(date_days_ago 7 2>/dev/null || python3 -c "from datetime import datetime, timedelta; print((datetime.utcnow() - timedelta(days=7)).strftime('%Y-%m-%d'))")
+    elif [[ -z "$to_date" ]]; then
+        to_date=$(date -u +"%Y-%m-%d")
+    fi
+
+    info "Negative Audit for ${from_date} to ${to_date}"
+    echo ""
+
+    if ! command -v jq >/dev/null 2>&1; then
+        error "jq required for negative audit"
+        return 1
+    fi
+
+    local from_epoch to_epoch
+    from_epoch=$(date_to_epoch "${from_date}T00:00:00Z")
+    to_epoch=$(date_to_epoch "${to_date}T23:59:59Z")
+
+    local findings='{"issues":[]}'
+    local issue_count=0
+
+    # Check for empty artifacts (silent stage failures)
+    echo ""
+    echo -e "${BOLD}1. Empty Artifacts Detection${RESET}"
+    local empty_count=0
+    if [[ -d ".claude/pipeline-artifacts" ]]; then
+        while IFS= read -r artifact_file; do
+            if [[ -f "$artifact_file" && ! -s "$artifact_file" ]]; then
+                local basename
+                basename=$(basename "$artifact_file")
+                warn "Empty artifact: $basename"
+                findings=$(echo "$findings" | jq --arg msg "Empty artifact: $basename" '.issues += [{"type": "empty_artifact", "message": $msg}]')
+                empty_count=$((empty_count + 1))
+                issue_count=$((issue_count + 1))
+            fi
+        done < <(find ".claude/pipeline-artifacts" -type f 2>/dev/null)
+    fi
+    [[ $empty_count -eq 0 ]] && echo "  ✓ No empty artifacts found"
+
+    # Check for skipped quality gates
+    echo ""
+    echo -e "${BOLD}2. Skipped Quality Gates${RESET}"
+    local skipped_count=0
+    if [[ -f ".claude/pipeline-artifacts/compound-quality.log" ]]; then
+        local skip_lines
+        skip_lines=$(grep -c "skipped\|SKIP" ".claude/pipeline-artifacts/compound-quality.log" 2>/dev/null || echo "0")
+        if [[ "$skip_lines" -gt 0 ]]; then
+            warn "Found $skip_lines skipped quality checks"
+            findings=$(echo "$findings" | jq --arg msg "Skipped $skip_lines quality gates" '.issues += [{"type": "skipped_gates", "message": $msg}]')
+            skipped_count=$skip_lines
+            issue_count=$((issue_count + skipped_count))
+        fi
+    fi
+    [[ $skipped_count -eq 0 ]] && echo "  ✓ No skipped quality gates"
+
+    # Check cost vs predicted
+    echo ""
+    echo -e "${BOLD}3. Cost Prediction Accuracy${RESET}"
+    if [[ -f ".claude/intelligence-cache.json" ]]; then
+        local predicted_cost actual_cost
+        predicted_cost=$(jq -r '.cost_estimate // 0' ".claude/intelligence-cache.json" 2>/dev/null)
+        if [[ -f ".claude/pipeline-artifacts/pipeline-state.md" ]]; then
+            actual_cost=$(grep -oP "Cost: \K[0-9]+" ".claude/pipeline-artifacts/pipeline-state.md" | tail -1 || echo "0")
+            if [[ -n "$predicted_cost" && "$predicted_cost" != "0" ]]; then
+                local cost_delta
+                cost_delta=$((actual_cost - predicted_cost))
+                local percent_error
+                percent_error=$((cost_delta * 100 / predicted_cost))
+                if [[ $percent_error -gt 30 || $percent_error -lt -30 ]]; then
+                    warn "Cost prediction off by ${percent_error}% (predicted: $predicted_cost, actual: $actual_cost)"
+                    findings=$(echo "$findings" | jq --arg msg "Cost off by ${percent_error}%" '.issues += [{"type": "cost_prediction", "message": $msg}]')
+                    issue_count=$((issue_count + 1))
+                fi
+            fi
+        fi
+    fi
+    [[ $issue_count -lt 4 ]] && echo "  ✓ Cost predictions accurate"
+
+    # Check loop iteration limit exhaustion
+    echo ""
+    echo -e "${BOLD}4. Loop Convergence Status${RESET}"
+    if [[ -f ".claude/pipeline-artifacts/pipeline-state.md" ]]; then
+        local loop_iter loop_limit
+        loop_iter=$(grep -oP "Iteration: \K[0-9]+" ".claude/pipeline-artifacts/pipeline-state.md" | tail -1 || echo "0")
+        loop_limit=$(grep -oP "Limit: \K[0-9]+" ".claude/pipeline-artifacts/pipeline-state.md" | tail -1 || echo "20")
+        if [[ "$loop_iter" -ge "$loop_limit" ]]; then
+            warn "Loop exhausted iterations ($loop_iter/$loop_limit)"
+            findings=$(echo "$findings" | jq --arg msg "Loop iteration limit exhausted: $loop_iter/$loop_limit" '.issues += [{"type": "loop_exhaustion", "message": $msg}]')
+            issue_count=$((issue_count + 1))
+        fi
+    fi
+    [[ $issue_count -lt 5 ]] && echo "  ✓ Loop convergence normal"
+
+    # Check for || true errors
+    echo ""
+    echo -e "${BOLD}5. Unsafe Error Suppression${RESET}"
+    if [[ -f ".claude/pipeline-artifacts/error-log.jsonl" ]]; then
+        local true_errors
+        true_errors=$(grep -c "|| true" ".claude/pipeline-artifacts/error-log.jsonl" 2>/dev/null || echo "0")
+        if [[ "$true_errors" -gt 0 ]]; then
+            warn "Found $true_errors errors suppressed with || true"
+            findings=$(echo "$findings" | jq --arg msg "Found $true_errors unsuppressed || true errors" '.issues += [{"type": "error_suppression", "message": $msg}]')
+            issue_count=$((issue_count + 1))
+        fi
+    fi
+    [[ $true_errors -eq 0 ]] && echo "  ✓ No unsafe error suppression"
+
+    # Summary
+    echo ""
+    echo -e "${PURPLE}${BOLD}━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━${RESET}"
+    echo ""
+
+    if [[ $issue_count -eq 0 ]]; then
+        success "Negative audit passed: no critical issues detected"
+    else
+        warn "Negative audit found $issue_count issue(s)"
+        echo "$findings" | jq '.issues[] | "\(.type): \(.message)"' -r
+    fi
+
+    # Store in memory as retrospective pattern
+    if type memory_capture_pattern >/dev/null 2>&1; then
+        local pattern_data
+        pattern_data=$(echo "$findings" | jq -n \
+            --argjson findings "$(echo "$findings" | jq '.issues | length')" \
+            --arg from_date "$from_date" \
+            --arg to_date "$to_date" \
+            '{
+                type: "negative_audit",
+                date_range: ($from_date + " to " + $to_date),
+                issues_found: $findings
+            }')
+        memory_capture_pattern "negative_audit" "$pattern_data" 2>/dev/null || true
+    fi
+
+    emit_event "retro.negative_audit" \
+        "from_date=$from_date" \
+        "to_date=$to_date" \
+        "issues=$issue_count"
+
+    echo ""
+}
+
 cmd_help() {
     cat << 'EOF'
 Usage: shipwright retro <subcommand> [options]
@@ -595,6 +747,7 @@ Subcommands:
   compare DATE1 DATE2             Compare two sprint periods
   history                         Show past retrospective reports
   quality                         Show quality index trend (longitudinal)
+  negative [--from DATE] [--to]   Negative audit: detect silent failures, skipped gates
   help                            Show this help message
 
 Options:
@@ -608,6 +761,7 @@ Examples:
   shipwright retro trends
   shipwright retro agents
   shipwright retro compare 2025-02-01 2025-01-25
+  shipwright retro negative                         # Last 7 days audit
 
 EOF
 }
@@ -651,6 +805,9 @@ if [[ "${BASH_SOURCE[0]}" == "$0" ]]; then
                 exit 1
             fi
             ;;
+        negative)
+            cmd_negative_audit "$@"
+            ;;
         help|--help|-h)
             cmd_help
             ;;

package/scripts/sw-review-rerun.sh

@@ -7,7 +7,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -22,6 +23,7 @@ REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"

package/scripts/sw-scale.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Dependency check ─────────────────────────────────────────────────────────
@@ -34,7 +35,8 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
+    local payload
+    payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
@@ -54,6 +56,7 @@ init_rules() {
     if [[ ! -f "$SCALE_RULES_FILE" ]]; then
         local tmp_file
         tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
         trap "rm -f '$tmp_file'" RETURN
         cat > "$tmp_file" << 'JSON'
 {
@@ -96,6 +99,7 @@ in_cooldown() {
 update_scale_state() {
     local tmp_file
     tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" RETURN
 
     if [[ -f "$SCALE_STATE_FILE" ]]; then
@@ -194,7 +198,8 @@ cmd_up() {
     fi
 
     for i in $(seq 1 "$count"); do
-        local agent_name="sw-agent-${role}-$(date +%s)-${i}"
+        local agent_name
+        agent_name="sw-agent-${role}-$(date +%s)-${i}"
         local session_name="shipwright-${agent_name}"
 
         # Spawn a real agent in a tmux session
@@ -231,6 +236,7 @@ cmd_down() {
     # Backward compat: "down agent-42" -> treat as session/agent identifier
     if [[ -n "$count" ]] && [[ "$count" != *[0-9]* ]] || [[ "$count" == agent-* ]]; then
         # Specific agent/session id
+        # shellcheck disable=SC2034
         local session_pattern="*${count}*"
         local sessions
         sessions=$(tmux list-sessions -F '#{session_name}' 2>/dev/null | grep -E "shipwright|swarm" | grep -i "$count" || true)
@@ -320,6 +326,7 @@ cmd_rules() {
 
             local tmp_file
             tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
             trap "rm -f '$tmp_file'" RETURN
 
             jq --arg key "$key" --arg value "$value" \

package/scripts/sw-security-audit.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -28,6 +28,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -118,8 +119,11 @@ scan_licenses() {
     local has_npm=false has_pip=false has_go=false has_cargo=false
 
     [[ -f "$REPO_DIR/package.json" ]] && has_npm=true
+    # shellcheck disable=SC2034
     [[ -f "$REPO_DIR/requirements.txt" || -f "$REPO_DIR/setup.py" ]] && has_pip=true
+    # shellcheck disable=SC2034
     [[ -f "$REPO_DIR/go.mod" ]] && has_go=true
+    # shellcheck disable=SC2034
     [[ -f "$REPO_DIR/Cargo.toml" ]] && has_cargo=true
 
     # Check npm licenses
@@ -202,6 +206,7 @@ generate_sbom() {
     # Add npm packages
     if [[ -f "$REPO_DIR/package.json" ]] && command -v npm >/dev/null 2>&1; then
         local npm_list
+        # shellcheck disable=SC2034
         npm_list=$(npm list --json 2>/dev/null || echo '{"dependencies":{}}')
         while IFS='=' read -r name version; do
             [[ -z "$name" || -z "$version" ]] && continue

package/scripts/sw-self-optimize.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+# shellcheck disable=SC2034,SC2064  # config vars used by sourced scripts; traps expand at definition time
 # ╔═══════════════════════════════════════════════════════════════════════════╗
 # ║  shipwright self-optimize — Learning & Self-Tuning System               ║
 # ║  Outcome analysis · Template tuning · Model routing · Memory evolution  ║
@@ -6,7 +7,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,7 +30,8 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
+    local payload
+    payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
@@ -1389,7 +1391,8 @@ optimize_track_quality_index() {
     local quality_index
     quality_index=$(awk "BEGIN{printf \"%.0f\", ($success_rate * 0.4) + ($efficiency * 0.3) + ($avg_quality * 0.3)}" 2>/dev/null || echo "0")
 
-    local entry="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"window\":$window,\"total\":$total,\"success_rate\":$success_rate,\"avg_iterations\":$avg_iterations,\"avg_quality\":$avg_quality,\"efficiency\":$efficiency,\"quality_index\":$quality_index}"
+    local entry
+    entry="{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"window\":$window,\"total\":$total,\"success_rate\":$success_rate,\"avg_iterations\":$avg_iterations,\"avg_quality\":$avg_quality,\"efficiency\":$efficiency,\"quality_index\":$quality_index}"
     echo "$entry" >> "$quality_file"
 
     # Detect trend

package/scripts/sw-session.sh

@@ -8,7 +8,8 @@
 # ║  Supports --template to scaffold from a team template and --terminal    ║
 # ║  to select a terminal adapter (tmux, iterm2, wezterm).                  ║
 # ╚═══════════════════════════════════════════════════════════════════════════╝
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
@@ -33,6 +34,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -206,8 +208,12 @@ if [[ -n "$TEMPLATE_NAME" ]]; then
                     case "$key" in
                         description)       TEMPLATE_DESC="$value" ;;
                         layout)            TEMPLATE_LAYOUT="$value" ;;
-                        layout_style)      TEMPLATE_LAYOUT_STYLE="$value" ;;
-                        main_pane_percent) TEMPLATE_MAIN_PANE_PERCENT="$value" ;;
+                        layout_style)
+                            # shellcheck disable=SC2034
+                            TEMPLATE_LAYOUT_STYLE="$value" ;;
+                        main_pane_percent)
+                            # shellcheck disable=SC2034
+                            TEMPLATE_MAIN_PANE_PERCENT="$value" ;;
                     esac
                     ;;
                 AGENT) [[ -n "$key" ]] && TEMPLATE_AGENTS+=("$key") ;;

package/scripts/sw-setup.sh

@@ -10,9 +10,10 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck disable=SC2034
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -34,6 +35,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"