shipwright-cli 3.2.0 → 3.3.0

package/scripts/sw-pm.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Cross-platform compatibility ──────────────────────────────────────────
@@ -26,18 +26,20 @@ if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
 fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    local event_type="$1"; shift; mkdir -p "${PM_STATE_DIR:=${HOME}/.shipwright}"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
+    echo "${payload}}" >> "${PM_STATE_DIR:=${HOME}/.shipwright}/events.jsonl"
   }
 fi
 # ─── PM History Storage ──────────────────────────────────────────────────────
-PM_HISTORY="${HOME}/.shipwright/pm-history.json"
+PM_STATE_DIR="${PM_STATE_DIR:-${HOME}/.shipwright}"
+PM_HISTORY="${PM_STATE_DIR}/pm-history.json"
 
 # ─── Ensure PM history file exists ───────────────────────────────────────────
 ensure_pm_history() {
-    mkdir -p "${HOME}/.shipwright"
+    mkdir -p "${PM_STATE_DIR}"
     if [[ ! -f "$PM_HISTORY" ]]; then
         echo '{"decisions":[],"outcomes":[]}' > "$PM_HISTORY"
     fi
@@ -495,6 +497,7 @@ cmd_recommend() {
 
     # Combine into comprehensive recommendation
     local recommendation
+    # shellcheck disable=SC2046
     recommendation=$(jq -n \
         --argjson analysis "$analysis" \
         --argjson team "$team_rec" \
@@ -513,6 +516,7 @@ cmd_recommend() {
         ensure_pm_history
         local tmp_hist
         tmp_hist=$(mktemp)
+        # shellcheck disable=SC2064
         trap "rm -f '$tmp_hist'" RETURN
         jq --argjson rec "$recommendation" '.decisions += [$rec]' "$PM_HISTORY" > "$tmp_hist" && mv "$tmp_hist" "$PM_HISTORY"
         emit_event "pm.recommend" "issue=${issue_num}"
@@ -541,6 +545,7 @@ cmd_recommend() {
     ensure_pm_history
     local tmp_hist
     tmp_hist=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_hist'" RETURN
     jq --argjson rec "$recommendation" '.decisions += [$rec]' "$PM_HISTORY" > "$tmp_hist" && mv "$tmp_hist" "$PM_HISTORY"
 
@@ -605,6 +610,7 @@ cmd_learn() {
     # Save to history
     local tmp_hist
     tmp_hist=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_hist'" RETURN
     jq --argjson outcome "$outcome_record" '.outcomes += [$outcome]' "$PM_HISTORY" > "$tmp_hist" && mv "$tmp_hist" "$PM_HISTORY"
 
@@ -630,6 +636,7 @@ cmd_history() {
             local total_decisions success_count fail_count
             total_decisions=$(jq '.outcomes | length' "$PM_HISTORY")
             success_count=$(jq '[.outcomes[] | select(.outcome == "success")] | length' "$PM_HISTORY")
+            # shellcheck disable=SC2034
             fail_count=$(jq '[.outcomes[] | select(.outcome == "failure")] | length' "$PM_HISTORY")
 
             if [[ "$total_decisions" -gt 0 ]]; then

package/scripts/sw-pr-lifecycle.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 

package/scripts/sw-predictive.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -31,12 +32,14 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
 fi
 # ─── Structured Event Log ──────────────────────────────────────────────────
+# shellcheck disable=SC2034
 EVENTS_FILE="${HOME}/.shipwright/events.jsonl"
 
 # ─── Intelligence Engine (optional) ────────────────────────────────────────
@@ -180,6 +183,7 @@ predictive_confirm_anomaly() {
     # Find the most recent unconfirmed anomaly for this stage+metric
     local tmp_file
     tmp_file=$(mktemp "${TMPDIR:-/tmp}/sw-anomaly-confirm.XXXXXX")
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" RETURN
     local found=false
 
@@ -276,6 +280,7 @@ _predictive_update_alarm_rates() {
     # Atomic write
     local tmp_file
     tmp_file=$(mktemp "${TMPDIR:-/tmp}/sw-anomaly-thresh.XXXXXX")
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" RETURN
     jq --arg m "$metric_name" \
        --argjson crit "$new_critical" \
@@ -757,6 +762,7 @@ predict_update_baseline() {
     # Atomic write
     local tmp_file
     tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" RETURN
     jq --arg key "$key" \
        --argjson val "$new_value" \

package/scripts/sw-prep.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # ─── Handle subcommands ───────────────────────────────────────────────────────
@@ -33,7 +33,8 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
+    local payload
+    payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
@@ -43,6 +44,7 @@ FORCE=false
 CHECK_ONLY=false
 UPDATE_MODE=false
 WITH_CLAUDE=false
+INTERACTIVE=false
 PROJECT_ROOT="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"
 
 # Detection results
@@ -99,6 +101,7 @@ show_help() {
     echo -e "  ${CYAN}--force${RESET}        Overwrite existing files"
     echo -e "  ${CYAN}--check${RESET}        Audit existing prep (dry run)"
     echo -e "  ${CYAN}--update${RESET}       Refresh auto-generated sections only"
+    echo -e "  ${CYAN}--interactive${RESET}  Interactive quality profile dialogue"
     echo -e "  ${CYAN}--with-claude${RESET}  Deep analysis using Claude Code (slower, richer)"
     echo -e "  ${CYAN}--help, -h${RESET}     Show this help message"
     echo ""
@@ -129,6 +132,7 @@ for arg in "$@"; do
         --force)       FORCE=true ;;
         --check)       CHECK_ONLY=true ;;
         --update)      UPDATE_MODE=true ;;
+        --interactive) INTERACTIVE=true ;;
         --with-claude) WITH_CLAUDE=true ;;
         --help|-h)     show_help; exit 0 ;;
         *)
@@ -459,6 +463,7 @@ prep_scan_structure() {
     for d in docs doc documentation wiki; do
         [[ -d "$root/$d" ]] && ddirs+=("$d")
     done
+    # shellcheck disable=SC2034
     DOC_DIRS="${ddirs[*]:-}"
 
     # Config files
@@ -499,6 +504,7 @@ prep_scan_structure() {
         -not -path "*/node_modules/*" -not -path "*/.git/*" 2>/dev/null | wc -l | tr -d ' ')
 
     # Total lines (approximation from source files)
+    # shellcheck disable=SC2227,SC2261
     TOTAL_LINES=$(find "$root" \( -name "*.ts" -o -name "*.tsx" -o -name "*.js" -o -name "*.jsx" \
         -o -name "*.py" -o -name "*.rb" -o -name "*.go" -o -name "*.rs" -o -name "*.java" \) \
         -not -path "*/node_modules/*" -not -path "*/.git/*" -not -path "*/vendor/*" \
@@ -572,6 +578,7 @@ prep_extract_patterns() {
 
     # ── Middleware ──
     if grep -rq "app\.use(" "$root/src" "$root/app" "$root/lib" 2>/dev/null; then
+        # shellcheck disable=SC2034
         HAS_MIDDLEWARE=true
     fi
 
@@ -767,8 +774,11 @@ ${style_samples}"
         DB_PATTERNS="$smart_val"
     fi
 
+    # shellcheck disable=SC2034
     SEMICOLONS=$(echo "$analysis" | grep "^SEMICOLONS:" | sed 's/^SEMICOLONS:[[:space:]]*//' | head -1)
+    # shellcheck disable=SC2034
     QUOTE_STYLE=$(echo "$analysis" | grep "^QUOTE_STYLE:" | sed 's/^QUOTE_STYLE:[[:space:]]*//' | head -1)
+    # shellcheck disable=SC2034
     INDENT_STYLE=$(echo "$analysis" | grep "^INDENT:" | sed 's/^INDENT:[[:space:]]*//' | head -1)
 
     success "Smart detection: ${ARCHITECTURE_PATTERN:-unknown} architecture${FRAMEWORK:+, ${FRAMEWORK}}"
@@ -818,6 +828,7 @@ prep_learn_patterns() {
     # Write patterns file atomically
     local tmp_patterns
     tmp_patterns=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_patterns'" RETURN
     jq -n \
         --arg ts "$(date -u +"%Y-%m-%dT%H:%M:%SZ")" \
@@ -947,6 +958,24 @@ prep_generate_settings() {
     success "Generated .claude/settings.json"
 }
 
+# ─── prep_generate_managed_mcp ────────────────────────────────────────────────
+
+prep_generate_managed_mcp() {
+    local filepath="$PROJECT_ROOT/.claude/managed-mcp.json"
+    if ! should_write "$filepath"; then return; fi
+
+    info "Generating .claude/managed-mcp.json..."
+
+    jq -n '{
+        "allowedMcpServers": ["*"],
+        "deniedMcpServers": [],
+        "note": "Configure MCP server access policies for pipeline agents"
+    }' > "$filepath"
+
+    track_file "$filepath"
+    success "Generated .claude/managed-mcp.json"
+}
+
 # ─── prep_generate_hooks ────────────────────────────────────────────────────
 
 prep_generate_hooks() {
@@ -1572,6 +1601,156 @@ prep_check() {
     echo ""
 }
 
+# ─── generate_quality_profile — Interactive quality profile dialogue ────────
+
+generate_quality_profile() {
+    local profile_path="$PROJECT_ROOT/.claude/quality-profile.json"
+
+    # Load quality-profile library
+    if [[ -f "$SCRIPT_DIR/lib/quality-profile.sh" ]]; then
+        source "$SCRIPT_DIR/lib/quality-profile.sh"
+    else
+        warn "quality-profile.sh library not found"
+        return 1
+    fi
+
+    info "Generating quality profile..."
+
+    # Start with inferred values
+    local inferred
+    inferred=$(qp_infer_from_repo)
+
+    # Generate base profile
+    local base_profile
+    base_profile=$(generate_default_profile)
+
+    # In interactive mode, ask refinement questions
+    if $INTERACTIVE; then
+        echo ""
+        echo -e "${CYAN}${BOLD}Quality Profile Setup${RESET}"
+        echo -e "${DIM}Answer these questions to calibrate quality standards:${RESET}"
+        echo ""
+
+        # Q1: Max PR size
+        local max_pr_lines
+        read -p "Max PR size in lines (default 500): " max_pr_lines
+        max_pr_lines="${max_pr_lines:-500}"
+
+        # Q2: Max files per PR
+        local max_files
+        read -p "Max files per PR (default 15): " max_files
+        max_files="${max_files:-15}"
+
+        # Q3: Test philosophy
+        echo ""
+        echo -e "${DIM}Test philosophy:${RESET}"
+        echo "  1. test_after (default)"
+        echo "  2. tdd"
+        echo "  3. coverage_target"
+        echo "  4. manual"
+        read -p "Choose [1-4]: " test_choice
+
+        local philosophy="test_after"
+        case "$test_choice" in
+            2) philosophy="tdd" ;;
+            3) philosophy="coverage_target" ;;
+            4) philosophy="manual" ;;
+        esac
+
+        # Q4: Architecture pattern
+        echo ""
+        echo -e "${DIM}Architecture pattern:${RESET}"
+        echo "  1. monolith (default)"
+        echo "  2. modular_monolith"
+        echo "  3. microservices"
+        echo "  4. serverless"
+        echo "  5. library"
+        read -p "Choose [1-5]: " arch_choice
+
+        local arch_pattern="monolith"
+        case "$arch_choice" in
+            2) arch_pattern="modular_monolith" ;;
+            3) arch_pattern="microservices" ;;
+            4) arch_pattern="serverless" ;;
+            5) arch_pattern="library" ;;
+        esac
+
+        # Q5: Never ship rules
+        echo ""
+        read -p "Critical rules to never ship (comma-separated, or press Enter to skip): " never_ship
+
+        # Q6: Focus areas for code review
+        echo ""
+        read -p "Focus areas for review (comma-separated, e.g., 'performance,security'): " focus_areas
+
+        # Q7: Deployment strategy
+        echo ""
+        echo -e "${DIM}Deployment strategy:${RESET}"
+        echo "  1. direct (default)"
+        echo "  2. preview_then_production"
+        echo "  3. staged_rollout"
+        read -p "Choose [1-3]: " deploy_choice
+
+        local deploy_strategy="direct"
+        case "$deploy_choice" in
+            2) deploy_strategy="preview_then_production" ;;
+            3) deploy_strategy="staged_rollout" ;;
+        esac
+
+        # Build the updated profile
+        local never_ship_array="[]"
+        if [[ -n "$never_ship" ]]; then
+            never_ship_array=$(echo "$never_ship" | jq -R 'split(",") | map(ltrimstr(" ") | rtrimstr(" "))')
+        fi
+
+        local focus_areas_array="[]"
+        if [[ -n "$focus_areas" ]]; then
+            focus_areas_array=$(echo "$focus_areas" | jq -R 'split(",") | map(ltrimstr(" ") | rtrimstr(" "))')
+        fi
+
+        # Merge updates into base profile
+        base_profile=$(echo "$base_profile" | jq \
+            --arg max_pr "$max_pr_lines" \
+            --arg max_f "$max_files" \
+            --arg phil "$philosophy" \
+            --arg arch "$arch_pattern" \
+            --arg deploy "$deploy_strategy" \
+            --argjson never_ship "$never_ship_array" \
+            --argjson focus "$focus_areas_array" \
+            '.quality.max_pr_lines = ($max_pr | tonumber) |
+             .quality.max_files_per_pr = ($max_f | tonumber) |
+             .quality.never_ship = $never_ship |
+             .testing.philosophy = $phil |
+             .architecture.pattern = $arch |
+             .deployment.strategy = $deploy |
+             .review.focus_areas = $focus'
+        )
+    else
+        # Non-interactive: apply inferred values
+        local test_cmd focus_areas arch_pattern
+        test_cmd=$(echo "$inferred" | jq -r '.test_cmd')
+        arch_pattern=$(echo "$inferred" | jq -r '.framework')
+
+        # Merge inferred test command and architecture
+        if [[ -n "$test_cmd" && "$test_cmd" != "null" && "$test_cmd" != "" ]]; then
+            base_profile=$(echo "$base_profile" | jq --arg cmd "$test_cmd" '.testing.test_cmd = $cmd')
+        fi
+        if [[ -n "$arch_pattern" && "$arch_pattern" != "null" && "$arch_pattern" != "" ]]; then
+            base_profile=$(echo "$base_profile" | jq --arg arch "$arch_pattern" '.architecture.pattern = $arch')
+        fi
+    fi
+
+    # Save the profile
+    if qp_save "$base_profile"; then
+        success "Quality profile saved to .claude/quality-profile.json"
+        track_file ".claude/quality-profile.json"
+        return 0
+    else
+        error "Failed to save quality profile"
+        return 1
+    fi
+}
+
 # ─── prep_report — Summary output ──────────────────────────────────────────
 
 prep_report() {
@@ -1627,6 +1806,7 @@ main() {
     # Generation
     prep_generate_claude_md
     prep_generate_settings
+    prep_generate_managed_mcp
     prep_generate_hooks
     prep_generate_agents
     prep_generate_architecture
@@ -1634,6 +1814,9 @@ main() {
     prep_generate_dod
     prep_generate_issue_templates
 
+    # Quality profile (auto or interactive)
+    generate_quality_profile
+
     # Deep analysis (optional)
     prep_with_claude
 

package/scripts/sw-ps.sh

@@ -5,32 +5,12 @@
 # ║  Displays a table of agents running in claude-* tmux windows with       ║
 # ║  PID, status, idle time, and pane references.                           ║
 # ╚═══════════════════════════════════════════════════════════════════════════╝
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 set -euo pipefail
-trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
-
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-
-# Canonical helpers (colors, output, events)
-# shellcheck source=lib/helpers.sh
-[[ -f "$SCRIPT_DIR/lib/helpers.sh" ]] && source "$SCRIPT_DIR/lib/helpers.sh"
-# Fallbacks when helpers not loaded (e.g. test env with overridden SCRIPT_DIR)
-[[ "$(type -t info 2>/dev/null)" == "function" ]]    || info()    { echo -e "\033[38;2;0;212;255m\033[1m▸\033[0m $*"; }
-[[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
-[[ "$(type -t warn 2>/dev/null)" == "function" ]]    || warn()    { echo -e "\033[38;2;250;204;21m\033[1m⚠\033[0m $*"; }
-[[ "$(type -t error 2>/dev/null)" == "function" ]]   || error()   { echo -e "\033[38;2;248;113;113m\033[1m✗\033[0m $*" >&2; }
-if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
-  now_iso()   { date -u +"%Y-%m-%dT%H:%M:%SZ"; }
-  now_epoch() { date +%s; }
-fi
-if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
-  emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
-    while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
-  }
-fi
+
+# shellcheck source=lib/bootstrap.sh
+source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/bootstrap.sh"
 # ─── Format idle time ───────────────────────────────────────────────────────
 format_idle() {
     local seconds="$1"

package/scripts/sw-public-dashboard.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -29,7 +30,8 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
+    local payload
+    payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
   }
@@ -79,11 +81,13 @@ sanitize_for_privacy() {
 gather_pipeline_state() {
     local privacy="${1:-stages_only}"
 
+    # shellcheck disable=SC2034
     local state_file="${REPO_DIR}/.claude/pipeline-state.md"
     local daemon_state="${HOME}/.shipwright/daemon-state.json"
     local pipeline_artifacts="${REPO_DIR}/.claude/pipeline-artifacts"
 
-    local pipeline_data='{
+    local pipeline_data
+    pipeline_data='{
         "status":"unknown",
         "stages":[],
         "agents":[],
@@ -140,6 +144,7 @@ generate_html() {
 
     # Escape JSON for embedding in HTML
     local json_escaped
+    # shellcheck disable=SC2034
     json_escaped=$(echo "$data_json" | sed 's/"/\\"/g' | tr '\n' ' ')
 
     cat <<'EOF'
@@ -418,6 +423,7 @@ cmd_export() {
     # Atomic write
     local tmp_file
     tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" EXIT
     echo "$html" > "$tmp_file"
     mv "$tmp_file" "$output_file"
@@ -453,6 +459,7 @@ cmd_share() {
     # Append to share links file (atomic)
     local tmp_file
     tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" EXIT
     jq ".links += [$link_entry]" "$SHARE_LINKS_FILE" > "$tmp_file"
     mv "$tmp_file" "$SHARE_LINKS_FILE"
@@ -480,6 +487,7 @@ cmd_revoke() {
 
     local tmp_file
     tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" EXIT
 
     if jq ".links |= map(select(.token != \"$token\"))" "$SHARE_LINKS_FILE" > "$tmp_file"; then
@@ -545,6 +553,7 @@ cmd_config() {
             [[ -z "$value" ]] && error "Value required for privacy" && return 1
             local tmp_file
             tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
             trap "rm -f '$tmp_file'" EXIT
             jq ".privacy = \"$value\"" "$SHARE_CONFIG_FILE" > "$tmp_file"
             mv "$tmp_file" "$SHARE_CONFIG_FILE"
@@ -554,6 +563,7 @@ cmd_config() {
             [[ -z "$value" ]] && error "Value required for expiry (hours)" && return 1
             local tmp_file
             tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
             trap "rm -f '$tmp_file'" EXIT
             jq ".expiry_hours = $value" "$SHARE_CONFIG_FILE" > "$tmp_file"
             mv "$tmp_file" "$SHARE_CONFIG_FILE"
@@ -563,6 +573,7 @@ cmd_config() {
             [[ -z "$value" ]] && error "Value required for domain" && return 1
             local tmp_file
             tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
             trap "rm -f '$tmp_file'" EXIT
             jq ".custom_domain = \"$value\"" "$SHARE_CONFIG_FILE" > "$tmp_file"
             mv "$tmp_file" "$SHARE_CONFIG_FILE"
@@ -642,6 +653,7 @@ cmd_cleanup() {
 
     local tmp_file
     tmp_file=$(mktemp)
+    # shellcheck disable=SC2064
     trap "rm -f '$tmp_file'" EXIT
 
     jq ".links |= map(select((.expires | fromdateiso8601) > $now_epoch_val))" "$SHARE_LINKS_FILE" > "$tmp_file"

package/scripts/sw-quality.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.2.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -30,6 +30,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"

package/scripts/sw-reaper.sh

@@ -11,32 +11,12 @@
 # ║    shipwright reaper --watch      Continuous loop (default: 5s)         ║
 # ║    shipwright reaper --dry-run    Preview what would be reaped          ║
 # ╚═══════════════════════════════════════════════════════════════════════════╝
-VERSION="3.2.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 set -euo pipefail
-trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
-
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-
-# Canonical helpers (colors, output, events)
-# shellcheck source=lib/helpers.sh
-[[ -f "$SCRIPT_DIR/lib/helpers.sh" ]] && source "$SCRIPT_DIR/lib/helpers.sh"
-# Fallbacks when helpers not loaded (e.g. test env with overridden SCRIPT_DIR)
-[[ "$(type -t info 2>/dev/null)" == "function" ]]    || info()    { echo -e "\033[38;2;0;212;255m\033[1m▸\033[0m $*"; }
-[[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
-[[ "$(type -t warn 2>/dev/null)" == "function" ]]    || warn()    { echo -e "\033[38;2;250;204;21m\033[1m⚠\033[0m $*"; }
-[[ "$(type -t error 2>/dev/null)" == "function" ]]   || error()   { echo -e "\033[38;2;248;113;113m\033[1m✗\033[0m $*" >&2; }
-if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
-  now_iso()   { date -u +"%Y-%m-%dT%H:%M:%SZ"; }
-  now_epoch() { date +%s; }
-fi
-if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
-  emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
-    while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
-  }
-fi
+
+# shellcheck source=lib/bootstrap.sh
+source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/bootstrap.sh"
 # ─── Defaults ──────────────────────────────────────────────────────────────
 WATCH=false
 DRY_RUN=false
@@ -193,6 +173,8 @@ scan_and_reap() {
     local skipped=0
     local scanned=0
 
+    # shellcheck disable=SC2034
+    # shellcheck disable=SC2034
     while IFS='|' read -r window_name pane_title pane_pid cmd pane_active pane_idle pane_dead pane_ref; do
         [[ -z "$window_name" ]] && continue
 
@@ -291,6 +273,7 @@ cleanup_team_dirs() {
                     cleaned=$((cleaned + 1))
                 }
                 if [[ -d "${tasks_dir}/${team_name}" ]]; then
+                    # shellcheck disable=SC2115
                     rm -rf "${tasks_dir}/${team_name}" && {
                         echo -e "  ${RED}✗${RESET} Removed task dir: ${BOLD}${team_name}/${RESET}"
                         log "CLEAN_TASKS team=${team_name}"