react-native-audio-browser 0.2.0-next.53 → 0.2.0-next.54

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (329) hide show
  1. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  2. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  3. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  5. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  6. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  7. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  8. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  9. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  10. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  11. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  12. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  13. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  15. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  16. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  17. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  18. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  19. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  20. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  21. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  22. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  23. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  24. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  25. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  26. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  27. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  28. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  29. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  30. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  31. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  32. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  33. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  34. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  35. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  36. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  37. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  38. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  39. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  40. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  41. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  42. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  43. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  45. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  46. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  50. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  51. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  52. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  53. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  54. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  55. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  56. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  58. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  59. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  60. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  61. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  63. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  64. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +28 -48
  66. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  67. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  68. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  71. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  78. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  80. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  81. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  82. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  84. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  85. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  86. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  90. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  91. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  92. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  93. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  94. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  96. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  97. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  98. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  99. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  100. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  102. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  103. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  104. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  105. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  106. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  107. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  108. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  109. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  110. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  111. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  112. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  113. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  114. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  115. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  116. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  121. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  122. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  123. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  124. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  125. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  126. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  127. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  128. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  129. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  130. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  131. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  132. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  133. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  134. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  135. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  136. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  137. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  138. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  139. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  143. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +2 -2
  144. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  145. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  146. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +5 -1
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  149. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  150. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  151. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  152. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  153. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  154. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  155. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +9 -10
  156. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +0 -1
  157. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  158. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  159. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  167. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  168. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  169. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  170. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  172. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  174. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  175. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  177. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  178. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  179. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  180. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  181. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  183. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  184. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  185. package/ios/AVPlayerEngine.swift +13 -21
  186. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  187. package/ios/Browser/BrowseGate.swift +7 -8
  188. package/ios/Browser/BrowserConfig.swift +19 -34
  189. package/ios/Browser/BrowserError.swift +0 -1
  190. package/ios/Browser/BrowserManager.swift +29 -75
  191. package/ios/Browser/BrowserPathHelper.swift +13 -93
  192. package/ios/Browser/FavoriteSet.swift +7 -10
  193. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  194. package/ios/Browser/JsonModels.swift +11 -51
  195. package/ios/Browser/NavigationErrorState.swift +3 -2
  196. package/ios/Browser/PageResolver.swift +13 -23
  197. package/ios/Browser/RequestLayer.swift +16 -20
  198. package/ios/Browser/RequestPipeline.swift +33 -43
  199. package/ios/Browser/SearchDrillIn.swift +7 -13
  200. package/ios/Browser/SectionScope.swift +14 -26
  201. package/ios/Browser/SimpleRouter.swift +8 -15
  202. package/ios/Browser/StyleResolver.swift +12 -29
  203. package/ios/Browser/TabBarEntries.swift +6 -11
  204. package/ios/Browser/TrackIdTemplate.swift +6 -14
  205. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  206. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  207. package/ios/CarPlay/CarPlayController.swift +4 -4
  208. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  209. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  210. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  211. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  212. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  213. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  214. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  215. package/ios/CarPlay/CarPlaySession.swift +13 -17
  216. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  217. package/ios/CarPlay/IntentHandlers.swift +3 -5
  218. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  219. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  220. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  221. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  222. package/ios/CarPlay/SectionPresentation.swift +18 -28
  223. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  224. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  225. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  226. package/ios/Extension/CxxVectorConformances.swift +4 -16
  227. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  228. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  229. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  230. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  231. package/ios/Extension/SearchParams+Query.swift +4 -4
  232. package/ios/Extension/Section+Copying.swift +3 -6
  233. package/ios/Extension/String+IcyCharset.swift +5 -5
  234. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  235. package/ios/Extension/Track+AVPlayer.swift +1 -2
  236. package/ios/Extension/Track+Copying.swift +2 -8
  237. package/ios/Extension/Track+Identity.swift +4 -9
  238. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  239. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  240. package/ios/Extension/Variant+Artwork.swift +8 -22
  241. package/ios/Http/HttpClient.swift +3 -3
  242. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  243. package/ios/HybridAudioBrowser+Options.swift +6 -9
  244. package/ios/HybridAudioBrowser+Player.swift +8 -16
  245. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  246. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  247. package/ios/HybridAudioBrowser.swift +54 -79
  248. package/ios/Model/NitroTypeStubs.swift +15 -22
  249. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  250. package/ios/Model/RemoteCommand.swift +2 -2
  251. package/ios/Model/TrackPlayerError.swift +9 -22
  252. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  253. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  254. package/ios/Observer/ItemObserver.swift +7 -5
  255. package/ios/Observer/PlayerObserver.swift +5 -5
  256. package/ios/PlaybackEvent.swift +2 -2
  257. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  258. package/ios/Player/AudioSessionController.swift +14 -15
  259. package/ios/Player/DeferredSeek.swift +2 -2
  260. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  261. package/ios/Player/ErrorStatus.swift +8 -7
  262. package/ios/Player/MediaLoader.swift +20 -24
  263. package/ios/Player/NowPlayingLines.swift +1 -4
  264. package/ios/Player/NowPlayingUpdater.swift +35 -61
  265. package/ios/Player/PersistedPlaybackState.swift +1 -2
  266. package/ios/Player/PlaybackFailure.swift +20 -24
  267. package/ios/Player/PlaybackPersistence.swift +5 -6
  268. package/ios/Player/PlaybackStateMachine.swift +8 -11
  269. package/ios/Player/PlaybackTimer.swift +8 -11
  270. package/ios/Player/Player.swift +6 -13
  271. package/ios/Player/PlayerEngine.swift +20 -20
  272. package/ios/Player/PlayerStatusTypes.swift +1 -2
  273. package/ios/Player/QueueManager.swift +23 -67
  274. package/ios/Player/RetryLoop.swift +39 -50
  275. package/ios/Player/ShuffleOrder.swift +17 -57
  276. package/ios/Player/SleepTimerManager.swift +13 -28
  277. package/ios/Player/VolumeFader.swift +16 -16
  278. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  279. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  280. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  281. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  282. package/ios/Tests/DeferredSeekTests.swift +1 -3
  283. package/ios/Tests/EmitterTests.swift +0 -1
  284. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  285. package/ios/Tests/FavoriteSetTests.swift +1 -0
  286. package/ios/Tests/GenerationMemoTests.swift +2 -2
  287. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  288. package/ios/Tests/JsonModelsTests.swift +5 -12
  289. package/ios/Tests/LRUCacheTests.swift +1 -5
  290. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  291. package/ios/Tests/MediaLoaderTests.swift +3 -12
  292. package/ios/Tests/ObserverTests.swift +3 -3
  293. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  294. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  295. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  296. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  297. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  298. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  299. package/ios/Tests/PlayerTests.swift +53 -88
  300. package/ios/Tests/PlayingStateTests.swift +0 -1
  301. package/ios/Tests/QueueManagerTests.swift +30 -80
  302. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  303. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  304. package/ios/Tests/RetryLoopTests.swift +12 -35
  305. package/ios/Tests/SearchDrillInTests.swift +4 -5
  306. package/ios/Tests/SectionPresentationTests.swift +3 -16
  307. package/ios/Tests/SectionScopeTests.swift +3 -6
  308. package/ios/Tests/SimpleRouterTests.swift +1 -5
  309. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  310. package/ios/Tests/StyleResolverTests.swift +4 -13
  311. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  312. package/ios/Tests/Support/TestTypes.swift +5 -15
  313. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  314. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  315. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  316. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  317. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  318. package/ios/Tests/TrackSelectorTests.swift +3 -15
  319. package/ios/TrackSelector.swift +13 -25
  320. package/ios/Util/ArtworkFreshness.swift +6 -6
  321. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  322. package/ios/Util/ConcurrentMap.swift +2 -2
  323. package/ios/Util/Emitter.swift +8 -13
  324. package/ios/Util/NetworkMonitor.swift +4 -6
  325. package/ios/Util/OutputPicker.swift +1 -1
  326. package/ios/Util/ReadyValue.swift +3 -2
  327. package/ios/Util/SFSymbolRenderer.swift +17 -30
  328. package/ios/Util/SVGProcessor.swift +5 -9
  329. package/package.json +1 -1
@@ -64,8 +64,8 @@ struct NextTests {
64
64
  #expect(q.currentIndex == 0)
65
65
  }
66
66
 
67
- /// The start track must be first in the shuffle order, not wherever the permutation put it —
68
- /// otherwise auto-advance ends the queue as soon as it is reached (#96).
67
+ /// The start track leads the shuffle order: left wherever the permutation put it, it could land
68
+ /// last, and auto-advance would end the queue as soon as it plays (#96).
69
69
  @Test func shuffle_startTrackLeadsTheOrder() {
70
70
  for start in 0 ..< 6 {
71
71
  let q = QueueManager()
@@ -79,8 +79,8 @@ struct NextTests {
79
79
  }
80
80
  }
81
81
 
82
- /// Same hazard on enabling shuffle mid-queue: the existing order has the current track wherever
83
- /// it landed, so without re-pinning, turning shuffle on can immediately report end-of-queue.
82
+ /// Enabling shuffle mid-queue pins the current track to the head too, or the queue could report
83
+ /// end-of-queue at once.
84
84
  @Test func shuffle_enablingMidQueueLeadsFromCurrent() {
85
85
  for start in 0 ..< 6 {
86
86
  let q = QueueManager()
@@ -95,8 +95,8 @@ struct NextTests {
95
95
  }
96
96
  }
97
97
 
98
- /// Re-pinning happens on enable only — flipping it off and on again must not renege on the
99
- /// order mid-listen, and a redundant `= true` must not reshuffle under the listener.
98
+ /// Only the off→on edge pins: a redundant enable, or disabling, must not reshuffle under the
99
+ /// listener.
100
100
  @Test func shuffle_redundantEnableKeepsTheOrder() {
101
101
  let q = QueueManager()
102
102
  q.setQueue(tracks("a", "b", "c", "d", "e", "f"))
@@ -110,9 +110,7 @@ struct NextTests {
110
110
  #expect(q.shuffleOrder.shuffled == order)
111
111
  }
112
112
 
113
- /// A queue reorder permutes positions, not identities, so it must leave the
114
- /// shuffled playback order alone. Re-inserting at a random shuffle position
115
- /// would silently reshuffle under the listener.
113
+ /// A move permutes positions, not identities, so the playback order of the tracks stays as it was.
116
114
  @Test func shuffle_moveKeepsThePlaybackOrder() {
117
115
  for target in 0 ..< 5 {
118
116
  let q = QueueManager()
@@ -126,15 +124,13 @@ struct NextTests {
126
124
  }
127
125
  }
128
126
 
129
- /// The same hazard as `shuffle_startTrackLeadsTheOrder`, reached by moving the
130
- /// *playing* track: a random re-insert can drop it last in the shuffle order,
131
- /// which reads as `isLastInPlaybackOrder` and ends the queue at the next track
132
- /// boundary with tracks still unplayed.
127
+ /// Moving the playing track must not drop it last in the shuffle order, which would end the queue
128
+ /// at the next track boundary with tracks unplayed.
133
129
  @Test func shuffle_movingCurrentTrackDoesNotEndTheQueue() {
134
130
  for target in 1 ..< 6 {
135
131
  let q = QueueManager()
136
132
  q.setQueue(tracks("a", "b", "c", "d", "e", "f"), initialIndex: 0)
137
- q.shuffleEnabled = true // pins "a" first in the order
133
+ q.shuffleEnabled = true
138
134
  #expect(!q.isLastInPlaybackOrder)
139
135
 
140
136
  _ = try? q.move(fromIndex: 0, toIndex: target)
@@ -164,11 +160,9 @@ struct NextTests {
164
160
  q.setQueue(tracks("a", "b", "c"))
165
161
  q.shuffleEnabled = true
166
162
  q.repeatMode = .off
167
- // Navigate to the end of the shuffle order
168
163
  for _ in 0 ..< 2 {
169
164
  _ = q.next()
170
165
  }
171
- // One more should wrap
172
166
  let result = q.next()
173
167
  #expect(result == .trackChanged)
174
168
  }
@@ -177,8 +171,6 @@ struct NextTests {
177
171
  let q = QueueManager()
178
172
  q.setQueue(tracks("a", "b", "c"), initialIndex: 2)
179
173
  q.repeatMode = .track
180
- // .track only triggers sameTrackReplay for single-track queues;
181
- // with multiple tracks it behaves like .off at the boundary.
182
174
  #expect(q.next() == .noChange)
183
175
  }
184
176
  }
@@ -215,19 +207,10 @@ struct PreviousTests {
215
207
  q.setQueue(tracks("a", "b", "c"))
216
208
  q.shuffleEnabled = true
217
209
  q.repeatMode = .off
218
- // Navigate to the beginning of the shuffle order
219
- // Find the first index in the shuffle order
220
- // Move to the first shuffle position by calling previous until we can't
221
- // Actually, the queue starts at index 0. The shuffle position of index 0
222
- // may or may not be position 0 in the shuffle order.
223
- // Navigate to the first position in shuffle order by calling previous
224
- // until we hit the boundary, then one more should wrap.
225
-
226
- // Navigate backwards until we reach the first in shuffle order
210
+
227
211
  while q.previousTracks.count > 0 {
228
212
  _ = q.previous()
229
213
  }
230
- // Now we're at the first in shuffle order — one more should wrap
231
214
  let result = q.previous()
232
215
  #expect(result == .trackChanged)
233
216
  }
@@ -248,8 +231,6 @@ struct PreviousTests {
248
231
  let q = QueueManager()
249
232
  q.setQueue(tracks("a", "b", "c"))
250
233
  q.repeatMode = .track
251
- // .track only triggers sameTrackReplay for single-track queues;
252
- // with multiple tracks it behaves like .off at the boundary.
253
234
  #expect(q.previous() == .noChange)
254
235
  }
255
236
  }
@@ -336,7 +317,7 @@ struct SetQueueTests {
336
317
  @Test func emptyArray_setsCurrentIndexToZero() {
337
318
  let q = QueueManager()
338
319
  q.setQueue([])
339
- // min(0, -1) = -1, max(0, -1) = 0 → currentIndex is 0 despite empty tracks
320
+ // max(0, min(0, -1)) clamps to 0, unlike the -1 that clear() and remove() leave.
340
321
  #expect(q.currentIndex == 0)
341
322
  #expect(q.currentTrack == nil)
342
323
  }
@@ -408,12 +389,8 @@ struct AddTests {
408
389
  #expect(q.tracks[3].id == "d")
409
390
  }
410
391
 
411
- /// Filling an empty queue must pin the start track to the head of the shuffle
412
- /// order, exactly as `setQueue` does — `insert(at:count:)` places new indices
413
- /// at random positions, so without the pin the start track can land last and
414
- /// the queue reports end-of-queue as soon as it finishes. `shuffleEnabled`'s
415
- /// didSet only re-pins on the off→on edge, so shuffle-already-on gets nothing
416
- /// from it.
392
+ /// Filling an empty queue pins the start track to the head of the shuffle order, as setQueue does;
393
+ /// shuffleEnabled pins only on its off→on edge, so with shuffle already on nothing else would.
417
394
  @Test func toEmptyQueue_withShuffleAlreadyOn_startTrackLeadsTheOrder() {
418
395
  for start in 0 ..< 6 {
419
396
  let q = QueueManager()
@@ -438,7 +415,7 @@ struct AddAtTests {
438
415
  q.setQueue(tracks("a", "b", "c"), initialIndex: 1)
439
416
  let changed = try q.addAt(tracks("x", "y"), at: 0).currentTrack
440
417
  #expect(changed == false)
441
- #expect(q.currentIndex == 3) // was 1, shifted by 2
418
+ #expect(q.currentIndex == 3)
442
419
  #expect(q.tracks.count == 5)
443
420
  }
444
421
 
@@ -458,7 +435,7 @@ struct AddAtTests {
458
435
  #expect(q.currentIndex == 0)
459
436
  }
460
437
 
461
- /// Same pinning requirement as `add()` into an empty queue — see its twin.
438
+ /// The same pin as add() into an empty queue.
462
439
  @Test func toEmptyQueue_withShuffleAlreadyOn_startTrackLeadsTheOrder() throws {
463
440
  let q = QueueManager()
464
441
  q.shuffleEnabled = true
@@ -497,9 +474,6 @@ struct AddAtTests {
497
474
  q.setQueue(tracks("a"))
498
475
  let changed = try q.addAt(tracks("x"), at: 0).currentTrack
499
476
  #expect(changed == false)
500
- // The pointer follows the playing track — the old `tracks.count > 1`
501
- // guard silently swapped currentTrack to the inserted track while the
502
- // player kept playing the old one.
503
477
  #expect(q.currentIndex == 1)
504
478
  #expect(q.currentTrack?.id == "a")
505
479
  }
@@ -507,18 +481,15 @@ struct AddAtTests {
507
481
  @Test func atExactCurrentIndex_shiftsCurrentIndex() throws {
508
482
  let q = QueueManager()
509
483
  q.setQueue(tracks("a", "b", "c"), initialIndex: 1)
510
- // currentIndex >= index (1 >= 1) triggers the shift
511
484
  let changed = try q.addAt(tracks("x"), at: 1).currentTrack
512
485
  #expect(changed == false)
513
486
  #expect(q.currentIndex == 2)
514
- // "b" should still be the current track
515
487
  #expect(q.currentTrack?.id == "b")
516
488
  }
517
489
 
518
490
  @Test func atEnd_appendsTrack() throws {
519
491
  let q = QueueManager()
520
492
  q.setQueue(tracks("a", "b"))
521
- // index == tracks.count is the valid append boundary
522
493
  let changed = try q.addAt(tracks("x"), at: 2).currentTrack
523
494
  #expect(changed == false)
524
495
  #expect(q.tracks.count == 3)
@@ -537,7 +508,6 @@ struct RemoveTests {
537
508
  q.setQueue(tracks("a", "b", "c"), initialIndex: 2)
538
509
  let changed = try q.remove(2).currentTrack
539
510
  #expect(changed == true)
540
- // After removing index 2, tracks has 2 items, currentIndex wraps: 2 % 2 = 0
541
511
  #expect(q.currentIndex == 0)
542
512
  #expect(q.tracks.count == 2)
543
513
  }
@@ -547,7 +517,7 @@ struct RemoveTests {
547
517
  q.setQueue(tracks("a", "b", "c"), initialIndex: 2)
548
518
  let changed = try q.remove(0).currentTrack
549
519
  #expect(changed == false)
550
- #expect(q.currentIndex == 1) // was 2, decremented
520
+ #expect(q.currentIndex == 1)
551
521
  #expect(q.tracks.count == 2)
552
522
  }
553
523
 
@@ -597,7 +567,6 @@ struct RemoveTests {
597
567
  q.setQueue(tracks("a", "b", "c"), initialIndex: 1)
598
568
  let changed = try q.remove(1).currentTrack
599
569
  #expect(changed == true)
600
- // 1 % 2 = 1, pointing to what was "c"
601
570
  #expect(q.currentIndex == 1)
602
571
  #expect(q.currentTrack?.id == "c")
603
572
  }
@@ -607,7 +576,6 @@ struct RemoveTests {
607
576
  q.setQueue(tracks("a", "b", "c"))
608
577
  let changed = try q.remove(0).currentTrack
609
578
  #expect(changed == true)
610
- // 0 % 2 = 0
611
579
  #expect(q.currentIndex == 0)
612
580
  #expect(q.currentTrack?.id == "b")
613
581
  }
@@ -616,7 +584,6 @@ struct RemoveTests {
616
584
  let q = QueueManager()
617
585
  q.setQueue(tracks("a", "b", "c"), initialIndex: 2)
618
586
  try q.remove(0)
619
- // currentIndex was 2, decremented to 1; track "c" should still be current
620
587
  #expect(q.currentTrack?.id == "c")
621
588
  }
622
589
  }
@@ -626,9 +593,8 @@ struct RemoveTests {
626
593
  @Suite("move()")
627
594
  @MainActor
628
595
  struct MoveTests {
629
- // A move never changes which track is current — the pointer follows the
630
- // track, and no move returns true (true triggers a reload at the caller,
631
- // which would restart playback on a reorder).
596
+ // No move reports a current-track change: the caller reloads on one, which would restart
597
+ // playback on a reorder.
632
598
 
633
599
  @Test func currentTrack_pointerFollows() throws {
634
600
  let q = QueueManager()
@@ -659,7 +625,6 @@ struct MoveTests {
659
625
  q.setQueue(tracks("a", "b", "c"), initialIndex: 1)
660
626
  let changed = try q.move(fromIndex: 0, toIndex: 2).currentTrack
661
627
  #expect(changed == false)
662
- // [a,b,c] → [b,c,a]; "b" is now index 0.
663
628
  #expect(q.currentTrack?.id == "b")
664
629
  #expect(q.currentIndex == 0)
665
630
  }
@@ -669,7 +634,6 @@ struct MoveTests {
669
634
  q.setQueue(tracks("a", "b", "c"), initialIndex: 1)
670
635
  let changed = try q.move(fromIndex: 2, toIndex: 0).currentTrack
671
636
  #expect(changed == false)
672
- // [a,b,c] → [c,a,b]; "b" is now index 2.
673
637
  #expect(q.currentTrack?.id == "b")
674
638
  #expect(q.currentIndex == 2)
675
639
  }
@@ -679,10 +643,7 @@ struct MoveTests {
679
643
  q.setQueue(tracks("a", "b", "c"), initialIndex: 0)
680
644
  let changed = try q.move(fromIndex: 0, toIndex: 99).currentTrack
681
645
  #expect(changed == false)
682
- // remove(0): [b, c], insert at min(2, 99)=2: [b, c, a]
683
646
  #expect(q.tracks[2].id == "a")
684
- // The unclamped assignment left currentIndex at 99 → currentTrack nil →
685
- // a reorder unloaded playback.
686
647
  #expect(q.currentIndex == 2)
687
648
  #expect(q.currentTrack?.id == "a")
688
649
  }
@@ -724,10 +685,8 @@ struct ClearTests {
724
685
  #expect(q.clear() == .none)
725
686
  }
726
687
 
727
- /// clear() and removeUpcomingTracks() were the only mutations not
728
- /// maintaining the shuffle order — a stale order over a rebuilt queue
729
- /// navigates to phantom indices, nil-ing currentTrack and unloading
730
- /// playback mid-session.
688
+ /// A stale shuffle order over a rebuilt queue navigates to indices that no longer exist, nil-ing
689
+ /// currentTrack mid-session.
731
690
  @Test func clear_alsoClearsShuffleOrder() {
732
691
  let q = QueueManager()
733
692
  q.shuffleEnabled = true
@@ -870,8 +829,6 @@ struct ComputedPropertyTests {
870
829
  q.setQueue(tracks("a", "b", "c", "d"))
871
830
  q.shuffleEnabled = true
872
831
  let nextFromProp = q.nextTracks.map { $0.id! }
873
- // Navigate forward only as many times as nextTracks reports
874
- // (nextTracks does not include wrapped tracks)
875
832
  var nextFromNav: [String] = []
876
833
  for _ in 0 ..< nextFromProp.count {
877
834
  _ = q.next()
@@ -884,12 +841,10 @@ struct ComputedPropertyTests {
884
841
  let q = QueueManager()
885
842
  q.setQueue(tracks("a", "b", "c", "d"))
886
843
  q.shuffleEnabled = true
887
- // Navigate to end of shuffle order so there are previous tracks
888
844
  for _ in 0 ..< 3 {
889
845
  _ = q.next()
890
846
  }
891
847
  let prevFromProp = q.previousTracks.map { $0.id! }
892
- // Navigate backward the same number of times
893
848
  var prevFromNav: [String] = []
894
849
  for _ in 0 ..< prevFromProp.count {
895
850
  _ = q.previous()
@@ -912,21 +867,17 @@ struct ComputedPropertyTests {
912
867
  let q = QueueManager()
913
868
  q.setQueue(tracks("a", "b", "c"))
914
869
  q.shuffleEnabled = true
915
- // Navigate forward until nextTracks is empty (= last in shuffle order)
916
870
  while !q.nextTracks.isEmpty {
917
871
  _ = q.next()
918
872
  }
919
873
  #expect(q.isLastInPlaybackOrder == true)
920
- // Navigate one more (wraps) — should no longer be last
921
874
  _ = q.next()
922
875
  #expect(q.isLastInPlaybackOrder == false)
923
876
  }
924
877
 
925
878
  @Test func isLastInPlaybackOrder_emptyQueue() {
926
879
  let q = QueueManager()
927
- // currentIndex is -1, tracks.count - 1 is -1, so this returns true
928
- // by the formula `currentIndex == tracks.count - 1`.
929
- // ShuffleOrder.isLast returns false for index -1.
880
+ // currentIndex -1 equals tracks.count - 1.
930
881
  #expect(q.isLastInPlaybackOrder == true)
931
882
  }
932
883
  }
@@ -1024,6 +975,7 @@ struct SkipAvailabilityTests {
1024
975
  let q = QueueManager()
1025
976
  q.setQueue(tracks("a"))
1026
977
  q.repeatMode = .queue
978
+ // next() would replay the same track, which is not a move to a distinct one.
1027
979
  #expect(q.canNext == false)
1028
980
  #expect(q.canPrevious == false)
1029
981
  }
@@ -1053,7 +1005,7 @@ struct SkipAvailabilityTests {
1053
1005
  let q = QueueManager()
1054
1006
  q.setQueue(tracks("a", "b", "c"), initialIndex: 2)
1055
1007
  q.repeatMode = .queue
1056
- #expect(q.canNext == true) // wraps to first
1008
+ #expect(q.canNext == true)
1057
1009
  #expect(q.canPrevious == true)
1058
1010
  }
1059
1011
 
@@ -1062,12 +1014,10 @@ struct SkipAvailabilityTests {
1062
1014
  q.setQueue(tracks("a", "b", "c"), initialIndex: 0)
1063
1015
  q.repeatMode = .queue
1064
1016
  #expect(q.canNext == true)
1065
- #expect(q.canPrevious == true) // wraps to last
1017
+ #expect(q.canPrevious == true)
1066
1018
  }
1067
1019
 
1068
- // Shuffle wraps the playback order unconditionally (even with repeat off), so
1069
- // next()/previous() always move when count > 1 — canNext/canPrevious must
1070
- // agree at the shuffle-order boundaries, not grey out.
1020
+ // Shuffle wraps even with repeat off, so canNext and canPrevious stay true at the order's ends.
1071
1021
  @Test func shuffleEnd_repeatOff_canNextTrue() {
1072
1022
  let q = QueueManager()
1073
1023
  q.setQueue(tracks("a", "b", "c", "d"))
@@ -1075,8 +1025,8 @@ struct SkipAvailabilityTests {
1075
1025
  q.repeatMode = .off
1076
1026
  while !q.isLastInPlaybackOrder {
1077
1027
  _ = q.next()
1078
- } // advance to last in shuffle order
1079
- #expect(q.canNext == true) // next() wraps to the first shuffle position
1028
+ }
1029
+ #expect(q.canNext == true)
1080
1030
  }
1081
1031
 
1082
1032
  @Test func shuffleStart_repeatOff_canPreviousTrue() {
@@ -1086,7 +1036,7 @@ struct SkipAvailabilityTests {
1086
1036
  q.repeatMode = .off
1087
1037
  while !q.previousTracks.isEmpty {
1088
1038
  _ = q.previous()
1089
- } // back to first in shuffle order
1090
- #expect(q.canPrevious == true) // previous() wraps to the last shuffle position
1039
+ }
1040
+ #expect(q.canPrevious == true)
1091
1041
  }
1092
1042
  }
@@ -4,12 +4,8 @@ import Testing
4
4
 
5
5
  @testable import AudioBrowserTestable
6
6
 
7
- /// Exercises the controller against the real `MPRemoteCommandCenter`.
8
- ///
9
- /// `MPRemoteCommandCenter`'s `init()` is unavailable, so `shared()` — a
10
- /// process-wide singleton — is the only center available. The suite is
11
- /// `.serialized` because of that shared state, and every test resets the
12
- /// commands it touches through `reset()`.
7
+ /// Runs against the real `MPRemoteCommandCenter`: its `init()` is unavailable, so the process-wide
8
+ /// `shared()` singleton is the only center, hence `.serialized`.
13
9
  @Suite("RemoteCommandController", .serialized)
14
10
  @MainActor
15
11
  struct RemoteCommandControllerTests {
@@ -28,9 +24,8 @@ struct RemoteCommandControllerTests {
28
24
  func remoteChangePlaybackRate(rate: Float) { events.append("rate:\(rate)") }
29
25
  }
30
26
 
31
- /// Clears every command on the shared center so a test starts from a known
32
- /// state regardless of what ran before it.
33
27
  private func makeController() -> (RemoteCommandController, SpyCallbacks) {
28
+ // Clears whatever an earlier test left enabled on the shared center.
34
29
  let center = MPRemoteCommandCenter.shared()
35
30
  let reset = RemoteCommandController(remoteCommandCenter: center)
36
31
  reset.enable(commands: Set(RemoteCommand.allCases))
@@ -128,7 +123,6 @@ struct RemoteCommandControllerTests {
128
123
  #expect(!center.skipForwardCommand.isEnabled)
129
124
  }
130
125
 
131
- /// Next/previous follow `skipAvailability` when refreshed and whenever they are enabled.
132
126
  @Test func skipAvailabilityAppliesOnRefreshAndEnable() {
133
127
  let (controller, _) = makeController()
134
128
  let center = MPRemoteCommandCenter.shared()
@@ -149,8 +143,7 @@ struct RemoteCommandControllerTests {
149
143
  #expect(center.previousTrackCommand.isEnabled)
150
144
  }
151
145
 
152
- /// The command targets must not capture the controller strongly, or every player
153
- /// instance leaks one across JS reloads.
146
+ /// Handlers capturing the controller strongly would leak one per player instance across JS reloads.
154
147
  @Test func doesNotRetainItselfThroughHandlers() {
155
148
  weak var weakController: RemoteCommandController?
156
149
  autoreleasepool {
@@ -170,8 +163,7 @@ struct RemoteCommandControllerTests {
170
163
  controller.updateShuffleMode(true)
171
164
  controller.updateRepeatMode(.queue)
172
165
 
173
- // Same center — switchCommandCenter no-ops, but the restore path is the
174
- // interesting part: state is re-applied from the stored values.
166
+ // The same center makes this a no-op; the expectations hold from the calls above.
175
167
  controller.switchCommandCenter(center)
176
168
 
177
169
  #expect(center.changeShuffleModeCommand.currentShuffleType == .items)
@@ -223,7 +223,6 @@ private func makeFullResolvedTrack() -> ResolvedTrack {
223
223
  #expect(copy.artist == "New Artist")
224
224
  #expect(copy.duration == 240.0)
225
225
  #expect(copy.favorited == true)
226
- // Unchanged fields
227
226
  #expect(copy.src == nil)
228
227
  #expect(copy.artwork == nil)
229
228
  #expect(copy.children == nil)
@@ -235,7 +234,6 @@ private func makeFullResolvedTrack() -> ResolvedTrack {
235
234
  let original = makeFullResolvedTrack()
236
235
  let copy = original.copying(title: "Changed Only Title")
237
236
  #expect(copy.title == "Changed Only Title")
238
- // All other fields unchanged
239
237
  #expect(copy.path == "/original")
240
238
  #expect(copy.children?.count == 1)
241
239
  #expect(copy.carPlaySiriListButton == .top)
@@ -9,14 +9,12 @@ private final class MockNetworkStatus: NetworkStatusProviding, @unchecked Sendab
9
9
  init(isOnline: Bool) { self.isOnline = isOnline }
10
10
  }
11
11
 
12
- /// The two duration budgets: a never-played load gives up fast while online; a
13
- /// load that produced audio — or a device that is offline — keeps the full
14
- /// recovery budget. Timing-based: budgets are configured in single-digit
15
- /// milliseconds so one executed backoff (~1s) exhausts them.
12
+ /// Timing-based: these run the real backoff (1s, 1.5s, 2.25s, 3.375s), and the budgets are checked
13
+ /// before and after each wait, so each budget below sits between two points on that ladder.
16
14
  @Suite("RetryLoop budgets")
17
15
  @MainActor
18
16
  struct RetryLoopBudgetTests {
19
- /// Returns the mock too — `networkMonitor` is weak, the test must keep it alive.
17
+ /// Returns the mock too: `networkMonitor` is weak, so the test must hold it.
20
18
  private func makeManager(
21
19
  firstConnectMs: Double,
22
20
  maxMs: Double = 120_000,
@@ -33,13 +31,9 @@ struct RetryLoopBudgetTests {
33
31
  return (manager, network)
34
32
  }
35
33
 
36
- /// A dead-on-arrival stream: the first attempt runs, and the budget refuses
37
- /// a later one. Budgets are checked before AND after each backoff wait, so
38
- /// the test budget must exceed the first backoff (~1s) for attempt one to
39
- /// execute, and be exceeded by the cumulative ~2.5s before attempt two ends.
40
- /// 1800ms sits ~800ms clear of the first backoff (sleep overshoot on a loaded
41
- /// machine only widens the passing margins, never shrinks them into failure).
42
34
  @Test func neverPlayedLoad_givesUpAfterFirstConnectBudget() async {
35
+ // Above the first backoff (1s), with ~800ms for sleep overshoot; below the 2.5s at which
36
+ // attempt two's wait ends.
43
37
  let (manager, network) = makeManager(firstConnectMs: 1800, online: true)
44
38
  _ = network
45
39
 
@@ -47,9 +41,8 @@ struct RetryLoopBudgetTests {
47
41
  #expect(await manager.attemptRetry(startFromCurrentTime: false) == false)
48
42
  }
49
43
 
50
- /// The same failure timeline on a load that has produced audio keeps
51
- /// retrying: only the recovery budget applies.
52
44
  @Test func playedLoad_ignoresTheFirstConnectBudget() async {
45
+ // Below the first backoff: a never-played load would give up on attempt one.
53
46
  let (manager, network) = makeManager(firstConnectMs: 500, online: true)
54
47
  _ = network
55
48
  manager.hasPlayed = { true }
@@ -58,21 +51,15 @@ struct RetryLoopBudgetTests {
58
51
  #expect(await manager.attemptRetry(startFromCurrentTime: false) == true)
59
52
  }
60
53
 
61
- /// Offline failures must not burn the first-connect budget (a station tapped
62
- /// in a tunnel parks for connectivity); the budget's clock starts at the
63
- /// first failure observed online, so a dead station still gets a fast
64
- /// verdict after restoration.
65
54
  @Test func offlineTime_doesNotBurnTheFirstConnectBudget() async {
66
- // 4s: well above the ~2.3s backoff of the first online attempt (the ladder
67
- // kept climbing while offline), well below the ~5.6s cumulative after it.
55
+ // Above the 2.25s wait of the first online attempt (the backoff kept climbing while offline),
56
+ // below the ~5.6s at which the second one's wait ends.
68
57
  let (manager, network) = makeManager(firstConnectMs: 4000, online: false)
69
58
 
70
- // Offline: the short budget never engages, attempts keep running.
71
59
  #expect(await manager.attemptRetry(startFromCurrentTime: false) == true)
72
60
  #expect(await manager.attemptRetry(startFromCurrentTime: false) == true)
73
61
 
74
- // Connectivity returns: the short clock starts now — one more attempt
75
- // runs, then the budget is spent.
62
+ // The first-connect clock starts here, at the first attempt made online.
76
63
  network.isOnline = true
77
64
  #expect(await manager.attemptRetry(startFromCurrentTime: false) == true)
78
65
  #expect(await manager.attemptRetry(startFromCurrentTime: false) == false)
@@ -84,7 +71,6 @@ struct RetryLoopBudgetTests {
84
71
  @Suite("RetryLoop.handleError")
85
72
  @MainActor
86
73
  struct RetryLoopHandleErrorTests {
87
- /// What the loop reported and did, in order.
88
74
  final class Record {
89
75
  var retrying: [TrackPlayerError.PlaybackError] = []
90
76
  var errors: [TrackPlayerError.PlaybackError] = []
@@ -108,8 +94,6 @@ struct RetryLoopHandleErrorTests {
108
94
  #expect(loop.pendingTask == nil)
109
95
  }
110
96
 
111
- /// A disabled policy makes every error terminal: no advisory, no retry task, even for a
112
- /// retryable failure, which is still classified.
113
97
  @Test func aDisabledPolicySurfacesAtOnce() {
114
98
  let (loop, record) = makeLoop()
115
99
  loop.updatePolicy(from: nil)
@@ -119,7 +103,6 @@ struct RetryLoopHandleErrorTests {
119
103
  #expect(loop.pendingTask == nil)
120
104
  }
121
105
 
122
- /// Also pins that a finished retry clears its handle: session release waits on it.
123
106
  @Test func aRetryableErrorReloadsFromTheContextsPosition() async {
124
107
  let (loop, record) = makeLoop()
125
108
  loop.handleError(URLError(.timedOut), context: .playback)
@@ -130,12 +113,11 @@ struct RetryLoopHandleErrorTests {
130
113
 
131
114
  #expect(record.reloads == [true, false])
132
115
  #expect(record.errors.isEmpty)
116
+ // Session release waits on `pendingTask`, so a finished retry must clear it.
133
117
  #expect(loop.pendingTask == nil)
134
118
  #expect(loop.attempts == 2)
135
119
  }
136
120
 
137
- /// The advisory goes out before the backoff, carrying the classification a terminal report
138
- /// would.
139
121
  @Test func theAdvisoryPrecedesTheRetry() async {
140
122
  let (loop, record) = makeLoop()
141
123
  loop.handleError(URLError(.cannotConnectToHost), context: .mediaLoad)
@@ -153,8 +135,6 @@ struct RetryLoopHandleErrorTests {
153
135
  #expect(record.errors == [.hostUnreachable])
154
136
  }
155
137
 
156
- /// A cancelled retry stays silent: a track change or a stop cancels it, and surfacing its
157
- /// failure would flip the new track or the stop to .error.
158
138
  @Test func aCancelledRetryStaysSilent() async {
159
139
  let (loop, record) = makeLoop(delay: 0.05)
160
140
  loop.handleError(URLError(.timedOut), context: .playback)
@@ -166,7 +146,6 @@ struct RetryLoopHandleErrorTests {
166
146
  #expect(record.reloads.isEmpty)
167
147
  }
168
148
 
169
- /// A second failure replaces the retry in flight, which neither reports nor reloads.
170
149
  @Test func aNewFailureReplacesTheRetryInFlight() async {
171
150
  let (loop, record) = makeLoop(delay: 0.02)
172
151
  loop.handleError(URLError(.timedOut), context: .playback)
@@ -187,7 +166,6 @@ struct RetryLoopHandleErrorTests {
187
166
  #expect(record.errors == [.httpStatus(404), .httpStatus(503)])
188
167
  }
189
168
 
190
- /// An unclassifiable failure, retried and given up on, reports the context's fallback.
191
169
  @Test func givingUpOnAnOpaqueFailureReportsTheFallback() async {
192
170
  let (loop, record) = makeLoop(retries: false)
193
171
  loop.handleError(NSError(domain: "CoreMediaErrorDomain", code: -12939), context: .mediaLoad)
@@ -215,7 +193,7 @@ struct RetryLoopHandleErrorTests {
215
193
  #expect(record.reloads.isEmpty)
216
194
  }
217
195
 
218
- /// A loop whose backoff waits until cancelled, reporting when it starts waiting.
196
+ /// A loop whose backoff waits until cancelled; the closure says whether it has started waiting.
219
197
  private func makeWaitingLoop() -> (RetryLoop, Record, () -> Bool) {
220
198
  var waiting = false
221
199
  let loop = RetryLoop(sleep: { _ in
@@ -243,10 +221,9 @@ struct RetryLoopHandleErrorTests {
243
221
  #expect(record.reloads.isEmpty)
244
222
  }
245
223
 
246
- /// A cancel that lands as the backoff completes (the sleep itself returning normally) still
247
- /// stops the reload.
248
224
  @Test func aCancelAsTheBackoffEndsStopsTheReload() async {
249
225
  let holder = LoopHolder()
226
+ // The cancel lands as the backoff completes: the sleep returns normally, not by throwing.
250
227
  let loop = RetryLoop(sleep: { _ in
251
228
  await holder.loop?.cancel()
252
229
  })
@@ -9,7 +9,6 @@ private struct Item: PlayableSearchItem {
9
9
 
10
10
  @Suite("SearchDrillIn.playable")
11
11
  struct SearchDrillInTests {
12
- /// A resolver that fails the test if the drill-in path calls it.
13
12
  private func unusedResolver(_ path: String) async throws -> [Item] {
14
13
  Issue.record("resolveChildren should not have been called (path: \(path))")
15
14
  return []
@@ -23,7 +22,7 @@ struct SearchDrillInTests {
23
22
  @Test func firstPlayable_returnsFlatPlayable_inOrder_withoutResolving() async throws {
24
23
  let items = [
25
24
  Item(src: "/a.mp3", path: nil),
26
- Item(src: nil, path: "/page/x"), // browsable, filtered out
25
+ Item(src: nil, path: "/page/x"),
27
26
  Item(src: "/b.mp3", path: nil),
28
27
  ]
29
28
  let result = try await SearchDrillIn.playable(from: items, resolveChildren: unusedResolver)
@@ -32,8 +31,8 @@ struct SearchDrillInTests {
32
31
 
33
32
  @Test func firstBrowsable_drillsIntoIt_andPlaysItsChildren() async throws {
34
33
  let items = [
35
- Item(src: nil, path: "/page/place"), // browsable first result
36
- Item(src: "/later.mp3", path: nil), // would win without drill-in
34
+ Item(src: nil, path: "/page/place"),
35
+ Item(src: "/later.mp3", path: nil), // would win without the drill-in
37
36
  ]
38
37
  let result = try await SearchDrillIn.playable(from: items) { path in
39
38
  #expect(path == "/page/place")
@@ -48,7 +47,7 @@ struct SearchDrillInTests {
48
47
  Item(src: "/fallback.mp3", path: nil),
49
48
  ]
50
49
  let result = try await SearchDrillIn.playable(from: items) { _ in
51
- [Item(src: nil, path: "/page/nested")] // nothing playable inside
50
+ [Item(src: nil, path: "/page/nested")] // the drill-in goes one level, so nothing playable
52
51
  }
53
52
  #expect(result?.compactMap(\.src) == ["/fallback.mp3"])
54
53
  }