react-native-audio-browser 0.2.0-next.53 → 0.2.0-next.54

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (329) hide show
  1. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  2. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  3. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  5. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  6. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  7. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  8. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  9. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  10. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  11. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  12. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  13. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  15. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  16. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  17. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  18. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  19. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  20. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  21. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  22. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  23. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  24. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  25. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  26. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  27. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  28. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  29. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  30. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  31. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  32. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  33. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  34. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  35. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  36. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  37. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  38. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  39. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  40. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  41. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  42. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  43. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  45. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  46. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  50. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  51. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  52. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  53. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  54. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  55. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  56. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  58. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  59. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  60. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  61. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  63. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  64. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +28 -48
  66. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  67. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  68. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  71. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  78. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  80. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  81. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  82. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  84. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  85. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  86. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  90. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  91. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  92. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  93. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  94. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  96. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  97. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  98. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  99. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  100. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  102. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  103. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  104. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  105. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  106. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  107. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  108. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  109. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  110. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  111. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  112. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  113. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  114. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  115. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  116. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  121. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  122. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  123. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  124. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  125. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  126. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  127. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  128. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  129. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  130. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  131. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  132. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  133. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  134. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  135. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  136. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  137. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  138. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  139. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  143. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +2 -2
  144. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  145. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  146. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +5 -1
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  149. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  150. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  151. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  152. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  153. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  154. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  155. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +9 -10
  156. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +0 -1
  157. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  158. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  159. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  167. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  168. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  169. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  170. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  172. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  174. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  175. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  177. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  178. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  179. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  180. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  181. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  183. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  184. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  185. package/ios/AVPlayerEngine.swift +13 -21
  186. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  187. package/ios/Browser/BrowseGate.swift +7 -8
  188. package/ios/Browser/BrowserConfig.swift +19 -34
  189. package/ios/Browser/BrowserError.swift +0 -1
  190. package/ios/Browser/BrowserManager.swift +29 -75
  191. package/ios/Browser/BrowserPathHelper.swift +13 -93
  192. package/ios/Browser/FavoriteSet.swift +7 -10
  193. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  194. package/ios/Browser/JsonModels.swift +11 -51
  195. package/ios/Browser/NavigationErrorState.swift +3 -2
  196. package/ios/Browser/PageResolver.swift +13 -23
  197. package/ios/Browser/RequestLayer.swift +16 -20
  198. package/ios/Browser/RequestPipeline.swift +33 -43
  199. package/ios/Browser/SearchDrillIn.swift +7 -13
  200. package/ios/Browser/SectionScope.swift +14 -26
  201. package/ios/Browser/SimpleRouter.swift +8 -15
  202. package/ios/Browser/StyleResolver.swift +12 -29
  203. package/ios/Browser/TabBarEntries.swift +6 -11
  204. package/ios/Browser/TrackIdTemplate.swift +6 -14
  205. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  206. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  207. package/ios/CarPlay/CarPlayController.swift +4 -4
  208. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  209. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  210. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  211. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  212. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  213. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  214. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  215. package/ios/CarPlay/CarPlaySession.swift +13 -17
  216. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  217. package/ios/CarPlay/IntentHandlers.swift +3 -5
  218. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  219. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  220. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  221. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  222. package/ios/CarPlay/SectionPresentation.swift +18 -28
  223. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  224. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  225. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  226. package/ios/Extension/CxxVectorConformances.swift +4 -16
  227. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  228. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  229. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  230. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  231. package/ios/Extension/SearchParams+Query.swift +4 -4
  232. package/ios/Extension/Section+Copying.swift +3 -6
  233. package/ios/Extension/String+IcyCharset.swift +5 -5
  234. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  235. package/ios/Extension/Track+AVPlayer.swift +1 -2
  236. package/ios/Extension/Track+Copying.swift +2 -8
  237. package/ios/Extension/Track+Identity.swift +4 -9
  238. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  239. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  240. package/ios/Extension/Variant+Artwork.swift +8 -22
  241. package/ios/Http/HttpClient.swift +3 -3
  242. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  243. package/ios/HybridAudioBrowser+Options.swift +6 -9
  244. package/ios/HybridAudioBrowser+Player.swift +8 -16
  245. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  246. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  247. package/ios/HybridAudioBrowser.swift +54 -79
  248. package/ios/Model/NitroTypeStubs.swift +15 -22
  249. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  250. package/ios/Model/RemoteCommand.swift +2 -2
  251. package/ios/Model/TrackPlayerError.swift +9 -22
  252. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  253. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  254. package/ios/Observer/ItemObserver.swift +7 -5
  255. package/ios/Observer/PlayerObserver.swift +5 -5
  256. package/ios/PlaybackEvent.swift +2 -2
  257. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  258. package/ios/Player/AudioSessionController.swift +14 -15
  259. package/ios/Player/DeferredSeek.swift +2 -2
  260. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  261. package/ios/Player/ErrorStatus.swift +8 -7
  262. package/ios/Player/MediaLoader.swift +20 -24
  263. package/ios/Player/NowPlayingLines.swift +1 -4
  264. package/ios/Player/NowPlayingUpdater.swift +35 -61
  265. package/ios/Player/PersistedPlaybackState.swift +1 -2
  266. package/ios/Player/PlaybackFailure.swift +20 -24
  267. package/ios/Player/PlaybackPersistence.swift +5 -6
  268. package/ios/Player/PlaybackStateMachine.swift +8 -11
  269. package/ios/Player/PlaybackTimer.swift +8 -11
  270. package/ios/Player/Player.swift +6 -13
  271. package/ios/Player/PlayerEngine.swift +20 -20
  272. package/ios/Player/PlayerStatusTypes.swift +1 -2
  273. package/ios/Player/QueueManager.swift +23 -67
  274. package/ios/Player/RetryLoop.swift +39 -50
  275. package/ios/Player/ShuffleOrder.swift +17 -57
  276. package/ios/Player/SleepTimerManager.swift +13 -28
  277. package/ios/Player/VolumeFader.swift +16 -16
  278. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  279. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  280. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  281. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  282. package/ios/Tests/DeferredSeekTests.swift +1 -3
  283. package/ios/Tests/EmitterTests.swift +0 -1
  284. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  285. package/ios/Tests/FavoriteSetTests.swift +1 -0
  286. package/ios/Tests/GenerationMemoTests.swift +2 -2
  287. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  288. package/ios/Tests/JsonModelsTests.swift +5 -12
  289. package/ios/Tests/LRUCacheTests.swift +1 -5
  290. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  291. package/ios/Tests/MediaLoaderTests.swift +3 -12
  292. package/ios/Tests/ObserverTests.swift +3 -3
  293. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  294. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  295. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  296. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  297. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  298. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  299. package/ios/Tests/PlayerTests.swift +53 -88
  300. package/ios/Tests/PlayingStateTests.swift +0 -1
  301. package/ios/Tests/QueueManagerTests.swift +30 -80
  302. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  303. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  304. package/ios/Tests/RetryLoopTests.swift +12 -35
  305. package/ios/Tests/SearchDrillInTests.swift +4 -5
  306. package/ios/Tests/SectionPresentationTests.swift +3 -16
  307. package/ios/Tests/SectionScopeTests.swift +3 -6
  308. package/ios/Tests/SimpleRouterTests.swift +1 -5
  309. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  310. package/ios/Tests/StyleResolverTests.swift +4 -13
  311. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  312. package/ios/Tests/Support/TestTypes.swift +5 -15
  313. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  314. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  315. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  316. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  317. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  318. package/ios/Tests/TrackSelectorTests.swift +3 -15
  319. package/ios/TrackSelector.swift +13 -25
  320. package/ios/Util/ArtworkFreshness.swift +6 -6
  321. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  322. package/ios/Util/ConcurrentMap.swift +2 -2
  323. package/ios/Util/Emitter.swift +8 -13
  324. package/ios/Util/NetworkMonitor.swift +4 -6
  325. package/ios/Util/OutputPicker.swift +1 -1
  326. package/ios/Util/ReadyValue.swift +3 -2
  327. package/ios/Util/SFSymbolRenderer.swift +17 -30
  328. package/ios/Util/SVGProcessor.swift +5 -9
  329. package/package.json +1 -1
@@ -177,15 +177,13 @@ class RequestConfigBuilderTest {
177
177
 
178
178
  val result = RequestConfigBuilder.mergeConfig(base, override)
179
179
 
180
- // Headers should be merged with override winning
181
180
  assertEquals("base-value", result.headers!!["Base-Header"])
182
181
  assertEquals("override-value", result.headers!!["Override-Header"])
183
- assertEquals("override-shared", result.headers!!["Shared"]) // Override wins
182
+ assertEquals("override-shared", result.headers!!["Shared"])
184
183
 
185
- // Query should be merged with override winning
186
184
  assertEquals("base-value", result.query!!["base-query"])
187
185
  assertEquals("override-value", result.query!!["override-query"])
188
- assertEquals("override-shared", result.query!!["shared"]) // Override wins
186
+ assertEquals("override-shared", result.query!!["shared"])
189
187
  }
190
188
 
191
189
  @Test
@@ -205,7 +203,7 @@ class RequestConfigBuilderTest {
205
203
  val configWithoutSlash =
206
204
  RequestConfig(
207
205
  method = null,
208
- path = "albums", // No leading slash
206
+ path = "albums",
209
207
  baseUrl = "https://api.example.com",
210
208
  headers = null,
211
209
  query = null,
@@ -218,7 +216,7 @@ class RequestConfigBuilderTest {
218
216
  val result2 = RequestConfigBuilder.buildHttpRequest(configWithoutSlash)
219
217
 
220
218
  assertEquals("https://api.example.com/albums", result1.url)
221
- assertEquals("https://api.example.com/albums", result2.url) // Should add slash
219
+ assertEquals("https://api.example.com/albums", result2.url)
222
220
  }
223
221
 
224
222
  @Test
@@ -229,7 +227,7 @@ class RequestConfigBuilderTest {
229
227
  path = "/albums",
230
228
  baseUrl = "https://api.example.com",
231
229
  headers = null,
232
- query = emptyMap(), // Empty map
230
+ query = emptyMap(),
233
231
  body = null,
234
232
  contentType = null,
235
233
  userAgent = null,
@@ -237,11 +235,9 @@ class RequestConfigBuilderTest {
237
235
 
238
236
  val result = RequestConfigBuilder.buildHttpRequest(config)
239
237
 
240
- assertEquals("https://api.example.com/albums", result.url) // No query string
238
+ assertEquals("https://api.example.com/albums", result.url)
241
239
  }
242
240
 
243
- // Run-both composition: the sync/async split replaced the old ambiguous variant.
244
-
245
241
  @Test
246
242
  fun `composeResolved merges async then sync with sync winning`() {
247
243
  val async =
@@ -250,8 +246,8 @@ class RequestConfigBuilderTest {
250
246
 
251
247
  val merged = RequestConfigBuilder.composeResolved(async, sync)
252
248
 
253
- assertEquals("SYNC", merged?.userAgent) // sync wins
254
- assertEquals("https://async.example.com", merged?.baseUrl) // async's baseUrl survives
249
+ assertEquals("SYNC", merged?.userAgent)
250
+ assertEquals("https://async.example.com", merged?.baseUrl)
255
251
  }
256
252
 
257
253
  @Test
@@ -287,10 +283,6 @@ class RequestConfigBuilderTest {
287
283
  assertEquals("base-ua", merged.userAgent)
288
284
  }
289
285
 
290
- // Request-Config Layer rule (mirrors iOS applyLayer and the web stub): a
291
- // layer's static `path` never overrides the base path — the path is carried
292
- // from the base; only a Transform may change it.
293
-
294
286
  @Test
295
287
  fun `mergeConfig TransformableRequestConfig carries the base path over a static layer path`() =
296
288
  runTest {
@@ -23,7 +23,7 @@ class IcyTitleTest {
23
23
 
24
24
  @Test
25
25
  fun `re-decodes a title the station utf-8 encoded from legacy bytes`() {
26
- // media3 decodes the valid UTF-8 to the same Latin-1-shaped string the fallback would give.
26
+ // media3 decodes this valid UTF-8 to the same Latin-1-shaped string its fallback gives.
27
27
  val doubleEncoded = latin1Shaped("Artist - เพลง", "windows-874").toByteArray(Charsets.UTF_8)
28
28
  assertEquals(
29
29
  "Artist - เพลง",
@@ -34,16 +34,9 @@ import org.junit.runner.RunWith
34
34
  import org.robolectric.RobolectricTestRunner
35
35
 
36
36
  /**
37
- * Tests the tiles an Android Auto browse level serves in place of a list: the empty tile of a page
38
- * that resolved with zero children, and the offline and failure tiles, all worded by the app's
39
- * `formatNavigationError` (ADR 0001). MediaSessionCallback itself needs a live MediaLibrarySession,
40
- * so the pieces under test are the ones carved out of it: [browseLevelItems] (the empty-branch
41
- * decision), the tile builders, [BrowserPathHelper.isDeadEndPath] (the drill-in guard),
42
- * [announcedSearchCount] (what onSearch tells the controller to ask for), [FailedSearchSlot] (a
43
- * failed search, which must not read as an empty one), [OfflineSearchRegistry] (the searches
44
- * connectivity returning re-runs), [navigationErrorFor] (the one exception mapping browse, search
45
- * and the JS-facing `search` rejection share) and [formattedOrDefault] (the formatter hop's
46
- * fallback rule, which sits off the JNI-backed Promise edge for exactly this reason).
37
+ * Tests the tiles a browse level serves in place of a list, worded by the app's
38
+ * `formatNavigationError` (ADR 0001). MediaSessionCallback needs a live MediaLibrarySession, so
39
+ * these test the pieces carved out of it.
47
40
  */
48
41
  @RunWith(RobolectricTestRunner::class)
49
42
  class BrowseTilesTest {
@@ -66,11 +59,7 @@ class BrowseTilesTest {
66
59
  .setMediaMetadata(MediaMetadata.Builder().setTitle(title).build())
67
60
  .build()
68
61
 
69
- /**
70
- * Stands in for an app's `formatNavigationError`: different copy per error and per path, the
71
- * point of ADR 0001. The search branches match the prefix the library builds car search paths
72
- * from.
73
- */
62
+ /** Stands in for an app's `formatNavigationError`: different copy per error and per path. */
74
63
  private fun appCopy(error: NavigationError, path: String): FormattedNavigationError {
75
64
  val isSearch = path.startsWith(BrowserPathHelper.SEARCH_PATH_PREFIX)
76
65
  return when {
@@ -282,8 +271,7 @@ class BrowseTilesTest {
282
271
  )
283
272
  )
284
273
 
285
- // Nothing servable, so the announced count is the tile's — a controller told zero would never
286
- // come back for it.
274
+ // The tile's count: a controller told zero never asks for the tile.
287
275
  assertEquals(1, announcedSearchCount(disabledOnly))
288
276
  }
289
277
 
@@ -318,8 +306,7 @@ class BrowseTilesTest {
318
306
  assertFalse(tile.mediaMetadata.isBrowsable!!)
319
307
  assertFalse(tile.mediaMetadata.isPlayable!!)
320
308
  assertTrue(BrowserPathHelper.isDeadEndPath(BrowserPathHelper.OFFLINE_PATH))
321
- // Offline is not a search that failed: connectivity returning is what serves results again,
322
- // so the slot stays empty and a later re-query of the query is not a failure.
309
+ // Offline is not a failed search: connectivity returning re-runs it, so the slot stays empty.
323
310
  assertNull(slot.errorFor("jazz"))
324
311
  }
325
312
 
@@ -344,11 +331,10 @@ class BrowseTilesTest {
344
331
  assertEquals("We couldn't load that", appTile.mediaMetadata.title)
345
332
  assertEquals("Try again in a moment.", appTile.mediaMetadata.subtitle)
346
333
 
347
- // Without a formatter, the status text the in-app error already shows.
348
334
  val defaultTile = createBrowseErrorMediaItem(defaultFormattedError(failure))
349
335
  assertEquals("Service Unavailable", defaultTile.mediaMetadata.title)
350
336
 
351
- // A re-read of the tile has no exception left to map, so it stands on the generic failure.
337
+ // A re-read of the tile has no exception left to map, so it gets the generic failure.
352
338
  assertEquals("Error", defaultFormattedError(browseFailureError()).title)
353
339
  }
354
340
 
@@ -368,8 +354,8 @@ class BrowseTilesTest {
368
354
 
369
355
  @Test
370
356
  fun `a failed search rejects with the navigation error a failed browse would raise`() {
371
- // Nitro's Promise is JNI-backed (its constructor calls initHybrid), so the JS-facing
372
- // AudioBrowser.search cannot be built here; what it rejects with is this.
357
+ // Nitro's Promise is JNI-backed, so AudioBrowser.search cannot be built here; this is what it
358
+ // rejects with.
373
359
  val rejection =
374
360
  NavigationErrorException(navigationErrorFor(HttpStatusException(503, "Service Unavailable")))
375
361
  assertEquals(NavigationErrorType.HTTP_ERROR, rejection.error.code)
@@ -401,7 +387,6 @@ class BrowseTilesTest {
401
387
  assertEquals(2, pending.size)
402
388
  assertEquals("jazz fm", pending.single { it.browser == auto }.query)
403
389
  assertEquals("blues", pending.single { it.browser == assistant }.query)
404
- // Drained, so a second connectivity change does not re-run the same searches again.
405
390
  assertTrue(registry.drain().isEmpty())
406
391
  }
407
392
 
@@ -415,10 +400,8 @@ class BrowseTilesTest {
415
400
  )
416
401
  )
417
402
 
418
- // The re-run goes through the same count as the first, online search, so what a controller is
419
- // told to fetch is what onGetSearchResult then serves from the cache that search filled.
403
+ // The re-run counts like the first search, so the controller asks for what the cache serves.
420
404
  assertEquals(2, announcedSearchCount(hits))
421
- // While offline there is nothing to count: the one tile is announced instead.
422
405
  assertEquals(1, announcedSearchCount(null))
423
406
  }
424
407
 
@@ -461,8 +444,8 @@ class BrowseTilesTest {
461
444
  var parked: Continuation<FormattedNavigationError?>? = null
462
445
 
463
446
  try {
464
- // Nitro's Promise.await parks exactly like this — suspendCoroutine, so cancelling the
465
- // coroutine never unparks it. The hop must be abandoned, not waited on.
447
+ // Nitro's Promise.await parks like this, in suspendCoroutine, which cancellation never
448
+ // unparks; the hop must be abandoned, not waited on.
466
449
  val formatted =
467
450
  formattedOrDefault(backgroundScope, default) {
468
451
  suspendCoroutine { continuation -> parked = continuation }
@@ -8,11 +8,6 @@ import org.junit.Assert.assertFalse
8
8
  import org.junit.Assert.assertTrue
9
9
  import org.junit.Test
10
10
 
11
- /**
12
- * Truth tables for the pure Capability decision core: [PlayerCapabilities.isEnabled] (one rule for
13
- * "available by default, only false disables; favorite is opt-in; play/pause is one control") and
14
- * [deriveButtonSlots] (the single slot derivation every Media3 assembly consumes).
15
- */
16
11
  class CapabilityControlsTest {
17
12
 
18
13
  private fun capabilities(
@@ -154,9 +149,7 @@ class CapabilityControlsTest {
154
149
 
155
150
  @Test
156
151
  fun `a layout is never merged with the capability defaults`() {
157
- // Nitro collapses an omitted and a null enum field to the same Kotlin null, so a per-field
158
- // merge is not expressible: an empty position must stay empty rather than falling back to the
159
- // capability default. Every capability here is enabled, so a merge would add skip and jump.
152
+ // Every capability is enabled, so a merge would add skip and jump.
160
153
  val derived =
161
154
  slots(capabilities(favorite = true), layout(overflow = arrayOf(RemoteButton.FAVORITE)))
162
155
  assertEquals(listOf(RemoteButton.FAVORITE to ButtonSlot.OVERFLOW), derived)
@@ -164,8 +157,7 @@ class CapabilityControlsTest {
164
157
 
165
158
  @Test
166
159
  fun `a disabled entry drops out without promoting anything into its position`() {
167
- // favorite unset (= disabled), skipToPrevious explicitly off. skip-to-next must stay on
168
- // FORWARD rather than sliding into the vacated BACK position.
160
+ // favorite is unset, so FAVORITE drops out too.
169
161
  val derived =
170
162
  slots(
171
163
  capabilities(skipToPrevious = false),
@@ -184,8 +176,7 @@ class CapabilityControlsTest {
184
176
  fun `sameAs compares overflow by content, not by array identity`() {
185
177
  val a = layout(back = RemoteButton.JUMP_BACKWARD, overflow = arrayOf(RemoteButton.FAVORITE))
186
178
  val b = layout(back = RemoteButton.JUMP_BACKWARD, overflow = arrayOf(RemoteButton.FAVORITE))
187
- // Distinct Array instances — data-class `==` would call these different and republish the
188
- // layout to Android Auto on every unrelated options update.
179
+ // Distinct Array instances, which data-class `==` would call different.
189
180
  assertTrue(a.sameAs(b))
190
181
  assertFalse(a.sameAs(layout(back = RemoteButton.JUMP_BACKWARD)))
191
182
  assertFalse(
@@ -8,10 +8,6 @@ import org.junit.Assert.assertNull
8
8
  import org.junit.Assert.assertTrue
9
9
  import org.junit.Test
10
10
 
11
- /**
12
- * OkHttp drops `Authorization` across a cross-origin redirect by itself; these cover the rest,
13
- * which it forwards and [CrossOriginHeaderStripper.stripCallerHeaders] removes.
14
- */
15
11
  class CrossOriginHeaderStripperTest {
16
12
 
17
13
  private val api = "https://api.example.com/stream/7".toHttpUrl()
@@ -72,7 +68,6 @@ class CrossOriginHeaderStripperTest {
72
68
 
73
69
  val stripped = CrossOriginHeaderStripper.stripCallerHeaders(request)
74
70
 
75
- // a dropped Range would restart the read from zero on every seek past a redirect
76
71
  assertEquals("bytes=1024-", stripped.header("Range"))
77
72
  assertEquals("identity", stripped.header("Accept-Encoding"))
78
73
  assertEquals("react-native-audio-browser", stripped.header("User-Agent"))
@@ -81,8 +76,6 @@ class CrossOriginHeaderStripperTest {
81
76
 
82
77
  @Test
83
78
  fun `keeps media3's ICY metadata request across a hop`() {
84
- // ProgressiveMediaPeriod asks for Shoutcast metadata on the DataSpec, the same channel the
85
- // config's headers arrive on. Dropping it costs icy-metaint, so onMetadata never fires again.
86
79
  val request =
87
80
  Request.Builder().url(api).header("Icy-MetaData", "1").header("X-Api-Key", "k").build()
88
81
 
@@ -41,7 +41,6 @@ class DynamicLoadControlTest {
41
41
  fun `clears once the rebuffer recovers`() {
42
42
  val loadControl = DynamicLoadControl()
43
43
  loadControl.shouldStartPlayback(params(rebuffering = true))
44
- // A later poll while playing normally reports rebuffering = false.
45
44
  loadControl.shouldContinueLoading(params(rebuffering = false))
46
45
  assertFalse(loadControl.isRebuffering)
47
46
  }
@@ -10,15 +10,8 @@ import org.junit.Assert.assertSame
10
10
  import org.junit.Assert.assertTrue
11
11
  import org.junit.Test
12
12
 
13
- /**
14
- * The controller's contract across the stretches where no equalizer effect exists — before the
15
- * first audio session and across a session change. Settings asked for in a gap have to survive it,
16
- * and every effect that appears has to announce itself, because the JS side reads the settings once
17
- * at startup and otherwise never learns the equalizer arrived.
18
- */
19
13
  class EqualizerControllerTest {
20
14
 
21
- /** Records what the controller does to an effect, and reports whatever it is told to report. */
22
15
  private class FakeEffect(override val audioSessionId: Int) : EqualizerEffect {
23
16
  var reported: EqualizerSettings? = equalizerSettings(preset = null, enabled = false)
24
17
  var callback: ((EqualizerSettings) -> Unit)? = null
@@ -119,8 +112,6 @@ class EqualizerControllerTest {
119
112
 
120
113
  fixture.controller.onAudioSessionChanged(42)
121
114
 
122
- // The effect only gets the callback once the restore is done, so the intermediate states of a
123
- // multi-step restore never reach the caller.
124
115
  assertEquals("emitted", 1, fixture.emitted.size)
125
116
  assertTrue("callback wired", fixture.created.single().callback != null)
126
117
  }
@@ -17,13 +17,12 @@ import org.robolectric.RobolectricTestRunner
17
17
  import org.robolectric.RuntimeEnvironment
18
18
  import org.robolectric.Shadows.shadowOf
19
19
 
20
- // Robolectric: a MediaSession needs the framework.
21
20
  @RunWith(RobolectricTestRunner::class)
22
21
  class LiveSeekCommandTest {
23
22
 
24
23
  private val app = RuntimeEnvironment.getApplication()
25
24
  private val exoPlayer = ExoPlayer.Builder(app).build()
26
- // A controller sees the session's grant intersected with the player's own commands, and an empty
25
+ // A controller sees the session's grant intersected with the player's commands, and an empty
27
26
  // player cannot seek, so this one offers every command to leave only the session's grant.
28
27
  private val session =
29
28
  MediaSession.Builder(
@@ -5,15 +5,6 @@ import org.junit.Assert.assertArrayEquals
5
5
  import org.junit.Assert.assertTrue
6
6
  import org.junit.Test
7
7
 
8
- /**
9
- * Guards the slot preference lists handed to Media3.
10
- *
11
- * The invariant that matters is the OVERFLOW fallback: every flattening keeps a button only if it
12
- * won SLOT_BACK, won SLOT_FORWARD, or names SLOT_OVERFLOW. A slot that stops naming OVERFLOW
13
- * silently deletes its button from the notification and the car the moment its primary position is
14
- * unavailable, so the loop below asserts the property for every slot rather than only today's
15
- * three.
16
- */
17
8
  class MediaSessionSlotMappingTest {
18
9
 
19
10
  @Test
@@ -17,12 +17,6 @@ import org.junit.Assert.assertNull
17
17
  import org.junit.Assert.assertTrue
18
18
  import org.junit.Test
19
19
 
20
- /**
21
- * Tests the Now Playing rendering pipeline through a fake [NowPlayingSurface]: the flash >
22
- * override > formatter > track precedence, the publish dedupe, the stale-result guards (render
23
- * generation + track-id keying), timed-metadata reruns, the once-per-track artwork keying, and the
24
- * flash revert timing — all previously untestable inside Player.kt.
25
- */
26
20
  class NowPlayingUpdaterTest {
27
21
 
28
22
  private class FakeSurface : NowPlayingSurface {
@@ -99,7 +93,7 @@ class NowPlayingUpdaterTest {
99
93
  updater.updateNowPlaying(update(title = "Song"))
100
94
 
101
95
  assertEquals("Song", surface.stamps.last().title)
102
- assertEquals("Place", surface.stamps.last().secondary) // falls back per-field
96
+ assertEquals("Place", surface.stamps.last().secondary)
103
97
  assertEquals("Song", updater.getNowPlaying()?.title)
104
98
  }
105
99
 
@@ -201,7 +195,7 @@ class NowPlayingUpdaterTest {
201
195
  runCurrent()
202
196
 
203
197
  assertEquals(listOf("Station", "Live Song"), surface.stamps.map { it.title })
204
- assertEquals("Place", surface.stamps.last().secondary) // per-field fallback
198
+ assertEquals("Place", surface.stamps.last().secondary)
205
199
  }
206
200
 
207
201
  @Test
@@ -437,10 +431,10 @@ class NowPlayingUpdaterTest {
437
431
  update(title = "Stale")
438
432
  }
439
433
 
440
- updater.render() // launches the gated formatter
441
- updater.flashNowPlaying(update(title = "Flash!"), durationMs = 60_000.0) // newer generation
434
+ updater.render()
435
+ updater.flashNowPlaying(update(title = "Flash!"), durationMs = 60_000.0) // the newer render
442
436
  runCurrent()
443
- gate.complete(Unit) // stale formatter completes after the flash
437
+ gate.complete(Unit)
444
438
  runCurrent()
445
439
 
446
440
  assertEquals("Flash!", surface.stamps.last().title)
@@ -459,7 +453,7 @@ class NowPlayingUpdaterTest {
459
453
  updater.flashNowPlaying(update(title = "Flash!"), durationMs = 60_000.0)
460
454
  runCurrent()
461
455
 
462
- updater.render() // e.g. a playback-state change mid-flash
456
+ updater.render()
463
457
  runCurrent()
464
458
 
465
459
  assertEquals(0, invocations)
@@ -476,7 +470,7 @@ class NowPlayingUpdaterTest {
476
470
  }
477
471
 
478
472
  updater.render()
479
- surface.currentTrack = track("B", src = "https://s/b.mp3") // fast skip
473
+ surface.currentTrack = track("B", src = "https://s/b.mp3")
480
474
  gate.complete(Unit)
481
475
  runCurrent()
482
476
 
@@ -519,7 +513,7 @@ class NowPlayingUpdaterTest {
519
513
  runCurrent()
520
514
  assertEquals("Song X", seenTimed.last())
521
515
 
522
- updater.clearOverride() // track change clears timed metadata
516
+ updater.clearOverride() // as on a track change
523
517
  updater.render()
524
518
  runCurrent()
525
519
  assertNull(seenTimed.last())
@@ -539,7 +533,7 @@ class NowPlayingUpdaterTest {
539
533
 
540
534
  updater.render()
541
535
  runCurrent()
542
- updater.updateNowPlaying(update(title = "Song")) // re-render, same track
536
+ updater.updateNowPlaying(update(title = "Song")) // re-renders the same track
543
537
  runCurrent()
544
538
 
545
539
  assertEquals(1, surface.artworkResolveCount)
@@ -563,7 +557,6 @@ class NowPlayingUpdaterTest {
563
557
  runCurrent()
564
558
  assertEquals(2, surface.artworkResolveCount)
565
559
 
566
- // The config runs for id-less tracks too — no blanket skip.
567
560
  surface.currentTrack = track("C", id = null, src = "https://s/c.mp3")
568
561
  updater.render()
569
562
  runCurrent()
@@ -583,7 +576,7 @@ class NowPlayingUpdaterTest {
583
576
 
584
577
  updater.render()
585
578
  runCurrent()
586
- updater.updateNowPlaying(update(title = "Song")) // re-render, same track
579
+ updater.updateNowPlaying(update(title = "Song")) // re-renders the same track
587
580
  runCurrent()
588
581
 
589
582
  assertEquals(1, surface.artworkResolveCount)
@@ -605,7 +598,7 @@ class NowPlayingUpdaterTest {
605
598
  assertEquals(1, surface.artworkResolveCount)
606
599
 
607
600
  surface.hasNowPlayingArtworkConfig = false
608
- updater.updateNowPlaying(update(title = "x")) // re-render without config resets the keying
601
+ updater.updateNowPlaying(update(title = "x")) // a render without the config
609
602
  runCurrent()
610
603
 
611
604
  surface.hasNowPlayingArtworkConfig = true
@@ -624,8 +617,8 @@ class NowPlayingUpdaterTest {
624
617
  }
625
618
  val updater = NowPlayingUpdater(surface, backgroundScope)
626
619
 
627
- updater.render() // schedules the artwork resolve
628
- surface.currentTrack = track("B", id = "b", src = "https://s/b.mp3") // skip before it lands
620
+ updater.render()
621
+ surface.currentTrack = track("B", id = "b", src = "https://s/b.mp3") // before the resolve lands
629
622
  runCurrent()
630
623
 
631
624
  assertTrue(surface.artworkStamps.isEmpty())
@@ -642,8 +635,8 @@ class NowPlayingUpdaterTest {
642
635
  }
643
636
  val updater = NowPlayingUpdater(surface, backgroundScope)
644
637
 
645
- updater.render() // schedules the artwork resolve
646
- // Skip to another id-less track before it lands: identity (src) keying must catch it.
638
+ updater.render()
639
+ // Before the resolve lands.
647
640
  surface.currentTrack = track("B", id = null, src = "https://s/b.mp3")
648
641
  runCurrent()
649
642
 
@@ -11,7 +11,7 @@ import org.junit.Test
11
11
  import org.junit.runner.RunWith
12
12
  import org.robolectric.RobolectricTestRunner
13
13
 
14
- // Robolectric: building the DataSpec that InvalidResponseCodeException requires goes through
14
+ // Robolectric: the DataSpec that InvalidResponseCodeException requires goes through
15
15
  // android.net.Uri, which is unimplemented on a bare JVM.
16
16
  @RunWith(RobolectricTestRunner::class)
17
17
  class PlaybackErrorClassifierTest {
@@ -30,11 +30,6 @@ class PlaybackErrorClassifierTest {
30
30
 
31
31
  // MARK: - Offline
32
32
 
33
- /**
34
- * ExoPlayer reports a dead radio and a dead wifi connection with the same codes, so an offline
35
- * device must win over whatever the code says — this is the one classification the error itself
36
- * can never carry.
37
- */
38
33
  @Test
39
34
  fun `offline device outranks the error code`() {
40
35
  val error = exception(PlaybackException.ERROR_CODE_IO_BAD_HTTP_STATUS, httpException(404))
@@ -53,7 +48,6 @@ class PlaybackErrorClassifierTest {
53
48
  )
54
49
  }
55
50
 
56
- /** media3 nests the response exception under wrapper exceptions rather than as a direct cause. */
57
51
  @Test
58
52
  fun `http status is recovered when nested deeper in the chain`() {
59
53
  val nested = IOException("loading failed", httpException(404))
@@ -88,10 +82,6 @@ class PlaybackErrorClassifierTest {
88
82
  }
89
83
  }
90
84
 
91
- /**
92
- * A recovered status must win over the code-based mapping: `ERROR_CODE_IO_BAD_HTTP_STATUS` alone
93
- * says only "non-2xx", which would land in UNKNOWN and lose the dead-station signal.
94
- */
95
85
  @Test
96
86
  fun `recovered status outranks the error code mapping`() {
97
87
  val error = exception(PlaybackException.ERROR_CODE_IO_BAD_HTTP_STATUS, httpException(404))
@@ -130,11 +120,6 @@ class PlaybackErrorClassifierTest {
130
120
 
131
121
  // MARK: - Retrying load errors
132
122
 
133
- /**
134
- * Load errors are raw IOExceptions from the transport layer; the policy only retries network
135
- * ones, so the advisory classification is UNREACHABLE unless the device is offline or the server
136
- * actually answered.
137
- */
138
123
  @Test
139
124
  fun `retrying transport failure is unreachable`() {
140
125
  val error =
@@ -142,8 +127,6 @@ class PlaybackErrorClassifierTest {
142
127
  assertEquals(PlaybackErrorKind.UNREACHABLE, error.kind)
143
128
  assertEquals(true, error.retrying)
144
129
  assertNull(error.statusCode)
145
- // Stable across attempts — the raw exception message varies between retries of the
146
- // same outage, which would defeat the report dedupe.
147
130
  assertEquals("Could not reach the stream host", error.message)
148
131
  }
149
132
 
@@ -155,7 +138,6 @@ class PlaybackErrorClassifierTest {
155
138
  assertEquals(true, error.retrying)
156
139
  }
157
140
 
158
- /** The HTTP status is dug out of the cause chain and mapped through the shared status table. */
159
141
  @Test
160
142
  fun `retrying HTTP failure carries the status`() {
161
143
  val error = PlaybackErrorClassifier.retryingLoadError(httpException(503), online = true)
@@ -165,11 +147,6 @@ class PlaybackErrorClassifierTest {
165
147
  assertEquals("Server responded with HTTP 503", error.message)
166
148
  }
167
149
 
168
- /**
169
- * Codes that name no cause must stay UNKNOWN. Guessing them into a friendlier bucket would put a
170
- * wrong line on the listener's screen and poison the telemetry aggregates that motivated the
171
- * classification in the first place.
172
- */
173
150
  @Test
174
151
  fun `codes without evidence stay unknown`() {
175
152
  val unevidenced =
@@ -5,11 +5,6 @@ import com.margelo.nitro.audiobrowser.PlaybackState
5
5
  import org.junit.Assert.assertEquals
6
6
  import org.junit.Test
7
7
 
8
- /**
9
- * Truth table for the playback state transitions — the Android analog of iOS's
10
- * `nextPlaybackState(from:on:)`, previously inline branching in PlayerListener.onEvents. Guards
11
- * here are state-related; context guards arrive as event fields captured at the call site.
12
- */
13
8
  class PlaybackStateMachineTest {
14
9
 
15
10
  private fun on(
@@ -35,8 +30,6 @@ class PlaybackStateMachineTest {
35
30
 
36
31
  @Test
37
32
  fun `ready is emitted only while paused, suppressed while playing`() {
38
- // Paused (shouldPlayWhenReady=false): READY is the settled signal consumers need to
39
- // clear a spinner from a buffer that finished while paused (mono#3325).
40
33
  assertEquals(
41
34
  listOf(PlaybackState.READY),
42
35
  on(
@@ -48,8 +41,6 @@ class PlaybackStateMachineTest {
48
41
  from = PlaybackState.BUFFERING,
49
42
  ),
50
43
  )
51
- // Playing (shouldPlayWhenReady=true): READY is a transient before PLAYING — suppressed
52
- // so consumers don't flash a settled/non-loading state mid-startup.
53
44
  assertEquals(
54
45
  emptyList<PlaybackState>(),
55
46
  on(
@@ -72,8 +63,6 @@ class PlaybackStateMachineTest {
72
63
  shouldPlayWhenReady = false,
73
64
  )
74
65
  assertEquals(listOf(PlaybackState.NONE), on(idle, from = PlaybackState.PLAYING))
75
- // A terminal error idles ExoPlayer; transitioning to NONE would clear the ERROR state the
76
- // session is rendering. Same for an explicit stop.
77
66
  assertEquals(emptyList<PlaybackState>(), on(idle, from = PlaybackState.ERROR))
78
67
  assertEquals(emptyList<PlaybackState>(), on(idle, from = PlaybackState.STOPPED))
79
68
  }
@@ -90,7 +79,6 @@ class PlaybackStateMachineTest {
90
79
  )
91
80
  ),
92
81
  )
93
- // An emptied queue also reports STATE_ENDED; that is "nothing loaded", not "played to end".
94
82
  assertEquals(
95
83
  listOf(PlaybackState.NONE),
96
84
  on(
@@ -105,9 +93,6 @@ class PlaybackStateMachineTest {
105
93
 
106
94
  @Test
107
95
  fun `recovery out of error is allowed`() {
108
- // The asymmetry that makes the session-error mask work: IDLE is suppressed from ERROR (the
109
- // error keeps rendering), but a real recovery (re-prepare reaching BUFFERING/READY) must
110
- // transition out of ERROR.
111
96
  assertEquals(
112
97
  listOf(PlaybackState.BUFFERING),
113
98
  on(
@@ -119,7 +104,6 @@ class PlaybackStateMachineTest {
119
104
  from = PlaybackState.ERROR,
120
105
  ),
121
106
  )
122
- // A paused recovery reaching READY (shouldPlayWhenReady=false) also leaves ERROR.
123
107
  assertEquals(
124
108
  listOf(PlaybackState.READY),
125
109
  on(
@@ -155,8 +139,6 @@ class PlaybackStateMachineTest {
155
139
  listOf(PlaybackState.LOADING),
156
140
  on(PlaybackEvent.MediaItemTransition(hasTrack = true, isPlaying = false)),
157
141
  )
158
- // Already audibly playing (gapless auto-advance): run the full burst so consumers see the
159
- // canonical sequence rather than staying stuck on LOADING.
160
142
  assertEquals(
161
143
  listOf(PlaybackState.LOADING, PlaybackState.READY, PlaybackState.PLAYING),
162
144
  on(PlaybackEvent.MediaItemTransition(hasTrack = true, isPlaying = true)),
@@ -182,8 +164,6 @@ class PlaybackStateMachineTest {
182
164
  )
183
165
  assertEquals(listOf(PlaybackState.PAUSED), on(paused, from = PlaybackState.PLAYING))
184
166
  assertEquals(emptyList<PlaybackState>(), on(paused, from = PlaybackState.STOPPED))
185
- // ENDED is terminal the same way: dropping the intent after a natural end (the
186
- // clear at ENDED, or a dead toggle press) must not re-report the state as PAUSED.
187
167
  assertEquals(emptyList<PlaybackState>(), on(paused, from = PlaybackState.ENDED))
188
168
  assertEquals(
189
169
  emptyList<PlaybackState>(),
@@ -10,12 +10,6 @@ import org.junit.Test
10
10
  import org.junit.runner.RunWith
11
11
  import org.robolectric.RobolectricTestRunner
12
12
 
13
- /**
14
- * The bespoke org.json persistence of the resumption track. ADR 0011: the style block and
15
- * `disabled` survive process death (a restored queue keeps its visible fidelity), and a snapshot
16
- * written before the block model — `style` as an enum-name string — restores without a declaration
17
- * rather than failing.
18
- */
19
13
  @RunWith(RobolectricTestRunner::class)
20
14
  class PlaybackStateStoreTrackJsonTest {
21
15
 
@@ -47,6 +41,7 @@ class PlaybackStateStoreTrackJsonTest {
47
41
 
48
42
  @Test
49
43
  fun `a pre-block snapshot with a string style restores without a declaration`() {
44
+ // Snapshots written before the block model (ADR 0011) store `style` as an enum-name string.
50
45
  val restored = PlaybackStateStore.trackFromJson("""{"title":"X","src":"s","style":"LIST"}""")
51
46
 
52
47
  assertEquals("X", restored?.title)