react-native-audio-browser 0.2.0-next.53 → 0.2.0-next.54

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (329) hide show
  1. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  2. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  3. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  5. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  6. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  7. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  8. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  9. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  10. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  11. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  12. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  13. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  15. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  16. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  17. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  18. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  19. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  20. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  21. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  22. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  23. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  24. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  25. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  26. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  27. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  28. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  29. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  30. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  31. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  32. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  33. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  34. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  35. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  36. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  37. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  38. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  39. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  40. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  41. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  42. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  43. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  45. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  46. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  50. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  51. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  52. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  53. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  54. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  55. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  56. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  58. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  59. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  60. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  61. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  63. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  64. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +28 -48
  66. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  67. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  68. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  71. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  78. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  80. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  81. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  82. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  84. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  85. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  86. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  90. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  91. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  92. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  93. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  94. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  96. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  97. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  98. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  99. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  100. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  102. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  103. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  104. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  105. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  106. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  107. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  108. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  109. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  110. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  111. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  112. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  113. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  114. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  115. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  116. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  121. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  122. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  123. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  124. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  125. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  126. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  127. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  128. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  129. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  130. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  131. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  132. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  133. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  134. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  135. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  136. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  137. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  138. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  139. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  143. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +2 -2
  144. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  145. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  146. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +5 -1
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  149. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  150. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  151. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  152. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  153. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  154. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  155. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +9 -10
  156. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +0 -1
  157. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  158. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  159. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  167. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  168. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  169. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  170. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  172. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  174. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  175. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  177. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  178. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  179. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  180. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  181. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  183. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  184. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  185. package/ios/AVPlayerEngine.swift +13 -21
  186. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  187. package/ios/Browser/BrowseGate.swift +7 -8
  188. package/ios/Browser/BrowserConfig.swift +19 -34
  189. package/ios/Browser/BrowserError.swift +0 -1
  190. package/ios/Browser/BrowserManager.swift +29 -75
  191. package/ios/Browser/BrowserPathHelper.swift +13 -93
  192. package/ios/Browser/FavoriteSet.swift +7 -10
  193. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  194. package/ios/Browser/JsonModels.swift +11 -51
  195. package/ios/Browser/NavigationErrorState.swift +3 -2
  196. package/ios/Browser/PageResolver.swift +13 -23
  197. package/ios/Browser/RequestLayer.swift +16 -20
  198. package/ios/Browser/RequestPipeline.swift +33 -43
  199. package/ios/Browser/SearchDrillIn.swift +7 -13
  200. package/ios/Browser/SectionScope.swift +14 -26
  201. package/ios/Browser/SimpleRouter.swift +8 -15
  202. package/ios/Browser/StyleResolver.swift +12 -29
  203. package/ios/Browser/TabBarEntries.swift +6 -11
  204. package/ios/Browser/TrackIdTemplate.swift +6 -14
  205. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  206. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  207. package/ios/CarPlay/CarPlayController.swift +4 -4
  208. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  209. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  210. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  211. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  212. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  213. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  214. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  215. package/ios/CarPlay/CarPlaySession.swift +13 -17
  216. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  217. package/ios/CarPlay/IntentHandlers.swift +3 -5
  218. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  219. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  220. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  221. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  222. package/ios/CarPlay/SectionPresentation.swift +18 -28
  223. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  224. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  225. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  226. package/ios/Extension/CxxVectorConformances.swift +4 -16
  227. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  228. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  229. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  230. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  231. package/ios/Extension/SearchParams+Query.swift +4 -4
  232. package/ios/Extension/Section+Copying.swift +3 -6
  233. package/ios/Extension/String+IcyCharset.swift +5 -5
  234. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  235. package/ios/Extension/Track+AVPlayer.swift +1 -2
  236. package/ios/Extension/Track+Copying.swift +2 -8
  237. package/ios/Extension/Track+Identity.swift +4 -9
  238. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  239. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  240. package/ios/Extension/Variant+Artwork.swift +8 -22
  241. package/ios/Http/HttpClient.swift +3 -3
  242. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  243. package/ios/HybridAudioBrowser+Options.swift +6 -9
  244. package/ios/HybridAudioBrowser+Player.swift +8 -16
  245. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  246. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  247. package/ios/HybridAudioBrowser.swift +54 -79
  248. package/ios/Model/NitroTypeStubs.swift +15 -22
  249. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  250. package/ios/Model/RemoteCommand.swift +2 -2
  251. package/ios/Model/TrackPlayerError.swift +9 -22
  252. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  253. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  254. package/ios/Observer/ItemObserver.swift +7 -5
  255. package/ios/Observer/PlayerObserver.swift +5 -5
  256. package/ios/PlaybackEvent.swift +2 -2
  257. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  258. package/ios/Player/AudioSessionController.swift +14 -15
  259. package/ios/Player/DeferredSeek.swift +2 -2
  260. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  261. package/ios/Player/ErrorStatus.swift +8 -7
  262. package/ios/Player/MediaLoader.swift +20 -24
  263. package/ios/Player/NowPlayingLines.swift +1 -4
  264. package/ios/Player/NowPlayingUpdater.swift +35 -61
  265. package/ios/Player/PersistedPlaybackState.swift +1 -2
  266. package/ios/Player/PlaybackFailure.swift +20 -24
  267. package/ios/Player/PlaybackPersistence.swift +5 -6
  268. package/ios/Player/PlaybackStateMachine.swift +8 -11
  269. package/ios/Player/PlaybackTimer.swift +8 -11
  270. package/ios/Player/Player.swift +6 -13
  271. package/ios/Player/PlayerEngine.swift +20 -20
  272. package/ios/Player/PlayerStatusTypes.swift +1 -2
  273. package/ios/Player/QueueManager.swift +23 -67
  274. package/ios/Player/RetryLoop.swift +39 -50
  275. package/ios/Player/ShuffleOrder.swift +17 -57
  276. package/ios/Player/SleepTimerManager.swift +13 -28
  277. package/ios/Player/VolumeFader.swift +16 -16
  278. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  279. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  280. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  281. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  282. package/ios/Tests/DeferredSeekTests.swift +1 -3
  283. package/ios/Tests/EmitterTests.swift +0 -1
  284. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  285. package/ios/Tests/FavoriteSetTests.swift +1 -0
  286. package/ios/Tests/GenerationMemoTests.swift +2 -2
  287. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  288. package/ios/Tests/JsonModelsTests.swift +5 -12
  289. package/ios/Tests/LRUCacheTests.swift +1 -5
  290. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  291. package/ios/Tests/MediaLoaderTests.swift +3 -12
  292. package/ios/Tests/ObserverTests.swift +3 -3
  293. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  294. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  295. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  296. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  297. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  298. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  299. package/ios/Tests/PlayerTests.swift +53 -88
  300. package/ios/Tests/PlayingStateTests.swift +0 -1
  301. package/ios/Tests/QueueManagerTests.swift +30 -80
  302. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  303. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  304. package/ios/Tests/RetryLoopTests.swift +12 -35
  305. package/ios/Tests/SearchDrillInTests.swift +4 -5
  306. package/ios/Tests/SectionPresentationTests.swift +3 -16
  307. package/ios/Tests/SectionScopeTests.swift +3 -6
  308. package/ios/Tests/SimpleRouterTests.swift +1 -5
  309. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  310. package/ios/Tests/StyleResolverTests.swift +4 -13
  311. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  312. package/ios/Tests/Support/TestTypes.swift +5 -15
  313. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  314. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  315. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  316. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  317. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  318. package/ios/Tests/TrackSelectorTests.swift +3 -15
  319. package/ios/TrackSelector.swift +13 -25
  320. package/ios/Util/ArtworkFreshness.swift +6 -6
  321. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  322. package/ios/Util/ConcurrentMap.swift +2 -2
  323. package/ios/Util/Emitter.swift +8 -13
  324. package/ios/Util/NetworkMonitor.swift +4 -6
  325. package/ios/Util/OutputPicker.swift +1 -1
  326. package/ios/Util/ReadyValue.swift +3 -2
  327. package/ios/Util/SFSymbolRenderer.swift +17 -30
  328. package/ios/Util/SVGProcessor.swift +5 -9
  329. package/package.json +1 -1
@@ -24,7 +24,6 @@ struct PlaybackFailureReportedErrorTests {
24
24
  #expect(reported(URLError(.notConnectedToInternet)) == .notConnectedToInternet)
25
25
  }
26
26
 
27
- /// Both fallbacks pin that `fallback` is plumbed, not hardcoded.
28
27
  @Test func anUnclassifiableErrorIsTheFallback() {
29
28
  #expect(reported(URLError(.badURL)) == .playbackFailed)
30
29
  #expect(reported(URLError(.badURL), fallback: .failedToLoadKeyValue) == .failedToLoadKeyValue)
@@ -36,7 +35,7 @@ struct PlaybackFailureReportedErrorTests {
36
35
  #expect(reported(URLError(code)) == .hostUnreachable)
37
36
  }
38
37
 
39
- /// AVFoundation hands back plain NSErrors in NSURLErrorDomain rather than bridged URLErrors.
38
+ /// AVFoundation hands back plain NSErrors in NSURLErrorDomain, not bridged URLErrors.
40
39
  @Test func anUnbridgedURLDomainErrorIsClassified() {
41
40
  #expect(reported(NSError(domain: NSURLErrorDomain, code: URLError.Code.cannotFindHost.rawValue)) == .hostUnreachable)
42
41
  }
@@ -50,7 +49,7 @@ struct PlaybackFailureReportedErrorTests {
50
49
  #expect(reported(nil) == .playbackFailed)
51
50
  }
52
51
 
53
- /// No response arrived, so a status left in the error log must not outrank the transport error.
52
+ /// No response arrived, so a status left in the error log belongs to an earlier attempt.
54
53
  @Test func aTransportErrorOutranksAStatus() {
55
54
  #expect(reported(URLError(.notConnectedToInternet), status: 500) == .notConnectedToInternet)
56
55
  }
@@ -59,7 +58,7 @@ struct PlaybackFailureReportedErrorTests {
59
58
  #expect(reported(URLError(.badURL), status: 500) == .httpStatus(500))
60
59
  }
61
60
 
62
- /// The server's answer beats "the decoder choked", a symptom of being handed an error page.
61
+ /// An undecodable body is the symptom of being handed an error page; the status is the cause.
63
62
  @Test func aStatusOutranksUnplayableMedia() {
64
63
  #expect(reported(avError(.fileFormatNotRecognized), status: 404) == .httpStatus(404))
65
64
  }
@@ -72,7 +71,6 @@ struct PlaybackFailureReportedErrorTests {
72
71
  #expect(reported(avError(code)) == .trackWasUnplayable)
73
72
  }
74
73
 
75
- /// In-domain is not enough: `AVError.unknown` tells us nothing.
76
74
  @Test func anUnrelatedAVErrorIsTheFallback() {
77
75
  #expect(reported(avError(.unknown)) == .playbackFailed)
78
76
  }
@@ -80,13 +78,13 @@ struct PlaybackFailureReportedErrorTests {
80
78
 
81
79
  @Suite("PlaybackFailure: retrying")
82
80
  struct PlaybackFailureRetryTests {
83
- /// The status, read off the error log, outranks the opaque error.
81
+ /// The status, read off the error log, decides over the opaque CoreMedia error.
84
82
  @Test(arguments: [408, 429, 500, 502, 503, 504])
85
83
  func aRetryableStatusRetries(status: Int) {
86
84
  #expect(retryable(NSError(domain: "CoreMediaErrorDomain", code: -12660), status: status))
87
85
  }
88
86
 
89
- /// A retry cannot conjure content that isn't there, whatever the error says.
87
+ /// The status decides over a timeout that would retry on its own.
90
88
  @Test(arguments: [400, 401, 403, 404, 410, 451])
91
89
  func aPermanentStatusDoesNotRetry(status: Int) {
92
90
  #expect(!retryable(URLError(.timedOut), status: status))
@@ -100,13 +98,11 @@ struct PlaybackFailureRetryTests {
100
98
  #expect(!retryable(URLError(.badURL)))
101
99
  }
102
100
 
103
- /// An opaque CoreMedia failure without a status used to be terminal, so a station that dropped
104
- /// mid-song never came back on iOS while Android reconnected.
105
101
  @Test func anOpaqueCoreMediaErrorRetries() {
106
102
  #expect(retryable(NSError(domain: "CoreMediaErrorDomain", code: -12939)))
107
103
  }
108
104
 
109
- /// `AVError.unknown` wraps transport failures, so it stays retryable.
105
+ /// `AVError.unknown` is what AVFoundation wraps transport failures in.
110
106
  @Test func avErrorUnknownRetries() {
111
107
  #expect(retryable(avError(.unknown)))
112
108
  }
@@ -119,8 +115,6 @@ struct PlaybackFailureRetryTests {
119
115
  #expect(!retryable(avError(code)))
120
116
  }
121
117
 
122
- /// A failure reported as unplayable is never also retried, except a decoder that is only
123
- /// temporarily unavailable.
124
118
  @Test(arguments: [
125
119
  AVError.Code.fileFormatNotRecognized, .failedToParse, .decoderNotFound, .formatUnsupported,
126
120
  .contentIsUnavailable,
@@ -134,7 +128,7 @@ struct PlaybackFailureRetryTests {
134
128
  #expect(retryable(avError(.decoderTemporarilyUnavailable)))
135
129
  }
136
130
 
137
- /// AVFoundation wraps the real cause, so the chain of underlying errors is walked.
131
+ /// AVFoundation wraps the real cause in `NSUnderlyingErrorKey`.
138
132
  @Test func anUnderlyingURLErrorDecides() {
139
133
  let wrappingFatal = NSError(
140
134
  domain: AVFoundationErrorDomain, code: AVError.unknown.rawValue,
@@ -148,8 +142,6 @@ struct PlaybackFailureRetryTests {
148
142
  #expect(retryable(wrappingTransient))
149
143
  }
150
144
 
151
- /// The report reads the same chain as the retry decision, so a wrapped cause that stops
152
- /// retrying is also what is reported.
153
145
  @Test func aWrappedCauseIsWhatIsReported() {
154
146
  let wrappedUnplayable = NSError(
155
147
  domain: AVFoundationErrorDomain, code: AVError.unknown.rawValue,
@@ -171,13 +163,13 @@ struct PlaybackFailureRetryTests {
171
163
 
172
164
  @Suite("PlaybackFailure.httpStatusCode(fromErrorStatusCodes:)")
173
165
  struct ErrorLogStatusTests {
174
- /// `errorStatusCode` carries negative OSStatus values in the same field.
166
+ /// `errorStatusCode` also carries negative OSStatus values.
175
167
  @Test func skipsNonHttpStatusCodes() {
176
168
  #expect(PlaybackFailure.httpStatusCode(fromErrorStatusCodes: [-12939, -1008]) == nil)
177
169
  #expect(PlaybackFailure.httpStatusCode(fromErrorStatusCodes: [-12939, 404]) == 404)
178
170
  }
179
171
 
180
- /// A live stream reconnects; older entries describe earlier attempts.
172
+ /// The log is oldest first, and a live stream's reconnects leave earlier attempts' statuses in it.
181
173
  @Test func prefersTheNewestInRangeStatus() {
182
174
  #expect(PlaybackFailure.httpStatusCode(fromErrorStatusCodes: [500, 404]) == 404)
183
175
  #expect(PlaybackFailure.httpStatusCode(fromErrorStatusCodes: [404, 500, -12939]) == 500)
@@ -3,6 +3,7 @@ import Testing
3
3
 
4
4
  @testable import AudioBrowserTestable
5
5
 
6
+ // Serialized: every test clears and writes the same UserDefaults suite.
6
7
  @Suite("PlaybackPersistence", .serialized)
7
8
  @MainActor
8
9
  struct PlaybackPersistenceTests {
@@ -95,17 +95,11 @@ struct AVPlayerPausedTests {
95
95
  #expect(nextPlaybackState(from: .error, on: .avPlayerPaused(hasAsset: true)) == nil)
96
96
  }
97
97
 
98
- /// After a natural end the play intent is cleared, so the call-site
99
- /// `!playWhenReady` gate no longer swallows stray pause observations —
100
- /// without this guard a late timeControlStatus pause would re-report
101
- /// .ended as .paused. (hasAsset: false still maps to .none: an emptied
102
- /// element after ended is "nothing loaded".)
103
98
  @Test func fromEnded_hasAssetTrue_isSuppressed() {
104
99
  #expect(nextPlaybackState(from: .ended, on: .avPlayerPaused(hasAsset: true)) == nil)
105
100
  }
106
101
 
107
102
  @Test func hasAssetFalse_transitionsToNone() {
108
- // hasAsset: false → .none from any non-stopped state
109
103
  let nonStoppedStates = allStates.filter { $0 != .stopped }
110
104
  for state in nonStoppedStates {
111
105
  #expect(
@@ -116,7 +110,6 @@ struct AVPlayerPausedTests {
116
110
  }
117
111
 
118
112
  @Test func hasAssetTrue_transitionsToPaused() {
119
- // hasAsset: true → .paused from states that aren't stopped, error, or ended
120
113
  let validStates = allStates.filter { $0 != .stopped && $0 != .error && $0 != .ended }
121
114
  for state in validStates {
122
115
  #expect(
@@ -137,23 +130,15 @@ struct BufferingSufficientTests {
137
130
  #expect(nextPlaybackState(from: .playing, on: .bufferingSufficient) == nil)
138
131
  }
139
132
 
140
- /// A late playbackLikelyToKeepUp observation after a natural track end must not
141
- /// leave .ended — playWhenReady is still true, so entering .ready would restart
142
- /// playback of the completed track.
143
133
  @Test func fromEnded_isSuppressed() {
144
134
  #expect(nextPlaybackState(from: .ended, on: .bufferingSufficient) == nil)
145
135
  }
146
136
 
147
- /// stop() seeks non-live tracks back to 0 with the asset still loaded, so the
148
- /// buffer refill flips playbackLikelyToKeepUp right after stopping. Leaving
149
- /// .stopped would both surface a wrong state and skip the reload-on-play path
150
- /// (which only triggers from .stopped/.error).
137
+ // stop() seeks a non-live track to 0 with its asset loaded, so a buffer refill follows every stop.
151
138
  @Test func fromStopped_isSuppressed() {
152
139
  #expect(nextPlaybackState(from: .stopped, on: .bufferingSufficient) == nil)
153
140
  }
154
141
 
155
- /// Recovery from .error always goes through a reload (→ .loading); a direct
156
- /// jump to .ready would clear playbackError without recovering anything.
157
142
  @Test func fromError_isSuppressed() {
158
143
  #expect(nextPlaybackState(from: .error, on: .bufferingSufficient) == nil)
159
144
  }
@@ -7,7 +7,7 @@ final class PlaybackTimerTests: XCTestCase {
7
7
  func testNoTicksUntilIntervalSetAndActive() async throws {
8
8
  var ticks = 0
9
9
  let timer = PlaybackTimer(isActive: { $0 == .playing }) { ticks += 1 }
10
- timer.onPlaybackStateChanged(.playing) // no interval yet
10
+ timer.onPlaybackStateChanged(.playing)
11
11
  try await Task.sleep(nanoseconds: 1_200_000_000)
12
12
  XCTAssertEqual(ticks, 0)
13
13
  }
@@ -37,14 +37,13 @@ final class PlaybackTimerTests: XCTestCase {
37
37
  let timer = PlaybackTimer(isActive: { $0 == .playing }) { ticks += 1 }
38
38
  timer.setInterval(1)
39
39
  timer.onPlaybackStateChanged(.playing)
40
- timer.setInterval(nil) // off-switch
40
+ timer.setInterval(nil)
41
41
  let after = ticks
42
42
  try await Task.sleep(nanoseconds: 1_200_000_000)
43
43
  XCTAssertEqual(ticks, after)
44
44
  }
45
45
 
46
46
  func testIsActivePredicateGatesState() async throws {
47
- // A "playing-only" predicate must not tick while buffering.
48
47
  var ticks = 0
49
48
  let timer = PlaybackTimer(isActive: { $0 == .playing }) { ticks += 1 }
50
49
  timer.setInterval(1)
@@ -2,8 +2,6 @@
2
2
  import Foundation
3
3
  import Testing
4
4
 
5
- /// The decisions the Player makes over its engine: seeking, reloading, recovering, and what an
6
- /// engine event leads to.
7
5
  @MainActor
8
6
  private func makeLoading(
9
7
  src: String? = "https://example.com/a.mp3",
@@ -17,7 +15,6 @@ private func makeLoading(
17
15
  return (player, engine, callbacks)
18
16
  }
19
17
 
20
- /// Loaded and playing: the item is in place and audio has started.
21
18
  @MainActor
22
19
  private func makePlaying(live: Bool = false) throws -> (Player, MockPlayerEngine, MockPlayerCallbacks) {
23
20
  let (player, engine, callbacks) = try makeLoading(live: live)
@@ -62,8 +59,6 @@ struct PlayerSeekingTests {
62
59
  #expect(player.deferredSeek.target == 45)
63
60
  }
64
61
 
65
- /// A completion from before a track change belongs to the old item: it reports false and
66
- /// leaves the new track's start position pending.
67
62
  @Test func aCompletionFromBeforeATrackChangeIsDropped() throws {
68
63
  let (player, engine, _) = try makePlaying()
69
64
  engine.seekResult = nil
@@ -73,6 +68,7 @@ struct PlayerSeekingTests {
73
68
  try player.setQueue([Track(id: "t2", src: "https://example.com/b.mp3", title: "B")], startPositionMs: 25000)
74
69
  engine.completeSeeks(true)
75
70
 
71
+ // The old item's seek reports false; the new track's start stays pending.
76
72
  #expect(landed == [false])
77
73
  #expect(player.deferredSeek.target == 25)
78
74
  #expect(player.state == .loading)
@@ -213,8 +209,6 @@ struct PlayerRecoveringTests {
213
209
  #expect(engine.resolveAndLoadCalls.count == loadsBefore + 1)
214
210
  }
215
211
 
216
- /// A restart from a terminal error is a new Load: fresh retry budgets, unproven playback, the
217
- /// primer allowed again; a retry within a Load keeps its Load.
218
212
  @Test func aRestartFromAnErrorBeginsANewLoad() async throws {
219
213
  let (player, engine, _) = try makePlaying()
220
214
  engine.emit(.audioDidStart)
@@ -273,34 +267,35 @@ struct PlayerRecoveringTests {
273
267
  engine.currentTime = 10
274
268
  engine.isPlaybackLikelyToKeepUp = false
275
269
  #expect(player.isStalled)
270
+ // Within Player.stallGraceSeconds.
276
271
  engine.currentTime = 0.2
277
272
  #expect(!player.isStalled)
278
273
  }
279
274
  }
280
275
 
276
+ // Serialized: every test shares makePlayer's "PlayerTests" defaults suite.
281
277
  @Suite("Player - review regressions", .serialized)
282
278
  @MainActor
283
279
  struct PlayerReviewRegressionTests {
284
- /// An end-of-track sleep timer drops the intent while still .playing; the snapshot must still
285
- /// be rewritten on entering .ended, or a cold resume seeks to the end and re-ends.
286
280
  @Test func endingWithTheIntentAlreadyOffSavesPositionZero() throws {
287
281
  UserDefaults(suiteName: "PlayerTests")!.removePersistentDomain(forName: "PlayerTests")
288
282
  let (player, engine, _) = try makePlaying()
289
283
  engine.currentTime = 300
290
284
  engine.duration = 300
291
285
  player.pause()
286
+ // An end-of-track sleep timer drops the intent while still .playing; without the save on
287
+ // entering .ended, a cold resume seeks to the end and re-ends.
292
288
  player.transition(.trackEndedNaturally)
293
289
  let saved = PlaybackPersistence(defaults: UserDefaults(suiteName: "PlayerTests")!) { nil }.load()
294
290
  #expect(saved?.positionMs == 0)
295
291
  }
296
292
 
297
- /// A track change while paused saves the new track at its start, not at the old item's
298
- /// position, which the engine still reports until the new item is prepared.
299
293
  @Test func skippingWhilePausedSavesTheNewTrackAtItsStart() throws {
300
294
  UserDefaults(suiteName: "PlayerTests")!.removePersistentDomain(forName: "PlayerTests")
301
295
  let (player, engine, _) = try makePlaying()
302
296
  try player.add([Track(id: "t2", src: "https://example.com/b.mp3", title: "B")])
303
297
  player.pause()
298
+ // The engine still reports the old item's position until the new item is prepared.
304
299
  engine.currentTime = 1800
305
300
  player.next()
306
301
  let saved = PlaybackPersistence(defaults: UserDefaults(suiteName: "PlayerTests")!) { nil }.load()
@@ -308,22 +303,19 @@ struct PlayerReviewRegressionTests {
308
303
  #expect(saved?.positionMs == 0)
309
304
  }
310
305
 
311
- /// A reload while paused holds its resume position before the loading transition saves the
312
- /// snapshot.
313
306
  @Test func aRetryWhilePausedSavesWhereItWas() throws {
314
307
  UserDefaults(suiteName: "PlayerTests")!.removePersistentDomain(forName: "PlayerTests")
315
308
  let (player, engine, _) = try makePlaying()
316
309
  player.pause()
317
310
  engine.currentTime = 120
318
311
  engine.resumePosition = 120
312
+ // The reload holds its resume position before the loading transition saves the snapshot.
319
313
  player.reloadResolving(startFromCurrentTime: true)
320
314
  let saved = PlaybackPersistence(defaults: UserDefaults(suiteName: "PlayerTests")!) { nil }.load()
321
315
  #expect(saved?.positionMs == 120_000)
322
316
  #expect(player.deferredSeek.target == 120)
323
317
  }
324
318
 
325
- /// A skip whose load fails leaves the previous item in the engine: the snapshot and the restart
326
- /// from the error start the new track at its start, not at the old one's position.
327
319
  @Test func aFailedSkipKeepsTheNewTrackAtItsStart() throws {
328
320
  UserDefaults(suiteName: "PlayerTests")!.removePersistentDomain(forName: "PlayerTests")
329
321
  let (player, engine, _) = try makePlaying()
@@ -331,6 +323,7 @@ struct PlayerReviewRegressionTests {
331
323
  engine.currentTime = 1800
332
324
  engine.resumePosition = 1800
333
325
  player.next()
326
+ // The failed load leaves the previous item, and its position, in the engine.
334
327
  engine.emit(.unplayable)
335
328
  #expect(player.state == .error)
336
329
  let saved = PlaybackPersistence(defaults: UserDefaults(suiteName: "PlayerTests")!) { nil }.load()
@@ -342,8 +335,6 @@ struct PlayerReviewRegressionTests {
342
335
  #expect(player.deferredSeek.target == nil)
343
336
  }
344
337
 
345
- /// A queue's start position is in the snapshot the track change saves, not only in the next
346
- /// periodic save.
347
338
  @Test func aStartPositionIsSavedWithTheTrackChange() throws {
348
339
  UserDefaults(suiteName: "PlayerTests")!.removePersistentDomain(forName: "PlayerTests")
349
340
  let player = makePlayer(retries: false)
@@ -353,14 +344,13 @@ struct PlayerReviewRegressionTests {
353
344
  #expect(player.deferredSeek.target == 30)
354
345
  }
355
346
 
356
- /// Play on a track without a source fails as an invalid source; it never reloads the media
357
- /// loader's last URL, which belongs to an earlier track.
358
347
  @Test func playOnATrackWithoutASourceFailsInsteadOfReloading() throws {
359
348
  let (player, engine, _) = try makePlaying()
360
349
  try player.setQueue([Track(id: "t2", path: "/no-source", src: nil, title: "No source")])
361
350
  #expect(player.state == .error)
362
351
  let resolves = engine.resolveAndLoadCalls.count
363
352
 
353
+ // The media loader's last URL belongs to the earlier track: play must not reload it.
364
354
  player.play()
365
355
 
366
356
  #expect(player.state == .error)
@@ -368,19 +358,18 @@ struct PlayerReviewRegressionTests {
368
358
  #expect(engine.resolveAndLoadCalls.count == resolves)
369
359
  }
370
360
 
371
- /// While nothing plays, a transition alone rewrites the snapshot.
372
361
  @Test func anErrorWhilePausedSavesWhereItStopped() throws {
373
362
  UserDefaults(suiteName: "PlayerTests")!.removePersistentDomain(forName: "PlayerTests")
374
363
  let (player, engine, _) = try makePlaying()
375
364
  player.pause()
376
365
  engine.currentTime = 42
366
+ // Nothing plays, so no periodic save runs: the transition alone rewrites the snapshot.
377
367
  engine.emit(.failed(nil, httpStatusCode: nil))
378
368
  #expect(player.state == .error)
379
369
  let saved = PlaybackPersistence(defaults: UserDefaults(suiteName: "PlayerTests")!) { nil }.load()
380
370
  #expect(saved?.positionMs == 42000)
381
371
  }
382
372
 
383
- /// An active play intent saves the snapshot periodically.
384
373
  @Test func playingSavesPeriodically() async throws {
385
374
  UserDefaults(suiteName: "PlayerTests")!.removePersistentDomain(forName: "PlayerTests")
386
375
  let engine = MockPlayerEngine()
@@ -399,7 +388,6 @@ struct PlayerReviewRegressionTests {
399
388
  player.pause()
400
389
  }
401
390
 
402
- /// A persisted session resumes its settings, then its track at the saved position.
403
391
  @Test func aPersistedSessionResumesWhereItWasSaved() throws {
404
392
  let defaults = UserDefaults(suiteName: "PlayerTests")!
405
393
  defaults.removePersistentDomain(forName: "PlayerTests")
@@ -430,8 +418,6 @@ struct PlayerReviewRegressionTests {
430
418
  #expect(makePlayer(retries: false).persistedSession() == nil)
431
419
  }
432
420
 
433
- /// A track change while the old track loads with a retrying error publishes the new track's
434
- /// loading state without that error.
435
421
  @Test func aTrackChangeClearsTheRetryingErrorOfTheTrackItLeaves() async throws {
436
422
  let (player, engine, callbacks) = try makeLoading()
437
423
  player.retry.shouldRetry = { true }
@@ -446,8 +432,6 @@ struct PlayerReviewRegressionTests {
446
432
  player.retry.cancel()
447
433
  }
448
434
 
449
- /// Leaving an errored track publishes the new track's loading state once, never an error
450
- /// state without its error.
451
435
  @Test func skippingAwayFromAnErrorNeverPublishesAnErrorlessError() throws {
452
436
  let (player, engine, callbacks) = try makeLoading()
453
437
  engine.emit(.unplayable)