react-native-audio-browser 0.2.0-next.53 → 0.2.0-next.54

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (329) hide show
  1. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  2. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  3. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  5. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  6. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  7. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  8. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  9. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  10. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  11. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  12. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  13. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  15. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  16. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  17. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  18. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  19. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  20. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  21. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  22. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  23. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  24. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  25. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  26. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  27. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  28. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  29. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  30. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  31. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  32. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  33. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  34. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  35. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  36. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  37. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  38. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  39. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  40. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  41. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  42. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  43. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  45. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  46. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  50. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  51. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  52. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  53. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  54. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  55. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  56. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  58. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  59. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  60. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  61. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  63. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  64. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +28 -48
  66. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  67. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  68. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  71. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  78. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  80. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  81. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  82. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  84. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  85. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  86. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  90. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  91. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  92. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  93. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  94. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  96. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  97. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  98. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  99. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  100. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  102. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  103. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  104. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  105. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  106. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  107. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  108. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  109. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  110. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  111. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  112. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  113. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  114. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  115. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  116. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  121. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  122. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  123. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  124. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  125. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  126. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  127. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  128. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  129. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  130. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  131. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  132. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  133. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  134. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  135. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  136. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  137. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  138. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  139. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  143. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +2 -2
  144. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  145. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  146. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +5 -1
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  149. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  150. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  151. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  152. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  153. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  154. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  155. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +9 -10
  156. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +0 -1
  157. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  158. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  159. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  167. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  168. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  169. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  170. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  172. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  174. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  175. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  177. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  178. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  179. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  180. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  181. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  183. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  184. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  185. package/ios/AVPlayerEngine.swift +13 -21
  186. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  187. package/ios/Browser/BrowseGate.swift +7 -8
  188. package/ios/Browser/BrowserConfig.swift +19 -34
  189. package/ios/Browser/BrowserError.swift +0 -1
  190. package/ios/Browser/BrowserManager.swift +29 -75
  191. package/ios/Browser/BrowserPathHelper.swift +13 -93
  192. package/ios/Browser/FavoriteSet.swift +7 -10
  193. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  194. package/ios/Browser/JsonModels.swift +11 -51
  195. package/ios/Browser/NavigationErrorState.swift +3 -2
  196. package/ios/Browser/PageResolver.swift +13 -23
  197. package/ios/Browser/RequestLayer.swift +16 -20
  198. package/ios/Browser/RequestPipeline.swift +33 -43
  199. package/ios/Browser/SearchDrillIn.swift +7 -13
  200. package/ios/Browser/SectionScope.swift +14 -26
  201. package/ios/Browser/SimpleRouter.swift +8 -15
  202. package/ios/Browser/StyleResolver.swift +12 -29
  203. package/ios/Browser/TabBarEntries.swift +6 -11
  204. package/ios/Browser/TrackIdTemplate.swift +6 -14
  205. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  206. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  207. package/ios/CarPlay/CarPlayController.swift +4 -4
  208. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  209. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  210. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  211. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  212. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  213. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  214. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  215. package/ios/CarPlay/CarPlaySession.swift +13 -17
  216. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  217. package/ios/CarPlay/IntentHandlers.swift +3 -5
  218. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  219. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  220. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  221. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  222. package/ios/CarPlay/SectionPresentation.swift +18 -28
  223. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  224. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  225. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  226. package/ios/Extension/CxxVectorConformances.swift +4 -16
  227. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  228. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  229. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  230. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  231. package/ios/Extension/SearchParams+Query.swift +4 -4
  232. package/ios/Extension/Section+Copying.swift +3 -6
  233. package/ios/Extension/String+IcyCharset.swift +5 -5
  234. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  235. package/ios/Extension/Track+AVPlayer.swift +1 -2
  236. package/ios/Extension/Track+Copying.swift +2 -8
  237. package/ios/Extension/Track+Identity.swift +4 -9
  238. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  239. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  240. package/ios/Extension/Variant+Artwork.swift +8 -22
  241. package/ios/Http/HttpClient.swift +3 -3
  242. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  243. package/ios/HybridAudioBrowser+Options.swift +6 -9
  244. package/ios/HybridAudioBrowser+Player.swift +8 -16
  245. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  246. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  247. package/ios/HybridAudioBrowser.swift +54 -79
  248. package/ios/Model/NitroTypeStubs.swift +15 -22
  249. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  250. package/ios/Model/RemoteCommand.swift +2 -2
  251. package/ios/Model/TrackPlayerError.swift +9 -22
  252. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  253. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  254. package/ios/Observer/ItemObserver.swift +7 -5
  255. package/ios/Observer/PlayerObserver.swift +5 -5
  256. package/ios/PlaybackEvent.swift +2 -2
  257. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  258. package/ios/Player/AudioSessionController.swift +14 -15
  259. package/ios/Player/DeferredSeek.swift +2 -2
  260. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  261. package/ios/Player/ErrorStatus.swift +8 -7
  262. package/ios/Player/MediaLoader.swift +20 -24
  263. package/ios/Player/NowPlayingLines.swift +1 -4
  264. package/ios/Player/NowPlayingUpdater.swift +35 -61
  265. package/ios/Player/PersistedPlaybackState.swift +1 -2
  266. package/ios/Player/PlaybackFailure.swift +20 -24
  267. package/ios/Player/PlaybackPersistence.swift +5 -6
  268. package/ios/Player/PlaybackStateMachine.swift +8 -11
  269. package/ios/Player/PlaybackTimer.swift +8 -11
  270. package/ios/Player/Player.swift +6 -13
  271. package/ios/Player/PlayerEngine.swift +20 -20
  272. package/ios/Player/PlayerStatusTypes.swift +1 -2
  273. package/ios/Player/QueueManager.swift +23 -67
  274. package/ios/Player/RetryLoop.swift +39 -50
  275. package/ios/Player/ShuffleOrder.swift +17 -57
  276. package/ios/Player/SleepTimerManager.swift +13 -28
  277. package/ios/Player/VolumeFader.swift +16 -16
  278. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  279. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  280. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  281. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  282. package/ios/Tests/DeferredSeekTests.swift +1 -3
  283. package/ios/Tests/EmitterTests.swift +0 -1
  284. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  285. package/ios/Tests/FavoriteSetTests.swift +1 -0
  286. package/ios/Tests/GenerationMemoTests.swift +2 -2
  287. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  288. package/ios/Tests/JsonModelsTests.swift +5 -12
  289. package/ios/Tests/LRUCacheTests.swift +1 -5
  290. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  291. package/ios/Tests/MediaLoaderTests.swift +3 -12
  292. package/ios/Tests/ObserverTests.swift +3 -3
  293. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  294. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  295. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  296. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  297. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  298. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  299. package/ios/Tests/PlayerTests.swift +53 -88
  300. package/ios/Tests/PlayingStateTests.swift +0 -1
  301. package/ios/Tests/QueueManagerTests.swift +30 -80
  302. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  303. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  304. package/ios/Tests/RetryLoopTests.swift +12 -35
  305. package/ios/Tests/SearchDrillInTests.swift +4 -5
  306. package/ios/Tests/SectionPresentationTests.swift +3 -16
  307. package/ios/Tests/SectionScopeTests.swift +3 -6
  308. package/ios/Tests/SimpleRouterTests.swift +1 -5
  309. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  310. package/ios/Tests/StyleResolverTests.swift +4 -13
  311. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  312. package/ios/Tests/Support/TestTypes.swift +5 -15
  313. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  314. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  315. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  316. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  317. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  318. package/ios/Tests/TrackSelectorTests.swift +3 -15
  319. package/ios/TrackSelector.swift +13 -25
  320. package/ios/Util/ArtworkFreshness.swift +6 -6
  321. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  322. package/ios/Util/ConcurrentMap.swift +2 -2
  323. package/ios/Util/Emitter.swift +8 -13
  324. package/ios/Util/NetworkMonitor.swift +4 -6
  325. package/ios/Util/OutputPicker.swift +1 -1
  326. package/ios/Util/ReadyValue.swift +3 -2
  327. package/ios/Util/SFSymbolRenderer.swift +17 -30
  328. package/ios/Util/SVGProcessor.swift +5 -9
  329. package/package.json +1 -1
@@ -2,7 +2,6 @@
2
2
  import Foundation
3
3
  import Testing
4
4
 
5
- /// Helper to build a player with mocks for testing.
6
5
  @MainActor
7
6
  private func makeCoordinator() -> (
8
7
  player: Player,
@@ -18,7 +17,6 @@ private func makeCoordinator() -> (
18
17
  return (player, engine, callbacks, clock)
19
18
  }
20
19
 
21
- /// Helper to load a track into the player's queue so it has a currentTrack.
22
20
  @MainActor
23
21
  private func loadTrack(
24
22
  _ player: Player,
@@ -39,7 +37,7 @@ struct TransitionTests {
39
37
  let (c, eh, _, _) = makeCoordinator()
40
38
  try loadTrack(c)
41
39
  c.setPlayWhenReady(true)
42
- eh.startPlaybackCallCount = 0 // reset from playWhenReady setter
40
+ eh.startPlaybackCallCount = 0
43
41
 
44
42
  c.transition(.bufferingSufficient)
45
43
 
@@ -98,7 +96,6 @@ struct TransitionTests {
98
96
 
99
97
  c.transition(.errorOccurred(.notConnectedToInternet))
100
98
 
101
- // State stays .error but error is updated
102
99
  #expect(c.state == .error)
103
100
  #expect(c.errorStatus.error == .notConnectedToInternet)
104
101
  #expect(cb.playbackChanges.count == 1)
@@ -108,10 +105,6 @@ struct TransitionTests {
108
105
 
109
106
  // MARK: - Retrying Errors
110
107
 
111
- /// Advisory errors from the retry loop: attached to the current non-terminal
112
- /// state via `playerDidChangePlayback`, never a state transition and never a
113
- /// `playerDidError`.
114
- /// Builds a player whose retries reload at once, so the advisory path is what shows.
115
108
  @MainActor
116
109
  private func makeRetrying() -> (
117
110
  Player, RetryLoop, MockPlayerCallbacks,
@@ -125,6 +118,8 @@ private func makeRetrying() -> (
125
118
  return (player, retryHandler, callbacks, engine)
126
119
  }
127
120
 
121
+ /// Retry-loop errors are advisory: they ride on the current state's playbackChanges,
122
+ /// never transition it and never reach playerDidError.
128
123
  @Suite("Player - retrying errors")
129
124
  struct RetryingErrorTests {
130
125
  @Test @MainActor
@@ -140,13 +135,11 @@ struct RetryingErrorTests {
140
135
  #expect(cb.playbackChanges.count == 1)
141
136
  #expect(cb.playbackChanges.last?.state == .loading)
142
137
  #expect(cb.playbackChanges.last?.error?.retrying == true)
143
- // Advisory, not terminal: the error event is reserved for .error.
144
138
  #expect(cb.errorEvents.isEmpty)
145
139
  await c.retry.pendingTask?.value
146
140
  }
147
141
 
148
- /// Every failed attempt re-reports through `handleError`; identical repeats
149
- /// must not re-emit (they'd re-render now-playing every backoff tick).
142
+ /// Each emission re-renders now-playing, so a repeat every backoff tick must not re-emit.
150
143
  @Test @MainActor
151
144
  func repeatedIdenticalFailure_emitsOnce() async {
152
145
  let (c, _, cb, _) = makeRetrying()
@@ -161,8 +154,7 @@ struct RetryingErrorTests {
161
154
  #expect(cb.playbackChanges.count == 1)
162
155
  }
163
156
 
164
- /// While .playing, buffered audio is still audibly fine — the advisory must
165
- /// not replace the song line over working sound (matches Android's guard).
157
+ /// Buffered audio still plays, so the advisory must not replace the song line (as on Android).
166
158
  @Test @MainActor
167
159
  func retryingErrorWhilePlaying_isSuppressed() async {
168
160
  let (c, _, cb, _) = makeRetrying()
@@ -176,8 +168,6 @@ struct RetryingErrorTests {
176
168
  await c.retry.pendingTask?.value
177
169
  }
178
170
 
179
- /// Reaching .ready proves the retry recovered: the advisory error must not
180
- /// survive into the clean state's emission.
181
171
  @Test @MainActor
182
172
  func recovery_clearsTheRetryingError() async {
183
173
  let (c, _, cb, _) = makeRetrying()
@@ -192,8 +182,6 @@ struct RetryingErrorTests {
192
182
  #expect(cb.playbackChanges.last?.error == nil)
193
183
  }
194
184
 
195
- /// Giving up hardens the advisory into a terminal error: same kind, state
196
- /// .error, `retrying` gone.
197
185
  @Test @MainActor
198
186
  func exhaustion_hardensIntoTerminalError() async {
199
187
  let (c, retryHandler, cb, _) = makeRetrying()
@@ -244,7 +232,7 @@ struct EmitStateChangeTests {
244
232
  c.transition(.trackLoading)
245
233
 
246
234
  #expect(cb.errorEvents.count == 1)
247
- #expect(cb.errorEvents.first?.error == nil) // error cleared
235
+ #expect(cb.errorEvents.first?.error == nil)
248
236
  }
249
237
 
250
238
  @Test @MainActor
@@ -272,12 +260,12 @@ struct ObserverGuardTests {
272
260
  c.transition(.avPlayerPlaying)
273
261
  cb.playbackChanges.removeAll()
274
262
  eh.hasLoadedAsset = true
263
+ // Within the last 0.5 s, where Player ignores a pause.
275
264
  eh.currentTime = 99.8
276
265
  eh.duration = 100
277
266
 
278
267
  eh.emit(.timeControlStatus(.paused, waitingForNoItem: false))
279
268
 
280
- // State should remain .playing — the pause near track end is ignored
281
269
  #expect(c.state == .playing)
282
270
  }
283
271
 
@@ -319,7 +307,6 @@ struct ObserverGuardTests {
319
307
 
320
308
  eh.emit(.timeControlStatus(.paused, waitingForNoItem: false))
321
309
 
322
- // playWhenReady is true — pause is ignored (likely buffering/seeking)
323
310
  #expect(c.state == .playing)
324
311
  }
325
312
 
@@ -343,7 +330,7 @@ struct ObserverGuardTests {
343
330
 
344
331
  eh.emit(.timeControlStatus(.waitingToPlayAtSpecifiedRate, waitingForNoItem: false))
345
332
 
346
- #expect(c.state == .playing) // unchanged
333
+ #expect(c.state == .playing)
347
334
  }
348
335
 
349
336
  @Test @MainActor
@@ -410,6 +397,7 @@ struct PlayWhenReadyTests {
410
397
  func true_fromError_triggersReload() throws {
411
398
  let (c, eh, _, _) = makeCoordinator()
412
399
  try loadTrack(c)
400
+ // The engine's position counts only once an item is prepared.
413
401
  eh.emit(.itemPrepared(likelyToKeepUp: false))
414
402
  c.transition(.errorOccurred(.playbackFailed))
415
403
  eh.resumePosition = 42
@@ -417,7 +405,7 @@ struct PlayWhenReadyTests {
417
405
 
418
406
  c.setPlayWhenReady(true)
419
407
 
420
- // A restart from .error is a new Load on a new AVPlayer, resuming where it failed.
408
+ // .error recreates the AVPlayer and resumes where it failed.
421
409
  #expect(eh.recreateCount == 1)
422
410
  #expect(eh.resolveAndLoadCalls.count == resolvesBefore + 1)
423
411
  #expect(c.state == .loading)
@@ -442,7 +430,7 @@ struct PlayWhenReadyTests {
442
430
  @Test @MainActor
443
431
  func true_notLoading_startsPlayback() {
444
432
  let (c, eh, _, _) = makeCoordinator()
445
- c.transition(.bufferingSufficient) // .ready state
433
+ c.transition(.bufferingSufficient)
446
434
 
447
435
  c.setPlayWhenReady(true)
448
436
 
@@ -470,7 +458,6 @@ struct PlayWhenReadyTests {
470
458
 
471
459
  c.setPlayWhenReady(true)
472
460
 
473
- // During loading, should NOT call start/pause
474
461
  #expect(eh.startPlaybackCallCount == 0)
475
462
  #expect(eh.pausePlaybackCallCount == 0)
476
463
  }
@@ -529,12 +516,12 @@ struct SkipAvailabilityCoordinatorTests {
529
516
  func repeatAll_repushesAvailability_atEnd() throws {
530
517
  let (c, eh, _, _) = makeCoordinator()
531
518
  try c.setQueue(Self.multiTrack())
532
- try? c.skipTo(1) // last track
519
+ try? c.skipTo(1)
533
520
  eh.updateSkipAvailabilityCalls.removeAll()
534
521
 
522
+ // Repeat-all wraps, so Next is available again at the last track.
535
523
  c.repeatMode = .queue
536
524
 
537
- // repeat-all wraps, so Next becomes available again at the last track.
538
525
  #expect(eh.updateSkipAvailabilityCalls.last?.canNext == true)
539
526
  #expect(eh.updateSkipAvailabilityCalls.last?.canPrevious == true)
540
527
  }
@@ -553,7 +540,6 @@ struct HandleCurrentTrackChangedTests {
553
540
 
554
541
  try loadTrack(c)
555
542
 
556
- // After loading a track, the error should be cleared
557
543
  #expect(c.errorStatus.error == nil)
558
544
  }
559
545
 
@@ -588,7 +574,7 @@ struct HandleCurrentTrackChangedTests {
588
574
 
589
575
  #expect(cb.activeTrackChanges.count == 1)
590
576
  let event = cb.activeTrackChanges.first!
591
- #expect(event.lastIndex == nil) // first track, no previous
577
+ #expect(event.lastIndex == nil)
592
578
  #expect(event.index == 0)
593
579
  #expect(event.track?.id == "t1")
594
580
  }
@@ -611,11 +597,9 @@ struct HandleTrackDidPlayToEndTimeTests {
611
597
  #expect(eh.startPlaybackCallCount == 1)
612
598
  }
613
599
 
614
- /// The end-of-track sleep timer pauses (clears intent) just before this
615
- /// handler runs — an unguarded replay would resume seconds after the sleep
616
- /// timer paused. Without intent the track settles in .ended, where play()
617
- /// reloads (a bare .paused would park at the end, where play() no-ops).
618
- /// A repeating queue never conceptually ends, so no queue-ended reaches JS.
600
+ /// The end-of-track sleep timer clears the intent just before this handler runs, so replaying
601
+ /// would resume right after it paused. Without intent the track settles in .ended, where play()
602
+ /// reloads. A repeating queue never ends, so no queue-ended event.
619
603
  @Test @MainActor
620
604
  func repeatTrack_withoutIntent_settlesEnded() throws {
621
605
  let (c, eh, cb, _) = makeCoordinator()
@@ -662,10 +646,9 @@ struct HandleTrackDidPlayToEndTimeTests {
662
646
 
663
647
  // MARK: - Natural end drops play intent
664
648
 
665
- /// A natural queue end exhausts the play intent: nothing is left to play, so
666
- /// `playWhenReady` must not stay true. Keeping it inverted the play/pause
667
- /// toggle, held the audio session forever, armed interruption auto-resume into
668
- /// silence, and made play-from-ended a silent no-op.
649
+ /// A natural queue end leaves nothing to play, so `playWhenReady` drops. Held, it would invert
650
+ /// the play/pause toggle, hold the audio session, arm interruption resume into silence, and
651
+ /// leave play() from .ended a no-op.
669
652
  @Suite("Player - natural end drops play intent")
670
653
  struct NaturalEndPlayIntentTests {
671
654
  @Test @MainActor
@@ -690,8 +673,7 @@ struct NaturalEndPlayIntentTests {
690
673
  #expect(eh.scheduleAudioSessionReleaseCount == 1)
691
674
  }
692
675
 
693
- /// play() from .ended must reload from the start — startPlayback() alone is a
694
- /// silent no-op on a player parked at the end of its item.
676
+ /// startPlayback() alone is a silent no-op on a player parked at the end of its item.
695
677
  @Test @MainActor
696
678
  func playAfterNaturalEnd_reloadsFromStart() throws {
697
679
  let (c, eh, _, _) = makeCoordinator()
@@ -706,9 +688,8 @@ struct NaturalEndPlayIntentTests {
706
688
  #expect(c.deferredSeek.target == nil)
707
689
  }
708
690
 
709
- /// The cleared intent opens the call-site `!playWhenReady` gate, so a stray
710
- /// timeControlStatus pause after the end reaches the state machine — the
711
- /// table's .ended guard must hold the state.
691
+ /// The cleared intent opens the call site's `!playWhenReady` gate, so this pause reaches the
692
+ /// state machine; the table's .ended guard must hold the state.
712
693
  @Test @MainActor
713
694
  func strayPauseAfterNaturalEnd_staysEnded() throws {
714
695
  let (c, eh, _, _) = makeCoordinator()
@@ -731,20 +712,18 @@ struct NaturalEndPlayIntentTests {
731
712
  c.handleInterruptionBegan()
732
713
  c.handleInterruptionEnded(shouldResume: true)
733
714
 
734
- #expect(c.playWhenReady == false) // nothing was playing — never resume
715
+ #expect(c.playWhenReady == false)
735
716
  #expect(eh.resolveAndLoadCalls.count == resolvesBefore)
736
717
  }
737
718
  }
738
719
 
739
720
  // MARK: - Healthy playback refills the retry budget
740
721
 
741
- /// Sustained audible playback proves the stream recovered, so the retry
742
- /// window/attempt counters must refill (mirrors Android's healthy-playback
743
- /// refill) — otherwise a long-lived stream permanently loses retry after its
744
- /// first recovered blip.
722
+ /// Sustained playback proves the stream recovered, so the retry budget refills (as on
723
+ /// Android); otherwise a long-lived stream loses retry after its first recovered blip.
745
724
  @Suite("Player - healthy playback resets retry budget")
746
725
  struct HealthyPlaybackRetryResetTests {
747
- /// A player whose retry loop has already executed one retry, so a reset shows.
726
+ /// A nonzero delay skips the retry, leaving the caller to start one that stays pending.
748
727
  @MainActor
749
728
  private func makeAfterOneRetry(delay: TimeInterval = 0) async -> (Player, RetryLoop, MockPlayerEngine) {
750
729
  let retry = makeRetryLoop(delay: delay)
@@ -769,8 +748,7 @@ struct HealthyPlaybackRetryResetTests {
769
748
  #expect(retry.attempts == 0)
770
749
  }
771
750
 
772
- /// reset() cancels a pending retry — firing the refill mid-episode
773
- /// would kill an in-flight reconnect silently (stuck .playing forever).
751
+ /// reset() cancels a pending retry: a refill now would silently kill an in-flight reconnect.
774
752
  @Test @MainActor
775
753
  func refill_skipsWhileRetryIsPending() async {
776
754
  let (player, retry, _) = await makeAfterOneRetry(delay: 1)
@@ -792,10 +770,10 @@ struct HealthyPlaybackRetryResetTests {
792
770
 
793
771
  player.transition(.avPlayerPlaying)
794
772
  let refill = retry.healthyPlaybackTask
795
- player.transition(.avPlayerWaiting) // stalls before the threshold
773
+ player.transition(.avPlayerWaiting)
796
774
 
797
- // Leaving .playing cancels the refill; awaiting the cancelled task is the
798
- // deterministic way to reach the point where it would have fired.
775
+ // Leaving .playing cancels the refill; awaiting the cancelled task reaches, deterministically,
776
+ // the point where it would have fired.
799
777
  await refill?.value
800
778
 
801
779
  #expect(retry.attempts == 1)
@@ -856,7 +834,7 @@ struct SleepTimerFadeTests {
856
834
  clock.advance(to: 20)
857
835
 
858
836
  #expect(c.playWhenReady == false)
859
- #expect(eh.volume == 0.8) // untouched — no fade ran
837
+ #expect(eh.volume == 0.8)
860
838
  }
861
839
 
862
840
  @Test @MainActor
@@ -900,7 +878,6 @@ struct SleepTimerFadeTests {
900
878
 
901
879
  // MARK: - Audio Session Interruptions
902
880
 
903
- /// Helper to drive the player into an actively-playing state.
904
881
  @MainActor
905
882
  private func startPlaying(_ c: Player, _ eh: MockPlayerEngine) throws {
906
883
  try loadTrack(c)
@@ -924,16 +901,15 @@ struct InterruptionTests {
924
901
  #expect(c.playWhenReady == false)
925
902
  }
926
903
 
927
- /// The bug: iOS pauses the AVPlayer first; that `timeControlStatus → paused`
928
- /// is swallowed because `playWhenReady` is still true, so the state stays
929
- /// `.playing`. The interruption handler must force the pause regardless.
904
+ /// iOS pauses the AVPlayer before the interruption arrives; with `playWhenReady` still true
905
+ /// that pause is swallowed, so the handler must force the pause itself.
930
906
  @Test @MainActor
931
907
  func began_afterSwallowedTimeControlPause_stillPauses() throws {
932
908
  let (c, eh, _, _) = makeCoordinator()
933
909
  try startPlaying(c, eh)
934
910
 
935
911
  eh.emit(.timeControlStatus(.paused, waitingForNoItem: false))
936
- #expect(c.state == .playing) // swallowed — the symptom this fix targets
912
+ #expect(c.state == .playing)
937
913
 
938
914
  c.handleInterruptionBegan()
939
915
 
@@ -966,9 +942,8 @@ struct InterruptionTests {
966
942
  #expect(c.playWhenReady == false)
967
943
  }
968
944
 
969
- /// The host gates audio-session reactivation at interruption-end on this:
970
- /// paused-when-interrupted must not grab a non-mixable session for a resume
971
- /// that never happens.
945
+ /// The host gates audio-session reactivation at interruption end on this, so a player paused
946
+ /// when interrupted does not take a non-mixable session for a resume that never comes.
972
947
  @Test @MainActor
973
948
  func willResumeAfterInterruption_reflectsCapturedIntent() throws {
974
949
  let (c, eh, _, _) = makeCoordinator()
@@ -980,13 +955,13 @@ struct InterruptionTests {
980
955
  c.handleInterruptionEnded(shouldResume: false)
981
956
  #expect(c.willResumeAfterInterruption == false)
982
957
 
983
- // Paused before the interruption: no resume will happen.
958
+ // Paused by the first interruption, so nothing to resume.
984
959
  c.handleInterruptionBegan()
985
960
  #expect(c.willResumeAfterInterruption == false)
986
961
  }
987
962
 
988
- /// iOS can deliver nested interruptions (Siri, then a phone call) — a second
989
- /// .began must not re-capture the now-false intent and wipe the resume flag.
963
+ /// iOS nests interruptions (Siri, then a call): a second began must not re-capture the
964
+ /// now-false intent.
990
965
  @Test @MainActor
991
966
  func doubleBegan_preservesResumeIntent() throws {
992
967
  let (c, eh, _, _) = makeCoordinator()
@@ -999,8 +974,8 @@ struct InterruptionTests {
999
974
  #expect(c.playWhenReady == true)
1000
975
  }
1001
976
 
1002
- /// Unplugging headphones during a call is a deliberate output loss — the
1003
- /// call ending must not blast playback from the built-in speaker.
977
+ /// Unplugging headphones during a call is a deliberate output loss: the call's end must not
978
+ /// resume on the built-in speaker.
1004
979
  @Test @MainActor
1005
980
  func routeDisconnectDuringInterruption_cancelsResume() throws {
1006
981
  let (c, eh, _, _) = makeCoordinator()
@@ -1013,8 +988,6 @@ struct InterruptionTests {
1013
988
  #expect(c.playWhenReady == false)
1014
989
  }
1015
990
 
1016
- /// An explicit stop during the interruption is a terminal command — the
1017
- /// interruption-end must not restart playback over it.
1018
991
  @Test @MainActor
1019
992
  func stopDuringInterruption_isNotOverriddenByResume() throws {
1020
993
  let (c, eh, _, _) = makeCoordinator()
@@ -1030,8 +1003,6 @@ struct InterruptionTests {
1030
1003
  #expect(eh.resolveAndLoadCalls.count == resolvesBefore)
1031
1004
  }
1032
1005
 
1033
- /// A user who plays then pauses during the interruption has taken ownership
1034
- /// of the intent — interruption-end must not override their pause.
1035
1006
  @Test @MainActor
1036
1007
  func userPauseDuringInterruption_overridesResume() throws {
1037
1008
  let (c, eh, _, _) = makeCoordinator()
@@ -1049,7 +1020,6 @@ struct InterruptionTests {
1049
1020
  func ended_doesNotResume_whenNotPlayingBeforeInterruption() throws {
1050
1021
  let (c, eh, _, _) = makeCoordinator()
1051
1022
  try startPlaying(c, eh)
1052
- // Pause before the interruption (e.g. user already paused).
1053
1023
  c.setPlayWhenReady(false)
1054
1024
  eh.emit(.timeControlStatus(.paused, waitingForNoItem: false))
1055
1025
  #expect(c.state == .paused)
@@ -1057,14 +1027,14 @@ struct InterruptionTests {
1057
1027
  c.handleInterruptionBegan()
1058
1028
  c.handleInterruptionEnded(shouldResume: true)
1059
1029
 
1060
- #expect(c.playWhenReady == false) // never resumes — we weren't playing
1030
+ #expect(c.playWhenReady == false)
1061
1031
  }
1062
1032
  }
1063
1033
 
1064
1034
  // MARK: - Skip availability freshness
1065
1035
 
1066
- /// A mutation pushes next/previous availability once, after currentIndex and the
1067
- /// shuffle order have settled; an earlier push leaves the lock-screen buttons wrong.
1036
+ /// A mutation pushes next/previous availability once, after currentIndex and the shuffle order
1037
+ /// settle; an earlier push leaves the lock-screen buttons wrong.
1068
1038
  @Suite("Player - skip availability after mutations")
1069
1039
  struct MutationSkipAvailabilityTests {
1070
1040
  @Test @MainActor
@@ -1078,7 +1048,7 @@ struct MutationSkipAvailabilityTests {
1078
1048
 
1079
1049
  try c.move(fromIndex: 0, toIndex: 1)
1080
1050
 
1081
- // Current track is now last: nothing to skip to.
1051
+ // Current is now last.
1082
1052
  #expect(eh.updateSkipAvailabilityCalls.count == 1)
1083
1053
  #expect(eh.updateSkipAvailabilityCalls.last?.canNext == false)
1084
1054
  }
@@ -1097,7 +1067,7 @@ struct MutationSkipAvailabilityTests {
1097
1067
 
1098
1068
  try c.remove(0)
1099
1069
 
1100
- // Current settled at index 1 of 2: previous available, next not.
1070
+ // Current settled at index 1 of 2.
1101
1071
  #expect(eh.updateSkipAvailabilityCalls.count == 1)
1102
1072
  #expect(eh.updateSkipAvailabilityCalls.last?.canNext == false)
1103
1073
  #expect(eh.updateSkipAvailabilityCalls.last?.canPrevious == true)
@@ -1108,8 +1078,8 @@ struct MutationSkipAvailabilityTests {
1108
1078
 
1109
1079
  @Suite("Player - publishing")
1110
1080
  struct PublishingTests {
1111
- /// The order JS has always seen: the intent, then the playing state, then the playback. A
1112
- /// natural end clears the intent on the way in; each change still goes out once.
1081
+ /// The order JS depends on: the intent, the playing state, the playback. A natural end clears
1082
+ /// the intent on the way in; each change still goes out once.
1113
1083
  @Test @MainActor
1114
1084
  func endingPublishesTheIntentThenThePlayingStateThenThePlayback() {
1115
1085
  let (c, _, cb, _) = makeCoordinator()
@@ -1166,8 +1136,7 @@ struct LoadTests {
1166
1136
  #expect(c.load?.hasPlayed == false)
1167
1137
  }
1168
1138
 
1169
- /// The healthy-playback refill resets the retry budgets mid-play; the load, and with it the
1170
- /// recovery budget, must survive it.
1139
+ /// The healthy-playback refill resets the retry budget mid-play; the load must survive it.
1171
1140
  @Test @MainActor
1172
1141
  func aRetryResetKeepsTheLoad() throws {
1173
1142
  let (c, eh, _, _) = makeCoordinator()
@@ -1242,9 +1211,6 @@ struct QueuePublicationTests {
1242
1211
 
1243
1212
  @Suite("Player - stop cancels pending retry")
1244
1213
  struct StopCancelsRetryTests {
1245
- /// A retry surviving stop() gives up later (intent dropped) and surfaced
1246
- /// .errorOccurred over the deliberate stop — the UI showed an error seconds
1247
- /// after the user stopped.
1248
1214
  @Test @MainActor
1249
1215
  func stop_cancelsPendingRetry_andStaysSilent() async {
1250
1216
  let errorHandler = makeRetryLoop(delay: 0.05)
@@ -1288,8 +1254,7 @@ struct SessionReleaseTests {
1288
1254
 
1289
1255
  @Test @MainActor
1290
1256
  func interruptionBegan_doesNotRequestRelease() throws {
1291
- // A phone call pauses (playWhenReady → false) but is meant to resume, so the session must be
1292
- // held — the exact race the intent-gating design exists to avoid.
1257
+ // A call pauses but is meant to resume, so the session is held.
1293
1258
  let (c, eh, _, _) = makeCoordinator()
1294
1259
  try startPlaying(c, eh)
1295
1260
  eh.scheduleAudioSessionReleaseCount = 0
@@ -1320,8 +1285,8 @@ struct SessionReleaseTests {
1320
1285
 
1321
1286
  // MARK: - Media-stack effects of a publish
1322
1287
 
1323
- /// The audio-session and now-playing effects the Player drives through its engine, in their
1324
- /// order relative to the callbacks JS hears.
1288
+ /// The audio-session and now-playing effects the Player drives through its engine, in order
1289
+ /// with the callbacks JS hears.
1325
1290
  @Suite("Player - media-stack effects")
1326
1291
  struct MediaStackEffectTests {
1327
1292
  @MainActor
@@ -23,7 +23,6 @@ struct PlayingStateTests {
23
23
  #expect(!state(false, .playing).playing)
24
24
  }
25
25
 
26
- /// .stopped was once missing here, masked only by stop() clearing the intent right after.
27
26
  @Test func notPlayingInTerminalStatesEvenWithIntent() {
28
27
  for terminal in [PlaybackState.none, .stopped, .ended, .error] {
29
28
  #expect(!state(true, terminal).playing, "Expected not playing in \(terminal) despite intent")