nativescript 9.0.4-dev.1 → 9.0.4-dev.3

package/lib/services/terminal-spinner-service.js

@@ -5,6 +5,7 @@ const ora = require("ora");
 const yok_1 = require("../common/yok");
 class TerminalSpinnerService {
     createSpinner(spinnerOptions = {}) {
+        // @ts-expect-error - options are readonly, however we still want to override them before passing them on...
         spinnerOptions.stream = spinnerOptions.stream || process.stdout;
         return ora(spinnerOptions);
     }
@@ -25,3 +26,4 @@ class TerminalSpinnerService {
 }
 exports.TerminalSpinnerService = TerminalSpinnerService;
 yok_1.injector.register("terminalSpinnerService", TerminalSpinnerService);
+//# sourceMappingURL=terminal-spinner-service.js.map

package/lib/services/test-execution-service.js

@@ -24,8 +24,10 @@ class TestExecutionService {
         platform = platform.toLowerCase();
         this.platform = platform;
         const projectData = this.$projectDataService.getProjectData(liveSyncInfo.projectDir);
+        // We need the dependencies installed here, so we can start the Karma server.
         await this.$pluginsService.ensureAllDependenciesAreInstalled(projectData);
         const karmaConfig = this.getKarmaConfiguration(platform, projectData);
+        // In case you want to debug the unit test runner, add "--inspect-brk=<port>" as a first element in the array of args.
         const karmaRunner = this.$childProcess.spawn(process.execPath, [path.join(__dirname, "karma-execution.js")], { stdio: ["inherit", "inherit", "inherit", "ipc"] });
         const launchKarmaTests = async (karmaData) => {
             this.$logger.trace("## Unit-testing: Parent process received message", karmaData);
@@ -42,6 +44,8 @@ class TestExecutionService {
                 const configJs = this.generateConfig(port, configOptions);
                 this.$fs.writeFile(path.join(liveSyncInfo.projectDir, TestExecutionService.CONFIG_FILE_NAME), configJs);
             }
+            // Prepare the project AFTER the TestExecutionService.CONFIG_FILE_NAME file is created in node_modules
+            // so it will be sent to device.
             await this.$runController.run({
                 liveSyncInfo,
                 deviceDescriptors,
@@ -54,12 +58,13 @@ class TestExecutionService {
             }
             launchKarmaTests(karmaData).catch((result) => {
                 this.$logger.error(result);
-                process.exit(130);
+                process.exit(130 /* ErrorCodes.KARMA_FAIL */);
             });
         });
         return new Promise((resolve, reject) => {
             karmaRunner.on("exit", (exitCode) => {
                 if (exitCode !== 0) {
+                    //End our process with a non-zero exit code
                     const testError = new Error("Test run failed.");
                     reject(testError);
                 }
@@ -72,7 +77,7 @@ class TestExecutionService {
     }
     async canStartKarmaServer(projectData) {
         let canStartKarmaServer = true;
-        const requiredDependencies = ["@nativescript/unit-test-runner"];
+        const requiredDependencies = ["@nativescript/unit-test-runner"]; // we need @nativescript/unit-test-runner at the local level because of hooks!
         _.each(requiredDependencies, (dep) => {
             if (!projectData.dependencies[dep] && !projectData.devDependencies[dep]) {
                 canStartKarmaServer = false;
@@ -121,6 +126,7 @@ class TestExecutionService {
             karmaConfig.logLevel = "DEBUG";
         }
         if (!this.$options.watch) {
+            // Setting singleRun to true will automatically start the tests when new browser (device in our case) is registered in karma.
             karmaConfig.singleRun = true;
         }
         if (this.$options.debugBrk) {
@@ -139,3 +145,4 @@ exports.TestExecutionService = TestExecutionService;
 TestExecutionService.CONFIG_FILE_NAME = `node_modules/${constants.TEST_RUNNER_NAME}/config.js`;
 TestExecutionService.SOCKETIO_JS_FILE_NAME = `node_modules/${constants.TEST_RUNNER_NAME}/socket.io.js`;
 yok_1.injector.register("testExecutionService", TestExecutionService);
+//# sourceMappingURL=test-execution-service.js.map

package/lib/services/test-initialization-service.js

@@ -34,6 +34,9 @@ class TestInitializationService {
         });
         return targetFrameworkDependencies;
     }
+    /**
+     * This method is used from test-init.md file so it is not allowed to use "this" inside the method's body.
+     */
     getFrameworkNames() {
         const configsPath = path.join(__dirname, "..", "..", "config");
         const dependenciesPath = path.join(configsPath, "test-dependencies.json");
@@ -52,3 +55,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], TestInitializationService.prototype, "getFrameworkNames", null);
 yok_1.injector.register("testInitializationService", TestInitializationService);
+//# sourceMappingURL=test-initialization-service.js.map

package/lib/services/timeline-profiler-service.js

@@ -98,3 +98,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], TimelineProfilerService.prototype, "isEnabled", null);
 yok_1.injector.register("timelineProfilerService", TimelineProfilerService);
+//# sourceMappingURL=timeline-profiler-service.js.map

package/lib/services/user-settings-service.js

@@ -32,3 +32,4 @@ class UserSettingsService {
 }
 exports.UserSettingsService = UserSettingsService;
 yok_1.injector.register("userSettingsService", UserSettingsService);
+//# sourceMappingURL=user-settings-service.js.map

package/lib/services/versions-service.js

@@ -47,6 +47,7 @@ class VersionsService {
             const tnsCoreModulesPath = path.join(nodeModulesPath, constants.TNS_CORE_MODULES_NAME);
             const dependsOnNonScopedPackage = !!this.projectData.dependencies[constants.TNS_CORE_MODULES_NAME];
             const dependsOnScopedPackage = !!this.projectData.dependencies[constants.SCOPED_TNS_CORE_MODULES];
+            // ensure the dependencies are installed, so we can get their actual versions from node_modules
             if (!this.$fs.exists(nodeModulesPath) ||
                 (dependsOnNonScopedPackage && !this.$fs.exists(tnsCoreModulesPath)) ||
                 (dependsOnScopedPackage && !this.$fs.exists(scopedPackagePath))) {
@@ -73,16 +74,16 @@ class VersionsService {
         return versionInformations;
     }
     async getRuntimesVersions(platform) {
-        const iosRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "ios");
-        const androidRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "android");
+        const iosRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "ios" /* constants.PlatformTypes.ios */);
+        const androidRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "android" /* constants.PlatformTypes.android */);
         let runtimes = [];
         if (!platform) {
             runtimes = [iosRuntime, androidRuntime];
         }
-        else if (platform === "ios") {
+        else if (platform === "ios" /* PlatformTypes.ios */) {
             runtimes.push(iosRuntime);
         }
-        else if (platform === "android") {
+        else if (platform === "android" /* PlatformTypes.android */) {
             runtimes.push(androidRuntime);
         }
         const runtimesVersions = await Promise.all(runtimes.map(async (runtime) => {
@@ -175,3 +176,4 @@ VersionsService.UP_TO_DATE_MESSAGE = "up to date";
 VersionsService.UPDATE_AVAILABLE_MESSAGE = "Update available";
 VersionsService.NOT_INSTALLED_MESSAGE = "not installed";
 yok_1.injector.register("versionsService", VersionsService);
+//# sourceMappingURL=versions-service.js.map

package/lib/services/watch-ignore-list-service.js

@@ -18,3 +18,4 @@ class WatchIgnoreListService {
 }
 exports.WatchIgnoreListService = WatchIgnoreListService;
 yok_1.injector.register("watchIgnoreListService", WatchIgnoreListService);
+//# sourceMappingURL=watch-ignore-list-service.js.map

package/lib/services/xcconfig-service.js

@@ -55,6 +55,7 @@ class XcconfigService {
                 }
             });
             if (isPropertyParsed) {
+                // property can be an empty string, so we don't check for that.
                 return property;
             }
         }
@@ -63,3 +64,4 @@ class XcconfigService {
 }
 exports.XcconfigService = XcconfigService;
 yok_1.injector.register("xcconfigService", XcconfigService);
+//# sourceMappingURL=xcconfig-service.js.map

package/lib/services/xcproj-service.js

@@ -21,3 +21,4 @@ class XcprojService {
     }
 }
 yok_1.injector.register("xcprojService", XcprojService);
+//# sourceMappingURL=xcproj-service.js.map

package/lib/shared-event-bus.js

@@ -2,6 +2,12 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const events_1 = require("events");
 const yok_1 = require("./common/yok");
+/**
+ * Event Bus used by different services to emit state changes and
+ * allow listening for these state changes without needing a reference
+ * to the emitting service.
+ */
 class SharedEventBus extends events_1.EventEmitter {
 }
 yok_1.injector.register("sharedEventBus", SharedEventBus);
+//# sourceMappingURL=shared-event-bus.js.map

package/lib/sys-info.js

@@ -79,7 +79,7 @@ class SysInfo {
         if (macOSVersion && macOSVersion < constants_1.MacOSVersions.HighSierra) {
             return {
                 message: (0, util_1.format)(constants_1.MacOSDeprecationStringFormat, macOSVersion),
-                severity: "high",
+                severity: "high" /* SystemWarningsSeverity.high */,
             };
         }
         return null;
@@ -101,3 +101,4 @@ __decorate([
     (0, decorators_1.exported)("sysInfo")
 ], SysInfo.prototype, "getSupportedNodeVersionRange", null);
 yok_1.injector.register("sysInfo", SysInfo);
+//# sourceMappingURL=sys-info.js.map

package/lib/tools/config-manipulation/config-transformer.js

@@ -55,6 +55,7 @@ class ConfigTransformer {
             const parts = key.split(".");
             const name = parts.shift();
             const property = this.getProperty(name, parent);
+            // no android key, add it to parent to root
             if (!property) {
                 return undefined;
             }
@@ -64,11 +65,14 @@ class ConfigTransformer {
             if (!_parent) {
                 return undefined;
             }
+            // add nonExistent.deep to android: {}
             return this.getProperty(parts.join("."), _parent);
         }
+        // if we have a parent, we are reading the property from it
         if (parent) {
             return parent.getProperty(key);
         }
+        // otherwise we just read it from the root exports object
         return this.getProperty(key, this.getDefaultExportValue());
     }
     addProperty(key, value, parent = null) {
@@ -190,15 +194,22 @@ class ConfigTransformer {
         }
         this.setInitializerValue(initializer, newValue);
     }
+    /**
+     * @internal
+     */
     getFullText() {
         return this.config.getFullText();
     }
+    /**
+     * @internal
+     */
     getValue(key) {
         return this.getPropertyValue(this.getProperty(key));
     }
     setValue(key, value) {
         const property = this.getProperty(key);
         if (!property) {
+            // add new property
             this.addProperty(key, value);
         }
         else {
@@ -208,3 +219,4 @@ class ConfigTransformer {
     }
 }
 exports.ConfigTransformer = ConfigTransformer;
+//# sourceMappingURL=config-transformer.js.map

package/lib/tools/node-modules/node-modules-builder.js

@@ -29,3 +29,4 @@ class NodeModulesBuilder {
 }
 exports.NodeModulesBuilder = NodeModulesBuilder;
 yok_1.injector.register("nodeModulesBuilder", NodeModulesBuilder);
+//# sourceMappingURL=node-modules-builder.js.map

package/lib/tools/node-modules/node-modules-dependencies-builder.js

@@ -56,14 +56,18 @@ class NodeModulesDependenciesBuilder {
             let modulePath = (0, resolve_package_path_1.resolvePackagePath)(depDescription.name, {
                 paths: [parentModulesPath],
             });
+            // perhaps traverse up the tree here?
             if (!modulePath) {
+                // fallback to searching in the root path
                 modulePath = (0, resolve_package_path_1.resolvePackagePath)(depDescription.name, {
                     paths: [rootPath],
                 });
             }
+            // if we failed to find the module...
             if (!modulePath) {
                 return null;
             }
+            // if we already resolved this dependency, we return null to avoid a duplicate resolution
             if (resolvedDependencies.some((r) => {
                 return r.name === depDescription.name && r.directory === modulePath;
             })) {
@@ -88,6 +92,7 @@ class NodeModulesDependenciesBuilder {
             const packageJsonContents = this.$fs.readJson(packageJsonPath);
             dependency.version = packageJsonContents.version;
             if (!!packageJsonContents.nativescript) {
+                // add `nativescript` property, necessary for resolving plugins
                 dependency.nativescript = packageJsonContents.nativescript;
             }
             dependency.dependencies = _.keys(packageJsonContents.dependencies);
@@ -98,3 +103,4 @@ class NodeModulesDependenciesBuilder {
 }
 exports.NodeModulesDependenciesBuilder = NodeModulesDependenciesBuilder;
 yok_1.injector.register("nodeModulesDependenciesBuilder", NodeModulesDependenciesBuilder);
+//# sourceMappingURL=node-modules-dependencies-builder.js.map

package/lib/yarn-package-manager.js

@@ -113,3 +113,4 @@ __decorate([
     (0, decorators_1.exported)("yarn")
 ], YarnPackageManager.prototype, "getCachePath", null);
 yok_1.injector.register("yarn", YarnPackageManager);
+//# sourceMappingURL=yarn-package-manager.js.map

package/lib/yarn2-package-manager.js

@@ -36,6 +36,8 @@ class Yarn2PackageManager extends base_package_manager_1.BasePackageManager {
         }
         const packageJsonPath = path.join(pathToSave, "package.json");
         const jsonContentBefore = this.$fs.readJson(packageJsonPath);
+        // remove unsupported flags
+        // todo: refactor all package managers to map typed flags to the actual flags
         const cleanedConfig = _.omit(config, ["save-dev", "save-exact"]);
         const flags = this.getFlagsString(cleanedConfig, true);
         let params = [];
@@ -122,3 +124,4 @@ __decorate([
     (0, decorators_1.exported)("yarn2")
 ], Yarn2PackageManager.prototype, "getCachePath", null);
 yok_1.injector.register("yarn2", Yarn2PackageManager);
+//# sourceMappingURL=yarn2-package-manager.js.map

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "nativescript",
   "main": "./lib/nativescript-cli-lib.js",
-  "version": "9.0.4-dev.1",
+  "version": "9.0.4-dev.3",
   "author": "NativeScript <oss@nativescript.org>",
   "description": "Command-line interface for building NativeScript projects",
   "bin": {