nativescript 9.0.4-dev.1 → 9.0.4-dev.3

package/lib/services/ios-watch-app-service.js

@@ -63,3 +63,4 @@ exports.IOSWatchAppService = IOSWatchAppService;
 IOSWatchAppService.WATCH_APP_IDENTIFIER = "watchkitapp";
 IOSWatchAppService.WACTCH_EXTENSION_IDENTIFIER = "watchkitextension";
 yok_1.injector.register("iOSWatchAppService", IOSWatchAppService);
+//# sourceMappingURL=ios-watch-app-service.js.map

package/lib/services/ip-service.js

@@ -38,6 +38,7 @@ class IPService {
         return ipAddress;
     }
     async getIPAddressFromIpifyOrgAPI() {
+        // https://www.ipify.org/
         const ipifyOrgAPIEndpoint = "https://api.ipify.org";
         let ipAddress = null;
         try {
@@ -61,3 +62,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], IPService.prototype, "getCurrentIPv4Address", null);
 yok_1.injector.register("ipService", IPService);
+//# sourceMappingURL=ip-service.js.map

package/lib/services/itmstransporter-service.js

@@ -191,3 +191,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], ITMSTransporterService.prototype, "getITMSTransporterPath", null);
 yok_1.injector.register("itmsTransporterService", ITMSTransporterService);
+//# sourceMappingURL=itmstransporter-service.js.map

package/lib/services/karma-execution.js

@@ -9,8 +9,10 @@ process.on("message", (data) => {
         });
         const KarmaServer = require(path.join(pathToKarma, "lib/server"));
         const karma = new KarmaServer(data.karmaConfig, (exitCode) => {
+            // Exit with the correct exit code and signal the manager process.
             process.exit(exitCode);
         });
         karma.start();
     }
 });
+//# sourceMappingURL=karma-execution.js.map

package/lib/services/livesync/android-device-livesync-service-base.js

@@ -49,3 +49,4 @@ class AndroidDeviceLiveSyncServiceBase extends device_livesync_service_base_1.De
     }
 }
 exports.AndroidDeviceLiveSyncServiceBase = AndroidDeviceLiveSyncServiceBase;
+//# sourceMappingURL=android-device-livesync-service-base.js.map

package/lib/services/livesync/android-device-livesync-service.js

@@ -97,6 +97,7 @@ class AndroidDeviceLiveSyncService extends android_device_livesync_service_base_
         ]);
         const regex = new RegExp(`^-.*${deviceRootBasename}$`, "m");
         const matchingFile = (listResult || "").match(regex);
+        // Check if there is already a file with deviceRootBasename. If so, delete it as it breaks LiveSyncing.
         if (matchingFile && matchingFile[0] && _.startsWith(matchingFile[0], "-")) {
             await this.device.adb.executeShellCommand(["rm", "-f", deviceRootPath]);
         }
@@ -172,3 +173,4 @@ __decorate([
 __decorate([
     (0, decorators_1.performanceLog)()
 ], AndroidDeviceLiveSyncService.prototype, "removeFiles", null);
+//# sourceMappingURL=android-device-livesync-service.js.map

package/lib/services/livesync/android-device-livesync-sockets-service.js

@@ -95,6 +95,8 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
                 await this.$cleanupService.removeCleanupCommand(cleanupCommand);
             };
             await this.$cleanupService.addCleanupCommand(cleanupCommand);
+            // We need to clear resources when the action fails
+            // But we also need the real result of the action.
             await doSyncPromise.then(actionOnEnd.bind(this), actionOnEnd.bind(this));
             result = await doSyncPromise;
         }
@@ -164,3 +166,4 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
 exports.AndroidDeviceSocketsLiveSyncService = AndroidDeviceSocketsLiveSyncService;
 AndroidDeviceSocketsLiveSyncService.STATUS_UPDATE_INTERVAL = 10000;
 AndroidDeviceSocketsLiveSyncService.MINIMAL_VERSION_LONG_LIVING_CONNECTION = "0.2.0";
+//# sourceMappingURL=android-device-livesync-sockets-service.js.map

package/lib/services/livesync/android-livesync-service.js

@@ -53,3 +53,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], AndroidLiveSyncService.prototype, "fullSync", null);
 yok_1.injector.register("androidLiveSyncService", AndroidLiveSyncService);
+//# sourceMappingURL=android-livesync-service.js.map

package/lib/services/livesync/android-livesync-tool.js

@@ -140,9 +140,12 @@ class AndroidLivesyncTool {
             error =
                 error ||
                     this.getErrorWithMessage("Socket connection ended before sync operation is complete.");
+            //remove listeners and delete this.socketConnection
             this.cleanState(socketUid);
+            //call end of the connection (close and error callbacks won't be called - listeners removed)
             socket.end();
             socket.destroy();
+            //reject all pending sync requests and clear timeouts
             this.rejectPendingSyncOperations(socketUid, error);
         }
     }
@@ -404,3 +407,4 @@ AndroidLivesyncTool.SOCKET_CONNECTION_ALREADY_EXISTS_ERROR = "Socket connection
 AndroidLivesyncTool.SOCKET_CONNECTION_TIMED_OUT_ERROR = "Socket connection timed out.";
 AndroidLivesyncTool.NO_SOCKET_CONNECTION_AVAILABLE_ERROR = "No socket connection available.";
 yok_1.injector.register("androidLivesyncTool", AndroidLivesyncTool);
+//# sourceMappingURL=android-livesync-tool.js.map

package/lib/services/livesync/device-livesync-service-base.js

@@ -40,6 +40,7 @@ class DeviceLiveSyncServiceBase {
         return transferredFiles;
     }
     async finalizeSync(liveSyncInfo, projectData) {
+        //implement in case a sync point for all remove/create operation is needed
         return {
             didRefresh: true,
             operationId: "",
@@ -54,3 +55,4 @@ __decorate([
 __decorate([
     (0, decorators_2.performanceLog)()
 ], DeviceLiveSyncServiceBase.prototype, "transferFiles", null);
+//# sourceMappingURL=device-livesync-service-base.js.map

package/lib/services/livesync/ios-device-livesync-service.js

@@ -37,11 +37,13 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
         return canRefresh;
     }
     async setupSocketIfNeeded(projectData) {
+        // TODO: persist the sockets per app in order to support LiveSync on multiple apps on the same device
         if (this.socket) {
             return true;
         }
         const appId = projectData.projectIdentifiers.ios;
         try {
+            // TODO: temp workaround till we setup the sockets along with the app start
             const ensureAppStarted = true;
             this.socket = await this.device.getDebugSocket(appId, projectData.projectName, projectData.projectDir, ensureAppStarted);
         }
@@ -121,6 +123,7 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
             projectDir: projectData.projectDir,
         });
         if (liveSyncInfo.useHotModuleReload) {
+            // enable HOT updates
             await this.setupSocketIfNeeded(projectData);
         }
     }
@@ -177,6 +180,9 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
     }
     async destroySocket() {
         if (this.socket) {
+            // we do not support LiveSync on multiple apps on the same device
+            // in order to do that, we should cache the socket per app
+            // and destroy just the current app socket when possible
             await this.device.destroyAllSockets();
             this.socket = null;
         }
@@ -187,3 +193,4 @@ IOSDeviceLiveSyncService.MIN_RUNTIME_VERSION_WITH_REFRESH_NOTIFICATION = "6.1.0"
 __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSDeviceLiveSyncService.prototype, "removeFiles", null);
+//# sourceMappingURL=ios-device-livesync-service.js.map

package/lib/services/livesync/ios-livesync-service.js

@@ -58,6 +58,7 @@ class IOSLiveSyncService extends platform_livesync_service_base_1.PlatformLiveSy
     }
     async syncAfterInstall(device, liveSyncInfo) {
         if (!device.isEmulator) {
+            // In this case we should execute fullsync because iOS Runtime requires the full content of app dir to be extracted in the root of sync dir.
             await this.fullSync({
                 projectData: liveSyncInfo.projectData,
                 device,
@@ -77,3 +78,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSLiveSyncService.prototype, "fullSync", null);
 yok_1.injector.register("iOSLiveSyncService", IOSLiveSyncService);
+//# sourceMappingURL=ios-livesync-service.js.map

package/lib/services/livesync/livesync-socket.js

@@ -12,3 +12,4 @@ class LiveSyncSocket extends net.Socket {
 }
 exports.LiveSyncSocket = LiveSyncSocket;
 yok_1.injector.register("LiveSyncSocket", LiveSyncSocket, false);
+//# sourceMappingURL=livesync-socket.js.map

package/lib/services/livesync/platform-livesync-service-base.js

@@ -40,6 +40,7 @@ class PlatformLiveSyncServiceBase {
         return shouldRestart;
     }
     async syncAfterInstall(device, liveSyncInfo) {
+        /* intentionally left blank */
     }
     async restartApplication(projectData, liveSyncInfo) {
         const deviceLiveSyncService = this.getDeviceLiveSyncService(liveSyncInfo.deviceAppData.device, projectData);
@@ -85,6 +86,8 @@ class PlatformLiveSyncServiceBase {
         let modifiedLocalToDevicePaths = [];
         if (liveSyncInfo.filesToSync.length) {
             const filesToSync = liveSyncInfo.filesToSync;
+            // const mappedFiles = _.map(filesToSync, filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData));
+            // Some plugins modify platforms dir on afterPrepare (check nativescript-dev-sass) - we want to sync only existing file.
             const existingFiles = filesToSync.filter((m) => m && this.$fs.exists(m));
             this.$logger.trace("Will execute livesync for files: ", existingFiles);
             const skippedFiles = _.difference(filesToSync, existingFiles);
@@ -103,6 +106,7 @@ class PlatformLiveSyncServiceBase {
             const filePaths = liveSyncInfo.filesToRemove;
             const platformData = this.$platformsDataService.getPlatformData(device.deviceInfo.platform, projectData);
             const mappedFiles = _(filePaths)
+                // .map(filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData))
                 .filter((filePath) => !!filePath)
                 .value();
             const projectFilesPath = path.join(platformData.appDestinationDirectoryPath, constants_1.APP_FOLDER_NAME);
@@ -154,3 +158,4 @@ exports.PlatformLiveSyncServiceBase = PlatformLiveSyncServiceBase;
 __decorate([
     (0, decorators_1.performanceLog)()
 ], PlatformLiveSyncServiceBase.prototype, "liveSyncWatchAction", null);
+//# sourceMappingURL=platform-livesync-service-base.js.map

package/lib/services/livesync-process-data-service.js

@@ -41,3 +41,4 @@ class LiveSyncProcessDataService {
 }
 exports.LiveSyncProcessDataService = LiveSyncProcessDataService;
 yok_1.injector.register("liveSyncProcessDataService", LiveSyncProcessDataService);
+//# sourceMappingURL=livesync-process-data-service.js.map

package/lib/services/log-parser-service.js

@@ -50,3 +50,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], LogParserService.prototype, "startParsingLogCore", null);
 yok_1.injector.register("logParserService", LogParserService);
+//# sourceMappingURL=log-parser-service.js.map

package/lib/services/log-source-map-service.js

@@ -31,6 +31,7 @@ class LogSourceMapService {
             if (!this.$fs.getFsStats(filePath).isDirectory()) {
                 const mapFile = filePath + ".map";
                 let sourceMapRaw;
+                // Skip files bigger than 50MB
                 if (this.$fs.getFileSize(filePath) > 50 * 1000 * 1000) {
                     this.$logger.trace(`Skipping source map for file ${filePath} because it is too big (> 50MB).`);
                     return;
@@ -155,6 +156,8 @@ class LogSourceMapService {
         }
     }
     parseAndroidLog(projectData, rawMessage) {
+        // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap (file:///data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
+        // "System.err: File: "file:///data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         const deviceProjectPath = util.format(constants_1.ANDROID_DEVICE_APP_ROOT_TEMPLATE, projectData.projectIdentifiers.android);
         let separator = ",";
@@ -162,18 +165,25 @@ class LogSourceMapService {
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
+            //"data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
             parts = fileSubstring.split(separator);
             if (parts.length >= 3) {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js"
                 parts[0] = parts[0].replace("'", "");
+                // " line: 304"
                 parts[1] = parts[1].replace(" line: ", "");
+                // " column: 8"
                 parts[2] = parts[2].replace(" column: ", "");
             }
             else {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
                 separator = ":";
                 parts = fileSubstring.split(separator);
             }
             if (parts.length >= 3) {
+                // "/data/data/org.nativescript.sourceMap/files/app/"
                 const devicePath = `${deviceProjectPath}/${constants_1.APP_FOLDER_NAME}/`;
+                // "bundle.js"
                 filePath = path.relative(devicePath, `${"/"}${parts[0]}`);
                 line = parseInt(parts[1]);
                 column = parseInt(parts[2]);
@@ -181,20 +191,24 @@ class LogSourceMapService {
                 for (let i = 3; i < parts.length; i++) {
                     messageSuffix += `${parts[i]}${i === parts.length - 1 ? "" : separator}`;
                 }
+                // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap ("
                 messagePrefix = _.trimEnd(messagePrefix, "(");
             }
         }
         return { filePath, line, column, messagePrefix, messageSuffix };
     }
     parseIosLog(rawMessage) {
+        // "CONSOLE INFO file:///app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         let messageSuffix = "";
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
+            // "app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
             parts = fileSubstring.split(":");
             if (parts && parts.length >= 3) {
                 filePath = parts[0];
+                // "app/vendor.js"
                 if (_.startsWith(filePath, constants_1.APP_FOLDER_NAME)) {
                     filePath = path.relative(constants_1.APP_FOLDER_NAME, parts[0]);
                 }
@@ -223,3 +237,4 @@ LogSourceMapService.FILE_PREFIX = "file:///";
 LogSourceMapService.FILE_PREFIX_REPLACEMENT = "file: ";
 LogSourceMapService.MEMOIZE_FUNCTION_RANDOM_KEY_FOR_JOIN = "__some_random_value__";
 yok_1.injector.register("logSourceMapService", LogSourceMapService);
+//# sourceMappingURL=log-source-map-service.js.map

package/lib/services/marking-mode-service.js

@@ -6,7 +6,7 @@ const constants_1 = require("../constants");
 const yok_1 = require("../common/yok");
 const semver = require("semver/preload");
 const MARKING_MODE_PROP = "markingMode";
-const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full"}" is no longer supported.`;
+const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}" is no longer supported.`;
 class MarkingModeService {
     constructor($logger, $projectConfigService, $projectHelper, $projectDataService) {
         this.$logger = $logger;
@@ -18,11 +18,13 @@ class MarkingModeService {
         const markingModeValue = this.$projectConfigService.getValue("android.markingMode");
         const { skipWarnings, forceSwitch } = options;
         if (forceSwitch) {
-            await this.setMarkingMode("none");
+            await this.setMarkingMode("none" /* MarkingMode.None */);
             return;
         }
-        if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none") {
-            const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android");
+        if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none" /* MarkingMode.None */) {
+            // only warn if runtime is less than 7.0.0-rc.5 - where the default has been changed to None
+            // if version is null - we are about to add the latest runtime, so no need to warn
+            const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android" /* PlatformTypes.android */);
             const isMarkingModeFullDefault = version && semver.lt(semver.coerce(version), "7.0.0-rc.5");
             if (isMarkingModeFullDefault) {
                 this.showMarkingModeFullWarning();
@@ -33,7 +35,7 @@ class MarkingModeService {
         await this.$projectConfigService.setValue("android.markingMode", newMode);
     }
     showMarkingModeFullWarning() {
-        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full"}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
+        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
         this.$logger.warn(markingModeFullWarning, {
             [constants_1.LoggerConfigData.wrapMessageWithBorders]: true,
         });
@@ -41,3 +43,4 @@ class MarkingModeService {
 }
 exports.MarkingModeService = MarkingModeService;
 yok_1.injector.register("markingModeService", MarkingModeService);
+//# sourceMappingURL=marking-mode-service.js.map

package/lib/services/metadata-filtering-service.js

@@ -103,3 +103,4 @@ class MetadataFilteringService {
 }
 exports.MetadataFilteringService = MetadataFilteringService;
 yok_1.injector.register("metadataFilteringService", MetadataFilteringService);
+//# sourceMappingURL=metadata-filtering-service.js.map

package/lib/services/npm-config-service.js

@@ -21,8 +21,11 @@ class NpmConfigService {
     readConfig() {
         try {
             const res = (0, child_process_1.execSync)("npm config list --json --global");
+            // const data: any = npmconfig.read();
             const data = JSON.parse(res.toString());
+            // todo: remove if not needed with npm config list --json?
             Object.entries(data).forEach(([key, value]) => {
+                // replace env ${VARS} in strings with the process.env value
                 this.config[key] =
                     typeof value !== "string"
                         ? value
@@ -37,3 +40,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], NpmConfigService.prototype, "readConfig", null);
 yok_1.injector.register("npmConfigService", NpmConfigService);
+//# sourceMappingURL=npm-config-service.js.map

package/lib/services/pacote-service.js

@@ -24,6 +24,7 @@ class PacoteService {
         this.$proxyService = $proxyService;
     }
     get $packageManager() {
+        // need to be resolved here due to cyclic dependency
         return this.$injector.resolve("packageManager");
     }
     async manifest(packageName, options) {
@@ -39,6 +40,8 @@ class PacoteService {
         return result;
     }
     async extractPackage(packageName, destinationDirectory, options) {
+        // strip: Remove the specified number of leading path elements. Pathnames with fewer elements will be silently skipped. More info: https://github.com/npm/node-tar/blob/e89c4d37519b1c20133a9f49d5f6b85fa34c203b/README.md
+        // C: Create an archive
         this.$logger.trace(`Calling pacoteService.extractPackage for packageName: '${packageName}', destinationDir: '${destinationDirectory}' and options: ${options}`);
         const extractOptions = { strip: 1, C: destinationDirectory };
         if (options) {
@@ -56,6 +59,7 @@ class PacoteService {
             });
             this.$logger.trace(`Creating extract tar stream with options: ${JSON.stringify(extractOptions, null, 2)}`);
             const destination = tar.x(extractOptions);
+            // Initiate the source
             const sourceStream = new stream_1.PassThrough();
             sourceStream.end(source);
             sourceStream.pipe(destination);
@@ -70,7 +74,9 @@ class PacoteService {
         });
     }
     async getPacoteBaseOptions() {
+        // In case `ns create myapp --template https://github.com/NativeScript/template-hello-world.git` command is executed, pacote module throws an error if cache option is not provided.
         const cachePath = await this.$packageManager.getCachePath();
+        // Add NPM Configuration to our Manifest options
         const npmConfig = this.$npmConfigService.getConfig();
         const pacoteOptions = _.extend(npmConfig, { cache: cachePath, Arborist: arborist_1.Arborist });
         const proxySettings = await this.$proxyService.getCache();
@@ -92,3 +98,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], PacoteService.prototype, "$packageManager", null);
 yok_1.injector.register("pacoteService", PacoteService);
+//# sourceMappingURL=pacote-service.js.map

package/lib/services/performance-service.js

@@ -41,7 +41,7 @@ class PerformanceService {
     trackAnalyticsData(methodInfo, executionTime) {
         this.$analyticsService
             .trackEventActionInGoogleAnalytics({
-            action: "Performance",
+            action: "Performance" /* TrackActionNames.Performance */,
             additionalData: methodInfo,
             value: executionTime,
         })
@@ -71,6 +71,7 @@ class PerformanceService {
             this.$logger.info(PerformanceService.LOG_MESSAGE_TEMPLATE, methodInfo, executionTime);
         }
     }
+    //removes any injected members of the arguments and excludes the options object even if it was renamed
     getJsonSanitizer() {
         const seen = new WeakSet();
         seen.add(this.$options);
@@ -90,3 +91,4 @@ PerformanceService.LOG_MESSAGE_TEMPLATE = `Execution of method "%s" took %s ms.`
 PerformanceService.FAIL_LOG_MESSAGE_TEMPLATE = `Failed to log pefromance data in file for method %s.`;
 PerformanceService.MIN_NODE_PERFORMANCE_MODULE_VERSION = "8.5.0";
 yok_1.injector.register("performanceService", PerformanceService);
+//# sourceMappingURL=performance-service.js.map

package/lib/services/platform/add-platform-service.js

@@ -12,7 +12,11 @@ const constants_1 = require("../../constants");
 const decorators_1 = require("../../common/decorators");
 const yok_1 = require("../../common/yok");
 class AddPlatformService {
-    constructor($fs, $logger, $options, $packageManager, $terminalSpinnerService, $analyticsService) {
+    constructor($fs, $logger, $options, 
+    // private $pacoteService: IPacoteService,
+    // private $projectDataService: IProjectDataService,
+    $packageManager, $terminalSpinnerService, $analyticsService // private $tempService: ITempService
+    ) {
         this.$fs = $fs;
         this.$logger = $logger;
         this.$options = $options;
@@ -25,9 +29,13 @@ class AddPlatformService {
         const spinner = this.$terminalSpinnerService.createSpinner();
         try {
             spinner.start();
+            // const frameworkDirPath = addPlatformData.frameworkPath ?
+            // 	await this.extractPackage(packageToInstall)
+            // 	: await this.installPackage(projectData.projectDir, packageToInstall);
             const frameworkDirPath = await this.installPackage(projectData.projectDir, packageToInstall);
             const frameworkPackageJsonContent = this.$fs.readJson(path.join(frameworkDirPath, "..", "package.json"));
             const frameworkVersion = frameworkPackageJsonContent.version;
+            // await this.setPlatformVersion(platformData, projectData, frameworkVersion);
             await this.trackPlatformVersion(frameworkVersion, platformData);
             if (!addPlatformData.nativePrepare ||
                 !addPlatformData.nativePrepare.skipNativePrepare) {
@@ -47,9 +55,21 @@ class AddPlatformService {
     async setPlatformVersion(platformData, projectData, frameworkVersion) {
         await this.installPackage(projectData.projectDir, `${platformData.frameworkPackageName}@${frameworkVersion}`);
     }
+    // private async extractPackage(pkg: string): Promise<string> {
+    // 	const downloadedPackagePath = await this.$tempService.mkdirSync(
+    // 		"runtimeDir"
+    // 	);
+    // 	await this.$pacoteService.extractPackage(pkg, downloadedPackagePath);
+    // 	const frameworkDir = path.join(
+    // 		downloadedPackagePath,
+    // 		PROJECT_FRAMEWORK_FOLDER_NAME
+    // 	);
+    // 	return path.resolve(frameworkDir);
+    // }
     async installPackage(projectDir, packageName) {
         const frameworkDir = this.resolveFrameworkDir(projectDir, packageName);
         if (frameworkDir && this.$fs.exists(frameworkDir)) {
+            // don't install if it's already installed
             return frameworkDir;
         }
         const installedPackage = await this.$packageManager.install(packageName, projectDir, {
@@ -65,6 +85,30 @@ class AddPlatformService {
     }
     resolveFrameworkDir(projectDir, packageName) {
         try {
+            // strip version info if present <package>@1.2.3-rc.0 -> <package>
+            // tested cases:
+            // @nativescript/ios
+            // @nativescript/ios@1
+            // @nativescript/ios@1.2
+            // @nativescript/ios@1.2.3
+            // @nativescript/ios@1.2.3-
+            // @nativescript/ios@1.2.3-rc
+            // @nativescript/ios@1.2.3-rc.
+            // @nativescript/ios@1.2.3-rc.0
+            // @nativescript/ios@rc
+            // @nativescript/ios@^7.0.0
+            // @nativescript/ios@~7.0.0
+            // tns-ios
+            // tns-ios@1
+            // tns-ios@1.2
+            // tns-ios@1.2.3
+            // tns-ios@1.2.3-
+            // tns-ios@1.2.3-rc
+            // tns-ios@1.2.3-rc.
+            // tns-ios@1.2.3-rc.0
+            // tns-ios@rc
+            // tns-ios@^7.0.0
+            // tns-ios@~7.0.0
             packageName = packageName.replace(/(.+)@.+$/g, "$1");
             const frameworkDir = require
                 .resolve(`${packageName}/package.json`, {
@@ -82,8 +126,10 @@ class AddPlatformService {
     }
     async addNativePlatform(platformData, projectData, frameworkDirPath, frameworkVersion) {
         var _a;
+        // here we should use ios OR android
         const platformDir = (_a = this.$options.hostProjectPath) !== null && _a !== void 0 ? _a : path.join(projectData.platformsDir, platformData.normalizedPlatformName.toLowerCase());
         this.$fs.deleteDirectory(platformDir);
+        //if iosHost - dont create project
         await platformData.platformProjectService.createProject(path.resolve(frameworkDirPath), frameworkVersion, projectData);
         platformData.platformProjectService.ensureConfigurationFileInAppResources(projectData);
         await platformData.platformProjectService.interpolateData(projectData);
@@ -91,7 +137,7 @@ class AddPlatformService {
     }
     async trackPlatformVersion(frameworkVersion, platformData) {
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Add Platform",
+            action: "Add Platform" /* TrackActionNames.AddPlatform */,
             additionalData: `${platformData.platformNameLowerCase}${constants_1.AnalyticsEventLabelDelimiter}${frameworkVersion}`,
         });
     }
@@ -101,3 +147,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], AddPlatformService.prototype, "addNativePlatform", null);
 yok_1.injector.register("addPlatformService", AddPlatformService);
+//# sourceMappingURL=add-platform-service.js.map

package/lib/services/platform/platform-validation-service.js

@@ -72,3 +72,4 @@ class PlatformValidationService {
 }
 exports.PlatformValidationService = PlatformValidationService;
 yok_1.injector.register("platformValidationService", PlatformValidationService);
+//# sourceMappingURL=platform-validation-service.js.map

package/lib/services/platform/prepare-native-platform-service.js

@@ -49,17 +49,19 @@ class PrepareNativePlatformService {
             this.$metadataFilteringService.generateMetadataFilters(projectData, platformData.platformNameLowerCase);
         }
         platformData.platformProjectService.interpolateConfigurationFile(projectData);
-        await this.$projectChangesService.setNativePlatformStatus(platformData, projectData, { nativePlatformStatus: "3" });
+        await this.$projectChangesService.setNativePlatformStatus(platformData, projectData, { nativePlatformStatus: "3" /* NativePlatformStatus.alreadyPrepared */ });
         return hasChanges;
     }
     async cleanProject(platformData, options) {
+        // android build artifacts need to be cleaned up
+        // when switching between debug, release and webpack builds
         if (platformData.platformNameLowerCase !== "android") {
             return;
         }
         const previousPrepareInfo = this.$projectChangesService.getPrepareInfo(platformData);
         if (!previousPrepareInfo ||
             previousPrepareInfo.nativePlatformStatus !==
-                "3") {
+                "3" /* NativePlatformStatus.alreadyPrepared */) {
             return;
         }
         const { release: previousWasRelease } = previousPrepareInfo;
@@ -75,3 +77,4 @@ __decorate([
     (0, helpers_1.hook)("prepareNativeApp")
 ], PrepareNativePlatformService.prototype, "prepareNativePlatform", null);
 yok_1.injector.register("prepareNativePlatformService", PrepareNativePlatformService);
+//# sourceMappingURL=prepare-native-platform-service.js.map

package/lib/services/platform-environment-requirements.js

@@ -11,7 +11,9 @@ const helpers_1 = require("../common/helpers");
 const os_1 = require("os");
 const yok_1 = require("../common/yok");
 class PlatformEnvironmentRequirements {
-    constructor($doctorService, $errors, $analyticsService, $injector) {
+    constructor($doctorService, $errors, $analyticsService, 
+    // @ts-ignore - required by the hook helper!
+    $injector) {
         this.$doctorService = $doctorService;
         this.$errors = $errors;
         this.$analyticsService = $analyticsService;
@@ -22,7 +24,7 @@ class PlatformEnvironmentRequirements {
         const selectedOption = null;
         if (process.env.NS_SKIP_ENV_CHECK) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Check Environment Requirements",
+                action: "Check Environment Requirements" /* TrackActionNames.CheckEnvironmentRequirements */,
                 additionalData: "Skipped: NS_SKIP_ENV_CHECK is set",
             });
             return {
@@ -37,8 +39,9 @@ class PlatformEnvironmentRequirements {
             forceCheck: input.forceCheck,
         });
         if (!canExecute) {
+            // if (!isInteractive()) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Check Environment Requirements",
+                action: "Check Environment Requirements" /* TrackActionNames.CheckEnvironmentRequirements */,
                 additionalData: "Non-interactive terminal, unable to execute local builds.",
             });
             this.fail(this.getNonInteractiveConsoleMessage(platform));
@@ -58,6 +61,7 @@ class PlatformEnvironmentRequirements {
         ].join(os_1.EOL);
     }
     getEnvVerificationMessage(platform) {
+        // map process.platform to OS name used in docs
         const os = {
             linux: "linux",
             win32: "windows",
@@ -76,3 +80,4 @@ __decorate([
     (0, helpers_1.hook)("checkEnvironment")
 ], PlatformEnvironmentRequirements.prototype, "checkEnvironmentRequirements", null);
 yok_1.injector.register("platformEnvironmentRequirements", PlatformEnvironmentRequirements);
+//# sourceMappingURL=platform-environment-requirements.js.map

package/lib/services/platform-project-service-base.js

@@ -30,3 +30,4 @@ class PlatformProjectServiceBase extends events_1.EventEmitter {
     }
 }
 exports.PlatformProjectServiceBase = PlatformProjectServiceBase;
+//# sourceMappingURL=platform-project-service-base.js.map

package/lib/services/platforms-data-service.js

@@ -29,3 +29,4 @@ class PlatformsDataService {
 }
 exports.PlatformsDataService = PlatformsDataService;
 yok_1.injector.register("platformsDataService", PlatformsDataService);
+//# sourceMappingURL=platforms-data-service.js.map