nativescript 9.0.4-dev.1 → 9.0.4-dev.3

package/lib/project-data.js

@@ -19,6 +19,7 @@ class ProjectData {
         this.warnProjectId();
         return this.projectIdentifiers.ios;
     }
+    //just in case hook/extension modifies it.
     set projectId(identifier) {
         this.warnProjectId();
         this.projectIdentifiers.ios = identifier;
@@ -44,6 +45,7 @@ class ProjectData {
             return;
         }
         projectDir = projectDir || this.$projectHelper.projectDir;
+        // If no project found, projectDir should be null
         if (projectDir) {
             const projectFilePath = this.getProjectFilePath(projectDir);
             if (this.$fs.exists(projectFilePath)) {
@@ -116,6 +118,7 @@ class ProjectData {
     errorInvalidProject(projectDir) {
         const currentDir = path.resolve(".");
         this.$logger.trace(`Unable to find project. projectDir: ${projectDir}, options.path: ${this.$options.path}, ${currentDir}`);
+        // This is the case when no project file found
         this.$errors.fail("No project found at or above '%s' and neither was a --path specified.", projectDir || this.$options.path || currentDir);
     }
     getProjectFilePath(projectDir) {
@@ -131,6 +134,10 @@ class ProjectData {
             return this.nsConfig[constants.CONFIG_NS_APP_RESOURCES_ENTRY];
         }
         return constants.APP_RESOURCES_FOLDER_NAME;
+        // return path.join(
+        // 	this.getAppDirectoryRelativePath(),
+        // 	constants.APP_RESOURCES_FOLDER_NAME
+        // );
     }
     getAppDirectoryPath(projectDir) {
         const appRelativePath = this.getAppDirectoryRelativePath();
@@ -144,6 +151,7 @@ class ProjectData {
             return constants.SRC_DIR;
         }
         else {
+            // legacy project setup often uses app folder
             return constants.APP_FOLDER_NAME;
         }
     }
@@ -201,6 +209,9 @@ class ProjectData {
     }
 }
 exports.ProjectData = ProjectData;
+/**
+ * NOTE: Order of the elements is important as the TypeScript dependencies are commonly included in Angular project as well.
+ */
 ProjectData.PROJECT_TYPES = [
     {
         type: constants.ProjectTypes.JsFlavorName,
@@ -238,3 +249,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], ProjectData.prototype, "warnProjectId", null);
 yok_1.injector.register("projectData", ProjectData, true);
+//# sourceMappingURL=project-data.js.map

package/lib/providers/project-files-provider.js

@@ -44,3 +44,4 @@ class ProjectFilesProvider extends project_files_provider_base_1.ProjectFilesPro
 exports.ProjectFilesProvider = ProjectFilesProvider;
 ProjectFilesProvider.INTERNAL_NONPROJECT_FILES = ["**/*.ts"];
 yok_1.injector.register("projectFilesProvider", ProjectFilesProvider);
+//# sourceMappingURL=project-files-provider.js.map

package/lib/resolvers/livesync-service-resolver.js

@@ -20,3 +20,4 @@ class LiveSyncServiceResolver {
 }
 exports.LiveSyncServiceResolver = LiveSyncServiceResolver;
 yok_1.injector.register("liveSyncServiceResolver", LiveSyncServiceResolver);
+//# sourceMappingURL=livesync-service-resolver.js.map

package/lib/services/analytics/analytics-broker-process.js

@@ -1,5 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+// NOTE: This file is used to track data in a separate process.
+// The instances here are not shared with the ones in main CLI process.
 const fs = require("fs");
 const analytics_broker_1 = require("./analytics-broker");
 const file_log_service_1 = require("../../detached-processes/file-log-service");
@@ -9,6 +11,7 @@ if (!pathToBootstrap || !fs.existsSync(pathToBootstrap)) {
     throw new Error("Invalid path to bootstrap.");
 }
 const logFile = process.argv[3];
+// After requiring the bootstrap we can use $injector
 require(pathToBootstrap);
 const analyticsLoggingService = yok_1.injector.resolve(file_log_service_1.FileLogService, { logFile });
 analyticsLoggingService.logData({ message: "Initializing AnalyticsBroker." });
@@ -38,15 +41,15 @@ process.on("message", async (data) => {
     analyticsLoggingService.logData({
         message: `analytics-broker-process received message of type: ${JSON.stringify(data)}`,
     });
-    if (data.type === "FinishTracking") {
+    if (data.type === "FinishTracking" /* TrackingTypes.FinishTracking */) {
         await finishTracking();
         if (process.connected) {
             analyticsLoggingService.logData({
-                message: `analytics-broker-process will send ${"ProcessFinishedTasks"} message`,
+                message: `analytics-broker-process will send ${"ProcessFinishedTasks" /* DetachedProcessMessages.ProcessFinishedTasks */} message`,
             });
-            process.send("ProcessFinishedTasks", null, null, () => {
+            process.send("ProcessFinishedTasks" /* DetachedProcessMessages.ProcessFinishedTasks */, null, null, () => {
                 analyticsLoggingService.logData({
-                    message: `analytics-broker-process sent ${"ProcessFinishedTasks"} message and will exit gracefully now`,
+                    message: `analytics-broker-process sent ${"ProcessFinishedTasks" /* DetachedProcessMessages.ProcessFinishedTasks */} message and will exit gracefully now`,
                 });
                 killCurrentProcessGracefully();
             });
@@ -63,6 +66,7 @@ process.on("disconnect", async () => {
     killCurrentProcessGracefully();
 });
 analyticsLoggingService.logData({
-    message: `analytics-broker-process will send ${"ProcessReadyToReceive"} message`,
+    message: `analytics-broker-process will send ${"ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */} message`,
 });
-process.send("ProcessReadyToReceive");
+process.send("ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */);
+//# sourceMappingURL=analytics-broker-process.js.map

package/lib/services/analytics/analytics-broker.js

@@ -29,7 +29,7 @@ class AnalyticsBroker {
         catch (err) {
             this.analyticsLoggingService.logData({
                 message: `AnalyticsBroker unable to execute action in sendDataForTracking: ${err}`,
-                type: "Error",
+                type: "Error" /* FileLogMessageType.Error */,
             });
         }
     }
@@ -38,3 +38,4 @@ exports.AnalyticsBroker = AnalyticsBroker;
 __decorate([
     (0, decorators_1.cache)()
 ], AnalyticsBroker.prototype, "getGoogleAnalyticsProvider", null);
+//# sourceMappingURL=analytics-broker.js.map

package/lib/services/analytics/analytics-service.js

@@ -34,7 +34,7 @@ class AnalyticsService {
     async checkConsent() {
         if (await this.$analyticsSettingsService.canDoRequest()) {
             const initialTrackFeatureUsageStatus = await this.getStatus(this.$staticConfig.TRACK_FEATURE_USAGE_SETTING_NAME);
-            let trackFeatureUsage = initialTrackFeatureUsageStatus === "enabled";
+            let trackFeatureUsage = initialTrackFeatureUsageStatus === "enabled" /* AnalyticsStatus.enabled */;
             if ((await this.isNotConfirmed(this.$staticConfig.TRACK_FEATURE_USAGE_SETTING_NAME)) &&
                 (0, helpers_1.isInteractive)()) {
                 const message = `Do you want to help us improve ${this.$analyticsSettingsService.getClientName()} by automatically sending anonymous usage statistics? We will not use this information to identify or contact you.`;
@@ -53,13 +53,13 @@ class AnalyticsService {
     }
     async setStatus(settingName, enabled) {
         this.analyticsStatuses[settingName] = enabled
-            ? "enabled"
-            : "disabled";
+            ? "enabled" /* AnalyticsStatus.enabled */
+            : "disabled" /* AnalyticsStatus.disabled */;
         await this.$userSettingsService.saveSetting(settingName, enabled.toString());
     }
     async isEnabled(settingName) {
         const analyticsStatus = await this.getStatus(settingName);
-        return analyticsStatus === "enabled";
+        return analyticsStatus === "enabled" /* AnalyticsStatus.enabled */;
     }
     getStatusMessage(settingName, jsonFormat, readableSettingName) {
         if (jsonFormat) {
@@ -70,8 +70,8 @@ class AnalyticsService {
     async trackAcceptFeatureUsage(settings) {
         const acceptTracking = !!(settings && settings.acceptTrackFeatureUsage);
         const googleAnalyticsEventData = {
-            googleAnalyticsDataType: "event",
-            action: "Accept Tracking",
+            googleAnalyticsDataType: "event" /* GoogleAnalyticsDataType.Event */,
+            action: "Accept Tracking" /* TrackActionNames.AcceptTracking */,
             label: acceptTracking.toString(),
         };
         await this.forcefullyTrackInGoogleAnalytics(googleAnalyticsEventData);
@@ -79,7 +79,7 @@ class AnalyticsService {
     async trackInGoogleAnalytics(gaSettings) {
         await this.initAnalyticsStatuses();
         if (!this.$staticConfig.disableAnalytics &&
-            this.analyticsStatuses[this.$staticConfig.TRACK_FEATURE_USAGE_SETTING_NAME] === "enabled") {
+            this.analyticsStatuses[this.$staticConfig.TRACK_FEATURE_USAGE_SETTING_NAME] === "enabled" /* AnalyticsStatus.enabled */) {
             return this.forcefullyTrackInGoogleAnalytics(gaSettings);
         }
     }
@@ -92,6 +92,8 @@ class AnalyticsService {
         const isForDevice = device ? !device.isEmulator : data.isForDevice;
         let label = "";
         label = this.addDataToLabel(label, normalizedPlatform);
+        // In some cases (like in case action is Build and platform is Android), we do not know if the deviceType is emulator or device.
+        // Just exclude the device_type in this case.
         if (isForDevice !== null && isForDevice !== undefined) {
             const deviceType = isForDevice
                 ? constants_1.DeviceTypes.Device
@@ -109,7 +111,7 @@ class AnalyticsService {
         const customDimensions = {};
         this.setProjectRelatedCustomDimensions(customDimensions, data.projectDir);
         const googleAnalyticsEventData = {
-            googleAnalyticsDataType: "event",
+            googleAnalyticsDataType: "event" /* GoogleAnalyticsDataType.Event */,
             action: data.action,
             label,
             customDimensions,
@@ -122,7 +124,7 @@ class AnalyticsService {
             if (this.brokerProcess && this.brokerProcess.connected) {
                 let timer;
                 const handler = (data) => {
-                    if (data === "ProcessFinishedTasks") {
+                    if (data === "ProcessFinishedTasks" /* DetachedProcessMessages.ProcessFinishedTasks */) {
                         this.brokerProcess.removeListener("message", handler);
                         clearTimeout(timer);
                         resolve();
@@ -133,7 +135,7 @@ class AnalyticsService {
                     resolve();
                 }, 3000);
                 this.brokerProcess.on("message", handler);
-                const msg = { type: "FinishTracking" };
+                const msg = { type: "FinishTracking" /* TrackingTypes.FinishTracking */ };
                 this.brokerProcess.send(msg, (err) => this.$logger.trace(`Error while sending ${JSON.stringify(msg)}`));
             }
             else {
@@ -143,13 +145,13 @@ class AnalyticsService {
     }
     forcefullyTrackInGoogleAnalytics(gaSettings) {
         gaSettings.customDimensions = gaSettings.customDimensions || {};
-        gaSettings.customDimensions["cd5"] =
+        gaSettings.customDimensions["cd5" /* GoogleAnalyticsCustomDimensions.client */] =
             this.$options.analyticsClient ||
-                ((0, helpers_1.isInteractive)() ? "CLI" : "Unknown");
+                ((0, helpers_1.isInteractive)() ? "CLI" /* AnalyticsClients.Cli */ : "Unknown" /* AnalyticsClients.Unknown */);
         this.setProjectRelatedCustomDimensions(gaSettings.customDimensions);
         const googleAnalyticsData = _.merge({
-            type: "googleAnalyticsData",
-            category: "CLI",
+            type: "googleAnalyticsData" /* TrackingTypes.GoogleAnalyticsData */,
+            category: "CLI" /* AnalyticsClients.Cli */,
         }, gaSettings);
         this.$logger.trace("Will send the following information to Google Analytics:", googleAnalyticsData);
         return this.sendMessageToBroker(googleAnalyticsData);
@@ -160,14 +162,15 @@ class AnalyticsService {
                 projectDir = this.$projectHelper.projectDir;
             }
             catch (err) {
+                // In case there's no project dir here, the above getter will fail.
                 this.$logger.trace("Unable to get the projectDir from projectHelper", err);
             }
         }
         if (projectDir) {
             const projectData = this.$projectDataService.getProjectData(projectDir);
-            customDimensions["cd2"] =
+            customDimensions["cd2" /* GoogleAnalyticsCustomDimensions.projectType */] =
                 projectData.projectType;
-            customDimensions["cd9"] =
+            customDimensions["cd9" /* GoogleAnalyticsCustomDimensions.isShared */] =
                 projectData.isShared.toString();
         }
         return customDimensions;
@@ -205,7 +208,7 @@ class AnalyticsService {
                 }
             });
             broker.on("message", (data) => {
-                if (data === "ProcessReadyToReceive") {
+                if (data === "ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */) {
                     clearTimeout(timeoutId);
                     if (!isSettled) {
                         isSettled = true;
@@ -229,7 +232,7 @@ class AnalyticsService {
     async sendInfoForTracking(trackingInfo, settingName) {
         await this.initAnalyticsStatuses();
         if (!this.$staticConfig.disableAnalytics &&
-            this.analyticsStatuses[settingName] === "enabled") {
+            this.analyticsStatuses[settingName] === "enabled" /* AnalyticsStatus.enabled */) {
             return this.sendMessageToBroker(trackingInfo);
         }
     }
@@ -277,21 +280,21 @@ class AnalyticsService {
             if (settingValue) {
                 const isEnabled = (0, helpers_1.toBoolean)(settingValue);
                 if (isEnabled) {
-                    this.analyticsStatuses[settingName] = "enabled";
+                    this.analyticsStatuses[settingName] = "enabled" /* AnalyticsStatus.enabled */;
                 }
                 else {
-                    this.analyticsStatuses[settingName] = "disabled";
+                    this.analyticsStatuses[settingName] = "disabled" /* AnalyticsStatus.disabled */;
                 }
             }
             else {
-                this.analyticsStatuses[settingName] = "not confirmed";
+                this.analyticsStatuses[settingName] = "not confirmed" /* AnalyticsStatus.notConfirmed */;
             }
         }
         return this.analyticsStatuses[settingName];
     }
     async isNotConfirmed(settingName) {
         const analyticsStatus = await this.getStatus(settingName);
-        return analyticsStatus === "not confirmed";
+        return analyticsStatus === "not confirmed" /* AnalyticsStatus.notConfirmed */;
     }
     async getHumanReadableStatusMessage(settingName, readableSettingName) {
         let status = null;
@@ -305,14 +308,14 @@ class AnalyticsService {
     }
     async getJsonStatusMessage(settingName) {
         const status = await this.getStatus(settingName);
-        const enabled = status === "not confirmed"
+        const enabled = status === "not confirmed" /* AnalyticsStatus.notConfirmed */
             ? null
-            : status === "enabled";
+            : status === "enabled" /* AnalyticsStatus.enabled */;
         return JSON.stringify({ enabled });
     }
     trackException(exception, message) {
         const data = {
-            type: "exception",
+            type: "exception" /* TrackingTypes.Exception */,
             exception,
             message,
         };
@@ -328,3 +331,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], AnalyticsService.prototype, "initAnalyticsStatuses", null);
 yok_1.injector.register("analyticsService", AnalyticsService);
+//# sourceMappingURL=analytics-service.js.map

package/lib/services/analytics/google-analytics-provider.js

@@ -29,7 +29,7 @@ class GoogleAnalyticsProvider {
         }
         catch (e) {
             this.analyticsLoggingService.logData({
-                type: "Error",
+                type: "Error" /* FileLogMessageType.Error */,
                 message: `Unable to track information ${JSON.stringify(trackInfo)}. Error is: ${e}`,
             });
             this.$logger.trace("Analytics exception: ", e);
@@ -61,23 +61,23 @@ class GoogleAnalyticsProvider {
         const visitor = this.getVisitor(gaTrackingId, proxy);
         await this.setCustomDimensions(visitor, trackInfo.customDimensions, sessionId);
         switch (trackInfo.googleAnalyticsDataType) {
-            case "pageview":
+            case "pageview" /* GoogleAnalyticsDataType.Page */:
                 await this.trackPageView(visitor, trackInfo);
                 break;
-            case "event":
+            case "event" /* GoogleAnalyticsDataType.Event */:
                 await this.trackEvent(visitor, trackInfo);
                 break;
         }
     }
     async setCustomDimensions(visitor, customDimensions, sessionId) {
         const defaultValues = {
-            ["cd1"]: this.$staticConfig.version,
-            ["cd6"]: process.version,
-            ["cd3"]: this.clientId,
-            ["cd2"]: null,
-            ["cd9"]: null,
-            ["cd4"]: sessionId,
-            ["cd5"]: "Unknown",
+            ["cd1" /* GoogleAnalyticsCustomDimensions.cliVersion */]: this.$staticConfig.version,
+            ["cd6" /* GoogleAnalyticsCustomDimensions.nodeVersion */]: process.version,
+            ["cd3" /* GoogleAnalyticsCustomDimensions.clientID */]: this.clientId,
+            ["cd2" /* GoogleAnalyticsCustomDimensions.projectType */]: null,
+            ["cd9" /* GoogleAnalyticsCustomDimensions.isShared */]: null,
+            ["cd4" /* GoogleAnalyticsCustomDimensions.sessionID */]: sessionId,
+            ["cd5" /* GoogleAnalyticsCustomDimensions.client */]: "Unknown" /* AnalyticsClients.Unknown */,
         };
         customDimensions = _.merge(defaultValues, customDimensions);
         _.each(customDimensions, (value, key) => {
@@ -94,7 +94,7 @@ class GoogleAnalyticsProvider {
                     this.analyticsLoggingService.logData({
                         message: `Unable to track event with category: '${trackInfo.category}', action: '${trackInfo.action}', label: '${trackInfo.label}', ` +
                             `value: '${trackInfo.value}' attached page: ${this.currentPage}. Error is: ${err}.`,
-                        type: "Error",
+                        type: "Error" /* FileLogMessageType.Error */,
                     });
                     reject(err);
                     return;
@@ -117,7 +117,7 @@ class GoogleAnalyticsProvider {
                 if (err) {
                     this.analyticsLoggingService.logData({
                         message: `Unable to track pageview with path '${trackInfo.path}' and title: '${trackInfo.title}' Error is: ${err}.`,
-                        type: "Error",
+                        type: "Error" /* FileLogMessageType.Error */,
                     });
                     reject(err);
                     return;
@@ -135,3 +135,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], GoogleAnalyticsProvider.prototype, "getVisitor", null);
 yok_1.injector.register("googleAnalyticsProvider", GoogleAnalyticsProvider);
+//# sourceMappingURL=google-analytics-provider.js.map

package/lib/services/analytics-settings-service.js

@@ -62,6 +62,10 @@ class AnalyticsSettingsService {
         return userAgent;
     }
     getMacOSReleaseVersion(osRelease) {
+        // https://en.wikipedia.org/wiki/Darwin_(operating_system)#Release_history
+        // Each macOS version is labeled 10.<version>, where it looks like <versions> is taken from the major version returned by os.release() (16.x.x for example) and subtracting 4 from it.
+        // So the version becomes "10.12" in this case.
+        // Could be improved by spawning `system_profiler SPSoftwareDataType` and getting the System Version line from the result.
         const majorVersion = osRelease && _.first(osRelease.split("."));
         return majorVersion && `10.${+majorVersion - 4}`;
     }
@@ -86,3 +90,4 @@ __decorate([
     (0, decorators_1.exported)("analyticsSettingsService")
 ], AnalyticsSettingsService.prototype, "getUserAgentString", null);
 yok_1.injector.register("analyticsSettingsService", AnalyticsSettingsService);
+//# sourceMappingURL=analytics-settings-service.js.map

package/lib/services/android/android-bundle-tool-service.js

@@ -62,3 +62,4 @@ class AndroidBundleToolService {
 }
 exports.AndroidBundleToolService = AndroidBundleToolService;
 yok_1.injector.register("androidBundleToolService", AndroidBundleToolService);
+//# sourceMappingURL=android-bundle-tool-service.js.map

package/lib/services/android/gradle-build-args-service.js

@@ -18,6 +18,7 @@ class GradleBuildArgsService {
         if (await this.$analyticsService.isEnabled(this.$staticConfig.TRACK_FEATURE_USAGE_SETTING_NAME)) {
             args.push("-PgatherAnalyticsData=true");
         }
+        // allow modifying gradle args from a `before-build-task-args` hook
         await this.$hooksService.executeBeforeHooks("build-task-args", {
             hookArgs: { args },
         });
@@ -30,6 +31,7 @@ class GradleBuildArgsService {
     }
     getBaseTaskArgs(buildData) {
         const args = this.getBuildLoggingArgs();
+        // ensure we initialize project data
         this.$projectData.initializeProjectData(buildData.projectDir);
         args.push(`-PappPath=${this.$projectData.getAppDirectoryPath()}`, `-PappResourcesPath=${this.$projectData.getAppResourcesDirectoryPath()}`);
         if (buildData.gradleArgs) {
@@ -61,3 +63,4 @@ class GradleBuildArgsService {
 }
 exports.GradleBuildArgsService = GradleBuildArgsService;
 yok_1.injector.register("gradleBuildArgsService", GradleBuildArgsService);
+//# sourceMappingURL=gradle-build-args-service.js.map

package/lib/services/android/gradle-build-service.js

@@ -39,3 +39,4 @@ class GradleBuildService extends events_1.EventEmitter {
 }
 exports.GradleBuildService = GradleBuildService;
 yok_1.injector.register("gradleBuildService", GradleBuildService);
+//# sourceMappingURL=gradle-build-service.js.map

package/lib/services/android/gradle-command-service.js

@@ -38,3 +38,4 @@ class GradleCommandService {
 }
 exports.GradleCommandService = GradleCommandService;
 yok_1.injector.register("gradleCommandService", GradleCommandService);
+//# sourceMappingURL=gradle-command-service.js.map

package/lib/services/android-device-debug-service.js

@@ -33,6 +33,7 @@ class AndroidDeviceDebugService extends debug_service_base_1.DebugServiceBase {
     async debug(debugData, debugOptions) {
         this._packageName = debugData.applicationIdentifier;
         const result = await this.debugCore(debugData.applicationIdentifier, debugOptions);
+        // TODO: extract this logic outside the debug service
         if (debugOptions.start && !debugOptions.justlaunch) {
             const pid = await this.$androidProcessService.getAppProcessId(this.deviceIdentifier, debugData.applicationIdentifier);
             if (pid) {
@@ -55,6 +56,7 @@ class AndroidDeviceDebugService extends debug_service_base_1.DebugServiceBase {
             `tcp:${port}`,
         ]);
     }
+    // TODO: Remove this method and reuse logic from androidProcessService
     async getForwardedDebugPort(deviceId, packageName) {
         let port = -1;
         const forwardsResult = await this.device.adb.executeCommand([
@@ -62,6 +64,7 @@ class AndroidDeviceDebugService extends debug_service_base_1.DebugServiceBase {
             "--list",
         ]);
         const unixSocketName = `${packageName}-inspectorServer`;
+        //matches 123a188909e6czzc tcp:40001 localabstract:org.nativescript.testUnixSockets-debug
         const regexp = new RegExp(`(?:${deviceId} tcp:)([\\d]+)(?= localabstract:${unixSocketName})`, "g");
         const match = regexp.exec(forwardsResult);
         if (match) {
@@ -77,6 +80,7 @@ class AndroidDeviceDebugService extends debug_service_base_1.DebugServiceBase {
         });
         return port;
     }
+    // TODO: Remove this method and reuse logic from androidProcessService
     async unixSocketForward(local, remote) {
         await this.device.adb.executeCommand([
             "forward",
@@ -102,6 +106,7 @@ class AndroidDeviceDebugService extends debug_service_base_1.DebugServiceBase {
     async printDebugPort(deviceId, port) {
         this.$logger.info("device: " + deviceId + " debug port: " + port + "\n");
     }
+    // TODO: extract this logic outside the debug service
     async validateRunningApp(deviceId, packageName) {
         if (!(await this.isAppRunning(packageName, deviceId))) {
             this.$errors.fail(`The application ${packageName} does not appear to be running on ${deviceId} or is not built with debugging enabled. Try starting the application manually.`);
@@ -144,3 +149,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], AndroidDeviceDebugService.prototype, "debugCore", null);
 yok_1.injector.register("androidDeviceDebugService", AndroidDeviceDebugService, false);
+//# sourceMappingURL=android-device-debug-service.js.map

package/lib/services/android-plugin-build-service.js

@@ -54,12 +54,15 @@ class AndroidPluginBuildService {
     async updateManifestContent(oldManifestContent, defaultPackageName) {
         let xml = await this.getXml(oldManifestContent);
         let packageName = defaultPackageName;
+        // if the manifest file is full-featured and declares settings inside the manifest scope
         if (xml["manifest"]) {
             if (xml["manifest"]["$"]["package"]) {
                 packageName = xml["manifest"]["$"]["package"];
             }
+            // set the xml as the value to iterate over its properties
             xml = xml["manifest"];
         }
+        // if the manifest file doesn't have a <manifest> scope, only the first setting will be picked up
         const newManifest = { manifest: {} };
         for (const prop in xml) {
             newManifest.manifest[prop] = xml[prop];
@@ -132,6 +135,14 @@ class AndroidPluginBuildService {
         }
         return result;
     }
+    /**
+     * Returns whether the build has completed or not
+     * @param {Object} options
+     * @param {string} options.pluginName - The name of the plugin. E.g. 'nativescript-barcodescanner'
+     * @param {string} options.platformsAndroidDirPath - The path to the 'plugin/src/platforms/android' directory.
+     * @param {string} options.aarOutputDir - The path where the aar should be copied after a successful build.
+     * @param {string} options.tempPluginDirPath - The path where the android plugin will be built.
+     */
     async buildAar(options) {
         this.validateOptions(options);
         const manifestFilePath = this.getManifest(options.platformsAndroidDirPath);
@@ -167,6 +178,7 @@ class AndroidPluginBuildService {
         return shouldBuildAar;
     }
     cleanPluginDir(pluginTempDir) {
+        // In case plugin was already built in the current process, we need to clean the old sources as they may break the new build.
         this.$fs.deleteDirectory(pluginTempDir);
         this.$fs.ensureDirectoryExists(pluginTempDir);
     }
@@ -240,6 +252,7 @@ class AndroidPluginBuildService {
         this.replaceGradleAndroidPluginVersion(buildGradlePath, runtimeGradleVersions.gradleAndroidPluginVersion);
         this.replaceFileContent(buildGradlePath, "{{pluginName}}", pluginName);
         this.replaceFileContent(settingsGradlePath, "{{pluginName}}", pluginName);
+        // gets the package from the AndroidManifest to use as the namespace or fallback to the `org.nativescript.${shortPluginName}`
         const shortPluginName = (0, helpers_1.getShortPluginName)(pluginName);
         const manifestPath = path.join(pluginTempDir, "src", "main", "AndroidManifest.xml");
         const manifestContent = this.$fs.readText(manifestPath);
@@ -286,6 +299,7 @@ class AndroidPluginBuildService {
         return runtimeVersion;
     }
     getLocalGradleVersions() {
+        // try reading from installed runtime first before reading from the npm registry...
         const installedRuntimePackageJSONPath = (0, resolve_package_path_1.resolvePackageJSONPath)(constants_1.SCOPED_ANDROID_RUNTIME_NAME, {
             paths: [this.$projectData.projectDir],
         });
@@ -319,13 +333,23 @@ class AndroidPluginBuildService {
         if (localVersionInfo) {
             return localVersionInfo;
         }
+        // fallback to reading from npm...
         try {
             let output = await this.$packageManager.view(`${constants_1.SCOPED_ANDROID_RUNTIME_NAME}@${runtimeVersion}`, { version_info: true });
             output = (_a = output === null || output === void 0 ? void 0 : output["version_info"]) !== null && _a !== void 0 ? _a : output;
             if (!output) {
+                /**
+                 * fallback to the old 'gradle' key in package.json
+                 *
+                 * format:
+                 *
+                 * gradle: { version: '6.4', android: '3.6.4' }
+                 *
+                 */
                 output = await this.$packageManager.view(`${constants_1.SCOPED_ANDROID_RUNTIME_NAME}@${runtimeVersion}`, { gradle: true });
                 output = (_b = output === null || output === void 0 ? void 0 : output["gradle"]) !== null && _b !== void 0 ? _b : output;
                 const { version, android } = output;
+                // covert output to the new format...
                 output = {
                     gradle: version,
                     gradleAndroid: android,
@@ -397,6 +421,10 @@ class AndroidPluginBuildService {
             this.$errors.fail(`No built aar found at ${pathToBuiltAar}`);
         }
     }
+    /**
+     * @param {Object} options
+     * @param {string} options.platformsAndroidDirPath - The path to the 'plugin/src/platforms/android' directory.
+     */
     migrateIncludeGradle(options) {
         this.validatePlatformsAndroidDirPathOption(options);
         const includeGradleFilePath = path.join(options.platformsAndroidDirPath, constants_1.INCLUDE_GRADLE_NAME);
@@ -449,8 +477,8 @@ class AndroidPluginBuildService {
         };
         if (this.$options.hostProjectPath) {
             opts.env = {
-                USER_PROJECT_PLATFORMS_ANDROID: path.resolve((0, process_1.cwd)(), this.$options.hostProjectPath),
-                ...process.env,
+                USER_PROJECT_PLATFORMS_ANDROID: path.resolve((0, process_1.cwd)(), this.$options.hostProjectPath), // TODO: couldn't `hostProjectPath` have an absolute path already?
+                ...process.env, // TODO: any other way to pass automatically the current process.env?
             };
         }
         try {
@@ -497,3 +525,4 @@ __decorate([
     (0, helpers_1.hook)("buildAndroidPlugin")
 ], AndroidPluginBuildService.prototype, "buildPlugin", null);
 yok_1.injector.register("androidPluginBuildService", AndroidPluginBuildService);
+//# sourceMappingURL=android-plugin-build-service.js.map